puppet_litmus 0.36.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9a130b9a5ccaf0b18f53a163b9e65dd207eef1fbe23db2921df3b4b534f44ab
-  data.tar.gz: b2f1d8367e536d2f83104b839438e26e7cfc4da9f06ba714730e7dbbb2de6f6c
+  metadata.gz: 8f2e5cb7497ccf31dbdb164f7a408c92940831f6e46b5ec5dc6b369bc39b8277
+  data.tar.gz: 1f38af54816bb26cd8787c9e209afe7b3f1589355cb324c60eb3ca9fcde05dc4
 SHA512:
-  metadata.gz: 9e5852a7557b51cf4ee81a50d169d58a7de90aebb6f4c0f53258274632b49f7e8d93175176b60b3435023326df6cabf27f68d10209d5bfdf100911f32a438869
-  data.tar.gz: 4c70b9fb01b6a32b374e287d2a8444896d31d9d38a0a8b7e18cc1cc10f5b531fcfad811a8269f707b9cc05f7085a5f94f94c28acf84a0a5858ebe5ef43db1e4f
+  metadata.gz: 0cdcccf05f113f0ea462ceac7709c5299a622b1343d6ed8fd1f26dc51122e7068bb7f7ab5808fd5f052e83d4f9efc1631b7a69d933e3078b32fbec335ea91de6
+  data.tar.gz: 12f93057558409cad13d67b705f1a7a021d470f8885e4fe8421591eb091dc1a8869e2637d95991a5efb77348c0a96abecda1d22ad047aa8ae5be75a61cfa78a7

data/exe/matrix_from_metadata

@@ -31,7 +31,7 @@ IMAGE_TABLE = {
   'SLES-15' => 'sles-15',
   'Windows-2012 R2' => 'windows-2012-r2-core',
   'Windows-2016' => 'windows-2016',
-  'Windows-2019' => 'windows-2019-core',
+  'Windows-2019' => 'windows-2019-core'
 }.freeze
 
 DOCKER_PLATFORMS = [
@@ -48,26 +48,26 @@ DOCKER_PLATFORMS = [
   'Ubuntu-14.04',
   'Ubuntu-16.04',
   'Ubuntu-18.04',
-  'Ubuntu-20.04',
+  'Ubuntu-20.04'
 ].freeze
 
 # This table uses the latest version in each collection for accurate
 # comparison when evaluating puppet requirements from the metadata
 COLLECTION_TABLE = {
   '6.21.0' => 'puppet6-nightly',
-  '7.4.0' => 'puppet7-nightly',
+  '7.4.0' => 'puppet7-nightly'
 }.freeze
 
 matrix = {
   platform: [],
-  collection: [],
+  collection: []
 }
 
 metadata = JSON.parse(File.read('metadata.json'))
 # Set platforms based on declared operating system support
 metadata['operatingsystem_support'].sort_by { |a| a['operatingsystem'] }.each do |sup|
   os = sup['operatingsystem']
-  sup['operatingsystemrelease'].sort_by { |a| a.to_i }.each do |ver|
+  sup['operatingsystemrelease'].sort_by(&:to_i).each do |ver|
     image_key = "#{os}-#{ver}"
     if IMAGE_TABLE.key? image_key
       matrix[:platform] << IMAGE_TABLE[image_key]
@@ -84,7 +84,7 @@ if metadata.key?('requirements') && metadata['requirements'].length.positive?
   metadata['requirements'].each do |req|
     next unless req.key?('name') && req.key?('version_requirement') && req['name'] == 'puppet'
 
-    ver_regexp = %r{^([>=<]{1,2})\s*([\d.]+)\s+([>=<]{1,2})\s*([\d.]+)$}
+    ver_regexp = /^([>=<]{1,2})\s*([\d.]+)\s+([>=<]{1,2})\s*([\d.]+)$/
     match = ver_regexp.match(req['version_requirement'])
     if match.nil?
       puts "::warning::Didn't recognize version_requirement '#{req['version_requirement']}'"
@@ -95,17 +95,13 @@ if metadata.key?('requirements') && metadata['requirements'].length.positive?
     reqs = ["#{cmp_one} #{ver_one}", "#{cmp_two} #{ver_two}"]
 
     COLLECTION_TABLE.each do |key, val|
-      if Gem::Requirement.create(reqs).satisfied_by?(Gem::Version.new(key))
-        matrix[:collection] << val
-      end
+      matrix[:collection] << val if Gem::Requirement.create(reqs).satisfied_by?(Gem::Version.new(key))
     end
   end
 end
 
 # Set to defaults (all collections) if no matches are found
-if matrix[:collection].empty?
-  matrix[:collection] = COLLECTION_TABLE.values
-end
+matrix[:collection] = COLLECTION_TABLE.values if matrix[:collection].empty?
 
 # Just to make sure there aren't any duplicates
 matrix[:platform] = matrix[:platform].uniq.sort

data/exe/matrix_from_metadata_v2

@@ -32,7 +32,7 @@ IMAGE_TABLE = {
   'SLES-15' => 'sles-15',
   'Windows-2016' => 'windows-2016',
   'Windows-2019' => 'windows-2019',
-  'Windows-2022' => 'windows-2022',
+  'Windows-2022' => 'windows-2022'
 }.freeze
 
 DOCKER_PLATFORMS = {
@@ -53,44 +53,40 @@ DOCKER_PLATFORMS = {
   # 'Ubuntu-16.04' => 'litmusimage/ubuntu:16.04', Support Dropped
   'Ubuntu-18.04' => 'litmusimage/ubuntu:18.04',
   'Ubuntu-20.04' => 'litmusimage/ubuntu:20.04',
-  'Ubuntu-22.04' => 'litmusimage/ubuntu:22.04',
+  'Ubuntu-22.04' => 'litmusimage/ubuntu:22.04'
 }.freeze
 
 # This table uses the latest version in each collection for accurate
 # comparison when evaluating puppet requirements from the metadata
 COLLECTION_TABLE = [
-  {
-    puppet_maj_version: 6,
-    ruby_version: 2.5,
-  },
   {
     puppet_maj_version: 7,
-    ruby_version: 2.7,
+    ruby_version: 2.7
   },
   {
     puppet_maj_version: 8,
-    ruby_version: 3.2,
-  },
+    ruby_version: 3.2
+  }
 ].freeze
 
 matrix = {
   platforms: [],
-  collection: [],
+  collection: []
 }
 
 spec_matrix = {
-  include: [],
+  include: []
 }
 
 if ARGV.include?('--exclude-platforms')
-  exclude_platforms_occurencies = ARGV.select { |arg| arg == '--exclude-platforms' }.length
+  exclude_platforms_occurencies = ARGV.count { |arg| arg == '--exclude-platforms' }
   raise '--exclude-platforms argument should be present just one time in the command' unless exclude_platforms_occurencies <= 1
 
   exclude_platforms_list = ARGV[ARGV.find_index('--exclude-platforms') + 1]
   raise 'you need to provide a list of platforms in JSON format' if exclude_platforms_list.nil?
 
   begin
-    exclude_list = JSON.parse(exclude_platforms_list).map { |platform| platform.downcase }
+    exclude_list = JSON.parse(exclude_platforms_list).map(&:downcase)
   rescue JSON::ParserError
     raise 'the exclude platforms list must valid JSON'
   end
@@ -103,20 +99,20 @@ metadata = JSON.parse(File.read(metadata_path))
 # Set platforms based on declared operating system support
 metadata['operatingsystem_support'].sort_by { |a| a['operatingsystem'] }.each do |sup|
   os = sup['operatingsystem']
-  sup['operatingsystemrelease'].sort_by { |a| a.to_i }.each do |ver|
+  sup['operatingsystemrelease'].sort_by(&:to_i).each do |ver|
     image_key = "#{os}-#{ver}"
 
     if IMAGE_TABLE.key?(image_key) && !exclude_list.include?(image_key.downcase)
       matrix[:platforms] << {
         label: image_key,
         provider: 'provision::provision_service',
-        image: IMAGE_TABLE[image_key],
+        image: IMAGE_TABLE[image_key]
       }
     elsif DOCKER_PLATFORMS.key?(image_key) && !exclude_list.include?(image_key.downcase)
       matrix[:platforms] << {
         label: image_key,
         provider: 'provision::docker',
-        image: DOCKER_PLATFORMS[image_key],
+        image: DOCKER_PLATFORMS[image_key]
       }
     else
       puts "::warning::#{image_key} was excluded from testing" if exclude_list.include?(image_key.downcase)
@@ -130,7 +126,7 @@ if metadata.key?('requirements') && metadata['requirements'].length.positive?
   metadata['requirements'].each do |req|
     next unless req.key?('name') && req.key?('version_requirement') && req['name'] == 'puppet'
 
-    ver_regexp = %r{^([>=<]{1,2})\s*([\d.]+)\s+([>=<]{1,2})\s*([\d.]+)$}
+    ver_regexp = /^([>=<]{1,2})\s*([\d.]+)\s+([>=<]{1,2})\s*([\d.]+)$/
     match = ver_regexp.match(req['version_requirement'])
     if match.nil?
       puts "::warning::Didn't recognize version_requirement '#{req['version_requirement']}'"
@@ -156,12 +152,10 @@ if metadata.key?('requirements') && metadata['requirements'].length.positive?
 end
 
 # Set to defaults (all collections) if no matches are found
-if matrix[:collection].empty?
-  matrix[:collection] = COLLECTION_TABLE.map { |collection| "puppet#{collection[:puppet_maj_version]}-nightly" }
-end
+matrix[:collection] = COLLECTION_TABLE.map { |collection| "puppet#{collection[:puppet_maj_version]}-nightly" } if matrix[:collection].empty?
 
 # Just to make sure there aren't any duplicates
-matrix[:platforms] = matrix[:platforms].uniq.sort { |a, b| a[:label] <=> b[:label] }
+matrix[:platforms] = matrix[:platforms].uniq.sort_by { |a| a[:label] }
 matrix[:collection] = matrix[:collection].uniq.sort
 
 set_output('matrix', JSON.generate(matrix))

data/lib/puppet_litmus/inventory_manipulation.rb

@@ -32,11 +32,11 @@ module PuppetLitmus::InventoryManipulation
             {
               'uri' => 'litmus_localhost',
               'config' => { 'transport' => 'local' },
-              'feature' => 'puppet-agent',
-            },
-          ],
-        },
-      ],
+              'feature' => 'puppet-agent'
+            }
+          ]
+        }
+      ]
     }
   end
 
@@ -47,7 +47,7 @@ module PuppetLitmus::InventoryManipulation
   # @return [Array] array of targets.
   def find_targets(inventory_hash, targets)
     if targets.nil?
-      inventory_hash.to_s.scan(%r{uri"=>"(\S*)"}).flatten
+      inventory_hash.to_s.scan(/uri"=>"(\S*)"/).flatten
     else
       [targets]
     end
@@ -62,7 +62,7 @@ module PuppetLitmus::InventoryManipulation
   def groups_in_inventory(inventory_hash, &block)
     inventory_hash['groups'].flat_map do |group|
       output_collector = []
-      output_collector << if block_given?
+      output_collector << if block
                             yield group
                           else
                             group['name'].downcase
@@ -104,7 +104,7 @@ module PuppetLitmus::InventoryManipulation
     targets_in_inventory(inventory) do |target|
       vars = target['vars']
       roles = [(vars['role'] || vars['roles'])].flatten
-      roles = roles.map { |r| r.downcase }
+      roles = roles.map(&:downcase)
       output_collector << target['uri'] if roles.include? role.downcase
     end
     output_collector unless output_collector.empty?
@@ -166,7 +166,7 @@ module PuppetLitmus::InventoryManipulation
   # @return [Hash] config for node of name node_name
   def config_from_node(inventory_hash, node_name)
     config = targets_in_inventory(inventory_hash) do |target|
-      next unless target['uri'].downcase == node_name.downcase
+      next unless target['uri'].casecmp(node_name).zero?
 
       return target['config'] unless target['config'].nil?
     end
@@ -181,7 +181,7 @@ module PuppetLitmus::InventoryManipulation
   # @return [Hash] facts for node of name node_name
   def facts_from_node(inventory_hash, node_name)
     facts = targets_in_inventory(inventory_hash) do |target|
-      next unless target['uri'].downcase == node_name.downcase
+      next unless target['uri'].casecmp(node_name).zero?
 
       target['facts'] unless target['facts'].nil?
     end
@@ -196,7 +196,7 @@ module PuppetLitmus::InventoryManipulation
   # @return [Hash] vars for node of name node_name
   def vars_from_node(inventory_hash, node_name)
     vars = targets_in_inventory(inventory_hash) do |target|
-      next unless target['uri'].downcase == node_name.downcase
+      next unless target['uri'].casecmp(node_name).zero?
 
       target['vars'] unless target['vars'].nil?
     end
@@ -213,9 +213,7 @@ module PuppetLitmus::InventoryManipulation
     # check if group exists
     if inventory_hash['groups'].any? { |g| g['name'] == group_name }
       inventory_hash['groups'].each do |group|
-        if group['name'] == group_name
-          group['targets'].push node
-        end
+        group['targets'].push node if group['name'] == group_name
       end
     else
       # add new group
@@ -248,9 +246,7 @@ module PuppetLitmus::InventoryManipulation
     i = 0
     inventory_hash['groups'].each do |group|
       if group['name'] == group_name
-        if group['features'].nil? == true
-          group = group.merge('features' => [])
-        end
+        group = group.merge('features' => []) if group['features'].nil? == true
         group['features'].push feature_name unless group['features'].include?(feature_name)
         inventory_hash['groups'][i] = group
       end
@@ -268,9 +264,7 @@ module PuppetLitmus::InventoryManipulation
   # @return [Hash] inventory_hash with feature added to group if group_name exists in inventory hash.
   def remove_feature_from_group(inventory_hash, feature_name, group_name)
     inventory_hash['groups'].each do |group|
-      if group['name'] == group_name && group['features'].nil? != true
-        group['features'].delete(feature_name)
-      end
+      group['features'].delete(feature_name) if group['name'] == group_name && group['features'].nil? != true
     end
     inventory_hash
   end
@@ -288,9 +282,7 @@ module PuppetLitmus::InventoryManipulation
       node_index = 0
       group['targets'].each do |node|
         if node['uri'] == node_name
-          if node['features'].nil? == true
-            node = node.merge('features' => [])
-          end
+          node = node.merge('features' => []) if node['features'].nil? == true
           node['features'].push feature_name unless node['features'].include?(feature_name)
           inventory_hash['groups'][group_index]['targets'][node_index] = node
         end
@@ -311,9 +303,7 @@ module PuppetLitmus::InventoryManipulation
   def remove_feature_from_node(inventory_hash, feature_name, node_name)
     inventory_hash['groups'].each do |group|
       group['targets'].each do |node|
-        if node['uri'] == node_name && node['features'].nil? != true
-          node['features'].delete(feature_name)
-        end
+        node['features'].delete(feature_name) if node['uri'] == node_name && node['features'].nil? != true
       end
     end
     inventory_hash

data/lib/puppet_litmus/puppet_helpers.rb

@@ -54,7 +54,7 @@ module PuppetLitmus::PuppetHelpers
       span.add_field('litmus.manifest', manifest)
       span.add_field('litmus.opts', opts)
 
-      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV['TARGET_HOST']
+      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV.fetch('TARGET_HOST', nil)
       raise 'manifest and manifest_file_location in the opts hash are mutually exclusive arguments, pick one' if !manifest.nil? && !opts[:manifest_file_location].nil?
       raise 'please pass a manifest or the manifest_file_location in the opts hash' if (manifest.nil? || manifest == '') && opts[:manifest_file_location].nil?
       raise 'please specify only one of `catch_changes`, `expect_changes`, `catch_failures` or `expect_failures`' if
@@ -92,10 +92,10 @@ module PuppetLitmus::PuppetHelpers
       add_node_fields_to_span(span, target_node_name, inventory_hash)
 
       # Forcibly set the locale of the command
-      locale = if os[:family] != 'windows'
-                 'LC_ALL=en_US.UTF-8 '
-               else
+      locale = if os[:family] == 'windows'
                  ''
+               else
+                 'LC_ALL=en_US.UTF-8 '
                end
       command_to_run = "#{locale}#{opts[:prefix_command]} puppet apply #{manifest_file_location}"
       command_to_run += ' --trace' if !opts[:trace].nil? && (opts[:trace] == true)
@@ -154,7 +154,7 @@ module PuppetLitmus::PuppetHelpers
       span.add_field('litmus.manifest', manifest)
 
       require 'tmpdir'
-      target_node_name = ENV['TARGET_HOST']
+      target_node_name = ENV.fetch('TARGET_HOST', nil)
       tmp_filename = File.join(Dir.tmpdir, "manifest_#{Time.now.strftime('%Y%m%d')}_#{Process.pid}_#{rand(0x100000000).to_s(36)}.pp")
       manifest_file = File.open(tmp_filename, 'w')
       manifest_file.write(manifest)
@@ -193,7 +193,7 @@ module PuppetLitmus::PuppetHelpers
 
       require 'tmpdir'
       inventory_hash = inventory_hash_from_inventory_file
-      target_node_name = ENV['TARGET_HOST']
+      target_node_name = ENV.fetch('TARGET_HOST', nil)
       target_option = opts['targets'] || opts[:targets]
       target_node_name = search_for_target(target_option, inventory_hash) unless target_option.nil?
 
@@ -234,7 +234,7 @@ module PuppetLitmus::PuppetHelpers
 
       target_option = opts['targets'] || opts[:targets]
       if target_option.nil?
-        target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV['TARGET_HOST']
+        target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV.fetch('TARGET_HOST', nil)
         raise "Target '#{target_node_name}' not found in spec/fixtures/litmus_inventory.yaml" unless target_in_inventory?(inventory_hash, target_node_name)
       else
         target_node_name = search_for_target(target_option, inventory_hash)
@@ -245,9 +245,7 @@ module PuppetLitmus::PuppetHelpers
       bolt_result = run_command(command_to_run, target_node_name, config: nil, inventory: inventory_hash)
       span.add_field('litmus.bolt_result', bolt_result)
 
-      if bolt_result.first['value']['exit_code'] != 0 && opts[:expect_failures] != true
-        raise "shell failed\n`#{command_to_run}`\n======\n#{bolt_result}"
-      end
+      raise "shell failed\n`#{command_to_run}`\n======\n#{bolt_result}" if bolt_result.first['value']['exit_code'] != 0 && opts[:expect_failures] != true
 
       result = OpenStruct.new(exit_code: bolt_result.first['value']['exit_code'],
                               exit_status: bolt_result.first['value']['exit_code'],
@@ -277,7 +275,7 @@ module PuppetLitmus::PuppetHelpers
       inventory_hash = File.exist?('spec/fixtures/litmus_inventory.yaml') ? inventory_hash_from_inventory_file : localhost_inventory_hash
       target_option = opts['targets'] || opts[:targets]
       if target_option.nil?
-        target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV['TARGET_HOST']
+        target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV.fetch('TARGET_HOST', nil)
         raise "Target '#{target_node_name}' not found in spec/fixtures/litmus_inventory.yaml" unless target_in_inventory?(inventory_hash, target_node_name)
       else
         target_node_name = search_for_target(target_option, inventory_hash)
@@ -292,7 +290,7 @@ module PuppetLitmus::PuppetHelpers
         exit_code: 0,
         stdout: bolt_result.first['value']['_output'],
         stderr: nil,
-        result: bolt_result.first['value'],
+        result: bolt_result.first['value']
       }
 
       if bolt_result.first['status'] != 'success'
@@ -330,7 +328,7 @@ module PuppetLitmus::PuppetHelpers
       span.add_field('litmus.opts', opts)
 
       config_data = { 'modulepath' => File.join(Dir.pwd, 'spec', 'fixtures', 'modules') }
-      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV['TARGET_HOST']
+      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV.fetch('TARGET_HOST', nil)
       inventory_hash = if !opts[:inventory_file].nil? && File.exist?(opts[:inventory_file])
                          inventory_hash_from_inventory_file(opts[:inventory_file])
                        elsif File.exist?('spec/fixtures/litmus_inventory.yaml')
@@ -353,7 +351,7 @@ module PuppetLitmus::PuppetHelpers
         exit_code: 0,
         stdout: nil,
         stderr: nil,
-        result: bolt_result.first['value'],
+        result: bolt_result.first['value']
       }
 
       if bolt_result.first['status'] == 'success'
@@ -402,7 +400,7 @@ module PuppetLitmus::PuppetHelpers
       span.add_field('litmus.opts', opts)
       span.add_field('litmus.arguments', arguments)
 
-      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV['TARGET_HOST']
+      target_node_name = targeting_localhost? ? 'litmus_localhost' : ENV.fetch('TARGET_HOST', nil)
       inventory_hash = File.exist?('spec/fixtures/litmus_inventory.yaml') ? inventory_hash_from_inventory_file : localhost_inventory_hash
       target_option = opts['targets'] || opts[:targets]
       if target_option.nil?

data/lib/puppet_litmus/rake_helper.rb

@@ -5,11 +5,9 @@ require 'honeycomb-beeline'
 require 'puppet_litmus/version'
 Honeycomb.configure do |config|
   # override client if no configuration is provided, so that the pesky libhoney warning about lack of configuration is not shown
-  unless ENV['HONEYCOMB_WRITEKEY'] && ENV['HONEYCOMB_DATASET']
-    config.client = Libhoney::NullClient.new
-  end
+  config.client = Libhoney::NullClient.new unless ENV['HONEYCOMB_WRITEKEY'] && ENV['HONEYCOMB_DATASET']
 end
-process_span = Honeycomb.start_span(name: "litmus: #{([$PROGRAM_NAME] + ($ARGV || [])).join(' ')}", serialized_trace: ENV['HONEYCOMB_TRACE'])
+process_span = Honeycomb.start_span(name: "litmus: #{([$PROGRAM_NAME] + ($ARGV || [])).join(' ')}", serialized_trace: ENV.fetch('HONEYCOMB_TRACE', nil))
 ENV['HONEYCOMB_TRACE'] = process_span.to_trace_header
 Honeycomb.add_field_to_trace('litmus.pid', Process.pid)
 if defined? PuppetLitmus::VERSION
@@ -18,27 +16,27 @@ else
   Honeycomb.add_field_to_trace('litmus.version', 'undefined')
 end
 if ENV['CI'] == 'true' && ENV['TRAVIS'] == 'true'
-  Honeycomb.add_field_to_trace('module_name', ENV['TRAVIS_REPO_SLUG'])
+  Honeycomb.add_field_to_trace('module_name', ENV.fetch('TRAVIS_REPO_SLUG', nil))
   Honeycomb.add_field_to_trace('ci.provider', 'travis')
-  Honeycomb.add_field_to_trace('ci.build_id', ENV['TRAVIS_BUILD_ID'])
-  Honeycomb.add_field_to_trace('ci.build_url', ENV['TRAVIS_BUILD_WEB_URL'])
-  Honeycomb.add_field_to_trace('ci.job_url', ENV['TRAVIS_JOB_WEB_URL'])
-  Honeycomb.add_field_to_trace('ci.commit_message', ENV['TRAVIS_COMMIT_MESSAGE'])
-  Honeycomb.add_field_to_trace('ci.sha', ENV['TRAVIS_PULL_REQUEST_SHA'] || ENV['TRAVIS_COMMIT'])
+  Honeycomb.add_field_to_trace('ci.build_id', ENV.fetch('TRAVIS_BUILD_ID', nil))
+  Honeycomb.add_field_to_trace('ci.build_url', ENV.fetch('TRAVIS_BUILD_WEB_URL', nil))
+  Honeycomb.add_field_to_trace('ci.job_url', ENV.fetch('TRAVIS_JOB_WEB_URL', nil))
+  Honeycomb.add_field_to_trace('ci.commit_message', ENV.fetch('TRAVIS_COMMIT_MESSAGE', nil))
+  Honeycomb.add_field_to_trace('ci.sha', ENV['TRAVIS_PULL_REQUEST_SHA'] || ENV.fetch('TRAVIS_COMMIT', nil))
 elsif ENV['CI'] == 'True' && ENV['APPVEYOR'] == 'True'
-  Honeycomb.add_field_to_trace('module_name', ENV['APPVEYOR_PROJECT_SLUG'])
+  Honeycomb.add_field_to_trace('module_name', ENV.fetch('APPVEYOR_PROJECT_SLUG', nil))
   Honeycomb.add_field_to_trace('ci.provider', 'appveyor')
-  Honeycomb.add_field_to_trace('ci.build_id', ENV['APPVEYOR_BUILD_ID'])
-  Honeycomb.add_field_to_trace('ci.build_url', "https://ci.appveyor.com/project/#{ENV['APPVEYOR_REPO_NAME']}/builds/#{ENV['APPVEYOR_BUILD_ID']}")
-  Honeycomb.add_field_to_trace('ci.job_url', "https://ci.appveyor.com/project/#{ENV['APPVEYOR_REPO_NAME']}/build/job/#{ENV['APPVEYOR_JOB_ID']}")
-  Honeycomb.add_field_to_trace('ci.commit_message', ENV['APPVEYOR_REPO_COMMIT_MESSAGE'])
-  Honeycomb.add_field_to_trace('ci.sha', ENV['APPVEYOR_PULL_REQUEST_HEAD_COMMIT'] || ENV['APPVEYOR_REPO_COMMIT'])
+  Honeycomb.add_field_to_trace('ci.build_id', ENV.fetch('APPVEYOR_BUILD_ID', nil))
+  Honeycomb.add_field_to_trace('ci.build_url', "https://ci.appveyor.com/project/#{ENV.fetch('APPVEYOR_REPO_NAME', nil)}/builds/#{ENV.fetch('APPVEYOR_BUILD_ID', nil)}")
+  Honeycomb.add_field_to_trace('ci.job_url', "https://ci.appveyor.com/project/#{ENV.fetch('APPVEYOR_REPO_NAME', nil)}/build/job/#{ENV.fetch('APPVEYOR_JOB_ID', nil)}")
+  Honeycomb.add_field_to_trace('ci.commit_message', ENV.fetch('APPVEYOR_REPO_COMMIT_MESSAGE', nil))
+  Honeycomb.add_field_to_trace('ci.sha', ENV['APPVEYOR_PULL_REQUEST_HEAD_COMMIT'] || ENV.fetch('APPVEYOR_REPO_COMMIT', nil))
 elsif ENV['GITHUB_ACTIONS'] == 'true'
-  Honeycomb.add_field_to_trace('module_name', ENV['GITHUB_REPOSITORY'])
+  Honeycomb.add_field_to_trace('module_name', ENV.fetch('GITHUB_REPOSITORY', nil))
   Honeycomb.add_field_to_trace('ci.provider', 'github')
-  Honeycomb.add_field_to_trace('ci.build_id', ENV['GITHUB_RUN_ID'])
-  Honeycomb.add_field_to_trace('ci.build_url', "https://github.com/#{ENV['GITHUB_REPOSITORY']}/actions/runs/#{ENV['GITHUB_RUN_ID']}")
-  Honeycomb.add_field_to_trace('ci.sha', ENV['GITHUB_SHA'])
+  Honeycomb.add_field_to_trace('ci.build_id', ENV.fetch('GITHUB_RUN_ID', nil))
+  Honeycomb.add_field_to_trace('ci.build_url', "https://github.com/#{ENV.fetch('GITHUB_REPOSITORY', nil)}/actions/runs/#{ENV.fetch('GITHUB_RUN_ID', nil)}")
+  Honeycomb.add_field_to_trace('ci.sha', ENV.fetch('GITHUB_SHA', nil))
 end
 at_exit do
   if $ERROR_INFO.is_a?(SystemExit)
@@ -54,8 +52,8 @@ end
 # helper methods for the litmus rake tasks
 module PuppetLitmus::RakeHelper
   # DEFAULT_CONFIG_DATA should be frozen for our safety, but it needs to work around https://github.com/puppetlabs/bolt/pull/1696
-  DEFAULT_CONFIG_DATA ||= { 'modulepath' => File.join(Dir.pwd, 'spec', 'fixtures', 'modules') } # .freeze # rubocop:disable Style/MutableConstant
-  SUPPORTED_PROVISIONERS ||= %w[abs docker docker_exp provision_service vagrant vmpooler].freeze
+  DEFAULT_CONFIG_DATA = { 'modulepath' => File.join(Dir.pwd, 'spec', 'fixtures', 'modules') } # .freeze # rubocop:disable Style/MutableConstant
+  SUPPORTED_PROVISIONERS = %w[abs docker docker_exp provision_service vagrant vmpooler].freeze
 
   # Gets a string representing the operating system and version.
   #
@@ -318,7 +316,7 @@ module PuppetLitmus::RakeHelper
 
       module_repository_opts = "--module_repository '#{module_repository}'" unless module_repository.nil?
       install_module_command = "puppet module install #{module_repository_opts} #{File.basename(module_tar)}"
-      install_module_command += ' --ignore-dependencies --force' if ignore_dependencies.to_s.downcase == 'true'
+      install_module_command += ' --ignore-dependencies --force' if ignore_dependencies.to_s.casecmp('true').zero?
       span.add_field('litmus.install_module_command', install_module_command)
 
       bolt_result = run_command(install_module_command, target_nodes, config: nil, inventory: inventory_hash.clone)
@@ -428,7 +426,7 @@ module PuppetLitmus::RakeHelper
   end
 
   def start_spinner(message)
-    if (ENV['CI'] || '').downcase == 'true'
+    if (ENV['CI'] || '').casecmp('true').zero?
       puts message
       spinner = Thread.new do
         # CI systems are strange beasts, we only output a '.' every wee while to keep the terminal alive.
@@ -446,7 +444,7 @@ module PuppetLitmus::RakeHelper
   end
 
   def stop_spinner(spinner)
-    if (ENV['CI'] || '').downcase == 'true'
+    if (ENV['CI'] || '').casecmp('true').zero?
       Thread.kill(spinner)
     else
       spinner.success

data/lib/puppet_litmus/rake_tasks.rb

@@ -42,10 +42,10 @@ namespace :litmus do
         stop_spinner(spinner)
       end
 
-      if result.first['status'] != 'success'
-        failed_image_message += "=====\n#{result.first['target']}\n#{result.first['value']['_output']}\n#{result.inspect}"
-      else
+      if result.first['status'] == 'success'
         $stdout.puts 'Success'
+      else
+        failed_image_message += "=====\n#{result.first['target']}\n#{result.first['value']['_output']}\n#{result.inspect}"
       end
     else
       provision_hash[args[:key]]['images'].each do |image|
@@ -56,10 +56,10 @@ namespace :litmus do
           stop_spinner(spinner)
         end
 
-        if result.first['status'] != 'success'
-          failed_image_message += "=====\n#{result.first['target']}\n#{result.first['value']['_output']}\n#{result.inspect}"
-        else
+        if result.first['status'] == 'success'
           $stdout.puts "#{result.first['value']['node_name']}, #{image}"
+        else
+          failed_image_message += "=====\n#{result.first['target']}\n#{result.first['value']['_output']}\n#{result.inspect}"
         end
       end
     end
@@ -80,9 +80,7 @@ namespace :litmus do
 
       results = provision(args[:provisioner], args[:platform], args[:inventory_vars])
 
-      unless results.first['status'] == 'success'
-        raise "Failed provisioning #{args[:platform]} using #{args[:provisioner]}\n#{results.first}"
-      end
+      raise "Failed provisioning #{args[:platform]} using #{args[:provisioner]}\n#{results.first}" unless results.first['status'] == 'success'
 
       puts "Successfully provisioned #{args[:platform]} using #{args[:provisioner]}\n"
 
@@ -320,10 +318,10 @@ namespace :litmus do
     bad_results = []
     results = tear_down_nodes(targets, inventory_hash)
     results.each do |node, result|
-      if result.first['status'] != 'success'
-        bad_results << "#{node}, #{result.first['value']['_error']['msg']}"
-      else
+      if result.first['status'] == 'success'
         puts "#{node}: #{result.first['status']}"
+      else
+        bad_results << "#{node}, #{result.first['value']['_error']['msg']}"
       end
     end
     puts ''
@@ -361,8 +359,8 @@ namespace :litmus do
         title = "#{target}, #{facts_from_node(inventory_hash, target)['platform']}"
         options = {
           env: {
-            'TARGET_HOST' => target,
-          },
+            'TARGET_HOST' => target
+          }
         }
         payloads << [title, test, options]
       end
@@ -395,9 +393,9 @@ namespace :litmus do
         # because we cannot modify variables inside of Parallel
         results.each do |result|
           if result.last.to_i.zero?
-            success_list.push(result.first.scan(%r{.*})[3])
+            success_list.push(result.first.scan(/.*/)[3])
           else
-            failure_list.push(result.first.scan(%r{.*})[3])
+            failure_list.push(result.first.scan(/.*/)[3])
           end
         end
         Thread.kill(progress)

data/lib/puppet_litmus/spec_helper_acceptance.rb

@@ -22,13 +22,13 @@ module PuppetLitmus
     else
       # load inventory
       inventory_hash = inventory_hash_from_inventory_file
-      node_config = config_from_node(inventory_hash, ENV['TARGET_HOST'])
+      node_config = config_from_node(inventory_hash, ENV.fetch('TARGET_HOST', nil))
 
-      if target_in_group(inventory_hash, ENV['TARGET_HOST'], 'docker_nodes')
-        host = ENV['TARGET_HOST']
+      if target_in_group(inventory_hash, ENV.fetch('TARGET_HOST', nil), 'docker_nodes')
+        host = ENV.fetch('TARGET_HOST', nil)
         set :backend, :docker
         set :docker_container, host
-      elsif target_in_group(inventory_hash, ENV['TARGET_HOST'], 'ssh_nodes')
+      elsif target_in_group(inventory_hash, ENV.fetch('TARGET_HOST', nil), 'ssh_nodes')
         set :backend, :ssh
         options = Net::SSH::Config.for(host)
         options[:user] = node_config.dig('ssh', 'user') unless node_config.dig('ssh', 'user').nil?
@@ -70,14 +70,14 @@ module PuppetLitmus
         set :request_pty, false
         set :sudo_password, options[:password] if run_as
         puts "Running tests as #{run_as}" if run_as
-      elsif target_in_group(inventory_hash, ENV['TARGET_HOST'], 'winrm_nodes')
+      elsif target_in_group(inventory_hash, ENV.fetch('TARGET_HOST', nil), 'winrm_nodes')
         require 'winrm'
 
         set :backend, :winrm
         set :os, family: 'windows'
         user = node_config.dig('winrm', 'user') unless node_config.dig('winrm', 'user').nil?
         pass = node_config.dig('winrm', 'password') unless node_config.dig('winrm', 'password').nil?
-        endpoint = URI("http://#{ENV['TARGET_HOST']}")
+        endpoint = URI("http://#{ENV.fetch('TARGET_HOST', nil)}")
         endpoint.port = 5985 if endpoint.port == 80
         endpoint.path = '/wsman'
 
@@ -85,7 +85,7 @@ module PuppetLitmus
           user: user,
           password: pass,
           endpoint: endpoint,
-          operation_timeout: 300,
+          operation_timeout: 300
         }
 
         winrm = WinRM::Connection.new opts

data/lib/puppet_litmus/version.rb

@@ -2,5 +2,5 @@
 
 # version of this gem
 module PuppetLitmus
-  VERSION ||= '0.36.1'
+  VERSION = '1.0.0'
 end

data/spec/exe/matrix_from_metadata_v2_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe 'matrix_from_metadata_v2' do
     let(:github_output_content) { github_output.read }
     let(:result) { run_matrix_from_metadata_v2 }
 
-    before(:each) do
+    before do
       ENV['GITHUB_OUTPUT'] = github_output.path
     end
 
@@ -29,11 +29,11 @@ RSpec.describe 'matrix_from_metadata_v2' do
           '"collection":[',
           '"puppet7-nightly","puppet8-nightly"',
           ']',
-          '}',
-        ].join,
+          '}'
+        ].join
       )
       expect(github_output_content).to include(
-        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"~> 8.0","ruby_version":3.2}]}',
+        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"https://github.com/puppetlabs/puppet","ruby_version":3.2}]}'
       )
       expect(result.stdout).to include("Created matrix with 8 cells:\n  - Acceptance Test Cells: 6\n  - Spec Test Cells: 2")
     end
@@ -44,7 +44,7 @@ RSpec.describe 'matrix_from_metadata_v2' do
     let(:github_output_content) { github_output.read }
     let(:result) { run_matrix_from_metadata_v2({ '--exclude-platforms' => ['ubuntu-18.04'] }) }
 
-    before(:each) do
+    before do
       ENV['GITHUB_OUTPUT'] = github_output.path
     end
 
@@ -65,11 +65,11 @@ RSpec.describe 'matrix_from_metadata_v2' do
           '"collection":[',
           '"puppet7-nightly","puppet8-nightly"',
           ']',
-          '}',
-        ].join,
+          '}'
+        ].join
       )
       expect(github_output_content).to include(
-        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"~> 8.0","ruby_version":3.2}]}',
+        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"https://github.com/puppetlabs/puppet","ruby_version":3.2}]}'
       )
       expect(result.stdout).to include("Created matrix with 6 cells:\n  - Acceptance Test Cells: 4\n  - Spec Test Cells: 2")
     end
@@ -80,7 +80,7 @@ RSpec.describe 'matrix_from_metadata_v2' do
     let(:github_output_content) { github_output.read }
     let(:result) { run_matrix_from_metadata_v2({ '--exclude-platforms' => ['ubuntu-18.04', 'redhat-8'] }) }
 
-    before(:each) do
+    before do
       ENV['GITHUB_OUTPUT'] = github_output.path
     end
 
@@ -101,11 +101,11 @@ RSpec.describe 'matrix_from_metadata_v2' do
           '"collection":[',
           '"puppet7-nightly","puppet8-nightly"',
           ']',
-          '}',
-        ].join,
+          '}'
+        ].join
       )
       expect(github_output_content).to include(
-        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"~> 8.0","ruby_version":3.2}]}',
+        'spec_matrix={"include":[{"puppet_version":"~> 7.0","ruby_version":2.7},{"puppet_version":"https://github.com/puppetlabs/puppet","ruby_version":3.2}]}'
       )
       expect(result.stdout).to include("Created matrix with 4 cells:\n  - Acceptance Test Cells: 2\n  - Spec Test Cells: 2")
     end

data/spec/lib/puppet_litmus/inventory_manipulation_spec.rb

@@ -8,11 +8,11 @@ RSpec.describe PuppetLitmus::InventoryManipulation do
 
   context 'with config_from_node' do
     it 'no matching node, returns nil' do
-      expect(config_from_node(config_hash, 'not.here')).to eq(nil)
+      expect(config_from_node(config_hash, 'not.here')).to be_nil
     end
 
     it 'no config section, returns nil' do
-      expect(config_from_node(no_config_hash, 'test.delivery.puppetlabs.net')).to eq(nil)
+      expect(config_from_node(no_config_hash, 'test.delivery.puppetlabs.net')).to be_nil
     end
 
     it 'config exists, and returns' do
@@ -82,9 +82,7 @@ RSpec.describe PuppetLitmus::InventoryManipulation do
 
     it 'applies a code block to groups' do
       counts = groups_in_inventory(complex_inventory) do |group|
-        if group.key? 'targets'
-          group['targets'].count
-        end
+        group['targets'].count if group.key? 'targets'
       end
       expect(counts.sum).to be 4
     end
@@ -133,7 +131,7 @@ RSpec.describe PuppetLitmus::InventoryManipulation do
     end
 
     it 'searches for roles as symbols' do
-      expect(search_for_target([:iis, :nginx], complex_inventory)).to eql ['test4.delivery.puppetlabs.net', 'test3.delivery.puppetlabs.net']
+      expect(search_for_target(%i[iis nginx], complex_inventory)).to eql ['test4.delivery.puppetlabs.net', 'test3.delivery.puppetlabs.net']
     end
 
     it 'raises an error if target not found' do

data/spec/lib/puppet_litmus/puppet_helpers_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
       let(:result) { ['value' => { 'exit_code' => 0, 'stdout' => nil, 'stderr' => nil }] }
       let :os do
         {
-          family: 'redhat',
+          family: 'redhat'
         }
       end
       let(:command) { "LC_ALL=en_US.UTF-8  puppet apply /bla.pp --trace --modulepath #{Dir.pwd}/spec/fixtures/modules --hiera_config='/hiera.yaml'" }
@@ -54,7 +54,7 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
       let(:command) { "LC_ALL=en_US.UTF-8  puppet apply /bla.pp --trace --modulepath #{Dir.pwd}/spec/fixtures/modules --detailed-exitcodes" }
       let :os do
         {
-          family: 'redhat',
+          family: 'redhat'
         }
       end
 
@@ -176,7 +176,7 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
         expect(self).to receive(:target_in_inventory?).and_return(true)
         expect(self).to receive(:target_in_inventory?).and_return(true)
         expect(self).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_failure)
-        expect { bolt_upload_file(local, remote) }.to raise_error(RuntimeError, %r{upload file failed})
+        expect { bolt_upload_file(local, remote) }.to raise_error(RuntimeError, /upload file failed/)
       end
 
       it 'returns the exit code and error message when expecting failure' do
@@ -307,7 +307,7 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
         expect(self).to receive(:target_in_inventory?).and_return(true)
         expect(self).to receive(:target_in_inventory?).and_return(true)
         expect(self).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_failure)
-        expect { run_bolt_task(task_name, params, opts: {}) }.to raise_error(RuntimeError, %r{task failed})
+        expect { run_bolt_task(task_name, params, opts: {}) }.to raise_error(RuntimeError, /task failed/)
       end
 
       it 'returns the exit code and error message when expecting failure' do
@@ -330,7 +330,7 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
     let(:owner) { 'foo:foo' }
     let(:local_path) { '/tmp/local_foo' }
 
-    before(:each) do
+    before do
       allow_any_instance_of(File).to receive(:path).and_return(local_path)
     end
 
@@ -342,9 +342,10 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
       it 'call upload file with the correct params' do
         stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
         expect(self).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        result = instance_double('result')
-        allow(result).to receive(:first).and_return({ 'status' => 'success' })
-        expect(self).to receive(:upload_file).with(local_path, destination, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result)
+
+        expected_result = [{ 'status' => 'success' }]
+        expect(self).to receive(:upload_file).with(local_path, destination, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(expected_result)
+
         result = write_file(content, destination)
         expect(result).to be true
       end
@@ -354,9 +355,10 @@ RSpec.describe PuppetLitmus::PuppetHelpers do
       it 'call upload file with the correct params' do
         stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
         expect(self).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        result = instance_double('result')
-        allow(result).to receive(:first).and_return({ 'status' => 'failure', 'value' => 'foo error' })
-        expect(self).to receive(:upload_file).with(local_path, destination, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result)
+
+        expected_result = [{ 'status' => 'failure', 'value' => 'foo error' }]
+        expect(self).to receive(:upload_file).with(local_path, destination, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(expected_result)
+
         expect { write_file(content, destination) }.to raise_error 'foo error'
       end
     end

data/spec/lib/puppet_litmus/puppet_litmus_version_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 RSpec.describe PuppetLitmus do
   it 'has a version number' do
-    expect(described_class::VERSION).not_to be nil
-    expect(described_class::VERSION).to be_a_kind_of(String)
+    expect(described_class::VERSION).not_to be_nil
+    expect(described_class::VERSION).to be_a(String)
   end
 end

data/spec/lib/puppet_litmus/rake_helper_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe PuppetLitmus::RakeHelper do
         inventory_vars: nil,
         provision_hash: { 'default' => { 'provisioner' => 'docker', 'images' => ['waffleimage/centos7'] } },
         results: [],
-        params: { 'action' => 'provision', 'platform' => 'waffleimage/centos7', 'inventory' => Dir.pwd },
+        params: { 'action' => 'provision', 'platform' => 'waffleimage/centos7', 'inventory' => Dir.pwd }
       },
       {
         provisioner: 'vagrant',
@@ -50,8 +50,8 @@ RSpec.describe PuppetLitmus::RakeHelper do
         inventory_vars: nil,
         provision_hash: { 'default' => { 'provisioner' => 'vagrant', 'images' => ['centos7'] } },
         results: [],
-        params: { 'action' => 'provision', 'platform' => 'centos7', 'inventory' => Dir.pwd },
-      },
+        params: { 'action' => 'provision', 'platform' => 'centos7', 'inventory' => Dir.pwd }
+      }
     ].freeze
 
     examples.each do |e|
@@ -85,7 +85,7 @@ RSpec.describe PuppetLitmus::RakeHelper do
             { 'uri' => 'one.host', 'facts' => { 'provisioner' => 'abs', 'platform' => 'ubuntu-1604-x86_64', 'job_id' => 'iac-task-pid-21648' } },
             { 'uri' => 'two.host', 'facts' => { 'provisioner' => 'abs', 'platform' => 'ubuntu-1804-x86_64', 'job_id' => 'iac-task-pid-21648' } },
             { 'uri' => 'three.host', 'facts' => { 'provisioner' => 'abs', 'platform' => 'ubuntu-2004-x86_64', 'job_id' => 'iac-task-pid-21648' } },
-            { 'uri' => 'four.host', 'facts' => { 'provisioner' => 'abs', 'platform' => 'ubuntu-2004-x86_64', 'job_id' => 'iac-task-pid-21649' } },
+            { 'uri' => 'four.host', 'facts' => { 'provisioner' => 'abs', 'platform' => 'ubuntu-2004-x86_64', 'job_id' => 'iac-task-pid-21649' } }
           ] }] }
     end
     let(:targets) { ['one.host'] }
@@ -103,7 +103,7 @@ RSpec.describe PuppetLitmus::RakeHelper do
              'removed' =>
              ['one.host',
               'two.host',
-              'three.host'] } }],
+              'three.host'] } }]
       )
       results = tear_down_nodes(targets, inventory_hash)
       expect(results.keys).to eq(['one.host', 'two.host', 'three.host'])
@@ -170,7 +170,7 @@ RSpec.describe PuppetLitmus::RakeHelper do
 
     it 'node unavailable' do
       allow_any_instance_of(BoltSpec::Run).to receive(:run_command).with(command, targets, config: nil, inventory: inventory_hash).and_return([{ 'target' => 'some.host', 'status' => 'failure' }])
-      expect { check_connectivity?(inventory_hash, 'some.host') }.to raise_error(RuntimeError, %r{Connectivity has failed on:})
+      expect { check_connectivity?(inventory_hash, 'some.host') }.to raise_error(RuntimeError, /Connectivity has failed on:/)
     end
   end
 

data/spec/lib/puppet_litmus/rake_tasks_spec.rb

@@ -59,6 +59,13 @@ describe 'litmus rake tasks' do
   end
 
   context 'with litmus:provision task' do
+    let(:expected_output) do
+      <<~OUTPUT
+        Successfully provisioned centos:7 using docker
+        localhost:2222, centos:7
+      OUTPUT
+    end
+
     it 'happy path' do
       results = [{ 'target' => 'localhost',
                    'action' => 'task',
@@ -71,11 +78,7 @@ describe 'litmus rake tasks' do
       allow_any_instance_of(PuppetLitmus::InventoryManipulation).to receive(:inventory_hash_from_inventory_file).with(any_args).and_return({})
       allow_any_instance_of(PuppetLitmus::RakeHelper).to receive(:check_connectivity?).with(any_args).and_return(true)
 
-      expect($stdout).to receive(:puts).with('Provisioning centos:7 using docker provisioner.')
-      expect($stdout).to receive(:puts).with("Successfully provisioned centos:7 using docker\n")
-      expect($stdout).to receive(:puts).with('localhost:2222, centos:7')
-
-      Rake::Task['litmus:provision'].invoke('docker', 'centos:7')
+      expect { Rake::Task['litmus:provision'].invoke('docker', 'centos:7') }.to output(expected_output).to_stdout
     end
   end
 
@@ -86,7 +89,7 @@ describe 'litmus rake tasks' do
     it 'no key in provision file' do
       allow(File).to receive(:file?).with(any_args).and_return(true)
       expect(YAML).to receive(:load_file).with(provision_file).and_return(provision_hash)
-      expect { Rake::Task['litmus:provision_list'].invoke('deet') }.to raise_error(%r{deet})
+      expect { Rake::Task['litmus:provision_list'].invoke('deet') }.to raise_error(/deet/)
     end
   end
 

data/spec/lib/puppet_litmus/util_spec.rb

@@ -6,10 +6,10 @@ load File.expand_path('../../../lib/puppet_litmus/util.rb', __dir__)
 RSpec.describe PuppetLitmus::Util do
   context 'when using interpolate_powershell' do
     it 'interpolates the command' do
-      expect(described_class.interpolate_powershell('foo')).to match(%r{powershell\.exe})
-      expect(described_class.interpolate_powershell('foo')).to match(%r{NoProfile})
-      expect(described_class.interpolate_powershell('foo')).to match(%r{EncodedCommand})
-      expect(described_class.interpolate_powershell('foo')).not_to match(%r{foo})
+      expect(described_class.interpolate_powershell('foo')).to match(/powershell\.exe/)
+      expect(described_class.interpolate_powershell('foo')).to match(/NoProfile/)
+      expect(described_class.interpolate_powershell('foo')).to match(/EncodedCommand/)
+      expect(described_class.interpolate_powershell('foo')).not_to match(/foo/)
     end
   end
 end

data/spec/spec_helper.rb

@@ -12,7 +12,7 @@ if ENV['COVERAGE'] == 'yes'
     SimpleCov.formatter = SimpleCov::Formatter::Codecov
   else
     SimpleCov.formatters = [
-      SimpleCov::Formatter::HTMLFormatter,
+      SimpleCov::Formatter::HTMLFormatter
     ]
   end
   SimpleCov.start do
@@ -41,7 +41,7 @@ def run_matrix_from_metadata_v2(options = {})
   OpenStruct.new(
     stdout: result[0],
     stderr: result[1],
-    status_code: result[2],
+    status_code: result[2]
   )
 end
 

data/spec/support/inventory.rb

@@ -7,7 +7,7 @@ def no_config_hash
         'targets' =>
       [{ 'uri' => 'test.delivery.puppetlabs.net',
          'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
-      { 'name' => 'winrm_nodes', 'targets' => [] },
+      { 'name' => 'winrm_nodes', 'targets' => [] }
     ] }
 end
 
@@ -99,21 +99,21 @@ def complex_inventory
                 'uri' => 'test.delivery.puppetlabs.net',
                 'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
                 'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' },
-                'vars' => { 'role' => 'agent' },
+                'vars' => { 'role' => 'agent' }
               },
               {
                 'uri' => 'test2.delivery.puppetlabs.net',
                 'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
                 'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' },
-                'vars' => { 'role' => 'server' },
+                'vars' => { 'role' => 'server' }
               },
               {
                 'uri' => 'test3.delivery.puppetlabs.net',
                 'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
-                'vars' => { 'roles' => %w[agent nginx webserver] },
-              },
-            ] },
-        ],
+                'vars' => { 'roles' => %w[agent nginx webserver] }
+              }
+            ] }
+        ]
       },
       {
         'name' => 'winrm_nodes',
@@ -122,9 +122,9 @@ def complex_inventory
             'uri' => 'test4.delivery.puppetlabs.net',
             'config' => { 'transport' => 'winrm', 'winrm' => { 'user' => 'admin', 'password' => 'Qu@lity!' } },
             'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' },
-            'vars' => { 'roles' => %w[agent iis webserver] },
-          },
-        ],
-      },
+            'vars' => { 'roles' => %w[agent iis webserver] }
+          }
+        ]
+      }
     ] }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet_litmus
 version: !ruby/object:Gem::Version
-  version: 0.36.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Puppet, Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-03-28 00:00:00.000000000 Z
+date: 2023-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bolt
@@ -25,93 +25,87 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: puppet-modulebuilder
+  name: docker-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: '1.34'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: '1.34'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
-  name: tty-spinner
+  name: honeycomb-beeline
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: docker-api
+  name: parallel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.34'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.34'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: retryable
+  name: puppet-modulebuilder
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 0.2.1
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0.rc
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 0.2.1
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0.rc
 - !ruby/object:Gem::Dependency
-  name: parallel
+  name: retryable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -127,7 +121,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: honeycomb-beeline
+  name: rspec_honeycomb_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -141,19 +135,25 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec_honeycomb_formatter
+  name: tty-spinner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: "    Providing a simple command line tool for puppet content creators,
   to enable simple and complex test deployments.\n"
 email:
@@ -202,7 +202,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -214,18 +214,4 @@ signing_key:
 specification_version: 4
 summary: Providing a simple command line tool for puppet content creators, to enable
   simple and complex test deployments.
-test_files:
-- spec/exe/matrix_from_metadata_v2_spec.rb
-- spec/exe/fake_metadata.json
-- spec/lib/puppet_litmus/util_spec.rb
-- spec/lib/puppet_litmus/inventory_manipulation_spec.rb
-- spec/lib/puppet_litmus/rake_tasks_spec.rb
-- spec/lib/puppet_litmus/puppet_helpers_spec.rb
-- spec/lib/puppet_litmus/rake_helper_spec.rb
-- spec/lib/puppet_litmus/puppet_litmus_version_spec.rb
-- spec/spec_helper.rb
-- spec/support/inventorytesting.yaml
-- spec/support/inventory.rb
-- spec/data/doot.tar.gz
-- spec/data/inventory.yaml
-- spec/data/jim.yaml
+test_files: []