puppet_forge 2.1.2 → 2.1.3

data/CHANGELOG.md

@@ -3,6 +3,12 @@
 Starting with v2.0.0, all notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## v2.1.3 - 2016-01-25
+
+### Changed
+
+* PuppetForge::V3::Release.download will now use the "file\_uri" field of the Release API response to calculate the URI to download from. (Thanks to [ericparton](https://github.com/ericparton) for the contribution.)
+
 ## v2.1.2 - 2015-12-16
 
 ### Changed

data/lib/puppet_forge/v3/release.rb

@@ -13,7 +13,7 @@ module PuppetForge
       # @return [String] fully qualified download URL for release
       def download_url
         if URI.parse(file_uri).host.nil?
-          PuppetForge.host + file_uri
+          URI.join(PuppetForge.host, file_uri).to_s
         else
           file_uri
         end
@@ -24,7 +24,7 @@ module PuppetForge
       # @param path [Pathname]
       # @return [void]
       def download(path)
-        resp = self.class.conn.get(file_url)
+        resp = self.class.conn.get(download_url)
         path.open('wb') { |fh| fh.write(resp.body) }
       rescue Faraday::ResourceNotFound => e
         raise PuppetForge::ReleaseNotFound, "The module release #{slug} does not exist on #{self.class.conn.url_prefix}.", e.backtrace
@@ -48,16 +48,6 @@ module PuppetForge
         end
       end
 
-      private
-
-      def file_url
-        "/v3/files/#{slug}.tar.gz"
-      end
-
-      def resource_url
-        "/v3/releases/#{slug}"
-      end
-
       class ChecksumMismatch < StandardError
       end
 

data/lib/puppet_forge/version.rb

@@ -1,3 +1,3 @@
 module PuppetForge
-  VERSION = '2.1.2' # Library version
+  VERSION = '2.1.3' # Library version
 end

data/spec/unit/forge/v3/release_spec.rb

@@ -48,7 +48,8 @@ describe PuppetForge::V3::Release do
 
     it 'handles an API response that does not include a scheme and host' do
       release.file_uri = '/v3/files/puppetlabs-apache-0.0.1.tar.gz'
-      expect(release.download_url).to eql(PuppetForge.host + '/v3/files/puppetlabs-apache-0.0.1.tar.gz')
+      uri_with_host = URI.join(PuppetForge.host, '/v3/files/puppetlabs-apache-0.0.1.tar.gz').to_s
+      expect(release.download_url).to eql(uri_with_host)
     end
 
     it 'handles an API response that includes a scheme and host' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet_forge
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-17 00:00:00.000000000 Z
+date: 2016-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -293,7 +293,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3862715394005484998
+      hash: -3937561798561843992
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.29