puppet 8.5.0-x86-mingw32 → 8.6.0-x86-mingw32

data/lib/puppet/face/module/list.rb

@@ -117,28 +117,28 @@ Puppet::Face.define(:module, '1.0.0') do
     end
 
     # Prepare the unmet dependencies for display on the console.
-    environment.modules.sort_by { |mod| mod.name }.each do |mod|
+    environment.modules.sort_by(&:name).each do |mod|
       unmet_grouped = Hash.new { |h, k| h[k] = [] }
       unmet_grouped = mod.unmet_dependencies.each_with_object(unmet_grouped) do |dep, acc|
         acc[dep[:reason]] << dep
       end
       unmet_grouped.each do |type, deps|
-        unless deps.empty?
-          unmet_grouped[type].sort_by { |dep| dep[:name] }.each do |dep|
-            dep_name           = dep[:name].tr('/', '-')
-            installed_version  = dep[:mod_details][:installed_version]
-            version_constraint = dep[:version_constraint]
-            parent_name        = dep[:parent][:name].tr('/', '-')
-            parent_version     = dep[:parent][:version]
-
-            msg = _("'%{parent_name}' (%{parent_version}) requires '%{dependency_name}' (%{dependency_version})") % { parent_name: parent_name, parent_version: parent_version, dependency_name: dep_name, dependency_version: version_constraint }
-            unmet_deps[type][dep[:name]][:errors] << msg
-            unmet_deps[type][dep[:name]][:parent] = {
-              :name => dep[:parent][:name],
-              :version => parent_version
-            }
-            unmet_deps[type][dep[:name]][:version] = installed_version
-          end
+        next if deps.empty?
+
+        unmet_grouped[type].sort_by { |dep| dep[:name] }.each do |dep|
+          dep_name           = dep[:name].tr('/', '-')
+          installed_version  = dep[:mod_details][:installed_version]
+          version_constraint = dep[:version_constraint]
+          parent_name        = dep[:parent][:name].tr('/', '-')
+          parent_version     = dep[:parent][:version]
+
+          msg = _("'%{parent_name}' (%{parent_version}) requires '%{dependency_name}' (%{dependency_version})") % { parent_name: parent_name, parent_version: parent_version, dependency_name: dep_name, dependency_version: version_constraint }
+          unmet_deps[type][dep[:name]][:errors] << msg
+          unmet_deps[type][dep[:name]][:parent] = {
+            :name => dep[:parent][:name],
+            :version => parent_version
+          }
+          unmet_deps[type][dep[:name]][:version] = installed_version
         end
       end
     end
@@ -151,24 +151,24 @@ Puppet::Face.define(:module, '1.0.0') do
     # Display unmet dependencies by category.
     error_display_order = [:non_semantic_version, :version_mismatch, :missing]
     error_display_order.each do |type|
-      unless @unmet_deps[type].empty?
-        @unmet_deps[type].keys.sort.each do |dep|
-          name    = dep.tr('/', '-')
-          errors  = @unmet_deps[type][dep][:errors]
-          version = @unmet_deps[type][dep][:version]
-
-          msg = case type
-                when :version_mismatch
-                  _("Module '%{name}' (v%{version}) fails to meet some dependencies:\n") % { name: name, version: version }
-                when :non_semantic_version
-                  _("Non semantic version dependency %{name} (v%{version}):\n") % { name: name, version: version }
-                else
-                  _("Missing dependency '%{name}':\n") % { name: name }
-                end
-
-          errors.each { |error_string| msg << "  #{error_string}\n" }
-          Puppet.warning msg.chomp
-        end
+      next if @unmet_deps[type].empty?
+
+      @unmet_deps[type].keys.sort.each do |dep|
+        name    = dep.tr('/', '-')
+        errors  = @unmet_deps[type][dep][:errors]
+        version = @unmet_deps[type][dep][:version]
+
+        msg = case type
+              when :version_mismatch
+                _("Module '%{name}' (v%{version}) fails to meet some dependencies:\n") % { name: name, version: version }
+              when :non_semantic_version
+                _("Non semantic version dependency %{name} (v%{version}):\n") % { name: name, version: version }
+              else
+                _("Missing dependency '%{name}':\n") % { name: name }
+              end
+
+        errors.each { |error_string| msg << "  #{error_string}\n" }
+        Puppet.warning msg.chomp
       end
     end
   end
@@ -259,8 +259,8 @@ Puppet::Face.define(:module, '1.0.0') do
         str << '  ' + colorize(:red, _('invalid'))
       elsif parent.respond_to?(:forge_name)
         unmet_parent = @unmet_deps[:version_mismatch][mod.forge_name][:parent]
-        if (unmet_parent[:name] == parent.forge_name &&
-            unmet_parent[:version] == "v#{parent.version}")
+        if unmet_parent[:name] == parent.forge_name &&
+           unmet_parent[:version] == "v#{parent.version}"
           str << '  ' + colorize(:red, _('invalid'))
         end
       end

data/lib/puppet/face/node/clean.rb

@@ -104,6 +104,6 @@ Puppet::Face.define(:node, '0.0.1') do
       return true if type && type.arguments.keys.include?('ensure')
     end
 
-    return false
+    false
   end
 end

data/lib/puppet/face/parser.rb

@@ -42,7 +42,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       parse_errors = {}
 
       if files.empty?
-        if not STDIN.tty?
+        if !STDIN.tty?
           Puppet[:code] = STDIN.read
           error = validate_manifest(nil)
           parse_errors['STDIN'] = error if error
@@ -214,13 +214,11 @@ Puppet::Face.define(:parser, '0.0.1') do
     loaders = Puppet::Pops::Loaders.new(env)
 
     Puppet.override({ :loaders => loaders }, _('For puppet parser validate')) do
-      begin
-        validation_environment = manifest ? env.override_with(:manifest => manifest) : env
-        validation_environment.check_for_reparse
-        validation_environment.known_resource_types.clear
-      rescue Puppet::ParseError => parse_error
-        return parse_error
-      end
+      validation_environment = manifest ? env.override_with(:manifest => manifest) : env
+      validation_environment.check_for_reparse
+      validation_environment.known_resource_types.clear
+    rescue Puppet::ParseError => parse_error
+      return parse_error
     end
 
     nil

data/lib/puppet/face/report.rb

@@ -41,13 +41,11 @@ Puppet::Indirector::Face.define(:report, '0.0.1') do
           return report
     EOT
     when_invoked do |report, _options|
-      begin
-        Puppet::Transaction::Report.indirection.terminus_class = :rest
-        Puppet::Face[:report, "0.0.1"].save(report)
-        Puppet.notice _("Uploaded report for %{name}") % { name: report.name }
-      rescue => detail
-        Puppet.log_exception(detail, _("Could not send report: %{detail}") % { detail: detail })
-      end
+      Puppet::Transaction::Report.indirection.terminus_class = :rest
+      Puppet::Face[:report, "0.0.1"].save(report)
+      Puppet.notice _("Uploaded report for %{name}") % { name: report.name }
+    rescue => detail
+      Puppet.log_exception(detail, _("Could not send report: %{detail}") % { detail: detail })
     end
   end
   deactivate_action(:find)

data/lib/puppet/facter_impl.rb

@@ -58,7 +58,7 @@ module Puppet
     end
 
     def load_external(value)
-      ::Facter.load_external(value) if self.load_external?
+      ::Facter.load_external(value) if load_external?
     end
 
     private

data/lib/puppet/feature/base.rb

@@ -24,7 +24,7 @@ raise Puppet::Error, _("Cannot determine basic system flavour") unless Puppet.fe
 Puppet.features.add(:ldap, :libs => ["ldap"])
 
 # We have the Rdoc::Usage library.
-Puppet.features.add(:usage, :libs => %w{rdoc/ri/ri_paths rdoc/usage})
+Puppet.features.add(:usage, :libs => %w[rdoc/ri/ri_paths rdoc/usage])
 
 # We have libshadow, useful for managing passwords.
 Puppet.features.add(:libshadow, :libs => ["shadow"])
@@ -36,7 +36,7 @@ Puppet.features.add(:root) do
 end
 
 # We have lcs diff
-Puppet.features.add :diff, :libs => %w{diff/lcs diff/lcs/hunk}
+Puppet.features.add :diff, :libs => %w[diff/lcs diff/lcs/hunk]
 
 # We have OpenSSL
 Puppet.features.add(:openssl, :libs => ["openssl"])
@@ -59,15 +59,13 @@ Puppet.features.add(:manages_symlinks) do
       extend FFI::Library
 
       def self.is_implemented # rubocop:disable Naming/PredicateName
-        begin
-          ffi_lib :kernel32
-          attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean
-
-          true
-        rescue LoadError
-          Puppet.debug { "CreateSymbolicLink is not available" }
-          false
-        end
+        ffi_lib :kernel32
+        attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean
+
+        true
+      rescue LoadError
+        Puppet.debug { "CreateSymbolicLink is not available" }
+        false
       end
     end
 

data/lib/puppet/feature/pe_license.rb

@@ -3,4 +3,4 @@
 require_relative '../../puppet/util/feature'
 
 # Is the pe license library installed providing the ability to read licenses.
-Puppet.features.add(:pe_license, :libs => %{pe_license})
+Puppet.features.add(:pe_license, :libs => %(pe_license))

data/lib/puppet/feature/ssh.rb

@@ -2,4 +2,4 @@
 
 require_relative '../../puppet/util/feature'
 
-Puppet.features.add(:ssh, :libs => %{net/ssh})
+Puppet.features.add(:ssh, :libs => %(net/ssh))

data/lib/puppet/feature/telnet.rb

@@ -3,9 +3,7 @@
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add :telnet do
-  begin
-    require 'net/telnet'
-  rescue LoadError
-    false
-  end
+  require 'net/telnet'
+rescue LoadError
+  false
 end

data/lib/puppet/feature/zlib.rb

@@ -4,4 +4,4 @@ require_relative '../../puppet/util/feature'
 
 # We want this to load if possible, but it's not automatically
 # required.
-Puppet.features.add(:zlib, :libs => %{zlib})
+Puppet.features.add(:zlib, :libs => %(zlib))

data/lib/puppet/ffi/windows/constants.rb

@@ -109,7 +109,7 @@ module Puppet::FFI::Windows
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364571(v=vs.85).aspx
     FSCTL_GET_REPARSE_POINT = 0x900a8
 
-    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16_384
 
     # Priority constants
     # https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setpriorityclass

data/lib/puppet/ffi/windows/functions.rb

@@ -287,7 +287,7 @@ module Puppet::FFI::Windows
     #   LPDWORD        pcbBytesNeeded
     # );
     SC_STATUS_TYPE = enum(
-      :SC_STATUS_PROCESS_INFO, 0,
+      :SC_STATUS_PROCESS_INFO, 0
     )
     ffi_lib :advapi32
     attach_function_private :QueryServiceStatusEx,
@@ -425,7 +425,7 @@ module Puppet::FFI::Windows
     #   LPCWSTR      pszGroupName
     # );
     SC_ENUM_TYPE = enum(
-      :SC_ENUM_PROCESS_INFO, 0,
+      :SC_ENUM_PROCESS_INFO, 0
     )
     ffi_lib :advapi32
     attach_function_private :EnumServicesStatusExW,

data/lib/puppet/ffi/windows/structs.rb

@@ -198,7 +198,7 @@ module Puppet::FFI::Windows
         :dwWin32ExitCode, :dword,
         :dwServiceSpecificExitCode, :dword,
         :dwCheckPoint, :dword,
-        :dwWaitHint, :dword,
+        :dwWaitHint, :dword
       )
     end
 
@@ -223,7 +223,7 @@ module Puppet::FFI::Windows
         :dwTagId, :dword,
         :lpDependencies, :pointer,
         :lpServiceStartName, :pointer,
-        :lpDisplayName, :pointer,
+        :lpDisplayName, :pointer
       )
     end
 
@@ -258,7 +258,7 @@ module Puppet::FFI::Windows
       )
     end
 
-    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16_384
 
     # SYMLINK_REPARSE_DATA_BUFFER
     # https://msdn.microsoft.com/en-us/library/cc232006.aspx

data/lib/puppet/file_bucket/dipper.rb

@@ -52,7 +52,7 @@ class Puppet::FileBucket::Dipper
         Puppet::FileBucket::File.indirection.save(file_bucket_file, dest_path)
       end
 
-      return file_bucket_file.checksum_data
+      file_bucket_file.checksum_data
     rescue => detail
       message = _("Could not back up %{file}: %{detail}") % { file: file, detail: detail }
       Puppet.log_exception(detail, message)
@@ -139,7 +139,7 @@ class Puppet::FileBucket::Dipper
         changed = nil
         if Puppet::FileSystem.exist?(file_handle) and !Puppet::FileSystem.writable?(file_handle)
           changed = Puppet::FileSystem.stat(file_handle).mode
-          ::File.chmod(changed | 0200, file)
+          ::File.chmod(changed | 0o200, file)
         end
         ::File.open(file, ::File::WRONLY | ::File::TRUNC | ::File::CREAT) { |of|
           of.binmode
@@ -152,9 +152,9 @@ class Puppet::FileBucket::Dipper
         Puppet.err _("Could not find file with checksum %{sum}") % { sum: sum }
         return nil
       end
-      return newsum
+      newsum
     else
-      return nil
+      nil
     end
   end
 

data/lib/puppet/file_bucket/file.rb

@@ -26,12 +26,12 @@ class Puppet::FileBucket::File
     when Pathname
       @contents = FileContents.new(contents)
     else
-      raise ArgumentError.new(_("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class })
+      raise ArgumentError, _("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class }
     end
 
     @bucket_path = options.delete(:bucket_path)
     @checksum_type = Puppet[:digest_algorithm].to_sym
-    raise ArgumentError.new(_("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') }) unless options.empty?
+    raise ArgumentError, _("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') } unless options.empty?
   end
 
   # @return [Num] The size of the contents
@@ -73,7 +73,7 @@ class Puppet::FileBucket::File
   end
 
   def self.from_binary(contents)
-    self.new(contents)
+    new(contents)
   end
 
   class StringContents
@@ -102,7 +102,7 @@ class Puppet::FileBucket::File
     def to_binary
       # This is not so horrible as for FileContent, but still possible to mutate the content that the
       # checksum is based on... so semi horrible...
-      return @contents;
+      @contents;
     end
   end
 

data/lib/puppet/file_serving/base.rb

@@ -13,9 +13,9 @@ class Puppet::FileServing::Base
   # Does our file exist?
   def exist?
     stat
-    return true
+    true
   rescue
-    return false
+    false
   end
 
   # Return the full path to our file.  Fails if there's no path set.
@@ -59,7 +59,7 @@ class Puppet::FileServing::Base
   attr_reader :path
 
   def path=(path)
-    raise ArgumentError.new(_("Paths must be fully qualified")) unless Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Paths must be fully qualified") unless Puppet::FileServing::Base.absolute?(path)
 
     @path = path
   end
@@ -69,14 +69,14 @@ class Puppet::FileServing::Base
   attr_reader :relative_path
 
   def relative_path=(path)
-    raise ArgumentError.new(_("Relative paths must not be fully qualified")) if Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Relative paths must not be fully qualified") if Puppet::FileServing::Base.absolute?(path)
 
     @relative_path = path
   end
 
   # Stat our file, using the appropriate link-sensitive method.
   def stat
-    @stat_method ||= self.links == :manage ? :lstat : :stat
+    @stat_method ||= links == :manage ? :lstat : :stat
     Puppet::FileSystem.send(@stat_method, full_path)
   end
 

data/lib/puppet/file_serving/configuration/parser.rb

@@ -25,10 +25,10 @@ class Puppet::FileServing::Configuration::Parser
         when /^\s*#/; next # skip comments
         when /^\s*$/; next # skip blank lines
         when /\[([-\w]+)\]/
-          mount = newmount($1)
+          mount = newmount(::Regexp.last_match(1))
         when /^\s*(\w+)\s+(.+?)(\s*#.*)?$/
-          var = $1
-          value = $2
+          var = ::Regexp.last_match(1)
+          value = ::Regexp.last_match(2)
           value.strip!
           raise(ArgumentError, _("Fileserver configuration file does not use '=' as a separator")) if value =~ /^=/
 
@@ -43,13 +43,13 @@ class Puppet::FileServing::Configuration::Parser
             end
           else
             error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-            raise ArgumentError.new(_("Invalid argument '%{var}' at %{error_location}") %
-                                        { var: var, error_location: error_location_str })
+            raise ArgumentError, _("Invalid argument '%{var}' at %{error_location}") %
+                                 { var: var, error_location: error_location_str }
           end
         else
           error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-          raise ArgumentError.new(_("Invalid entry at %{error_location}: '%{file_text}'") %
-                                      { file_text: line.chomp, error_location: error_location_str })
+          raise ArgumentError, _("Invalid entry at %{error_location}: '%{file_text}'") %
+                               { file_text: line.chomp, error_location: error_location_str }
         end
       end
     end
@@ -73,8 +73,8 @@ class Puppet::FileServing::Configuration::Parser
   def newmount(name)
     if @mounts.include?(name)
       error_location_str = Puppet::Util::Errors.error_location(@file, @count)
-      raise ArgumentError.new(_("%{mount} is already mounted at %{name} at %{error_location}") %
-                                  { mount: @mounts[name], name: name, error_location: error_location_str })
+      raise ArgumentError, _("%{mount} is already mounted at %{name} at %{error_location}") %
+                           { mount: @mounts[name], name: name, error_location: error_location_str }
     end
     case name
     when "modules"

data/lib/puppet/file_serving/configuration.rb

@@ -56,7 +56,7 @@ class Puppet::FileServing::Configuration
 
     mount_name, path = request.key.split(File::Separator, 2)
 
-    raise(ArgumentError, _("Cannot find file: Invalid mount '%{mount_name}'") % { mount_name: mount_name }) unless mount_name =~ %r{^[-\w]+$}
+    raise(ArgumentError, _("Cannot find file: Invalid mount '%{mount_name}'") % { mount_name: mount_name }) unless mount_name =~ /^[-\w]+$/
     raise(ArgumentError, _("Cannot find file: Invalid relative path '%{path}'") % { path: path }) if path and path.split('/').include?('..')
 
     mount = find_mount(mount_name, request.environment)
@@ -71,10 +71,10 @@ class Puppet::FileServing::Configuration
       path = nil
     elsif path
       # Remove any double slashes that might have occurred
-      path = path.gsub(/\/+/, "/")
+      path = path.gsub(%r{/+}, "/")
     end
 
-    return mount, path
+    [mount, path]
   end
 
   def umount(name)

data/lib/puppet/file_serving/fileset.rb

@@ -29,11 +29,11 @@ class Puppet::FileServing::Fileset
   def initialize(path, options = {})
     if Puppet::Util::Platform.windows?
       # REMIND: UNC path
-      path = path.chomp(File::SEPARATOR) unless path =~ /^[A-Za-z]:\/$/
+      path = path.chomp(File::SEPARATOR) unless path =~ %r{^[A-Za-z]:/$}
     else
       path = path.chomp(File::SEPARATOR) unless path == File::SEPARATOR
     end
-    raise ArgumentError.new(_("Fileset paths must be fully qualified: %{path}") % { path: path }) unless Puppet::Util.absolute_path?(path)
+    raise ArgumentError, _("Fileset paths must be fully qualified: %{path}") % { path: path } unless Puppet::Util.absolute_path?(path)
 
     @path = path
 
@@ -50,9 +50,9 @@ class Puppet::FileServing::Fileset
       initialize_from_hash(options)
     end
 
-    raise ArgumentError.new(_("Fileset paths must exist")) unless valid?(path)
+    raise ArgumentError, _("Fileset paths must exist") unless valid?(path)
     # TRANSLATORS "recurse" and "recurselimit" are parameter names and should not be translated
-    raise ArgumentError.new(_("Fileset recurse parameter must not be a number anymore, please use recurselimit")) if @recurse.is_a?(Integer)
+    raise ArgumentError, _("Fileset recurse parameter must not be a number anymore, please use recurselimit") if @recurse.is_a?(Integer)
   end
 
   # Return a list of all files in our fileset.  This is different from the
@@ -68,7 +68,7 @@ class Puppet::FileServing::Fileset
     munged_max_files = max_files == '-1' ? -1 : max_files
 
     if munged_max_files > 0 && files.size > munged_max_files
-      raise Puppet::Error.new _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
+      raise Puppet::Error, _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
     elsif munged_max_files == 0 && files.size > soft_max_files
       Puppet.warning _("The directory '%{path}' contains %{entries} entries, which exceeds the default soft limit %{soft_max_files} and may cause excessive resource consumption and degraded performance. To remove this warning set a value for `max_files` parameter or consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, soft_max_files: soft_max_files }
     end
@@ -104,8 +104,8 @@ class Puppet::FileServing::Fileset
       method = option.to_s + "="
       begin
         send(method, value)
-      rescue NoMethodError
-        raise ArgumentError, _("Invalid option '%{option}'") % { option: option }, $!.backtrace
+      rescue NoMethodError => e
+        raise ArgumentError, _("Invalid option '%{option}'") % { option: option }, e.backtrace
       end
     end
   end
@@ -165,11 +165,11 @@ class Puppet::FileServing::Fileset
     result = []
 
     while entry = current_dirs.shift # rubocop:disable Lint/AssignmentInCondition
-      if continue_recursion_at?(entry.depth + 1)
-        entry.children.each do |child|
-          result << child.path
-          current_dirs << child
-        end
+      next unless continue_recursion_at?(entry.depth + 1)
+
+      entry.children.each do |child|
+        result << child.path
+        current_dirs << child
       end
     end
 
@@ -185,6 +185,6 @@ class Puppet::FileServing::Fileset
 
   def continue_recursion_at?(depth)
     # recurse if told to, and infinite recursion or current depth not at the limit
-    self.recurse && (self.recurselimit == :infinite || depth <= self.recurselimit)
+    recurse && (recurselimit == :infinite || depth <= recurselimit)
   end
 end

data/lib/puppet/file_serving/http_metadata.rb

@@ -20,7 +20,7 @@ class Puppet::FileServing::HttpMetadata < Puppet::FileServing::Metadata
     checksum = http_response['content-md5']
     if checksum
       # convert base64 digest to hex
-      checksum = checksum.unpack("m").first.unpack("H*").first
+      checksum = checksum.unpack1("m").unpack1("H*")
       @checksums[:md5] = "{md5}#{checksum}"
     end
 

data/lib/puppet/file_serving/metadata.rb

@@ -47,7 +47,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
 
     def initialize(stat, source_permissions)
       @stat = stat
-      @source_permissions_ignore = (!source_permissions || source_permissions == :ignore)
+      @source_permissions_ignore = !source_permissions || source_permissions == :ignore
     end
 
     def owner
@@ -59,7 +59,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
     end
 
     def mode
-      @source_permissions_ignore ? 0644 : @stat.mode
+      @source_permissions_ignore ? 0o644 : @stat.mode
     end
 
     def_delegators :@stat, :ftype
@@ -78,9 +78,9 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
 
     { :owner => 'S-1-5-32-544',
       :group => 'S-1-0-0',
-      :mode => 0644 }.each do |method, default_value|
+      :mode => 0o644 }.each do |method, default_value|
       define_method method do
-        return default_value
+        default_value
       end
     end
   end
@@ -107,20 +107,24 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
     @ftype = stat.ftype
 
     # We have to mask the mode, yay.
-    @mode = stat.mode & 007777
+    @mode = stat.mode & 0o07777
 
     case stat.ftype
     when "file"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
     when "directory" # Always just timestamp the directory.
       @checksum_type = "ctime"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", path).to_s
     when "link"
       @destination = Puppet::FileSystem.readlink(real_path)
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s rescue nil
+      @checksum = begin
+        "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
+      rescue
+        nil
+      end
     when "fifo", "socket"
       @checksum_type = "none"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
     else
       raise ArgumentError, _("Cannot manage files of type %{file_type}") % { file_type: stat.ftype }
     end