puppet 8.4.0-universal-darwin → 8.5.1-universal-darwin

data/spec/unit/pops/visitor_spec.rb

@@ -1,93 +0,0 @@
-require 'spec_helper'
-require 'puppet/pops'
-
-describe Puppet::Pops::Visitor do
-  describe "A visitor and a visitable in a configuration with min and max args set to 0" do
-    class DuckProcessor
-      def initialize
-        @friend_visitor = Puppet::Pops::Visitor.new(self, "friend", 0, 0)
-      end
-
-      def hi(o, *args)
-        @friend_visitor.visit(o, *args)
-      end
-
-      def friend_Duck(o)
-        "Hi #{o.class}"
-      end
-
-      def friend_Numeric(o)
-        "Howdy #{o.class}"
-      end
-    end
-
-    class Duck
-      include Puppet::Pops::Visitable
-    end
-
-    it "should select the expected method when there are no arguments" do
-      duck = Duck.new
-      duck_processor = DuckProcessor.new
-      expect(duck_processor.hi(duck)).to eq("Hi Duck")
-    end
-
-    it "should fail if there are too many arguments" do
-      duck = Duck.new
-      duck_processor = DuckProcessor.new
-      expect { duck_processor.hi(duck, "how are you?") }.to raise_error(/^Visitor Error: Too many.*/)
-    end
-
-    it "should select method for superclass" do
-      duck_processor = DuckProcessor.new
-      expect(duck_processor.hi(42)).to match(/Howdy Integer/)
-    end
-
-    it "should select method for superclass" do
-      duck_processor = DuckProcessor.new
-      expect(duck_processor.hi(42.0)).to eq("Howdy Float")
-    end
-
-    it "should fail if class not handled" do
-      duck_processor = DuckProcessor.new
-      expect { duck_processor.hi("wassup?") }.to raise_error(/Visitor Error: the configured.*/)
-    end
-  end
-
-  describe "A visitor and a visitable in a configuration with min =1, and max args set to 2" do
-    class DuckProcessor2
-      def initialize
-        @friend_visitor = Puppet::Pops::Visitor.new(self, "friend", 1, 2)
-      end
-
-      def hi(o, *args)
-        @friend_visitor.visit(o, *args)
-      end
-
-      def friend_Duck(o, drink, eat="grain")
-        "Hi #{o.class}, drink=#{drink}, eat=#{eat}"
-      end
-    end
-
-    class Duck
-      include Puppet::Pops::Visitable
-    end
-
-    it "should select the expected method when there are is one arguments" do
-      duck = Duck.new
-      duck_processor = DuckProcessor2.new
-      expect(duck_processor.hi(duck, "water")).to eq("Hi Duck, drink=water, eat=grain")
-    end
-
-    it "should fail if there are too many arguments" do
-      duck = Duck.new
-      duck_processor = DuckProcessor2.new
-      expect { duck_processor.hi(duck, "scotch", "soda", "peanuts") }.to raise_error(/^Visitor Error: Too many.*/)
-    end
-
-    it "should fail if there are too few arguments" do
-      duck = Duck.new
-      duck_processor = DuckProcessor2.new
-      expect { duck_processor.hi(duck) }.to raise_error(/^Visitor Error: Too few.*/)
-    end
-  end
-end

data/spec/unit/property/boolean_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-require 'puppet/property/boolean'
-
-describe Puppet::Property::Boolean do
-  let (:resource) { double('resource') }
-  subject { described_class.new(:resource => resource) }
-
-  [ true, :true, 'true', :yes, 'yes', 'TrUe', 'yEs' ].each do |arg|
-    it "should munge #{arg.inspect} as true" do
-      expect(subject.munge(arg)).to eq(true)
-    end
-  end
-  [ false, :false, 'false', :no, 'no', 'FaLSE', 'nO' ].each do |arg|
-    it "should munge #{arg.inspect} as false" do
-      expect(subject.munge(arg)).to eq(false)
-    end
-  end
-  [ nil, :undef, 'undef', '0', 0, '1', 1, 9284 ].each do |arg|
-    it "should fail to munge #{arg.inspect}" do
-      expect { subject.munge(arg) }.to raise_error Puppet::Error
-    end
-  end
-end
-

data/spec/unit/property/ensure_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/property/ensure'
-
-klass = Puppet::Property::Ensure
-
-describe klass do
-  it "should be a subclass of Property" do
-    expect(klass.superclass).to eq(Puppet::Property)
-  end
-end

data/spec/unit/property/keyvalue_spec.rb

@@ -1,259 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/property/keyvalue'
-
-describe 'Puppet::Property::KeyValue' do 
-  let(:klass) { Puppet::Property::KeyValue }
-
-  it "should be a subclass of Property" do
-    expect(klass.superclass).to eq(Puppet::Property)
-  end
-
-  describe "as an instance" do
-    before do
-      # Wow that's a messy interface to the resource.
-      klass.initvars
-      @resource = double('resource', :[]= => nil, :property => nil)
-      @property = klass.new(:resource => @resource)
-      klass.log_only_changed_or_new_keys = false
-    end
-
-    it "should have a , as default delimiter" do
-      expect(@property.delimiter).to eq(";")
-    end
-
-    it "should have a = as default separator" do
-      expect(@property.separator).to eq("=")
-    end
-
-    it "should have a :membership as default membership" do
-      expect(@property.membership).to eq(:key_value_membership)
-    end
-
-    it "should return the same value passed into should_to_s" do
-      @property.should_to_s({:foo => "baz", :bar => "boo"}) == "foo=baz;bar=boo"
-    end
-
-    it "should return the passed in hash values joined with the delimiter from is_to_s" do
-      s = @property.is_to_s({"foo" => "baz" , "bar" => "boo"})
-
-      # We can't predict the order the hash is processed in...
-      expect(["foo=baz;bar=boo", "bar=boo;foo=baz"]).to be_include s
-    end
-
-    describe "when calling hash_to_key_value_s" do
-      let(:input) do
-        {
-          :key1 => "value1",
-          :key2 => "value2",
-          :key3 => "value3"
-        }
-      end
-
-      before(:each) do
-        @property.instance_variable_set(:@changed_or_new_keys, [:key1, :key2])
-      end
-
-      it "returns only the changed or new keys if log_only_changed_or_new_keys is set" do
-        klass.log_only_changed_or_new_keys = true
-
-        expect(@property.hash_to_key_value_s(input)).to eql("key1=value1;key2=value2")
-      end
-    end
-
-    describe "when calling inclusive?" do
-      it "should use the membership method to look up on the @resource" do
-        expect(@property).to receive(:membership).and_return(:key_value_membership)
-        expect(@resource).to receive(:[]).with(:key_value_membership)
-        @property.inclusive?
-      end
-
-      it "should return true when @resource[membership] == inclusive" do
-        allow(@property).to receive(:membership).and_return(:key_value_membership)
-        allow(@resource).to receive(:[]).with(:key_value_membership).and_return(:inclusive)
-        expect(@property.inclusive?).to eq(true)
-      end
-
-      it "should return false when @resource[membership] != inclusive" do
-        allow(@property).to receive(:membership).and_return(:key_value_membership)
-        allow(@resource).to receive(:[]).with(:key_value_membership).and_return(:minimum)
-        expect(@property.inclusive?).to eq(false)
-      end
-    end
-
-    describe "when calling process_current_hash" do
-      it "should return {} if hash is :absent" do
-        expect(@property.process_current_hash(:absent)).to eq({})
-      end
-
-      it "should set every key to nil if inclusive?" do
-        allow(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.process_current_hash({:foo => "bar", :do => "re"})).to eq({ :foo => nil, :do => nil })
-      end
-
-      it "should return the hash if !inclusive?" do
-        allow(@property).to receive(:inclusive?).and_return(false)
-        expect(@property.process_current_hash({:foo => "bar", :do => "re"})).to eq({:foo => "bar", :do => "re"})
-      end
-    end
-
-    describe "when calling should" do
-      it "should return nil if @should is nil" do
-        expect(@property.should).to eq(nil)
-      end
-
-      it "should call process_current_hash" do
-        @property.should = ["foo=baz", "bar=boo"]
-        allow(@property).to receive(:retrieve).and_return({:do => "re", :mi => "fa" })
-        expect(@property).to receive(:process_current_hash).and_return({})
-        @property.should
-      end
-
-      it "should return the hashed values of @should and the nilled values of retrieve if inclusive" do
-        @property.should = ["foo=baz", "bar=boo"]
-        expect(@property).to receive(:retrieve).and_return({:do => "re", :mi => "fa" })
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.should).to eq({ :foo => "baz", :bar => "boo", :do => nil, :mi => nil })
-      end
-
-      it "should return the hashed @should + the unique values of retrieve if !inclusive" do
-        @property.should = ["foo=baz", "bar=boo"]
-        expect(@property).to receive(:retrieve).and_return({:foo => "diff", :do => "re", :mi => "fa"})
-        expect(@property).to receive(:inclusive?).and_return(false)
-        expect(@property.should).to eq({ :foo => "baz", :bar => "boo", :do => "re", :mi => "fa" })
-      end
-
-      it "should mark the keys that will change or be added as a result of our Puppet run" do
-        @property.should = {
-          :key1 => "new_value1",
-          :key2 => "value2",
-          :key3 => "new_value3",
-          :key4 => "value4"
-        }
-        allow(@property).to receive(:retrieve).and_return(
-          {
-            :key1 => "value1",
-            :key2 => "value2",
-            :key3 => "value3"
-          }
-        )
-        allow(@property).to receive(:inclusive?).and_return(false)
-
-        @property.should
-        expect(@property.instance_variable_get(:@changed_or_new_keys)).to eql([:key1, :key3, :key4])
-      end
-    end
-
-    describe "when calling retrieve" do
-      before do
-        @provider = double("provider")
-        allow(@property).to receive(:provider).and_return(@provider)
-      end
-
-      it "should send 'name' to the provider" do
-        expect(@provider).to receive(:send).with(:keys)
-        expect(@property).to receive(:name).and_return(:keys)
-        @property.retrieve
-      end
-
-      it "should return a hash with the provider returned info" do
-        allow(@provider).to receive(:send).with(:keys).and_return({"do" => "re", "mi" => "fa" })
-        allow(@property).to receive(:name).and_return(:keys)
-        @property.retrieve == {"do" => "re", "mi" => "fa" }
-      end
-
-      it "should return :absent when the provider returns :absent" do
-        allow(@provider).to receive(:send).with(:keys).and_return(:absent)
-        allow(@property).to receive(:name).and_return(:keys)
-        @property.retrieve == :absent
-      end
-    end
-
-    describe "when calling hashify_should" do
-      it "should return the underlying hash if the user passed in a hash" do
-        @property.should = { "foo" => "bar" }
-        expect(@property.hashify_should).to eql({ :foo => "bar" })
-      end
-
-      it "should hashify the array of key/value pairs if that is what our user passed in" do
-        @property.should = [ "foo=baz", "bar=boo" ]
-        expect(@property.hashify_should).to eq({ :foo => "baz", :bar => "boo" })
-      end
-    end
-
-    describe "when calling safe_insync?" do
-      before do
-        @provider = double("provider")
-        allow(@property).to receive(:provider).and_return(@provider)
-        allow(@property).to receive(:name).and_return(:prop_name)
-      end
-
-      it "should return true unless @should is defined and not nil" do
-        @property.safe_insync?("foo") == true
-      end
-
-      it "should return true if the passed in values is nil" do
-        @property.safe_insync?(nil) == true
-      end
-
-      it "should return true if hashified should value == (retrieved) value passed in" do
-        allow(@provider).to receive(:prop_name).and_return({ :foo => "baz", :bar => "boo" })
-        @property.should = ["foo=baz", "bar=boo"]
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.safe_insync?({ :foo => "baz", :bar => "boo" })).to eq(true)
-      end
-
-      it "should return false if prepared value != should value" do
-        allow(@provider).to receive(:prop_name).and_return({ "foo" => "bee", "bar" => "boo" })
-        @property.should = ["foo=baz", "bar=boo"]
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.safe_insync?({ "foo" => "bee", "bar" => "boo" })).to eq(false)
-      end
-    end
-
-    describe 'when validating a passed-in property value' do
-      it 'should raise a Puppet::Error if the property value is anything but a Hash or a String' do
-        expect { @property.validate(5) }.to raise_error do |error|
-          expect(error).to be_a(Puppet::Error)
-          expect(error.message).to match("specified as a hash or an array")
-        end
-      end
-
-      it 'should accept a Hash property value' do
-        @property.validate({ 'foo' => 'bar' })
-      end
-
-      it "should raise a Puppet::Error if the property value isn't a key/value pair" do
-        expect { @property.validate('foo') }.to raise_error do |error|
-          expect(error).to be_a(Puppet::Error)
-          expect(error.message).to match("separated by '='")
-        end
-      end
-
-      it 'should accept a valid key/value pair property value' do
-        @property.validate('foo=bar')
-      end
-    end
-
-    describe 'when munging a passed-in property value' do
-      it 'should return the value as-is if it is a string' do
-        expect(@property.munge('foo=bar')).to eql('foo=bar')
-      end
-
-      it 'should stringify + symbolize the keys and stringify the values if it is a hash' do
-        input = {
-          1     => 2,
-          true  => false,
-          '   foo   ' => 'bar'
-        }
-        expected_output = {
-          :'1'    => '2',
-          :true => 'false',
-          :foo  => 'bar'
-        }
-
-        expect(@property.munge(input)).to eql(expected_output)
-      end
-    end
-  end
-end

data/spec/unit/property/list_spec.rb

@@ -1,172 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/property/list'
-
-list_class = Puppet::Property::List
-
-describe list_class do
-
-  it "should be a subclass of Property" do
-    expect(list_class.superclass).to eq(Puppet::Property)
-  end
-
-  describe "as an instance" do
-    before do
-      # Wow that's a messy interface to the resource.
-      list_class.initvars
-      @resource = double('resource', :[]= => nil, :property => nil)
-      @property = list_class.new(:resource => @resource)
-    end
-
-    it "should have a , as default delimiter" do
-      expect(@property.delimiter).to eq(",")
-    end
-
-    it "should have a :membership as default membership" do
-      expect(@property.membership).to eq(:membership)
-    end
-
-    it "should return the same value passed into should_to_s" do
-      @property.should_to_s("foo") == "foo"
-    end
-
-    it "should return the passed in array values joined with the delimiter from is_to_s" do
-      expect(@property.is_to_s(["foo","bar"])).to eq("foo,bar")
-    end
-
-    it "should be able to correctly convert ':absent' to a quoted string" do
-      expect(@property.is_to_s(:absent)).to eq("'absent'")
-    end
-
-    describe "when adding should to current" do
-      it "should add the arrays when current is an array" do
-        expect(@property.add_should_with_current(["foo"], ["bar"])).to eq(["foo", "bar"])
-      end
-
-      it "should return should if current is not an array" do
-        expect(@property.add_should_with_current(["foo"], :absent)).to eq(["foo"])
-      end
-
-      it "should return only the uniq elements" do
-        expect(@property.add_should_with_current(["foo", "bar"], ["foo", "baz"])).to eq(["foo", "bar", "baz"])
-      end
-    end
-
-    describe "when calling inclusive?" do
-      it "should use the membership method to look up on the @resource" do
-        expect(@property).to receive(:membership).and_return(:membership)
-        expect(@resource).to receive(:[]).with(:membership)
-        @property.inclusive?
-      end
-
-      it "should return true when @resource[membership] == inclusive" do
-        allow(@property).to receive(:membership).and_return(:membership)
-        allow(@resource).to receive(:[]).with(:membership).and_return(:inclusive)
-        expect(@property.inclusive?).to eq(true)
-      end
-
-      it "should return false when @resource[membership] != inclusive" do
-        allow(@property).to receive(:membership).and_return(:membership)
-        allow(@resource).to receive(:[]).with(:membership).and_return(:minimum)
-        expect(@property.inclusive?).to eq(false)
-      end
-    end
-
-    describe "when calling should" do
-      it "should return nil if @should is nil" do
-        expect(@property.should).to eq(nil)
-      end
-
-      it "should return the sorted values of @should as a string if inclusive" do
-        @property.should = ["foo", "bar"]
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.should).to eq("bar,foo")
-      end
-
-      it "should return the uniq sorted values of @should + retrieve as a string if !inclusive" do
-        @property.should = ["foo", "bar"]
-        expect(@property).to receive(:inclusive?).and_return(false)
-        expect(@property).to receive(:retrieve).and_return(["foo","baz"])
-        expect(@property.should).to eq("bar,baz,foo")
-      end
-    end
-
-    describe "when calling retrieve" do
-      let(:provider) { @provider }
-      before do
-        @provider = double("provider")
-        allow(@property).to receive(:provider).and_return(provider)
-      end
-
-      it "should send 'name' to the provider" do
-        expect(@provider).to receive(:send).with(:group)
-        expect(@property).to receive(:name).and_return(:group)
-        @property.retrieve
-      end
-
-      it "should return an array with the provider returned info" do
-        allow(@provider).to receive(:send).with(:group).and_return("foo,bar,baz")
-        allow(@property).to receive(:name).and_return(:group)
-        @property.retrieve == ["foo", "bar", "baz"]
-      end
-
-      it "should return :absent when the provider returns :absent" do
-        allow(@provider).to receive(:send).with(:group).and_return(:absent)
-        allow(@property).to receive(:name).and_return(:group)
-        @property.retrieve == :absent
-      end
-
-      context "and provider is nil" do
-        let(:provider) { nil }
-        it "should return :absent" do
-          @property.retrieve == :absent
-        end
-      end
-    end
-
-    describe "when calling safe_insync?" do
-      it "should return true unless @should is defined and not nil" do
-        expect(@property).to be_safe_insync("foo")
-      end
-
-      it "should return true unless the passed in values is not nil" do
-        @property.should = "foo"
-        expect(@property).to be_safe_insync(nil)
-      end
-
-      it "should call prepare_is_for_comparison with value passed in and should" do
-        @property.should = "foo"
-        expect(@property).to receive(:prepare_is_for_comparison).with("bar")
-        expect(@property).to receive(:should)
-        @property.safe_insync?("bar")
-      end
-
-      it "should return true if 'is' value is array of comma delimited should values" do
-        @property.should = "bar,foo"
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property).to be_safe_insync(["bar","foo"])
-      end
-
-      it "should return true if 'is' value is :absent and should value is empty string" do
-        @property.should = ""
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property).to be_safe_insync([])
-      end
-
-      it "should return false if prepared value != should value" do
-        @property.should = "bar,baz,foo"
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property).to_not be_safe_insync(["bar","foo"])
-      end
-    end
-
-    describe "when calling dearrayify" do
-      it "should sort and join the array with 'delimiter'" do
-        array = double("array")
-        expect(array).to receive(:sort).and_return(array)
-        expect(array).to receive(:join).with(@property.delimiter)
-        @property.dearrayify(array)
-      end
-    end
-  end
-end

data/spec/unit/property/ordered_list_spec.rb

@@ -1,59 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/property/ordered_list'
-
-describe Puppet::Property::OrderedList do
-  it "should be a subclass of List" do
-    expect(described_class.superclass).to eq(Puppet::Property::List)
-  end
-
-  describe "as an instance" do
-    before do
-      # Wow that's a messy interface to the resource.
-      described_class.initvars
-      @resource = double('resource', :[]= => nil, :property => nil)
-      @property = described_class.new(:resource => @resource)
-    end
-
-    describe "when adding should to current" do
-      it "should add the arrays when current is an array" do
-        expect(@property.add_should_with_current(["should"], ["current"])).to eq(["should", "current"])
-      end
-
-      it "should return 'should' if current is not an array" do
-        expect(@property.add_should_with_current(["should"], :absent)).to eq(["should"])
-      end
-
-      it "should return only the uniq elements leading with the order of 'should'" do
-        expect(@property.add_should_with_current(["this", "is", "should"], ["is", "this", "current"])).to eq(["this", "is", "should", "current"])
-      end
-    end
-
-    describe "when calling should" do
-      it "should return nil if @should is nil" do
-        expect(@property.should).to eq(nil)
-      end
-
-      it "should return the values of @should (without sorting) as a string if inclusive" do
-        @property.should = ["foo", "bar"]
-        expect(@property).to receive(:inclusive?).and_return(true)
-        expect(@property.should).to eq("foo,bar")
-      end
-
-      it "should return the uniq values of @should + retrieve as a string if !inclusive with the @ values leading" do
-        @property.should = ["foo", "bar"]
-        expect(@property).to receive(:inclusive?).and_return(false)
-        expect(@property).to receive(:retrieve).and_return(["foo","baz"])
-        expect(@property.should).to eq("foo,bar,baz")
-      end
-    end
-
-    describe "when calling dearrayify" do
-      it "should join the array with the delimiter" do
-        array = double("array")
-        expect(array).to receive(:join).with(@property.delimiter)
-        @property.dearrayify(array)
-      end
-    end
-  end
-end