puppet 8.4.0-universal-darwin → 8.5.0-universal-darwin

data/lib/puppet/face/parser.rb

@@ -65,7 +65,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       end
 
       unless missing_files.empty?
-        raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{files}") % { files: missing_files.collect {|f| " " * 3 + f + "\n"} }
+        raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{files}") % { files: missing_files.collect { |f| " " * 3 + f + "\n" } }
       end
 
       parse_errors
@@ -84,12 +84,12 @@ Puppet::Face.define(:parser, '0.0.1') do
 
     when_rendering :json do |errors|
       unless errors.empty?
-        ignore_error_keys = [ :arguments, :environment, :node ]
+        ignore_error_keys = [:arguments, :environment, :node]
 
-        data = errors.map do |file, error|
+        data = errors.to_h do |file, error|
           file_errors = error.to_h.reject { |k, _| ignore_error_keys.include?(k) }
           [file, file_errors]
-        end.to_h
+        end
 
         puts Puppet::Util::Json.dump(Puppet::Pops::Serialization::ToDataConverter.convert(data, rich_data: false, symbol_as_string: true), :pretty => true)
 
@@ -148,7 +148,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       if options[:e]
         dump_parse(options[:e], 'command-line-string', options, false)
       elsif args.empty?
-        if ! STDIN.tty?
+        if !STDIN.tty?
           dump_parse(STDIN.read, 'stdin', options, false)
         else
           raise Puppet::Error, _("No input to parse given on command line or stdin")
@@ -213,7 +213,7 @@ Puppet::Face.define(:parser, '0.0.1') do
     env = Puppet.lookup(:current_environment)
     loaders = Puppet::Pops::Loaders.new(env)
 
-    Puppet.override( {:loaders => loaders } , _('For puppet parser validate')) do
+    Puppet.override({ :loaders => loaders }, _('For puppet parser validate')) do
       begin
         validation_environment = manifest ? env.override_with(:manifest => manifest) : env
         validation_environment.check_for_reparse

data/lib/puppet/feature/base.rb

@@ -18,7 +18,7 @@ end
 # We can use Microsoft Windows functions
 Puppet.features.add(:microsoft_windows) { Puppet::Util::Platform.windows? }
 
-raise Puppet::Error,_("Cannot determine basic system flavour") unless Puppet.features.posix? or Puppet.features.microsoft_windows?
+raise Puppet::Error, _("Cannot determine basic system flavour") unless Puppet.features.posix? or Puppet.features.microsoft_windows?
 
 # We've got LDAP available.
 Puppet.features.add(:ldap, :libs => ["ldap"])
@@ -51,7 +51,7 @@ Puppet.features.add(:minitar, :libs => ["archive/tar/minitar"])
 
 # We can manage symlinks
 Puppet.features.add(:manages_symlinks) do
-  if ! Puppet::Util::Platform.windows?
+  if !Puppet::Util::Platform.windows?
     true
   else
     module WindowsSymlink

data/lib/puppet/feature/libuser.rb

@@ -5,6 +5,6 @@ require_relative '../../puppet/util/libuser'
 
 Puppet.features.add(:libuser) {
   File.executable?("/usr/sbin/lgroupadd") and
-  File.executable?("/usr/sbin/luseradd")  and
-  Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
+    File.executable?("/usr/sbin/luseradd") and
+    Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
 }

data/lib/puppet/ffi/posix/constants.rb

@@ -5,7 +5,7 @@ require_relative '../../../puppet/ffi/posix'
 module Puppet::FFI::POSIX
   module Constants
     extend FFI::Library
-  
+
     # Maximum number of supplementary groups (groups
     # that a user can be in plus its primary group)
     # (64 + 1 primary group)

data/lib/puppet/ffi/windows/functions.rb

@@ -235,7 +235,7 @@ module Puppet::FFI::Windows
     # );
     ffi_lib :advapi32
     attach_function_private :GetTokenInformation,
-                            [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword ], :win32_bool
+                            [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx
     # BOOL WINAPI GetVersionEx(

data/lib/puppet/file_bucket/dipper.rb

@@ -32,7 +32,7 @@ class Puppet::FileBucket::Dipper
   end
 
   def local?
-    !! @local_path
+    !!@local_path
   end
 
   # Backs up a file to the file bucket
@@ -70,7 +70,8 @@ class Puppet::FileBucket::Dipper
         file_diff = Puppet::FileBucket::File.indirection.find(
           source_path,
           :bucket_path => @local_path,
-          :diff_with => checksum_b)
+          :diff_with => checksum_b
+        )
       elsif file_b
         tmp_file = ::Tempfile.new('diff')
         begin
@@ -136,11 +137,11 @@ class Puppet::FileBucket::Dipper
       if newcontents
         newsum = newcontents.checksum_data
         changed = nil
-        if Puppet::FileSystem.exist?(file_handle) and ! Puppet::FileSystem.writable?(file_handle)
+        if Puppet::FileSystem.exist?(file_handle) and !Puppet::FileSystem.writable?(file_handle)
           changed = Puppet::FileSystem.stat(file_handle).mode
           ::File.chmod(changed | 0200, file)
         end
-        ::File.open(file, ::File::WRONLY|::File::TRUNC|::File::CREAT) { |of|
+        ::File.open(file, ::File::WRONLY | ::File::TRUNC | ::File::CREAT) { |of|
           of.binmode
           newcontents.stream do |source_stream|
             FileUtils.copy_stream(source_stream, of)
@@ -167,7 +168,8 @@ class Puppet::FileBucket::Dipper
       :bucket_path => @local_path,
       :list_all => true,
       :fromdate => fromdate,
-      :todate => todate)
+      :todate => todate
+    )
     raise Puppet::Error, _("File not found") unless file_bucket_list
 
     file_bucket_list.to_s
@@ -175,7 +177,7 @@ class Puppet::FileBucket::Dipper
 
   private
 
-  def absolutize_path( path )
+  def absolutize_path(path)
     Pathname.new(path).realpath
   end
 end

data/lib/puppet/file_bucket/file.rb

@@ -13,7 +13,7 @@ class Puppet::FileBucket::File
   extend Puppet::Indirector
   indirects :file_bucket_file, :terminus_class => :selector
 
-  attr :bucket_path
+  attr_reader :bucket_path
 
   def self.supported_formats
     [:binary]
@@ -125,7 +125,7 @@ class Puppet::FileBucket::File
     end
 
     def to_binary
-      Puppet::FileSystem::binread(@path)
+      Puppet::FileSystem.binread(@path)
     end
   end
 end

data/lib/puppet/file_serving/configuration.rb

@@ -100,7 +100,7 @@ class Puppet::FileServing::Configuration
 
     @parser ||= Puppet::FileServing::Configuration::Parser.new(config)
 
-    return if check and ! @parser.changed?
+    return if check and !@parser.changed?
 
     # Don't assign the mounts hash until we're sure the parsing succeeded.
     begin

data/lib/puppet/file_serving/fileset.rb

@@ -139,8 +139,8 @@ class Puppet::FileServing::Fileset
       return [] unless directory?
 
       Dir.entries(path, encoding: Encoding::UTF_8)
-        .reject { |child| ignore?(child) }
-        .collect { |child| down_level(child) }
+         .reject { |child| ignore?(child) }
+         .collect { |child| down_level(child) }
     end
 
     def ignore?(child)

data/lib/puppet/file_serving/http_metadata.rb

@@ -50,7 +50,7 @@ class Puppet::FileServing::HttpMetadata < Puppet::FileServing::Metadata
   def collect
     # Prefer the checksum_type from the indirector request options
     # but fall back to the alternative otherwise
-    [ @checksum_type, :sha256, :sha1, :md5, :mtime ].each do |type|
+    [@checksum_type, :sha256, :sha1, :md5, :mtime].each do |type|
       @checksum_type = type
       @checksum = @checksums[type]
       break if @checksum

data/lib/puppet/file_serving/metadata.rb

@@ -78,8 +78,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
 
     { :owner => 'S-1-5-32-544',
       :group => 'S-1-0-0',
-      :mode => 0644
-    }.each do |method, default_value|
+      :mode => 0644 }.each do |method, default_value|
       define_method method do
         return default_value
       end
@@ -127,7 +126,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
     end
   end
 
-  def initialize(path,data={})
+  def initialize(path, data = {})
     @owner       = data.delete('owner')
     @group       = data.delete('group')
     @mode        = data.delete('mode')
@@ -160,8 +159,8 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
         },
         'type' => ftype,
         'destination' => destination,
-      }.merge(content_uri ? {'content_uri' => content_uri} : {})
-       .merge(source ? {'source' => source} : {})
+      }.merge(content_uri ? { 'content_uri' => content_uri } : {})
+       .merge(source ? { 'source' => source } : {})
     )
   end
 

data/lib/puppet/file_serving/terminus_selector.rb

@@ -18,7 +18,7 @@ module Puppet::FileServing::TerminusSelector
       else
         Puppet[:default_file_terminus]
       end
-    when "http","https"
+    when "http", "https"
       :http
     when nil
       if Puppet::Util.absolute_path?(request.key)

data/lib/puppet/file_system/file_impl.rb

@@ -54,13 +54,13 @@ class Puppet::FileSystem::FileImpl
     written = false
     while !written
       ::File.open(path, options, mode) do |rf|
-        if rf.flock(::File::LOCK_EX|::File::LOCK_NB)
-          Puppet.debug{ _("Locked '%{path}'") % { path: path } }
+        if rf.flock(::File::LOCK_EX | ::File::LOCK_NB)
+          Puppet.debug { _("Locked '%{path}'") % { path: path } }
           yield rf
           written = true
-          Puppet.debug{ _("Unlocked '%{path}'") % { path: path } }
+          Puppet.debug { _("Unlocked '%{path}'") % { path: path } }
         else
-          Puppet.debug{ "Failed to lock '%s' retrying in %.2f milliseconds" % [path, wait * 1000] }
+          Puppet.debug { "Failed to lock '%s' retrying in %.2f milliseconds" % [path, wait * 1000] }
           sleep wait
           timeout -= wait
           wait *= 2

data/lib/puppet/file_system/uniquefile.rb

@@ -28,7 +28,7 @@ class Puppet::FileSystem::Uniquefile < DelegateClass(File)
 
   def initialize(basename, *rest)
     create_tmpname(basename, *rest) do |tmpname, _n, opts|
-      mode = File::RDWR|File::CREAT|File::EXCL
+      mode = File::RDWR | File::CREAT | File::EXCL
       perm = 0600
       if opts
         mode |= opts.delete(:mode) || 0
@@ -41,7 +41,7 @@ class Puppet::FileSystem::Uniquefile < DelegateClass(File)
         @tmpfile = File.open(tmpname, mode, opts)
         @tmpname = tmpname
       end
-      @mode = mode & ~(File::CREAT|File::EXCL)
+      @mode = mode & ~(File::CREAT | File::EXCL)
       perm or opts.freeze
       @opts = opts
     end
@@ -65,7 +65,7 @@ class Puppet::FileSystem::Uniquefile < DelegateClass(File)
   end
   protected :_close
 
-  def close(unlink_now=false)
+  def close(unlink_now = false)
     if unlink_now
       close!
     else
@@ -153,7 +153,7 @@ class Puppet::FileSystem::Uniquefile < DelegateClass(File)
 
   def tmpdir
     tmp = '.'
-    for dir in [ ENV['TMPDIR'], ENV['TMP'], ENV['TEMP'], @@systmpdir, '/tmp']
+    [ENV.fetch('TMPDIR', nil), ENV.fetch('TMP', nil), ENV.fetch('TEMP', nil), @@systmpdir, '/tmp'].each do |dir|
       stat = File.stat(dir) if dir
       if stat && stat.directory? && stat.writable?
         tmp = dir

data/lib/puppet/file_system/windows.rb

@@ -61,7 +61,7 @@ class Puppet::FileSystem::Windows < Puppet::FileSystem::Posix
   end
 
   def symlink?(path)
-    return false if ! Puppet.features.manages_symlinks?
+    return false if !Puppet.features.manages_symlinks?
 
     Puppet::Util::Windows::File.symlink?(path)
   end
@@ -72,7 +72,7 @@ class Puppet::FileSystem::Windows < Puppet::FileSystem::Posix
   end
 
   def unlink(*file_names)
-    if ! Puppet.features.manages_symlinks?
+    if !Puppet.features.manages_symlinks?
       return ::File.unlink(*file_names)
     end
 
@@ -102,7 +102,7 @@ class Puppet::FileSystem::Windows < Puppet::FileSystem::Posix
   end
 
   def lstat(path)
-    if ! Puppet.features.manages_symlinks?
+    if !Puppet.features.manages_symlinks?
       return Puppet::Util::Windows::File.stat(path)
     end
 
@@ -114,8 +114,8 @@ class Puppet::FileSystem::Windows < Puppet::FileSystem::Posix
   end
 
   def read_preserve_line_endings(path)
-    contents = path.read( :mode => 'rb', :encoding => 'bom|utf-8')
-    contents = path.read( :mode => 'rb', :encoding => "bom|#{Encoding::default_external.name}") unless contents.valid_encoding?
+    contents = path.read(:mode => 'rb', :encoding => 'bom|utf-8')
+    contents = path.read(:mode => 'rb', :encoding => "bom|#{Encoding.default_external.name}") unless contents.valid_encoding?
     contents = path.read unless contents.valid_encoding?
 
     contents
@@ -204,12 +204,12 @@ class Puppet::FileSystem::Windows < Puppet::FileSystem::Posix
   end
 
   def raise_if_symlinks_unsupported
-    if ! Puppet.features.manages_symlinks?
+    if !Puppet.features.manages_symlinks?
       msg = _("This version of Windows does not support symlinks.  Windows Vista / 2008 or higher is required.")
       raise Puppet::Util::Windows::Error.new(msg)
     end
 
-    if ! Puppet::Util::Windows::Process.process_privilege_symlink?
+    if !Puppet::Util::Windows::Process.process_privilege_symlink?
       Puppet.warning _("The current user does not have the necessary permission to manage symlinks.")
     end
   end

data/lib/puppet/file_system.rb

@@ -288,7 +288,7 @@ module Puppet::FileSystem
   # @api public
   #
   def self.unlink(*paths)
-    @impl.unlink(*(paths.map {|p| assert_path(p) }))
+    @impl.unlink(*(paths.map { |p| assert_path(p) }))
   end
 
   # @return [File::Stat] object for the named file.

data/lib/puppet/forge/cache.rb

@@ -43,7 +43,7 @@ class Puppet::Forge
 
     # Return Pathname for repository's cache directory, create it if needed.
     def path
-      (self.class.base_path + @repository.cache_key).tap{ |o| o.mkpath }
+      (self.class.base_path + @repository.cache_key).tap { |o| o.mkpath }
     end
 
     # Return the base Pathname for all the caches.

data/lib/puppet/forge/repository.rb

@@ -47,7 +47,7 @@ class Puppet::Forge
         end
 
         http = Puppet.runtime[:http]
-        response = http.get(uri, headers: headers, options: {ssl_context: @ssl_context})
+        response = http.get(uri, headers: headers, options: { ssl_context: @ssl_context })
         io.write(response.body) if io.respond_to?(:write)
         response
       rescue Puppet::SSL::CertVerifyError => e

data/lib/puppet/forge.rb

@@ -20,7 +20,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
   USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
-  MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
+  MODULE_RELEASE_EXCLUSIONS = %w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
 
   attr_reader :host, :repository
 
@@ -139,14 +139,14 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
             Puppet::ModuleTool.parse_module_dependency(release, dep)[0..1]
           rescue ArgumentError => e
             raise ArgumentError, _("Malformed dependency: %{name}.") % { name: dep['name'] } +
-                ' ' + _("Exception was: %{detail}") % { detail: e }
+                                 ' ' + _("Exception was: %{detail}") % { detail: e }
           end
         end
       else
         dependencies = []
       end
 
-      super(source, name, version, Hash[dependencies])
+      super(source, name, version, dependencies.to_h)
     end
 
     def install(dir)

data/lib/puppet/functions/abs.rb

@@ -20,7 +20,7 @@
 # ```puppet
 # abs(Numeric($str_val))
 # ```
-# 
+#
 # It is worth noting that `Numeric` can convert to absolute value
 # directly as in the following examples:
 #
@@ -52,9 +52,10 @@ Puppet::Functions.create_function(:abs) do
     # These patterns for conversion are backwards compatible with the stdlib
     # version of this function.
     #
-    if x =~ %r{^-?(?:\d+)(?:\.\d+){1}$}
+    case x
+    when %r{^-?(?:\d+)(?:\.\d+){1}$}
       x.to_f.abs
-    elsif x =~ %r{^-?\d+$}
+    when %r{^-?\d+$}
       x.to_i.abs
     else
       raise(ArgumentError, 'abs(): Requires float or integer to work with - was given non decimal string')

data/lib/puppet/functions/all.rb

@@ -87,7 +87,7 @@ Puppet::Functions.create_function(:all) do
   end
 
   def all_Hash_2(hash)
-    hash.each_pair.all? { |x,y| yield(x,y) }
+    hash.each_pair.all? { |x, y| yield(x, y) }
   end
 
   def all_Enumerable_1(enumerable)

data/lib/puppet/functions/any.rb

@@ -92,7 +92,7 @@ Puppet::Functions.create_function(:any) do
   end
 
   def any_Hash_2(hash)
-    hash.each_pair.any? { |x,y| yield(x, y) }
+    hash.each_pair.any? { |x, y| yield(x, y) }
   end
 
   def any_Enumerable_1(enumerable)

data/lib/puppet/functions/assert_type.rb

@@ -69,7 +69,7 @@ Puppet::Functions.create_function(:assert_type) do
   # @param value [Object] the value to assert
   #
   def assert_type(type, value)
-    unless Puppet::Pops::Types::TypeCalculator.instance?(type,value)
+    unless Puppet::Pops::Types::TypeCalculator.instance?(type, value)
       inferred_type = Puppet::Pops::Types::TypeCalculator.infer_set(value)
       if block_given?
         # Give the inferred type to allow richer comparison in the given block (if generalized
@@ -79,7 +79,8 @@ Puppet::Functions.create_function(:assert_type) do
       else
         raise Puppet::Pops::Types::TypeAssertionError.new(
           Puppet::Pops::Types::TypeMismatchDescriber.singleton.describe_mismatch('assert_type():', type, inferred_type),
-          type, inferred_type)
+          type, inferred_type
+        )
       end
     end
     value

data/lib/puppet/functions/break.rb

@@ -37,7 +37,7 @@ Puppet::Functions.create_function(:break) do
   dispatch :break_impl do
   end
 
-  def break_impl()
+  def break_impl
     # get file, line if available, else they are set to nil
     file, line = Puppet::Pops::PuppetStack.top_of_stack
 

data/lib/puppet/functions/camelcase.rb

@@ -49,11 +49,11 @@ Puppet::Functions.create_function(:camelcase) do
   end
 
   def on_string(s)
-    s.split('_').map {|x| x.capitalize }.join('')
+    s.split('_').map { |x| x.capitalize }.join('')
   end
 
   def on_iterable(a)
-    a.map {|x| do_camelcase(x) }
+    a.map { |x| do_camelcase(x) }
   end
 
   def do_camelcase(x)

data/lib/puppet/functions/capitalize.rb

@@ -5,7 +5,7 @@
 # This function is compatible with the stdlib function with the same name.
 #
 # The function does the following:
-# * For a `String`, a string with its first character in upper case version is returned. 
+# * For a `String`, a string with its first character in upper case version is returned.
 #   This is done using Ruby system locale which handles some, but not all
 #   special international up-casing rules (for example German double-s ß is capitalized to "Ss").
 # * For an `Iterable[Variant[String, Numeric]]` (for example an `Array`) each value is capitalized and the conversion is not recursive.
@@ -52,7 +52,7 @@ Puppet::Functions.create_function(:capitalize) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_capitalize(x) }
+    a.map { |x| do_capitalize(x) }
   end
 
   def do_capitalize(x)

data/lib/puppet/functions/chomp.rb

@@ -48,7 +48,7 @@ Puppet::Functions.create_function(:chomp) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_chomp(x) }
+    a.map { |x| do_chomp(x) }
   end
 
   def do_chomp(x)

data/lib/puppet/functions/chop.rb

@@ -58,7 +58,7 @@ Puppet::Functions.create_function(:chop) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_chop(x) }
+    a.map { |x| do_chop(x) }
   end
 
   def do_chop(x)

data/lib/puppet/functions/compare.rb

@@ -105,7 +105,7 @@ Puppet::Functions.create_function(:compare) do
       end
       unless ignore_case.size == 1
         # TRANSLATORS 'compare' is a name
-        return _("compare(): Accepts at most 3 arguments, got %{actual_number}") % {actual_number: 2 + ignore_case.size}
+        return _("compare(): Accepts at most 3 arguments, got %{actual_number}") % { actual_number: 2 + ignore_case.size }
       end
       unless ignore_case[0].is_a?(Boolean)
         # TRANSLATORS 'compare' is a name

data/lib/puppet/functions/contain.rb

@@ -34,24 +34,25 @@ Puppet::Functions.create_function(:contain, Puppet::Functions::InternalFunction)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'contain'})
+        { :operation => 'contain' }
+      )
     end
 
     # Make call patterns uniform and protected against nested arrays, also make
     # names absolute if so desired.
     classes = scope.transform_and_assert_classnames(classes.flatten)
 
-    result = classes.map {|name| Puppet::Pops::Types::TypeFactory.host_class(name) }
+    result = classes.map { |name| Puppet::Pops::Types::TypeFactory.host_class(name) }
     containing_resource = scope.resource
 
     # This is the same as calling the include function but faster and does not rely on the include
     # function.
     (scope.compiler.evaluate_classes(classes, scope, false) || []).each do |resource|
-      if ! scope.catalog.edge?(containing_resource, resource)
+      if !scope.catalog.edge?(containing_resource, resource)
         scope.catalog.add_edge(containing_resource, resource)
       end
     end
     # Result is an Array[Class, 1, n] which allows chaining other operations
     result
   end
-end
+end

data/lib/puppet/functions/dig.rb

@@ -37,7 +37,7 @@ Puppet::Functions.create_function(:dig) do
 
   def dig(data, *args)
     walked_path = []
-    args.reduce(data) do | d, k |
+    args.reduce(data) do |d, k|
       return nil if d.nil? || k.nil?
 
       if !(d.is_a?(Array) || d.is_a?(Hash))
@@ -46,7 +46,7 @@ Puppet::Functions.create_function(:dig) do
         error_data = Puppet::DataTypes::Error.new(
           msg,
           'SLICE_ERROR',
-          {'walked_path' => walked_path, 'value_type' => t},
+          { 'walked_path' => walked_path, 'value_type' => t },
           'EXPECTED_COLLECTION'
         )
         raise Puppet::ErrorWithData.new(error_data, msg)
@@ -59,7 +59,7 @@ Puppet::Functions.create_function(:dig) do
         error_data = Puppet::DataTypes::Error.new(
           msg,
           'SLICE_ERROR',
-          {'walked_path' => walked_path, 'index_type' => t},
+          { 'walked_path' => walked_path, 'index_type' => t },
           'EXPECTED_INTEGER_INDEX'
         )
         raise Puppet::ErrorWithData.new(error_data, msg)

data/lib/puppet/functions/downcase.rb

@@ -76,12 +76,12 @@ Puppet::Functions.create_function(:downcase) do
   end
 
   def on_array(a)
-    a.map {|x| do_downcase(x) }
+    a.map { |x| do_downcase(x) }
   end
 
   def on_hash(h)
     result = {}
-    h.each_pair {|k,v| result[do_downcase(k)] = do_downcase(v) }
+    h.each_pair { |k, v| result[do_downcase(k)] = do_downcase(v) }
     result
   end
 

data/lib/puppet/functions/eyaml_lookup_key.rb

@@ -31,7 +31,7 @@ Puppet::Functions.create_function(:eyaml_lookup_key) do
       # TRANSLATORS 'eyaml_lookup_key':, 'path', 'paths' 'glob', 'globs', 'mapped_paths', and lookup_key should not be translated
       raise ArgumentError,
             _("'eyaml_lookup_key': one of 'path', 'paths' 'glob', 'globs' or 'mapped_paths' must be declared in hiera.yaml"\
-                  " when using this lookup_key function")
+              " when using this lookup_key function")
     end
 
     # nil key is used to indicate that the cache contains the raw content of the eyaml file