puppet 8.3.1-x86-mingw32 → 8.5.0-x86-mingw32

data/lib/puppet/parser/functions/strftime.rb

@@ -1,186 +1,187 @@
 # frozen_string_literal: true
-Puppet::Parser::Functions::newfunction(
+
+Puppet::Parser::Functions.newfunction(
   :strftime,
   :type => :rvalue,
   :arity => -3,
-  :doc => <<DOC
-Formats timestamp or timespan according to the directives in the given format string. The directives begins with a percent (%) character.
-Any text not listed as a directive will be passed through to the output string.
-
-A third optional timezone argument can be provided. The first argument will then be formatted to represent a local time in that
-timezone. The timezone can be any timezone that is recognized when using the '%z' or '%Z' formats, or the word 'current', in which
-case the current timezone of the evaluating process will be used. The timezone argument is case insensitive.
-
-The default timezone, when no argument is provided, or when using the keyword `default`, is 'UTC'.
-
-The directive consists of a percent (%) character, zero or more flags, optional minimum field width and
-a conversion specifier as follows:
-```
-%[Flags][Width]Conversion
-```
-
-### Flags that controls padding
-
-| Flag  | Meaning
-| ----  | ---------------
-| -     | Don't pad numerical output
-| _     | Use spaces for padding
-| 0     | Use zeros for padding
-
-### `Timestamp` specific flags
-
-| Flag  | Meaning
-| ----  | ---------------
-| #     | Change case
-| ^     | Use uppercase
-| :     | Use colons for %z
-
-### Format directives applicable to `Timestamp` (names and padding can be altered using flags):
-
-**Date (Year, Month, Day):**
-
-| Format | Meaning |
-| ------ | ------- |
-| Y | Year with century, zero-padded to at least 4 digits |
-| C | year / 100 (rounded down such as 20 in 2009) |
-| y | year % 100 (00..99) |
-| m | Month of the year, zero-padded (01..12) |
-| B | The full month name ("January") |
-| b | The abbreviated month name ("Jan") |
-| h | Equivalent to %b |
-| d | Day of the month, zero-padded (01..31) |
-| e | Day of the month, blank-padded ( 1..31) |
-| j | Day of the year (001..366) |
-
-**Time (Hour, Minute, Second, Subsecond):**
-
-| Format | Meaning |
-| ------ | ------- |
-| H | Hour of the day, 24-hour clock, zero-padded (00..23) |
-| k | Hour of the day, 24-hour clock, blank-padded ( 0..23) |
-| I | Hour of the day, 12-hour clock, zero-padded (01..12) |
-| l | Hour of the day, 12-hour clock, blank-padded ( 1..12) |
-| P | Meridian indicator, lowercase ("am" or "pm") |
-| p | Meridian indicator, uppercase ("AM" or "PM") |
-| M | Minute of the hour (00..59) |
-| S | Second of the minute (00..60) |
-| L | Millisecond of the second (000..999). Digits under millisecond are truncated to not produce 1000 |
-| N | Fractional seconds digits, default is 9 digits (nanosecond). Digits under a specified width are truncated to avoid carry up |
-
-**Time (Hour, Minute, Second, Subsecond):**
-
-| Format | Meaning |
-| ------ | ------- |
-| z   | Time zone as hour and minute offset from UTC (e.g. +0900) |
-| :z  | hour and minute offset from UTC with a colon (e.g. +09:00) |
-| ::z | hour, minute and second offset from UTC (e.g. +09:00:00) |
-| Z   | Abbreviated time zone name or similar information.  (OS dependent) |
-
-**Weekday:**
-
-| Format | Meaning |
-| ------ | ------- |
-| A | The full weekday name ("Sunday") |
-| a | The abbreviated name ("Sun") |
-| u | Day of the week (Monday is 1, 1..7) |
-| w | Day of the week (Sunday is 0, 0..6) |
-
-**ISO 8601 week-based year and week number:**
-
-The first week of YYYY starts with a Monday and includes YYYY-01-04.
-The days in the year before the first week are in the last week of
-the previous year.
-
-| Format | Meaning |
-| ------ | ------- |
-| G | The week-based year |
-| g | The last 2 digits of the week-based year (00..99) |
-| V | Week number of the week-based year (01..53) |
-
-**Week number:**
-
-The first week of YYYY that starts with a Sunday or Monday (according to %U
-or %W). The days in the year before the first week are in week 0.
-
-| Format | Meaning |
-| ------ | ------- |
-| U | Week number of the year. The week starts with Sunday. (00..53) |
-| W | Week number of the year. The week starts with Monday. (00..53) |
-
-**Seconds since the Epoch:**
-
-| Format | Meaning |
-| s | Number of seconds since 1970-01-01 00:00:00 UTC. |
-
-**Literal string:**
-
-| Format | Meaning |
-| ------ | ------- |
-| n | Newline character (\n) |
-| t | Tab character (\t) |
-| % | Literal "%" character |
-
-**Combination:**
-
-| Format | Meaning |
-| ------ | ------- |
-| c | date and time (%a %b %e %T %Y) |
-| D | Date (%m/%d/%y) |
-| F | The ISO 8601 date format (%Y-%m-%d) |
-| v | VMS date (%e-%^b-%4Y) |
-| x | Same as %D |
-| X | Same as %T |
-| r | 12-hour time (%I:%M:%S %p) |
-| R | 24-hour time (%H:%M) |
-| T | 24-hour time (%H:%M:%S) |
-
-**Example**: Using `strftime` with a `Timestamp`:
-
-~~~ puppet
-$timestamp = Timestamp('2016-08-24T12:13:14')
-
-# Notice the timestamp using a format that notices the ISO 8601 date format
-notice($timestamp.strftime('%F')) # outputs '2016-08-24'
-
-# Notice the timestamp using a format that notices weekday, month, day, time (as UTC), and year
-notice($timestamp.strftime('%c')) # outputs 'Wed Aug 24 12:13:14 2016'
-
-# Notice the timestamp using a specific timezone
-notice($timestamp.strftime('%F %T %z', 'PST')) # outputs '2016-08-24 04:13:14 -0800'
-
-# Notice the timestamp using timezone that is current for the evaluating process
-notice($timestamp.strftime('%F %T', 'current')) # outputs the timestamp using the timezone for the current process
-~~~
+  :doc => <<~DOC
+    Formats timestamp or timespan according to the directives in the given format string. The directives begins with a percent (%) character.
+    Any text not listed as a directive will be passed through to the output string.
+
+    A third optional timezone argument can be provided. The first argument will then be formatted to represent a local time in that
+    timezone. The timezone can be any timezone that is recognized when using the '%z' or '%Z' formats, or the word 'current', in which
+    case the current timezone of the evaluating process will be used. The timezone argument is case insensitive.
+
+    The default timezone, when no argument is provided, or when using the keyword `default`, is 'UTC'.
+
+    The directive consists of a percent (%) character, zero or more flags, optional minimum field width and
+    a conversion specifier as follows:
+    ```
+    %[Flags][Width]Conversion
+    ```
+
+    ### Flags that controls padding
+
+    | Flag  | Meaning
+    | ----  | ---------------
+    | -     | Don't pad numerical output
+    | _     | Use spaces for padding
+    | 0     | Use zeros for padding
+
+    ### `Timestamp` specific flags
+
+    | Flag  | Meaning
+    | ----  | ---------------
+    | #     | Change case
+    | ^     | Use uppercase
+    | :     | Use colons for %z
+
+    ### Format directives applicable to `Timestamp` (names and padding can be altered using flags):
+
+    **Date (Year, Month, Day):**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | Y | Year with century, zero-padded to at least 4 digits |
+    | C | year / 100 (rounded down such as 20 in 2009) |
+    | y | year % 100 (00..99) |
+    | m | Month of the year, zero-padded (01..12) |
+    | B | The full month name ("January") |
+    | b | The abbreviated month name ("Jan") |
+    | h | Equivalent to %b |
+    | d | Day of the month, zero-padded (01..31) |
+    | e | Day of the month, blank-padded ( 1..31) |
+    | j | Day of the year (001..366) |
+
+    **Time (Hour, Minute, Second, Subsecond):**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | H | Hour of the day, 24-hour clock, zero-padded (00..23) |
+    | k | Hour of the day, 24-hour clock, blank-padded ( 0..23) |
+    | I | Hour of the day, 12-hour clock, zero-padded (01..12) |
+    | l | Hour of the day, 12-hour clock, blank-padded ( 1..12) |
+    | P | Meridian indicator, lowercase ("am" or "pm") |
+    | p | Meridian indicator, uppercase ("AM" or "PM") |
+    | M | Minute of the hour (00..59) |
+    | S | Second of the minute (00..60) |
+    | L | Millisecond of the second (000..999). Digits under millisecond are truncated to not produce 1000 |
+    | N | Fractional seconds digits, default is 9 digits (nanosecond). Digits under a specified width are truncated to avoid carry up |
+
+    **Time (Hour, Minute, Second, Subsecond):**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | z   | Time zone as hour and minute offset from UTC (e.g. +0900) |
+    | :z  | hour and minute offset from UTC with a colon (e.g. +09:00) |
+    | ::z | hour, minute and second offset from UTC (e.g. +09:00:00) |
+    | Z   | Abbreviated time zone name or similar information.  (OS dependent) |
+
+    **Weekday:**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | A | The full weekday name ("Sunday") |
+    | a | The abbreviated name ("Sun") |
+    | u | Day of the week (Monday is 1, 1..7) |
+    | w | Day of the week (Sunday is 0, 0..6) |
+
+    **ISO 8601 week-based year and week number:**
+
+    The first week of YYYY starts with a Monday and includes YYYY-01-04.
+    The days in the year before the first week are in the last week of
+    the previous year.
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | G | The week-based year |
+    | g | The last 2 digits of the week-based year (00..99) |
+    | V | Week number of the week-based year (01..53) |
+
+    **Week number:**
+
+    The first week of YYYY that starts with a Sunday or Monday (according to %U
+    or %W). The days in the year before the first week are in week 0.
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | U | Week number of the year. The week starts with Sunday. (00..53) |
+    | W | Week number of the year. The week starts with Monday. (00..53) |
+
+    **Seconds since the Epoch:**
+
+    | Format | Meaning |
+    | s | Number of seconds since 1970-01-01 00:00:00 UTC. |
+
+    **Literal string:**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | n | Newline character (\n) |
+    | t | Tab character (\t) |
+    | % | Literal "%" character |
+
+    **Combination:**
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | c | date and time (%a %b %e %T %Y) |
+    | D | Date (%m/%d/%y) |
+    | F | The ISO 8601 date format (%Y-%m-%d) |
+    | v | VMS date (%e-%^b-%4Y) |
+    | x | Same as %D |
+    | X | Same as %T |
+    | r | 12-hour time (%I:%M:%S %p) |
+    | R | 24-hour time (%H:%M) |
+    | T | 24-hour time (%H:%M:%S) |
+
+    **Example**: Using `strftime` with a `Timestamp`:
+
+    ~~~ puppet
+    $timestamp = Timestamp('2016-08-24T12:13:14')
+
+    # Notice the timestamp using a format that notices the ISO 8601 date format
+    notice($timestamp.strftime('%F')) # outputs '2016-08-24'
+
+    # Notice the timestamp using a format that notices weekday, month, day, time (as UTC), and year
+    notice($timestamp.strftime('%c')) # outputs 'Wed Aug 24 12:13:14 2016'
+
+    # Notice the timestamp using a specific timezone
+    notice($timestamp.strftime('%F %T %z', 'PST')) # outputs '2016-08-24 04:13:14 -0800'
+
+    # Notice the timestamp using timezone that is current for the evaluating process
+    notice($timestamp.strftime('%F %T', 'current')) # outputs the timestamp using the timezone for the current process
+    ~~~
 
-### Format directives applicable to `Timespan`:
-
-| Format | Meaning |
-| ------ | ------- |
-| D | Number of Days |
-| H | Hour of the day, 24-hour clock |
-| M | Minute of the hour (00..59) |
-| S | Second of the minute (00..59) |
-| L | Millisecond of the second (000..999). Digits under millisecond are truncated to not produce 1000. |
-| N | Fractional seconds digits, default is 9 digits (nanosecond). Digits under a specified length are truncated to avoid carry up |
+    ### Format directives applicable to `Timespan`:
+
+    | Format | Meaning |
+    | ------ | ------- |
+    | D | Number of Days |
+    | H | Hour of the day, 24-hour clock |
+    | M | Minute of the hour (00..59) |
+    | S | Second of the minute (00..59) |
+    | L | Millisecond of the second (000..999). Digits under millisecond are truncated to not produce 1000. |
+    | N | Fractional seconds digits, default is 9 digits (nanosecond). Digits under a specified length are truncated to avoid carry up |
 
-The format directive that represents the highest magnitude in the format will be allowed to overflow.
-I.e. if no "%D" is used but a "%H" is present, then the hours will be more than 23 in case the
-timespan reflects more than a day.
+    The format directive that represents the highest magnitude in the format will be allowed to overflow.
+    I.e. if no "%D" is used but a "%H" is present, then the hours will be more than 23 in case the
+    timespan reflects more than a day.
 
-**Example**: Using `strftime` with a Timespan and a format
+    **Example**: Using `strftime` with a Timespan and a format
 
-~~~ puppet
-$duration = Timespan({ hours => 3, minutes => 20, seconds => 30 })
+    ~~~ puppet
+    $duration = Timespan({ hours => 3, minutes => 20, seconds => 30 })
 
-# Notice the duration using a format that outputs <hours>:<minutes>:<seconds>
-notice($duration.strftime('%H:%M:%S')) # outputs '03:20:30'
+    # Notice the duration using a format that outputs <hours>:<minutes>:<seconds>
+    notice($duration.strftime('%H:%M:%S')) # outputs '03:20:30'
 
-# Notice the duration using a format that outputs <minutes>:<seconds>
-notice($duration.strftime('%M:%S')) # outputs '200:30'
-~~~
+    # Notice the duration using a format that outputs <minutes>:<seconds>
+    notice($duration.strftime('%M:%S')) # outputs '200:30'
+    ~~~
 
-- Since 4.8.0
-DOC
-) do |args|
+    - Since 4.8.0
+  DOC
+) do |_args|
   Puppet::Parser::Functions::Error.is4x('strftime')
 end

data/lib/puppet/parser/functions/tag.rb

@@ -1,13 +1,15 @@
 # frozen_string_literal: true
+
 # Tag the current scope with each passed name
-Puppet::Parser::Functions::newfunction(:tag, :arity => -2, :doc => "Add the specified tags to the containing class
+Puppet::Parser::Functions.newfunction(:tag, :arity => -2, :doc => "Add the specified tags to the containing class
   or definition.  All contained objects will then acquire that tag, also.
   ") do |vals|
-    if Puppet[:tasks]
-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
-        Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'tag'})
-    end
+  if Puppet[:tasks]
+    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+      Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
+      { :operation => 'tag' }
+    )
+  end
 
-    self.resource.tag(*vals)
+  self.resource.tag(*vals)
 end

data/lib/puppet/parser/functions/tagged.rb

@@ -1,22 +1,24 @@
 # frozen_string_literal: true
+
 # Test whether a given tag is set.  This functions as a big OR -- if any of the specified tags are unset, we return false.
-Puppet::Parser::Functions::newfunction(:tagged, :type => :rvalue, :arity => -2, :doc => "A boolean function that
+Puppet::Parser::Functions.newfunction(:tagged, :type => :rvalue, :arity => -2, :doc => "A boolean function that
   tells you whether the current container is tagged with the specified tags.
   The tags are ANDed, so that all of the specified tags must be included for
   the function to return true.") do |vals|
-    if Puppet[:tasks]
-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
-        Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'tagged'})
-    end
+  if Puppet[:tasks]
+    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+      Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
+      { :operation => 'tagged' }
+    )
+  end
 
-    retval = true
-    vals.each do |val|
-      unless compiler.catalog.tagged?(val) or resource.tagged?(val)
-        retval = false
-        break
-      end
+  retval = true
+  vals.each do |val|
+    unless compiler.catalog.tagged?(val) or resource.tagged?(val)
+      retval = false
+      break
     end
+  end
 
-    return retval
+  return retval
 end

data/lib/puppet/parser/functions/template.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-Puppet::Parser::Functions::newfunction(:template, :type => :rvalue, :arity => -2, :doc =>
+
+Puppet::Parser::Functions.newfunction(:template, :type => :rvalue, :arity => -2, :doc =>
   "Loads an ERB template from a module, evaluates it, and returns the resulting
   value as a string.
 
@@ -13,28 +14,29 @@ Puppet::Parser::Functions::newfunction(:template, :type => :rvalue, :arity => -2
   * An absolute path, which can load a template file from anywhere on disk.
   * Multiple arguments, which will evaluate all of the specified templates and
   return their outputs concatenated into a single string.") do |vals|
-    if Puppet[:tasks]
-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
-        Puppet::Pops::Issues::FEATURE_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:feature => 'ERB template'})
-    end
-    vals.collect do |file|
-      # Use a wrapper, so the template can't get access to the full
-      # Scope object.
-      debug "Retrieving template #{file}"
+  if Puppet[:tasks]
+    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+      Puppet::Pops::Issues::FEATURE_NOT_SUPPORTED_WHEN_SCRIPTING,
+      { :feature => 'ERB template' }
+    )
+  end
+  vals.collect do |file|
+    # Use a wrapper, so the template can't get access to the full
+    # Scope object.
+    debug "Retrieving template #{file}"
 
-      wrapper = Puppet::Parser::TemplateWrapper.new(self)
-      wrapper.file = file
-      begin
-        wrapper.result
-      rescue => detail
-        info = detail.backtrace.first.split(':')
-        message = []
-        message << _("Failed to parse template %{file}:") % { file: file }
-        message << _("  Filepath: %{file_path}") % { file_path: info[0] }
-        message << _("  Line: %{line}") % { line: info[1] }
-        message << _("  Detail: %{detail}") % { detail: detail }
-        raise Puppet::ParseError, message.join("\n") + "\n"
-      end
-    end.join("")
+    wrapper = Puppet::Parser::TemplateWrapper.new(self)
+    wrapper.file = file
+    begin
+      wrapper.result
+    rescue => detail
+      info = detail.backtrace.first.split(':')
+      message = []
+      message << _("Failed to parse template %{file}:") % { file: file }
+      message << _("  Filepath: %{file_path}") % { file_path: info[0] }
+      message << _("  Line: %{line}") % { line: info[1] }
+      message << _("  Detail: %{detail}") % { detail: detail }
+      raise Puppet::ParseError, message.join("\n") + "\n"
+    end
+  end.join("")
 end

data/lib/puppet/parser/functions/then.rb

@@ -1,74 +1,75 @@
 # frozen_string_literal: true
-Puppet::Parser::Functions::newfunction(
+
+Puppet::Parser::Functions.newfunction(
   :then,
   :type => :rvalue,
   :arity => -2,
-  :doc => <<-DOC
-Call a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
-with the given argument unless the argument is undef. Return `undef` if argument is
-`undef`, and otherwise the result of giving the argument to the lambda.
+  :doc => <<~DOC
+    Call a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
+    with the given argument unless the argument is undef. Return `undef` if argument is
+    `undef`, and otherwise the result of giving the argument to the lambda.
 
-This is useful to process a sequence of operations where an intermediate
-result may be `undef` (which makes the entire sequence `undef`).
-The `then` function is especially useful with the function `dig` which
-performs in a similar way "digging out" a value in a complex structure.
+    This is useful to process a sequence of operations where an intermediate
+    result may be `undef` (which makes the entire sequence `undef`).
+    The `then` function is especially useful with the function `dig` which
+    performs in a similar way "digging out" a value in a complex structure.
 
-**Example:** Using `dig` and `then`
+    **Example:** Using `dig` and `then`
 
-```puppet
-$data = {a => { b => [{x => 10, y => 20}, {x => 100, y => 200}]}}
-notice $data.dig(a, b, 1, x).then |$x| { $x * 2 }
-```
+    ```puppet
+    $data = {a => { b => [{x => 10, y => 20}, {x => 100, y => 200}]}}
+    notice $data.dig(a, b, 1, x).then |$x| { $x * 2 }
+    ```
 
-Would notice the value 200
+    Would notice the value 200
 
-Contrast this with:
+    Contrast this with:
 
-```puppet
-$data = {a => { b => [{x => 10, y => 20}, {ex => 100, why => 200}]}}
-notice $data.dig(a, b, 1, x).then |$x| { $x * 2 }
-```
+    ```puppet
+    $data = {a => { b => [{x => 10, y => 20}, {ex => 100, why => 200}]}}
+    notice $data.dig(a, b, 1, x).then |$x| { $x * 2 }
+    ```
 
-Which would notice `undef` since the last lookup of 'x' results in `undef` which
-is returned (without calling the lambda given to the `then` function).
+    Which would notice `undef` since the last lookup of 'x' results in `undef` which
+    is returned (without calling the lambda given to the `then` function).
 
-As a result there is no need for conditional logic or a temporary (non local)
-variable as the result is now either the wanted value (`x`) multiplied
-by 2 or `undef`.
+    As a result there is no need for conditional logic or a temporary (non local)
+    variable as the result is now either the wanted value (`x`) multiplied
+    by 2 or `undef`.
 
-Calls to `then` can be chained. In the next example, a structure is using an offset based on
-using 1 as the index to the first element (instead of 0 which is used in the language).
-We are not sure if user input actually contains an index at all, or if it is
-outside the range of available names.args.
+    Calls to `then` can be chained. In the next example, a structure is using an offset based on
+    using 1 as the index to the first element (instead of 0 which is used in the language).
+    We are not sure if user input actually contains an index at all, or if it is
+    outside the range of available names.args.
 
-**Example:** Chaining calls to the `then` function
+    **Example:** Chaining calls to the `then` function
 
-```puppet
-# Names to choose from
-$names = ['Ringo', 'Paul', 'George', 'John']
+    ```puppet
+    # Names to choose from
+    $names = ['Ringo', 'Paul', 'George', 'John']
 
-# Structure where 'beatle 2' is wanted (but where the number refers
-# to 'Paul' because input comes from a source using 1 for the first
-# element).
+    # Structure where 'beatle 2' is wanted (but where the number refers
+    # to 'Paul' because input comes from a source using 1 for the first
+    # element).
 
-$data = ['singer', { beatle => 2 }]
-$picked = assert_type(String,
-  # the data we are interested in is the second in the array,
-  # a hash, where we want the value of the key 'beatle'
-  $data.dig(1, 'beatle')
-    # and we want the index in $names before the given index
-    .then |$x| { $names[$x-1] }
-    # so we can construct a string with that beatle's name
-    .then |$x| { "Picked Beatle '${x}'" }
-)
-```
+    $data = ['singer', { beatle => 2 }]
+    $picked = assert_type(String,
+      # the data we are interested in is the second in the array,
+      # a hash, where we want the value of the key 'beatle'
+      $data.dig(1, 'beatle')
+        # and we want the index in $names before the given index
+        .then |$x| { $names[$x-1] }
+        # so we can construct a string with that beatle's name
+        .then |$x| { "Picked Beatle '${x}'" }
+    )
+    ```
 
-Would notice "Picked Beatle 'Paul'", and would raise an error if the result
-was not a String.
+    Would notice "Picked Beatle 'Paul'", and would raise an error if the result
+    was not a String.
 
-* Since 4.5.0
+    * Since 4.5.0
 
-DOC
-) do |args|
+  DOC
+) do |_args|
   Puppet::Parser::Functions::Error.is4x('then')
 end