puppet 7.5.0-universal-darwin → 7.9.0-universal-darwin

data/lib/puppet/module_tool/applications.rb

@@ -1,12 +1,12 @@
-require 'puppet/module_tool'
+require_relative '../../puppet/module_tool'
 
 module Puppet::ModuleTool
   module Applications
-    require 'puppet/module_tool/applications/application'
-    require 'puppet/module_tool/applications/checksummer'
-    require 'puppet/module_tool/applications/installer'
-    require 'puppet/module_tool/applications/unpacker'
-    require 'puppet/module_tool/applications/uninstaller'
-    require 'puppet/module_tool/applications/upgrader'
+    require_relative 'applications/application'
+    require_relative 'applications/checksummer'
+    require_relative 'applications/installer'
+    require_relative 'applications/unpacker'
+    require_relative 'applications/uninstaller'
+    require_relative 'applications/upgrader'
   end
 end

data/lib/puppet/module_tool/applications/application.rb

@@ -1,6 +1,6 @@
 require 'net/http'
-require 'puppet/util/json'
-require 'puppet/util/colors'
+require_relative '../../../puppet/util/json'
+require_relative '../../../puppet/util/colors'
 
 module Puppet::ModuleTool
   module Applications

data/lib/puppet/module_tool/applications/checksummer.rb

@@ -1,5 +1,5 @@
-require 'puppet/util/json'
-require 'puppet/module_tool/checksums'
+require_relative '../../../puppet/util/json'
+require_relative '../../../puppet/module_tool/checksums'
 
 module Puppet::ModuleTool
   module Applications

data/lib/puppet/module_tool/applications/installer.rb

@@ -3,13 +3,13 @@ require 'pathname'
 require 'fileutils'
 require 'tmpdir'
 
-require 'puppet/forge'
-require 'puppet/module_tool'
-require 'puppet/module_tool/shared_behaviors'
-require 'puppet/module_tool/install_directory'
-require 'puppet/module_tool/local_tarball'
-require 'puppet/module_tool/installed_modules'
-require 'puppet/network/uri'
+require_relative '../../../puppet/forge'
+require_relative '../../../puppet/module_tool'
+require_relative '../../../puppet/module_tool/shared_behaviors'
+require_relative '../../../puppet/module_tool/install_directory'
+require_relative '../../../puppet/module_tool/local_tarball'
+require_relative '../../../puppet/module_tool/installed_modules'
+require_relative '../../../puppet/network/uri'
 
 module Puppet::ModuleTool
   module Applications
@@ -59,6 +59,10 @@ module Puppet::ModuleTool
         results = { :action => :install, :module_name => name, :module_version => version }
 
         begin
+          if !@local_tarball && name !~ /-/
+            raise InvalidModuleNameError.new(module_name: @name, suggestion: "puppetlabs-#{@name}", action: :install)
+          end
+
           installed_module = installed_modules[name]
           if installed_module
             unless forced?

data/lib/puppet/module_tool/applications/unpacker.rb

@@ -1,7 +1,7 @@
 require 'pathname'
 require 'tmpdir'
-require 'puppet/util/json'
-require 'puppet/file_system'
+require_relative '../../../puppet/util/json'
+require_relative '../../../puppet/file_system'
 
 module Puppet::ModuleTool
   module Applications

data/lib/puppet/module_tool/applications/upgrader.rb

@@ -1,10 +1,10 @@
 require 'pathname'
 
-require 'puppet/forge'
-require 'puppet/module_tool'
-require 'puppet/module_tool/shared_behaviors'
-require 'puppet/module_tool/install_directory'
-require 'puppet/module_tool/installed_modules'
+require_relative '../../../puppet/forge'
+require_relative '../../../puppet/module_tool'
+require_relative '../../../puppet/module_tool/shared_behaviors'
+require_relative '../../../puppet/module_tool/install_directory'
+require_relative '../../../puppet/module_tool/installed_modules'
 
 module Puppet::ModuleTool
   module Applications

data/lib/puppet/module_tool/checksums.rb

@@ -1,5 +1,5 @@
 require 'digest/md5'
-require 'puppet/network/format_support'
+require_relative '../../puppet/network/format_support'
 
 module Puppet::ModuleTool
 

data/lib/puppet/module_tool/contents_description.rb

@@ -1,4 +1,4 @@
-require 'puppet/module_tool'
+require_relative '../../puppet/module_tool'
 
 module Puppet::ModuleTool
 

data/lib/puppet/module_tool/dependency.rb

@@ -1,5 +1,5 @@
-require 'puppet/module_tool'
-require 'puppet/network/format_support'
+require_relative '../../puppet/module_tool'
+require_relative '../../puppet/network/format_support'
 
 module Puppet::ModuleTool
 

data/lib/puppet/module_tool/errors.rb

@@ -1,11 +1,11 @@
-require 'puppet/module_tool'
+require_relative '../../puppet/module_tool'
 
 module Puppet::ModuleTool
   module Errors
-    require 'puppet/module_tool/errors/base'
-    require 'puppet/module_tool/errors/installer'
-    require 'puppet/module_tool/errors/uninstaller'
-    require 'puppet/module_tool/errors/upgrader'
-    require 'puppet/module_tool/errors/shared'
+    require_relative 'errors/base'
+    require_relative 'errors/installer'
+    require_relative 'errors/uninstaller'
+    require_relative 'errors/upgrader'
+    require_relative 'errors/shared'
   end
 end

data/lib/puppet/module_tool/errors/shared.rb

@@ -127,6 +127,23 @@ module Puppet::ModuleTool::Errors
     end
   end
 
+  class InvalidModuleNameError < ModuleToolError
+    def initialize(options)
+      @module_name = options[:module_name]
+      @suggestion = options[:suggestion]
+      @action = options[:action]
+      super _("Could not %{action} '%{module_name}', did you mean '%{suggestion}'?") % { action: @action, module_name: @module_name, suggestion: @suggestion }
+    end
+
+    def multiline
+      message = []
+      message << _("Could not %{action} module '%{module_name}'") % { action: @action, module_name: @module_name }
+      message << _("  The name '%{module_name}' is invalid") % { module_name: @module_name }
+      message << _("    Did you mean `puppet module %{action} %{suggestion}`?") % { action: @action, suggestion: @suggestion }
+      message.join("\n")
+    end
+  end
+
   class NotInstalledError < ModuleToolError
     def initialize(options)
       @module_name = options[:module_name]

data/lib/puppet/module_tool/install_directory.rb

@@ -1,5 +1,5 @@
-require 'puppet/module_tool'
-require 'puppet/module_tool/errors'
+require_relative '../../puppet/module_tool'
+require_relative '../../puppet/module_tool/errors'
 
 module Puppet
   module ModuleTool

data/lib/puppet/module_tool/installed_modules.rb

@@ -1,7 +1,7 @@
 require 'pathname'
 
-require 'puppet/forge'
-require 'puppet/module_tool'
+require_relative '../../puppet/forge'
+require_relative '../../puppet/module_tool'
 
 module Puppet::ModuleTool
   class InstalledModules < SemanticPuppet::Dependency::Source

data/lib/puppet/module_tool/local_tarball.rb

@@ -1,8 +1,8 @@
 require 'pathname'
 require 'tmpdir'
 
-require 'puppet/forge'
-require 'puppet/module_tool'
+require_relative '../../puppet/forge'
+require_relative '../../puppet/module_tool'
 
 module Puppet::ModuleTool
   class LocalTarball < SemanticPuppet::Dependency::Source

data/lib/puppet/module_tool/metadata.rb

@@ -1,7 +1,7 @@
-require 'puppet/module_tool'
-require 'puppet/network/format_support'
+require_relative '../../puppet/module_tool'
+require_relative '../../puppet/network/format_support'
 require 'uri'
-require 'puppet/util/json'
+require_relative '../../puppet/util/json'
 require 'set'
 
 module Puppet::ModuleTool

data/lib/puppet/module_tool/tar.rb

@@ -1,9 +1,9 @@
-require 'puppet/module_tool'
-require 'puppet/util'
+require_relative '../../puppet/module_tool'
+require_relative '../../puppet/util'
 
 module Puppet::ModuleTool::Tar
-  require 'puppet/module_tool/tar/gnu'
-  require 'puppet/module_tool/tar/mini'
+  require_relative 'tar/gnu'
+  require_relative 'tar/mini'
 
   def self.instance
     if Puppet.features.minitar? && Puppet.features.zlib?

data/lib/puppet/module_tool/tar/mini.rb

@@ -107,7 +107,7 @@ class Puppet::ModuleTool::Tar::Mini
       raise Puppet::ModuleTool::Errors::InvalidPathInPackageError, :entry_path => path, :directory => destdir
     end
 
-    path = File.expand_path File.join(destdir, path)
+    path = Pathname.new(File.join(destdir, path)).cleanpath.to_path
 
     if path !~ /\A#{Regexp.escape destdir}/
       raise Puppet::ModuleTool::Errors::InvalidPathInPackageError, :entry_path => path, :directory => destdir

data/lib/puppet/network/format.rb

@@ -1,4 +1,4 @@
-require 'puppet/confiner'
+require_relative '../../puppet/confiner'
 
 # A simple class for modeling encoding formats for moving
 # instances around the network.

data/lib/puppet/network/format_handler.rb

@@ -1,6 +1,6 @@
 require 'yaml'
-require 'puppet/network'
-require 'puppet/network/format'
+require_relative '../../puppet/network'
+require_relative '../../puppet/network/format'
 
 module Puppet::Network::FormatHandler
   class FormatError < Puppet::Error; end
@@ -105,4 +105,4 @@ module Puppet::Network::FormatHandler
   end
 end
 
-require 'puppet/network/formats'
+require_relative '../../puppet/network/formats'

data/lib/puppet/network/format_support.rb

@@ -1,4 +1,4 @@
-require 'puppet/network/format_handler'
+require_relative '../../puppet/network/format_handler'
 
 # Provides network serialization support when included
 # @api public

data/lib/puppet/network/formats.rb

@@ -1,5 +1,5 @@
-require 'puppet/network/format_handler'
-require 'puppet/util/json'
+require_relative '../../puppet/network/format_handler'
+require_relative '../../puppet/util/json'
 
 Puppet::Network::FormatHandler.create_serialized_formats(:msgpack, :weight => 20, :mime => "application/x-msgpack", :required_methods => [:render_method, :intern_method], :intern_method => :from_data_hash) do
 

data/lib/puppet/network/http.rb

@@ -12,17 +12,17 @@ module Puppet::Network::HTTP
   CA_URL_PREFIX = "/puppet-ca"
   CA_URL_VERSIONS = "v1"
 
-  require 'puppet/network/authconfig'
-  require 'puppet/network/authorization'
+  require_relative '../../puppet/network/authconfig'
+  require_relative '../../puppet/network/authorization'
 
-  require 'puppet/network/http/issues'
-  require 'puppet/network/http/error'
-  require 'puppet/network/http/route'
-  require 'puppet/network/http/api'
-  require 'puppet/network/http/api/master'
-  require 'puppet/network/http/api/master/v3'
-  require 'puppet/network/http/handler'
-  require 'puppet/network/http/response'
-  require 'puppet/network/http/request'
-  require 'puppet/network/http/memory_response'
+  require_relative 'http/issues'
+  require_relative 'http/error'
+  require_relative 'http/route'
+  require_relative 'http/api'
+  require_relative 'http/api/master'
+  require_relative 'http/api/master/v3'
+  require_relative 'http/handler'
+  require_relative 'http/response'
+  require_relative 'http/request'
+  require_relative 'http/memory_response'
 end

data/lib/puppet/network/http/api.rb

@@ -1,5 +1,5 @@
 class Puppet::Network::HTTP::API
-  require 'puppet/version'
+  require_relative '../../../puppet/version'
 
   def self.not_found
     Puppet::Network::HTTP::Route.

data/lib/puppet/network/http/api/indirected_routes.rb

@@ -1,4 +1,4 @@
-require 'puppet/network/http/api/indirection_type'
+require_relative '../../../../puppet/network/http/api/indirection_type'
 
 class Puppet::Network::HTTP::API::IndirectedRoutes
 

data/lib/puppet/network/http/api/master.rb

@@ -1,3 +1,3 @@
-require 'puppet/network/http/api/server'
+require_relative '../../../../puppet/network/http/api/server'
 
 Puppet::Network::HTTP::API::Master = Puppet::Network::HTTP::API::Server

data/lib/puppet/network/http/api/master/v3.rb

@@ -1,3 +1,3 @@
-require 'puppet/network/http/api/master'
-require 'puppet/network/http/api/server/v3'
+require_relative '../../../../../puppet/network/http/api/master'
+require_relative '../../../../../puppet/network/http/api/server/v3'
 

data/lib/puppet/network/http/api/master/v3/environments.rb

@@ -1,3 +1,3 @@
-require 'puppet/network/http/api/master'
-require 'puppet/network/http/api/server/v3/environments'
+require_relative '../../../../../../puppet/network/http/api/master'
+require_relative '../../../../../../puppet/network/http/api/server/v3/environments'
 

data/lib/puppet/network/http/api/server/v3.rb

@@ -1,5 +1,5 @@
-require 'puppet/network/http/api/server/v3/environments'
-require 'puppet/network/http/api/indirected_routes'
+require_relative 'v3/environments'
+require_relative '../../../../../puppet/network/http/api/indirected_routes'
 
 module Puppet
   module Network

data/lib/puppet/network/http/api/server/v3/environments.rb

@@ -1,4 +1,4 @@
-require 'puppet/util/json'
+require_relative '../../../../../../puppet/util/json'
 
 module Puppet
   module Network

data/lib/puppet/network/http/connection.rb

@@ -1,4 +1,4 @@
-require 'puppet/http'
+require_relative '../../../puppet/http'
 
 # This will be raised if too many redirects happen for a given HTTP request
 class Puppet::Network::HTTP::RedirectionLimitExceededException < Puppet::Error ; end

data/lib/puppet/network/http/error.rb

@@ -1,4 +1,4 @@
-require 'puppet/util/json'
+require_relative '../../../puppet/util/json'
 
 module Puppet::Network::HTTP::Error
   Issues = Puppet::Network::HTTP::Issues

data/lib/puppet/network/http/handler.rb

@@ -1,9 +1,9 @@
 module Puppet::Network::HTTP
 end
 
-require 'puppet/network/http'
-require 'puppet/util/profiler'
-require 'puppet/util/profiler/aggregate'
+require_relative '../../../puppet/network/http'
+require_relative '../../../puppet/util/profiler'
+require_relative '../../../puppet/util/profiler/aggregate'
 require 'resolv'
 
 module Puppet::Network::HTTP::Handler

data/lib/puppet/network/http_pool.rb

@@ -1,4 +1,4 @@
-require 'puppet/network/http/connection'
+require_relative '../../puppet/network/http/connection'
 
 module Puppet::Network; end
 

data/lib/puppet/node.rb

@@ -1,9 +1,9 @@
-require 'puppet/indirector'
+require_relative '../puppet/indirector'
 
 # A class for managing nodes, including their facts and environment.
 class Puppet::Node
-  require 'puppet/node/facts'
-  require 'puppet/node/environment'
+  require_relative 'node/facts'
+  require_relative 'node/environment'
 
   # Set up indirection, so that nodes can be looked for in
   # the node sources.

data/lib/puppet/node/environment.rb

@@ -1,7 +1,7 @@
-require 'puppet/util'
+require_relative '../../puppet/util'
 require 'monitor'
-require 'puppet/parser/parser_factory'
-require 'puppet/concurrent/lock'
+require_relative '../../puppet/parser/parser_factory'
+require_relative '../../puppet/concurrent/lock'
 
 # Just define it, so this class has fewer load dependencies.
 class Puppet::Node
@@ -214,15 +214,22 @@ class Puppet::Node::Environment
     errors
   end
 
+  def rich_data_from_env_conf
+    unless @checked_conf_for_rich_data
+      environment_conf = Puppet.lookup(:environments).get_conf(name)
+      @rich_data_from_conf = environment_conf&.rich_data
+      @checked_conf_for_rich_data = true
+    end
+    @rich_data_from_conf
+  end
+
   # Checks if this environment permits use of rich data types in the catalog
+  # Checks the environment conf for an override on first query, then going forward
+  # either uses that, or if unset, uses the current value of the `rich_data` setting.
   # @return [Boolean] `true` if rich data is permitted.
   # @api private
   def rich_data?
-    if @rich_data.nil?
-      environment_conf = Puppet.lookup(:environments).get_conf(name)
-      @rich_data = (environment_conf.nil? ? Puppet[:rich_data] : environment_conf.rich_data)
-    end
-    @rich_data
+    @rich_data = rich_data_from_env_conf.nil? ? Puppet[:rich_data] : rich_data_from_env_conf
   end
 
   # Return an environment-specific Puppet setting.