puppet 7.4.0-universal-darwin → 7.8.0-universal-darwin

data/lib/puppet/parser/type_loader.rb

@@ -1,6 +1,6 @@
 require 'find'
 require 'forwardable'
-require 'puppet/parser/parser_factory'
+require_relative '../../puppet/parser/parser_factory'
 
 class Puppet::Parser::TypeLoader
   extend  Forwardable

data/lib/puppet/plugins/configuration.rb

@@ -7,11 +7,11 @@
 #
 module Puppet::Plugins
   module Configuration
-    require 'puppet/plugins/syntax_checkers'
-    require 'puppet/syntax_checkers/base64'
-    require 'puppet/syntax_checkers/json'
-    require 'puppet/syntax_checkers/pp'
-    require 'puppet/syntax_checkers/epp'
+    require_relative '../../puppet/plugins/syntax_checkers'
+    require_relative '../../puppet/syntax_checkers/base64'
+    require_relative '../../puppet/syntax_checkers/json'
+    require_relative '../../puppet/syntax_checkers/pp'
+    require_relative '../../puppet/syntax_checkers/epp'
 
     def self.load_plugins
       # Register extensions

data/lib/puppet/pops.rb

@@ -22,100 +22,100 @@ module Puppet
 
     require 'semantic_puppet'
 
-    require 'puppet/pops/patterns'
-    require 'puppet/pops/utils'
-    require 'puppet/pops/puppet_stack'
+    require_relative 'pops/patterns'
+    require_relative 'pops/utils'
+    require_relative 'pops/puppet_stack'
 
-    require 'puppet/pops/adaptable'
-    require 'puppet/pops/adapters'
+    require_relative 'pops/adaptable'
+    require_relative 'pops/adapters'
 
-    require 'puppet/pops/visitable'
-    require 'puppet/pops/visitor'
+    require_relative 'pops/visitable'
+    require_relative 'pops/visitor'
 
-    require 'puppet/pops/issues'
-    require 'puppet/pops/semantic_error'
-    require 'puppet/pops/label_provider'
-    require 'puppet/pops/validation'
-    require 'puppet/pops/issue_reporter'
+    require_relative 'pops/issues'
+    require_relative 'pops/semantic_error'
+    require_relative 'pops/label_provider'
+    require_relative 'pops/validation'
+    require_relative 'pops/issue_reporter'
 
-    require 'puppet/pops/time/timespan'
-    require 'puppet/pops/time/timestamp'
+    require_relative 'pops/time/timespan'
+    require_relative 'pops/time/timestamp'
 
     # (the Types module initializes itself)
-    require 'puppet/pops/types/types'
-    require 'puppet/pops/types/string_converter'
-    require 'puppet/pops/lookup'
+    require_relative 'pops/types/types'
+    require_relative 'pops/types/string_converter'
+    require_relative 'pops/lookup'
 
-    require 'puppet/pops/merge_strategy'
+    require_relative 'pops/merge_strategy'
 
     module Model
-      require 'puppet/pops/model/ast'
-      require 'puppet/pops/model/tree_dumper'
-      require 'puppet/pops/model/ast_transformer'
-      require 'puppet/pops/model/factory'
-      require 'puppet/pops/model/model_tree_dumper'
-      require 'puppet/pops/model/model_label_provider'
+      require_relative 'pops/model/ast'
+      require_relative 'pops/model/tree_dumper'
+      require_relative 'pops/model/ast_transformer'
+      require_relative 'pops/model/factory'
+      require_relative 'pops/model/model_tree_dumper'
+      require_relative 'pops/model/model_label_provider'
     end
 
     module Resource
-      require 'puppet/pops/resource/resource_type_impl'
+      require_relative 'pops/resource/resource_type_impl'
     end
     module Evaluator
-      require 'puppet/pops/evaluator/literal_evaluator'
-      require 'puppet/pops/evaluator/callable_signature'
-      require 'puppet/pops/evaluator/runtime3_converter'
-      require 'puppet/pops/evaluator/runtime3_resource_support'
-      require 'puppet/pops/evaluator/runtime3_support'
-      require 'puppet/pops/evaluator/evaluator_impl'
-      require 'puppet/pops/evaluator/epp_evaluator'
-      require 'puppet/pops/evaluator/collector_transformer'
-      require 'puppet/pops/evaluator/puppet_proc'
-      require 'puppet/pops/evaluator/deferred_resolver'
+      require_relative 'pops/evaluator/literal_evaluator'
+      require_relative 'pops/evaluator/callable_signature'
+      require_relative 'pops/evaluator/runtime3_converter'
+      require_relative 'pops/evaluator/runtime3_resource_support'
+      require_relative 'pops/evaluator/runtime3_support'
+      require_relative 'pops/evaluator/evaluator_impl'
+      require_relative 'pops/evaluator/epp_evaluator'
+      require_relative 'pops/evaluator/collector_transformer'
+      require_relative 'pops/evaluator/puppet_proc'
+      require_relative 'pops/evaluator/deferred_resolver'
       module Collectors
-        require 'puppet/pops/evaluator/collectors/abstract_collector'
-        require 'puppet/pops/evaluator/collectors/fixed_set_collector'
-        require 'puppet/pops/evaluator/collectors/catalog_collector'
-        require 'puppet/pops/evaluator/collectors/exported_collector'
+        require_relative 'pops/evaluator/collectors/abstract_collector'
+        require_relative 'pops/evaluator/collectors/fixed_set_collector'
+        require_relative 'pops/evaluator/collectors/catalog_collector'
+        require_relative 'pops/evaluator/collectors/exported_collector'
       end
     end
 
     module Parser
-      require 'puppet/pops/parser/eparser'
-      require 'puppet/pops/parser/parser_support'
-      require 'puppet/pops/parser/locator'
-      require 'puppet/pops/parser/locatable'
-      require 'puppet/pops/parser/lexer2'
-      require 'puppet/pops/parser/evaluating_parser'
-      require 'puppet/pops/parser/epp_parser'
-      require 'puppet/pops/parser/code_merger'
+      require_relative 'pops/parser/eparser'
+      require_relative 'pops/parser/parser_support'
+      require_relative 'pops/parser/locator'
+      require_relative 'pops/parser/locatable'
+      require_relative 'pops/parser/lexer2'
+      require_relative 'pops/parser/evaluating_parser'
+      require_relative 'pops/parser/epp_parser'
+      require_relative 'pops/parser/code_merger'
     end
 
     module Validation
-      require 'puppet/pops/validation/checker4_0'
-      require 'puppet/pops/validation/validator_factory_4_0'
+      require_relative 'pops/validation/checker4_0'
+      require_relative 'pops/validation/validator_factory_4_0'
     end
 
     # Subsystem for puppet functions defined in ruby.
     #
     # @api public
     module Functions
-      require 'puppet/pops/functions/function'
-      require 'puppet/pops/functions/dispatch'
-      require 'puppet/pops/functions/dispatcher'
+      require_relative 'pops/functions/function'
+      require_relative 'pops/functions/dispatch'
+      require_relative 'pops/functions/dispatcher'
     end
 
     module Migration
-      require 'puppet/pops/migration/migration_checker'
+      require_relative 'pops/migration/migration_checker'
     end
 
     module Serialization
-      require 'puppet/pops/serialization'
+      require_relative 'pops/serialization'
     end
   end
 
-  require 'puppet/parser/ast/pops_bridge'
-  require 'puppet/functions'
-  require 'puppet/datatypes'
+  require_relative '../puppet/parser/ast/pops_bridge'
+  require_relative '../puppet/functions'
+  require_relative '../puppet/datatypes'
 
   Puppet::Pops::Model.register_pcore_types
 end

data/lib/puppet/pops/evaluator/deferred_resolver.rb

@@ -1,4 +1,4 @@
-require 'puppet/parser/script_compiler'
+require_relative '../../../puppet/parser/script_compiler'
 
 module Puppet::Pops
 module Evaluator

data/lib/puppet/pops/evaluator/evaluator_impl.rb

@@ -1,10 +1,10 @@
-require 'puppet/parser/scope'
-require 'puppet/pops/evaluator/compare_operator'
-require 'puppet/pops/evaluator/relationship_operator'
-require 'puppet/pops/evaluator/access_operator'
-require 'puppet/pops/evaluator/closure'
-require 'puppet/pops/evaluator/external_syntax_support'
-require 'puppet/pops/types/iterable'
+require_relative '../../../puppet/parser/scope'
+require_relative '../../../puppet/pops/evaluator/compare_operator'
+require_relative '../../../puppet/pops/evaluator/relationship_operator'
+require_relative '../../../puppet/pops/evaluator/access_operator'
+require_relative '../../../puppet/pops/evaluator/closure'
+require_relative '../../../puppet/pops/evaluator/external_syntax_support'
+require_relative '../../../puppet/pops/types/iterable'
 
 module Puppet::Pops
 module Evaluator

data/lib/puppet/pops/evaluator/external_syntax_support.rb

@@ -1,7 +1,7 @@
 # This module is an integral part of the evaluator. It deals with the concern of validating
 # external syntax in text produced by heredoc and templates.
 #
-require 'puppet/plugins/syntax_checkers'
+require_relative '../../../puppet/plugins/syntax_checkers'
 module Puppet::Pops::Evaluator::ExternalSyntaxSupport
   def assert_external_syntax(_, result, syntax, reference_expr)
     # ignore 'unspecified syntax'

data/lib/puppet/pops/loader/base_loader.rb

@@ -13,8 +13,8 @@ class BaseLoader < Loader
   # The parent loader
   attr_reader :parent
 
-  def initialize(parent_loader, loader_name)
-    super(loader_name)
+  def initialize(parent_loader, loader_name, environment)
+    super(loader_name, environment)
     @parent = parent_loader # the higher priority loader to consult
     @named_values = {}      # hash name => NamedEntry
     @last_result = nil      # the value of the last name (optimization)
@@ -38,22 +38,26 @@ class BaseLoader < Loader
     # These modules are typically parented by the same
     # loader as the one initiating the search. It is inefficient to again try to search the same loader for
     # the same name.
-    if @last_result.nil? || typed_name != @last_result.typed_name
-      @last_result = internal_load(typed_name)
-    else
-      @last_result
+    synchronize do
+      if @last_result.nil? || typed_name != @last_result.typed_name
+        @last_result = internal_load(typed_name)
+      else
+        @last_result
+      end
     end
   end
 
   # @api public
   #
   def loaded_entry(typed_name, check_dependencies = false)
-    if @named_values.has_key?(typed_name)
-      @named_values[typed_name]
-    elsif parent
-      parent.loaded_entry(typed_name, check_dependencies)
-    else
-      nil
+    synchronize do
+      if @named_values.has_key?(typed_name)
+        @named_values[typed_name]
+      elsif parent
+        parent.loaded_entry(typed_name, check_dependencies)
+      else
+        nil
+      end
     end
   end
 
@@ -68,23 +72,25 @@ class BaseLoader < Loader
   # @api private
   #
   def set_entry(typed_name, value, origin = nil)
-    # It is never ok to redefine in the very same loader unless redefining a 'not found'
-    entry = @named_values[typed_name]
-    if entry
-      fail_redefine(entry) unless entry.value.nil?
-    end
-
-    # Check if new entry shadows existing entry and fail
-    # (unless special loader allows shadowing)
-    if typed_name.type == :type && !allow_shadowing?
-      entry = loaded_entry(typed_name)
+    synchronize do
+      # It is never ok to redefine in the very same loader unless redefining a 'not found'
+      entry = @named_values[typed_name]
       if entry
-        fail_redefine(entry) unless entry.value.nil? #|| entry.value == value
+        fail_redefine(entry) unless entry.value.nil?
+      end
+
+      # Check if new entry shadows existing entry and fail
+      # (unless special loader allows shadowing)
+      if typed_name.type == :type && !allow_shadowing?
+        entry = loaded_entry(typed_name)
+        if entry
+          fail_redefine(entry) unless entry.value.nil? #|| entry.value == value
+        end
       end
-    end
 
-    @last_result = Loader::NamedEntry.new(typed_name, value, origin)
-    @named_values[typed_name] = @last_result
+      @last_result = Loader::NamedEntry.new(typed_name, value, origin)
+      @named_values[typed_name] = @last_result
+    end
   end
 
   # @api private
@@ -96,8 +102,10 @@ class BaseLoader < Loader
   # @api private
   #
   def remove_entry(typed_name)
-    unless @named_values.delete(typed_name).nil?
-      @last_result = nil unless @last_result.nil? || typed_name != @last_result.typed_name
+    synchronize do
+      unless @named_values.delete(typed_name).nil?
+        @last_result = nil unless @last_result.nil? || typed_name != @last_result.typed_name
+      end
     end
   end
 
@@ -106,10 +114,12 @@ class BaseLoader < Loader
   # @api private
   #
   def promote_entry(named_entry)
-    typed_name = named_entry.typed_name
-    entry = @named_values[typed_name]
-    if entry then fail_redefine(entry); end
-    @named_values[typed_name] = named_entry
+    synchronize do
+      typed_name = named_entry.typed_name
+      entry = @named_values[typed_name]
+      if entry then fail_redefine(entry); end
+      @named_values[typed_name] = named_entry
+    end
   end
 
   protected

data/lib/puppet/pops/loader/dependency_loader.rb

@@ -18,8 +18,8 @@ class Puppet::Pops::Loader::DependencyLoader < Puppet::Pops::Loader::BaseLoader
   # @param name [String] the name of the dependency-loader (used for debugging and tracing only)
   # @param dependency_loaders [Array<Puppet::Pops::Loader>] array of loaders for modules this module depends on
   #
-  def initialize(parent_loader, name, dependency_loaders)
-    super parent_loader, name
+  def initialize(parent_loader, name, dependency_loaders, environment)
+    super(parent_loader, name, environment)
     @dependency_loaders = dependency_loaders
   end
 

data/lib/puppet/pops/loader/loader.rb

@@ -26,14 +26,15 @@ ENVIRONMENT = 'environment'.freeze
 ENVIRONMENT_PRIVATE = 'environment private'.freeze
 
 class Loader
-  attr_reader :loader_name
+  attr_reader :environment, :loader_name
 
   # Describes the kinds of things that loaders can load
   LOADABLE_KINDS = [:func_4x, :func_4xpp, :func_3x, :datatype, :type_pp, :resource_type_pp, :plan, :task].freeze
 
   # @param [String] name the name of the loader. Must be unique among all loaders maintained by a {Loader} instance
-  def initialize(loader_name)
+  def initialize(loader_name, environment)
     @loader_name = loader_name.freeze
+    @environment = environment
   end
 
   # Search all places where this loader would find values of a given type and return a list the
@@ -69,9 +70,11 @@ class Loader
   # @api public
   #
   def load(type, name)
-    result = load_typed(TypedName.new(type, name.to_s))
-    if result
-      result.value
+    synchronize do
+      result = load_typed(TypedName.new(type, name.to_s))
+      if result
+        result.value
+      end
     end
   end
 
@@ -143,6 +146,13 @@ class Loader
     self
   end
 
+  # Lock around a block
+  # This exists so some subclasses that are set up statically and don't actually
+  # load can override it
+  def synchronize(&block)
+    @environment.lock.synchronize(&block)
+  end
+
   # Binds a value to a name. The name should not start with '::', but may contain multiple segments.
   #
   # @param type [:Symbol] the type of the entity being set

data/lib/puppet/pops/loader/module_loaders.rb

@@ -45,17 +45,17 @@ module ModuleLoaders
     #
     puppet_lib = File.realpath(File.join(File.dirname(__FILE__), '../../..'))
     LibRootedFileBased.new(parent_loader,
-                                                       loaders,
-                                                       nil,
-                                                       puppet_lib,   # may or may not have a 'lib' above 'puppet'
-                                                       'puppet_system',
-                                                        [:func_4x, :func_3x, :datatype]   # only load ruby functions and types from "puppet"
-                                                       )
+                           loaders,
+                           nil,
+                           puppet_lib,   # may or may not have a 'lib' above 'puppet'
+                           'puppet_system',
+                           [:func_4x, :func_3x, :datatype]   # only load ruby functions and types from "puppet"
+                          )
   end
 
   def self.environment_loader_from(parent_loader, loaders, env_path)
     if env_path.nil? || env_path.empty?
-      EmptyLoader.new(parent_loader, ENVIRONMENT)
+      EmptyLoader.new(parent_loader, ENVIRONMENT, loaders.environment)
     else
       FileBased.new(parent_loader,
         loaders,
@@ -125,7 +125,7 @@ module ModuleLoaders
     # @param loader_name [String] a name that is used for human identification (useful when module_name is nil)
     #
     def initialize(parent_loader, loaders, module_name, path, loader_name, loadables)
-      super parent_loader, loader_name
+      super(parent_loader, loader_name, loaders.environment)
 
       raise ArgumentError, 'path based loader cannot be instantiated without a path' if path.nil? || path.empty?
 

data/lib/puppet/pops/loader/predefined_loader.rb

@@ -19,6 +19,10 @@ class PredefinedLoader < BaseLoader
   def allow_shadowing?
     true
   end
+
+  def synchronize(&block)
+    yield
+  end
 end
 
 end

data/lib/puppet/pops/loader/runtime3_type_loader.rb

@@ -10,7 +10,7 @@ class Runtime3TypeLoader < BaseLoader
   attr_reader :resource_3x_loader
 
   def initialize(parent_loader, loaders, environment, resource_3x_loader)
-    super(parent_loader, environment.name)
+    super(parent_loader, environment.name, environment)
     @environment = environment
     @resource_3x_loader = resource_3x_loader
   end