puppet 7.31.0-x86-mingw32 → 8.0.1-x86-mingw32

data/spec/unit/util/profiler/around_profiler_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+require 'puppet/util/profiler'
+
+describe Puppet::Util::Profiler::AroundProfiler do
+  let(:child) { TestAroundProfiler.new() }
+  let(:profiler) { Puppet::Util::Profiler::AroundProfiler.new }
+
+  before :each do
+    profiler.add_profiler(child)
+  end
+
+  it "returns the value of the profiled segment" do
+    retval = profiler.profile("Testing", ["testing"]) { "the return value" }
+
+    expect(retval).to eq("the return value")
+  end
+
+  it "propagates any errors raised in the profiled segment" do
+    expect do
+      profiler.profile("Testing", ["testing"]) { raise "a problem" }
+    end.to raise_error("a problem")
+  end
+
+  it "makes the description and the context available to the `start` and `finish` methods" do
+    profiler.profile("Testing", ["testing"]) { }
+
+    expect(child.context).to eq("Testing")
+    expect(child.description).to eq("Testing")
+  end
+
+  it "calls finish even when an error is raised" do
+    begin
+      profiler.profile("Testing", ["testing"]) { raise "a problem" }
+    rescue
+      expect(child.context).to eq("Testing")
+    end
+  end
+
+  it "supports multiple profilers" do
+    profiler2 = TestAroundProfiler.new
+    profiler.add_profiler(profiler2)
+    profiler.profile("Testing", ["testing"]) {}
+
+    expect(child.context).to eq("Testing")
+    expect(profiler2.context).to eq("Testing")
+  end
+
+  class TestAroundProfiler
+    attr_accessor :context, :description
+
+    def start(description, metric_id)
+      description
+    end
+
+    def finish(context, description, metric_id)
+      @context = context
+      @description = description
+    end
+  end
+end
+

data/spec/unit/util/profiler/logging_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'puppet/util/profiler'
+
+describe Puppet::Util::Profiler::Logging do
+  let(:logger) { SimpleLog.new }
+  let(:identifier) { "Profiling ID" }
+  let(:logging_profiler) { TestLoggingProfiler.new(logger, identifier) }
+  let(:profiler) do
+    p = Puppet::Util::Profiler::AroundProfiler.new
+    p.add_profiler(logging_profiler)
+    p
+  end
+
+  it "logs the explanation of the profile results" do
+    profiler.profile("Testing", ["test"]) { }
+
+    expect(logger.messages.first).to match(/the explanation/)
+  end
+
+  it "describes the profiled segment" do
+    profiler.profile("Tested measurement", ["test"]) { }
+
+    expect(logger.messages.first).to match(/PROFILE \[#{identifier}\] \d Tested measurement/)
+  end
+
+  it "indicates the order in which segments are profiled" do
+    profiler.profile("Measurement", ["measurement"]) { }
+    profiler.profile("Another measurement", ["measurement"]) { }
+
+    expect(logger.messages[0]).to match(/1 Measurement/)
+    expect(logger.messages[1]).to match(/2 Another measurement/)
+  end
+
+  it "indicates the nesting of profiled segments" do
+    profiler.profile("Measurement", ["measurement1"]) do
+      profiler.profile("Nested measurement", ["measurement2"]) { }
+    end
+    profiler.profile("Another measurement", ["measurement1"]) do
+      profiler.profile("Another nested measurement", ["measurement2"]) { }
+    end
+
+    expect(logger.messages[0]).to match(/1.1 Nested measurement/)
+    expect(logger.messages[1]).to match(/1 Measurement/)
+    expect(logger.messages[2]).to match(/2.1 Another nested measurement/)
+    expect(logger.messages[3]).to match(/2 Another measurement/)
+  end
+
+  class TestLoggingProfiler < Puppet::Util::Profiler::Logging
+    def do_start(metric, description)
+      "the start"
+    end
+
+    def do_finish(context, metric, description)
+      {:msg => "the explanation of #{context}"}
+    end
+  end
+
+  class SimpleLog
+    attr_reader :messages
+
+    def initialize
+      @messages = []
+    end
+
+    def call(msg)
+      @messages << msg
+    end
+  end
+end
+

data/spec/unit/util/profiler/object_counts_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+require 'puppet/util/profiler'
+
+describe Puppet::Util::Profiler::ObjectCounts, unless: Puppet::Util::Platform.jruby? do
+  # ObjectSpace is not enabled by default on JRuby
+  it "reports the changes in the system object counts" do
+    profiler = Puppet::Util::Profiler::ObjectCounts.new(nil, nil)
+
+    message = profiler.finish(profiler.start)
+
+    expect(message).to match(/ T_STRING: \d+, /)
+  end
+end

data/spec/unit/util/profiler/wall_clock_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+require 'puppet/util/profiler'
+
+describe Puppet::Util::Profiler::WallClock do
+
+  it "logs the number of seconds it took to execute the segment" do
+    profiler = Puppet::Util::Profiler::WallClock.new(nil, nil)
+
+    message = profiler.do_finish(profiler.start(["foo", "bar"], "Testing"), ["foo", "bar"], "Testing")[:msg]
+
+    expect(message).to match(/took \d\.\d{4} seconds/)
+  end
+end

data/spec/unit/util/profiler_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'puppet/util/profiler'
+
+describe Puppet::Util::Profiler do
+  let(:profiler) { TestProfiler.new() }
+
+  it "supports adding profilers" do
+    subject.add_profiler(profiler)
+    expect(subject.current[0]).to eq(profiler)
+  end
+
+  it "supports removing profilers" do
+    subject.add_profiler(profiler)
+    subject.remove_profiler(profiler)
+    expect(subject.current.length).to eq(0)
+  end
+
+  it "supports clearing profiler list" do
+    subject.add_profiler(profiler)
+    subject.clear
+    expect(subject.current.length).to eq(0)
+  end
+
+  it "supports profiling" do
+    subject.add_profiler(profiler)
+    subject.profile("hi", ["mymetric"]) {}
+    expect(profiler.context[:metric_id]).to eq(["mymetric"])
+    expect(profiler.context[:description]).to eq("hi")
+    expect(profiler.description).to eq("hi")
+  end
+
+  class TestProfiler
+    attr_accessor :context, :metric, :description
+
+    def start(description, metric_id)
+      {:metric_id => metric_id,
+       :description => description}
+    end
+
+    def finish(context, description, metric_id)
+      @context = context
+      @metric_id = metric_id
+      @description = description
+    end
+  end
+end
+

data/spec/unit/util/rdoc_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+require 'puppet/util/rdoc'
+require 'rdoc/rdoc'
+
+describe Puppet::Util::RDoc do
+  describe "when generating RDoc HTML documentation" do
+    before :each do
+      @rdoc = double('rdoc')
+      allow(RDoc::RDoc).to receive(:new).and_return(@rdoc)
+    end
+
+    it "should tell RDoc to generate documentation using the Puppet generator" do
+      expect(@rdoc).to receive(:document).with(include("--fmt").and(include("puppet")))
+
+      Puppet::Util::RDoc.rdoc("output", [])
+    end
+
+    it "should tell RDoc to be quiet" do
+      expect(@rdoc).to receive(:document).with(include("--quiet"))
+
+      Puppet::Util::RDoc.rdoc("output", [])
+    end
+
+    it "should pass charset to RDoc" do
+      expect(@rdoc).to receive(:document).with(include("--charset").and(include("utf-8")))
+
+      Puppet::Util::RDoc.rdoc("output", [], "utf-8")
+    end
+
+    it "should tell RDoc to use the given outputdir" do
+      expect(@rdoc).to receive(:document).with(include("--op").and(include("myoutputdir")))
+
+      Puppet::Util::RDoc.rdoc("myoutputdir", [])
+    end
+
+    it "should tell RDoc to exclude all files under any modules/<mod>/files section" do
+      expect(@rdoc).to receive(:document).with(include("--exclude").and(include("/modules/[^/]*/files/.*$")))
+
+      Puppet::Util::RDoc.rdoc("myoutputdir", [])
+    end
+
+    it "should tell RDoc to exclude all files under any modules/<mod>/templates section" do
+      expect(@rdoc).to receive(:document).with(include("--exclude").and(include("/modules/[^/]*/templates/.*$")))
+
+      Puppet::Util::RDoc.rdoc("myoutputdir", [])
+    end
+
+    it "should give all the source directories to RDoc" do
+      expect(@rdoc).to receive(:document).with(include("sourcedir"))
+
+      Puppet::Util::RDoc.rdoc("output", ["sourcedir"])
+    end
+  end
+end

data/spec/unit/util/reference_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+require 'puppet/util/reference'
+
+describe Puppet::Util::Reference do
+  it "should create valid Markdown extension definition lists" do
+    my_fragment = nil
+    Puppet::Util::Reference.newreference :testreference, :doc => "A peer of the type and configuration references, but with no useful information" do
+      my_term = "A term"
+      my_definition = <<-EOT
+        The definition of this term, marked by a colon and a space.
+        We should be able to handle multi-line definitions. Each subsequent
+        line should left-align with the first word character after the colon
+        used as the definition marker.
+
+        We should be able to handle multi-paragraph definitions.
+
+        Leading indentation should be stripped from the definition, which allows
+        us to indent the source string for cosmetic purposes.
+      EOT
+      my_fragment = markdown_definitionlist(my_term, my_definition)
+    end
+    Puppet::Util::Reference.reference(:testreference).send(:to_markdown, true)
+    expect(my_fragment).to eq <<-EOT
+A term
+: The definition of this term, marked by a colon and a space.
+  We should be able to handle multi-line definitions. Each subsequent
+  line should left-align with the first word character after the colon
+  used as the definition marker.
+
+  We should be able to handle multi-paragraph definitions.
+
+  Leading indentation should be stripped from the definition, which allows
+  us to indent the source string for cosmetic purposes.
+
+    EOT
+  end
+
+end

data/spec/unit/util/resource_template_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+require 'puppet/util/resource_template'
+
+describe Puppet::Util::ResourceTemplate do
+  describe "when initializing" do
+    it "should fail if the template does not exist" do
+      expect(Puppet::FileSystem).to receive(:exist?).with("/my/template").and_return(false)
+      expect { Puppet::Util::ResourceTemplate.new("/my/template", double('resource')) }.to raise_error(ArgumentError)
+    end
+
+    it "should not create the ERB template" do
+      expect(ERB).not_to receive(:new)
+      expect(Puppet::FileSystem).to receive(:exist?).with("/my/template").and_return(true)
+      Puppet::Util::ResourceTemplate.new("/my/template", double('resource'))
+    end
+  end
+
+  describe "when evaluating" do
+    before do
+      allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
+      allow(Puppet::FileSystem).to receive(:read).and_return("eh")
+
+      @template = double('template', :result => nil)
+      allow(ERB).to receive(:new).and_return(@template)
+
+      @resource = double('resource')
+      @wrapper = Puppet::Util::ResourceTemplate.new("/my/template", @resource)
+    end
+
+    it "should set all of the resource's parameters as instance variables" do
+      expect(@resource).to receive(:to_hash).and_return(:one => "uno", :two => "dos")
+      expect(@template).to receive(:result) do |bind|
+        expect(eval("@one", bind)).to eq("uno")
+        expect(eval("@two", bind)).to eq("dos")
+      end
+      @wrapper.evaluate
+    end
+
+    it "should create a template instance with the contents of the file" do
+      expect(Puppet::FileSystem).to receive(:read).with("/my/template", {:encoding => 'utf-8'}).and_return("yay")
+      expect(Puppet::Util).to receive(:create_erb).with("yay").and_return(@template)
+
+      allow(@wrapper).to receive(:set_resource_variables)
+
+      @wrapper.evaluate
+    end
+
+    it "should return the result of the template" do
+      allow(@wrapper).to receive(:set_resource_variables)
+
+      expect(@wrapper).to receive(:binding).and_return("mybinding")
+      expect(@template).to receive(:result).with("mybinding").and_return("myresult")
+      expect(@wrapper.evaluate).to eq("myresult")
+    end
+  end
+end

data/spec/unit/util/retry_action_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+require 'puppet/util/retry_action'
+
+describe Puppet::Util::RetryAction do
+  let (:exceptions) { [ Puppet::Error, NameError ] }
+
+  it "doesn't retry SystemExit" do
+    expect do
+      Puppet::Util::RetryAction.retry_action( :retries => 0 ) do
+        raise SystemExit
+      end
+    end.to exit_with(0)
+  end
+
+  it "doesn't retry NoMemoryError" do
+    expect do
+      Puppet::Util::RetryAction.retry_action( :retries => 0 ) do
+        raise NoMemoryError, "OOM"
+      end
+    end.to raise_error(NoMemoryError, /OOM/)
+  end
+
+  it 'should retry on any exception if no acceptable exceptions given' do
+    expect(Puppet::Util::RetryAction).to receive(:sleep).with( (((2 ** 1) -1) * 0.1) )
+    expect(Puppet::Util::RetryAction).to receive(:sleep).with( (((2 ** 2) -1) * 0.1) )
+
+    expect do
+      Puppet::Util::RetryAction.retry_action( :retries => 2 ) do
+        raise ArgumentError, 'Fake Failure'
+      end
+    end.to raise_exception(Puppet::Util::RetryAction::RetryException::RetriesExceeded)
+  end
+
+  it 'should retry on acceptable exceptions' do
+    expect(Puppet::Util::RetryAction).to receive(:sleep).with( (((2 ** 1) -1) * 0.1) )
+    expect(Puppet::Util::RetryAction).to receive(:sleep).with( (((2 ** 2) -1) * 0.1) )
+
+    expect do
+      Puppet::Util::RetryAction.retry_action( :retries => 2, :retry_exceptions => exceptions) do
+        raise Puppet::Error, 'Fake Failure'
+      end
+    end.to raise_exception(Puppet::Util::RetryAction::RetryException::RetriesExceeded)
+  end
+
+  it 'should not retry on unacceptable exceptions' do
+    expect(Puppet::Util::RetryAction).not_to receive(:sleep)
+
+    expect do
+      Puppet::Util::RetryAction.retry_action( :retries => 2, :retry_exceptions => exceptions) do
+        raise ArgumentError
+      end
+    end.to raise_exception(ArgumentError)
+  end
+
+  it 'should succeed if nothing is raised' do
+    expect(Puppet::Util::RetryAction).not_to receive(:sleep)
+
+    Puppet::Util::RetryAction.retry_action( :retries => 2) do
+      true
+    end
+  end
+
+  it 'should succeed if an expected exception is raised retried and succeeds' do
+    should_retry = nil
+    expect(Puppet::Util::RetryAction).to receive(:sleep).once
+
+    Puppet::Util::RetryAction.retry_action( :retries => 2, :retry_exceptions => exceptions) do
+      if should_retry
+        true
+      else
+        should_retry = true
+        raise Puppet::Error, 'Fake error'
+      end
+    end
+  end
+
+  it "doesn't mutate caller's arguments" do
+    options = { :retries => 1 }.freeze
+
+    Puppet::Util::RetryAction.retry_action(options) do
+    end
+  end
+end

data/spec/unit/util/rpm_compare_spec.rb

@@ -0,0 +1,196 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'puppet/util/rpm_compare'
+
+describe Puppet::Util::RpmCompare do
+  class RpmTest
+    extend Puppet::Util::RpmCompare
+  end
+
+  describe '.rpmvercmp' do
+    # test cases munged directly from rpm's own
+    # tests/rpmvercmp.at
+    it { expect(RpmTest.rpmvercmp('1.0', '1.0')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('1.0', '2.0')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('2.0', '1.0')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('2.0.1', '2.0.1')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('2.0', '2.0.1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('2.0.1', '2.0')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('2.0.1a', '2.0.1a')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('2.0.1a', '2.0.1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('2.0.1', '2.0.1a')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('5.5p1', '5.5p1')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('5.5p1', '5.5p2')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('5.5p2', '5.5p1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('5.5p10', '5.5p10')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('5.5p1', '5.5p10')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('5.5p10', '5.5p1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('10xyz', '10.1xyz')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('10.1xyz', '10xyz')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('xyz10', 'xyz10')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('xyz10', 'xyz10.1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('xyz10.1', 'xyz10')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('xyz.4', 'xyz.4')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('xyz.4', '8')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('8', 'xyz.4')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('xyz.4', '2')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('2', 'xyz.4')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('5.5p2', '5.6p1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('5.6p1', '5.5p2')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('5.6p1', '6.5p1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('6.5p1', '5.6p1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('6.0.rc1', '6.0')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('6.0', '6.0.rc1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('10b2', '10a1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('10a2', '10b2')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1.0aa', '1.0aa')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('1.0a', '1.0aa')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1.0aa', '1.0a')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('10.0001', '10.0001')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('10.0001', '10.1')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('10.1', '10.0001')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('10.0001', '10.0039')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('10.0039', '10.0001')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('4.999.9', '5.0')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('5.0', '4.999.9')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('20101121', '20101121')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('20101121', '20101122')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('20101122', '20101121')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('2_0', '2_0')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('2.0', '2_0')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('2_0', '2.0')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('a', 'a')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('a+', 'a+')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('a+', 'a_')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('a_', 'a+')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('+a', '+a')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('+a', '_a')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('_a', '+a')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('+_', '+_')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('_+', '+_')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('_+', '_+')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('+', '_')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('_', '+')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1', '1.0~rc1')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1', '1.0')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1.0', '1.0~rc1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1', '1.0~rc2')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc2', '1.0~rc1')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1~git123', '1.0~rc1~git123')).to eq(0) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1~git123', '1.0~rc1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1', '1.0~rc1~git123')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('1.0~rc1', '1.0arc1')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('', '~')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('~', '~~')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('~', '~+~')).to eq(1) }
+    it { expect(RpmTest.rpmvercmp('~', '~a')).to eq(-1) }
+
+    # non-upstream test cases
+    it { expect(RpmTest.rpmvercmp('405', '406')).to eq(-1) }
+    it { expect(RpmTest.rpmvercmp('1', '0')).to eq(1) }
+  end
+
+  describe '.rpm_compareEVR' do
+    it 'evaluates identical version-release as equal' do
+      expect(RpmTest.rpm_compareEVR('1.2.3-1.el5', '1.2.3-1.el5')).to eq(0)
+    end
+
+    it 'evaluates identical version as equal' do
+      expect(RpmTest.rpm_compareEVR('1.2.3', '1.2.3')).to eq(0)
+    end
+
+    it 'evaluates identical version but older release as less' do
+      expect(RpmTest.rpm_compareEVR('1.2.3-1.el5', '1.2.3-2.el5')).to eq(-1)
+    end
+
+    it 'evaluates identical version but newer release as greater' do
+      expect(RpmTest.rpm_compareEVR('1.2.3-3.el5', '1.2.3-2.el5')).to eq(1)
+    end
+
+    it 'evaluates a newer epoch as greater' do
+      expect(RpmTest.rpm_compareEVR('1:1.2.3-4.5', '1.2.3-4.5')).to eq(1)
+    end
+
+    # these tests describe PUP-1244 logic yet to be implemented
+    it 'evaluates any version as equal to the same version followed by release' do
+      expect(RpmTest.rpm_compareEVR('1.2.3', '1.2.3-2.el5')).to eq(0)
+    end
+
+    # test cases for PUP-682
+    it 'evaluates same-length numeric revisions numerically' do
+      expect(RpmTest.rpm_compareEVR('2.2-405', '2.2-406')).to eq(-1)
+    end
+  end
+
+  describe '.rpm_parse_evr' do
+    it 'parses full simple evr' do
+      version = RpmTest.rpm_parse_evr('0:1.2.3-4.el5')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq(['0', '1.2.3', '4.el5'])
+    end
+
+    it 'parses version only' do
+      version = RpmTest.rpm_parse_evr('1.2.3')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '1.2.3', nil])
+    end
+
+    it 'parses version-release' do
+      version = RpmTest.rpm_parse_evr('1.2.3-4.5.el6')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '1.2.3', '4.5.el6'])
+    end
+
+    it 'parses release with git hash' do
+      version = RpmTest.rpm_parse_evr('1.2.3-4.1234aefd')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '1.2.3', '4.1234aefd'])
+    end
+
+    it 'parses single integer versions' do
+      version = RpmTest.rpm_parse_evr('12345')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '12345', nil])
+    end
+
+    it 'parses text in the epoch to 0' do
+      version = RpmTest.rpm_parse_evr('foo0:1.2.3-4')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '1.2.3', '4'])
+    end
+
+    it 'parses revisions with text' do
+      version = RpmTest.rpm_parse_evr('1.2.3-SNAPSHOT20140107')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '1.2.3', 'SNAPSHOT20140107'])
+    end
+
+    # test cases for PUP-682
+    it 'parses revisions with text and numbers' do
+      version = RpmTest.rpm_parse_evr('2.2-SNAPSHOT20121119105647')
+      expect([version[:epoch], version[:version], version[:release]]).to \
+        eq([nil, '2.2', 'SNAPSHOT20121119105647'])
+    end
+  end
+
+  describe '.compare_values' do
+    it 'treats two nil values as equal' do
+      expect(RpmTest.compare_values(nil, nil)).to eq(0)
+    end
+
+    it 'treats a nil value as less than a non-nil value' do
+      expect(RpmTest.compare_values(nil, '0')).to eq(-1)
+    end
+
+    it 'treats a non-nil value as greater than a nil value' do
+      expect(RpmTest.compare_values('0', nil)).to eq(1)
+    end
+
+    it 'passes two non-nil values on to rpmvercmp' do
+      allow(RpmTest).to receive(:rpmvercmp).and_return(0)
+      expect(RpmTest).to receive(:rpmvercmp).with('s1', 's2')
+      RpmTest.compare_values('s1', 's2')
+    end
+  end
+end