puppet 7.28.0-universal-darwin → 8.0.1-universal-darwin

data/lib/puppet/util/package/version/range/simple.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../../../puppet/util/package/version/range'
 
 module Puppet::Util::Package::Version

data/lib/puppet/util/package/version/range.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'range/lt'
 require_relative 'range/lt_eq'
 require_relative 'range/gt'

data/lib/puppet/util/package/version/rpm.rb

@@ -19,7 +19,7 @@ module Puppet::Util::Package::Version
     end
 
     def to_s
-      version_found = ''
+      version_found = String.new
       version_found += "#{@epoch}:"   if @epoch
       version_found += @version
       version_found += "-#{@release}" if @release

data/lib/puppet/util/pidlock.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'fileutils'
 require_relative '../../puppet/util/lockfile'
 

data/lib/puppet/util/platform.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 module Puppet
   module Util
     module Platform
-      FIPS_STATUS_FILE = "/proc/sys/crypto/fips_enabled".freeze
-      WINDOWS_FIPS_REGISTRY_KEY = 'System\\CurrentControlSet\\Control\\Lsa\\FipsAlgorithmPolicy'.freeze
+      FIPS_STATUS_FILE = "/proc/sys/crypto/fips_enabled"
+      WINDOWS_FIPS_REGISTRY_KEY = 'System\\CurrentControlSet\\Control\\Lsa\\FipsAlgorithmPolicy'
 
       def windows?
         # Ruby only sets File::ALT_SEPARATOR on Windows and the Ruby standard

data/lib/puppet/util/plist.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cfpropertylist' if Puppet.features.cfpropertylist?
 require_relative '../../puppet/util/execution'
 

data/lib/puppet/util/posix.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Utility methods for interacting with POSIX objects; mostly user and group
 module Puppet::Util::POSIX
 

data/lib/puppet/util/profiler/aggregate.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/profiler'
 require_relative '../../../puppet/util/profiler/wall_clock'
 

data/lib/puppet/util/profiler/around_profiler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A Profiler that can be used to wrap around blocks of code. It is configured
 # with other profilers and controls them to start before the block is executed
 # and finish after the block is executed.

data/lib/puppet/util/profiler/logging.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::Util::Profiler::Logging
   def initialize(logger, identifier)
     @logger = logger

data/lib/puppet/util/profiler/object_counts.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/profiler/logging'
 
 class Puppet::Util::Profiler::ObjectCounts < Puppet::Util::Profiler::Logging

data/lib/puppet/util/profiler/wall_clock.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/profiler/logging'
 
 # A profiler implementation that measures the number of seconds a segment of

data/lib/puppet/util/profiler.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'benchmark'
 
 # A simple profiling callback system.

data/lib/puppet/util/provider_features.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Provides feature definitions.
 require_relative '../../puppet/util/docs'
 require_relative '../../puppet/util'
@@ -75,7 +76,7 @@ module Puppet::Util::ProviderFeatures
 
   # @return [String] Returns a string with documentation covering all features.
   def featuredocs
-    str = ""
+    str = String.new
     @features ||= {}
     return nil if @features.empty?
     names = @features.keys.sort_by(&:to_s)

data/lib/puppet/util/psych_support.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This module should be included when a class can be serialized to yaml and
 # needs to handle the deserialization from Psych with more control. Psych normally
 # pokes values directly into an instance using `instance_variable_set` which completely

data/lib/puppet/util/rdoc/code_objects.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rdoc/code_objects'
 
 module RDoc

data/lib/puppet/util/rdoc/generators/puppet_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rdoc/generators/html_generator'
 require_relative '../../../../puppet/util/rdoc/code_objects'
 require 'digest/md5'

data/lib/puppet/util/rdoc/generators/template/puppet/puppet.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # = CSS2 RDoc HTML template
 #

data/lib/puppet/util/rdoc/parser/puppet_parser_core.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Functionality common to both our RDoc version 1 and 2 parsers.
 module RDoc::PuppetParserCore
 

data/lib/puppet/util/rdoc/parser/puppet_parser_rdoc2.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../../puppet/util/rdoc/parser/puppet_parser_core.rb'
 
 module RDoc

data/lib/puppet/util/rdoc/parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Puppet "parser" for the rdoc system
 # The parser uses puppet parser and traverse the AST to instruct RDoc about
 # our current structures. It also parses ruby files that could contain

data/lib/puppet/util/rdoc.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util'
 module Puppet::Util::RDoc
   module_function

data/lib/puppet/util/reference.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/instance_loader'
 require 'fileutils'
 

data/lib/puppet/util/resource_template.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util'
 require_relative '../../puppet/util/logging'
 require 'erb'

data/lib/puppet/util/retry_action.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::RetryAction
   class RetryException < Exception; end
   class RetryException::NoBlockGiven < RetryException; end

data/lib/puppet/util/rpm_compare.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::RpmCompare
 
   ARCH_LIST = %w(

data/lib/puppet/util/rubygems.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util'
 
 module Puppet::Util::RubyGems

data/lib/puppet/util/run_mode.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'etc'
 
 module Puppet

data/lib/puppet/util/selinux.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Provides utility functions to help interface Puppet to SELinux.
 #
 # This requires the very new SELinux Ruby bindings.  These bindings closely
@@ -226,7 +227,7 @@ module Puppet::Util::SELinux
 
   # Internal helper function to read and parse /proc/mounts
   def read_mounts
-    mounts = ""
+    mounts = String.new
     begin
       if File.method_defined? "read_nonblock"
         # If possible we use read_nonblock in a loop rather than read to work-

data/lib/puppet/util/skip_tags.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/tagging'
 
 class Puppet::Util::SkipTags

data/lib/puppet/util/splayer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Handle splay options (sleeping for a random interval before executing)
 module Puppet::Util::Splayer
   # Have we splayed already?

data/lib/puppet/util/storage.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'yaml'
 require 'singleton'
 require_relative '../../puppet/util/yaml'

data/lib/puppet/util/suidmanager.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/warnings'
 require 'forwardable'
 require 'etc'
@@ -17,7 +18,7 @@ module Puppet::Util::SUIDManager
 
   def osx_maj_ver
     return @osx_maj_ver unless @osx_maj_ver.nil?
-    @osx_maj_ver = Puppet.runtime[:facter].value('macosx_productversion_major') || false
+    @osx_maj_ver = Puppet.runtime[:facter].value('os.macosx.version.major') || false
   end
   module_function :osx_maj_ver
 

data/lib/puppet/util/symbolic_file_mode.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util'
 
 module Puppet

data/lib/puppet/util/tag_set.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'set'
 require_relative '../../puppet/network/format_support'
 

data/lib/puppet/util/terminal.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Terminal
   # Attempts to determine the width of the terminal.  This is currently only
   # supported on POSIX systems, and relies on the claims of `stty` (or `tput`).

data/lib/puppet/util/user_attr.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class UserAttr
   def self.get_attributes_by_name(name)
     attributes = nil

data/lib/puppet/util/warnings.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Methods to help with handling warnings.
 module Puppet::Util::Warnings
   module_function

data/lib/puppet/util/watched_file.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/watcher'
 
 # Monitor a given file for changes on a periodic interval. Changes are detected

data/lib/puppet/util/watcher/change_watcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Watches for changes over time. It only re-examines the values when it is requested to update readings.
 # @api private
 class Puppet::Util::Watcher::ChangeWatcher

data/lib/puppet/util/watcher/periodic_watcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Monitor a given watcher for changes on a periodic interval.
 class Puppet::Util::Watcher::PeriodicWatcher
   # @param watcher [Puppet::Util::Watcher::ChangeWatcher] a watcher for the value to watch

data/lib/puppet/util/watcher/timer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::Util::Watcher::Timer
   attr_reader :timeout
 

data/lib/puppet/util/watcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Watcher
   require_relative 'watcher/timer'
   require_relative 'watcher/change_watcher'

data/lib/puppet/util/windows/access_control_entry.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Windows Access Control Entry
 #
 # Represents an access control entry, which grants or denies a subject,
@@ -60,7 +61,7 @@ class Puppet::Util::Windows::AccessControlEntry
   end
 
   def inspect
-    inheritance = ""
+    inheritance = String.new
     inheritance << '(I)' if inherited?
     inheritance << '(OI)' if object_inherit?
     inheritance << '(CI)' if container_inherit?

data/lib/puppet/util/windows/access_control_list.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Windows Access Control List
 #
 # Represents a list of access control entries (ACEs).
@@ -97,7 +98,7 @@ class Puppet::Util::Windows::AccessControlList
   end
 
   def inspect
-    str = ""
+    str = String.new
     @aces.each do |ace|
       str << "  #{ace.inspect}\n"
     end

data/lib/puppet/util/windows/adsi.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Windows::ADSI
   require 'ffi'
 
@@ -175,13 +176,6 @@ module Puppet::Util::Windows::ADSI
         sids = []
         adsi_child_collection.each do |m|
           sids << Puppet::Util::Windows::SID.ads_to_principal(m)
-        rescue Puppet::Util::Windows::Error => e
-          case e.code
-          when Puppet::Util::Windows::SID::ERROR_TRUSTED_RELATIONSHIP_FAILURE, Puppet::Util::Windows::SID::ERROR_TRUSTED_DOMAIN_FAILURE
-            sids << Puppet::Util::Windows::SID.unresolved_principal(m.name, m.sid)
-          else
-            raise e
-          end
         end
 
         sids
@@ -494,7 +488,7 @@ module Puppet::Util::Windows::ADSI
     # UNLEN from lmcons.h - https://stackoverflow.com/a/2155176
     MAX_USERNAME_LENGTH = 256
     def self.current_user_name
-      user_name = ''
+      user_name = String.new
       max_length = MAX_USERNAME_LENGTH + 1 # NULL terminated
       FFI::MemoryPointer.new(max_length * 2) do |buffer| # wide string
         FFI::MemoryPointer.new(:dword, 1) do |buffer_size|
@@ -526,7 +520,7 @@ module Puppet::Util::Windows::ADSI
     NameSurname           = 14
 
     def self.current_user_name_with_format(format)
-      user_name = ''
+      user_name = String.new
       max_length = 1024
 
       FFI::MemoryPointer.new(:lpwstr, max_length * 2 + 1) do |buffer|

data/lib/puppet/util/windows/com.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ffi'
 
 module Puppet::Util::Windows::COM

data/lib/puppet/util/windows/daemon.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::Util::Windows

data/lib/puppet/util/windows/error.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 require_relative '../../../puppet/error'
 
@@ -31,7 +32,7 @@ class Puppet::Util::Windows::Error < Puppet::Error
             FORMAT_MESSAGE_ARGUMENT_ARRAY |
             FORMAT_MESSAGE_IGNORE_INSERTS |
             FORMAT_MESSAGE_MAX_WIDTH_MASK
-    error_string = ''
+    error_string = String.new
 
     # this pointer actually points to a :lpwstr (pointer) since we're letting Windows allocate for us
     FFI::MemoryPointer.new(:pointer, 1) do |buffer_ptr|

data/lib/puppet/util/windows/eventlog.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ffi'
 
 # Puppet::Util::Windows::EventLog needs to be requirable without having loaded

data/lib/puppet/util/windows/file.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::Util::Windows::File
@@ -244,7 +245,7 @@ module Puppet::Util::Windows::File
   module_function :readlink
 
   def get_long_pathname(path)
-    converted = ''
+    converted = String.new
     FFI::Pointer.from_string_to_wide_string(path) do |path_ptr|
       # includes terminating NULL
       buffer_size = GetLongPathNameW(path_ptr, FFI::Pointer::NULL, 0)
@@ -262,7 +263,7 @@ module Puppet::Util::Windows::File
   module_function :get_long_pathname
 
   def get_short_pathname(path)
-    converted = ''
+    converted = String.new
     FFI::Pointer.from_string_to_wide_string(path) do |path_ptr|
       # includes terminating NULL
       buffer_size = GetShortPathNameW(path_ptr, FFI::Pointer::NULL, 0)

data/lib/puppet/util/windows/principal.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 
 module Puppet::Util::Windows::SID

data/lib/puppet/util/windows/process.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows/monkey_patches/process'
 require_relative '../../../puppet/ffi/windows'
 
@@ -120,7 +121,7 @@ module Puppet::Util::Windows::Process
   module_function :with_process_token
 
   def get_process_image_name_by_pid(pid)
-    image_name = ""
+    image_name = String.new
 
     Puppet::Util::Windows::Security.with_privilege(Puppet::Util::Windows::Security::SE_DEBUG_NAME) do
       open_process(PROCESS_QUERY_INFORMATION, false, pid) do |phandle|

data/lib/puppet/util/windows/registry.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 
 module Puppet::Util::Windows

data/lib/puppet/util/windows/root_certs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 require_relative '../../../puppet/ssl/openssl_loader'
 require 'ffi'

data/lib/puppet/util/windows/security.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This class maps POSIX owner, group, and modes to the Windows
 # security model, and back.
 #

data/lib/puppet/util/windows/security_descriptor.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Windows Security Descriptor
 #
 # Represents a security descriptor that can be applied to any Windows securable

data/lib/puppet/util/windows/service.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::Util::Windows

data/lib/puppet/util/windows/sid.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 
 module Puppet::Util::Windows
@@ -6,10 +7,8 @@ module Puppet::Util::Windows
     extend FFI::Library
 
     # missing from Windows::Error
-    ERROR_NONE_MAPPED                  = 1332
-    ERROR_INVALID_SID_STRUCTURE        = 1337
-    ERROR_TRUSTED_DOMAIN_FAILURE       = 1788
-    ERROR_TRUSTED_RELATIONSHIP_FAILURE = 1789
+    ERROR_NONE_MAPPED           = 1332
+    ERROR_INVALID_SID_STRUCTURE = 1337
 
     # Well Known SIDs
     Null                        = 'S-1-0'

data/lib/puppet/util/windows/string.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   module Util
     module Windows

data/lib/puppet/util/windows/user.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/windows'
 
 require 'ffi'

data/lib/puppet/util/windows.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/platform'
 
 module Puppet::Util::Windows

data/lib/puppet/util/yaml.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'yaml'
 
 module Puppet::Util::Yaml