puppet 7.28.0-universal-darwin → 7.29.1-universal-darwin

data/spec/unit/type/user_spec.rb

@@ -1,553 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe Puppet::Type.type(:user) do
-  before :each do
-    @provider_class = described_class.provide(:simple) do
-      has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_roles, :manages_shell
-      mk_resource_methods
-      def create; end
-      def delete; end
-      def exists?; get(:ensure) != :absent; end
-      def flush; end
-      def self.instances; []; end
-    end
-    allow(described_class).to receive(:defaultprovider).and_return(@provider_class)
-  end
-
-  it "should be able to create an instance" do
-    expect(described_class.new(:name => "foo")).not_to be_nil
-  end
-
-  it "should have an allows_duplicates feature" do
-    expect(described_class.provider_feature(:allows_duplicates)).not_to be_nil
-  end
-
-  it "should have a manages_homedir feature" do
-    expect(described_class.provider_feature(:manages_homedir)).not_to be_nil
-  end
-
-  it "should have a manages_passwords feature" do
-    expect(described_class.provider_feature(:manages_passwords)).not_to be_nil
-  end
-
-  it "should have a manages_solaris_rbac feature" do
-    expect(described_class.provider_feature(:manages_solaris_rbac)).not_to be_nil
-  end
-
-  it "should have a manages_roles feature" do
-    expect(described_class.provider_feature(:manages_roles)).not_to be_nil
-  end
-
-  it "should have a manages_expiry feature" do
-    expect(described_class.provider_feature(:manages_expiry)).not_to be_nil
-  end
-
-  it "should have a manages_password_age feature" do
-    expect(described_class.provider_feature(:manages_password_age)).not_to be_nil
-  end
-
-  it "should have a system_users feature" do
-    expect(described_class.provider_feature(:system_users)).not_to be_nil
-  end
-
-  it "should have a manages_shell feature" do
-    expect(described_class.provider_feature(:manages_shell)).not_to be_nil
-  end
-
-  context "managehome" do
-    let (:provider) { @provider_class.new(:name => 'foo', :ensure => :absent) }
-    let (:instance) { described_class.new(:name => 'foo', :provider => provider) }
-
-    it "defaults to false" do
-      expect(instance[:managehome]).to be_falsey
-    end
-
-    it "can be set to false" do
-      instance[:managehome] = 'false'
-    end
-
-    it "cannot be set to true for a provider that does not manage homedirs" do
-      allow(provider.class).to receive(:manages_homedir?).and_return(false)
-      expect { instance[:managehome] = 'yes' }.to raise_error(Puppet::Error, /can not manage home directories/)
-    end
-
-    it "can be set to true for a provider that does manage homedirs" do
-      allow(provider.class).to receive(:manages_homedir?).and_return(true)
-      instance[:managehome] = 'yes'
-    end
-  end
-
-  describe "instances" do
-    it "should delegate existence questions to its provider" do
-      @provider = @provider_class.new(:name => 'foo', :ensure => :absent)
-      instance = described_class.new(:name => "foo", :provider => @provider)
-      expect(instance.exists?).to eq(false)
-
-      @provider.set(:ensure => :present)
-      expect(instance.exists?).to eq(true)
-    end
-  end
-
-  properties = [:ensure, :uid, :gid, :home, :comment, :shell, :password, :password_min_age, :password_max_age, :password_warn_days, :groups, :roles, :auths, :profiles, :project, :keys, :expiry]
-
-  properties.each do |property|
-    it "should have a #{property} property" do
-      expect(described_class.attrclass(property).ancestors).to be_include(Puppet::Property)
-    end
-
-    it "should have documentation for its #{property} property" do
-      expect(described_class.attrclass(property).doc).to be_instance_of(String)
-    end
-  end
-
-  list_properties = [:groups, :roles, :auths]
-
-  list_properties.each do |property|
-    it "should have a list '#{property}'" do
-      expect(described_class.attrclass(property).ancestors).to be_include(Puppet::Property::List)
-    end
-  end
-
-  it "should have an ordered list 'profiles'" do
-    expect(described_class.attrclass(:profiles).ancestors).to be_include(Puppet::Property::OrderedList)
-  end
-
-  it "should have key values 'keys'" do
-    expect(described_class.attrclass(:keys).ancestors).to be_include(Puppet::Property::KeyValue)
-  end
-
-  describe "when retrieving all current values" do
-    before do
-      @provider = @provider_class.new(:name => 'foo', :ensure => :present, :uid => 15, :gid => 15)
-      @user = described_class.new(:name => "foo", :uid => 10, :provider => @provider)
-    end
-
-    it "should return a hash containing values for all set properties" do
-      @user[:gid] = 10
-      values = @user.retrieve
-      [@user.property(:uid), @user.property(:gid)].each { |property| expect(values).to be_include(property) }
-    end
-
-    it "should set all values to :absent if the user is absent" do
-      expect(@user.property(:ensure)).to receive(:retrieve).and_return(:absent)
-      expect(@user.property(:uid)).not_to receive(:retrieve)
-      expect(@user.retrieve[@user.property(:uid)]).to eq(:absent)
-    end
-
-    it "should include the result of retrieving each property's current value if the user is present" do
-      expect(@user.retrieve[@user.property(:uid)]).to eq(15)
-    end
-  end
-
-  describe "when managing the ensure property" do
-    it "should support a :present value" do
-      expect { described_class.new(:name => 'foo', :ensure => :present) }.to_not raise_error
-    end
-
-    it "should support an :absent value" do
-      expect { described_class.new(:name => 'foo', :ensure => :absent) }.to_not raise_error
-    end
-
-    it "should call :create on the provider when asked to sync to the :present state" do
-      @provider = @provider_class.new(:name => 'foo', :ensure => :absent)
-      expect(@provider).to receive(:create)
-      described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).sync
-    end
-
-    it "should call :delete on the provider when asked to sync to the :absent state" do
-      @provider = @provider_class.new(:name => 'foo', :ensure => :present)
-      expect(@provider).to receive(:delete)
-      described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).sync
-    end
-
-    describe "and determining the current state" do
-      it "should return :present when the provider indicates the user exists" do
-        @provider = @provider_class.new(:name => 'foo', :ensure => :present)
-        expect(described_class.new(:name => 'foo', :ensure => :absent, :provider => @provider).parameter(:ensure).retrieve).to eq(:present)
-      end
-
-      it "should return :absent when the provider indicates the user does not exist" do
-        @provider = @provider_class.new(:name => 'foo', :ensure => :absent)
-        expect(described_class.new(:name => 'foo', :ensure => :present, :provider => @provider).parameter(:ensure).retrieve).to eq(:absent)
-      end
-    end
-  end
-
-  describe "when managing the uid property" do
-    it "should convert number-looking strings into actual numbers" do
-      expect(described_class.new(:name => 'foo', :uid => '50')[:uid]).to eq(50)
-    end
-
-    it "should support UIDs as numbers" do
-      expect(described_class.new(:name => 'foo', :uid => 50)[:uid]).to eq(50)
-    end
-
-    it "should support :absent as a value" do
-      expect(described_class.new(:name => 'foo', :uid => :absent)[:uid]).to eq(:absent)
-    end
-  end
-
-  describe "when managing the gid" do
-    it "should support :absent as a value" do
-      expect(described_class.new(:name => 'foo', :gid => :absent)[:gid]).to eq(:absent)
-    end
-
-    it "should convert number-looking strings into actual numbers" do
-      expect(described_class.new(:name => 'foo', :gid => '50')[:gid]).to eq(50)
-    end
-
-    it "should support GIDs specified as integers" do
-      expect(described_class.new(:name => 'foo', :gid => 50)[:gid]).to eq(50)
-    end
-
-    it "should support groups specified by name" do
-      expect(described_class.new(:name => 'foo', :gid => 'foo')[:gid]).to eq('foo')
-    end
-
-    describe "when testing whether in sync" do
-      it "should return true if no 'should' values are set" do
-        # this is currently not the case because gid has no default value, so we would never even
-        # call insync? on that property
-        if param = described_class.new(:name => 'foo').parameter(:gid)
-          expect(param).to be_safe_insync(500)
-        end
-      end
-
-      it "should return true if any of the specified groups are equal to the current integer" do
-        expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
-        expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
-        expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to be_safe_insync(500)
-      end
-
-      it "should return false if none of the specified groups are equal to the current integer" do
-        expect(Puppet::Util).to receive(:gid).with("foo").and_return(300)
-        expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
-        expect(described_class.new(:name => 'baz', :gid => [ 'foo', 'bar' ]).parameter(:gid)).to_not be_safe_insync(700)
-      end
-    end
-
-    describe "when syncing" do
-      it "should use the first found, specified group as the desired value and send it to the provider" do
-        expect(Puppet::Util).to receive(:gid).with("foo").and_return(nil)
-        expect(Puppet::Util).to receive(:gid).with("bar").and_return(500)
-
-        @provider = @provider_class.new(:name => 'foo')
-        resource = described_class.new(:name => 'foo', :provider => @provider, :gid => [ 'foo', 'bar' ])
-
-        expect(@provider).to receive(:gid=).with(500)
-        resource.parameter(:gid).sync
-      end
-    end
-  end
-
-  describe "when managing groups" do
-    it "should support a singe group" do
-      expect { described_class.new(:name => 'foo', :groups => 'bar') }.to_not raise_error
-    end
-
-    it "should support multiple groups as an array" do
-      expect { described_class.new(:name => 'foo', :groups => [ 'bar' ]) }.to_not raise_error
-      expect { described_class.new(:name => 'foo', :groups => [ 'bar', 'baz' ]) }.to_not raise_error
-    end
-
-    it "should not support a comma separated list" do
-      expect { described_class.new(:name => 'foo', :groups => 'bar,baz') }.to raise_error(Puppet::Error, /Group names must be provided as an array/)
-    end
-
-    it "should not support an empty string" do
-      expect { described_class.new(:name => 'foo', :groups => '') }.to raise_error(Puppet::Error, /Group names must not be empty/)
-    end
-
-    describe "when testing is in sync" do
-      before :each do
-        # the useradd provider uses a single string to represent groups and so does Puppet::Property::List when converting to should values
-        @provider = @provider_class.new(:name => 'foo', :groups => 'a,b,e,f')
-      end
-
-      it "should not care about order" do
-        @property = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ]).property(:groups)
-        expect(@property).to be_safe_insync([ 'a', 'b', 'c' ])
-        expect(@property).to be_safe_insync([ 'a', 'c', 'b' ])
-        expect(@property).to be_safe_insync([ 'b', 'a', 'c' ])
-        expect(@property).to be_safe_insync([ 'b', 'c', 'a' ])
-        expect(@property).to be_safe_insync([ 'c', 'a', 'b' ])
-        expect(@property).to be_safe_insync([ 'c', 'b', 'a' ])
-      end
-
-      it "should merge current value and desired value if membership minimal" do
-        @instance = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ], :provider => @provider)
-        @instance[:membership] = :minimum
-        expect(@instance[:groups]).to eq('a,b,c,e,f')
-      end
-
-      it "should not treat a subset of groups insync if membership inclusive" do
-        @instance = described_class.new(:name => 'foo', :groups => [ 'a', 'c', 'b' ], :provider => @provider)
-        @instance[:membership] = :inclusive
-        expect(@instance[:groups]).to eq('a,b,c')
-      end
-    end
-  end
-
-  describe "when managing the purge_ssh_keys property" do
-    context "with valid input" do
-      ['true', :true, true].each do |input|
-        it "should support #{input} as value" do
-          expect { described_class.new(:name => 'foo', :purge_ssh_keys => input) }.to_not raise_error
-        end
-      end
-
-      ['false', :false, false].each do |input|
-        it "should support #{input} as value" do
-          expect { described_class.new(:name => 'foo', :purge_ssh_keys => input) }.to_not raise_error
-        end
-      end
-
-      it "should support a String value" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => File.expand_path('home/foo/.ssh/authorized_keys')) }.to_not raise_error
-      end
-
-      it "should support an Array value" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => [File.expand_path('home/foo/.ssh/authorized_keys'),
-          File.expand_path('custom/authorized_keys')]) }.to_not raise_error
-      end
-    end
-
-    context "with faulty input" do
-      it "should raise error for relative path" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => 'home/foo/.ssh/authorized_keys') }.to raise_error(Puppet::ResourceError,
-          /Paths to keyfiles must be absolute/ )
-      end
-
-      it "should raise error for invalid type" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => :invalid) }.to raise_error(Puppet::ResourceError,
-          /purge_ssh_keys must be true, false, or an array of file names/ )
-      end
-
-      it "should raise error for array with relative path" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => ['home/foo/.ssh/authorized_keys',
-          File.expand_path('custom/authorized_keys')]) }.to raise_error(Puppet::ResourceError,
-          /Paths to keyfiles must be absolute/ )
-      end
-
-      it "should raise error for array with invalid type" do
-        expect { described_class.new(:name => 'foo', :purge_ssh_keys => [:invalid,
-          File.expand_path('custom/authorized_keys')]) }.to raise_error(Puppet::ResourceError,
-          /Each entry for purge_ssh_keys must be a string/ )
-      end
-    end
-
-    context "homedir retrieval" do
-      it "should accept the home provided" do
-        expect(Puppet).not_to receive(:debug).with("User 'foo' does not exist")
-        described_class.new(:name => 'foo', :purge_ssh_keys => true, :home => '/my_home')
-      end
-
-      it "should accept the home provided" do
-        expect(Dir).to receive(:home).with('foo').and_return('/my_home')
-        expect(Puppet).not_to receive(:debug).with("User 'foo' does not exist")
-        described_class.new(:name => 'foo', :purge_ssh_keys => true)
-      end
-
-      it "should output debug message when home directory cannot be retrieved" do
-        allow(Dir).to receive(:home).with('foo').and_raise(ArgumentError)
-        expect(Puppet).to receive(:debug).with("User 'foo' does not exist")
-        described_class.new(:name => 'foo', :purge_ssh_keys => true)
-      end
-    end
-  end
-
-  describe "when managing expiry" do
-    it "should fail if given an invalid date" do
-      expect { described_class.new(:name => 'foo', :expiry => "200-20-20") }.to raise_error(Puppet::Error, /Expiry dates must be YYYY-MM-DD/)
-    end
-  end
-
-  describe "when managing minimum password age" do
-    it "should accept a negative minimum age" do
-      expect { described_class.new(:name => 'foo', :password_min_age => '-1') }.to_not raise_error
-    end
-
-    it "should fail with an empty minimum age" do
-      expect { described_class.new(:name => 'foo', :password_min_age => '') }.to raise_error(Puppet::Error, /minimum age must be provided as a number/)
-    end
-  end
-
-  describe "when managing maximum password age" do
-    it "should accept a negative maximum age" do
-      expect { described_class.new(:name => 'foo', :password_max_age => '-1') }.to_not raise_error
-    end
-
-    it "should fail with an empty maximum age" do
-      expect { described_class.new(:name => 'foo', :password_max_age => '') }.to raise_error(Puppet::Error, /maximum age must be provided as a number/)
-    end
-  end
-
-  describe "when managing warning password days" do
-    it "should accept a negative warning days" do
-      expect { described_class.new(:name => 'foo', :password_warn_days => '-1') }.to_not raise_error
-    end
-
-    it "should fail with an empty warning days" do
-      expect { described_class.new(:name => 'foo', :password_warn_days => '') }.to raise_error(Puppet::Error, /warning days must be provided as a number/)
-    end
-  end
-
-  describe "when managing passwords" do
-    let(:transaction) { Puppet::Transaction.new(Puppet::Resource::Catalog.new, nil, nil) }
-    let(:harness) { Puppet::Transaction::ResourceHarness.new(transaction) }
-    let(:provider) { @provider_class.new(:name => 'foo', :ensure => :present) }
-    let(:resource) { described_class.new(:name => 'foo', :ensure => :present, :password => 'top secret', :provider => provider) }
-
-    it "should not include the password in the change log when adding the password" do
-      status = harness.evaluate(resource)
-      sync_event = status.events[0]
-      expect(sync_event.message).not_to include('top secret')
-      expect(sync_event.message).to eql('changed [redacted] to [redacted]')
-    end
-
-    it "should not include the password in the change log when changing the password" do
-      resource[:password] = 'super extra classified'
-      status = harness.evaluate(resource)
-      sync_event = status.events[0]
-      expect(sync_event.message).not_to include('super extra classified')
-      expect(sync_event.message).to eql('changed [redacted] to [redacted]')
-    end
-
-    it "should fail if a ':' is included in the password" do
-      expect { described_class.new(:name => 'foo', :password => "some:thing") }.to raise_error(Puppet::Error, /Passwords cannot include ':'/)
-    end
-
-    it "should allow the value to be set to :absent" do
-      expect { described_class.new(:name => 'foo', :password => :absent) }.to_not raise_error
-    end
-  end
-
-  describe "when managing comment" do
-    before :each do
-      @value = 'abcd™'
-      expect(@value.encoding).to eq(Encoding::UTF_8)
-      @user = described_class.new(:name => 'foo', :comment => @value)
-    end
-
-    describe "#insync" do
-      it "should delegate to the provider's #comments_insync? method if defined" do
-        # useradd subclasses nameservice and thus inherits #comments_insync?
-        user = described_class.new(:name => 'foo', :comment => @value, :provider => :useradd)
-        comment_property = user.properties.find {|p| p.name == :comment}
-        expect(user.provider).to receive(:comments_insync?)
-        comment_property.insync?('bar')
-      end
-
-      describe "#change_to_s" do
-        let(:is) { "\u2603" }
-        let(:should) { "\u06FF" }
-        let(:comment_property) { @user.properties.find { |p| p.name == :comment } }
-
-        context "given is and should strings with incompatible encoding" do
-          it "should return a formatted string" do
-            is.force_encoding(Encoding::ASCII_8BIT)
-            should.force_encoding(Encoding::UTF_8)
-            expect(Encoding.compatible?(is, should)).to be_falsey
-            expect(comment_property.change_to_s(is,should)).to match(/changed '\u{E2}\u{98}\u{83}' to '\u{DB}\u{BF}'/)
-          end
-        end
-
-        context "given is and should strings with compatible encoding" do
-          it "should return a formatted string" do
-            is.force_encoding(Encoding::UTF_8)
-            should.force_encoding(Encoding::UTF_8)
-            expect(Encoding.compatible?(is, should)).to be_truthy
-            expect(comment_property.change_to_s(is,should)).to match(/changed '\u{2603}' to '\u{6FF}'/u)
-          end
-        end
-      end
-    end
-  end
-
-  describe "when manages_solaris_rbac is enabled" do
-    it "should support a :role value for ensure" do
-      expect { described_class.new(:name => 'foo', :ensure => :role) }.to_not raise_error
-    end
-  end
-
-  describe "when user has roles" do
-    it "should autorequire roles on non-Windows", :unless => Puppet::Util::Platform.windows? do
-      testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
-      testrole = described_class.new(:name => "testrole")
-
-      Puppet::Resource::Catalog.new :testing do |conf|
-        [testuser, testrole].each { |resource| conf.add_resource resource }
-      end
-
-      rel = testuser.autorequire[0]
-      expect(rel.source.ref).to eq(testrole.ref)
-      expect(rel.target.ref).to eq(testuser.ref)
-    end
-
-    it "should not autorequire roles on Windows", :if => Puppet::Util::Platform.windows? do
-      testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
-      testrole = described_class.new(:name => "testrole")
-
-      Puppet::Resource::Catalog.new :testing do |conf|
-        [testuser, testrole].each { |resource| conf.add_resource resource }
-      end
-
-      expect(testuser.autorequire).to be_empty
-    end
-
-    it "should sync the user roles when changing the state of :ensure if :roles is being managed" do
-      user = Puppet::Type.type(:user).new(:name => "myUser", :ensure => :present)
-      user[:roles] = 'testRole'
-
-      allow(user.provider.class).to receive(:supports_parameter?).and_return(true)
-      expect(user.property(:roles)).to receive(:retrieve).and_return("other")
-      expect(user.property(:roles)).to receive(:insync?).and_return(false)
-      expect(user.property(:roles)).to receive(:sync)
-
-      allow(user.provider).to receive(:create)
-
-      user.property(:ensure).sync
-    end
-  end
-
-  describe "when setting shell" do
-    before :each do
-      @shell_provider_class = described_class.provide(:shell_manager) do
-        has_features :manages_shell
-        mk_resource_methods
-        def create; check_valid_shell;end
-        def shell=(value); check_valid_shell; end
-        def delete; end
-        def exists?; get(:ensure) != :absent; end
-        def flush; end
-        def self.instances; []; end
-        def check_valid_shell; end
-      end
-
-      allow(described_class).to receive(:defaultprovider).and_return(@shell_provider_class)
-    end
-
-    it "should call :check_valid_shell on the provider when changing shell value" do
-      @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :present)
-      expect(@provider).to receive(:check_valid_shell)
-      resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
-      allow(Puppet::Util::Storage).to receive(:load)
-      allow(Puppet::Util::Storage).to receive(:store)
-      catalog = Puppet::Resource::Catalog.new
-      catalog.add_resource resource
-      catalog.apply
-    end
-
-    it "should call :check_valid_shell on the provider when changing ensure from present to absent" do
-      @provider = @shell_provider_class.new(:name => 'foo', :shell => '/bin/bash', :ensure => :absent)
-      expect(@provider).to receive(:check_valid_shell)
-      resource = described_class.new(:name => 'foo', :shell => '/bin/zsh', :provider => @provider)
-      allow(Puppet::Util::Storage).to receive(:load)
-      allow(Puppet::Util::Storage).to receive(:store)
-      catalog = Puppet::Resource::Catalog.new
-      catalog.add_resource resource
-      catalog.apply
-    end
-  end
-end

data/spec/unit/type/whit_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-whit = Puppet::Type.type(:whit)
-
-describe whit do
-  it "should stringify in a way that users will regognise" do
-    expect(whit.new(:name => "Foo::Bar").to_s).to eq("Foo::Bar")
-  end
-end