puppet 7.27.0-x86-mingw32 → 8.0.1-x86-mingw32

data/lib/puppet/pops/loader/loader_paths.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 # LoaderPaths
 # ===
@@ -87,7 +88,7 @@ module LoaderPaths
 
     def typed_name(type, name_authority, relative_path, module_name)
       # Module name is assumed to be included in the path and therefore not added here
-      n = ''
+      n = String.new
       unless extension.empty?
         # Remove extension
         relative_path = relative_path[0..-(extension.length+1)]
@@ -117,7 +118,7 @@ module LoaderPaths
   end
 
   class RubySmartPath < SmartPath
-    EXTENSION = '.rb'.freeze
+    EXTENSION = '.rb'
 
     def extension
       EXTENSION
@@ -133,7 +134,7 @@ module LoaderPaths
   # path (which is a reference to its 'lib' directory.
   #
   class PuppetSmartPath < SmartPath
-    EXTENSION = '.pp'.freeze
+    EXTENSION = '.pp'
 
     def extension
       EXTENSION
@@ -152,7 +153,7 @@ module LoaderPaths
     end
 
     def typed_name(type, name_authority, relative_path, module_name)
-      n = ''
+      n = String.new
       n << module_name unless module_name.nil?
       unless extension.empty?
         # Remove extension
@@ -193,7 +194,7 @@ module LoaderPaths
   end
 
   class FunctionPathPP < PuppetSmartPath
-    FUNCTION_PATH_PP = 'functions'.freeze
+    FUNCTION_PATH_PP = 'functions'
 
     def relative_path
       FUNCTION_PATH_PP
@@ -218,7 +219,7 @@ module LoaderPaths
   end
 
   class TypePathPP < PuppetSmartPath
-    TYPE_PATH_PP = 'types'.freeze
+    TYPE_PATH_PP = 'types'
 
     def relative_path
       TYPE_PATH_PP
@@ -232,7 +233,7 @@ module LoaderPaths
   # TaskPath is like PuppetSmartPath but it does not use an extension and may
   # match more than one path with one name
   class TaskPath < PuppetSmartPath
-    TASKS_PATH = 'tasks'.freeze
+    TASKS_PATH = 'tasks'
     FORBIDDEN_EXTENSIONS = %w{.conf .md}.freeze
 
     def extension
@@ -248,7 +249,7 @@ module LoaderPaths
     end
 
     def typed_name(type, name_authority, relative_path, module_name)
-      n = ''
+      n = String.new
       n << module_name unless module_name.nil?
 
       # Remove the file extension, defined as everything after the *last* dot.
@@ -285,7 +286,7 @@ module LoaderPaths
   end
 
   class ResourceTypeImplPP < PuppetSmartPath
-    RESOURCE_TYPES_PATH_PP = '.resource_types'.freeze
+    RESOURCE_TYPES_PATH_PP = '.resource_types'
 
     def relative_path
       RESOURCE_TYPES_PATH_PP
@@ -312,8 +313,8 @@ module LoaderPaths
 
   class PlanPath < PuppetSmartPath
     PLAN_PATH = File.join('plans')
-    PP_EXT = '.pp'.freeze
-    YAML_EXT = '.yaml'.freeze
+    PP_EXT = '.pp'
+    YAML_EXT = '.yaml'
 
     def initialize(loader)
       super
@@ -350,7 +351,7 @@ module LoaderPaths
       if @init_filenames.include?(relative_path) && !(module_name.nil? || module_name.empty?)
         TypedName.new(type, module_name, name_authority)
       else
-        n = ''
+        n = String.new
         n << module_name unless module_name.nil?
         ext = @extensions.find { |extension| relative_path.end_with?(extension) }
         relative_path = relative_path[0..-(ext.length+1)]

data/lib/puppet/pops/loader/module_loaders.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # =ModuleLoaders
@@ -21,7 +22,7 @@ module Loader
 module ModuleLoaders
 
   # Wildcard module name for module loaders, makes loading possible from any namespace.
-  NAMESPACE_WILDCARD = '*'.freeze
+  NAMESPACE_WILDCARD = '*'
 
   # This is exactly the same as the #system_loader_from method, but the argument for path is changed to
   # location where pluginsync stores functions. It also accepts definitions in any namespace since pluginsync

data/lib/puppet/pops/loader/predefined_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Loader
 
 # A PredefinedLoader is a loader that is manually populated with loaded elements

data/lib/puppet/pops/loader/puppet_function_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetFunctionInstantiator instantiates a Puppet::Functions::PuppetFunction given a Puppet Programming language

data/lib/puppet/pops/loader/puppet_plan_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetPlanInstantiator instantiates a Puppet::Functions::PuppetFunction given a Puppet Programming language

data/lib/puppet/pops/loader/puppet_resource_type_impl_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # The PuppetResourceTypeImplInstantiator instantiates a Puppet::Pops::ResourceTypeImpl object.

data/lib/puppet/pops/loader/ruby_data_type_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The RubyTypeInstantiator instantiates a data type from the ruby source
 # that calls Puppet::DataTypes.create_type.
 #

data/lib/puppet/pops/loader/ruby_function_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The RubyFunctionInstantiator instantiates a Puppet::Functions::Function given the ruby source
 # that calls Puppet::Functions.create_function.
 #

data/lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 # The RubyLegacyFunctionInstantiator instantiates a Puppet::Functions::Function given the ruby source
 # that calls Puppet::Functions.create_function.
 #
 require 'ripper'
 class Puppet::Pops::Loader::RubyLegacyFunctionInstantiator
-  UNKNOWN = '<unknown>'.freeze
+  UNKNOWN = '<unknown>'
 
   # Produces an instance of the Function class with the given typed_name, or fails with an error if the
   # given ruby source does not produce this instance when evaluated.

data/lib/puppet/pops/loader/runtime3_type_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 

data/lib/puppet/pops/loader/simple_environment_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # SimpleEnvironmentLoader
 # ===
 # This loader does not load anything and it is populated by the bootstrapping logic that loads

data/lib/puppet/pops/loader/static_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
   # Static Loader contains constants, basic data types and other types required for the system
   # to boot.
   #

data/lib/puppet/pops/loader/task_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
 require_relative '../../../puppet/module/task'

data/lib/puppet/pops/loader/type_definition_instantiator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
 module Puppet::Pops

data/lib/puppet/pops/loader/typed_name.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Loader
 # A namespace/name/type combination that can be used as a compound hash key
@@ -26,7 +27,7 @@ class TypedName
     @name_parts = parts.freeze
 
     # Use a frozen compound key for the hash and comparison. Most varying part first
-    @compound_name = "#{@name}/#{@type}/#{@name_authority}".freeze
+    @compound_name = "#{@name}/#{@type}/#{@name_authority}"
     @hash = @compound_name.hash
     freeze
   end

data/lib/puppet/pops/loader/uri_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops::Loader::UriHelper
   # Raises an exception if specified gem can not be located
   #

data/lib/puppet/pops/loaders.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 # This is the container for all Loader instances. Each Loader instance has a `loader_name` by which it can be uniquely
 # identified within this container.

data/lib/puppet/pops/lookup/configured_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'hiera_config'
 require_relative 'data_provider'
 

data/lib/puppet/pops/lookup/context.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'interpolation'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/data_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 # A class that adapts a Hash

data/lib/puppet/pops/lookup/data_dig_function_provider.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require_relative 'function_provider'
 
 module Puppet::Pops
 module Lookup
 # @api private
 class DataDigFunctionProvider < FunctionProvider
-  TAG = 'data_dig'.freeze
+  TAG = 'data_dig'
 
   # Performs a lookup with the assumption that a recursive check has been made.
   #
@@ -63,7 +64,7 @@ end
 
 # @api private
 class V3BackendFunctionProvider < DataDigFunctionProvider
-  TAG = 'hiera3_backend'.freeze
+  TAG = 'hiera3_backend'
 
   def data_dig(key, lookup_invocation, location, merge)
     @backend ||= instantiate_backend(lookup_invocation)

data/lib/puppet/pops/lookup/data_hash_function_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'function_provider'
 require_relative 'interpolation'
 
@@ -8,7 +9,7 @@ class DataHashFunctionProvider < FunctionProvider
   include SubLookup
   include Interpolation
 
-  TAG = 'data_hash'.freeze
+  TAG = 'data_hash'
 
   def self.trusted_return_type
     @trusted_return_type ||= Types::PHashType.new(DataProvider.key_type, DataProvider.value_type)
@@ -80,7 +81,7 @@ end
 
 # @api private
 class V3DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v3_data_hash'.freeze
+  TAG = 'v3_data_hash'
 
   def initialize(name, parent_data_provider, function_name, options, locations)
     @datadir = options.delete(HieraConfig::KEY_DATADIR)
@@ -108,7 +109,7 @@ end
 # TODO: API 5.0, remove this class
 # @api private
 class V4DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v4_data_hash'.freeze
+  TAG = 'v4_data_hash'
 
   def name
     "Deprecated API function \"#{function_name}\""

data/lib/puppet/pops/lookup/data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 # @api private

data/lib/puppet/pops/lookup/environment_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'configured_data_provider'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/explainer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 
@@ -19,7 +20,7 @@ module Lookup
     end
 
     def explain
-      io = ''
+      io = String.new
       dump_on(io, '', '')
       io
     end
@@ -585,7 +586,7 @@ module Lookup
     end
 
     def emit_debug_info(preamble)
-      io = ''
+      io = String.new
       io << preamble << "\n"
       dump_on(io, '  ', '  ')
       Puppet.debug(io.chomp!)

data/lib/puppet/pops/lookup/function_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'data_adapter'
 require_relative 'context'
 require_relative 'data_provider'

data/lib/puppet/pops/lookup/global_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'hiera/scope'
 require_relative 'configured_data_provider'
 

data/lib/puppet/pops/lookup/hiera_config.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'data_dig_function_provider'
 require_relative 'data_hash_function_provider'
 require_relative 'lookup_key_function_provider'
@@ -41,22 +42,22 @@ class HieraConfig
 
   CONFIG_FILE_NAME = 'hiera.yaml'
 
-  KEY_NAME = 'name'.freeze
-  KEY_VERSION = 'version'.freeze
-  KEY_DATADIR = 'datadir'.freeze
-  KEY_DEFAULT_HIERARCHY = 'default_hierarchy'.freeze
-  KEY_HIERARCHY = 'hierarchy'.freeze
-  KEY_PLAN_HIERARCHY = 'plan_hierarchy'.freeze
-  KEY_LOGGER = 'logger'.freeze
-  KEY_OPTIONS = 'options'.freeze
-  KEY_PATH = 'path'.freeze
-  KEY_PATHS = 'paths'.freeze
-  KEY_MAPPED_PATHS = 'mapped_paths'.freeze
-  KEY_GLOB = 'glob'.freeze
-  KEY_GLOBS = 'globs'.freeze
-  KEY_URI = 'uri'.freeze
-  KEY_URIS = 'uris'.freeze
-  KEY_DEFAULTS = 'defaults'.freeze
+  KEY_NAME = 'name'
+  KEY_VERSION = 'version'
+  KEY_DATADIR = 'datadir'
+  KEY_DEFAULT_HIERARCHY = 'default_hierarchy'
+  KEY_HIERARCHY = 'hierarchy'
+  KEY_PLAN_HIERARCHY = 'plan_hierarchy'
+  KEY_LOGGER = 'logger'
+  KEY_OPTIONS = 'options'
+  KEY_PATH = 'path'
+  KEY_PATHS = 'paths'
+  KEY_MAPPED_PATHS = 'mapped_paths'
+  KEY_GLOB = 'glob'
+  KEY_GLOBS = 'globs'
+  KEY_URI = 'uri'
+  KEY_URIS = 'uris'
+  KEY_DEFAULTS = 'defaults'
   KEY_DATA_HASH = DataHashFunctionProvider::TAG
   KEY_LOOKUP_KEY = LookupKeyFunctionProvider::TAG
   KEY_DATA_DIG = DataDigFunctionProvider::TAG
@@ -64,8 +65,8 @@ class HieraConfig
   KEY_V3_LOOKUP_KEY = V3LookupKeyFunctionProvider::TAG
   KEY_V3_BACKEND = V3BackendFunctionProvider::TAG
   KEY_V4_DATA_HASH = V4DataHashFunctionProvider::TAG
-  KEY_BACKEND = 'backend'.freeze
-  KEY_EXTENSION = 'extension'.freeze
+  KEY_BACKEND = 'backend'
+  KEY_EXTENSION = 'extension'
 
   FUNCTION_KEYS = [KEY_DATA_HASH, KEY_LOOKUP_KEY, KEY_DATA_DIG, KEY_V3_BACKEND]
   ALL_FUNCTION_KEYS = FUNCTION_KEYS + [KEY_V4_DATA_HASH]
@@ -227,7 +228,7 @@ class HieraConfig
       line_number += 1
       next if line_number < start_line
       quote = nil
-      stripped = ''
+      stripped = String.new
       line.each_codepoint do |cp|
         if cp == 0x22 || cp == 0x27 # double or single quote
           if quote == cp
@@ -252,7 +253,7 @@ class HieraConfig
       scope = lookup_invocation.scope
       lookup_invocation.without_explain do
         @scope_interpolations.all? do |key, root_key, segments, old_value|
-          value = scope[root_key]
+          value = Puppet.override(avoid_hiera_interpolation_errors: true) { scope[root_key] }
           unless value.nil? || segments.empty?
             found = nil;
             catch(:no_such_key) { found = sub_lookup(key, lookup_invocation, segments, value) }
@@ -282,8 +283,9 @@ class HieraConfig
   end
 
   def create_hiera3_backend_provider(name, backend, parent_data_provider, datadir, paths, hiera3_config)
-    # Custom backend. Hiera v3 must be installed, it's logger configured, and it must be made aware of the loaded config
-    require 'hiera'
+    # Custom backend. Hiera 3 must be installed, its logger configured, and it must be made aware of the loaded config
+    raise Puppet::DataBinding::LookupError, 'Hiera 3 is not installed' if !Puppet.features.hiera?
+
     if Hiera::Config.instance_variable_defined?(:@config) && (current_config = Hiera::Config.instance_variable_get(:@config)).is_a?(Hash)
       current_config.each_pair do |key, val|
         case key
@@ -345,9 +347,9 @@ end
 
 # @api private
 class HieraConfigV3 < HieraConfig
-  KEY_BACKENDS = 'backends'.freeze
-  KEY_MERGE_BEHAVIOR = 'merge_behavior'.freeze
-  KEY_DEEP_MERGE_OPTIONS = 'deep_merge_options'.freeze
+  KEY_BACKENDS = 'backends'
+  KEY_MERGE_BEHAVIOR = 'merge_behavior'
+  KEY_DEEP_MERGE_OPTIONS = 'deep_merge_options'
 
   def self.config_type
     return @@CONFIG_TYPE if class_variable_defined?(:@@CONFIG_TYPE)
@@ -632,23 +634,26 @@ class HieraConfigV5 < HieraConfig
       entry_datadir = @config_root + (he[KEY_DATADIR] || datadir)
       entry_datadir = Pathname(interpolate(entry_datadir.to_s, lookup_invocation, false))
       location_key = LOCATION_KEYS.find { |key| he.include?(key) }
-      locations = case location_key
-      when KEY_PATHS
-        resolve_paths(entry_datadir, he[location_key], lookup_invocation, @config_path.nil?)
-      when KEY_PATH
-        resolve_paths(entry_datadir, [he[location_key]], lookup_invocation, @config_path.nil?)
-      when KEY_GLOBS
-        expand_globs(entry_datadir, he[location_key], lookup_invocation)
-      when KEY_GLOB
-        expand_globs(entry_datadir, [he[location_key]], lookup_invocation)
-      when KEY_URIS
-        expand_uris(he[location_key], lookup_invocation)
-      when KEY_URI
-        expand_uris([he[location_key]], lookup_invocation)
-      when KEY_MAPPED_PATHS
-        expand_mapped_paths(entry_datadir, he[location_key], lookup_invocation)
-      else
-        nil
+      locations = []
+      Puppet.override(avoid_hiera_interpolation_errors: true) do
+        locations = case location_key
+                    when KEY_PATHS
+                      resolve_paths(entry_datadir, he[location_key], lookup_invocation, @config_path.nil?)
+                    when KEY_PATH
+                      resolve_paths(entry_datadir, [he[location_key]], lookup_invocation, @config_path.nil?)
+                    when KEY_GLOBS
+                      expand_globs(entry_datadir, he[location_key], lookup_invocation)
+                    when KEY_GLOB
+                      expand_globs(entry_datadir, [he[location_key]], lookup_invocation)
+                    when KEY_URIS
+                      expand_uris(he[location_key], lookup_invocation)
+                    when KEY_URI
+                      expand_uris([he[location_key]], lookup_invocation)
+                    when KEY_MAPPED_PATHS
+                      expand_mapped_paths(entry_datadir, he[location_key], lookup_invocation)
+                    else
+                      nil
+                    end
       end
       next if @config_path.nil? && !locations.nil? && locations.empty? # Default config and no existing paths found
       options = he[KEY_OPTIONS] || defaults[KEY_OPTIONS]

data/lib/puppet/pops/lookup/interpolation.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'hiera/scope'
 require_relative 'sub_lookup'
 module Puppet::Pops
@@ -90,11 +91,16 @@ module Interpolation
             lookup_invocation.report_found_in_overrides(root_key, ovr[root_key])
           else
             scope = lookup_invocation.scope
-            val = scope[root_key]
+            val = nil
+            if (default_key_exists = lookup_invocation.default_values.include?(root_key) )
+              catch(:undefined_variable) { val = scope[root_key] }
+            else
+              val = scope[root_key]
+            end
             if val.nil? && !nil_in_scope?(scope, root_key)
-              defaults = lookup_invocation.default_values
-              if defaults.include?(root_key)
-                lookup_invocation.report_found_in_defaults(root_key, defaults[root_key])
+              if default_key_exists
+                lookup_invocation.report_found_in_defaults(root_key,
+                                                           lookup_invocation.default_values[root_key])
               else
                 nil
               end

data/lib/puppet/pops/lookup/invocation.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/thread_local'
 
 require_relative 'explainer'

data/lib/puppet/pops/lookup/key_recorder.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This class defines the private API of the Lookup Key Recorder support.
 # @api private
 #

data/lib/puppet/pops/lookup/location_resolver.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'pathname'
 require_relative 'interpolation'
 

data/lib/puppet/pops/lookup/lookup_adapter.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'data_adapter'
 require_relative 'lookup_key'
 
@@ -12,12 +13,12 @@ class LookupAdapter < DataAdapter
 
   LOOKUP_OPTIONS_PREFIX = LOOKUP_OPTIONS + '.'
   LOOKUP_OPTIONS_PREFIX.freeze
-  LOOKUP_OPTIONS_PATTERN_START = '^'.freeze
+  LOOKUP_OPTIONS_PATTERN_START = '^'
 
-  HASH = 'hash'.freeze
-  MERGE = 'merge'.freeze
-  CONVERT_TO = 'convert_to'.freeze
-  NEW = 'new'.freeze
+  HASH = 'hash'
+  MERGE = 'merge'
+  CONVERT_TO = 'convert_to'
+  NEW = 'new'
 
   def self.create_adapter(compiler)
     new(compiler)
@@ -334,7 +335,7 @@ class LookupAdapter < DataAdapter
     end
   end
 
-  GLOBAL_ENV_MERGE = 'Global and Environment'.freeze
+  GLOBAL_ENV_MERGE = 'Global and Environment'
 
   # Retrieve lookup options that applies when using a specific module (i.e. a merge of the pre-cached
   # `env_lookup_options` and the module specific data)

data/lib/puppet/pops/lookup/lookup_key.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'sub_lookup'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/lookup_key_function_provider.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require_relative 'function_provider'
 
 module Puppet::Pops
 module Lookup
 # @api private
 class LookupKeyFunctionProvider < FunctionProvider
-  TAG = 'lookup_key'.freeze
+  TAG = 'lookup_key'
 
   # Performs a lookup with the assumption that a recursive check has been made.
   #
@@ -64,7 +65,7 @@ end
 
 # @api private
 class V3LookupKeyFunctionProvider < LookupKeyFunctionProvider
-  TAG = 'v3_lookup_key'.freeze
+  TAG = 'v3_lookup_key'
 
   def initialize(name, parent_data_provider, function_name, options, locations)
     @datadir = options.delete(HieraConfig::KEY_DATADIR)

data/lib/puppet/pops/lookup/module_data_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative 'configured_data_provider'
 
 module Puppet::Pops

data/lib/puppet/pops/lookup/sub_lookup.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Lookup
 module SubLookup

data/lib/puppet/pops/lookup.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 # This class is the backing implementation of the Puppet function 'lookup'.
 # See puppet/functions/lookup.rb for documentation.
 #
 module Puppet::Pops
 module Lookup
-  LOOKUP_OPTIONS = 'lookup_options'.freeze
-  GLOBAL = '__global__'.freeze
+  LOOKUP_OPTIONS = 'lookup_options'
+  GLOBAL = '__global__'
 
   # Performs a lookup in the configured scopes and optionally merges the default.
   #

data/lib/puppet/pops/merge_strategy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'deep_merge/core'
 
 module Puppet::Pops

data/lib/puppet/pops/migration/migration_checker.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This class defines the private API of the MigrationChecker support.
 # @api private
 #

data/lib/puppet/pops/model/ast_transformer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/parser/ast'
 
 # The receiver of `import(file)` calls; once per imported file, or nil if imports are ignored

data/lib/puppet/pops/model/factory.rb

@@ -1112,7 +1112,7 @@ class Factory
   end
 
   def self.concat(*args)
-    result = ''.dup
+    result = String.new
     args.each do |e|
       if e.instance_of?(Factory) && e.model_class <= LiteralString
         result << e[KEY_VALUE]

data/lib/puppet/pops/model/model_label_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Pops
 module Model
 # A provider of labels for model object, producing a human name for the model object.