puppet 7.27.0-x64-mingw32 → 7.29.0-x64-mingw32

data/spec/unit/provider/group/windows_adsi_spec.rb

@@ -1,398 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:group).provider(:windows_adsi), :if => Puppet::Util::Platform.windows? do
-  let(:resource) do
-    Puppet::Type.type(:group).new(
-      :title => 'testers',
-      :provider => :windows_adsi
-    )
-  end
-
-  let(:provider) { resource.provider }
-  let(:connection) { double('connection') }
-
-  before :each do
-    allow(Puppet::Util::Windows::ADSI).to receive(:computer_name).and_return('testcomputername')
-    allow(Puppet::Util::Windows::ADSI).to receive(:connect).and_return(connection)
-    # this would normally query the system, but not needed for these tests
-    allow(Puppet::Util::Windows::ADSI::Group).to receive(:localized_domains).and_return([])
-  end
-
-  describe ".instances" do
-    it "should enumerate all groups" do
-      names = ['group1', 'group2', 'group3']
-      stub_groups = names.map{|n| double(:name => n)}
-
-      allow(connection).to receive(:execquery).with('select name from win32_group where localaccount = "TRUE"').and_return(stub_groups)
-
-      expect(described_class.instances.map(&:name)).to match(names)
-    end
-  end
-
-  describe "group type :members property helpers" do
-    let(:user1) { double(:account => 'user1', :domain => '.', :sid => 'user1sid') }
-    let(:user2) { double(:account => 'user2', :domain => '.', :sid => 'user2sid') }
-    let(:user3) { double(:account => 'user3', :domain => '.', :sid => 'user3sid') }
-    let(:user_without_domain) { double(:account => 'user_without_domain', :domain => nil, :sid => 'user_without_domain_sid') }
-
-    let(:invalid_user) { SecureRandom.uuid }
-    let(:invalid_user_principal) { double(:account => "#{invalid_user}", :domain => nil, :sid => "#{invalid_user}") }
-
-    before :each do
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user1', any_args).and_return(user1)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user2', any_args).and_return(user2)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user3', any_args).and_return(user3)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user_without_domain', any_args).and_return(user_without_domain)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(invalid_user).and_return(nil)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(invalid_user, true).and_return(invalid_user_principal)
-    end
-
-    describe "#members_insync?" do
-      it "should return true for same lists of members" do
-        current = [
-          'user1',
-          'user2',
-        ]
-        expect(provider.members_insync?(current, ['user1', 'user2'])).to be_truthy
-      end
-
-      it "should return true for same lists of unordered members" do
-        current = [
-          'user1',
-          'user2',
-        ]
-        expect(provider.members_insync?(current, ['user2', 'user1'])).to be_truthy
-      end
-
-      it "should return true for same lists of members irrespective of duplicates" do
-        current = [
-          'user1',
-          'user2',
-          'user2',
-        ]
-        expect(provider.members_insync?(current, ['user2', 'user1', 'user1'])).to be_truthy
-      end
-
-      it "should return true when current and should members are empty lists" do
-        expect(provider.members_insync?([], [])).to be_truthy
-      end
-
-      # invalid scenarios
-      #it "should return true when current and should members are nil lists" do
-      #it "should return true when current members is nil and should members is empty" do
-
-      it "should return true when current members is empty and should members is nil" do
-        expect(provider.members_insync?([], nil)).to be_truthy
-      end
-
-      context "when auth_membership => true" do
-        before :each do
-          resource[:auth_membership] = true
-        end
-
-        it "should return true when current and should contain the same users in a different order" do
-          current = [
-            'user1',
-            'user2',
-            'user3',
-          ]
-          expect(provider.members_insync?(current, ['user3', 'user1', 'user2'])).to be_truthy
-        end
-
-        it "should return false when current is nil" do
-          expect(provider.members_insync?(nil, ['user2'])).to be_falsey
-        end
-
-        it "should return false when should is nil" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, nil)).to be_falsey
-        end
-
-        it "should return false when current contains different users than should" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, ['user2'])).to be_falsey
-        end
-
-        it "should return false when current contains members and should is empty" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, [])).to be_falsey
-        end
-
-        it "should return false when current is empty and should contains members" do
-          expect(provider.members_insync?([], ['user2'])).to be_falsey
-        end
-
-        it "should return false when should user(s) are not the only items in the current" do
-          current = [
-            'user1',
-            'user2',
-          ]
-          expect(provider.members_insync?(current, ['user1'])).to be_falsey
-        end
-
-        it "should return false when current user(s) is not empty and should is an empty list" do
-          current = [
-            'user1',
-            'user2',
-          ]
-          expect(provider.members_insync?(current, [])).to be_falsey
-        end
-      end
-
-      context "when auth_membership => false" do
-        before :each do
-          # this is also the default
-          resource[:auth_membership] = false
-        end
-
-        it "should return false when current is nil" do
-          expect(provider.members_insync?(nil, ['user2'])).to be_falsey
-        end
-
-        it "should return true when should is nil" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, nil)).to be_truthy
-        end
-
-        it "should return false when current contains different users than should" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, ['user2'])).to be_falsey
-        end
-
-        it "should return true when current contains members and should is empty" do
-          current = [
-            'user1',
-          ]
-          expect(provider.members_insync?(current, [])).to be_truthy
-        end
-
-        it "should return false when current is empty and should contains members" do
-          expect(provider.members_insync?([], ['user2'])).to be_falsey
-        end
-
-        it "should return true when current user(s) contains at least the should list" do
-          current = [
-            'user1',
-            'user2',
-          ]
-          expect(provider.members_insync?(current, ['user1'])).to be_truthy
-        end
-
-        it "should return true when current user(s) is not empty and should is an empty list" do
-          current = [
-            'user1',
-            'user2',
-          ]
-          expect(provider.members_insync?(current, [])).to be_truthy
-        end
-
-        it "should return true when current user(s) contains at least the should list, even unordered" do
-          current = [
-            'user3',
-            'user1',
-            'user2',
-          ]
-          expect(provider.members_insync?(current, ['user2','user1'])).to be_truthy
-        end
-
-      it "should return true even if a current user is unresolvable if should is included" do
-        current = [
-            "#{invalid_user}",
-            'user2',
-          ]
-          expect(provider.members_insync?(current, ['user2'])).to be_truthy
-      end
-     end
-    end
-
-    describe "#members_to_s" do
-      it "should return an empty string on non-array input" do
-        [Object.new, {}, 1, :symbol, ''].each do |input|
-          expect(provider.members_to_s(input)).to be_empty
-        end
-      end
-
-      it "should return an empty string on empty or nil users" do
-        expect(provider.members_to_s([])).to be_empty
-        expect(provider.members_to_s(nil)).to be_empty
-      end
-
-      it "should return a user string like DOMAIN\\USER" do
-        expect(provider.members_to_s(['user1'])).to eq('.\user1')
-      end
-
-      it "should return a user string like DOMAIN\\USER,DOMAIN2\\USER2" do
-        expect(provider.members_to_s(['user1', 'user2'])).to eq('.\user1,.\user2')
-      end
-
-      it "should return a user string without domain if domain is not set" do
-        expect(provider.members_to_s(['user_without_domain'])).to eq('user_without_domain')
-      end
-
-      it "should return the username when it cannot be resolved to a SID (for the sake of resource_harness error messages)" do
-        expect(provider.members_to_s([invalid_user])).to eq("#{invalid_user}")
-      end
-    end
-  end
-
-  describe "when managing members" do
-    let(:user1) { double(:account => 'user1', :domain => '.', :sid => 'user1sid') }
-    let(:user2) { double(:account => 'user2', :domain => '.', :sid => 'user2sid') }
-    let(:user3) { double(:account => 'user3', :domain => '.', :sid => 'user3sid') }
-
-    let(:invalid_user) { SecureRandom.uuid }
-    let(:invalid_user_principal) { double(:account => "#{invalid_user}", :domain => nil, :sid => "#{invalid_user}") }
-
-    before :each do
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user1', any_args).and_return(user1)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user2', any_args).and_return(user2)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user3', any_args).and_return(user3)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(invalid_user, true).and_return(invalid_user_principal)
-
-      resource[:auth_membership] = true
-    end
-
-    it "should be able to provide a list of members" do
-      allow(provider.group).to receive(:members).and_return([
-        'user1',
-        'user2',
-        'user3',
-      ])
-
-      expected_member_sids = [user1.sid, user2.sid, user3.sid]
-      expected_members = ['user1', 'user2', 'user3']
-      allow(provider).to receive(:members_to_s)
-        .with(expected_member_sids)
-        .and_return(expected_members.join(','))
-
-      expect(provider.members).to match_array(expected_members)
-    end
-
-    it "should be able to handle unresolvable SID in list of members" do
-      allow(provider.group).to receive(:members).and_return([
-        'user1',
-        "#{invalid_user}",
-        'user3',
-      ])
-
-      expected_member_sids = [user1.sid, invalid_user_principal.sid, user3.sid]
-      expected_members = ['user1', "#{invalid_user}", 'user3']
-      allow(provider).to receive(:members_to_s)
-        .with(expected_member_sids)
-        .and_return(expected_members.join(','))
-
-      expect(provider.members).to match_array(expected_members)
-    end
-
-    it "should be able to set group members" do
-      allow(provider.group).to receive(:members).and_return(['user1', 'user2'])
-
-      member_sids = [
-        double(:account => 'user1', :domain => 'testcomputername', :sid => 1),
-        double(:account => 'user2', :domain => 'testcomputername', :sid => 2),
-        double(:account => 'user3', :domain => 'testcomputername', :sid => 3),
-      ]
-
-      allow(provider.group).to receive(:member_sids).and_return(member_sids[0..1])
-
-      expect(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user2', any_args).and_return(member_sids[1])
-      expect(Puppet::Util::Windows::SID).to receive(:name_to_principal).with('user3', any_args).and_return(member_sids[2])
-
-      expect(provider.group).to receive(:remove_member_sids).with(member_sids[0])
-      expect(provider.group).to receive(:add_member_sids).with(member_sids[2])
-
-      provider.members = ['user2', 'user3']
-    end
-  end
-
-  describe 'when creating groups' do
-    it "should be able to create a group" do
-      resource[:members] = ['user1', 'user2']
-
-      group = double('group')
-      expect(Puppet::Util::Windows::ADSI::Group).to receive(:create).with('testers').and_return(group)
-
-      expect(group).to receive(:commit).ordered
-      # due to PUP-1967, defaultto false will set the default to nil
-      expect(group).to receive(:set_members).with(['user1', 'user2'], nil).ordered
-
-      provider.create
-    end
-
-    it 'should not create a group if a user by the same name exists' do
-      expect(Puppet::Util::Windows::ADSI::Group).to receive(:create).with('testers').and_raise(Puppet::Error.new("Cannot create group if user 'testers' exists."))
-      expect{ provider.create }.to raise_error( Puppet::Error,
-        /Cannot create group if user 'testers' exists./ )
-    end
-
-    it "should fail with an actionable message when trying to create an active directory group" do
-      resource[:name] = 'DOMAIN\testdomaingroup'
-      expect(Puppet::Util::Windows::ADSI::User).to receive(:exists?).with(resource[:name]).and_return(false)
-      expect(connection).to receive(:Create)
-      expect(connection).to receive(:SetInfo).and_raise( WIN32OLERuntimeError.new("(in OLE method `SetInfo': )\n    OLE error code:8007089A in Active Directory\n      The specified username is invalid.\r\n\n    HRESULT error code:0x80020009\n      Exception occurred."))
-
-      expect{ provider.create }.to raise_error(Puppet::Error)
-    end
-
-    it 'should commit a newly created group' do
-      expect(provider.group).to receive( :commit )
-
-      provider.flush
-    end
-  end
-
-  it "should be able to test whether a group exists" do
-    allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).and_return(nil)
-    allow(Puppet::Util::Windows::ADSI).to receive(:connect).and_return(double('connection', :Class => 'Group'))
-    expect(provider).to be_exists
-
-    allow(Puppet::Util::Windows::ADSI).to receive(:connect).and_return(nil)
-    expect(provider).not_to be_exists
-  end
-
-  it "should be able to delete a group" do
-    expect(connection).to receive(:Delete).with('group', 'testers')
-
-    provider.delete
-  end
-
-  it 'should not run commit on a deleted group' do
-    expect(connection).to receive(:Delete).with('group', 'testers')
-    expect(connection).not_to receive(:SetInfo)
-
-    provider.delete
-    provider.flush
-  end
-
-  it "should report the group's SID as gid" do
-    expect(Puppet::Util::Windows::SID).to receive(:name_to_sid).with('testers').and_return('S-1-5-32-547')
-    expect(provider.gid).to eq('S-1-5-32-547')
-  end
-
-  it "should fail when trying to manage the gid property" do
-    expect(provider).to receive(:fail).with(/gid is read-only/)
-    provider.send(:gid=, 500)
-  end
-
-  it "should prefer the domain component from the resolved SID" do
-    # must lookup well known S-1-5-32-544 as actual 'Administrators' name may be localized
-    admins_sid_bytes = [1, 2, 0, 0, 0, 0, 0, 5, 32, 0, 0, 0, 32, 2, 0, 0]
-    admins_group = Puppet::Util::Windows::SID::Principal.lookup_account_sid(admins_sid_bytes)
-    # prefix just the name like .\Administrators
-    converted = provider.members_to_s([".\\#{admins_group.account}"])
-
-    # and ensure equivalent of BUILTIN\Administrators, without a leading .
-    expect(converted).to eq(admins_group.domain_account)
-    expect(converted[0]).to_not eq('.')
-  end
-end

data/spec/unit/provider/ldap_spec.rb

@@ -1,242 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/provider/ldap'
-
-describe Puppet::Provider::Ldap do
-  before do
-    @class = Class.new(Puppet::Provider::Ldap)
-  end
-
-  it "should be able to define its manager" do
-    manager = double('manager')
-    expect(Puppet::Util::Ldap::Manager).to receive(:new).and_return(manager)
-    allow(@class).to receive(:mk_resource_methods)
-    expect(manager).to receive(:manages).with(:one)
-    expect(@class.manages(:one)).to equal(manager)
-    expect(@class.manager).to equal(manager)
-  end
-
-  it "should be able to prefetch instances from ldap" do
-    expect(@class).to respond_to(:prefetch)
-  end
-
-  it "should create its resource getter/setter methods when the manager is defined" do
-    manager = double('manager')
-    expect(Puppet::Util::Ldap::Manager).to receive(:new).and_return(manager)
-    expect(@class).to receive(:mk_resource_methods)
-    allow(manager).to receive(:manages)
-    expect(@class.manages(:one)).to equal(manager)
-  end
-
-  it "should have an instances method" do
-    expect(@class).to respond_to(:instances)
-  end
-
-  describe "when providing a list of instances" do
-    it "should convert all results returned from the manager's :search method into provider instances" do
-      manager = double('manager')
-      allow(@class).to receive(:manager).and_return(manager)
-
-      expect(manager).to receive(:search).and_return(%w{one two three})
-
-      expect(@class).to receive(:new).with("one").and_return(1)
-      expect(@class).to receive(:new).with("two").and_return(2)
-      expect(@class).to receive(:new).with("three").and_return(3)
-
-      expect(@class.instances).to eq([1,2,3])
-    end
-  end
-
-  it "should have a prefetch method" do
-    expect(@class).to respond_to(:prefetch)
-  end
-
-  describe "when prefetching" do
-    before do
-      @manager = double('manager')
-      allow(@class).to receive(:manager).and_return(@manager)
-
-      @resource = double('resource')
-
-      @resources = {"one" => @resource}
-    end
-
-    it "should find an entry for each passed resource" do
-      expect(@manager).to receive(:find).with("one").and_return(nil)
-
-      allow(@class).to receive(:new)
-      allow(@resource).to receive(:provider=)
-      @class.prefetch(@resources)
-    end
-
-    describe "resources that do not exist" do
-      it "should create a provider with :ensure => :absent" do
-        expect(@manager).to receive(:find).with("one").and_return(nil)
-
-        expect(@class).to receive(:new).with({:ensure => :absent}).and_return("myprovider")
-
-        expect(@resource).to receive(:provider=).with("myprovider")
-
-        @class.prefetch(@resources)
-      end
-    end
-
-    describe "resources that exist" do
-      it "should create a provider with the results of the find" do
-        expect(@manager).to receive(:find).with("one").and_return("one" => "two")
-
-        expect(@class).to receive(:new).with({"one" => "two", :ensure => :present}).and_return("myprovider")
-
-        expect(@resource).to receive(:provider=).with("myprovider")
-
-        @class.prefetch(@resources)
-      end
-
-      it "should set :ensure to :present in the returned values" do
-        expect(@manager).to receive(:find).with("one").and_return("one" => "two")
-
-        expect(@class).to receive(:new).with({"one" => "two", :ensure => :present}).and_return("myprovider")
-
-        expect(@resource).to receive(:provider=).with("myprovider")
-
-        @class.prefetch(@resources)
-      end
-    end
-  end
-
-  describe "when being initialized" do
-    it "should fail if no manager has been defined" do
-      expect { @class.new }.to raise_error(Puppet::DevError)
-    end
-
-    it "should fail if the manager is invalid" do
-      manager = double("manager", :valid? => false)
-      allow(@class).to receive(:manager).and_return(manager)
-      expect { @class.new }.to raise_error(Puppet::DevError)
-    end
-
-    describe "with a hash" do
-      before do
-        @manager = double("manager", :valid? => true)
-        allow(@class).to receive(:manager).and_return(@manager)
-
-        @resource_class = double('resource_class')
-        allow(@class).to receive(:resource_type).and_return(@resource_class)
-
-        @property_class = double('property_class', :array_matching => :all, :superclass => Puppet::Property)
-        allow(@resource_class).to receive(:attrclass).with(:one).and_return(@property_class)
-        allow(@resource_class).to receive(:valid_parameter?).and_return(true)
-      end
-
-      it "should store a copy of the hash as its ldap_properties" do
-        instance = @class.new(:one => :two)
-        expect(instance.ldap_properties).to eq({:one => :two})
-      end
-
-      it "should only store the first value of each value array for those attributes that do not match all values" do
-        expect(@property_class).to receive(:array_matching).and_return(:first)
-        instance = @class.new(:one => %w{two three})
-        expect(instance.properties).to eq({:one => "two"})
-      end
-
-      it "should store the whole value array for those attributes that match all values" do
-        expect(@property_class).to receive(:array_matching).and_return(:all)
-        instance = @class.new(:one => %w{two three})
-        expect(instance.properties).to eq({:one => %w{two three}})
-      end
-
-      it "should only use the first value for attributes that are not properties" do
-        # Yay.  hackish, but easier than mocking everything.
-        expect(@resource_class).to receive(:attrclass).with(:a).and_return(Puppet::Type.type(:user).attrclass(:name))
-        allow(@property_class).to receive(:array_matching).and_return(:all)
-
-        instance = @class.new(:one => %w{two three}, :a => %w{b c})
-        expect(instance.properties).to eq({:one => %w{two three}, :a => "b"})
-      end
-
-      it "should discard any properties not valid in the resource class" do
-        expect(@resource_class).to receive(:valid_parameter?).with(:a).and_return(false)
-        allow(@property_class).to receive(:array_matching).and_return(:all)
-
-        instance = @class.new(:one => %w{two three}, :a => %w{b})
-        expect(instance.properties).to eq({:one => %w{two three}})
-      end
-    end
-  end
-
-  describe "when an instance" do
-    before do
-      @manager = double("manager", :valid? => true)
-      allow(@class).to receive(:manager).and_return(@manager)
-      @instance = @class.new
-
-      @property_class = double('property_class', :array_matching => :all, :superclass => Puppet::Property)
-      @resource_class = double('resource_class', :attrclass => @property_class, :valid_parameter? => true, :validproperties => [:one, :two])
-      allow(@class).to receive(:resource_type).and_return(@resource_class)
-    end
-
-    it "should have a method for creating the ldap entry" do
-      expect(@instance).to respond_to(:create)
-    end
-
-    it "should have a method for removing the ldap entry" do
-      expect(@instance).to respond_to(:delete)
-    end
-
-    it "should have a method for returning the class's manager" do
-      expect(@instance.manager).to equal(@manager)
-    end
-
-    it "should indicate when the ldap entry already exists" do
-      @instance = @class.new(:ensure => :present)
-      expect(@instance.exists?).to be_truthy
-    end
-
-    it "should indicate when the ldap entry does not exist" do
-      @instance = @class.new(:ensure => :absent)
-      expect(@instance.exists?).to be_falsey
-    end
-
-    describe "is being flushed" do
-      it "should call the manager's :update method with its name, current attributes, and desired attributes" do
-        allow(@instance).to receive(:name).and_return("myname")
-        allow(@instance).to receive(:ldap_properties).and_return(:one => :two)
-        allow(@instance).to receive(:properties).and_return(:three => :four)
-        expect(@manager).to receive(:update).with(@instance.name, {:one => :two}, {:three => :four})
-        @instance.flush
-      end
-    end
-
-    describe "is being created" do
-      before do
-        @rclass = double('resource_class')
-        allow(@rclass).to receive(:validproperties).and_return([:one, :two])
-        @resource = double('resource')
-        allow(@resource).to receive(:class).and_return(@rclass)
-        allow(@resource).to receive(:should).and_return(nil)
-        allow(@instance).to receive(:resource).and_return(@resource)
-      end
-
-      it "should set its :ensure value to :present" do
-        @instance.create
-        expect(@instance.properties[:ensure]).to eq(:present)
-      end
-
-      it "should set all of the other attributes from the resource" do
-        expect(@resource).to receive(:should).with(:one).and_return("oneval")
-        expect(@resource).to receive(:should).with(:two).and_return("twoval")
-
-        @instance.create
-        expect(@instance.properties[:one]).to eq("oneval")
-        expect(@instance.properties[:two]).to eq("twoval")
-      end
-    end
-
-    describe "is being deleted" do
-      it "should set its :ensure value to :absent" do
-        @instance.delete
-        expect(@instance.properties[:ensure]).to eq(:absent)
-      end
-    end
-  end
-end