puppet 7.24.0 → 8.1.0

data/lib/puppet/type/file/selcontext.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Manage SELinux context of files.
 #
 # This code actually manages three pieces of data in the context.

data/lib/puppet/type/file/source.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/content'
 require_relative '../../../puppet/file_serving/metadata'
 require_relative '../../../puppet/file_serving/terminus_helper'
@@ -72,7 +73,7 @@ module Puppet
           file { '/etc/nfs.conf':
             source => [
               "puppet:///modules/nfs/conf.${host}",
-              "puppet:///modules/nfs/conf.${operatingsystem}",
+              "puppet:///modules/nfs/conf.${os['name']}",
               'puppet:///modules/nfs/conf'
             ]
           }

data/lib/puppet/type/file/target.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:target) do
     desc "The target for creating a link.  Currently, symlinks are the

data/lib/puppet/type/file/type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:type) do
     require 'etc'

data/lib/puppet/type/file.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 require 'digest/md5'
 require 'cgi'
 require 'etc'

data/lib/puppet/type/filebucket.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   require_relative '../../puppet/file_bucket/dipper'
 

data/lib/puppet/type/group.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'etc'
 require_relative '../../puppet/property/keyvalue'
 require_relative '../../puppet/parameter/boolean'

data/lib/puppet/type/notify.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Simple module for logging messages on the client-side
 

data/lib/puppet/type/package.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 # Define the different packaging systems.  Each package system is implemented
 # in a module, which then gets used to individually extend each package object.
 # This allows packages to exist on the same machine using different packaging
@@ -242,7 +243,7 @@ module Puppet
       conditionally:
 
           # In the 'openssl' class
-          $ssl = $operatingsystem ? {
+          $ssl = $os['name'] ? {
             solaris => SMCossl,
             default => openssl
           }
@@ -254,7 +255,7 @@ module Puppet
 
           ...
 
-          $ssh = $operatingsystem ? {
+          $ssh = $os['name'] ? {
             solaris => SMCossh,
             default => openssh
           }

data/lib/puppet/type/resources.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/parameter/boolean'
 
@@ -170,7 +171,7 @@ Puppet::Type.newtype(:resources) do
     end
 
     # Otherwise, use a sensible default based on the OS family
-    @system_users_max_uid ||= case Puppet.runtime[:facter].value(:osfamily)
+    @system_users_max_uid ||= case Puppet.runtime[:facter].value('os.family')
       when 'OpenBSD', 'FreeBSD'
         999
       else

data/lib/puppet/type/schedule.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Type.newtype(:schedule) do
     @doc = <<-'EOT'

data/lib/puppet/type/service.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This is our main way of managing processes right now.
 #
 # a service is distinct from a process in that services

data/lib/puppet/type/stage.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.newtype(:stage) do
   desc "A resource type for creating new run stages.  Once a stage is available,
     classes can be assigned to it by declaring them with the resource-like syntax

data/lib/puppet/type/tidy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/parameter/boolean'
 
 Puppet::Type.newtype(:tidy) do

data/lib/puppet/type/user.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'etc'
 require_relative '../../puppet/parameter/boolean'
 require_relative '../../puppet/property/list'

data/lib/puppet/type/whit.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.newtype(:whit) do
   desc "Whits are internal artifacts of Puppet's current implementation, and
     Puppet suppresses their appearance in all logs. We make no guarantee of

data/lib/puppet/type.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require_relative '../puppet'
 require_relative '../puppet/util/log'
 require_relative '../puppet/util/metric'
@@ -1032,47 +1033,6 @@ class Type
     self.provider.flush if self.provider and self.provider.respond_to?(:flush)
   end
 
-  # Returns true if all contained objects are in sync.
-  # @todo "contained in what?" in the given "in" parameter?
-  #
-  # @todo deal with the comment _"FIXME I don't think this is used on the type instances any more,
-  #   it's really only used for testing"_
-  # @return [Boolean] true if in sync, false otherwise.
-  #
-  def insync?(is)
-    insync = true
-
-    property = @parameters[:ensure]
-    if property
-      unless is.include? property
-        #TRANSLATORS 'is' is a variable name and should not be translated
-        raise Puppet::DevError, _("The 'is' value is not in the 'is' array for '%{name}'") % { name: property.name }
-      end
-      ensureis = is[property]
-      if property.safe_insync?(ensureis) and property.should == :absent
-        return true
-      end
-    end
-
-    properties.each { |prop|
-      unless is.include? prop
-        #TRANSLATORS 'is' is a variable name and should not be translated
-        raise Puppet::DevError, _("The 'is' value is not in the 'is' array for '%{name}'") % { name: prop.name }
-      end
-
-      propis = is[prop]
-      unless prop.safe_insync?(propis)
-        prop.debug("Not in sync: #{propis.inspect} vs #{prop.should.inspect}")
-        insync = false
-      #else
-      #    property.debug("In sync")
-      end
-    }
-
-    #self.debug("#{self} sync status is #{insync}")
-    insync
-  end
-
   # Says if the ensure property should be retrieved if the resource is ensurable
   # Defaults to true. Some resource type classes can override it
   def self.needs_ensure_retrieved
@@ -1415,7 +1375,7 @@ class Type
       provide a symbolic title and an explicit namevar value:
 
           file { 'sshdconfig':
-            path => $operatingsystem ? {
+            path => $os['name'] ? {
               solaris => '/usr/local/etc/ssh/sshd_config',
               default => '/etc/ssh/sshd_config',
             },

data/lib/puppet/util/at_fork/noop.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A noop implementation of the Puppet::Util::AtFork handler
 class Puppet::Util::AtFork::Noop
   class << self

data/lib/puppet/util/at_fork/solaris.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet'
 require 'fiddle'
 

data/lib/puppet/util/at_fork.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 
 # A module for building AtFork handlers. These handlers are objects providing

data/lib/puppet/util/autoload.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'pathname'
 require_relative '../../puppet/util/rubygems'
 require_relative '../../puppet/util/warnings'

data/lib/puppet/util/backups.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'find'
 require 'fileutils'
 module Puppet::Util::Backups

data/lib/puppet/util/character_encoding.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A module to centralize heuristics/practices for managing character encoding in Puppet
 
 module Puppet::Util::CharacterEncoding

data/lib/puppet/util/checksums.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'digest/md5'
 require 'digest/sha1'
 require 'time'

data/lib/puppet/util/classgen.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   class ConstantAlreadyDefined < Error; end
   class SubclassAlreadyDefined < Error; end

data/lib/puppet/util/colors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/platform'
 
 module Puppet::Util::Colors

data/lib/puppet/util/command_line/puppet_option_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/command_line/trollop'
 
 module Puppet

data/lib/puppet/util/command_line/trollop.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 ## lib/trollop.rb -- trollop command-line processing library
 ## Author::    William Morgan (mailto: wmorgan-trollop@masanjin.net)
 ## Copyright:: Copyright 2007 William Morgan

data/lib/puppet/util/command_line.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Bundler and rubygems maintain a set of directories from which to
 # load gems. If Bundler is loaded, let it determine what can be
 # loaded. If it's not loaded, then use rubygems. But do this before

data/lib/puppet/util/constant_inflector.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Created on 2008-02-12
 # Copyright Luke Kanies
 

data/lib/puppet/util/diff.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'tempfile'
 
 # Provide a diff between two strings.
@@ -33,7 +34,7 @@ module Puppet::Util::Diff
     data_old = data_old.split(/\n/).map! { |e| e.chomp }
     data_new = data_new.split(/\n/).map! { |e| e.chomp }
 
-    output = ""
+    output = String.new
 
     diffs = ::Diff::LCS.diff(data_old, data_new)
     return output if diffs.empty?

data/lib/puppet/util/docs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Some simple methods for helping manage automatic documentation generation.
 module Puppet::Util::Docs
   # Specify the actual doc string.

data/lib/puppet/util/errors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Some helper methods for throwing and populating errors.
 #
 # @api public

data/lib/puppet/util/execution.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'timeout'
 require_relative '../../puppet/file_system/uniquefile'
 
@@ -161,7 +162,7 @@ module Puppet::Util::Execution
     # do this after processing 'command' array or string
     command_str = '[redacted]' if options[:sensitive]
 
-    user_log_s = ''
+    user_log_s = String.new
     if options[:uid]
       user_log_s << " uid=#{options[:uid]}"
     end
@@ -201,7 +202,7 @@ module Puppet::Util::Execution
       stderr = options[:combine] ? stdout : Puppet::FileSystem.open(null_file, nil, 'w')
 
       exec_args = [command, options, stdin, stdout, stderr]
-      output = ''
+      output = String.new
 
       # We close stdin/stdout/stderr immediately after fork/exec as they're no longer needed by
       # this process. In most cases they could be closed later, but when `stdout` is the "writer"
@@ -379,7 +380,7 @@ module Puppet::Util::Execution
     end.join(" ") if command.is_a?(Array)
 
     options[:custom_environment] ||= {}
-    Puppet::Util.withenv(options[:custom_environment], :windows) do
+    Puppet::Util.withenv(options[:custom_environment]) do
       Puppet::Util::Windows::Process.execute(command, options, stdin, stdout, stderr)
     end
   end

data/lib/puppet/util/execution_stub.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util
   class ExecutionStub
     class << self

data/lib/puppet/util/feature.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/util/warnings'
 

data/lib/puppet/util/file_watcher.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::Util::FileWatcher
   include Enumerable
 

data/lib/puppet/util/fileparsing.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A mini-language for parsing files.  This is only used file the ParsedFile
 # provider, but it makes more sense to split it out so it's easy to maintain
 # in one place.

data/lib/puppet/util/filetype.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Basic classes for reading, writing, and emptying files.  Not much
 # to see here.
 
@@ -215,7 +216,7 @@ class Puppet::Util::FileType
     # Remove a specific @path's cron tab.
     def remove
       cmd = "#{cmdbase} -r"
-      if %w{Darwin FreeBSD DragonFly}.include?(Puppet.runtime[:facter].value("operatingsystem"))
+      if %w{Darwin FreeBSD DragonFly}.include?(Puppet.runtime[:facter].value('os.name'))
         cmd = "/bin/echo yes | #{cmd}"
       end
 
@@ -244,7 +245,7 @@ class Puppet::Util::FileType
     # Only add the -u flag when the @path is different.  Fedora apparently
     # does not think I should be allowed to set the @path to my own user name
     def cmdbase
-      if @uid == Puppet::Util::SUIDManager.uid || Puppet.runtime[:facter].value(:operatingsystem) == "HP-UX"
+      if @uid == Puppet::Util::SUIDManager.uid || Puppet.runtime[:facter].value('os.name') == "HP-UX"
         return "crontab"
       else
         return "crontab -u #{@path}"

data/lib/puppet/util/http_proxy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/http'
 
 # for backwards compatibility

data/lib/puppet/util/inifile.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Module Puppet::IniConfig
 # A generic way to parse .ini style files and manipulate them in memory
 # One 'file' can be made up of several physical files. Changes to sections
@@ -78,7 +79,7 @@ module Puppet::Util::IniConfig
     # written to file
     def format
       if @destroy
-        text = ""
+        text = String.new
       else
         text = "[#{name}]\n"
         @entries.each do |entry|
@@ -207,7 +208,7 @@ module Puppet::Util::IniConfig
     end
 
     def format
-      text = ""
+      text = String.new
 
       @contents.each do |content|
         if content.is_a? Section

data/lib/puppet/util/instance_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/autoload'
 require_relative '../../puppet/util'
 require_relative '../../puppet/concurrent/lock'

data/lib/puppet/util/json.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util
   module Json
     class ParseError < StandardError

data/lib/puppet/util/json_lockfile.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/lockfile'
 
 # This class provides a simple API for managing a lock file

data/lib/puppet/util/ldap/connection.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/ldap'
 
 class Puppet::Util::Ldap::Connection

data/lib/puppet/util/ldap/generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/ldap'
 
 class Puppet::Util::Ldap::Generator

data/lib/puppet/util/ldap/manager.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/ldap'
 require_relative '../../../puppet/util/ldap/connection'
 require_relative '../../../puppet/util/ldap/generator'

data/lib/puppet/util/ldap.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module Puppet::Util::Ldap
 end

data/lib/puppet/util/libuser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Libuser
    def self.getconf
      File.expand_path("../libuser.conf", __FILE__)

data/lib/puppet/util/limits.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util'
 
 module Puppet::Util::Limits

data/lib/puppet/util/lockfile.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This class provides a simple API for managing a lock file
 # whose contents are an (optional) String.  In addition
 # to querying the basic state (#locked?) of the lock, managing

data/lib/puppet/util/log/destination.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A type of log destination.
 class Puppet::Util::Log::Destination
   class << self

data/lib/puppet/util/log/destinations.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Util::Log.newdesttype :syslog do
   def self.suitable?(obj)
     Puppet.features.syslog?

data/lib/puppet/util/log.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/tagging'
 require_relative '../../puppet/util/classgen'
 require_relative '../../puppet/util/psych_support'

data/lib/puppet/util/logging.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A module to make logging a bit easier.
 require_relative '../../puppet/util/log'
 require_relative '../../puppet/error'

data/lib/puppet/util/metaid.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Object
   # The hidden singleton lurks behind everyone
   def singleton_class; class << self; self; end; end

data/lib/puppet/util/metric.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # included so we can test object types
 require_relative '../../puppet'
 require_relative '../../puppet/network/format_support'

data/lib/puppet/util/monkey_patches.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/platform'
 
 module Puppet::Util::MonkeyPatches
@@ -29,39 +30,13 @@ class Object
   end
 end
 
-if RUBY_VERSION.to_f < 3.0
-  # absolute/relative were optimized to avoid chop_basename in ruby 3
-  # see https://github.com/ruby/ruby/commit/39312cf4d6c2ab3f07d688ad1a467c8f84b58db0
-  require 'pathname'
-  class Pathname
-    if File.dirname('A:') == 'A:.' # DOSish drive letter
-      ABSOLUTE_PATH = /\A(?:[A-Za-z]:|#{SEPARATOR_PAT})/o
-    else
-      ABSOLUTE_PATH = /\A#{SEPARATOR_PAT}/o
-    end
-    private_constant :ABSOLUTE_PATH
-
-    def absolute?
-      ABSOLUTE_PATH.match? @path
-    end
-
-    def relative?
-      !absolute?
-    end
-  end
-end
-
-# (#19151) Reject all SSLv2 ciphers and handshakes
 require_relative '../../puppet/ssl/openssl_loader'
 unless Puppet::Util::Platform.jruby_fips?
   class OpenSSL::SSL::SSLContext
     if DEFAULT_PARAMS[:options]
-      DEFAULT_PARAMS[:options] |= OpenSSL::SSL::OP_NO_SSLv2 | OpenSSL::SSL::OP_NO_SSLv3
+      DEFAULT_PARAMS[:options] |= OpenSSL::SSL::OP_NO_SSLv3
     else
-      DEFAULT_PARAMS[:options] = OpenSSL::SSL::OP_NO_SSLv2 | OpenSSL::SSL::OP_NO_SSLv3
-    end
-    if DEFAULT_PARAMS[:ciphers]
-      DEFAULT_PARAMS[:ciphers] << ':!SSLv2'
+      DEFAULT_PARAMS[:options] = OpenSSL::SSL::OP_NO_SSLv3
     end
 
     alias __original_initialize initialize

data/lib/puppet/util/multi_match.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # MultiMatch allows multiple values to be tested at once in a case expression.
 # This class is needed since Array does not implement the === operator to mean
 # "each v === other.each v". 

data/lib/puppet/util/network_device/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/autoload'
 require 'uri'
 require_relative '../../../puppet/util/network_device/transport'

data/lib/puppet/util/network_device/config.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'ostruct'
 require_relative '../../../puppet/util/watched_file'
 require_relative '../../../puppet/util/network_device'

data/lib/puppet/util/network_device/transport/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 require_relative '../../../../puppet/util/network_device'
 require_relative '../../../../puppet/util/network_device/transport'

data/lib/puppet/util/network_device/transport.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/network_device'
 
 # stub

data/lib/puppet/util/network_device.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::Util::NetworkDevice
   class << self
     attr_reader :current

data/lib/puppet/util/package/version/debian.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Package::Version
   class Debian < Numeric
     include Comparable

data/lib/puppet/util/package/version/gem.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Package::Version
   class Gem < ::Gem::Version
     def self.parse(version)

data/lib/puppet/util/package/version/pip.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::Util::Package::Version
   class Pip
     include Comparable
@@ -31,7 +32,7 @@ module Puppet::Util::Package::Version
         )?
       )
       (?:\\+(?<local>[a-z0-9]+(?:[-_\\.][a-z0-9]+)*))?      # local version
-    ".freeze
+    "
 
     def self.parse(version)
       raise ValidationFailure, version.to_s unless version.is_a? String

data/lib/puppet/util/package/version/range/eq.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../../../puppet/util/package/version/range/simple'
 
 module Puppet::Util::Package::Version

data/lib/puppet/util/package/version/range/gt.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../../../puppet/util/package/version/range/simple'
 
 module Puppet::Util::Package::Version