puppet 7.24.0-universal-darwin → 8.0.1-universal-darwin

data/lib/puppet/settings.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../puppet'
 require 'getoptlong'
 require_relative '../puppet/util/watched_file'
@@ -49,7 +50,7 @@ class Puppet::Settings
   # The acceptable sections of the puppet.conf configuration file.
   ALLOWED_SECTION_NAMES = ['main', 'server', 'master', 'agent', 'user'].freeze
 
-  NONE = 'none'.freeze
+  NONE = 'none'
 
   # This method is intended for puppet internal use only; it is a convenience method that
   # returns reasonable application default settings values for a given run_mode.
@@ -78,11 +79,11 @@ class Puppet::Settings
   end
 
   def self.hostname_fact()
-    Puppet.runtime[:facter].value :hostname
+    Puppet.runtime[:facter].value 'networking.hostname'
   end
 
   def self.domain_fact()
-    Puppet.runtime[:facter].value :domain
+    Puppet.runtime[:facter].value 'networking.domain'
   end
 
   def self.default_config_file_name
@@ -1400,7 +1401,7 @@ Generated on #{Time.now}.
   #
   # @api public
   class ChainedValues
-    ENVIRONMENT_SETTING = "environment".freeze
+    ENVIRONMENT_SETTING = "environment"
     ENVIRONMENT_INTERPOLATION_ALLOWED = ['config_version'].freeze
 
     # @see Puppet::Settings.values

data/lib/puppet/ssl/base.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl/openssl_loader'
 require_relative '../../puppet/ssl'
 require_relative '../../puppet/ssl/digest'

data/lib/puppet/ssl/certificate.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl/base'
 
 # Manage certificates themselves.  This class has no

data/lib/puppet/ssl/certificate_request.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl/base'
 require_relative '../../puppet/ssl/certificate_signer'
 
@@ -68,10 +69,7 @@ class Puppet::SSL::CertificateRequest < Puppet::SSL::Base
     csr.public_key = if key.is_a?(OpenSSL::PKey::EC)
                        # EC#public_key doesn't follow the PKey API,
                        # see https://github.com/ruby/openssl/issues/29
-                       point = key.public_key
-                       pubkey = OpenSSL::PKey::EC.new(point.group)
-                       pubkey.public_key = point
-                       pubkey
+                       key
                      else
                        key.public_key
                      end

data/lib/puppet/ssl/certificate_request_attributes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 require_relative '../../puppet/util/yaml'
 

data/lib/puppet/ssl/certificate_signer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Take care of signing a certificate in a FIPS 140-2 compliant manner.
 #
 # @see https://projects.puppetlabs.com/issues/17295

data/lib/puppet/ssl/digest.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Puppet::SSL::Digest
   attr_reader :digest
 

data/lib/puppet/ssl/error.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet::SSL
   class SSLError < Puppet::Error; end
 

data/lib/puppet/ssl/oids.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 
 # This module defines OIDs for use within Puppet.

data/lib/puppet/ssl/openssl_loader.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/platform'
 
 # This file should be required instead of writing `require 'openssl'`

data/lib/puppet/ssl/ssl_context.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 
 module Puppet::SSL

data/lib/puppet/ssl/ssl_provider.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 
 # SSL Provider creates `SSLContext` objects that can be used to create
@@ -235,7 +236,7 @@ class Puppet::SSL::SSLProvider
   def default_flags
     # checking the signature of the self-signed cert doesn't add any security,
     # but it's a sanity check to make sure the cert isn't corrupt. This option
-    # is only available in openssl 1.1+
+    # is not available in JRuby's OpenSSL library.
     if defined?(OpenSSL::X509::V_FLAG_CHECK_SS_SIGNATURE)
       OpenSSL::X509::V_FLAG_CHECK_SS_SIGNATURE
     else

data/lib/puppet/ssl/state_machine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 require_relative '../../puppet/util/pidlock'
 

data/lib/puppet/ssl/verifier.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/ssl'
 
 # Verify an SSL connection.

data/lib/puppet/ssl.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Just to make the constants work out.
 require_relative '../puppet'
 require_relative 'ssl/openssl_loader'
@@ -9,7 +10,7 @@ require_relative 'ssl/openssl_loader'
 # @see Puppet::SSL::SSLProvider
 # @api private
 module Puppet::SSL
-  CA_NAME = "ca".freeze
+  CA_NAME = "ca"
 
   require_relative 'ssl/oids'
   require_relative 'ssl/error'

data/lib/puppet/syntax_checkers/base64.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A syntax checker for Base64.
 # @api public
 require_relative '../../puppet/syntax_checkers'

data/lib/puppet/syntax_checkers/epp.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A syntax checker for JSON.
 # @api public
 require_relative '../../puppet/syntax_checkers'

data/lib/puppet/syntax_checkers/json.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A syntax checker for JSON.
 # @api public
 require_relative '../../puppet/syntax_checkers'

data/lib/puppet/syntax_checkers/pp.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A syntax checker for JSON.
 # @api public
 require_relative '../../puppet/syntax_checkers'

data/lib/puppet/syntax_checkers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A name space for syntax checkers provided by Puppet.
 module Puppet::SyntaxCheckers
 end

data/lib/puppet/test/test_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'tmpdir'
 require 'fileutils'
 
@@ -69,13 +70,7 @@ module Puppet::Test
     # @return nil
     def self.before_all_tests()
       # The process environment is a shared, persistent resource.
-      # Can't use Puppet.features.microsoft_windows? as it may be mocked out in a test.  This can cause test recurring test failures
-      if (!!File::ALT_SEPARATOR)
-        mode = :windows
-      else
-        mode = :posix
-      end
-      $old_env = Puppet::Util.get_environment(mode)
+      $old_env = ENV.to_hash
     end
 
     # Call this method once, at the end of a test run, when no more tests
@@ -188,20 +183,8 @@ module Puppet::Test
       end
       $saved_indirection_state = nil
 
-      # Can't use Puppet.features.microsoft_windows? as it may be mocked out in a test.  This can cause test recurring test failures
-      if (!!File::ALT_SEPARATOR)
-        mode = :windows
-      else
-        mode = :posix
-      end
-      # Restore the global process environment.  Can't just assign because this
-      # is a magic variable, sadly, and doesn't do that™.  It is sufficiently
-      # faster to use the compare-then-set model to avoid excessive work that it
-      # justifies the complexity.  --daniel 2012-03-15
-      unless Puppet::Util.get_environment(mode) == $old_env
-        Puppet::Util.clear_environment(mode)
-        $old_env.each {|k, v| Puppet::Util.set_env(k, v, mode) }
-      end
+      # Restore the global process environment.
+      ENV.replace($old_env)
 
       # Clear all environments
       Puppet.lookup(:environments).clear_all

data/lib/puppet/thread_local.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'concurrent'
 
 # We want to use the pure Ruby implementation even on JRuby. If we use the Java

data/lib/puppet/transaction/additional_resource_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Adds additional resources to the catalog and relationship graph that are
 # generated by existing resources. There are two ways that a resource can
 # generate additional resources, either through the #generate method or the

data/lib/puppet/transaction/event.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/transaction'
 require_relative '../../puppet/util/tagging'
 require_relative '../../puppet/util/logging'

data/lib/puppet/transaction/event_manager.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/transaction'
 
 # This class stores, routes, and responds to events generated while evaluating

data/lib/puppet/transaction/persistence.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'yaml'
 require_relative '../../puppet/util/yaml'
 

data/lib/puppet/transaction/report.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/indirector'
 
@@ -139,7 +140,7 @@ class Puppet::Transaction::Report
   #
   attr_accessor :transaction_completed
 
-  TOTAL = "total".freeze
+  TOTAL = "total"
 
   def self.from_data_hash(data)
     obj = self.allocate
@@ -368,7 +369,7 @@ class Puppet::Transaction::Report
   def summary
     report = raw_summary
 
-    ret = ""
+    ret = String.new
     report.keys.sort_by(&:to_s).each do |key|
       ret += "#{Puppet::Util::Metric.labelize(key)}:\n"
 

data/lib/puppet/transaction/resource_harness.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/resource/status'
 
 class Puppet::Transaction::ResourceHarness

data/lib/puppet/transaction.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../puppet'
 require_relative '../puppet/util/tagging'
 require_relative '../puppet/util/skip_tags'

data/lib/puppet/trusted_external.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A method for retrieving external trusted facts
 module Puppet::TrustedExternal
   def retrieve(certname)

data/lib/puppet/type/component.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 require_relative '../../puppet'
 require_relative '../../puppet/type'

data/lib/puppet/type/exec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Type.newtype(:exec) do
     include Puppet::Util::Execution

data/lib/puppet/type/file/checksum.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/checksums'
 
 # Specify which checksum algorithm to use when checksumming

data/lib/puppet/type/file/checksum_value.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/checksums'
 require_relative '../../../puppet/type/file/data_sync'
 

data/lib/puppet/type/file/content.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'net/http'
 require 'uri'
 require 'tempfile'

data/lib/puppet/type/file/ctime.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:ctime) do
     desc %q{A read-only state to check the file ctime. On most modern \*nix-like

data/lib/puppet/type/file/data_sync.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/checksums'
 require_relative '../../../puppet/util/diff'
 require 'date'

data/lib/puppet/type/file/ensure.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 module Puppet
   Puppet::Type.type(:file).ensurable do

data/lib/puppet/type/file/group.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/posix'
 
 module Puppet

data/lib/puppet/type/file/mode.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Manage file modes.  This state should support different formats
 # for specification (e.g., u+rwx, or -0011), but for now only supports
 # specifying the full mode.

data/lib/puppet/type/file/mtime.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:mtime) do
     desc %q{A read-only state to check the file mtime. On \*nix-like systems, this

data/lib/puppet/type/file/owner.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:owner) do
     include Puppet::Util::Warnings

data/lib/puppet/type/file/selcontext.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Manage SELinux context of files.
 #
 # This code actually manages three pieces of data in the context.

data/lib/puppet/type/file/source.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/file_serving/content'
 require_relative '../../../puppet/file_serving/metadata'
 require_relative '../../../puppet/file_serving/terminus_helper'
@@ -72,7 +73,7 @@ module Puppet
           file { '/etc/nfs.conf':
             source => [
               "puppet:///modules/nfs/conf.${host}",
-              "puppet:///modules/nfs/conf.${operatingsystem}",
+              "puppet:///modules/nfs/conf.${os['name']}",
               'puppet:///modules/nfs/conf'
             ]
           }

data/lib/puppet/type/file/target.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:target) do
     desc "The target for creating a link.  Currently, symlinks are the

data/lib/puppet/type/file/type.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Puppet::Type.type(:file).newproperty(:type) do
     require 'etc'

data/lib/puppet/type/file.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 require 'digest/md5'
 require 'cgi'
 require 'etc'

data/lib/puppet/type/filebucket.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   require_relative '../../puppet/file_bucket/dipper'
 

data/lib/puppet/type/group.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'etc'
 require_relative '../../puppet/property/keyvalue'
 require_relative '../../puppet/parameter/boolean'

data/lib/puppet/type/notify.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 #
 # Simple module for logging messages on the client-side
 

data/lib/puppet/type/package.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+# frozen_string_literal: true
 # Define the different packaging systems.  Each package system is implemented
 # in a module, which then gets used to individually extend each package object.
 # This allows packages to exist on the same machine using different packaging
@@ -242,7 +243,7 @@ module Puppet
       conditionally:
 
           # In the 'openssl' class
-          $ssl = $operatingsystem ? {
+          $ssl = $os['name'] ? {
             solaris => SMCossl,
             default => openssl
           }
@@ -254,7 +255,7 @@ module Puppet
 
           ...
 
-          $ssh = $operatingsystem ? {
+          $ssh = $os['name'] ? {
             solaris => SMCossh,
             default => openssh
           }

data/lib/puppet/type/resources.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 require_relative '../../puppet/parameter/boolean'
 
@@ -170,7 +171,7 @@ Puppet::Type.newtype(:resources) do
     end
 
     # Otherwise, use a sensible default based on the OS family
-    @system_users_max_uid ||= case Puppet.runtime[:facter].value(:osfamily)
+    @system_users_max_uid ||= case Puppet.runtime[:facter].value('os.family')
       when 'OpenBSD', 'FreeBSD'
         999
       else

data/lib/puppet/type/schedule.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   Type.newtype(:schedule) do
     @doc = <<-'EOT'

data/lib/puppet/type/service.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This is our main way of managing processes right now.
 #
 # a service is distinct from a process in that services

data/lib/puppet/type/stage.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.newtype(:stage) do
   desc "A resource type for creating new run stages.  Once a stage is available,
     classes can be assigned to it by declaring them with the resource-like syntax

data/lib/puppet/type/tidy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/parameter/boolean'
 
 Puppet::Type.newtype(:tidy) do

data/lib/puppet/type/user.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'etc'
 require_relative '../../puppet/parameter/boolean'
 require_relative '../../puppet/property/list'

data/lib/puppet/type/whit.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Puppet::Type.newtype(:whit) do
   desc "Whits are internal artifacts of Puppet's current implementation, and
     Puppet suppresses their appearance in all logs. We make no guarantee of

data/lib/puppet/type.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# frozen_string_literal: true
 require_relative '../puppet'
 require_relative '../puppet/util/log'
 require_relative '../puppet/util/metric'
@@ -1032,47 +1033,6 @@ class Type
     self.provider.flush if self.provider and self.provider.respond_to?(:flush)
   end
 
-  # Returns true if all contained objects are in sync.
-  # @todo "contained in what?" in the given "in" parameter?
-  #
-  # @todo deal with the comment _"FIXME I don't think this is used on the type instances any more,
-  #   it's really only used for testing"_
-  # @return [Boolean] true if in sync, false otherwise.
-  #
-  def insync?(is)
-    insync = true
-
-    property = @parameters[:ensure]
-    if property
-      unless is.include? property
-        #TRANSLATORS 'is' is a variable name and should not be translated
-        raise Puppet::DevError, _("The 'is' value is not in the 'is' array for '%{name}'") % { name: property.name }
-      end
-      ensureis = is[property]
-      if property.safe_insync?(ensureis) and property.should == :absent
-        return true
-      end
-    end
-
-    properties.each { |prop|
-      unless is.include? prop
-        #TRANSLATORS 'is' is a variable name and should not be translated
-        raise Puppet::DevError, _("The 'is' value is not in the 'is' array for '%{name}'") % { name: prop.name }
-      end
-
-      propis = is[prop]
-      unless prop.safe_insync?(propis)
-        prop.debug("Not in sync: #{propis.inspect} vs #{prop.should.inspect}")
-        insync = false
-      #else
-      #    property.debug("In sync")
-      end
-    }
-
-    #self.debug("#{self} sync status is #{insync}")
-    insync
-  end
-
   # Says if the ensure property should be retrieved if the resource is ensurable
   # Defaults to true. Some resource type classes can override it
   def self.needs_ensure_retrieved
@@ -1415,7 +1375,7 @@ class Type
       provide a symbolic title and an explicit namevar value:
 
           file { 'sshdconfig':
-            path => $operatingsystem ? {
+            path => $os['name'] ? {
               solaris => '/usr/local/etc/ssh/sshd_config',
               default => '/etc/ssh/sshd_config',
             },

data/lib/puppet/util/at_fork/noop.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A noop implementation of the Puppet::Util::AtFork handler
 class Puppet::Util::AtFork::Noop
   class << self

data/lib/puppet/util/at_fork/solaris.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet'
 require 'fiddle'
 

data/lib/puppet/util/at_fork.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet'
 
 # A module for building AtFork handlers. These handlers are objects providing

data/lib/puppet/util/autoload.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'pathname'
 require_relative '../../puppet/util/rubygems'
 require_relative '../../puppet/util/warnings'

data/lib/puppet/util/backups.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'find'
 require 'fileutils'
 module Puppet::Util::Backups

data/lib/puppet/util/character_encoding.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # A module to centralize heuristics/practices for managing character encoding in Puppet
 
 module Puppet::Util::CharacterEncoding

data/lib/puppet/util/checksums.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'digest/md5'
 require 'digest/sha1'
 require 'time'

data/lib/puppet/util/classgen.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Puppet
   class ConstantAlreadyDefined < Error; end
   class SubclassAlreadyDefined < Error; end

data/lib/puppet/util/colors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../puppet/util/platform'
 
 module Puppet::Util::Colors

data/lib/puppet/util/command_line/puppet_option_parser.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require_relative '../../../puppet/util/command_line/trollop'
 
 module Puppet