puppet 6.4.5 → 6.5.0

data/spec/unit/util/skip_tags_spec.rb

@@ -0,0 +1,14 @@
+# coding: utf-8
+require 'spec_helper'
+
+require 'puppet/util/skip_tags'
+
+describe Puppet::Util::SkipTags do
+  let(:tagger) { Puppet::Util::SkipTags.new([]) }
+
+  it "should add qualified classes as single tags" do
+    tagger.tag("one::two::three")
+    expect(tagger.tags).to include("one::two::three")
+    expect(tagger.tags).not_to include("one", "two", "three")
+  end
+end

data/spec/unit/util/windows/adsi_spec.rb

@@ -41,19 +41,6 @@ describe Puppet::Util::Windows::ADSI, :if => Puppet::Util::Platform.windows? do
     end
   end
 
-  describe ".domain_role" do
-    DOMAIN_ROLES = Puppet::Util::Platform.windows? ? Puppet::Util::Windows::ADSI::DOMAIN_ROLES : {}
-
-    DOMAIN_ROLES.each do |id, role|
-      it "should be able to return #{role} as the domain role of the computer" do
-        Puppet::Util::Windows::ADSI.instance_variable_set(:@domain_role, nil)
-        domain_role = [double('WMI', :DomainRole => id)]
-        allow(Puppet::Util::Windows::ADSI).to receive(:execquery).with('select DomainRole from Win32_ComputerSystem').and_return(domain_role)
-        expect(Puppet::Util::Windows::ADSI.domain_role).to eq(role)
-      end
-    end
-  end
-
   describe ".sid_uri" do
     it "should raise an error when the input is not a SID Principal" do
       [Object.new, {}, 1, :symbol, '', nil].each do |input|
@@ -69,32 +56,6 @@ describe Puppet::Util::Windows::ADSI, :if => Puppet::Util::Platform.windows? do
     end
   end
 
-  shared_examples 'a local only resource query' do |klass, account_type|
-    before(:each) do
-      allow(Puppet::Util::Windows::ADSI).to receive(:domain_role).and_return(:MEMBER_SERVER)
-    end
-
-    it "should be able to check for a local resource" do
-      local_domain = 'testcomputername'
-      principal = double('Principal', :account => resource_name, :domain => local_domain, :account_type => account_type)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(resource_name).and_return(principal)
-      expect(klass.exists?(resource_name)).to eq(true)
-    end
-
-    it "should be case insensitive when comparing the domain with the computer name" do
-      local_domain = 'TESTCOMPUTERNAME'
-      principal = double('Principal', :account => resource_name, :domain => local_domain, :account_type => account_type)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(resource_name).and_return(principal)
-      expect(klass.exists?(resource_name)).to eq(true)
-    end
-
-    it "should return false if no local resource exists" do
-      principal = double('Principal', :account => resource_name, :domain => 'AD_DOMAIN', :account_type => account_type)
-      allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(resource_name).and_return(principal)
-      expect(klass.exists?(resource_name)).to eq(false)
-    end
-  end
-
   describe Puppet::Util::Windows::ADSI::User do
     let(:username)  { 'testuser' }
     let(:domain)    { 'DOMAIN' }
@@ -142,12 +103,6 @@ describe Puppet::Util::Windows::ADSI, :if => Puppet::Util::Platform.windows? do
       expect(user.native_object).to eq(adsi_user)
     end
 
-    context "when domain-joined" do
-      it_should_behave_like 'a local only resource query', Puppet::Util::Windows::ADSI::User, :SidTypeUser do
-        let(:resource_name) { username }
-      end
-    end
-
     it "should be able to check the existence of a user" do
       expect(Puppet::Util::Windows::SID).to receive(:name_to_principal).with(username).and_return(nil)
       expect(Puppet::Util::Windows::ADSI).to receive(:connect).with("WinNT://./#{username},user").and_return(connection)
@@ -588,12 +543,6 @@ describe Puppet::Util::Windows::ADSI, :if => Puppet::Util::Platform.windows? do
       expect(Puppet::Util::Windows::ADSI::Group.uri(groupname, ntauthority_localized)).to eq("WinNT://./#{groupname},group")
     end
 
-    context "when domain-joined" do
-      it_should_behave_like 'a local only resource query', Puppet::Util::Windows::ADSI::Group, :SidTypeGroup do
-        let(:resource_name) { groupname }
-      end
-    end
-
     it "should be able to create a group" do
       adsi_group = double("adsi")
 

data/spec/unit/util/windows/service_spec.rb

@@ -41,10 +41,6 @@ describe "Puppet::Util::Windows::Service", :if => Puppet.features.microsoft_wind
     expect(subject::QUERY_SERVICE_CONFIGW).to receive(:new).and_return(query_return)
   end
 
-  def expect_successful_config_query2_and_return(param, query_return)
-    expect(param).to receive(:new).and_return(query_return)
-  end
-
   let(:subject)      { Puppet::Util::Windows::Service }
   let(:pointer) { double() }
   let(:mock_service_name) { double() }
@@ -55,9 +51,7 @@ describe "Puppet::Util::Windows::Service", :if => Puppet.features.microsoft_wind
   before do
     allow(subject).to receive(:QueryServiceStatusEx).and_return(1)
     allow(subject).to receive(:QueryServiceConfigW).and_return(1)
-    allow(subject).to receive(:QueryServiceConfig2W).and_return(1)
     allow(subject).to receive(:ChangeServiceConfigW).and_return(1)
-    allow(subject).to receive(:ChangeServiceConfig2W).and_return(1)
     allow(subject).to receive(:OpenSCManagerW).and_return(scm)
     allow(subject).to receive(:OpenServiceW).and_return(service)
     allow(subject).to receive(:CloseServiceHandle)
@@ -583,9 +577,6 @@ describe "Puppet::Util::Windows::Service", :if => Puppet.features.microsoft_wind
         }.each do |start_type_name, start_type|
           it "queries the service and returns the service start type #{start_type_name}" do
             expect_successful_config_query_and_return({:dwStartType => start_type})
-            if start_type_name == :SERVICE_AUTO_START
-              expect_successful_config_query2_and_return(subject::SERVICE_DELAYED_AUTO_START_INFO, {:fDelayedAutostart => 0})
-            end
             expect(subject.service_start_type(mock_service_name)).to eq(start_type_name)
           end
         end

data/spec/unit/util_spec.rb

@@ -871,6 +871,16 @@ describe Puppet::Util do
       end
     end
 
+    it "should use a temporary staging location if provided" do
+      new_target = File.join(tmpdir('new_file'), 'new_file.baz')
+      staging_target = tmpdir('staging_file')
+
+      subject.replace_file(new_target, 0555, staging_location: staging_target) do |fh|
+        expect(File.dirname(fh.path)).to eq(staging_target)
+          fh.puts "foo"
+      end
+    end
+
     it "should not replace the file if an exception is thrown in the block" do
       yielded = false
       threw   = false

data/spec/unit/x509/cert_provider_spec.rb

@@ -8,12 +8,6 @@ describe Puppet::X509::CertProvider do
     described_class.new(options)
   end
 
-  def as_pem_file(pem)
-    path = tmpfile('cert_provider_pem')
-    File.write(path, pem)
-    path
-  end
-
   def expects_public_file(path)
     if Puppet::Util::Platform.windows?
       current_sid = Puppet::Util::Windows::SID.name_to_sid(Puppet::Util::Windows::ADSI::User.current_user_name)
@@ -69,7 +63,7 @@ describe Puppet::X509::CertProvider do
 
       context 'and input is invalid' do
         it 'raises when invalid input is inside BEGIN-END block' do
-          ca_path = as_pem_file(<<~END)
+          ca_path = file_containing('invalid_ca', <<~END)
             -----BEGIN CERTIFICATE-----
             whoops
             -----END CERTIFICATE-----
@@ -82,12 +76,12 @@ describe Puppet::X509::CertProvider do
 
         it 'raises if the input is empty' do
           expect {
-            create_provider(capath: as_pem_file('')).load_cacerts
+            create_provider(capath: file_containing('empty_ca', '')).load_cacerts
           }.to raise_error(OpenSSL::X509::CertificateError)
         end
 
         it 'raises if the input is malformed' do
-          ca_path = as_pem_file(<<~END)
+          ca_path = file_containing('malformed_ca', <<~END)
             -----BEGIN CERTIFICATE-----
             MIIBpDCCAQ2gAwIBAgIBAjANBgkqhkiG9w0BAQsFADAfMR0wGwYDVQQDDBRUZXN0
           END
@@ -133,7 +127,7 @@ describe Puppet::X509::CertProvider do
         it 'raises when invalid input is inside BEGIN-END block' do
           pending('jruby bug: https://github.com/jruby/jruby/issues/5619') if Puppet::Util::Platform.jruby?
 
-          crl_path = as_pem_file(<<~END)
+          crl_path = file_containing('invalid_crls', <<~END)
             -----BEGIN X509 CRL-----
             whoops
             -----END X509 CRL-----
@@ -146,12 +140,12 @@ describe Puppet::X509::CertProvider do
 
         it 'raises if the input is empty' do
           expect {
-            create_provider(crlpath: as_pem_file('')).load_crls
+            create_provider(crlpath: file_containing('empty_crl', '')).load_crls
           }.to raise_error(OpenSSL::X509::CRLError, 'Failed to parse CRLs as PEM')
         end
 
         it 'raises if the input is malformed' do
-          crl_path = as_pem_file(<<~END)
+          crl_path = file_containing('malformed_crl', <<~END)
             -----BEGIN X509 CRL-----
             MIIBCjB1AgEBMA0GCSqGSIb3DQEBCwUAMBIxEDAOBgNVBAMMB1Rlc3QgQ0EXDTcw
           END
@@ -231,6 +225,7 @@ describe Puppet::X509::CertProvider do
   context 'when loading' do
     context 'private keys' do
       let(:provider) { create_provider(privatekeydir: fixture_dir) }
+      let(:password) { '74695716c8b6' }
 
       it 'returns nil if it does not exist' do
         provider = create_provider(privatekeydir: '/does/not/exist')
@@ -246,10 +241,6 @@ describe Puppet::X509::CertProvider do
         }.to raise_error(Puppet::Error, %r{The private key is missing from '/does/not/exist/whatever.pem'})
       end
 
-      it 'returns an RSA key' do
-        expect(provider.load_private_key('signed-key')).to be_a(OpenSSL::PKey::RSA)
-      end
-
       it 'downcases name' do
         expect(provider.load_private_key('SIGNED-KEY')).to be_a(OpenSSL::PKey::RSA)
       end
@@ -260,11 +251,11 @@ describe Puppet::X509::CertProvider do
         }.to raise_error(RuntimeError, 'Certname "signed/../key" must not contain unprintable or non-ASCII characters')
       end
 
-      it 'prefers `hostprivkey` if set' do
+      it 'returns nil if `hostprivkey` is overridden' do
         Puppet[:certname] = 'foo'
         Puppet[:hostprivkey] = File.join(fixture_dir, "signed-key.pem")
 
-        expect(provider.load_private_key('foo')).to be_a(OpenSSL::PKey::RSA)
+        expect(provider.load_private_key('foo')).to be_nil
       end
 
       it 'raises if the private key is unreadable' do
@@ -275,12 +266,48 @@ describe Puppet::X509::CertProvider do
         }.to raise_error(Puppet::Error, "Failed to load private key for 'signed'")
       end
 
-      context 'that are encrypted' do
-        it 'raises without a passphrase' do
+      context 'using RSA' do
+        it 'returns an RSA key' do
+          expect(provider.load_private_key('signed-key')).to be_a(OpenSSL::PKey::RSA)
+        end
+
+        it 'decrypts an RSA key using the password' do
+          rsa = provider.load_private_key('encrypted-key', password: password)
+          expect(rsa).to be_a(OpenSSL::PKey::RSA)
+        end
+
+        it 'raises without a password' do
           # password is 74695716c8b6
           expect {
             provider.load_private_key('encrypted-key')
-          }.to raise_error(OpenSSL::PKey::RSAError, /Neither PUB key nor PRIV key/)
+          }.to raise_error(OpenSSL::PKey::PKeyError, /Could not parse PKey: no start line/)
+        end
+
+        it 'decrypts an RSA key previously saved using 3DES' do
+          key = key_fixture('signed-key.pem')
+          cipher = OpenSSL::Cipher::DES.new(:EDE3, :CBC)
+          privatekeydir = dir_containing('private_keys', {'oldkey.pem' => key.export(cipher, password)})
+          provider = create_provider(privatekeydir: privatekeydir)
+
+          expect(provider.load_private_key('oldkey', password: password).to_der).to eq(key.to_der)
+        end
+      end
+
+      context 'using EC' do
+        it 'returns an EC key' do
+          expect(provider.load_private_key('ec-key')).to be_a(OpenSSL::PKey::EC)
+        end
+
+        it 'decrypts an EC key using the password' do
+          ec = provider.load_private_key('encrypted-ec-key', password: password)
+          expect(ec).to be_a(OpenSSL::PKey::EC)
+        end
+
+        it 'raises without a password' do
+          # password is 74695716c8b6
+          expect {
+            provider.load_private_key('encrypted-ec-key')
+          }.to raise_error(OpenSSL::PKey::PKeyError, /Could not parse PKey: no start line/)
         end
       end
     end
@@ -318,11 +345,11 @@ describe Puppet::X509::CertProvider do
         }.to raise_error(RuntimeError, 'Certname "tom/../key" must not contain unprintable or non-ASCII characters')
       end
 
-      it 'prefers `hostcert` if set' do
+      it 'returns nil if `hostcert` is overridden' do
         Puppet[:certname] = 'foo'
         Puppet[:hostcert] = File.join(fixture_dir, "signed.pem")
 
-        expect(provider.load_client_cert('foo')).to be_a(OpenSSL::X509::Certificate)
+        expect(provider.load_client_cert('foo')).to be_nil
       end
 
       it 'raises if the certificate is unreadable' do
@@ -388,6 +415,12 @@ describe Puppet::X509::CertProvider do
         expect(File.read(path)).to match(/\A-----BEGIN RSA PRIVATE KEY-----.*?-----END RSA PRIVATE KEY-----\Z/m)
       end
 
+      it 'encrypts the private key using AES128-CBC' do
+        provider.save_private_key(name, private_key, password: Random.new.bytes(8))
+
+        expect(File.read(path)).to match(/Proc-Type: 4,ENCRYPTED.*DEK-Info: AES-128-CBC/m)
+      end
+
       it 'sets mode to 640' do
         provider.save_private_key(name, private_key)
 
@@ -413,16 +446,6 @@ describe Puppet::X509::CertProvider do
           provider.save_private_key(name, private_key)
         }.to raise_error(Puppet::Error, "Failed to save private key for '#{name}'")
       end
-
-      it 'prefers `hostprivkey` if set' do
-        overridden_path = tmpfile('hostprivkey')
-        Puppet[:hostprivkey] = overridden_path
-
-        provider.save_private_key(name, private_key)
-
-        expect(File).to_not exist(path)
-        expect(File).to exist(overridden_path)
-      end
     end
 
     context 'certs' do
@@ -462,16 +485,6 @@ describe Puppet::X509::CertProvider do
           provider.save_client_cert(name, client_cert)
         }.to raise_error(Puppet::Error, "Failed to save client certificate for '#{name}'")
       end
-
-      it 'prefers `hostcert` if set' do
-        overridden_path = tmpfile('hostcert')
-        Puppet[:hostcert] = overridden_path
-
-        provider.save_client_cert(name, client_cert)
-
-        expect(File).to_not exist(path)
-        expect(File).to exist(overridden_path)
-      end
     end
 
     context 'requests' do
@@ -544,4 +557,30 @@ describe Puppet::X509::CertProvider do
       end
     end
   end
+
+  context 'CRL last update time' do
+    let(:crl_path) { tmpfile('pem_crls') }
+
+    it 'returns nil if the CRL does not exist' do
+      provider = create_provider(crlpath: '/does/not/exist')
+
+      expect(provider.crl_last_update).to be_nil
+    end
+
+    it 'returns the last update time' do
+      time = Time.now - 30
+      Puppet::FileSystem.touch(crl_path, mtime: time)
+      provider = create_provider(crlpath: crl_path)
+
+      expect(provider.crl_last_update).to be_within(1).of(time)
+    end
+
+    it 'sets the last update time' do
+      time = Time.now - 30
+      provider = create_provider(crlpath: crl_path)
+      provider.crl_last_update = time
+
+      expect(Puppet::FileSystem.stat(crl_path).mtime).to be_within(1).of(time)
+    end
+  end
 end

data/tasks/generate_cert_fixtures.rake

@@ -38,7 +38,8 @@ task(:gen_cert_fixtures) do
   # signed.pem                        |   +- /CN=signed
   # revoked.pem                       |   +- /CN=revoked
   # 127.0.0.1.pem                     |   +- /CN=127.0.0.1 (with dns alt names)
-  # tampered.pem                      |   +- /CN=signed (with different public key)
+  # tampered-cert.pem                 |   +- /CN=signed (with different public key)
+  # ec.pem                            |   +- /CN=ec (with EC private key)
   #                                   |
   #                                   + /CN=Test CA Agent Subauthority
   #                                   |  |
@@ -95,6 +96,17 @@ task(:gen_cert_fixtures) do
   save(dir, 'revoked.pem', revoked[:cert])
   save(dir, 'revoked-key.pem', revoked[:private_key])
 
+  # Create an EC key and cert, issued by "Test CA Subauthority"
+  ec = ca.create_cert('ec', inter[:cert], inter[:private_key], key_type: :ec)
+  save(dir, 'ec.pem', ec[:cert])
+  save(dir, 'ec-key.pem', ec[:private_key])
+
+  # Create an encrypted version of the above private key for host "ec"
+  save(dir, 'encrypted-ec-key.pem', ec[:private_key]) do |x509|
+    # private key password was chosen at random
+    x509.to_pem(OpenSSL::Cipher::AES.new(128, :CBC), '74695716c8b6')
+  end
+
   # Update intermediate CRL now that we've revoked
   save(dir, 'intermediate-crl.pem', inter_crl)
 

data/tasks/manpages.rake

@@ -43,7 +43,6 @@ task :gen_manpages do
 #   IO.popen("#{ronn} #{ronn_args} > ./man/man5/puppet.conf.5", 'w') do |fh|
 #     fh.write %x{RUBYLIB=./lib:$RUBYLIB bin/puppetdoc --reference configuration}
 #   end
-  %x{mkdir -p ./man/man5 ./man/man8}
   %x{RUBYLIB=./lib:$RUBYLIB bin/puppet doc --reference configuration > ./man/man5/puppetconf.5.ronn}
   %x{#{ronn} #{ronn_args} ./man/man5/puppetconf.5.ronn}
   FileUtils.mv("./man/man5/puppetconf.5", "./man/man5/puppet.conf.5")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet
 version: !ruby/object:Gem::Version
-  version: 6.4.5
+  version: 6.5.0
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-10 00:00:00.000000000 Z
+date: 2019-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: facter
@@ -70,14 +70,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.2
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: locale
   requirement: !ruby/object:Gem::Requirement
@@ -173,7 +173,6 @@ files:
 - examples/hiera/site.pp
 - ext/README.environment
 - ext/build_defaults.yaml
-- ext/cert_inspector
 - ext/dbfix.sql
 - ext/debian/README.Debian
 - ext/debian/README.source
@@ -224,8 +223,6 @@ files:
 - ext/debian/vim-puppet.dirs
 - ext/debian/vim-puppet.yaml
 - ext/debian/watch
-- ext/envpuppet
-- ext/envpuppet.bat
 - ext/freebsd/puppetd
 - ext/freebsd/puppetmasterd
 - ext/gentoo/conf.d/puppet
@@ -250,8 +247,6 @@ files:
 - ext/osx/prototype.plist.erb
 - ext/osx/puppet.plist
 - ext/project_data.yaml
-- ext/puppet-test
-- ext/pure_ruby_dsl/dsl_test.rb
 - ext/redhat/client.init
 - ext/redhat/client.sysconfig
 - ext/redhat/fileserver.conf
@@ -277,7 +272,9 @@ files:
 - ext/suse/puppet.spec
 - ext/suse/server.init
 - ext/systemd/puppet.service
-- ext/upload_facts.rb
+- ext/windows/eventlog/Rakefile
+- ext/windows/eventlog/puppetres.dll
+- ext/windows/eventlog/puppetres.mc
 - ext/windows/puppet_interactive.bat
 - ext/windows/puppet_shell.bat
 - ext/windows/run_puppet_interactive.bat
@@ -827,6 +824,7 @@ files:
 - lib/puppet/pops/loader/loader.rb
 - lib/puppet/pops/loader/loader_paths.rb
 - lib/puppet/pops/loader/module_loaders.rb
+- lib/puppet/pops/loader/null_loader.rb
 - lib/puppet/pops/loader/predefined_loader.rb
 - lib/puppet/pops/loader/puppet_function_instantiator.rb
 - lib/puppet/pops/loader/puppet_plan_instantiator.rb
@@ -993,7 +991,6 @@ files:
 - lib/puppet/provider/package/aptrpm.rb
 - lib/puppet/provider/package/blastwave.rb
 - lib/puppet/provider/package/dnf.rb
-- lib/puppet/provider/package/dnfmodule.rb
 - lib/puppet/provider/package/dpkg.rb
 - lib/puppet/provider/package/fink.rb
 - lib/puppet/provider/package/freebsd.rb
@@ -1381,6 +1378,9 @@ files:
 - spec/fixtures/ssl/bad-int-basic-constraints.pem
 - spec/fixtures/ssl/ca.pem
 - spec/fixtures/ssl/crl.pem
+- spec/fixtures/ssl/ec-key.pem
+- spec/fixtures/ssl/ec.pem
+- spec/fixtures/ssl/encrypted-ec-key.pem
 - spec/fixtures/ssl/encrypted-key.pem
 - spec/fixtures/ssl/intermediate-agent-crl.pem
 - spec/fixtures/ssl/intermediate-agent.pem
@@ -1594,6 +1594,7 @@ files:
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load5.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/callee.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/callee_ws.rb
+- spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/func_with_syntax_error.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/good_func_load.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/metadata.json
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/user/functions/puppetcalled.pp
@@ -1664,7 +1665,6 @@ files:
 - spec/fixtures/unit/provider/cron/crontab/vixie_header.txt
 - spec/fixtures/unit/provider/cron/parsed/managed
 - spec/fixtures/unit/provider/cron/parsed/simple
-- spec/fixtures/unit/provider/package/dnfmodule/dnf-module-list-installed.txt
 - spec/fixtures/unit/provider/package/gem/gem-list-single-package
 - spec/fixtures/unit/provider/package/gem/line-with-1.8.5-warning
 - spec/fixtures/unit/provider/package/openbsd/pkginfo.detail
@@ -1715,6 +1715,9 @@ files:
 - spec/fixtures/unit/util/filetype/suntab_output
 - spec/fixtures/unit/util/monkey_patches/x509.pem
 - spec/fixtures/unit/util/rdoc/basic.pp
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_get/should_yield_to_the_block.yml
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_head/should_yield_to_the_block.yml
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_post/should_yield_to_the_block.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_fetch_if_not_on_the_local_disk.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_not_update_if_content_on_disk_is_up-to-date.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_update_if_content_differs_on_disk.yml
@@ -1788,7 +1791,6 @@ files:
 - spec/integration/transaction_spec.rb
 - spec/integration/type/exec_spec.rb
 - spec/integration/type/file_spec.rb
-- spec/integration/type/notify_spec.rb
 - spec/integration/type/package_spec.rb
 - spec/integration/type/tidy_spec.rb
 - spec/integration/type_spec.rb
@@ -2318,7 +2320,6 @@ files:
 - spec/unit/provider/package/aptrpm_spec.rb
 - spec/unit/provider/package/base_spec.rb
 - spec/unit/provider/package/dnf_spec.rb
-- spec/unit/provider/package/dnfmodule_spec.rb
 - spec/unit/provider/package/dpkg_spec.rb
 - spec/unit/provider/package/freebsd_spec.rb
 - spec/unit/provider/package/gem_spec.rb
@@ -2348,7 +2349,6 @@ files:
 - spec/unit/provider/package/windows_spec.rb
 - spec/unit/provider/package/yum_spec.rb
 - spec/unit/provider/package/zypper_spec.rb
-- spec/unit/provider/package_targetable_spec.rb
 - spec/unit/provider/parsedfile_spec.rb
 - spec/unit/provider/service/base_spec.rb
 - spec/unit/provider/service/bsd_spec.rb
@@ -2513,6 +2513,7 @@ files:
 - spec/unit/util/rubygems_spec.rb
 - spec/unit/util/run_mode_spec.rb
 - spec/unit/util/selinux_spec.rb
+- spec/unit/util/skip_tags_spec.rb
 - spec/unit/util/splayer_spec.rb
 - spec/unit/util/ssl_spec.rb
 - spec/unit/util/storage_spec.rb
@@ -2575,7 +2576,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.0.6
+rubyforge_project: puppet
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Puppet, an automated configuration management tool
@@ -2618,6 +2620,9 @@ test_files:
 - spec/fixtures/ssl/bad-int-basic-constraints.pem
 - spec/fixtures/ssl/ca.pem
 - spec/fixtures/ssl/crl.pem
+- spec/fixtures/ssl/ec-key.pem
+- spec/fixtures/ssl/ec.pem
+- spec/fixtures/ssl/encrypted-ec-key.pem
 - spec/fixtures/ssl/encrypted-key.pem
 - spec/fixtures/ssl/intermediate-agent-crl.pem
 - spec/fixtures/ssl/intermediate-agent.pem
@@ -2831,6 +2836,7 @@ test_files:
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load5.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/callee.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/callee_ws.rb
+- spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/func_with_syntax_error.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/good_func_load.rb
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/metadata.json
 - spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/user/functions/puppetcalled.pp
@@ -2901,7 +2907,6 @@ test_files:
 - spec/fixtures/unit/provider/cron/crontab/vixie_header.txt
 - spec/fixtures/unit/provider/cron/parsed/managed
 - spec/fixtures/unit/provider/cron/parsed/simple
-- spec/fixtures/unit/provider/package/dnfmodule/dnf-module-list-installed.txt
 - spec/fixtures/unit/provider/package/gem/gem-list-single-package
 - spec/fixtures/unit/provider/package/gem/line-with-1.8.5-warning
 - spec/fixtures/unit/provider/package/openbsd/pkginfo.detail
@@ -2952,6 +2957,9 @@ test_files:
 - spec/fixtures/unit/util/filetype/suntab_output
 - spec/fixtures/unit/util/monkey_patches/x509.pem
 - spec/fixtures/unit/util/rdoc/basic.pp
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_get/should_yield_to_the_block.yml
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_head/should_yield_to_the_block.yml
+- spec/fixtures/vcr/cassettes/Puppet_Network_HTTP_Connection/when_handling_requests/_request_post/should_yield_to_the_block.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_fetch_if_not_on_the_local_disk.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_not_update_if_content_on_disk_is_up-to-date.yml
 - spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_update_if_content_differs_on_disk.yml
@@ -3025,7 +3033,6 @@ test_files:
 - spec/integration/transaction_spec.rb
 - spec/integration/type/exec_spec.rb
 - spec/integration/type/file_spec.rb
-- spec/integration/type/notify_spec.rb
 - spec/integration/type/package_spec.rb
 - spec/integration/type/tidy_spec.rb
 - spec/integration/type_spec.rb
@@ -3555,7 +3562,6 @@ test_files:
 - spec/unit/provider/package/aptrpm_spec.rb
 - spec/unit/provider/package/base_spec.rb
 - spec/unit/provider/package/dnf_spec.rb
-- spec/unit/provider/package/dnfmodule_spec.rb
 - spec/unit/provider/package/dpkg_spec.rb
 - spec/unit/provider/package/freebsd_spec.rb
 - spec/unit/provider/package/gem_spec.rb
@@ -3585,7 +3591,6 @@ test_files:
 - spec/unit/provider/package/windows_spec.rb
 - spec/unit/provider/package/yum_spec.rb
 - spec/unit/provider/package/zypper_spec.rb
-- spec/unit/provider/package_targetable_spec.rb
 - spec/unit/provider/parsedfile_spec.rb
 - spec/unit/provider/service/base_spec.rb
 - spec/unit/provider/service/bsd_spec.rb
@@ -3750,6 +3755,7 @@ test_files:
 - spec/unit/util/rubygems_spec.rb
 - spec/unit/util/run_mode_spec.rb
 - spec/unit/util/selinux_spec.rb
+- spec/unit/util/skip_tags_spec.rb
 - spec/unit/util/splayer_spec.rb
 - spec/unit/util/ssl_spec.rb
 - spec/unit/util/storage_spec.rb