puppet 6.4.0-universal-darwin → 6.4.1-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (646) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +7 -11
  4. data/lib/puppet/application/device.rb +97 -82
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/application/ssl.rb +2 -2
  7. data/lib/puppet/configurer.rb +5 -4
  8. data/lib/puppet/defaults.rb +33 -11
  9. data/lib/puppet/indirector/request.rb +28 -15
  10. data/lib/puppet/ssl.rb +1 -1
  11. data/lib/puppet/ssl/certificate.rb +1 -1
  12. data/lib/puppet/ssl/error.rb +1 -1
  13. data/lib/puppet/ssl/host.rb +0 -47
  14. data/lib/puppet/ssl/ssl_provider.rb +2 -2
  15. data/lib/puppet/ssl/state_machine.rb +16 -17
  16. data/lib/puppet/ssl/validator/default_validator.rb +4 -4
  17. data/lib/puppet/ssl/verifier.rb +1 -1
  18. data/lib/puppet/transaction/event_manager.rb +1 -5
  19. data/lib/puppet/util/connection.rb +15 -8
  20. data/lib/puppet/util/monkey_patches.rb +20 -1
  21. data/lib/puppet/version.rb +1 -1
  22. data/locales/puppet.pot +135 -68
  23. data/man/man5/puppet.conf.5 +9 -9
  24. data/man/man8/puppet-agent.8 +1 -1
  25. data/man/man8/puppet-apply.8 +1 -1
  26. data/man/man8/puppet-catalog.8 +1 -1
  27. data/man/man8/puppet-config.8 +1 -1
  28. data/man/man8/puppet-describe.8 +1 -1
  29. data/man/man8/puppet-device.8 +1 -1
  30. data/man/man8/puppet-doc.8 +1 -1
  31. data/man/man8/puppet-epp.8 +1 -1
  32. data/man/man8/puppet-facts.8 +1 -1
  33. data/man/man8/puppet-filebucket.8 +1 -1
  34. data/man/man8/puppet-generate.8 +1 -1
  35. data/man/man8/puppet-help.8 +1 -1
  36. data/man/man8/puppet-key.8 +1 -1
  37. data/man/man8/puppet-lookup.8 +1 -1
  38. data/man/man8/puppet-man.8 +1 -1
  39. data/man/man8/puppet-module.8 +1 -1
  40. data/man/man8/puppet-node.8 +1 -1
  41. data/man/man8/puppet-parser.8 +1 -1
  42. data/man/man8/puppet-plugin.8 +1 -1
  43. data/man/man8/puppet-report.8 +1 -1
  44. data/man/man8/puppet-resource.8 +1 -1
  45. data/man/man8/puppet-script.8 +1 -1
  46. data/man/man8/puppet-ssl.8 +1 -1
  47. data/man/man8/puppet-status.8 +1 -1
  48. data/man/man8/puppet.8 +2 -2
  49. data/spec/integration/agent/logging_spec.rb +5 -7
  50. data/spec/integration/application/apply_spec.rb +18 -16
  51. data/spec/integration/application/doc_spec.rb +1 -2
  52. data/spec/integration/application/lookup_spec.rb +5 -5
  53. data/spec/integration/configurer_spec.rb +5 -6
  54. data/spec/integration/defaults_spec.rb +5 -6
  55. data/spec/integration/directory_environments_spec.rb +1 -1
  56. data/spec/integration/faces/config_spec.rb +3 -4
  57. data/spec/integration/faces/documentation_spec.rb +0 -1
  58. data/spec/integration/faces/plugin_spec.rb +1 -1
  59. data/spec/integration/file_bucket/file_spec.rb +2 -4
  60. data/spec/integration/file_serving/content_spec.rb +0 -1
  61. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  62. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  63. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  64. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  65. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  66. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  67. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  68. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  69. data/spec/integration/network/authconfig_spec.rb +23 -24
  70. data/spec/integration/network/formats_spec.rb +0 -1
  71. data/spec/integration/network/http_pool_spec.rb +3 -3
  72. data/spec/integration/node/environment_spec.rb +0 -1
  73. data/spec/integration/node/facts_spec.rb +9 -10
  74. data/spec/integration/node_spec.rb +6 -7
  75. data/spec/integration/parser/catalog_spec.rb +1 -5
  76. data/spec/integration/parser/collection_spec.rb +1 -2
  77. data/spec/integration/parser/compiler_spec.rb +6 -6
  78. data/spec/integration/parser/scope_spec.rb +1 -1
  79. data/spec/integration/parser/undef_param_spec.rb +1 -1
  80. data/spec/integration/provider/service/init_spec.rb +4 -5
  81. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  82. data/spec/integration/provider/service/windows_spec.rb +1 -2
  83. data/spec/integration/reference/providers_spec.rb +1 -2
  84. data/spec/integration/reports_spec.rb +1 -2
  85. data/spec/integration/resource/catalog_spec.rb +14 -17
  86. data/spec/integration/resource/type_collection_spec.rb +4 -5
  87. data/spec/integration/rest/client_spec.rb +1 -1
  88. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  89. data/spec/integration/ssl/host_spec.rb +1 -2
  90. data/spec/integration/ssl/key_spec.rb +0 -1
  91. data/spec/integration/test/test_helper_spec.rb +0 -1
  92. data/spec/integration/transaction/report_spec.rb +6 -11
  93. data/spec/integration/transaction_spec.rb +18 -19
  94. data/spec/integration/type/exec_spec.rb +0 -1
  95. data/spec/integration/type/file_spec.rb +13 -14
  96. data/spec/integration/type/package_spec.rb +19 -23
  97. data/spec/integration/type/tidy_spec.rb +1 -2
  98. data/spec/integration/type_spec.rb +0 -1
  99. data/spec/integration/util/autoload_spec.rb +1 -2
  100. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  101. data/spec/integration/util/settings_spec.rb +0 -1
  102. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  103. data/spec/integration/util/windows/principal_spec.rb +0 -1
  104. data/spec/integration/util/windows/process_spec.rb +4 -6
  105. data/spec/integration/util/windows/registry_spec.rb +41 -51
  106. data/spec/integration/util/windows/security_spec.rb +2 -4
  107. data/spec/integration/util/windows/user_spec.rb +18 -20
  108. data/spec/integration/util_spec.rb +4 -7
  109. data/spec/lib/puppet_spec/compiler.rb +1 -1
  110. data/spec/lib/puppet_spec/files.rb +0 -1
  111. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  112. data/spec/lib/puppet_spec/scope.rb +1 -2
  113. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  114. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  115. data/spec/shared_behaviours/file_serving.rb +6 -8
  116. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  117. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  118. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  119. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  120. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  121. data/spec/spec_helper.rb +10 -1
  122. data/spec/unit/agent/disabler_spec.rb +4 -5
  123. data/spec/unit/agent/locker_spec.rb +12 -13
  124. data/spec/unit/agent_spec.rb +80 -85
  125. data/spec/unit/application/agent_spec.rb +88 -94
  126. data/spec/unit/application/apply_spec.rb +82 -83
  127. data/spec/unit/application/config_spec.rb +0 -1
  128. data/spec/unit/application/describe_spec.rb +6 -7
  129. data/spec/unit/application/device_spec.rb +379 -384
  130. data/spec/unit/application/doc_spec.rb +44 -46
  131. data/spec/unit/application/face_base_spec.rb +61 -62
  132. data/spec/unit/application/facts_spec.rb +3 -4
  133. data/spec/unit/application/filebucket_spec.rb +66 -74
  134. data/spec/unit/application/indirection_base_spec.rb +8 -6
  135. data/spec/unit/application/lookup_spec.rb +26 -26
  136. data/spec/unit/application/resource_spec.rb +42 -48
  137. data/spec/unit/application/ssl_spec.rb +9 -9
  138. data/spec/unit/application_spec.rb +82 -92
  139. data/spec/unit/capability_spec.rb +6 -6
  140. data/spec/unit/certificate_factory_spec.rb +3 -5
  141. data/spec/unit/configurer/downloader_spec.rb +20 -21
  142. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  143. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  144. data/spec/unit/configurer_spec.rb +189 -192
  145. data/spec/unit/confine/exists_spec.rb +17 -15
  146. data/spec/unit/confine/false_spec.rb +5 -6
  147. data/spec/unit/confine/feature_spec.rb +7 -5
  148. data/spec/unit/confine/true_spec.rb +5 -6
  149. data/spec/unit/confine/variable_spec.rb +14 -15
  150. data/spec/unit/confine_collection_spec.rb +28 -29
  151. data/spec/unit/confine_spec.rb +13 -14
  152. data/spec/unit/confiner_spec.rb +10 -11
  153. data/spec/unit/context/trusted_information_spec.rb +1 -1
  154. data/spec/unit/daemon_spec.rb +35 -36
  155. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  156. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  157. data/spec/unit/datatypes_spec.rb +3 -4
  158. data/spec/unit/defaults_spec.rb +18 -13
  159. data/spec/unit/environments_spec.rb +7 -7
  160. data/spec/unit/etc_spec.rb +30 -32
  161. data/spec/unit/external/pson_spec.rb +0 -1
  162. data/spec/unit/face/catalog_spec.rb +0 -1
  163. data/spec/unit/face/config_spec.rb +31 -35
  164. data/spec/unit/face/epp_face_spec.rb +3 -4
  165. data/spec/unit/face/facts_spec.rb +5 -6
  166. data/spec/unit/face/generate_spec.rb +4 -5
  167. data/spec/unit/face/help_spec.rb +7 -8
  168. data/spec/unit/face/key_spec.rb +0 -1
  169. data/spec/unit/face/man_spec.rb +1 -2
  170. data/spec/unit/face/module/install_spec.rb +3 -5
  171. data/spec/unit/face/module/list_spec.rb +2 -12
  172. data/spec/unit/face/module/search_spec.rb +11 -9
  173. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  174. data/spec/unit/face/node_spec.rb +23 -24
  175. data/spec/unit/face/parser_spec.rb +3 -3
  176. data/spec/unit/face/plugin_spec.rb +36 -9
  177. data/spec/unit/face/status_spec.rb +0 -1
  178. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  179. data/spec/unit/file_bucket/file_spec.rb +0 -2
  180. data/spec/unit/file_serving/base_spec.rb +14 -15
  181. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  182. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  183. data/spec/unit/file_serving/content_spec.rb +10 -11
  184. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  185. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  186. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  187. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  188. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  189. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  190. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  191. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  192. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  193. data/spec/unit/file_serving/mount_spec.rb +0 -1
  194. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  195. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  196. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  197. data/spec/unit/file_system_spec.rb +4 -4
  198. data/spec/unit/forge/errors_spec.rb +1 -1
  199. data/spec/unit/forge/forge_spec.rb +13 -14
  200. data/spec/unit/forge/module_release_spec.rb +18 -18
  201. data/spec/unit/forge/repository_spec.rb +29 -30
  202. data/spec/unit/forge_spec.rb +15 -11
  203. data/spec/unit/functions/binary_file_spec.rb +3 -3
  204. data/spec/unit/functions/contain_spec.rb +0 -2
  205. data/spec/unit/functions/defined_spec.rb +0 -1
  206. data/spec/unit/functions/epp_spec.rb +2 -2
  207. data/spec/unit/functions/find_file_spec.rb +7 -7
  208. data/spec/unit/functions/include_spec.rb +0 -4
  209. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  210. data/spec/unit/functions/lookup_spec.rb +1 -2
  211. data/spec/unit/functions/module_directory_spec.rb +12 -12
  212. data/spec/unit/functions/require_spec.rb +0 -3
  213. data/spec/unit/functions/shared.rb +5 -8
  214. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  215. data/spec/unit/functions4_spec.rb +9 -10
  216. data/spec/unit/gettext/config_spec.rb +4 -4
  217. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  218. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  219. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  220. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  221. data/spec/unit/hiera_puppet_spec.rb +20 -20
  222. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  223. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  224. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  225. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  226. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  227. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  228. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  229. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  230. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  231. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  232. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  233. data/spec/unit/indirector/envelope_spec.rb +1 -2
  234. data/spec/unit/indirector/exec_spec.rb +4 -5
  235. data/spec/unit/indirector/face_spec.rb +9 -9
  236. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  237. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  238. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  239. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  240. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  241. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  242. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  243. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  244. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  245. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  246. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  247. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  248. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  249. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  250. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  251. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  252. data/spec/unit/indirector/file_server_spec.rb +87 -87
  253. data/spec/unit/indirector/indirection_spec.rb +242 -226
  254. data/spec/unit/indirector/json_spec.rb +7 -9
  255. data/spec/unit/indirector/key/file_spec.rb +21 -22
  256. data/spec/unit/indirector/memory_spec.rb +6 -7
  257. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  258. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  259. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  260. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  261. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  262. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  263. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  264. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  265. data/spec/unit/indirector/none_spec.rb +5 -5
  266. data/spec/unit/indirector/plain_spec.rb +7 -8
  267. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  268. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  269. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  270. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  271. data/spec/unit/indirector/request_spec.rb +11 -12
  272. data/spec/unit/indirector/resource/ral_spec.rb +47 -54
  273. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  274. data/spec/unit/indirector/rest_spec.rb +113 -110
  275. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  276. data/spec/unit/indirector/status/local_spec.rb +0 -1
  277. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  278. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  279. data/spec/unit/indirector/terminus_spec.rb +27 -27
  280. data/spec/unit/indirector/yaml_spec.rb +5 -6
  281. data/spec/unit/indirector_spec.rb +1 -2
  282. data/spec/unit/info_service_spec.rb +1 -1
  283. data/spec/unit/interface/action_builder_spec.rb +0 -1
  284. data/spec/unit/interface/action_manager_spec.rb +0 -1
  285. data/spec/unit/interface/action_spec.rb +2 -3
  286. data/spec/unit/interface/documentation_spec.rb +0 -1
  287. data/spec/unit/interface/face_collection_spec.rb +19 -12
  288. data/spec/unit/interface_spec.rb +3 -3
  289. data/spec/unit/man_spec.rb +3 -4
  290. data/spec/unit/module_spec.rb +46 -51
  291. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  292. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  293. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  294. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  295. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  296. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  297. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  298. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  299. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  300. data/spec/unit/module_tool/tar_spec.rb +12 -13
  301. data/spec/unit/module_tool_spec.rb +7 -12
  302. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  303. data/spec/unit/network/authconfig_spec.rb +17 -18
  304. data/spec/unit/network/authorization_spec.rb +4 -5
  305. data/spec/unit/network/authstore_spec.rb +0 -1
  306. data/spec/unit/network/format_handler_spec.rb +0 -1
  307. data/spec/unit/network/format_spec.rb +9 -10
  308. data/spec/unit/network/format_support_spec.rb +28 -29
  309. data/spec/unit/network/formats_spec.rb +4 -5
  310. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  311. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  312. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  313. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  314. data/spec/unit/network/http/api_spec.rb +0 -2
  315. data/spec/unit/network/http/compression_spec.rb +21 -22
  316. data/spec/unit/network/http/connection_spec.rb +35 -35
  317. data/spec/unit/network/http/factory_spec.rb +5 -6
  318. data/spec/unit/network/http/handler_spec.rb +9 -18
  319. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  320. data/spec/unit/network/http/pool_spec.rb +33 -34
  321. data/spec/unit/network/http/request_spec.rb +0 -2
  322. data/spec/unit/network/http/response_spec.rb +11 -13
  323. data/spec/unit/network/http/route_spec.rb +0 -1
  324. data/spec/unit/network/http/session_spec.rb +2 -3
  325. data/spec/unit/network/http/site_spec.rb +0 -1
  326. data/spec/unit/network/http_pool_spec.rb +19 -10
  327. data/spec/unit/network/http_spec.rb +0 -1
  328. data/spec/unit/network/resolver_spec.rb +25 -26
  329. data/spec/unit/network/rights_spec.rb +52 -53
  330. data/spec/unit/node/environment_spec.rb +14 -15
  331. data/spec/unit/node/facts_spec.rb +5 -7
  332. data/spec/unit/node_spec.rb +4 -10
  333. data/spec/unit/other/selinux_spec.rb +0 -1
  334. data/spec/unit/parameter/boolean_spec.rb +1 -2
  335. data/spec/unit/parameter/package_options_spec.rb +1 -2
  336. data/spec/unit/parameter/path_spec.rb +0 -1
  337. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  338. data/spec/unit/parameter/value_spec.rb +0 -1
  339. data/spec/unit/parameter_spec.rb +9 -9
  340. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  341. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  342. data/spec/unit/parser/compiler_spec.rb +84 -96
  343. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  344. data/spec/unit/parser/files_spec.rb +0 -1
  345. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  346. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  347. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  348. data/spec/unit/parser/functions/file_spec.rb +13 -14
  349. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  350. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  351. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  352. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  353. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  354. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  355. data/spec/unit/parser/functions/split_spec.rb +0 -1
  356. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  357. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  358. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  359. data/spec/unit/parser/functions/template_spec.rb +13 -13
  360. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  361. data/spec/unit/parser/functions_spec.rb +6 -7
  362. data/spec/unit/parser/relationship_spec.rb +0 -1
  363. data/spec/unit/parser/resource_spec.rb +42 -42
  364. data/spec/unit/parser/scope_spec.rb +39 -35
  365. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  366. data/spec/unit/parser/type_loader_spec.rb +17 -19
  367. data/spec/unit/pops/adaptable_spec.rb +0 -1
  368. data/spec/unit/pops/benchmark_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  371. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  372. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  373. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  374. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  375. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  376. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  377. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  378. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  379. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  380. data/spec/unit/pops/factory_spec.rb +3 -4
  381. data/spec/unit/pops/issues_spec.rb +19 -20
  382. data/spec/unit/pops/loaders/loader_spec.rb +9 -5
  383. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  384. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  385. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  386. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  387. data/spec/unit/pops/migration_spec.rb +3 -5
  388. data/spec/unit/pops/model/model_spec.rb +0 -1
  389. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  390. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  391. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  392. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  393. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  394. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  395. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  396. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  397. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  398. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  399. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  400. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  401. data/spec/unit/pops/pn_spec.rb +0 -1
  402. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  403. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  404. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  405. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  406. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  407. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  408. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  409. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  410. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  411. data/spec/unit/pops/visitor_spec.rb +0 -1
  412. data/spec/unit/property/boolean_spec.rb +1 -1
  413. data/spec/unit/property/ensure_spec.rb +0 -1
  414. data/spec/unit/property/keyvalue_spec.rb +32 -34
  415. data/spec/unit/property/list_spec.rb +26 -27
  416. data/spec/unit/property/ordered_list_spec.rb +10 -14
  417. data/spec/unit/property_spec.rb +42 -43
  418. data/spec/unit/provider/aix_object_spec.rb +47 -45
  419. data/spec/unit/provider/command_spec.rb +9 -9
  420. data/spec/unit/provider/exec/posix_spec.rb +8 -9
  421. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  422. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  423. data/spec/unit/provider/exec_spec.rb +0 -1
  424. data/spec/unit/provider/file/posix_spec.rb +22 -24
  425. data/spec/unit/provider/file/windows_spec.rb +15 -17
  426. data/spec/unit/provider/group/aix_spec.rb +3 -2
  427. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  428. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  429. data/spec/unit/provider/group/pw_spec.rb +11 -11
  430. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  431. data/spec/unit/provider/ldap_spec.rb +61 -62
  432. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  433. data/spec/unit/provider/nameservice_spec.rb +38 -40
  434. data/spec/unit/provider/package/aix_spec.rb +15 -15
  435. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  436. data/spec/unit/provider/package/apt_spec.rb +44 -27
  437. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  438. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  439. data/spec/unit/provider/package/base_spec.rb +4 -4
  440. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  441. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  442. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  443. data/spec/unit/provider/package/gem_spec.rb +51 -43
  444. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  445. data/spec/unit/provider/package/macports_spec.rb +46 -42
  446. data/spec/unit/provider/package/nim_spec.rb +30 -39
  447. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  448. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  449. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  450. data/spec/unit/provider/package/pip_spec.rb +71 -72
  451. data/spec/unit/provider/package/pkg_spec.rb +113 -114
  452. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  453. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  454. data/spec/unit/provider/package/pkgng_spec.rb +21 -22
  455. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  456. data/spec/unit/provider/package/portage_spec.rb +71 -75
  457. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  458. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  459. data/spec/unit/provider/package/sun_spec.rb +16 -18
  460. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  461. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  462. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  463. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  464. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  465. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  466. data/spec/unit/provider/package/windows_spec.rb +36 -32
  467. data/spec/unit/provider/package/yum_spec.rb +7 -7
  468. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  469. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  470. data/spec/unit/provider/service/base_spec.rb +4 -5
  471. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  472. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  473. data/spec/unit/provider/service/debian_spec.rb +38 -38
  474. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  475. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  476. data/spec/unit/provider/service/init_spec.rb +53 -52
  477. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  478. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  479. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  480. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  481. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  482. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  483. data/spec/unit/provider/service/runit_spec.rb +29 -27
  484. data/spec/unit/provider/service/smf_spec.rb +74 -66
  485. data/spec/unit/provider/service/src_spec.rb +46 -47
  486. data/spec/unit/provider/service/systemd_spec.rb +113 -122
  487. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  488. data/spec/unit/provider/service/windows_spec.rb +33 -41
  489. data/spec/unit/provider/user/aix_spec.rb +31 -31
  490. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  491. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  492. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  493. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  494. data/spec/unit/provider/user/pw_spec.rb +37 -35
  495. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  496. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  497. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  498. data/spec/unit/provider_spec.rb +35 -35
  499. data/spec/unit/puppet_pal_2pec.rb +4 -5
  500. data/spec/unit/puppet_pal_spec.rb +0 -1
  501. data/spec/unit/puppet_spec.rb +6 -7
  502. data/spec/unit/relationship_spec.rb +0 -1
  503. data/spec/unit/reports/http_spec.rb +22 -24
  504. data/spec/unit/reports/store_spec.rb +3 -4
  505. data/spec/unit/reports_spec.rb +12 -14
  506. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  507. data/spec/unit/resource/catalog_spec.rb +72 -68
  508. data/spec/unit/resource/status_spec.rb +6 -8
  509. data/spec/unit/resource/type_collection_spec.rb +17 -18
  510. data/spec/unit/resource/type_spec.rb +34 -35
  511. data/spec/unit/resource_spec.rb +36 -32
  512. data/spec/unit/rest/client_spec.rb +56 -25
  513. data/spec/unit/rest/route_spec.rb +5 -5
  514. data/spec/unit/scheduler/job_spec.rb +0 -1
  515. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  516. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  517. data/spec/unit/settings/array_setting_spec.rb +1 -1
  518. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  519. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  520. data/spec/unit/settings/config_file_spec.rb +0 -1
  521. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  522. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  523. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  524. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  525. data/spec/unit/settings/file_setting_spec.rb +44 -46
  526. data/spec/unit/settings/path_setting_spec.rb +1 -2
  527. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  528. data/spec/unit/settings/string_setting_spec.rb +14 -15
  529. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  530. data/spec/unit/settings/value_translator_spec.rb +0 -1
  531. data/spec/unit/settings_spec.rb +228 -235
  532. data/spec/unit/ssl/base_spec.rb +14 -15
  533. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  534. data/spec/unit/ssl/certificate_spec.rb +23 -25
  535. data/spec/unit/ssl/digest_spec.rb +0 -1
  536. data/spec/unit/ssl/host_spec.rb +147 -130
  537. data/spec/unit/ssl/key_spec.rb +30 -31
  538. data/spec/unit/ssl/ssl_provider_spec.rb +24 -24
  539. data/spec/unit/ssl/state_machine_spec.rb +50 -58
  540. data/spec/unit/ssl/validator_spec.rb +43 -54
  541. data/spec/unit/ssl/verifier_spec.rb +10 -10
  542. data/spec/unit/task_spec.rb +44 -45
  543. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  544. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  545. data/spec/unit/transaction/event_spec.rb +16 -15
  546. data/spec/unit/transaction/persistence_spec.rb +16 -17
  547. data/spec/unit/transaction/report_spec.rb +11 -12
  548. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  549. data/spec/unit/transaction_spec.rb +100 -101
  550. data/spec/unit/type/component_spec.rb +0 -1
  551. data/spec/unit/type/exec_spec.rb +60 -56
  552. data/spec/unit/type/file/checksum_spec.rb +9 -10
  553. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  554. data/spec/unit/type/file/content_spec.rb +58 -61
  555. data/spec/unit/type/file/ctime_spec.rb +0 -1
  556. data/spec/unit/type/file/ensure_spec.rb +12 -13
  557. data/spec/unit/type/file/group_spec.rb +5 -7
  558. data/spec/unit/type/file/mode_spec.rb +4 -6
  559. data/spec/unit/type/file/mtime_spec.rb +0 -1
  560. data/spec/unit/type/file/owner_spec.rb +6 -8
  561. data/spec/unit/type/file/selinux_spec.rb +17 -19
  562. data/spec/unit/type/file/source_spec.rb +104 -101
  563. data/spec/unit/type/file/type_spec.rb +0 -1
  564. data/spec/unit/type/file_spec.rb +195 -185
  565. data/spec/unit/type/filebucket_spec.rb +4 -5
  566. data/spec/unit/type/group_spec.rb +6 -8
  567. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  568. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  569. data/spec/unit/type/package_spec.rb +56 -57
  570. data/spec/unit/type/resources_spec.rb +72 -74
  571. data/spec/unit/type/schedule_spec.rb +24 -26
  572. data/spec/unit/type/service_spec.rb +49 -49
  573. data/spec/unit/type/stage_spec.rb +0 -1
  574. data/spec/unit/type/tidy_spec.rb +61 -62
  575. data/spec/unit/type/user_spec.rb +24 -25
  576. data/spec/unit/type/whit_spec.rb +0 -1
  577. data/spec/unit/type_spec.rb +55 -54
  578. data/spec/unit/util/at_fork_spec.rb +18 -19
  579. data/spec/unit/util/autoload_spec.rb +55 -56
  580. data/spec/unit/util/backups_spec.rb +34 -35
  581. data/spec/unit/util/character_encoding_spec.rb +5 -5
  582. data/spec/unit/util/checksums_spec.rb +38 -39
  583. data/spec/unit/util/colors_spec.rb +1 -2
  584. data/spec/unit/util/command_line_spec.rb +24 -25
  585. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  586. data/spec/unit/util/diff_spec.rb +7 -8
  587. data/spec/unit/util/errors_spec.rb +0 -1
  588. data/spec/unit/util/execution_spec.rb +185 -161
  589. data/spec/unit/util/execution_stub_spec.rb +0 -1
  590. data/spec/unit/util/feature_spec.rb +23 -14
  591. data/spec/unit/util/filetype_spec.rb +49 -49
  592. data/spec/unit/util/http_proxy_spec.rb +12 -12
  593. data/spec/unit/util/inifile_spec.rb +26 -31
  594. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  595. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  596. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  597. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  598. data/spec/unit/util/lockfile_spec.rb +0 -1
  599. data/spec/unit/util/log/destinations_spec.rb +30 -33
  600. data/spec/unit/util/log_spec.rb +35 -36
  601. data/spec/unit/util/logging_spec.rb +58 -72
  602. data/spec/unit/util/metric_spec.rb +0 -1
  603. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  604. data/spec/unit/util/multi_match_spec.rb +0 -1
  605. data/spec/unit/util/network_device/config_spec.rb +0 -1
  606. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  607. data/spec/unit/util/network_device_spec.rb +7 -9
  608. data/spec/unit/util/package_spec.rb +0 -1
  609. data/spec/unit/util/pidlock_spec.rb +21 -22
  610. data/spec/unit/util/plist_spec.rb +40 -33
  611. data/spec/unit/util/posix_spec.rb +54 -51
  612. data/spec/unit/util/rdoc_spec.rb +9 -10
  613. data/spec/unit/util/reference_spec.rb +0 -1
  614. data/spec/unit/util/resource_template_spec.rb +20 -20
  615. data/spec/unit/util/retry_action_spec.rb +7 -8
  616. data/spec/unit/util/rubygems_spec.rb +7 -8
  617. data/spec/unit/util/run_mode_spec.rb +3 -4
  618. data/spec/unit/util/selinux_spec.rb +79 -72
  619. data/spec/unit/util/splayer_spec.rb +8 -9
  620. data/spec/unit/util/ssl_spec.rb +0 -1
  621. data/spec/unit/util/storage_spec.rb +3 -4
  622. data/spec/unit/util/suidmanager_spec.rb +45 -54
  623. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  624. data/spec/unit/util/tag_set_spec.rb +0 -1
  625. data/spec/unit/util/tagging_spec.rb +0 -1
  626. data/spec/unit/util/terminal_spec.rb +9 -10
  627. data/spec/unit/util/user_attr_spec.rb +1 -2
  628. data/spec/unit/util/warnings_spec.rb +3 -4
  629. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  630. data/spec/unit/util/watcher_spec.rb +51 -21
  631. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  632. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  633. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  634. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  635. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  636. data/spec/unit/util/windows/file_spec.rb +0 -1
  637. data/spec/unit/util/windows/root_certs_spec.rb +1 -2
  638. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  639. data/spec/unit/util/windows/service_spec.rb +66 -68
  640. data/spec/unit/util/windows/sid_spec.rb +11 -13
  641. data/spec/unit/util/windows/string_spec.rb +0 -1
  642. data/spec/unit/util_spec.rb +55 -57
  643. data/spec/unit/version_spec.rb +6 -6
  644. data/spec/unit/x509/cert_provider_spec.rb +14 -14
  645. data/spec/unit/x509/pem_store_spec.rb +5 -5
  646. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  def safely_load_service_type
@@ -7,7 +6,7 @@ def safely_load_service_type
7
6
  # on jruby. Thus, we stub it out here since we don't care to do any assertions on it.
8
7
  # This is only an issue if you're running these unit tests on a platform where upstart
9
8
  # is a default provider, like Ubuntu trusty.
10
- Puppet::Util::Execution.stubs(:execute)
9
+ allow(Puppet::Util::Execution).to receive(:execute)
11
10
  Puppet::Type.type(:service)
12
11
  end
13
12
  end
@@ -46,8 +45,8 @@ describe test_title, "when validating attribute values" do
46
45
  safely_load_service_type
47
46
 
48
47
  before do
49
- @provider = stub 'provider', :class => Puppet::Type.type(:service).defaultprovider, :clear => nil, :controllable? => false
50
- Puppet::Type.type(:service).defaultprovider.stubs(:new).returns(@provider)
48
+ @provider = double('provider', :class => Puppet::Type.type(:service).defaultprovider, :clear => nil, :controllable? => false)
49
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:new).and_return(@provider)
51
50
  end
52
51
 
53
52
  it "should support :running as a value to :ensure" do
@@ -70,8 +69,9 @@ describe test_title, "when validating attribute values" do
70
69
 
71
70
  describe "the enable property" do
72
71
  before :each do
73
- @provider.class.stubs(:supports_parameter?).returns true
72
+ allow(@provider.class).to receive(:supports_parameter?).and_return(true)
74
73
  end
74
+
75
75
  it "should support :true as a value" do
76
76
  srv = Puppet::Type.type(:service).new(:name => "yay", :enable => :true)
77
77
  expect(srv.should(:enable)).to eq(:true)
@@ -88,13 +88,13 @@ describe test_title, "when validating attribute values" do
88
88
  end
89
89
 
90
90
  it "should support :manual as a value on Windows" do
91
- Puppet::Util::Platform.stubs(:windows?).returns true
91
+ allow(Puppet::Util::Platform).to receive(:windows?).and_return(true)
92
92
  srv = Puppet::Type.type(:service).new(:name => "yay", :enable => :manual)
93
93
  expect(srv.should(:enable)).to eq(:manual)
94
94
  end
95
95
 
96
96
  it "should not support :manual as a value when not on Windows" do
97
- Puppet::Util::Platform.stubs(:windows?).returns false
97
+ allow(Puppet::Util::Platform).to receive(:windows?).and_return(false)
98
98
 
99
99
  expect { Puppet::Type.type(:service).new(:name => "yay", :enable => :manual) }.to raise_error(
100
100
  Puppet::Error,
@@ -108,7 +108,7 @@ describe test_title, "when validating attribute values" do
108
108
  provider_class_with_timeout = Puppet::Type.type(:service).provide(:simple) do
109
109
  has_features :configurable_timeout
110
110
  end
111
- Puppet::Type.type(:service).stubs(:defaultprovider).returns provider_class_with_timeout
111
+ allow(Puppet::Type.type(:service)).to receive(:defaultprovider).and_return(provider_class_with_timeout)
112
112
  end
113
113
 
114
114
  it "should fail when timeout is not an integer" do
@@ -155,29 +155,29 @@ describe test_title, "when validating attribute values" do
155
155
  end
156
156
 
157
157
  it "should allow setting the :enable parameter if the provider has the :enableable feature" do
158
- Puppet::Type.type(:service).defaultprovider.stubs(:supports_parameter?).returns(true)
159
- Puppet::Type.type(:service).defaultprovider.expects(:supports_parameter?).with(Puppet::Type.type(:service).attrclass(:enable)).returns(true)
158
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:supports_parameter?).and_return(true)
159
+ expect(Puppet::Type.type(:service).defaultprovider).to receive(:supports_parameter?).with(Puppet::Type.type(:service).attrclass(:enable)).and_return(true)
160
160
  svc = Puppet::Type.type(:service).new(:name => "yay", :enable => true)
161
161
  expect(svc.should(:enable)).to eq(:true)
162
162
  end
163
163
 
164
164
  it "should not allow setting the :enable parameter if the provider is missing the :enableable feature" do
165
- Puppet::Type.type(:service).defaultprovider.stubs(:supports_parameter?).returns(true)
166
- Puppet::Type.type(:service).defaultprovider.expects(:supports_parameter?).with(Puppet::Type.type(:service).attrclass(:enable)).returns(false)
165
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:supports_parameter?).and_return(true)
166
+ expect(Puppet::Type.type(:service).defaultprovider).to receive(:supports_parameter?).with(Puppet::Type.type(:service).attrclass(:enable)).and_return(false)
167
167
  svc = Puppet::Type.type(:service).new(:name => "yay", :enable => true)
168
168
  expect(svc.should(:enable)).to be_nil
169
169
  end
170
170
 
171
171
  it "should split paths on '#{File::PATH_SEPARATOR}'" do
172
- Puppet::FileSystem.stubs(:exist?).returns(true)
173
- FileTest.stubs(:directory?).returns(true)
172
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
173
+ allow(FileTest).to receive(:directory?).and_return(true)
174
174
  svc = Puppet::Type.type(:service).new(:name => "yay", :path => "/one/two#{File::PATH_SEPARATOR}/three/four")
175
175
  expect(svc[:path]).to eq(%w{/one/two /three/four})
176
176
  end
177
177
 
178
178
  it "should accept arrays of paths joined by '#{File::PATH_SEPARATOR}'" do
179
- Puppet::FileSystem.stubs(:exist?).returns(true)
180
- FileTest.stubs(:directory?).returns(true)
179
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
180
+ allow(FileTest).to receive(:directory?).and_return(true)
181
181
  svc = Puppet::Type.type(:service).new(:name => "yay", :path => ["/one#{File::PATH_SEPARATOR}/two", "/three#{File::PATH_SEPARATOR}/four"])
182
182
  expect(svc[:path]).to eq(%w{/one /two /three /four})
183
183
  end
@@ -187,11 +187,11 @@ describe test_title, "when setting default attribute values" do
187
187
  safely_load_service_type
188
188
 
189
189
  it "should default to the provider's default path if one is available" do
190
- FileTest.stubs(:directory?).returns(true)
191
- Puppet::FileSystem.stubs(:exist?).returns(true)
190
+ allow(FileTest).to receive(:directory?).and_return(true)
191
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
192
192
 
193
- Puppet::Type.type(:service).defaultprovider.stubs(:respond_to?).returns(true)
194
- Puppet::Type.type(:service).defaultprovider.stubs(:defpath).returns("testing")
193
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:respond_to?).and_return(true)
194
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:defpath).and_return("testing")
195
195
  svc = Puppet::Type.type(:service).new(:name => "other")
196
196
  expect(svc[:path]).to eq(["testing"])
197
197
  end
@@ -207,8 +207,8 @@ describe test_title, "when setting default attribute values" do
207
207
  end
208
208
 
209
209
  it "should default 'control' to the upcased service name with periods replaced by underscores if the provider supports the 'controllable' feature" do
210
- provider = stub 'provider', :controllable? => true, :class => Puppet::Type.type(:service).defaultprovider, :clear => nil
211
- Puppet::Type.type(:service).defaultprovider.stubs(:new).returns(provider)
210
+ provider = double('provider', :controllable? => true, :class => Puppet::Type.type(:service).defaultprovider, :clear => nil)
211
+ allow(Puppet::Type.type(:service).defaultprovider).to receive(:new).and_return(provider)
212
212
  svc = Puppet::Type.type(:service).new(:name => "nfs.client")
213
213
  expect(svc[:control]).to eq("NFS_CLIENT_START")
214
214
  end
@@ -222,14 +222,14 @@ describe test_title, "when retrieving the host's current state" do
222
222
  end
223
223
 
224
224
  it "should use the provider's status to determine whether the service is running" do
225
- @service.provider.expects(:status).returns(:yepper)
225
+ expect(@service.provider).to receive(:status).and_return(:yepper)
226
226
  @service[:ensure] = :running
227
227
  expect(@service.property(:ensure).retrieve).to eq(:yepper)
228
228
  end
229
229
 
230
230
  it "should ask the provider whether it is enabled" do
231
- @service.provider.class.stubs(:supports_parameter?).returns(true)
232
- @service.provider.expects(:enabled?).returns(:yepper)
231
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
232
+ expect(@service.provider).to receive(:enabled?).and_return(:yepper)
233
233
  @service[:enable] = true
234
234
  expect(@service.property(:enable).retrieve).to eq(:yepper)
235
235
  end
@@ -244,56 +244,56 @@ describe test_title, "when changing the host" do
244
244
 
245
245
  it "should start the service if it is supposed to be running" do
246
246
  @service[:ensure] = :running
247
- @service.provider.expects(:start)
247
+ expect(@service.provider).to receive(:start)
248
248
  @service.property(:ensure).sync
249
249
  end
250
250
 
251
251
  it "should stop the service if it is supposed to be stopped" do
252
252
  @service[:ensure] = :stopped
253
- @service.provider.expects(:stop)
253
+ expect(@service.provider).to receive(:stop)
254
254
  @service.property(:ensure).sync
255
255
  end
256
256
 
257
257
  it "should enable the service if it is supposed to be enabled" do
258
- @service.provider.class.stubs(:supports_parameter?).returns(true)
258
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
259
259
  @service[:enable] = true
260
- @service.provider.expects(:enable)
260
+ expect(@service.provider).to receive(:enable)
261
261
  @service.property(:enable).sync
262
262
  end
263
263
 
264
264
  it "should disable the service if it is supposed to be disabled" do
265
- @service.provider.class.stubs(:supports_parameter?).returns(true)
265
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
266
266
  @service[:enable] = false
267
- @service.provider.expects(:disable)
267
+ expect(@service.provider).to receive(:disable)
268
268
  @service.property(:enable).sync
269
269
  end
270
270
 
271
271
  it "should always consider the enable state of a static service to be in sync" do
272
- @service.provider.class.stubs(:supports_parameter?).returns(true)
273
- @service.provider.expects(:cached_enabled?).returns('static')
272
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
273
+ expect(@service.provider).to receive(:cached_enabled?).and_return('static')
274
274
  @service[:enable] = false
275
- Puppet.expects(:debug).with("Unable to enable or disable static service yay")
275
+ expect(Puppet).to receive(:debug).with("Unable to enable or disable static service yay")
276
276
  expect(@service.property(:enable).insync?(:true)).to eq(true)
277
277
  end
278
278
 
279
279
  it "should determine insyncness normally when the service is not static" do
280
- @service.provider.class.stubs(:supports_parameter?).returns(true)
281
- @service.provider.expects(:cached_enabled?).returns('true')
280
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
281
+ expect(@service.provider).to receive(:cached_enabled?).and_return('true')
282
282
  @service[:enable] = true
283
- Puppet.expects(:debug).never
283
+ expect(Puppet).not_to receive(:debug)
284
284
  expect(@service.property(:enable).insync?(:true)).to eq(true)
285
285
  end
286
286
 
287
287
  it "should sync the service's enable state when changing the state of :ensure if :enable is being managed" do
288
- @service.provider.class.stubs(:supports_parameter?).returns(true)
288
+ allow(@service.provider.class).to receive(:supports_parameter?).and_return(true)
289
289
  @service[:enable] = false
290
290
  @service[:ensure] = :stopped
291
291
 
292
- @service.property(:enable).expects(:retrieve).returns("whatever")
293
- @service.property(:enable).expects(:insync?).returns(false)
294
- @service.property(:enable).expects(:sync)
292
+ expect(@service.property(:enable)).to receive(:retrieve).and_return("whatever")
293
+ expect(@service.property(:enable)).to receive(:insync?).and_return(false)
294
+ expect(@service.property(:enable)).to receive(:sync)
295
295
 
296
- @service.provider.stubs(:stop)
296
+ allow(@service.provider).to receive(:stop)
297
297
 
298
298
  @service.property(:ensure).sync
299
299
  end
@@ -308,27 +308,27 @@ describe test_title, "when refreshing the service" do
308
308
 
309
309
  it "should restart the service if it is running" do
310
310
  @service[:ensure] = :running
311
- @service.provider.expects(:status).returns(:running)
312
- @service.provider.expects(:restart)
311
+ expect(@service.provider).to receive(:status).and_return(:running)
312
+ expect(@service.provider).to receive(:restart)
313
313
  @service.refresh
314
314
  end
315
315
 
316
316
  it "should restart the service if it is running, even if it is supposed to stopped" do
317
317
  @service[:ensure] = :stopped
318
- @service.provider.expects(:status).returns(:running)
319
- @service.provider.expects(:restart)
318
+ expect(@service.provider).to receive(:status).and_return(:running)
319
+ expect(@service.provider).to receive(:restart)
320
320
  @service.refresh
321
321
  end
322
322
 
323
323
  it "should not restart the service if it is not running" do
324
324
  @service[:ensure] = :running
325
- @service.provider.expects(:status).returns(:stopped)
325
+ expect(@service.provider).to receive(:status).and_return(:stopped)
326
326
  @service.refresh
327
327
  end
328
328
 
329
329
  it "should add :ensure as a property if it is not being managed" do
330
- @service.provider.expects(:status).returns(:running)
331
- @service.provider.expects(:restart)
330
+ expect(@service.provider).to receive(:status).and_return(:running)
331
+ expect(@service.provider).to receive(:restart)
332
332
  @service.refresh
333
333
  end
334
334
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:stage) do
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/file_bucket/dipper'
4
3
 
@@ -9,7 +8,7 @@ describe tidy do
9
8
 
10
9
  before do
11
10
  @basepath = make_absolute("/what/ever")
12
- Puppet.settings.stubs(:use)
11
+ allow(Puppet.settings).to receive(:use)
13
12
  end
14
13
 
15
14
  context "when normalizing 'path' on windows", :if => Puppet::Util::Platform.windows? do
@@ -21,8 +20,8 @@ describe tidy do
21
20
 
22
21
  it "should use :lstat when stating a file" do
23
22
  path = '/foo/bar'
24
- stat = mock 'stat'
25
- Puppet::FileSystem.expects(:lstat).with(path).returns stat
23
+ stat = double('stat')
24
+ expect(Puppet::FileSystem).to receive(:lstat).with(path).and_return(stat)
26
25
 
27
26
  resource = tidy.new :path => path, :age => "1d"
28
27
 
@@ -135,32 +134,32 @@ describe tidy do
135
134
  describe "when tidying" do
136
135
  before do
137
136
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
138
- @stat = stub 'stat', :ftype => "directory"
137
+ @stat = double('stat', :ftype => "directory")
139
138
  lstat_is(@basepath, @stat)
140
139
  end
141
140
 
142
141
  describe "and generating files" do
143
142
  it "should set the backup on the file if backup is set on the tidy instance" do
144
143
  @tidy[:backup] = "whatever"
145
- Puppet::Type.type(:file).expects(:new).with { |args| args[:backup] == "whatever" }
144
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(backup: "whatever"))
146
145
 
147
146
  @tidy.mkfile(@basepath)
148
147
  end
149
148
 
150
149
  it "should set the file's path to the tidy's path" do
151
- Puppet::Type.type(:file).expects(:new).with { |args| args[:path] == @basepath }
150
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(path: @basepath))
152
151
 
153
152
  @tidy.mkfile(@basepath)
154
153
  end
155
154
 
156
155
  it "should configure the file for deletion" do
157
- Puppet::Type.type(:file).expects(:new).with { |args| args[:ensure] == :absent }
156
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(ensure: :absent))
158
157
 
159
158
  @tidy.mkfile(@basepath)
160
159
  end
161
160
 
162
161
  it "should force deletion on the file" do
163
- Puppet::Type.type(:file).expects(:new).with { |args| args[:force] == true }
162
+ expect(Puppet::Type.type(:file)).to receive(:new).with(hash_including(force: true))
164
163
 
165
164
  @tidy.mkfile(@basepath)
166
165
  end
@@ -174,16 +173,16 @@ describe tidy do
174
173
 
175
174
  describe "and recursion is not used" do
176
175
  it "should generate a file resource if the file should be tidied" do
177
- @tidy.expects(:tidy?).with(@basepath).returns true
176
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(true)
178
177
  file = Puppet::Type.type(:file).new(:path => @basepath+"/eh")
179
- @tidy.expects(:mkfile).with(@basepath).returns file
178
+ expect(@tidy).to receive(:mkfile).with(@basepath).and_return(file)
180
179
 
181
180
  expect(@tidy.generate).to eq([file])
182
181
  end
183
182
 
184
183
  it "should do nothing if the file should not be tidied" do
185
- @tidy.expects(:tidy?).with(@basepath).returns false
186
- @tidy.expects(:mkfile).never
184
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(false)
185
+ expect(@tidy).not_to receive(:mkfile)
187
186
 
188
187
  expect(@tidy.generate).to eq([])
189
188
  end
@@ -192,38 +191,38 @@ describe tidy do
192
191
  describe "and recursion is used" do
193
192
  before do
194
193
  @tidy[:recurse] = true
195
- Puppet::FileServing::Fileset.any_instance.stubs(:stat).returns mock("stat")
194
+ allow_any_instance_of(Puppet::FileServing::Fileset).to receive(:stat).and_return(double("stat"))
196
195
  @fileset = Puppet::FileServing::Fileset.new(@basepath)
197
- Puppet::FileServing::Fileset.stubs(:new).returns @fileset
196
+ allow(Puppet::FileServing::Fileset).to receive(:new).and_return(@fileset)
198
197
  end
199
198
 
200
199
  it "should use a Fileset for infinite recursion" do
201
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns @fileset
202
- @fileset.expects(:files).returns %w{. one two}
203
- @tidy.stubs(:tidy?).returns false
200
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(@fileset)
201
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
202
+ allow(@tidy).to receive(:tidy?).and_return(false)
204
203
 
205
204
  @tidy.generate
206
205
  end
207
206
 
208
207
  it "should use a Fileset for limited recursion" do
209
208
  @tidy[:recurse] = 42
210
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true, :recurselimit => 42).returns @fileset
211
- @fileset.expects(:files).returns %w{. one two}
212
- @tidy.stubs(:tidy?).returns false
209
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true, :recurselimit => 42).and_return(@fileset)
210
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
211
+ allow(@tidy).to receive(:tidy?).and_return(false)
213
212
 
214
213
  @tidy.generate
215
214
  end
216
215
 
217
216
  it "should generate a file resource for every file that should be tidied but not for files that should not be tidied" do
218
- @fileset.expects(:files).returns %w{. one two}
217
+ expect(@fileset).to receive(:files).and_return(%w{. one two})
219
218
 
220
- @tidy.expects(:tidy?).with(@basepath).returns true
221
- @tidy.expects(:tidy?).with(@basepath+"/one").returns true
222
- @tidy.expects(:tidy?).with(@basepath+"/two").returns false
219
+ expect(@tidy).to receive(:tidy?).with(@basepath).and_return(true)
220
+ expect(@tidy).to receive(:tidy?).with(@basepath+"/one").and_return(true)
221
+ expect(@tidy).to receive(:tidy?).with(@basepath+"/two").and_return(false)
223
222
 
224
223
  file = Puppet::Type.type(:file).new(:path => @basepath+"/eh")
225
- @tidy.expects(:mkfile).with(@basepath).returns file
226
- @tidy.expects(:mkfile).with(@basepath+"/one").returns file
224
+ expect(@tidy).to receive(:mkfile).with(@basepath).and_return(file)
225
+ expect(@tidy).to receive(:mkfile).with(@basepath+"/one").and_return(file)
227
226
 
228
227
  @tidy.generate
229
228
  end
@@ -234,7 +233,7 @@ describe tidy do
234
233
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath, :recurse => 1
235
234
  @tidy[:matches] = %w{*foo* *bar*}
236
235
 
237
- @stat = mock 'stat'
236
+ @stat = double('stat')
238
237
 
239
238
  @matcher = @tidy.parameter(:matches)
240
239
  end
@@ -258,7 +257,7 @@ describe tidy do
258
257
  describe "and determining whether a file is too old" do
259
258
  before do
260
259
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
261
- @stat = stub 'stat'
260
+ @stat = double('stat')
262
261
 
263
262
  @tidy[:age] = "1s"
264
263
  @tidy[:type] = "mtime"
@@ -267,19 +266,19 @@ describe tidy do
267
266
 
268
267
  it "should use the age type specified" do
269
268
  @tidy[:type] = :ctime
270
- @stat.expects(:ctime).returns(Time.now)
269
+ expect(@stat).to receive(:ctime).and_return(Time.now)
271
270
 
272
271
  @ager.tidy?(@basepath, @stat)
273
272
  end
274
273
 
275
274
  it "should return false if the file is more recent than the specified age" do
276
- @stat.expects(:mtime).returns(Time.now)
275
+ expect(@stat).to receive(:mtime).and_return(Time.now)
277
276
 
278
277
  expect(@ager).not_to be_tidy(@basepath, @stat)
279
278
  end
280
279
 
281
280
  it "should return true if the file is older than the specified age" do
282
- @stat.expects(:mtime).returns(Time.now - 10)
281
+ expect(@stat).to receive(:mtime).and_return(Time.now - 10)
283
282
 
284
283
  expect(@ager).to be_tidy(@basepath, @stat)
285
284
  end
@@ -288,26 +287,26 @@ describe tidy do
288
287
  describe "and determining whether a file is too large" do
289
288
  before do
290
289
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
291
- @stat = stub 'stat', :ftype => "file"
290
+ @stat = double('stat', :ftype => "file")
292
291
 
293
292
  @tidy[:size] = "1kb"
294
293
  @sizer = @tidy.parameter(:size)
295
294
  end
296
295
 
297
296
  it "should return false if the file is smaller than the specified size" do
298
- @stat.expects(:size).returns(4) # smaller than a kilobyte
297
+ expect(@stat).to receive(:size).and_return(4) # smaller than a kilobyte
299
298
 
300
299
  expect(@sizer).not_to be_tidy(@basepath, @stat)
301
300
  end
302
301
 
303
302
  it "should return true if the file is larger than the specified size" do
304
- @stat.expects(:size).returns(1500) # larger than a kilobyte
303
+ expect(@stat).to receive(:size).and_return(1500) # larger than a kilobyte
305
304
 
306
305
  expect(@sizer).to be_tidy(@basepath, @stat)
307
306
  end
308
307
 
309
308
  it "should return true if the file is equal to the specified size" do
310
- @stat.expects(:size).returns(1024)
309
+ expect(@stat).to receive(:size).and_return(1024)
311
310
 
312
311
  expect(@sizer).to be_tidy(@basepath, @stat)
313
312
  end
@@ -318,7 +317,7 @@ describe tidy do
318
317
  @tidy = Puppet::Type.type(:tidy).new :path => @basepath
319
318
  @catalog = Puppet::Resource::Catalog.new
320
319
  @tidy.catalog = @catalog
321
- @stat = stub 'stat', :ftype => "file"
320
+ @stat = double('stat', :ftype => "file")
322
321
  lstat_is(@basepath, @stat)
323
322
  end
324
323
 
@@ -343,7 +342,7 @@ describe tidy do
343
342
  end
344
343
 
345
344
  it "should not be tidied if it is a directory and rmdirs is set to false" do
346
- stat = mock 'stat', :ftype => "directory"
345
+ stat = double('stat', :ftype => "directory")
347
346
  lstat_is(@basepath, stat)
348
347
 
349
348
  expect(@tidy).not_to be_tidy(@basepath)
@@ -354,7 +353,7 @@ describe tidy do
354
353
  @tidy[:matches] = "globs"
355
354
 
356
355
  matches = @tidy.parameter(:matches)
357
- matches.expects(:tidy?).with(@basepath, @stat).returns false
356
+ expect(matches).to receive(:tidy?).with(@basepath, @stat).and_return(false)
358
357
  expect(@tidy).not_to be_tidy(@basepath)
359
358
  end
360
359
 
@@ -362,7 +361,7 @@ describe tidy do
362
361
  @tidy[:age] = "1d"
363
362
 
364
363
  ager = @tidy.parameter(:age)
365
- ager.expects(:tidy?).with(@basepath, @stat).returns false
364
+ expect(ager).to receive(:tidy?).with(@basepath, @stat).and_return(false)
366
365
  expect(@tidy).not_to be_tidy(@basepath)
367
366
  end
368
367
 
@@ -370,7 +369,7 @@ describe tidy do
370
369
  @tidy[:size] = "1b"
371
370
 
372
371
  sizer = @tidy.parameter(:size)
373
- sizer.expects(:tidy?).with(@basepath, @stat).returns false
372
+ expect(sizer).to receive(:tidy?).with(@basepath, @stat).and_return(false)
374
373
  expect(@tidy).not_to be_tidy(@basepath)
375
374
  end
376
375
 
@@ -378,8 +377,8 @@ describe tidy do
378
377
  @tidy[:size] = "1b"
379
378
  @tidy[:age] = "1d"
380
379
 
381
- @tidy.parameter(:size).stubs(:tidy?).returns true
382
- @tidy.parameter(:age).stubs(:tidy?).returns false
380
+ allow(@tidy.parameter(:size)).to receive(:tidy?).and_return(true)
381
+ allow(@tidy.parameter(:age)).to receive(:tidy?).and_return(false)
383
382
  expect(@tidy).to be_tidy(@basepath)
384
383
  end
385
384
 
@@ -387,8 +386,8 @@ describe tidy do
387
386
  @tidy[:size] = "1b"
388
387
  @tidy[:age] = "1d"
389
388
 
390
- @tidy.parameter(:size).stubs(:tidy?).returns false
391
- @tidy.parameter(:age).stubs(:tidy?).returns true
389
+ allow(@tidy.parameter(:size)).to receive(:tidy?).and_return(false)
390
+ allow(@tidy.parameter(:age)).to receive(:tidy?).and_return(true)
392
391
  expect(@tidy).to be_tidy(@basepath)
393
392
  end
394
393
 
@@ -400,10 +399,10 @@ describe tidy do
400
399
  @tidy[:recurse] = true
401
400
  @tidy[:rmdirs] = true
402
401
  fileset = Puppet::FileServing::Fileset.new(@basepath)
403
- Puppet::FileServing::Fileset.expects(:new).returns fileset
404
- fileset.expects(:files).returns %w{. one one/two}
402
+ expect(Puppet::FileServing::Fileset).to receive(:new).and_return(fileset)
403
+ expect(fileset).to receive(:files).and_return(%w{. one one/two})
405
404
 
406
- @tidy.stubs(:tidy?).returns true
405
+ allow(@tidy).to receive(:tidy?).and_return(true)
407
406
 
408
407
  expect(@tidy.generate.collect { |r| r[:path] }).to eq([@basepath+"/one/two", @basepath+"/one", @basepath])
409
408
  end
@@ -412,10 +411,10 @@ describe tidy do
412
411
  it "should configure directories to require their contained files if rmdirs is enabled, so the files will be deleted first" do
413
412
  @tidy[:recurse] = true
414
413
  @tidy[:rmdirs] = true
415
- fileset = mock 'fileset'
416
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
417
- fileset.expects(:files).returns %w{. one two one/subone two/subtwo one/subone/ssone}
418
- @tidy.stubs(:tidy?).returns true
414
+ fileset = double('fileset')
415
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
416
+ expect(fileset).to receive(:files).and_return(%w{. one two one/subone two/subtwo one/subone/ssone})
417
+ allow(@tidy).to receive(:tidy?).and_return(true)
419
418
 
420
419
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
421
420
  {
@@ -434,10 +433,10 @@ describe tidy do
434
433
  it "should configure directories to require their contained files in sorted order" do
435
434
  @tidy[:recurse] = true
436
435
  @tidy[:rmdirs] = true
437
- fileset = mock 'fileset'
438
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
439
- fileset.expects(:files).returns %w{. a a/2 a/1 a/3}
440
- @tidy.stubs(:tidy?).returns true
436
+ fileset = double('fileset')
437
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
438
+ expect(fileset).to receive(:files).and_return(%w{. a a/2 a/1 a/3})
439
+ allow(@tidy).to receive(:tidy?).and_return(true)
441
440
 
442
441
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
443
442
  expect(result[@basepath + '/a'][:require].collect{|a| a.name[('File//a/' + @basepath).length..-1]}.join()).to eq('321')
@@ -447,10 +446,10 @@ describe tidy do
447
446
  @tidy[:recurse] = true
448
447
  @tidy[:noop] = true
449
448
 
450
- fileset = mock 'fileset'
451
- Puppet::FileServing::Fileset.expects(:new).with(@basepath, :recurse => true).returns fileset
452
- fileset.expects(:files).returns %w{. a a/2 a/1 a/3}
453
- @tidy.stubs(:tidy?).returns true
449
+ fileset = double('fileset')
450
+ expect(Puppet::FileServing::Fileset).to receive(:new).with(@basepath, :recurse => true).and_return(fileset)
451
+ expect(fileset).to receive(:files).and_return(%w{. a a/2 a/1 a/3})
452
+ allow(@tidy).to receive(:tidy?).and_return(true)
454
453
 
455
454
  result = @tidy.generate.inject({}) { |hash, res| hash[res[:path]] = res; hash }
456
455
 
@@ -459,10 +458,10 @@ describe tidy do
459
458
  end
460
459
 
461
460
  def lstat_is(path, stat)
462
- Puppet::FileSystem.stubs(:lstat).with(path).returns(stat)
461
+ allow(Puppet::FileSystem).to receive(:lstat).with(path).and_return(stat)
463
462
  end
464
463
 
465
464
  def lstat_raises(path, error_class)
466
- Puppet::FileSystem.expects(:lstat).with(path).raises Errno::ENOENT
465
+ expect(Puppet::FileSystem).to receive(:lstat).with(path).and_raise(Errno::ENOENT)
467
466
  end
468
467
  end