puppet 6.23.0 → 7.0.0

data/spec/unit/face/key_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-require 'puppet/face'
-
-describe Puppet::Face[:key, '0.0.1'] do
-  it "should be deprecated" do
-    expect(subject.deprecated?).to be_truthy
-  end
-end
-

data/spec/unit/face/module/search_spec.rb

@@ -1,231 +0,0 @@
-require 'spec_helper'
-require 'puppet/face'
-require 'puppet/application/module'
-require 'puppet/module_tool'
-
-describe "puppet module search" do
-  subject { Puppet::Face[:module, :current] }
-
-  let(:options) do
-    {}
-  end
-
-  describe Puppet::Application::Module do
-    subject do
-      app = Puppet::Application::Module.new
-      allow(app).to receive(:action).and_return(Puppet::Face.find_action(:module, :search))
-      app
-    end
-
-    before do
-      subject.render_as = :console
-      allow(Puppet::Util::Terminal).to receive(:width).and_return(100)
-    end
-
-    it 'should output nothing when receiving an empty dataset' do
-      expect(subject.render({:answers => [], :result => :success}, ['apache', {}])).to eq("No results found for 'apache'.")
-    end
-
-    it 'should return error and exit when error returned' do
-      results = {
-        :result => :failure,
-        :error => {
-          :oneline => 'Something failed',
-          :multiline => 'Something failed',
-        }
-      }
-      expect { subject.render(results, ['apache', {}]) }.to raise_error 'Something failed'
-    end
-
-    it 'should output a header when receiving a non-empty dataset' do
-      results = {
-        :result => :success,
-        :answers => [
-          {'full_name' => '', 'author' => '', 'desc' => '', 'tag_list' => [] },
-        ],
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/NAME/)
-      expect(subject.render(results, ['apache', {}])).to match(/DESCRIPTION/)
-      expect(subject.render(results, ['apache', {}])).to match(/AUTHOR/)
-      expect(subject.render(results, ['apache', {}])).to match(/KEYWORDS/)
-    end
-
-    it 'should output the relevant fields when receiving a non-empty dataset' do
-      results = {
-        :result => :success,
-        :answers => [
-          {'full_name' => 'Name', 'author' => 'Author', 'desc' => 'Summary', 'tag_list' => ['tag1', 'tag2'] },
-        ]
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/Name/)
-      expect(subject.render(results, ['apache', {}])).to match(/Author/)
-      expect(subject.render(results, ['apache', {}])).to match(/Summary/)
-      expect(subject.render(results, ['apache', {}])).to match(/tag1/)
-      expect(subject.render(results, ['apache', {}])).to match(/tag2/)
-    end
-
-    it 'should mark deprecated modules in search results' do
-      results = {
-        :result => :success,
-        :answers => [
-          {'full_name' => 'puppetlabs-corosync', 'deprecated_at' => Time.new, 'author' => 'Author', 'desc' => 'Summary', 'tag_list' => ['tag1', 'tag2'] },
-        ]
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/puppetlabs-corosync.*DEPRECATED/i)
-    end
-
-    it 'should elide really long descriptions' do
-      results = {
-        :result => :success,
-        :answers => [
-          {
-            'full_name' => 'Name',
-            'author' => 'Author',
-            'desc' => 'This description is really too long to fit in a single data table, guys -- we should probably set about truncating it',
-            'tag_list' => ['tag1', 'tag2'],
-          },
-        ]
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/\.{3}  @Author/)
-    end
-
-    it 'should never truncate the module name' do
-      results = {
-        :result => :success,
-        :answers => [
-          {
-            'full_name' => 'This-module-has-a-really-really-long-name',
-            'author' => 'Author',
-            'desc' => 'Description',
-            'tag_list' => ['tag1', 'tag2'],
-          },
-        ]
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/This-module-has-a-really-really-long-name/)
-    end
-
-    it 'should never truncate the author name' do
-      results = {
-        :result => :success,
-        :answers => [
-          {
-            'full_name' => 'Name',
-            'author' => 'This-author-has-a-really-really-long-name',
-            'desc' => 'Description',
-            'tag_list' => ['tag1', 'tag2'],
-          },
-        ]
-      }
-
-      expect(subject.render(results, ['apache', {}])).to match(/@This-author-has-a-really-really-long-name/)
-    end
-
-    it 'should never remove tags that match the search term' do
-      results = {
-        :results => :success,
-        :answers => [
-          {
-            'full_name' => 'Name',
-            'author' => 'Author',
-            'desc' => 'Description',
-            'tag_list' => ['Supercalifragilisticexpialidocious'] + (1..100).map { |i| "tag#{i}" },
-          },
-        ]
-      }
-
-      expect(subject.render(results, ['Supercalifragilisticexpialidocious', {}])).to match(/Supercalifragilisticexpialidocious/)
-      expect(subject.render(results, ['Supercalifragilisticexpialidocious', {}])).not_to match(/tag/)
-    end
-
-    {
-      100 => "NAME          DESCRIPTION                                     AUTHOR         KEYWORDS#{' '*15}\n"\
-             "Name          This description is really too long to fit ...  @JohnnyApples  tag1 tag2 taggitty3#{' '*4}\n",
-
-      70  => "NAME          DESCRIPTION                 AUTHOR         KEYWORDS#{' '*5}\n"\
-             "Name          This description is rea...  @JohnnyApples  tag1 tag2#{' '*4}\n",
-
-      80  => "NAME          DESCRIPTION                        AUTHOR         KEYWORDS#{' '*8}\n"\
-             "Name          This description is really too...  @JohnnyApples  tag1 tag2#{' '*7}\n",
-
-      200 => "NAME          DESCRIPTION                                                                                                        AUTHOR         KEYWORDS#{' '*48}\n"\
-             "Name          This description is really too long to fit in a single data table, guys -- we should probably set about trunca...  @JohnnyApples  tag1 tag2 taggitty3#{' '*37}\n"
-    }.each do |width, expectation|
-      it "should resize the table to fit the screen, when #{width} columns" do
-        results = {
-          :result => :success,
-          :answers => [
-            {
-              'full_name' => 'Name',
-              'author' => 'JohnnyApples',
-              'desc' => 'This description is really too long to fit in a single data table, guys -- we should probably set about truncating it',
-              'tag_list' => ['tag1', 'tag2', 'taggitty3'],
-            },
-          ]
-        }
-
-        expect(Puppet::Util::Terminal).to receive(:width).and_return(width)
-        result = subject.render(results, ['apache', {}])
-        expect(result.lines.sort_by(&:length).last.chomp.length).to be <= width
-        expect(result).to eq(expectation)
-      end
-    end
-  end
-
-  describe "option validation" do
-    context "without any options" do
-      it "should require a search term" do
-        pattern = /wrong number of arguments/
-        expect { subject.search }.to raise_error ArgumentError, pattern
-      end
-    end
-
-    it "should accept the --module_repository option" do
-      forge = double("Puppet::Forge")
-      searcher = double("Searcher")
-      options[:module_repository] = "http://forge.example.com"
-
-      expect(Puppet::Forge).to receive(:new).with("http://forge.example.com").and_return(forge)
-      expect(Puppet::ModuleTool::Applications::Searcher).to receive(:new).with("puppetlabs-apache", forge, hash_including(options)).and_return(searcher)
-      expect(searcher).to receive(:run)
-
-      subject.search("puppetlabs-apache", options)
-    end
-  end
-
-  describe "inline documentation" do
-    subject { Puppet::Face[:module, :current].get_action :search }
-
-    its(:summary)     { should =~ /search.*module/im }
-    its(:description) { should =~ /search.*module/im }
-    its(:returns)     { should =~ /array/i }
-    its(:examples)    { should_not be_empty }
-
-    %w{ license copyright summary description returns examples }.each do |doc|
-      context "of the" do
-        its(doc.to_sym) { should_not =~ /(FIXME|REVISIT|TODO)/ }
-      end
-    end
-  end
-
-  it "should include a deprecation warning" do
-    stub_request(:get, "https://forgeapi.puppet.com/v3/modules?query=puppetlabs-apache").to_return(status: 200, body: [answers: [], result: :success])
-
-    subject.search("puppetlabs-apache")
-
-    expect(@logs).to include(an_object_having_attributes(level: :warning, message: /This action has been deprecated. Please use the Puppet Forge to search for modules./))
-  end
-
-  it "omits the warning when deprecations are disabled" do
-    stub_request(:get, "https://forgeapi.puppet.com/v3/modules?query=puppetlabs-apache").to_return(status: 200, body: [answers: [], result: :success])
-
-    Puppet[:disable_warnings] = 'deprecations'
-    subject.search("puppetlabs-apache")
-
-    expect(@logs).not_to include(an_object_having_attributes(level: :warning))
-  end
-end

data/spec/unit/face/status_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-require 'puppet/face'
-
-describe Puppet::Face[:status, '0.0.1'] do
-  it "should be deprecated" do
-    expect(subject.deprecated?).to be_truthy
-  end
-end
-

data/spec/unit/indirector/certificate/file_spec.rb

@@ -1,14 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/indirector/certificate/file'
-
-describe Puppet::SSL::Certificate::File do
-  it "should have documentation" do
-    expect(Puppet::SSL::Certificate::File.doc).to be_instance_of(String)
-  end
-
-  it "should use the :certdir as the collection directory" do
-    Puppet[:certdir] = File.expand_path("/cert/dir")
-    expect(Puppet::SSL::Certificate::File.collection_directory).to eq(Puppet[:certdir])
-  end
-end

data/spec/unit/indirector/certificate/rest_spec.rb

@@ -1,61 +0,0 @@
-require 'spec_helper'
-require 'puppet/indirector/certificate/rest'
-
-describe Puppet::SSL::Certificate::Rest do
-  before do
-    @searcher = Puppet::SSL::Certificate::Rest.new
-  end
-
-  it "should be a sublcass of Puppet::Indirector::REST" do
-    expect(Puppet::SSL::Certificate::Rest.superclass).to equal(Puppet::Indirector::REST)
-  end
-
-  it "should set server_setting to :ca_server" do
-    expect(Puppet::SSL::Certificate::Rest.server_setting).to eq(:ca_server)
-  end
-
-  it "should set port_setting to :ca_port" do
-    expect(Puppet::SSL::Certificate::Rest.port_setting).to eq(:ca_port)
-  end
-
-  it "should use the :ca SRV service" do
-    expect(Puppet::SSL::Certificate::Rest.srv_service).to eq(:ca)
-  end
-
-  it "should make sure found certificates have their names set to the search string" do
-    terminus = Puppet::SSL::Certificate::Rest.new
-
-    # This has 'boo.com' in the CN
-    cert_string = "-----BEGIN CERTIFICATE-----
-MIICPzCCAaigAwIBAgIBBDANBgkqhkiG9w0BAQUFADAWMRQwEgYDVQQDDAtidWNr
-eS5sb2NhbDAeFw0wOTA5MTcxNzI1MzJaFw0xNDA5MTYxNzI1MzJaMBIxEDAOBgNV
-BAMMB2Jvby5jb20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAKG9B+DkTCNh
-F5xHchNDfnbC9NzWKM600oxrr84pgUVAG6B2wAZcdfoEtXszhsY9Jzpwqkvxk4Mx
-AbYqo9+TCi4UoiH6e+vAKOOJD3DHrlf+/RW4hGtyaI41DBhf4+B4/oFz5PH9mvKe
-NSfHFI/yPW+1IXYjxKLQNwF9E7q3JbnzAgMBAAGjgaAwgZ0wOAYJYIZIAYb4QgEN
-BCsWKVB1cHBldCBSdWJ5L09wZW5TU0wgR2VuZXJhdGVkIENlcnRpZmljYXRlMAwG
-A1UdEwEB/wQCMAAwHQYDVR0OBBYEFJOxEUeyf4cNOBmf9zIaE1JTuNdLMAsGA1Ud
-DwQEAwIFoDAnBgNVHSUEIDAeBggrBgEFBQcDAQYIKwYBBQUHAwIGCCsGAQUFBwME
-MA0GCSqGSIb3DQEBBQUAA4GBAFTJxKprMg6tfhGnvEvURPmlJrINn9c2b5Y4AGYp
-tO86PFFkWw/EIJvvJzbj3s+Butr+eUo//+f1xxX7UCwwGqGxKqjtVS219oU/wkx8
-h7rW4Xk7MrLl0auSS1p4wLcAMm+ZImf94+j8Cj+tkr8eGozZceRV13b8+EkdaE3S
-rn/G
------END CERTIFICATE-----
-"
-
-    network = double('network')
-    allow(terminus).to receive(:network).and_return(network)
-
-    response = double('response', :code => "200", :body => cert_string)
-    allow(response).to receive(:[]).with('content-type').and_return("text/plain")
-    allow(response).to receive(:[]).with('content-encoding')
-    allow(response).to receive(:[]).with(Puppet::Network::HTTP::HEADER_PUPPET_VERSION).and_return(Puppet.version)
-    allow(network).to receive(:verify_callback=)
-    expect(network).to receive(:get).and_return(response)
-
-    request = Puppet::Indirector::Request.new(:certificate, :find, "foo.com", nil)
-    result = terminus.find(request)
-    expect(result).not_to be_nil
-    expect(result.name).to eq("foo.com")
-  end
-end

data/spec/unit/indirector/certificate_request/file_spec.rb

@@ -1,14 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/indirector/certificate_request/file'
-
-describe Puppet::SSL::CertificateRequest::File do
-  it "should have documentation" do
-    expect(Puppet::SSL::CertificateRequest::File.doc).to be_instance_of(String)
-  end
-
-  it "should use the :requestdir as the collection directory" do
-    Puppet[:requestdir] = File.expand_path("/request/dir")
-    expect(Puppet::SSL::CertificateRequest::File.collection_directory).to eq(Puppet[:requestdir])
-  end
-end

data/spec/unit/indirector/certificate_request/rest_spec.rb

@@ -1,25 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/indirector/certificate_request/rest'
-
-describe Puppet::SSL::CertificateRequest::Rest do
-  before do
-    @searcher = Puppet::SSL::CertificateRequest::Rest.new
-  end
-
-  it "should be a sublcass of Puppet::Indirector::REST" do
-    expect(Puppet::SSL::CertificateRequest::Rest.superclass).to equal(Puppet::Indirector::REST)
-  end
-
-  it "should set server_setting to :ca_server" do
-    expect(Puppet::SSL::CertificateRequest::Rest.server_setting).to eq(:ca_server)
-  end
-
-  it "should set port_setting to :ca_port" do
-    expect(Puppet::SSL::CertificateRequest::Rest.port_setting).to eq(:ca_port)
-  end
-
-  it "should use the :ca SRV service" do
-    expect(Puppet::SSL::CertificateRequest::Rest.srv_service).to eq(:ca)
-  end
-end

data/spec/unit/indirector/key/file_spec.rb

@@ -1,78 +0,0 @@
-require 'spec_helper'
-
-require 'puppet/indirector/key/file'
-
-describe Puppet::SSL::Key::File do
-  it "should have documentation" do
-    expect(Puppet::SSL::Key::File.doc).to be_instance_of(String)
-  end
-
-  it "should use the :privatekeydir as the collection directory" do
-    Puppet[:privatekeydir] = File.expand_path("/key/dir")
-    expect(Puppet::SSL::Key::File.collection_directory).to eq(Puppet[:privatekeydir])
-  end
-
-  describe "when choosing the path for the public key" do
-    it "should use the host name plus '.pem' in :publickeydir for normal hosts" do
-      Puppet[:privatekeydir] = File.expand_path("/private/key/dir")
-      Puppet[:publickeydir] = File.expand_path("/public/key/dir")
-      allow(Puppet.settings).to receive(:use)
-
-      @searcher = Puppet::SSL::Key::File.new
-      expect(@searcher.public_key_path("whatever")).to eq(File.expand_path("/public/key/dir/whatever.pem"))
-    end
-  end
-
-  describe "when managing private keys" do
-    before do
-      @searcher = Puppet::SSL::Key::File.new
-
-      @private_key_path = File.join("/fake/key/path")
-      @public_key_path = File.join("/other/fake/key/path")
-
-      allow(@searcher).to receive(:public_key_path).and_return(@public_key_path)
-      allow(@searcher).to receive(:path).and_return(@private_key_path)
-
-      allow(FileTest).to receive(:directory?).and_return(true)
-      allow(FileTest).to receive(:writable?).and_return(true)
-
-      @public_key = double('public_key')
-      @real_key = double('sslkey', :public_key => @public_key)
-
-      @key = double('key', :name => "myname", :content => @real_key)
-
-      @request = double('request', :key => "myname", :instance => @key)
-    end
-
-    it "should save the public key when saving the private key" do
-      fh = StringIO.new
-
-      expect(Puppet.settings.setting(:publickeydir)).to receive(:open_file).with(@public_key_path, 'w:ASCII').and_yield(fh)
-      allow(Puppet.settings.setting(:privatekeydir)).to receive(:open_file)
-      expect(@public_key).to receive(:to_pem).and_return("my pem")
-
-      @searcher.save(@request)
-
-      expect(fh.string).to eq("my pem")
-    end
-
-    it "should destroy the public key when destroying the private key" do
-      expect(Puppet::FileSystem).to receive(:unlink).with(Puppet::FileSystem.pathname(@private_key_path))
-      expect(Puppet::FileSystem).to receive(:exist?).with(Puppet::FileSystem.pathname(@private_key_path)).and_return(true)
-      expect(Puppet::FileSystem).to receive(:exist?).with(Puppet::FileSystem.pathname(@public_key_path)).and_return(true)
-      expect(Puppet::FileSystem).to receive(:unlink).with(Puppet::FileSystem.pathname(@public_key_path))
-
-      @searcher.destroy(@request)
-    end
-
-    it "should not fail if the public key does not exist when deleting the private key" do
-      allow(Puppet::FileSystem).to receive(:unlink).with(Puppet::FileSystem.pathname(@private_key_path))
-
-      allow(Puppet::FileSystem).to receive(:exist?).with(Puppet::FileSystem.pathname(@private_key_path)).and_return(true)
-      expect(Puppet::FileSystem).to receive(:exist?).with(Puppet::FileSystem.pathname(@public_key_path)).and_return(false)
-      expect(Puppet::FileSystem).not_to receive(:unlink).with(Puppet::FileSystem.pathname(@public_key_path))
-
-      @searcher.destroy(@request)
-    end
-  end
-end