puppet 6.16.0-x64-mingw32 → 6.20.0-x64-mingw32
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Potentially problematic release.
This version of puppet might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CODEOWNERS +2 -16
- data/Gemfile +6 -2
- data/Gemfile.lock +40 -36
- data/README.md +3 -4
- data/Rakefile +4 -12
- data/lib/puppet/agent.rb +2 -2
- data/lib/puppet/agent/locker.rb +0 -7
- data/lib/puppet/application.rb +10 -6
- data/lib/puppet/application/agent.rb +23 -6
- data/lib/puppet/application/apply.rb +20 -21
- data/lib/puppet/application/device.rb +1 -0
- data/lib/puppet/application/doc.rb +1 -1
- data/lib/puppet/application/filebucket.rb +2 -2
- data/lib/puppet/application/lookup.rb +16 -4
- data/lib/puppet/application/script.rb +1 -0
- data/lib/puppet/application_support.rb +7 -0
- data/lib/puppet/configurer.rb +70 -20
- data/lib/puppet/configurer/downloader.rb +31 -10
- data/lib/puppet/confine.rb +2 -2
- data/lib/puppet/confine/any.rb +1 -1
- data/lib/puppet/defaults.rb +113 -46
- data/lib/puppet/environments.rb +84 -59
- data/lib/puppet/face/catalog.rb +1 -1
- data/lib/puppet/face/config.rb +56 -16
- data/lib/puppet/face/epp.rb +12 -2
- data/lib/puppet/face/facts.rb +60 -0
- data/lib/puppet/face/node.rb +3 -3
- data/lib/puppet/face/node/clean.rb +2 -2
- data/lib/puppet/face/status.rb +1 -1
- data/lib/puppet/feature/base.rb +1 -1
- data/lib/puppet/ffi/posix.rb +10 -0
- data/lib/puppet/ffi/posix/constants.rb +14 -0
- data/lib/puppet/ffi/posix/functions.rb +24 -0
- data/lib/puppet/file_bucket/dipper.rb +1 -1
- data/lib/puppet/file_serving/http_metadata.rb +13 -1
- data/lib/puppet/file_serving/metadata.rb +4 -1
- data/lib/puppet/file_serving/mount/locales.rb +1 -2
- data/lib/puppet/file_serving/mount/pluginfacts.rb +1 -2
- data/lib/puppet/file_serving/mount/plugins.rb +1 -2
- data/lib/puppet/file_serving/terminus_selector.rb +7 -8
- data/lib/puppet/file_system/file_impl.rb +4 -4
- data/lib/puppet/file_system/uniquefile.rb +8 -16
- data/lib/puppet/forge.rb +1 -1
- data/lib/puppet/forge/cache.rb +1 -1
- data/lib/puppet/forge/repository.rb +3 -7
- data/lib/puppet/functions/epp.rb +1 -0
- data/lib/puppet/functions/inline_epp.rb +1 -0
- data/lib/puppet/functions/lstrip.rb +4 -4
- data/lib/puppet/functions/new.rb +8 -3
- data/lib/puppet/functions/reverse_each.rb +1 -1
- data/lib/puppet/functions/rstrip.rb +4 -4
- data/lib/puppet/functions/step.rb +1 -1
- data/lib/puppet/functions/strip.rb +4 -4
- data/lib/puppet/gettext/config.rb +5 -5
- data/lib/puppet/gettext/module_translations.rb +4 -4
- data/lib/puppet/http.rb +1 -0
- data/lib/puppet/http/client.rb +6 -1
- data/lib/puppet/http/redirector.rb +9 -7
- data/lib/puppet/http/resolver.rb +5 -8
- data/lib/puppet/http/resolver/server_list.rb +18 -36
- data/lib/puppet/http/resolver/settings.rb +4 -4
- data/lib/puppet/http/resolver/srv.rb +5 -5
- data/lib/puppet/http/response.rb +19 -0
- data/lib/puppet/http/service.rb +3 -1
- data/lib/puppet/http/service/compiler.rb +1 -1
- data/lib/puppet/http/service/file_server.rb +1 -1
- data/lib/puppet/http/service/puppetserver.rb +39 -0
- data/lib/puppet/http/session.rb +5 -4
- data/lib/puppet/indirector.rb +1 -1
- data/lib/puppet/indirector/catalog/compiler.rb +1 -1
- data/lib/puppet/indirector/exec.rb +1 -1
- data/lib/puppet/indirector/fact_search.rb +60 -0
- data/lib/puppet/indirector/facts/facter.rb +3 -3
- data/lib/puppet/indirector/facts/json.rb +27 -0
- data/lib/puppet/indirector/facts/yaml.rb +4 -59
- data/lib/puppet/indirector/file_content/rest.rb +1 -1
- data/lib/puppet/indirector/file_metadata/http.rb +25 -5
- data/lib/puppet/indirector/file_metadata/rest.rb +2 -2
- data/lib/puppet/indirector/hiera.rb +4 -0
- data/lib/puppet/indirector/indirection.rb +1 -1
- data/lib/puppet/indirector/json.rb +5 -1
- data/lib/puppet/indirector/msgpack.rb +1 -1
- data/lib/puppet/indirector/node/json.rb +8 -0
- data/lib/puppet/indirector/report/json.rb +34 -0
- data/lib/puppet/indirector/report/processor.rb +2 -2
- data/lib/puppet/indirector/request.rb +5 -5
- data/lib/puppet/indirector/yaml.rb +1 -1
- data/lib/puppet/module.rb +1 -2
- data/lib/puppet/module_tool/applications/installer.rb +48 -2
- data/lib/puppet/module_tool/errors/shared.rb +17 -2
- data/lib/puppet/network/format_support.rb +2 -2
- data/lib/puppet/network/formats.rb +2 -1
- data/lib/puppet/network/http/api/indirected_routes.rb +1 -1
- data/lib/puppet/network/http/api/master/v3/environment.rb +3 -0
- data/lib/puppet/network/http/api/master/v3/environments.rb +0 -1
- data/lib/puppet/network/http/connection_adapter.rb +6 -4
- data/lib/puppet/network/http/route.rb +2 -2
- data/lib/puppet/node/environment.rb +12 -5
- data/lib/puppet/node/facts.rb +17 -0
- data/lib/puppet/pal/pal_impl.rb +90 -13
- data/lib/puppet/parameter.rb +1 -1
- data/lib/puppet/parser/ast/leaf.rb +7 -6
- data/lib/puppet/parser/ast/pops_bridge.rb +0 -4
- data/lib/puppet/parser/compiler.rb +1 -1
- data/lib/puppet/parser/compiler/catalog_validator/env_relationship_validator.rb +2 -0
- data/lib/puppet/parser/compiler/catalog_validator/site_validator.rb +2 -0
- data/lib/puppet/parser/environment_compiler.rb +4 -1
- data/lib/puppet/parser/functions.rb +21 -17
- data/lib/puppet/parser/functions/create_resources.rb +11 -7
- data/lib/puppet/parser/resource.rb +3 -2
- data/lib/puppet/parser/resource/param.rb +6 -0
- data/lib/puppet/parser/templatewrapper.rb +1 -1
- data/lib/puppet/parser/type_loader.rb +2 -2
- data/lib/puppet/pops/adaptable.rb +7 -13
- data/lib/puppet/pops/adapters.rb +8 -4
- data/lib/puppet/pops/evaluator/collectors/abstract_collector.rb +1 -3
- data/lib/puppet/pops/evaluator/deferred_resolver.rb +5 -3
- data/lib/puppet/pops/evaluator/evaluator_impl.rb +27 -8
- data/lib/puppet/pops/evaluator/runtime3_converter.rb +2 -2
- data/lib/puppet/pops/issues.rb +5 -0
- data/lib/puppet/pops/loader/runtime3_type_loader.rb +4 -2
- data/lib/puppet/pops/loaders.rb +18 -11
- data/lib/puppet/pops/lookup/context.rb +1 -1
- data/lib/puppet/pops/lookup/hiera_config.rb +14 -1
- data/lib/puppet/pops/model/ast_transformer.rb +1 -1
- data/lib/puppet/pops/resource/resource_type_impl.rb +2 -0
- data/lib/puppet/pops/types/iterable.rb +34 -8
- data/lib/puppet/pops/types/p_meta_type.rb +1 -1
- data/lib/puppet/pops/types/p_type_set_type.rb +4 -0
- data/lib/puppet/pops/validation/checker4_0.rb +29 -15
- data/lib/puppet/pops/validation/validator_factory_4_0.rb +1 -0
- data/lib/puppet/provider/file/windows.rb +1 -1
- data/lib/puppet/provider/package/apt.rb +38 -0
- data/lib/puppet/provider/package/aptitude.rb +1 -1
- data/lib/puppet/provider/package/dpkg.rb +1 -1
- data/lib/puppet/provider/package/gem.rb +4 -2
- data/lib/puppet/provider/package/pip2.rb +17 -0
- data/lib/puppet/provider/package/puppet_gem.rb +5 -0
- data/lib/puppet/provider/package/puppetserver_gem.rb +180 -0
- data/lib/puppet/provider/package/yum.rb +2 -1
- data/lib/puppet/provider/package/zypper.rb +3 -0
- data/lib/puppet/provider/service/windows.rb +23 -7
- data/lib/puppet/provider/user/aix.rb +3 -3
- data/lib/puppet/provider/user/user_role_add.rb +1 -1
- data/lib/puppet/provider/user/useradd.rb +11 -4
- data/lib/puppet/provider/user/windows_adsi.rb +18 -1
- data/lib/puppet/reference/configuration.rb +6 -5
- data/lib/puppet/reports/http.rb +2 -0
- data/lib/puppet/resource.rb +2 -1
- data/lib/puppet/resource/type.rb +10 -1
- data/lib/puppet/rest/route.rb +2 -2
- data/lib/puppet/settings.rb +63 -21
- data/lib/puppet/settings/alias_setting.rb +37 -0
- data/lib/puppet/settings/base_setting.rb +26 -2
- data/lib/puppet/ssl/ssl_context.rb +2 -2
- data/lib/puppet/ssl/ssl_provider.rb +20 -1
- data/lib/puppet/ssl/validator/default_validator.rb +1 -1
- data/lib/puppet/test/test_helper.rb +18 -13
- data/lib/puppet/transaction.rb +2 -2
- data/lib/puppet/transaction/persistence.rb +1 -1
- data/lib/puppet/transaction/report.rb +12 -8
- data/lib/puppet/trusted_external.rb +29 -1
- data/lib/puppet/type.rb +15 -7
- data/lib/puppet/type/file.rb +40 -15
- data/lib/puppet/type/file/checksum.rb +4 -4
- data/lib/puppet/type/file/source.rb +32 -12
- data/lib/puppet/type/filebucket.rb +1 -1
- data/lib/puppet/type/notify.rb +2 -2
- data/lib/puppet/type/service.rb +53 -0
- data/lib/puppet/type/user.rb +18 -3
- data/lib/puppet/util.rb +41 -3
- data/lib/puppet/util/autoload.rb +10 -15
- data/lib/puppet/util/character_encoding.rb +9 -5
- data/lib/puppet/util/checksums.rb +19 -4
- data/lib/puppet/util/connection.rb +8 -8
- data/lib/puppet/util/execution.rb +2 -2
- data/lib/puppet/util/fact_dif.rb +62 -0
- data/lib/puppet/util/fileparsing.rb +2 -2
- data/lib/puppet/util/posix.rb +54 -5
- data/lib/puppet/util/provider_features.rb +1 -1
- data/lib/puppet/util/reference.rb +1 -1
- data/lib/puppet/util/rubygems.rb +5 -1
- data/lib/puppet/util/run_mode.rb +5 -1
- data/lib/puppet/util/windows.rb +1 -0
- data/lib/puppet/util/windows/api_types.rb +60 -33
- data/lib/puppet/util/windows/eventlog.rb +1 -6
- data/lib/puppet/util/windows/monkey_patches/dir.rb +40 -0
- data/lib/puppet/util/windows/principal.rb +8 -6
- data/lib/puppet/util/windows/registry.rb +11 -11
- data/lib/puppet/util/windows/security.rb +4 -4
- data/lib/puppet/util/windows/service.rb +43 -26
- data/lib/puppet/util/windows/user.rb +242 -8
- data/lib/puppet/version.rb +1 -1
- data/locales/puppet.pot +501 -443
- data/man/man5/puppet.conf.5 +70 -24
- data/man/man8/puppet-agent.8 +8 -5
- data/man/man8/puppet-apply.8 +2 -2
- data/man/man8/puppet-catalog.8 +1 -1
- data/man/man8/puppet-config.8 +6 -6
- data/man/man8/puppet-describe.8 +1 -1
- data/man/man8/puppet-device.8 +2 -2
- data/man/man8/puppet-doc.8 +1 -1
- data/man/man8/puppet-epp.8 +1 -1
- data/man/man8/puppet-facts.8 +32 -1
- data/man/man8/puppet-filebucket.8 +3 -3
- data/man/man8/puppet-generate.8 +1 -1
- data/man/man8/puppet-help.8 +1 -1
- data/man/man8/puppet-key.8 +1 -1
- data/man/man8/puppet-lookup.8 +2 -2
- data/man/man8/puppet-man.8 +1 -1
- data/man/man8/puppet-module.8 +1 -1
- data/man/man8/puppet-node.8 +7 -4
- data/man/man8/puppet-parser.8 +1 -1
- data/man/man8/puppet-plugin.8 +1 -1
- data/man/man8/puppet-report.8 +4 -1
- data/man/man8/puppet-resource.8 +1 -1
- data/man/man8/puppet-script.8 +2 -2
- data/man/man8/puppet-ssl.8 +1 -1
- data/man/man8/puppet-status.8 +2 -2
- data/man/man8/puppet.8 +2 -2
- data/spec/fixtures/integration/application/agent/cached_deferred_catalog.json +91 -0
- data/spec/fixtures/integration/application/apply/environments/spec/modules/amod/lib/puppet/provider/applytest/applytest.rb +2 -0
- data/spec/fixtures/integration/application/apply/environments/spec/modules/amod/lib/puppet/type/applytest.rb +25 -0
- data/spec/fixtures/unit/forge/bacula-releases.json +128 -0
- data/spec/fixtures/unit/forge/bacula.tar.gz +0 -0
- data/spec/fixtures/unit/provider/package/puppetserver_gem/gem-list-local-packages +30 -0
- data/spec/fixtures/unit/provider/user/aix/aix_passwd_file.out +4 -0
- data/spec/integration/application/agent_spec.rb +263 -54
- data/spec/integration/application/apply_spec.rb +168 -149
- data/spec/integration/application/doc_spec.rb +16 -6
- data/spec/integration/application/filebucket_spec.rb +70 -21
- data/spec/integration/application/help_spec.rb +42 -0
- data/spec/integration/application/lookup_spec.rb +13 -0
- data/spec/integration/application/module_spec.rb +68 -0
- data/spec/integration/application/plugin_spec.rb +53 -3
- data/spec/integration/configurer_spec.rb +14 -0
- data/spec/integration/data_binding_spec.rb +82 -0
- data/spec/integration/defaults_spec.rb +20 -3
- data/spec/integration/directory_environments_spec.rb +17 -17
- data/spec/integration/environments/setting_hooks_spec.rb +1 -1
- data/spec/integration/indirector/facts/facter_spec.rb +8 -6
- data/spec/integration/network/http_pool_spec.rb +26 -9
- data/spec/integration/node/environment_spec.rb +1 -1
- data/spec/integration/parser/compiler_spec.rb +11 -0
- data/spec/integration/resource/type_collection_spec.rb +2 -6
- data/spec/integration/transaction_spec.rb +4 -9
- data/spec/integration/type/file_spec.rb +1 -1
- data/spec/integration/util/execution_spec.rb +22 -0
- data/spec/integration/util/windows/adsi_spec.rb +5 -3
- data/spec/integration/util/windows/monkey_patches/dir_spec.rb +11 -0
- data/spec/integration/util/windows/process_spec.rb +26 -32
- data/spec/integration/util/windows/registry_spec.rb +7 -17
- data/spec/integration/util/windows/user_spec.rb +47 -5
- data/spec/integration/util_spec.rb +7 -33
- data/spec/lib/puppet_spec/matchers.rb +0 -80
- data/spec/lib/puppet_spec/puppetserver.rb +8 -0
- data/spec/lib/puppet_spec/settings.rb +6 -1
- data/spec/shared_contexts/types_setup.rb +2 -0
- data/spec/spec_helper.rb +1 -4
- data/spec/unit/agent_spec.rb +8 -6
- data/spec/unit/application/agent_spec.rb +3 -5
- data/spec/unit/application/config_spec.rb +224 -4
- data/spec/unit/application/doc_spec.rb +2 -2
- data/spec/unit/application/face_base_spec.rb +6 -4
- data/spec/unit/application/facts_spec.rb +41 -10
- data/spec/unit/application/filebucket_spec.rb +0 -2
- data/spec/unit/application/man_spec.rb +52 -0
- data/spec/unit/application/resource_spec.rb +3 -1
- data/spec/unit/application/ssl_spec.rb +15 -2
- data/spec/unit/application_spec.rb +60 -13
- data/spec/unit/configurer/downloader_spec.rb +10 -0
- data/spec/unit/configurer/fact_handler_spec.rb +4 -4
- data/spec/unit/configurer_spec.rb +86 -37
- data/spec/unit/confine/feature_spec.rb +1 -1
- data/spec/unit/confine_spec.rb +10 -3
- data/spec/unit/context/trusted_information_spec.rb +10 -4
- data/spec/unit/defaults_spec.rb +20 -1
- data/spec/unit/environments_spec.rb +176 -32
- data/spec/unit/face/config_spec.rb +65 -12
- data/spec/unit/face/node_spec.rb +2 -13
- data/spec/unit/file_serving/configuration/parser_spec.rb +0 -1
- data/spec/unit/file_serving/http_metadata_spec.rb +37 -14
- data/spec/unit/file_serving/metadata_spec.rb +3 -3
- data/spec/unit/file_serving/mount/locales_spec.rb +2 -2
- data/spec/unit/file_serving/mount/pluginfacts_spec.rb +2 -2
- data/spec/unit/file_serving/mount/plugins_spec.rb +2 -2
- data/spec/unit/file_serving/terminus_helper_spec.rb +11 -4
- data/spec/unit/file_serving/terminus_selector_spec.rb +45 -26
- data/spec/unit/file_system/uniquefile_spec.rb +18 -0
- data/spec/unit/file_system_spec.rb +1 -2
- data/spec/unit/forge/module_release_spec.rb +2 -7
- data/spec/unit/functions/inline_epp_spec.rb +26 -1
- data/spec/unit/http/client_spec.rb +64 -9
- data/spec/unit/http/resolver_spec.rb +24 -5
- data/spec/unit/http/response_spec.rb +6 -0
- data/spec/unit/http/service/ca_spec.rb +2 -3
- data/spec/unit/http/service/compiler_spec.rb +51 -3
- data/spec/unit/http/service/file_server_spec.rb +2 -3
- data/spec/unit/http/service/puppetserver_spec.rb +82 -0
- data/spec/unit/http/service/report_spec.rb +2 -3
- data/spec/unit/http/service_spec.rb +1 -2
- data/spec/unit/http/session_spec.rb +8 -21
- data/spec/unit/indirector/catalog/json_spec.rb +1 -1
- data/spec/unit/indirector/catalog/rest_spec.rb +1 -1
- data/spec/unit/indirector/face_spec.rb +0 -1
- data/spec/unit/indirector/facts/facter_spec.rb +0 -1
- data/spec/unit/indirector/facts/json_spec.rb +255 -0
- data/spec/unit/indirector/facts/rest_spec.rb +1 -1
- data/spec/unit/indirector/file_bucket_file/selector_spec.rb +26 -8
- data/spec/unit/indirector/file_metadata/http_spec.rb +27 -0
- data/spec/unit/indirector/indirection_spec.rb +8 -12
- data/spec/unit/indirector/json_spec.rb +8 -8
- data/spec/unit/indirector/key/file_spec.rb +0 -1
- data/spec/unit/indirector/msgpack_spec.rb +8 -8
- data/spec/unit/indirector/node/json_spec.rb +33 -0
- data/spec/unit/indirector/node/rest_spec.rb +1 -1
- data/spec/{integration/indirector/report/yaml.rb → unit/indirector/report/json_spec.rb} +13 -24
- data/spec/unit/indirector/report/yaml_spec.rb +72 -8
- data/spec/unit/indirector/request_spec.rb +5 -5
- data/spec/unit/indirector/rest_spec.rb +1 -1
- data/spec/unit/indirector/status/rest_spec.rb +1 -1
- data/spec/unit/indirector/yaml_spec.rb +7 -7
- data/spec/unit/indirector_spec.rb +2 -2
- data/spec/unit/interface_spec.rb +3 -3
- data/spec/unit/module_tool/applications/installer_spec.rb +66 -0
- data/spec/unit/module_tool/tar/mini_spec.rb +20 -0
- data/spec/unit/network/authconfig_spec.rb +0 -3
- data/spec/unit/network/format_support_spec.rb +3 -2
- data/spec/unit/network/http/api/indirected_routes_spec.rb +2 -10
- data/spec/unit/network/http/api/master/v3/environments_spec.rb +12 -23
- data/spec/unit/network/http/connection_spec.rb +42 -32
- data/spec/unit/network/http/handler_spec.rb +0 -5
- data/spec/unit/node/environment_spec.rb +18 -1
- data/spec/unit/parser/ast/block_expression_spec.rb +1 -1
- data/spec/unit/parser/compiler_spec.rb +3 -19
- data/spec/unit/parser/environment_compiler_spec.rb +7 -0
- data/spec/unit/parser/resource_spec.rb +14 -8
- data/spec/unit/parser/scope_spec.rb +1 -1
- data/spec/unit/parser/templatewrapper_spec.rb +4 -3
- data/spec/unit/pops/evaluator/deferred_resolver_spec.rb +20 -0
- data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +15 -1
- data/spec/unit/pops/loaders/loaders_spec.rb +71 -1
- data/spec/unit/pops/lookup/lookup_spec.rb +25 -0
- data/spec/unit/pops/types/type_calculator_spec.rb +1 -11
- data/spec/unit/property_spec.rb +1 -0
- data/spec/unit/provider/exec_spec.rb +4 -3
- data/spec/unit/provider/nameservice_spec.rb +66 -65
- data/spec/unit/provider/package/apt_spec.rb +76 -3
- data/spec/unit/provider/package/aptitude_spec.rb +1 -0
- data/spec/unit/provider/package/base_spec.rb +6 -5
- data/spec/unit/provider/package/dpkg_spec.rb +22 -7
- data/spec/unit/provider/package/openbsd_spec.rb +2 -0
- data/spec/unit/provider/package/pacman_spec.rb +18 -12
- data/spec/unit/provider/package/pip2_spec.rb +36 -0
- data/spec/unit/provider/package/pip_spec.rb +6 -11
- data/spec/unit/provider/package/pkgdmg_spec.rb +0 -4
- data/spec/unit/provider/package/puppet_gem_spec.rb +4 -1
- data/spec/unit/provider/package/puppetserver_gem_spec.rb +137 -0
- data/spec/unit/provider/package/yum_spec.rb +31 -0
- data/spec/unit/provider/package/zypper_spec.rb +14 -0
- data/spec/unit/provider/service/base_spec.rb +2 -4
- data/spec/unit/provider/service/bsd_spec.rb +5 -1
- data/spec/unit/provider/service/daemontools_spec.rb +1 -1
- data/spec/unit/provider/service/debian_spec.rb +3 -5
- data/spec/unit/provider/service/freebsd_spec.rb +1 -1
- data/spec/unit/provider/service/gentoo_spec.rb +4 -5
- data/spec/unit/provider/service/init_spec.rb +45 -5
- data/spec/unit/provider/service/launchd_spec.rb +5 -6
- data/spec/unit/provider/service/openrc_spec.rb +4 -5
- data/spec/unit/provider/service/openwrt_spec.rb +1 -1
- data/spec/unit/provider/service/redhat_spec.rb +1 -1
- data/spec/unit/provider/service/runit_spec.rb +2 -1
- data/spec/unit/provider/service/smf_spec.rb +1 -1
- data/spec/unit/provider/service/src_spec.rb +3 -5
- data/spec/unit/provider/service/systemd_spec.rb +3 -6
- data/spec/unit/provider/service/upstart_spec.rb +4 -5
- data/spec/unit/provider/service/windows_spec.rb +50 -14
- data/spec/unit/provider/user/aix_spec.rb +5 -0
- data/spec/unit/provider/user/hpux_spec.rb +1 -1
- data/spec/unit/provider/user/openbsd_spec.rb +1 -0
- data/spec/unit/provider/user/pw_spec.rb +2 -0
- data/spec/unit/provider/user/useradd_spec.rb +23 -16
- data/spec/unit/provider/user/windows_adsi_spec.rb +82 -0
- data/spec/unit/provider_spec.rb +8 -10
- data/spec/unit/puppet_pal_2pec.rb +40 -0
- data/spec/unit/puppet_pal_catalog_spec.rb +45 -0
- data/spec/unit/reports/store_spec.rb +17 -13
- data/spec/unit/resource/capability_finder_spec.rb +6 -1
- data/spec/unit/resource/type_spec.rb +1 -1
- data/spec/unit/resource_spec.rb +14 -13
- data/spec/unit/rest/route_spec.rb +4 -4
- data/spec/unit/settings_spec.rb +576 -239
- data/spec/unit/ssl/base_spec.rb +0 -1
- data/spec/unit/ssl/host_spec.rb +0 -5
- data/spec/unit/ssl/ssl_provider_spec.rb +82 -50
- data/spec/unit/test/test_helper_spec.rb +17 -0
- data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -7
- data/spec/unit/transaction/event_manager_spec.rb +14 -11
- data/spec/unit/transaction/persistence_spec.rb +15 -0
- data/spec/unit/transaction/report_spec.rb +3 -1
- data/spec/unit/transaction_spec.rb +13 -4
- data/spec/unit/type/file/content_spec.rb +0 -1
- data/spec/unit/type/file/selinux_spec.rb +0 -2
- data/spec/unit/type/file/source_spec.rb +4 -4
- data/spec/unit/type/file_spec.rb +122 -102
- data/spec/unit/type/filebucket_spec.rb +1 -1
- data/spec/unit/type/group_spec.rb +13 -6
- data/spec/unit/type/resources_spec.rb +7 -7
- data/spec/unit/type/service_spec.rb +210 -1
- data/spec/unit/type/tidy_spec.rb +0 -1
- data/spec/unit/type/user_spec.rb +31 -2
- data/spec/unit/type_spec.rb +52 -2
- data/spec/unit/util/at_fork_spec.rb +2 -2
- data/spec/unit/util/autoload_spec.rb +5 -1
- data/spec/unit/util/backups_spec.rb +1 -2
- data/spec/unit/util/character_encoding_spec.rb +4 -4
- data/spec/unit/util/checksums_spec.rb +16 -0
- data/spec/unit/util/command_line_spec.rb +11 -6
- data/spec/unit/util/execution_spec.rb +15 -11
- data/spec/unit/util/inifile_spec.rb +6 -14
- data/spec/unit/util/log_spec.rb +8 -7
- data/spec/unit/util/logging_spec.rb +3 -3
- data/spec/unit/util/posix_spec.rb +363 -15
- data/spec/unit/util/rubygems_spec.rb +2 -2
- data/spec/unit/util/run_mode_spec.rb +6 -6
- data/spec/unit/util/selinux_spec.rb +76 -52
- data/spec/unit/util/storage_spec.rb +3 -1
- data/spec/unit/util/suidmanager_spec.rb +44 -41
- data/spec/unit/util/windows/api_types_spec.rb +104 -40
- data/spec/unit/util/windows/service_spec.rb +4 -4
- data/spec/unit/util_spec.rb +16 -9
- data/spec/unit/x509/cert_provider_spec.rb +1 -1
- metadata +52 -53
- data/spec/integration/faces/config_spec.rb +0 -91
- data/spec/integration/faces/documentation_spec.rb +0 -57
- data/spec/integration/file_bucket/file_spec.rb +0 -50
- data/spec/integration/file_serving/content_spec.rb +0 -7
- data/spec/integration/file_serving/fileset_spec.rb +0 -12
- data/spec/integration/file_serving/metadata_spec.rb +0 -8
- data/spec/integration/file_serving/terminus_helper_spec.rb +0 -20
- data/spec/integration/file_system/uniquefile_spec.rb +0 -26
- data/spec/integration/module_tool/forge_spec.rb +0 -51
- data/spec/integration/module_tool/tar/mini_spec.rb +0 -28
- data/spec/integration/provider/service/init_spec.rb +0 -48
- data/spec/integration/provider/service/systemd_spec.rb +0 -25
- data/spec/integration/provider/service/windows_spec.rb +0 -50
- data/spec/integration/reference/providers_spec.rb +0 -21
- data/spec/integration/reports_spec.rb +0 -13
- data/spec/integration/ssl/certificate_request_spec.rb +0 -44
- data/spec/integration/ssl/host_spec.rb +0 -72
- data/spec/integration/ssl/key_spec.rb +0 -99
- data/spec/integration/test/test_helper_spec.rb +0 -31
- data/spec/shared_behaviours/file_serving_model.rb +0 -51
- data/spec/unit/face/catalog_spec.rb +0 -6
- data/spec/unit/face/man_spec.rb +0 -25
- data/spec/unit/face/module_spec.rb +0 -3
- data/spec/unit/man_spec.rb +0 -31
| @@ -152,6 +152,9 @@ describe Puppet::Transaction::EventManager do | |
| 152 152 |  | 
| 153 153 | 
             
                  @resource = Puppet::Type.type(:file).new :path => make_absolute("/my/file")
         | 
| 154 154 | 
             
                  @event = Puppet::Transaction::Event.new(:name => :event, :resource => @resource)
         | 
| 155 | 
            +
             | 
| 156 | 
            +
                  @resource.class.send(:define_method, :callback1) {}
         | 
| 157 | 
            +
                  @resource.class.send(:define_method, :callback2) {}
         | 
| 155 158 | 
             
                end
         | 
| 156 159 |  | 
| 157 160 | 
             
                it "should call the required callback once for each set of associated events" do
         | 
| @@ -178,7 +181,7 @@ describe Puppet::Transaction::EventManager do | |
| 178 181 |  | 
| 179 182 | 
             
                  allow(@resource).to receive(:callback1)
         | 
| 180 183 |  | 
| 181 | 
            -
                  @manager.process_events(@resource) | 
| 184 | 
            +
                  @manager.process_events(@resource)
         | 
| 182 185 |  | 
| 183 186 | 
             
                  expect(@transaction.resource_status(@resource).events.length).to eq(1)
         | 
| 184 187 | 
             
                end
         | 
| @@ -211,9 +214,11 @@ describe Puppet::Transaction::EventManager do | |
| 211 214 | 
             
                    @event2 = Puppet::Transaction::Event.new(:name => :event, :resource => @resource)
         | 
| 212 215 | 
             
                    @event2.status = "success"
         | 
| 213 216 | 
             
                    expect(@manager).to receive(:queued_events).with(@resource).and_yield(:callback1, [@event, @event2])
         | 
| 217 | 
            +
                    @resource.class.send(:define_method, :callback1) {}
         | 
| 214 218 | 
             
                  end
         | 
| 215 219 |  | 
| 216 220 | 
             
                  it "should call the callback" do
         | 
| 221 | 
            +
             | 
| 217 222 | 
             
                    expect(@resource).to receive(:callback1)
         | 
| 218 223 |  | 
| 219 224 | 
             
                    @manager.process_events(@resource)
         | 
| @@ -225,6 +230,7 @@ describe Puppet::Transaction::EventManager do | |
| 225 230 | 
             
                    allow(@event).to receive(:status).and_return("noop")
         | 
| 226 231 | 
             
                    allow(@resource).to receive(:event).and_return(Puppet::Transaction::Event.new)
         | 
| 227 232 | 
             
                    expect(@manager).to receive(:queued_events).with(@resource).and_yield(:callback1, [@event])
         | 
| 233 | 
            +
                    @resource.class.send(:define_method, :callback1) {}
         | 
| 228 234 | 
             
                  end
         | 
| 229 235 |  | 
| 230 236 | 
             
                  it "should log" do
         | 
| @@ -254,6 +260,7 @@ describe Puppet::Transaction::EventManager do | |
| 254 260 | 
             
                    allow(@resource).to receive(:event).and_return(Puppet::Transaction::Event.new)
         | 
| 255 261 | 
             
                    allow(@resource).to receive(:noop?).and_return(true)
         | 
| 256 262 | 
             
                    expect(@manager).to receive(:queued_events).with(@resource).and_yield(:callback1, [@event])
         | 
| 263 | 
            +
                    @resource.class.send(:define_method, :callback1) {}
         | 
| 257 264 | 
             
                  end
         | 
| 258 265 |  | 
| 259 266 | 
             
                  it "should log" do
         | 
| @@ -279,7 +286,7 @@ describe Puppet::Transaction::EventManager do | |
| 279 286 |  | 
| 280 287 | 
             
                describe "and the callback fails" do
         | 
| 281 288 | 
             
                  before do
         | 
| 282 | 
            -
                     | 
| 289 | 
            +
                    @resource.class.send(:define_method, :callback1) { raise "a failure" }
         | 
| 283 290 |  | 
| 284 291 | 
             
                    expect(@manager).to receive(:queued_events).and_yield(:callback1, [@event])
         | 
| 285 292 | 
             
                  end
         | 
| @@ -323,16 +330,12 @@ describe Puppet::Transaction::EventManager do | |
| 323 330 |  | 
| 324 331 | 
             
              describe "when queueing then processing events for a given resource" do
         | 
| 325 332 | 
             
                before do
         | 
| 326 | 
            -
                  @ | 
| 327 | 
            -
                  @ | 
| 333 | 
            +
                  @catalog = Puppet::Resource::Catalog.new
         | 
| 334 | 
            +
                  @target = Puppet::Type.type(:exec).new(name: 'target', path: ENV['PATH'])
         | 
| 335 | 
            +
                  @resource = Puppet::Type.type(:exec).new(name: 'resource', path: ENV['PATH'], notify: @target)
         | 
| 336 | 
            +
                  @catalog.add_resource(@resource, @target)
         | 
| 328 337 |  | 
| 329 | 
            -
                  @ | 
| 330 | 
            -
                  @target = Puppet::Type.type(:file).new :path => make_absolute("/your/file")
         | 
| 331 | 
            -
             | 
| 332 | 
            -
                  @graph = allow('graph')
         | 
| 333 | 
            -
                  allow(@graph).to receive(:matching_edges).and_return([])
         | 
| 334 | 
            -
                  allow(@graph).to receive(:matching_edges).with(anything, @resource).and_return([double('edge', :target => @target, :callback => :refresh)])
         | 
| 335 | 
            -
                  allow(@manager).to receive(:relationship_graph).and_return(@graph)
         | 
| 338 | 
            +
                  @manager = Puppet::Transaction::EventManager.new(Puppet::Transaction.new(@catalog, nil, nil))
         | 
| 336 339 |  | 
| 337 340 | 
             
                  @event  = Puppet::Transaction::Event.new(:name => :notify, :resource => @target)
         | 
| 338 341 | 
             
                  @event2 = Puppet::Transaction::Event.new(:name => :service_start, :resource => @target, :invalidate_refreshes => true)
         | 
| @@ -123,6 +123,21 @@ describe Puppet::Transaction::Persistence do | |
| 123 123 | 
             
                    persistence = Puppet::Transaction::Persistence.new
         | 
| 124 124 | 
             
                    persistence.load
         | 
| 125 125 | 
             
                  end
         | 
| 126 | 
            +
             | 
| 127 | 
            +
                  it 'should load Time and Symbols' do
         | 
| 128 | 
            +
                    write_state_file(<<~END)
         | 
| 129 | 
            +
                      File[/tmp/audit]:
         | 
| 130 | 
            +
                        parameters:
         | 
| 131 | 
            +
                          mtime:
         | 
| 132 | 
            +
                            system_value:
         | 
| 133 | 
            +
                              - 2020-07-15 05:38:12.427678398 +00:00
         | 
| 134 | 
            +
                          ensure:
         | 
| 135 | 
            +
                            system_value:
         | 
| 136 | 
            +
                    END
         | 
| 137 | 
            +
             | 
| 138 | 
            +
                    persistence = Puppet::Transaction::Persistence.new
         | 
| 139 | 
            +
                    expect(persistence.load.dig("File[/tmp/audit]", "parameters", "mtime", "system_value")).to contain_exactly(be_a(Time))
         | 
| 140 | 
            +
                  end
         | 
| 126 141 | 
             
                end
         | 
| 127 142 | 
             
              end
         | 
| 128 143 |  | 
| @@ -663,7 +663,7 @@ Version: | |
| 663 663 | 
             
                  :status => stringifier.convert('success'),
         | 
| 664 664 | 
             
                }
         | 
| 665 665 |  | 
| 666 | 
            -
                event = Puppet::Transaction::Event.new(event_hash)
         | 
| 666 | 
            +
                event = Puppet::Transaction::Event.new(**event_hash)
         | 
| 667 667 |  | 
| 668 668 | 
             
                status = Puppet::Resource::Status.new(Puppet::Type.type(:notify).new(:title => "a resource"))
         | 
| 669 669 | 
             
                status.changed = true
         | 
| @@ -676,6 +676,7 @@ Version: | |
| 676 676 | 
             
                report.catalog_uuid = "some catalog uuid"
         | 
| 677 677 | 
             
                report.cached_catalog_status = "not_used"
         | 
| 678 678 | 
             
                report.master_used = "test:000"
         | 
| 679 | 
            +
                report.server_used = "test:000"
         | 
| 679 680 | 
             
                report.add_resource_status(status)
         | 
| 680 681 | 
             
                report.transaction_completed = true
         | 
| 681 682 | 
             
                report.finalize_report
         | 
| @@ -694,6 +695,7 @@ Version: | |
| 694 695 | 
             
                report.catalog_uuid = "some catalog uuid"
         | 
| 695 696 | 
             
                report.cached_catalog_status = "not_used"
         | 
| 696 697 | 
             
                report.master_used = "test:000"
         | 
| 698 | 
            +
                report.server_used = "test:000"
         | 
| 697 699 | 
             
                report.add_resource_status(status)
         | 
| 698 700 | 
             
                report.transaction_completed = true
         | 
| 699 701 | 
             
                report.finalize_report
         | 
| @@ -5,6 +5,13 @@ require 'puppet_spec/compiler' | |
| 5 5 | 
             
            require 'puppet/transaction'
         | 
| 6 6 | 
             
            require 'fileutils'
         | 
| 7 7 |  | 
| 8 | 
            +
            Puppet::Type.newtype(:generator) do
         | 
| 9 | 
            +
              newparam(:name) { isnamevar }
         | 
| 10 | 
            +
             | 
| 11 | 
            +
              def generate
         | 
| 12 | 
            +
              end
         | 
| 13 | 
            +
            end
         | 
| 14 | 
            +
             | 
| 8 15 | 
             
            describe Puppet::Transaction do
         | 
| 9 16 | 
             
              include PuppetSpec::Files
         | 
| 10 17 | 
             
              include PuppetSpec::Compiler
         | 
| @@ -323,9 +330,9 @@ describe Puppet::Transaction do | |
| 323 330 | 
             
              describe "when generating resources before traversal" do
         | 
| 324 331 | 
             
                let(:catalog) { Puppet::Resource::Catalog.new }
         | 
| 325 332 | 
             
                let(:transaction) { Puppet::Transaction.new(catalog, nil, Puppet::Graph::SequentialPrioritizer.new) }
         | 
| 326 | 
            -
                let(:generator) { Puppet::Type.type(: | 
| 333 | 
            +
                let(:generator) { Puppet::Type.type(:generator).new :title => "generator" }
         | 
| 327 334 | 
             
                let(:generated) do
         | 
| 328 | 
            -
                  %w[a b c].map { |name| Puppet::Type.type(: | 
| 335 | 
            +
                  %w[a b c].map { |name| Puppet::Type.type(:generator).new(:name => name) }
         | 
| 329 336 | 
             
                end
         | 
| 330 337 |  | 
| 331 338 | 
             
                before :each do
         | 
| @@ -666,7 +673,7 @@ describe Puppet::Transaction do | |
| 666 673 | 
             
                    end
         | 
| 667 674 |  | 
| 668 675 | 
             
                    describe "and new resources are generated" do
         | 
| 669 | 
            -
                      let(:generator) { Puppet::Type.type(: | 
| 676 | 
            +
                      let(:generator) { Puppet::Type.type(:generator).new :title => "generator" }
         | 
| 670 677 | 
             
                      let(:generated) do
         | 
| 671 678 | 
             
                        %w[a b c].map { |name| Puppet::Type.type(:package).new :title => "foo", :name => name, :provider => :apt }
         | 
| 672 679 | 
             
                      end
         | 
| @@ -785,6 +792,9 @@ describe Puppet::Transaction do | |
| 785 792 | 
             
                      def self.is_selinux_enabled
         | 
| 786 793 | 
             
                        true
         | 
| 787 794 | 
             
                      end
         | 
| 795 | 
            +
             | 
| 796 | 
            +
                      def self.matchpathcon_fini
         | 
| 797 | 
            +
                      end
         | 
| 788 798 | 
             
                    end
         | 
| 789 799 | 
             
                  end
         | 
| 790 800 |  | 
| @@ -828,7 +838,6 @@ describe Puppet::Transaction do | |
| 828 838 | 
             
                  before do
         | 
| 829 839 | 
             
                    @resource = Puppet::Type.type(:notify).new :title => "foobar"
         | 
| 830 840 | 
             
                    @catalog.add_resource @resource
         | 
| 831 | 
            -
                    allow(@transaction).to receive(:add_dynamically_generated_resources)
         | 
| 832 841 | 
             
                  end
         | 
| 833 842 |  | 
| 834 843 | 
             
                  it 'should stop processing if :stop_processing? is true' do
         | 
| @@ -11,7 +11,6 @@ describe Puppet::Type.type(:file).attrclass(:content), :uses_checksums => true d | |
| 11 11 |  | 
| 12 12 | 
             
              before do
         | 
| 13 13 | 
             
                File.open(filename, 'w') {|f| f.write "initial file content"}
         | 
| 14 | 
            -
                allow(described_class).to receive(:standalone?).and_return(false)
         | 
| 15 14 | 
             
              end
         | 
| 16 15 |  | 
| 17 16 | 
             
              around do |example|
         | 
| @@ -9,8 +9,6 @@ require 'spec_helper' | |
| 9 9 | 
             
                  @path = make_absolute("/my/file")
         | 
| 10 10 | 
             
                  @resource = Puppet::Type.type(:file).new :path => @path
         | 
| 11 11 | 
             
                  @sel = property.new :resource => @resource
         | 
| 12 | 
            -
                  allow(@sel).to receive(:normalize_selinux_category).with("s0").and_return("s0")
         | 
| 13 | 
            -
                  allow(@sel).to receive(:normalize_selinux_category).with(nil).and_return(nil)
         | 
| 14 12 | 
             
                end
         | 
| 15 13 |  | 
| 16 14 | 
             
                it "retrieve on #{param} should return :absent if the file isn't statable" do
         | 
| @@ -22,8 +22,8 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do | |
| 22 22 | 
             
                @foobar = make_absolute("/foo/bar baz")
         | 
| 23 23 | 
             
                @feebooz = make_absolute("/fee/booz baz")
         | 
| 24 24 |  | 
| 25 | 
            -
                @foobar_uri  =  | 
| 26 | 
            -
                @feebooz_uri =  | 
| 25 | 
            +
                @foobar_uri  = Puppet::Util.uri_unescape(Puppet::Util.path_to_uri(@foobar).to_s)
         | 
| 26 | 
            +
                @feebooz_uri = Puppet::Util.uri_unescape(Puppet::Util.path_to_uri(@feebooz).to_s)
         | 
| 27 27 | 
             
              end
         | 
| 28 28 |  | 
| 29 29 | 
             
              it "should be a subclass of Parameter" do
         | 
| @@ -82,7 +82,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do | |
| 82 82 | 
             
              describe "#munge" do
         | 
| 83 83 | 
             
                it "should prefix file scheme to absolute paths" do
         | 
| 84 84 | 
             
                  resource[:source] = filename
         | 
| 85 | 
            -
                  expect(resource[:source]).to eq([ | 
| 85 | 
            +
                  expect(resource[:source]).to eq([Puppet::Util.uri_unescape(Puppet::Util.path_to_uri(filename).to_s)])
         | 
| 86 86 | 
             
                end
         | 
| 87 87 |  | 
| 88 88 | 
             
                %w[file puppet].each do |scheme|
         | 
| @@ -521,7 +521,7 @@ describe Puppet::Type.type(:file).attrclass(:source), :uses_checksums => true do | |
| 521 521 | 
             
                        end
         | 
| 522 522 |  | 
| 523 523 | 
             
                        it "should return the default source port" do
         | 
| 524 | 
            -
                          Puppet[: | 
| 524 | 
            +
                          Puppet[:serverport] = 1234
         | 
| 525 525 | 
             
                          expect(resource.parameter(:source).port).to eq(1234)
         | 
| 526 526 | 
             
                        end
         | 
| 527 527 | 
             
                      end
         | 
    
        data/spec/unit/type/file_spec.rb
    CHANGED
    
    | @@ -3,6 +3,34 @@ require 'spec_helper' | |
| 3 3 | 
             
            describe Puppet::Type.type(:file) do
         | 
| 4 4 | 
             
              include PuppetSpec::Files
         | 
| 5 5 |  | 
| 6 | 
            +
              # precomputed checksum values for FILE_CONTENT
         | 
| 7 | 
            +
              FILE_CONTENT = 'file content'.freeze
         | 
| 8 | 
            +
              CHECKSUM_VALUES = {
         | 
| 9 | 
            +
                md5: 'd10b4c3ff123b26dc068d43a8bef2d23',
         | 
| 10 | 
            +
                md5lite: 'd10b4c3ff123b26dc068d43a8bef2d23',
         | 
| 11 | 
            +
                sha256: 'e0ac3601005dfa1864f5392aabaf7d898b1b5bab854f1acb4491bcd806b76b0c',
         | 
| 12 | 
            +
                sha256lite: 'e0ac3601005dfa1864f5392aabaf7d898b1b5bab854f1acb4491bcd806b76b0c',
         | 
| 13 | 
            +
                sha1: '87758871f598e1a3b4679953589ae2f57a0bb43c',
         | 
| 14 | 
            +
                sha1lite: '87758871f598e1a3b4679953589ae2f57a0bb43c',
         | 
| 15 | 
            +
                sha224: '2aefaaa5f4d8f17f82f3e1bb407e190cede9aa1311fa4533ce505531',
         | 
| 16 | 
            +
                sha384: '61c7783501ebd90233650357fefbe5a141b7618f907b8f043bbaa92c0f610c785a641ddd479fa81d650cd86e29aa6858',
         | 
| 17 | 
            +
                sha512: '2fb1877301854ac92dd518018f97407a0a88bb696bfef0a51e9efbd39917353500009e15bd72c3f0e4bf690115870bfab926565d5ad97269d922dbbb41261221',
         | 
| 18 | 
            +
                mtime: 'Jan 26 13:59:49 2016',
         | 
| 19 | 
            +
                ctime: 'Jan 26 13:59:49 2016'
         | 
| 20 | 
            +
              }.freeze
         | 
| 21 | 
            +
             | 
| 22 | 
            +
              INVALID_CHECKSUM_VALUES = {
         | 
| 23 | 
            +
                md5: '00000000000000000000000000000000',
         | 
| 24 | 
            +
                md5lite: '00000000000000000000000000000000',
         | 
| 25 | 
            +
                sha256: '0000000000000000000000000000000000000000000000000000000000000000',
         | 
| 26 | 
            +
                sha256lite: '0000000000000000000000000000000000000000000000000000000000000000',
         | 
| 27 | 
            +
                sha1: '0000000000000000000000000000000000000000',
         | 
| 28 | 
            +
                sha1lite: '0000000000000000000000000000000000000000',
         | 
| 29 | 
            +
                sha224: '00000000000000000000000000000000000000000000000000000000',
         | 
| 30 | 
            +
                sha384: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
         | 
| 31 | 
            +
                sha512: '00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'
         | 
| 32 | 
            +
              }.freeze
         | 
| 33 | 
            +
             | 
| 6 34 | 
             
              let(:path) { tmpfile('file_testing') }
         | 
| 7 35 | 
             
              let(:file) { described_class.new(:path => path, :catalog => catalog) }
         | 
| 8 36 | 
             
              let(:provider) { file.provider }
         | 
| @@ -316,12 +344,6 @@ describe Puppet::Type.type(:file) do | |
| 316 344 | 
             
              end
         | 
| 317 345 |  | 
| 318 346 | 
             
              describe "#flush" do
         | 
| 319 | 
            -
                it "should flush all properties that respond to :flush" do
         | 
| 320 | 
            -
                  file[:source] = File.expand_path(__FILE__)
         | 
| 321 | 
            -
                  expect(file.parameter(:source)).to receive(:flush)
         | 
| 322 | 
            -
                  file.flush
         | 
| 323 | 
            -
                end
         | 
| 324 | 
            -
             | 
| 325 347 | 
             
                it "should reset its stat reference" do
         | 
| 326 348 | 
             
                  FileUtils.touch(path)
         | 
| 327 349 | 
             
                  stat1 = file.stat
         | 
| @@ -791,7 +813,7 @@ describe Puppet::Type.type(:file) do | |
| 791 813 | 
             
                  let(:sources) do
         | 
| 792 814 | 
             
                    h = {}
         | 
| 793 815 | 
             
                    %w{/a /b /c /d}.each do |key|
         | 
| 794 | 
            -
                      h[key] =  | 
| 816 | 
            +
                      h[key] = Puppet::Util.uri_unescape(Puppet::Util.path_to_uri(File.expand_path(key)).to_s)
         | 
| 795 817 | 
             
                    end
         | 
| 796 818 | 
             
                    h
         | 
| 797 819 | 
             
                  end
         | 
| @@ -1108,38 +1130,6 @@ describe Puppet::Type.type(:file) do | |
| 1108 1130 | 
             
              end
         | 
| 1109 1131 |  | 
| 1110 1132 | 
             
              describe "#write" do
         | 
| 1111 | 
            -
                describe "when validating the checksum" do
         | 
| 1112 | 
            -
                  before { allow(file).to receive(:validate_checksum?).and_return(true) }
         | 
| 1113 | 
            -
             | 
| 1114 | 
            -
                  it "should fail if the checksum parameter and content checksums do not match" do
         | 
| 1115 | 
            -
                    checksum = double('checksum_parameter',  :sum => 'checksum_b', :sum_file => 'checksum_b')
         | 
| 1116 | 
            -
                    allow(file).to receive(:parameter).with(:checksum).and_return(checksum)
         | 
| 1117 | 
            -
                    allow(file).to receive(:parameter).with(:source).and_return(nil)
         | 
| 1118 | 
            -
             | 
| 1119 | 
            -
             | 
| 1120 | 
            -
                    property = double('content_property', :actual_content => "something", :length => "something".length, :write => 'checksum_a')
         | 
| 1121 | 
            -
                    allow(file).to receive(:property).with(:content).and_return(property)
         | 
| 1122 | 
            -
             | 
| 1123 | 
            -
                    expect { file.write property }.to raise_error(Puppet::Error) end
         | 
| 1124 | 
            -
                end
         | 
| 1125 | 
            -
             | 
| 1126 | 
            -
                describe "when not validating the checksum" do
         | 
| 1127 | 
            -
                  before do
         | 
| 1128 | 
            -
                    allow(file).to receive(:validate_checksum?).and_return(false)
         | 
| 1129 | 
            -
                  end
         | 
| 1130 | 
            -
             | 
| 1131 | 
            -
                  it "should not fail if the checksum property and content checksums do not match" do
         | 
| 1132 | 
            -
                    checksum = double('checksum_parameter',  :sum => 'checksum_b')
         | 
| 1133 | 
            -
                    allow(file).to receive(:parameter).with(:checksum).and_return(checksum)
         | 
| 1134 | 
            -
                    allow(file).to receive(:parameter).with(:source).and_return(nil)
         | 
| 1135 | 
            -
             | 
| 1136 | 
            -
                    property = double('content_property', :actual_content => "something", :length => "something".length, :write => 'checksum_a')
         | 
| 1137 | 
            -
                    allow(file).to receive(:property).with(:content).and_return(property)
         | 
| 1138 | 
            -
             | 
| 1139 | 
            -
                    expect { file.write property }.to_not raise_error
         | 
| 1140 | 
            -
                  end
         | 
| 1141 | 
            -
                end
         | 
| 1142 | 
            -
             | 
| 1143 1133 | 
             
                describe "when resource mode is supplied" do
         | 
| 1144 1134 | 
             
                  before do
         | 
| 1145 1135 | 
             
                    allow(file).to receive(:property_fix)
         | 
| @@ -1191,7 +1181,7 @@ describe Puppet::Type.type(:file) do | |
| 1191 1181 | 
             
                describe "when resource mode is not supplied" do
         | 
| 1192 1182 | 
             
                  context "and content is supplied" do
         | 
| 1193 1183 | 
             
                    it "should default to 0644 mode" do
         | 
| 1194 | 
            -
                      file = described_class.new(:path => path, :content =>  | 
| 1184 | 
            +
                      file = described_class.new(:path => path, :content => FILE_CONTENT)
         | 
| 1195 1185 |  | 
| 1196 1186 | 
             
                      file.write file.parameter(:content)
         | 
| 1197 1187 |  | 
| @@ -1214,35 +1204,6 @@ describe Puppet::Type.type(:file) do | |
| 1214 1204 | 
             
                end
         | 
| 1215 1205 | 
             
              end
         | 
| 1216 1206 |  | 
| 1217 | 
            -
              describe "#fail_if_checksum_is_wrong" do
         | 
| 1218 | 
            -
                it "should fail if the checksum of the file doesn't match the expected one" do
         | 
| 1219 | 
            -
                  expect do
         | 
| 1220 | 
            -
                    allow(file.parameter(:checksum)).to receive(:sum_file).and_return('wrong!!')
         | 
| 1221 | 
            -
                    file.instance_eval do
         | 
| 1222 | 
            -
                      fail_if_checksum_is_wrong(self[:path], 'anything!')
         | 
| 1223 | 
            -
                    end
         | 
| 1224 | 
            -
                  end.to raise_error(Puppet::Error, /File written to disk did not match checksum/)
         | 
| 1225 | 
            -
                end
         | 
| 1226 | 
            -
             | 
| 1227 | 
            -
                it "should not fail if the checksum is correct" do
         | 
| 1228 | 
            -
                  expect do
         | 
| 1229 | 
            -
                    allow(file.parameter(:checksum)).to receive(:sum_file).and_return('anything!')
         | 
| 1230 | 
            -
                    file.instance_eval do
         | 
| 1231 | 
            -
                      fail_if_checksum_is_wrong(self[:path], 'anything!')
         | 
| 1232 | 
            -
                    end
         | 
| 1233 | 
            -
                  end.not_to raise_error
         | 
| 1234 | 
            -
                end
         | 
| 1235 | 
            -
             | 
| 1236 | 
            -
                it "should not fail if the checksum is absent" do
         | 
| 1237 | 
            -
                  expect do
         | 
| 1238 | 
            -
                    allow(file.parameter(:checksum)).to receive(:sum_file).and_return(nil)
         | 
| 1239 | 
            -
                    file.instance_eval do
         | 
| 1240 | 
            -
                      fail_if_checksum_is_wrong(self[:path], 'anything!')
         | 
| 1241 | 
            -
                    end
         | 
| 1242 | 
            -
                  end.not_to raise_error
         | 
| 1243 | 
            -
                end
         | 
| 1244 | 
            -
              end
         | 
| 1245 | 
            -
             | 
| 1246 1207 | 
             
              describe "#write_temporary_file?" do
         | 
| 1247 1208 | 
             
                it "should be true if the file has specified content" do
         | 
| 1248 1209 | 
             
                  file[:content] = 'some content'
         | 
| @@ -1462,7 +1423,7 @@ describe Puppet::Type.type(:file) do | |
| 1462 1423 | 
             
                  expect(Puppet::FileServing::Metadata.indirection).to receive(:find).with(source, anything).and_return(metadata)
         | 
| 1463 1424 |  | 
| 1464 1425 | 
             
                  uri = file.parameters[:source].uri
         | 
| 1465 | 
            -
                  expect( | 
| 1426 | 
            +
                  expect(Puppet::Util.uri_unescape(uri.path)).to eq(filename)
         | 
| 1466 1427 | 
             
                  expect(uri.path.encoding).to eq(Encoding::UTF_8)
         | 
| 1467 1428 | 
             
                end
         | 
| 1468 1429 |  | 
| @@ -1486,29 +1447,16 @@ describe Puppet::Type.type(:file) do | |
| 1486 1447 | 
             
                  expect_any_instance_of(Puppet::Indirector::FileMetadata::Rest).to receive(:find).with(request_key(filename[1..-1])).and_return(metadata)
         | 
| 1487 1448 |  | 
| 1488 1449 | 
             
                  uri = file.parameters[:source].uri
         | 
| 1489 | 
            -
                  expect( | 
| 1450 | 
            +
                  expect(Puppet::Util.uri_unescape(uri.path)).to eq(filename)
         | 
| 1490 1451 | 
             
                  expect(uri.path.encoding).to eq(Encoding::UTF_8)
         | 
| 1491 1452 | 
             
                end
         | 
| 1492 1453 | 
             
              end
         | 
| 1493 1454 |  | 
| 1494 1455 | 
             
              describe "when using source" do
         | 
| 1456 | 
            +
                let(:source) { tmpfile('file_source') }
         | 
| 1457 | 
            +
             | 
| 1495 1458 | 
             
                before do
         | 
| 1496 | 
            -
                  file[:source] =  | 
| 1497 | 
            -
                  # Contents of an empty file generate the below hash values
         | 
| 1498 | 
            -
                  # in case you need to add support for additional algorithms in future
         | 
| 1499 | 
            -
                  @checksum_values = {
         | 
| 1500 | 
            -
                    :md5 => 'd41d8cd98f00b204e9800998ecf8427e',
         | 
| 1501 | 
            -
                    :md5lite => 'd41d8cd98f00b204e9800998ecf8427e',
         | 
| 1502 | 
            -
                    :sha256 => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855',
         | 
| 1503 | 
            -
                    :sha256lite => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855',
         | 
| 1504 | 
            -
                    :sha1 => 'da39a3ee5e6b4b0d3255bfef95601890afd80709',
         | 
| 1505 | 
            -
                    :sha1lite => 'da39a3ee5e6b4b0d3255bfef95601890afd80709',
         | 
| 1506 | 
            -
                    :sha224 => 'd14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f',
         | 
| 1507 | 
            -
                    :sha384 => '38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b',
         | 
| 1508 | 
            -
                    :sha512 => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e',
         | 
| 1509 | 
            -
                    :mtime => 'Jan 26 13:59:49 2016',
         | 
| 1510 | 
            -
                    :ctime => 'Jan 26 13:59:49 2016'
         | 
| 1511 | 
            -
                  }
         | 
| 1459 | 
            +
                  file[:source] = source
         | 
| 1512 1460 | 
             
                end
         | 
| 1513 1461 |  | 
| 1514 1462 | 
             
                Puppet::Type::File::ParameterChecksum.value_collection.values.reject {|v| v == :none}.each do |checksum_type|
         | 
| @@ -1527,9 +1475,51 @@ describe Puppet::Type.type(:file) do | |
| 1527 1475 | 
             
                    end
         | 
| 1528 1476 |  | 
| 1529 1477 | 
             
                    it 'should validate a valid checksum_value' do
         | 
| 1530 | 
            -
                      file[:checksum_value] =  | 
| 1478 | 
            +
                      file[:checksum_value] = CHECKSUM_VALUES[checksum_type]
         | 
| 1531 1479 | 
             
                      expect { file.validate }.to_not raise_error
         | 
| 1532 1480 | 
             
                    end
         | 
| 1481 | 
            +
             | 
| 1482 | 
            +
                    it 'fails if the checksum_value parameter and written file do not match' do
         | 
| 1483 | 
            +
                      skip if checksum_type =~ /^(ctime|mtime)/
         | 
| 1484 | 
            +
             | 
| 1485 | 
            +
                      File.write(source, FILE_CONTENT)
         | 
| 1486 | 
            +
                      file[:checksum_value] = INVALID_CHECKSUM_VALUES[checksum_type]
         | 
| 1487 | 
            +
             | 
| 1488 | 
            +
                      expect {
         | 
| 1489 | 
            +
                        file.property(:checksum_value).sync
         | 
| 1490 | 
            +
                      }.to raise_error(Puppet::Error, /File written to disk did not match desired checksum/)
         | 
| 1491 | 
            +
             | 
| 1492 | 
            +
                      expect(Puppet::FileSystem).to_not be_exist(file[:path])
         | 
| 1493 | 
            +
                    end
         | 
| 1494 | 
            +
             | 
| 1495 | 
            +
                    it 'fails if the checksum_value parameter does not match, but the metadata does' do
         | 
| 1496 | 
            +
                      skip if checksum_type =~ /^(ctime|mtime)/
         | 
| 1497 | 
            +
             | 
| 1498 | 
            +
                      File.write(source, FILE_CONTENT)
         | 
| 1499 | 
            +
                      file[:checksum_value] = INVALID_CHECKSUM_VALUES[checksum_type]
         | 
| 1500 | 
            +
                      allow(file.parameter(:source).metadata).to receive(:checksum).and_return(file[:checksum_value])
         | 
| 1501 | 
            +
             | 
| 1502 | 
            +
                      expect {
         | 
| 1503 | 
            +
                        file.property(:checksum_value).sync
         | 
| 1504 | 
            +
                      }.to raise_error(Puppet::Error, /File written to disk did not match desired checksum/)
         | 
| 1505 | 
            +
             | 
| 1506 | 
            +
                      expect(Puppet::FileSystem).to_not be_exist(file[:path])
         | 
| 1507 | 
            +
                    end
         | 
| 1508 | 
            +
             | 
| 1509 | 
            +
                    it 'replaces a file from a source when the checksum matches' do
         | 
| 1510 | 
            +
                      File.write(source, FILE_CONTENT)
         | 
| 1511 | 
            +
                      file[:checksum_value] = CHECKSUM_VALUES[checksum_type]
         | 
| 1512 | 
            +
             | 
| 1513 | 
            +
                      file.property(:checksum_value).sync
         | 
| 1514 | 
            +
                      checksum = file.parameter(:checksum).sum_file(file[:path])
         | 
| 1515 | 
            +
             | 
| 1516 | 
            +
                      if checksum_type =~ /^(ctime|mtime)/
         | 
| 1517 | 
            +
                        # file on disk ctime/mtime will be later than expected time
         | 
| 1518 | 
            +
                        expect(checksum).to match(/{#{checksum_type}}/)
         | 
| 1519 | 
            +
                      else
         | 
| 1520 | 
            +
                        expect(checksum).to eq("{#{checksum_type}}#{file[:checksum_value]}")
         | 
| 1521 | 
            +
                      end
         | 
| 1522 | 
            +
                    end
         | 
| 1533 1523 | 
             
                  end
         | 
| 1534 1524 | 
             
                end
         | 
| 1535 1525 |  | 
| @@ -1591,19 +1581,8 @@ describe Puppet::Type.type(:file) do | |
| 1591 1581 | 
             
              end
         | 
| 1592 1582 |  | 
| 1593 1583 | 
             
              describe "when using content" do
         | 
| 1594 | 
            -
                before do
         | 
| 1595 | 
            -
                  file[:content] =  | 
| 1596 | 
            -
                  @checksum_values = {
         | 
| 1597 | 
            -
                    :md5 => 'd41d8cd98f00b204e9800998ecf8427e',
         | 
| 1598 | 
            -
                    :md5lite => 'd41d8cd98f00b204e9800998ecf8427e',
         | 
| 1599 | 
            -
                    :sha256 => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855',
         | 
| 1600 | 
            -
                    :sha256lite => 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855',
         | 
| 1601 | 
            -
                    :sha1 => 'da39a3ee5e6b4b0d3255bfef95601890afd80709',
         | 
| 1602 | 
            -
                    :sha1lite => 'da39a3ee5e6b4b0d3255bfef95601890afd80709',
         | 
| 1603 | 
            -
                    :sha224 => 'd14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f',
         | 
| 1604 | 
            -
                    :sha384 => '38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b',
         | 
| 1605 | 
            -
                    :sha512 => 'cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e',
         | 
| 1606 | 
            -
                  }
         | 
| 1584 | 
            +
                before :each do
         | 
| 1585 | 
            +
                  file[:content] = FILE_CONTENT
         | 
| 1607 1586 | 
             
                end
         | 
| 1608 1587 |  | 
| 1609 1588 | 
             
                (Puppet::Type::File::ParameterChecksum.value_collection.values - SOURCE_ONLY_CHECKSUMS).each do |checksum_type|
         | 
| @@ -1622,9 +1601,43 @@ describe Puppet::Type.type(:file) do | |
| 1622 1601 | 
             
                    end
         | 
| 1623 1602 |  | 
| 1624 1603 | 
             
                    it 'should validate a valid checksum_value' do
         | 
| 1625 | 
            -
                      file[:checksum_value] =  | 
| 1604 | 
            +
                      file[:checksum_value] = CHECKSUM_VALUES[checksum_type]
         | 
| 1626 1605 | 
             
                      expect { file.validate }.to_not raise_error
         | 
| 1627 1606 | 
             
                    end
         | 
| 1607 | 
            +
             | 
| 1608 | 
            +
                    it 'fails if the checksum_value parameter and written file do not match' do
         | 
| 1609 | 
            +
                      file[:checksum_value] = INVALID_CHECKSUM_VALUES[checksum_type]
         | 
| 1610 | 
            +
             | 
| 1611 | 
            +
                      expect {
         | 
| 1612 | 
            +
                        file.property(:content).sync
         | 
| 1613 | 
            +
                      }.to raise_error(Puppet::Error, /File written to disk did not match desired checksum/)
         | 
| 1614 | 
            +
             | 
| 1615 | 
            +
                      expect(Puppet::FileSystem).to_not be_exist(file[:path])
         | 
| 1616 | 
            +
                    end
         | 
| 1617 | 
            +
             | 
| 1618 | 
            +
                    it 'fails if the calculated checksum for the content and written file do not match' do
         | 
| 1619 | 
            +
                      allow(file.parameter(:checksum)).to receive(:sum).and_return(INVALID_CHECKSUM_VALUES[checksum_type])
         | 
| 1620 | 
            +
             | 
| 1621 | 
            +
                      expect {
         | 
| 1622 | 
            +
                        file.property(:content).sync
         | 
| 1623 | 
            +
                      }.to raise_error(Puppet::Error, /File written to disk did not match desired checksum/)
         | 
| 1624 | 
            +
             | 
| 1625 | 
            +
                      expect(Puppet::FileSystem).to_not be_exist(file[:path])
         | 
| 1626 | 
            +
                    end
         | 
| 1627 | 
            +
             | 
| 1628 | 
            +
                    it 'replaces a file from content when the checksum matches' do
         | 
| 1629 | 
            +
                      file[:checksum_value] = CHECKSUM_VALUES[checksum_type]
         | 
| 1630 | 
            +
             | 
| 1631 | 
            +
                      file.property(:content).sync
         | 
| 1632 | 
            +
                      checksum = file.parameter(:checksum).sum_file(file[:path])
         | 
| 1633 | 
            +
             | 
| 1634 | 
            +
                      if checksum_type =~ /^(ctime|mtime)/
         | 
| 1635 | 
            +
                        # file on disk ctime/mtime will be later than expected time
         | 
| 1636 | 
            +
                        expect(checksum).to match(/{#{checksum_type}}/)
         | 
| 1637 | 
            +
                      else
         | 
| 1638 | 
            +
                        expect(checksum).to eq("{#{checksum_type}}#{file[:checksum_value]}")
         | 
| 1639 | 
            +
                      end
         | 
| 1640 | 
            +
                    end
         | 
| 1628 1641 | 
             
                  end
         | 
| 1629 1642 | 
             
                end
         | 
| 1630 1643 |  | 
| @@ -1657,6 +1670,13 @@ describe Puppet::Type.type(:file) do | |
| 1657 1670 | 
             
                  file[:checksum_value] = ''
         | 
| 1658 1671 | 
             
                  expect { file.validate }.to_not raise_error
         | 
| 1659 1672 | 
             
                end
         | 
| 1673 | 
            +
             | 
| 1674 | 
            +
                it 'writes a file' do
         | 
| 1675 | 
            +
                  file[:ensure] = :file
         | 
| 1676 | 
            +
                  file.property(:ensure).sync
         | 
| 1677 | 
            +
             | 
| 1678 | 
            +
                  expect(file.parameter(:checksum).sum_file(file[:path])).to eq('{none}')
         | 
| 1679 | 
            +
                end
         | 
| 1660 1680 | 
             
              end
         | 
| 1661 1681 |  | 
| 1662 1682 | 
             
              describe "when auditing" do
         |