puppet 6.14.0-x86-mingw32 → 6.19.0-x86-mingw32

data/spec/unit/type/user_spec.rb

@@ -1,10 +1,10 @@
-# encoding: UTF-8
+# encoding: utf-8
 require 'spec_helper'
 
 describe Puppet::Type.type(:user) do
   before :each do
     @provider_class = described_class.provide(:simple) do
-      has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_shell
+      has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_roles, :manages_shell
       mk_resource_methods
       def create; end
       def delete; end
@@ -35,6 +35,10 @@ describe Puppet::Type.type(:user) do
     expect(described_class.provider_feature(:manages_solaris_rbac)).not_to be_nil
   end
 
+  it "should have a manages_roles feature" do
+    expect(described_class.provider_feature(:manages_roles)).not_to be_nil
+  end
+
   it "should have a manages_expiry feature" do
     expect(described_class.provider_feature(:manages_expiry)).not_to be_nil
   end
@@ -401,7 +405,7 @@ describe Puppet::Type.type(:user) do
   end
 
   describe "when user has roles" do
-    it "should autorequire roles" do
+    it "should autorequire roles on non-Windows", :unless => Puppet::Util::Platform.windows? do
       testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
       testrole = described_class.new(:name => "testrole")
 
@@ -413,6 +417,31 @@ describe Puppet::Type.type(:user) do
       expect(rel.source.ref).to eq(testrole.ref)
       expect(rel.target.ref).to eq(testuser.ref)
     end
+
+    it "should not autorequire roles on Windows", :if => Puppet::Util::Platform.windows? do
+      testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
+      testrole = described_class.new(:name => "testrole")
+
+      Puppet::Resource::Catalog.new :testing do |conf|
+        [testuser, testrole].each { |resource| conf.add_resource resource }
+      end
+
+      expect(testuser.autorequire).to be_empty
+    end
+
+    it "should sync the user roles when changing the state of :ensure if :roles is being managed" do
+      user = Puppet::Type.type(:user).new(:name => "myUser", :ensure => :present)
+      user[:roles] = 'testRole'
+
+      allow(user.provider.class).to receive(:supports_parameter?).and_return(true)
+      expect(user.property(:roles)).to receive(:retrieve).and_return("other")
+      expect(user.property(:roles)).to receive(:insync?).and_return(false)
+      expect(user.property(:roles)).to receive(:sync)
+
+      allow(user.provider).to receive(:create)
+
+      user.property(:ensure).sync
+    end
   end
 
   describe "when setting shell" do

data/spec/unit/type_spec.rb

@@ -1099,6 +1099,56 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
       expect { expect(type.instances).to eq([]) }.to_not raise_error
     end
 
+    context "with a composite namevar type" do
+      let :type do
+        Puppet::Type.newtype(:type_spec_fake_type) do
+          newparam(:name) do
+            isnamevar
+          end
+
+          newparam(:path) do
+            isnamevar
+          end
+
+          def self.title_patterns
+            [[%r{^(.*)@(.*)$}, [:name, :path]], [%r{^([^@]+)$}, [:name]]]
+          end
+
+          newproperty(:prop1) {}
+        end
+
+        Puppet::Type.type(:type_spec_fake_type)
+      end
+
+      before :each do
+        type.provide(:default) do
+          defaultfor :operatingsystem => Facter.value(:operatingsystem)
+          mk_resource_methods
+          class << self
+            attr_accessor :params
+          end
+
+          def title
+            "#{@property_hash[:name]}@#{@property_hash[:path]}"
+          end
+
+          def self.instance(name, path)
+            new(:name => name, :path => path, :ensure => :present)
+          end
+
+          def self.instances
+            @instances ||= params.collect { |param| instance(param.first.to_s, param.last.to_s) }
+          end
+
+          @params = [[:name_one, :path_one], [:name_two, :path_two]]
+        end
+      end
+
+      it "should return composite titles for the instances" do
+        expect(type.instances.map(&:title)).to eq(["name_one@path_one", "name_two@path_two"])
+      end
+    end
+
     context "with a default provider" do
       before :each do
         type.provide(:default) do

data/spec/unit/util/at_fork_spec.rb

@@ -19,7 +19,7 @@ describe 'Puppet::Util::AtFork' do
   describe '.get_handler' do
     context 'when on Solaris' do
       before :each do
-        expect(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
+        expect(Puppet::Util::Platform).to receive(:solaris?).and_return(true)
       end
 
       after :each do
@@ -114,7 +114,7 @@ describe 'Puppet::Util::AtFork' do
 
     context 'when NOT on Solaris' do
       before :each do
-        expect(Facter).to receive(:value).with(:operatingsystem).and_return(nil)
+        expect(Puppet::Util::Platform).to receive(:solaris?).and_return(false)
       end
 
       def stub_noop_handler(namespace_only = false)

data/spec/unit/util/autoload_spec.rb

@@ -23,10 +23,10 @@ describe Puppet::Util::Autoload do
 
     def with_libdir(libdir)
       begin
-        Puppet::Util::Autoload.instance_variable_set(:@initialized, false)
         old_loadpath = $LOAD_PATH.dup
         old_libdir = Puppet[:libdir]
         Puppet[:libdir] = libdir
+        $LOAD_PATH.unshift(libdir)
         yield
       ensure
         Puppet[:libdir] = old_libdir
@@ -83,6 +83,7 @@ describe Puppet::Util::Autoload do
 
       libdir = File.expand_path('/libdir1')
       Puppet[:vendormoduledir] = vendor_dir
+      Puppet.initialize_settings
 
       with_libdir(libdir) do
         expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})

data/spec/unit/util/character_encoding_spec.rb

@@ -21,7 +21,7 @@ describe Puppet::Util::CharacterEncoding do
         let(:invalid_utf8_string) { "\xfd\xf1".force_encoding(Encoding::UTF_8) }
 
         it "should issue a debug message" do
-          expect(Puppet).to receive(:debug).with(/encoding is invalid/)
+          expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/encoding is invalid/) }
           Puppet::Util::CharacterEncoding.convert_to_utf_8(invalid_utf8_string)
         end
 
@@ -80,7 +80,7 @@ describe Puppet::Util::CharacterEncoding do
         end
 
         it "should issue a debug message that the string was not transcodable" do
-          expect(Puppet).to receive(:debug).with(/cannot be transcoded/)
+          expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/cannot be transcoded/) }
           PuppetSpec::CharacterEncoding.with_external_encoding(Encoding::Windows_31J) do
             Puppet::Util::CharacterEncoding.convert_to_utf_8(invalid_win_31j)
           end
@@ -124,7 +124,7 @@ describe Puppet::Util::CharacterEncoding do
           let(:euc_kr) { [253, 241].pack('C*').force_encoding(Encoding::ASCII) }
 
           it "should issue a debug message" do
-            expect(Puppet).to receive(:debug).with(/cannot be transcoded/)
+            expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/cannot be transcoded/) }
             Puppet::Util::CharacterEncoding.convert_to_utf_8(euc_kr)
           end
 
@@ -168,7 +168,7 @@ describe Puppet::Util::CharacterEncoding do
       let(:foo) { 'foo' }
 
       it "should issue a debug message" do
-        expect(Puppet).to receive(:debug).with(/not valid UTF-8/)
+        expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/not valid UTF-8/) }
         Puppet::Util::CharacterEncoding.override_encoding_to_utf_8(oslash)
       end
 

data/spec/unit/util/checksums_spec.rb

@@ -65,6 +65,22 @@ describe Puppet::Util::Checksums do
     expect(@summer.sumtype("asdfasdfa")).to be_nil
   end
 
+  it "has a list of known checksum types" do
+    expect(@summer.known_checksum_types).to match_array(content_sums + file_only)
+  end
+
+  it "returns true if the checksum is valid" do
+    expect(@summer).to be_valid_checksum('sha1', 'fcc1715b22278a9dae322b0a34935f10d1608b9f')
+  end
+
+  it "returns false if the checksum is known but invalid" do
+    expect(@summer).to_not be_valid_checksum('sha1', 'wronglength')
+  end
+
+  it "returns false if the checksum type is unknown" do
+    expect(@summer).to_not be_valid_checksum('rot13', 'doesntmatter')
+  end
+
   {:md5 => Digest::MD5, :sha1 => Digest::SHA1, :sha256 => Digest::SHA256, :sha512 => Digest::SHA512, :sha384 => Digest::SHA384}.each do |sum, klass|
     describe("when using #{sum}") do
       it "should use #{klass} to calculate string checksums" do

data/spec/unit/util/command_line_spec.rb

@@ -62,7 +62,7 @@ describe Puppet::Util::CommandLine do
       it "should print the version and exit if #{arg} is given" do
         expect do
           described_class.new("puppet", [arg]).execute
-        end.to have_printed(/^#{Regexp.escape(Puppet.version)}$/)
+        end.to output(/^#{Regexp.escape(Puppet.version)}$/).to_stdout
       end
     end
 
@@ -73,7 +73,8 @@ describe Puppet::Util::CommandLine do
 
         expect {
           commandline.execute
-        }.to have_printed(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).and_exit_with(0)
+        }.to exit_with(0)
+         .and output(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).to_stdout
       end
     end
 
@@ -95,7 +96,8 @@ describe Puppet::Util::CommandLine do
 
       expect {
         commandline.execute
-      }.to have_printed(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).and_exit_with(0)
+      }.to exit_with(0)
+       .and output(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).to_stdout
     end
   end
 
@@ -124,7 +126,8 @@ describe Puppet::Util::CommandLine do
 
           expect {
             commandline.execute
-          }.to have_printed(/Unknown Puppet subcommand 'whatever'/).and_exit_with(1)
+          }.to exit_with(1)
+           .and output(/Unknown Puppet subcommand 'whatever'/).to_stdout
         end
 
         it "should abort and show the help message" do
@@ -134,7 +137,8 @@ describe Puppet::Util::CommandLine do
 
           expect {
             commandline.execute
-          }.to have_printed(/See 'puppet help' for help on available puppet subcommands/).and_exit_with(1)
+          }.to exit_with(1)
+           .and output(/See 'puppet help' for help on available puppet subcommands/).to_stdout
         end
 
         %w{--version -V}.each do |arg|
@@ -145,7 +149,8 @@ describe Puppet::Util::CommandLine do
 
             expect {
               commandline.execute
-            }.to have_printed(%r[^#{Regexp.escape(Puppet.version)}$]).and_exit_with(1)
+            }.to exit_with(1)
+             .and output(%r[^#{Regexp.escape(Puppet.version)}$]).to_stdout
           end
         end
       end

data/spec/unit/util/log/destinations_spec.rb

@@ -44,41 +44,13 @@ describe Puppet::Util::Log.desttypes[:file] do
       end
     end
 
-    describe "on POSIX systems", :if => Puppet.features.posix? do
+    describe "on POSIX systems", :unless => Puppet::Util::Platform.windows? do
       describe "with a normal file" do
         let (:parent) { Pathname.new('/tmp') }
         let (:abspath) { '/tmp/log' }
         let (:relpath) { 'log' }
 
         it_behaves_like "file destination"
-
-        it "logs an error if it can't chown the file owner & group" do
-          allow(File).to receive(:exist?).with(parent).and_return(true)
-          expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(false)
-          expect(FileUtils).to receive(:chown).with(Puppet[:user], Puppet[:group], abspath).and_raise(Errno::EPERM)
-          expect(Puppet.features).to receive(:root?).and_return(true)
-          expect(Puppet).to receive(:err).with("Unable to set ownership to #{Puppet[:user]}:#{Puppet[:group]} for log file: #{abspath}")
-
-          @class.new(abspath)
-        end
-
-        it "doesn't attempt to chown when running as non-root" do
-          allow(File).to receive(:exist?).with(parent).and_return(true)
-          expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(false)
-          expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
-          expect(Puppet.features).to receive(:root?).and_return(false)
-
-          @class.new(abspath)
-        end
-
-        it "doesn't attempt to chown when file already exists" do
-          allow(File).to receive(:exist?).with(parent).and_return(true)
-          expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(true)
-          expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
-          expect(Puppet.features).to receive(:root?).and_return(true)
-
-          @class.new(abspath)
-        end
       end
 
       describe "with a JSON file" do

data/spec/unit/util/package/version/debian_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+require 'puppet/util/package/version/debian'
+
+describe Puppet::Util::Package::Version::Debian do
+  context "when creating new version should fail" do
+    it "if is parsing symbols" do
+      expect { described_class.parse(:absent) }.to raise_error(described_class::ValidationFailure)
+    end
+  end
+  context "when creating new version" do
+    it "is parsing basic version" do
+      v = described_class.parse('1:20191210.1-0ubuntu0.19.04.2')
+      expect(v.epoch).to eql(1)
+      expect(v.upstream_version).to eql('20191210.1')
+      expect(v.debian_revision).to eql('0ubuntu0.19.04.2')
+    end
+
+    it "is parsing no epoch basic version" do
+      v = described_class.parse('20191210.1-0ubuntu0.19.04.2')
+      expect(v.epoch).to eql(0)
+      expect(v.upstream_version).to eql('20191210.1')
+      expect(v.debian_revision).to eql('0ubuntu0.19.04.2')
+    end
+
+    it "is parsing no debian revision basic version" do
+      v = described_class.parse('2.42.1+19.04')
+      expect(v.epoch).to eql(0)
+      expect(v.upstream_version).to eql('2.42.1+19.04')
+      expect(v.debian_revision).to eql(nil)
+    end
+
+    it "is parsing no epoch complex version" do
+      v = described_class.parse('3.32.2+git20190711-2ubuntu1~19.04.1')
+      expect(v.epoch).to eql(0)
+      expect(v.upstream_version).to eql('3.32.2+git20190711')
+      expect(v.debian_revision).to eql('2ubuntu1~19.04.1')
+    end
+
+    it "is parsing even more complex version" do
+      v = described_class.parse('5:1.0.0+git-20190109.133f4c4-0ubuntu2')
+      expect(v.epoch).to eql(5)
+      expect(v.upstream_version).to eql('1.0.0+git-20190109.133f4c4')
+      expect(v.debian_revision).to eql('0ubuntu2')
+    end
+  end
+  context "when comparing two versions" do
+    it "epoch has precedence" do
+      first = described_class.parse('9:99-99')
+      second = described_class.parse('10:01-01')
+      expect(first < second).to eql(true)
+    end
+    it "handles equals letters-only versions" do
+      lower = described_class.parse('abd-def')
+      higher = described_class.parse('abd-def')
+      expect(lower == higher).to eql(true)
+    end
+    it "shorter version is smaller" do
+      lower = described_class.parse('abd-de')
+      higher = described_class.parse('abd-def')
+      expect(lower < higher).to eql(true)
+    end
+    it "shorter version is smaller even with digits" do
+      lower = described_class.parse('a1b2d-d3e')
+      higher = described_class.parse('a1b2d-d3ef')
+      expect(lower < higher).to eql(true)
+    end
+    it "shorter version is smaller when number is less" do
+      lower = described_class.parse('a1b2d-d9')
+      higher = described_class.parse('a1b2d-d13')
+      expect(lower < higher).to eql(true)
+    end
+    it "handles ~ version" do
+      lower = described_class.parse('a1b2d-d10~')
+      higher = described_class.parse('a1b2d-d10')
+      expect(lower < higher).to eql(true)
+    end
+    it "handles letters versus -" do
+      lower = described_class.parse('a1b2d-d1a')
+      higher = described_class.parse('a1b2d-d1-')
+      expect(lower < higher).to eql(true)
+    end
+  end
+end

data/spec/unit/util/package/version/pip_spec.rb

@@ -0,0 +1,464 @@
+require 'spec_helper'
+require 'puppet/util/package/version/pip'
+
+describe Puppet::Util::Package::Version::Pip do
+  describe "initialization" do
+    shared_examples_for 'a valid version' do |input_version, output = input_version|
+      [input_version, input_version.swapcase].each do |input|
+        it "transforms #{input} back to string(#{output}) succesfully" do
+          version = described_class.parse(input)
+          expect(version.to_s).to eq(output)
+        end
+      end
+
+      describe "comparison" do
+        version = described_class.parse(input_version)
+
+        # rubocop:disable UselessComparison
+        it "#{input_version} shouldn't be lesser than itself" do
+          expect(version <  version).to eq(false)
+        end
+
+        it "#{input_version} shouldn't be greater than itself" do
+          expect(version >  version).to eq(false)
+        end
+
+        it "#{input_version} shouldn't be equal with itself" do
+          expect(version != version).to eq(false)
+        end
+
+        it "#{input_version} should be equal to itself" do
+          expect(version == version).to eq(true)
+        end
+      end
+    end
+
+    shared_examples_for 'an invalid version' do |invalid_input|
+      [invalid_input, invalid_input.swapcase].each do |input|
+        it "should not be able to transform #{invalid_input} to string" do
+          expect{ described_class.parse(input) }.to raise_error(described_class::ValidationFailure)
+        end
+      end
+
+      describe "comparison" do
+        valid_version = described_class.parse("1.0")
+
+        it "should raise error when checking if #{invalid_input} is lesser than a valid version" do
+          expect{ valid_version <  invalid_input }.to raise_error(described_class::ValidationFailure)
+        end
+
+        it "should raise error when checking if #{invalid_input} is greater than a valid version" do
+          expect{ valid_version >  invalid_input }.to raise_error(described_class::ValidationFailure)
+        end
+
+        it "should raise error when checking if #{invalid_input} is greater or equal than a valid version" do
+          expect{ valid_version >= invalid_input }.to raise_error(described_class::ValidationFailure)
+        end
+
+        it "should raise error when checking if #{invalid_input} is lesser or equal than a valid version" do
+          expect{ valid_version <= invalid_input }.to raise_error(described_class::ValidationFailure)
+        end
+      end
+    end
+
+    describe "when only release segment is present in provided version" do
+      context "should work with any number of integer elements" do
+        context "when it has 1 element" do
+          it_should_behave_like 'a valid version', "1"
+        end
+        context "when it has 2 elements" do
+          it_should_behave_like 'a valid version', "1.1"
+        end
+
+        context "when it has 3 elements" do
+          it_should_behave_like 'a valid version', "1.1.1"
+        end
+
+        context "when it has 4 elements" do
+          it_should_behave_like 'a valid version', "1.1.1.1"
+        end
+
+        context "when it has 10 elements" do
+          it_should_behave_like 'a valid version', "1.1.1.1.1.1.1.1.1.1"
+        end
+      end
+
+      describe "should work with elements which are zero" do
+        context "when it ends with 1 zero" do
+          it_should_behave_like 'a valid version', "1.0"
+        end
+
+        context "when it ends with 2 zeros" do
+          it_should_behave_like 'a valid version', "1.0.0"
+        end
+
+        context "when it ends with 3 zeros" do
+          it_should_behave_like 'a valid version', "1.0.0.0"
+        end
+
+        context "when it starts with 1 zero" do
+          it_should_behave_like 'a valid version', "0.1"
+        end
+
+        context "when it starts with 2 zeros" do
+          it_should_behave_like 'a valid version', "0.0.1"
+        end
+
+        context "when it starts with 3 zeros" do
+          it_should_behave_like 'a valid version', "0.0.0.1"
+        end
+
+        context "when it is just a zero" do
+          it_should_behave_like 'a valid version', "0"
+        end
+
+        context "when it is full of just zeros" do
+          it_should_behave_like 'a valid version', "0.0.0"
+        end
+      end
+
+      describe "should work with elements containing multiple digits" do
+        context "when it has two digit elements" do
+          it_should_behave_like 'a valid version', "1.10.1"
+        end
+
+        context "when it has three digit elements" do
+          it_should_behave_like 'a valid version', "1.101.1.11"
+        end
+
+        context "when it has four digit elements" do
+          it_should_behave_like 'a valid version', "2019.0.11"
+        end
+
+        context "when it has a numerical element starting with zero" do
+          # the zero will dissapear
+          it_should_behave_like 'a valid version', "1.09.10", "1.9.10"
+        end
+
+        context "when it starts with multiple zeros" do
+          # the zeros will dissapear
+          it_should_behave_like 'a valid version', "0010.0000.0011", "10.0.11"
+        end
+      end
+
+      context "should fail because of misplaced letters" do
+        context "when it starts with letters" do
+          it_should_behave_like 'an invalid version', "d.2"
+          it_should_behave_like 'an invalid version', "ee.2"
+        end
+
+        context "when it has only letters" do
+          it_should_behave_like 'an invalid version', "d.c"
+          it_should_behave_like 'an invalid version', "dd.c"
+        end
+      end
+    end
+
+    describe "when the epoch segment is present in provided version" do
+      context "should work when epoch is an integer" do
+        context "when epoch has 1 digit" do
+          it_should_behave_like 'a valid version', "1!1.0.0"
+        end
+
+        context "when epoch has 2 digits" do
+          it_should_behave_like 'a valid version', "10!1.0.0"
+        end
+
+        context "when epoch is zero" do
+          # versions without epoch specified are considered to have epoch 0
+          # it is accepted as input but it should be ignored at output
+          it_should_behave_like 'a valid version', "0!1.0.0", "1.0.0"
+        end
+      end
+
+      context "should fail when epoch contains letters" do
+        context "when epoch starts with a letter" do
+          it_should_behave_like 'an invalid version', "a9!1.0.0"
+        end
+
+        context "when epoch ends with a letter" do
+          it_should_behave_like 'an invalid version', "9a!1.0.0"
+        end
+      end
+    end
+
+    describe "when the pre-release segment is present in provided version" do
+      context "when pre-release contains the letter a" do
+        it_should_behave_like 'a valid version', "1.0a", "1.0a0"
+        it_should_behave_like 'a valid version', "1.0a0"
+      end
+
+      context "when pre-release contains the letter b" do
+        it_should_behave_like 'a valid version', "1.0b", "1.0b0"
+        it_should_behave_like 'a valid version', "1.0b0"
+      end
+
+      context "when pre-release contains the letter c" do
+        it_should_behave_like 'a valid version', "1.0c",  "1.0rc0"
+        it_should_behave_like 'a valid version', "1.0c0", "1.0rc0"
+      end
+
+      context "when pre-release contains the string alpha" do
+        it_should_behave_like 'a valid version', "1.0alpha",  "1.0a0"
+        it_should_behave_like 'a valid version', "1.0alpha0", "1.0a0"
+      end
+
+      context "when pre-release contains the string beta" do
+        it_should_behave_like 'a valid version', "1.0beta",  "1.0b0"
+        it_should_behave_like 'a valid version', "1.0beta0", "1.0b0"
+      end
+
+      context "when pre-release contains the string rc" do
+        it_should_behave_like 'a valid version', "1.0rc",  "1.0rc0"
+        it_should_behave_like 'a valid version', "1.0rc0", "1.0rc0"
+      end
+
+      context "when pre-release contains the string pre" do
+        it_should_behave_like 'a valid version', "1.0pre",  "1.0rc0"
+        it_should_behave_like 'a valid version', "1.0pre0", "1.0rc0"
+      end
+
+      context "when pre-release contains the string preview" do
+        it_should_behave_like 'a valid version', "1.0preview",  "1.0rc0"
+        it_should_behave_like 'a valid version', "1.0preview0", "1.0rc0"
+      end
+
+      context "when pre-release contains multiple zeros at the beginning" do
+        it_should_behave_like 'a valid version', "1.0.beta.00",  "1.0b0"
+        it_should_behave_like 'a valid version', "1.0.beta.002", "1.0b2"
+      end
+
+      context "when pre-release elements are separated by dots" do
+        it_should_behave_like 'a valid version', "1.0.alpha",   "1.0a0"
+        it_should_behave_like 'a valid version', "1.0.alpha.0", "1.0a0"
+        it_should_behave_like 'a valid version', "1.0.alpha.2", "1.0a2"
+      end
+
+      context "when pre-release elements are separated by dashes" do
+        it_should_behave_like 'a valid version', "1.0-alpha",   "1.0a0"
+        it_should_behave_like 'a valid version', "1.0-alpha-0", "1.0a0"
+        it_should_behave_like 'a valid version', "1.0-alpha-2", "1.0a2"
+      end
+
+      context "when pre-release elements are separated by underscores" do
+        it_should_behave_like 'a valid version', "1.0_alpha",   "1.0a0"
+        it_should_behave_like 'a valid version', "1.0_alpha_0", "1.0a0"
+        it_should_behave_like 'a valid version', "1.0_alpha_2", "1.0a2"
+      end
+
+      context "when pre-release elements are separated by mixed symbols" do
+        it_should_behave_like 'a valid version', "1.0-alpha_5", "1.0a5"
+        it_should_behave_like 'a valid version', "1.0-alpha.5", "1.0a5"
+        it_should_behave_like 'a valid version', "1.0_alpha-5", "1.0a5"
+        it_should_behave_like 'a valid version', "1.0_alpha.5", "1.0a5"
+        it_should_behave_like 'a valid version', "1.0.alpha-5", "1.0a5"
+        it_should_behave_like 'a valid version', "1.0.alpha_5", "1.0a5"
+      end
+    end
+
+    describe "when the post-release segment is present in provided version" do
+      context "when post-release is just an integer" do
+        it_should_behave_like 'a valid version', "1.0-9",  "1.0.post9"
+        it_should_behave_like 'a valid version', "1.0-10", "1.0.post10"
+      end
+
+      context "when post-release is just an integer and starts with zero" do
+        it_should_behave_like 'a valid version', "1.0-09",  "1.0.post9"
+        it_should_behave_like 'a valid version', "1.0-009", "1.0.post9"
+      end
+
+      context "when post-release contains the string post" do
+        it_should_behave_like 'a valid version', "1.0post",  "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0post0", "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0post1", "1.0.post1"
+        it_should_behave_like 'an invalid version', "1.0-0.post1"
+      end
+
+      context "when post-release contains the string rev" do
+        it_should_behave_like 'a valid version', "1.0rev",  "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0rev0", "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0rev1", "1.0.post1"
+        it_should_behave_like 'an invalid version', "1.0-0.rev1"
+      end
+
+      context "when post-release contains the letter r" do
+        it_should_behave_like 'a valid version', "1.0r",  "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0r0", "1.0.post0"
+        it_should_behave_like 'a valid version', "1.0r1", "1.0.post1"
+        it_should_behave_like 'an invalid version', "1.0-0.r1"
+      end
+
+      context "when post-release elements are separated by dashes" do
+        it_should_behave_like 'a valid version', "1.0-post-22", "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0-rev-22",  "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0-r-22",    "1.0.post22"
+      end
+
+      context "when post-release elements are separated by underscores" do
+        it_should_behave_like 'a valid version', "1.0_post_22", "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0_rev_22",  "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0_r_22",    "1.0.post22"
+      end
+
+      context "when post-release elements are separated by dots" do
+        it_should_behave_like 'a valid version', "1.0.post.22", "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0.rev.22",  "1.0.post22"
+        it_should_behave_like 'a valid version', "1.0.r.22",    "1.0.post22"
+      end
+
+      context "when post-release elements are separated by mixed symbols" do
+        it_should_behave_like 'a valid version', "1.0-r_5", "1.0.post5"
+        it_should_behave_like 'a valid version', "1.0-r.5", "1.0.post5"
+        it_should_behave_like 'a valid version', "1.0_r-5", "1.0.post5"
+        it_should_behave_like 'a valid version', "1.0_r.5", "1.0.post5"
+        it_should_behave_like 'a valid version', "1.0.r-5", "1.0.post5"
+        it_should_behave_like 'a valid version', "1.0.r_5", "1.0.post5"
+      end
+    end
+
+    describe "when the dev release segment is present in provided version" do
+      context "when dev release is only the keyword dev" do
+        it_should_behave_like 'a valid version', "1.0dev",  "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0-dev", "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0_dev", "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0.dev", "1.0.dev0"
+      end
+
+      context "when dev release contains the keyword dev and a number" do
+        it_should_behave_like 'a valid version', "1.0dev2",    "1.0.dev2"
+        it_should_behave_like 'a valid version', "1.0-dev33",  "1.0.dev33"
+        it_should_behave_like 'a valid version', "1.0.dev11",  "1.0.dev11"
+        it_should_behave_like 'a valid version', "1.0_dev101", "1.0.dev101"
+      end
+
+      context "when dev release's number element starts with 0" do
+        it_should_behave_like 'a valid version', "1.0dev02",     "1.0.dev2"
+        it_should_behave_like 'a valid version', "1.0-dev033",   "1.0.dev33"
+        it_should_behave_like 'a valid version', "1.0_dev0101",  "1.0.dev101"
+        it_should_behave_like 'a valid version', "1.0.dev00011", "1.0.dev11"
+      end
+
+      context "when dev release elements are separated by dashes" do
+        it_should_behave_like 'a valid version', "1.0-dev",    "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0-dev-2",  "1.0.dev2"
+        it_should_behave_like 'a valid version', "1.0-dev-22", "1.0.dev22"
+      end
+
+      context "when dev release elements are separated by underscores" do
+        it_should_behave_like 'a valid version', "1.0_dev",    "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0_dev_2",  "1.0.dev2"
+        it_should_behave_like 'a valid version', "1.0_dev_22", "1.0.dev22"
+      end
+
+      context "when dev release elements are separated by dots" do
+        it_should_behave_like 'a valid version', "1.0.dev",    "1.0.dev0"
+        it_should_behave_like 'a valid version', "1.0.dev.2",  "1.0.dev2"
+        it_should_behave_like 'a valid version', "1.0.dev.22", "1.0.dev22"
+      end
+
+      context "when dev release elements are separated by mixed symbols" do
+        it_should_behave_like 'a valid version', "1.0-dev_5", "1.0.dev5"
+        it_should_behave_like 'a valid version', "1.0-dev.5", "1.0.dev5"
+        it_should_behave_like 'a valid version', "1.0_dev-5", "1.0.dev5"
+        it_should_behave_like 'a valid version', "1.0_dev.5", "1.0.dev5"
+        it_should_behave_like 'a valid version', "1.0.dev-5", "1.0.dev5"
+        it_should_behave_like 'a valid version', "1.0.dev_5", "1.0.dev5"
+      end
+    end
+
+    describe "when the local version segment is present in provided version" do
+      it_should_behave_like 'an invalid version', "1.0+"
+
+      context "when local version is just letters" do
+        it_should_behave_like 'a valid version', "1.0+local"
+        it_should_behave_like 'a valid version', "1.0+Local", "1.0+local"
+      end
+
+      context "when local version contains numbers" do
+        it_should_behave_like 'a valid version', "1.0+10"
+        it_should_behave_like 'a valid version', "1.0+01",    "1.0+1"
+        it_should_behave_like 'a valid version', "1.0+01L",   "1.0+01l"
+        it_should_behave_like 'a valid version', "1.0+L101L", "1.0+l101l"
+      end
+
+      context "when local version contains multiple elements" do
+        it_should_behave_like 'a valid version', "1.0+10.local"
+        it_should_behave_like 'a valid version', "1.0+abc.def.ghi"
+        it_should_behave_like 'a valid version', "1.0+01.abc",            "1.0+1.abc"
+        it_should_behave_like 'a valid version', "1.0+01L.0001",          "1.0+01l.1"
+        it_should_behave_like 'a valid version', "1.0+L101L.local",       "1.0+l101l.local"
+        it_should_behave_like 'a valid version', "1.0+dash-undrsc_dot.5", "1.0+dash.undrsc.dot.5"
+      end
+    end
+  end
+
+  describe "comparison of versions" do
+    # This array must remain sorted (smallest to highest version).
+    versions = [
+      "0.1",
+      "0.10",
+      "0.10.1",
+      "0.10.1.0.1",
+      "1.0.dev456",
+      "1.0a1",
+      "1.0a2.dev456",
+      "1.0a12.dev456",
+      "1.0a12",
+      "1.0b1.dev456",
+      "1.0b2",
+      "1.0b2.post345.dev456",
+      "1.0b2.post345",
+      "1.0b2-346",
+      "1.0c1.dev456",
+      "1.0c1",
+      "1.0rc2",
+      "1.0c3",
+      "1.0",
+      "1.0.post456.dev34",
+      "1.0.post456",
+      "1.1.dev1",
+      "1.2",
+      "1.2+123abc",
+      "1.2+123abc456",
+      "1.2+abc",
+      "1.2+abc123",
+      "1.2+abc123-def2",
+      "1.2+abc123-def2-0",
+      "1.2+abc123def",
+      "1.2+1234.abc",
+      "1.2+123456",
+      "1.2.r32+123456",
+      "1.2.rev33+123456",
+      "1!1.0b2.post345.dev456",
+      "1!1.0",
+      "1!1.0.post456.dev34",
+      "1!1.0.post456",
+      "1!1.2.rev33+123456",
+      "2!2.3.4.alpha5.rev6.dev7+abc89"
+    ]
+
+    it "should find versions list to be already sorted" do
+      sorted_versions = versions.sort do |x,y|
+        described_class.compare(x, y)
+      end
+      expect(versions).to eq(sorted_versions)
+    end
+
+    versions.combination(2).to_a.each do |version_pair|
+      lower_version = described_class.parse(version_pair.first)
+      greater_version = described_class.parse(version_pair.last)
+      
+      it "#{lower_version} should be equal to #{lower_version}" do
+        expect(lower_version == lower_version).to eq(true)
+      end
+
+      it "#{lower_version} should not be equal to #{greater_version}" do
+        expect(lower_version != greater_version).to eq(true)
+      end
+
+      it "#{lower_version} should be lower than #{greater_version}" do
+        expect(lower_version < greater_version).to eq(true)
+      end
+    end
+  end
+end