puppet 6.14.0-x64-mingw32 → 6.19.0-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (496) hide show
  1. checksums.yaml +4 -4
  2. data/CODEOWNERS +2 -7
  3. data/Gemfile +4 -2
  4. data/Gemfile.lock +36 -34
  5. data/README.md +3 -4
  6. data/Rakefile +4 -12
  7. data/ext/windows/service/daemon.rb +3 -3
  8. data/lib/puppet.rb +33 -9
  9. data/lib/puppet/agent.rb +20 -14
  10. data/lib/puppet/agent/locker.rb +0 -7
  11. data/lib/puppet/application/agent.rb +25 -9
  12. data/lib/puppet/application/apply.rb +18 -20
  13. data/lib/puppet/application/device.rb +1 -1
  14. data/lib/puppet/application/doc.rb +1 -1
  15. data/lib/puppet/application/filebucket.rb +5 -14
  16. data/lib/puppet/application/lookup.rb +16 -4
  17. data/lib/puppet/application/plugin.rb +1 -0
  18. data/lib/puppet/application/ssl.rb +3 -3
  19. data/lib/puppet/configurer.rb +68 -24
  20. data/lib/puppet/configurer/downloader.rb +31 -10
  21. data/lib/puppet/configurer/plugin_handler.rb +1 -1
  22. data/lib/puppet/confine.rb +2 -2
  23. data/lib/puppet/confine/any.rb +1 -1
  24. data/lib/puppet/context/trusted_information.rb +14 -8
  25. data/lib/puppet/daemon.rb +13 -27
  26. data/lib/puppet/defaults.rb +141 -41
  27. data/lib/puppet/environments.rb +55 -15
  28. data/lib/puppet/face/catalog.rb +1 -1
  29. data/lib/puppet/face/config.rb +46 -16
  30. data/lib/puppet/face/facts.rb +1 -1
  31. data/lib/puppet/face/help.rb +29 -3
  32. data/lib/puppet/face/module/search.rb +5 -0
  33. data/lib/puppet/face/node.rb +3 -3
  34. data/lib/puppet/face/node/clean.rb +2 -2
  35. data/lib/puppet/face/plugin.rb +2 -2
  36. data/lib/puppet/face/status.rb +1 -1
  37. data/lib/puppet/feature/base.rb +1 -1
  38. data/lib/puppet/file_bucket/dipper.rb +1 -1
  39. data/lib/puppet/file_serving/http_metadata.rb +14 -2
  40. data/lib/puppet/file_serving/metadata.rb +4 -1
  41. data/lib/puppet/file_serving/mount/locales.rb +1 -2
  42. data/lib/puppet/file_serving/mount/pluginfacts.rb +1 -2
  43. data/lib/puppet/file_serving/mount/plugins.rb +1 -2
  44. data/lib/puppet/file_serving/terminus_selector.rb +7 -8
  45. data/lib/puppet/file_system/file_impl.rb +17 -13
  46. data/lib/puppet/file_system/uniquefile.rb +12 -16
  47. data/lib/puppet/forge.rb +1 -1
  48. data/lib/puppet/forge/cache.rb +1 -1
  49. data/lib/puppet/forge/repository.rb +4 -7
  50. data/lib/puppet/functions/call.rb +1 -1
  51. data/lib/puppet/functions/filter.rb +1 -0
  52. data/lib/puppet/functions/lstrip.rb +4 -4
  53. data/lib/puppet/functions/new.rb +8 -3
  54. data/lib/puppet/functions/reduce.rb +2 -4
  55. data/lib/puppet/functions/reverse_each.rb +1 -1
  56. data/lib/puppet/functions/rstrip.rb +4 -4
  57. data/lib/puppet/functions/step.rb +1 -1
  58. data/lib/puppet/functions/strip.rb +4 -4
  59. data/lib/puppet/gettext/config.rb +5 -5
  60. data/lib/puppet/gettext/module_translations.rb +4 -4
  61. data/lib/puppet/http.rb +3 -0
  62. data/lib/puppet/http/client.rb +215 -60
  63. data/lib/puppet/http/external_client.rb +90 -0
  64. data/lib/puppet/http/redirector.rb +43 -7
  65. data/lib/puppet/http/resolver.rb +43 -3
  66. data/lib/puppet/http/resolver/server_list.rb +66 -24
  67. data/lib/puppet/http/resolver/settings.rb +21 -1
  68. data/lib/puppet/http/resolver/srv.rb +28 -2
  69. data/lib/puppet/http/response.rb +82 -1
  70. data/lib/puppet/http/retry_after_handler.rb +39 -0
  71. data/lib/puppet/http/service.rb +70 -2
  72. data/lib/puppet/http/service/ca.rb +71 -9
  73. data/lib/puppet/http/service/compiler.rb +214 -12
  74. data/lib/puppet/http/service/file_server.rb +106 -5
  75. data/lib/puppet/http/service/puppetserver.rb +39 -0
  76. data/lib/puppet/http/service/report.rb +36 -3
  77. data/lib/puppet/http/session.rb +60 -8
  78. data/lib/puppet/indirector.rb +1 -1
  79. data/lib/puppet/indirector/catalog/compiler.rb +1 -1
  80. data/lib/puppet/indirector/catalog/rest.rb +2 -1
  81. data/lib/puppet/indirector/exec.rb +1 -1
  82. data/lib/puppet/indirector/facts/facter.rb +3 -3
  83. data/lib/puppet/indirector/facts/rest.rb +2 -1
  84. data/lib/puppet/indirector/facts/yaml.rb +1 -1
  85. data/lib/puppet/indirector/file_bucket_file/rest.rb +48 -0
  86. data/lib/puppet/indirector/file_content/http.rb +5 -0
  87. data/lib/puppet/indirector/file_content/rest.rb +1 -1
  88. data/lib/puppet/indirector/file_metadata/http.rb +28 -8
  89. data/lib/puppet/indirector/file_metadata/rest.rb +6 -4
  90. data/lib/puppet/indirector/hiera.rb +4 -0
  91. data/lib/puppet/indirector/indirection.rb +1 -1
  92. data/lib/puppet/indirector/json.rb +1 -1
  93. data/lib/puppet/indirector/msgpack.rb +1 -1
  94. data/lib/puppet/indirector/node/rest.rb +2 -1
  95. data/lib/puppet/indirector/report/processor.rb +2 -2
  96. data/lib/puppet/indirector/report/yaml.rb +23 -0
  97. data/lib/puppet/indirector/request.rb +5 -5
  98. data/lib/puppet/indirector/rest.rb +7 -1
  99. data/lib/puppet/indirector/status/rest.rb +2 -1
  100. data/lib/puppet/indirector/yaml.rb +1 -1
  101. data/lib/puppet/metatype/manager.rb +80 -80
  102. data/lib/puppet/module.rb +1 -2
  103. data/lib/puppet/network/format_support.rb +2 -2
  104. data/lib/puppet/network/http/api/indirected_routes.rb +1 -1
  105. data/lib/puppet/network/http/api/master/v3/environment.rb +3 -0
  106. data/lib/puppet/network/http/api/master/v3/environments.rb +0 -1
  107. data/lib/puppet/network/http/base_pool.rb +6 -1
  108. data/lib/puppet/network/http/compression.rb +7 -0
  109. data/lib/puppet/network/http/connection.rb +2 -0
  110. data/lib/puppet/network/http/connection_adapter.rb +184 -0
  111. data/lib/puppet/network/http/nocache_pool.rb +1 -0
  112. data/lib/puppet/network/http/pool.rb +2 -4
  113. data/lib/puppet/network/http/route.rb +2 -2
  114. data/lib/puppet/network/http_pool.rb +2 -1
  115. data/lib/puppet/node/environment.rb +22 -5
  116. data/lib/puppet/node/facts.rb +17 -0
  117. data/lib/puppet/pal/catalog_compiler.rb +5 -0
  118. data/lib/puppet/pal/pal_impl.rb +30 -31
  119. data/lib/puppet/parameter.rb +1 -1
  120. data/lib/puppet/parser/ast/leaf.rb +5 -5
  121. data/lib/puppet/parser/ast/pops_bridge.rb +0 -4
  122. data/lib/puppet/parser/compiler.rb +43 -33
  123. data/lib/puppet/parser/compiler/catalog_validator/env_relationship_validator.rb +2 -0
  124. data/lib/puppet/parser/compiler/catalog_validator/site_validator.rb +2 -0
  125. data/lib/puppet/parser/environment_compiler.rb +4 -1
  126. data/lib/puppet/parser/functions.rb +18 -9
  127. data/lib/puppet/parser/functions/create_resources.rb +11 -7
  128. data/lib/puppet/parser/functions/filter.rb +1 -0
  129. data/lib/puppet/parser/resource.rb +3 -2
  130. data/lib/puppet/parser/resource/param.rb +6 -0
  131. data/lib/puppet/parser/type_loader.rb +2 -2
  132. data/lib/puppet/pops/adaptable.rb +7 -13
  133. data/lib/puppet/pops/adapters.rb +8 -4
  134. data/lib/puppet/pops/evaluator/collectors/abstract_collector.rb +1 -3
  135. data/lib/puppet/pops/evaluator/evaluator_impl.rb +5 -5
  136. data/lib/puppet/pops/evaluator/runtime3_converter.rb +2 -2
  137. data/lib/puppet/pops/issues.rb +5 -0
  138. data/lib/puppet/pops/loader/runtime3_type_loader.rb +4 -2
  139. data/lib/puppet/pops/loaders.rb +24 -15
  140. data/lib/puppet/pops/lookup/context.rb +1 -1
  141. data/lib/puppet/pops/lookup/hiera_config.rb +14 -1
  142. data/lib/puppet/pops/resource/resource_type_impl.rb +2 -0
  143. data/lib/puppet/pops/types/iterable.rb +34 -8
  144. data/lib/puppet/pops/types/p_meta_type.rb +1 -1
  145. data/lib/puppet/pops/types/p_type_set_type.rb +4 -0
  146. data/lib/puppet/pops/validation/checker4_0.rb +29 -15
  147. data/lib/puppet/pops/validation/validator_factory_4_0.rb +1 -0
  148. data/lib/puppet/provider/file/windows.rb +1 -1
  149. data/lib/puppet/provider/group/windows_adsi.rb +3 -3
  150. data/lib/puppet/provider/package/aix.rb +17 -2
  151. data/lib/puppet/provider/package/apt.rb +98 -1
  152. data/lib/puppet/provider/package/aptitude.rb +1 -1
  153. data/lib/puppet/provider/package/dnfmodule.rb +61 -14
  154. data/lib/puppet/provider/package/dpkg.rb +1 -1
  155. data/lib/puppet/provider/package/gem.rb +45 -9
  156. data/lib/puppet/provider/package/pacman.rb +2 -5
  157. data/lib/puppet/provider/package/pip.rb +143 -48
  158. data/lib/puppet/provider/package/pip2.rb +17 -0
  159. data/lib/puppet/provider/package/pip3.rb +0 -2
  160. data/lib/puppet/provider/package/pkgdmg.rb +1 -1
  161. data/lib/puppet/provider/package/pkgng.rb +16 -4
  162. data/lib/puppet/provider/package/portage.rb +2 -2
  163. data/lib/puppet/provider/package/puppet_gem.rb +11 -2
  164. data/lib/puppet/provider/package/puppetserver_gem.rb +180 -0
  165. data/lib/puppet/provider/package/rpm.rb +6 -213
  166. data/lib/puppet/provider/package/yum.rb +101 -20
  167. data/lib/puppet/provider/package/zypper.rb +62 -1
  168. data/lib/puppet/provider/service/systemd.rb +22 -4
  169. data/lib/puppet/provider/service/windows.rb +23 -7
  170. data/lib/puppet/provider/user/aix.rb +1 -1
  171. data/lib/puppet/provider/user/user_role_add.rb +1 -1
  172. data/lib/puppet/provider/user/useradd.rb +16 -5
  173. data/lib/puppet/provider/user/windows_adsi.rb +18 -1
  174. data/lib/puppet/reports/http.rb +15 -9
  175. data/lib/puppet/resource.rb +2 -1
  176. data/lib/puppet/resource/type.rb +10 -1
  177. data/lib/puppet/resource/type_collection.rb +20 -16
  178. data/lib/puppet/rest/route.rb +2 -2
  179. data/lib/puppet/runtime.rb +25 -2
  180. data/lib/puppet/settings.rb +20 -6
  181. data/lib/puppet/ssl.rb +1 -0
  182. data/lib/puppet/ssl/host.rb +4 -4
  183. data/lib/puppet/ssl/oids.rb +1 -0
  184. data/lib/puppet/ssl/ssl_context.rb +2 -2
  185. data/lib/puppet/ssl/ssl_provider.rb +20 -1
  186. data/lib/puppet/ssl/state_machine.rb +79 -37
  187. data/lib/puppet/ssl/validator/default_validator.rb +1 -1
  188. data/lib/puppet/ssl/verifier_adapter.rb +9 -1
  189. data/lib/puppet/test/test_helper.rb +19 -14
  190. data/lib/puppet/transaction.rb +2 -2
  191. data/lib/puppet/transaction/persistence.rb +1 -1
  192. data/lib/puppet/transaction/report.rb +14 -10
  193. data/lib/puppet/trusted_external.rb +29 -1
  194. data/lib/puppet/type.rb +21 -8
  195. data/lib/puppet/type/file.rb +40 -15
  196. data/lib/puppet/type/file/checksum.rb +4 -4
  197. data/lib/puppet/type/file/source.rb +35 -13
  198. data/lib/puppet/type/filebucket.rb +1 -1
  199. data/lib/puppet/type/notify.rb +2 -2
  200. data/lib/puppet/type/package.rb +41 -3
  201. data/lib/puppet/type/service.rb +59 -8
  202. data/lib/puppet/type/user.rb +19 -29
  203. data/lib/puppet/util.rb +41 -3
  204. data/lib/puppet/util/at_fork.rb +1 -1
  205. data/lib/puppet/util/autoload.rb +13 -25
  206. data/lib/puppet/util/character_encoding.rb +9 -5
  207. data/lib/puppet/util/checksums.rb +19 -4
  208. data/lib/puppet/util/connection.rb +8 -8
  209. data/lib/puppet/util/execution.rb +2 -2
  210. data/lib/puppet/util/fileparsing.rb +2 -2
  211. data/lib/puppet/util/instance_loader.rb +14 -10
  212. data/lib/puppet/util/log/destinations.rb +1 -10
  213. data/lib/puppet/util/package/version/debian.rb +175 -0
  214. data/lib/puppet/util/package/version/gem.rb +15 -0
  215. data/lib/puppet/util/package/version/pip.rb +167 -0
  216. data/lib/puppet/util/package/version/range.rb +53 -0
  217. data/lib/puppet/util/package/version/range/eq.rb +14 -0
  218. data/lib/puppet/util/package/version/range/gt.rb +14 -0
  219. data/lib/puppet/util/package/version/range/gt_eq.rb +14 -0
  220. data/lib/puppet/util/package/version/range/lt.rb +14 -0
  221. data/lib/puppet/util/package/version/range/lt_eq.rb +14 -0
  222. data/lib/puppet/util/package/version/range/min_max.rb +21 -0
  223. data/lib/puppet/util/package/version/range/simple.rb +11 -0
  224. data/lib/puppet/util/package/version/rpm.rb +73 -0
  225. data/lib/puppet/util/pidlock.rb +13 -7
  226. data/lib/puppet/util/platform.rb +5 -0
  227. data/lib/puppet/util/provider_features.rb +1 -1
  228. data/lib/puppet/util/reference.rb +1 -1
  229. data/lib/puppet/util/rpm_compare.rb +193 -0
  230. data/lib/puppet/util/run_mode.rb +5 -1
  231. data/lib/puppet/util/windows.rb +1 -0
  232. data/lib/puppet/util/windows/adsi.rb +2 -2
  233. data/lib/puppet/util/windows/api_types.rb +60 -33
  234. data/lib/puppet/util/windows/eventlog.rb +1 -6
  235. data/lib/puppet/util/windows/monkey_patches/dir.rb +40 -0
  236. data/lib/puppet/util/windows/principal.rb +8 -6
  237. data/lib/puppet/util/windows/process.rb +15 -14
  238. data/lib/puppet/util/windows/registry.rb +11 -11
  239. data/lib/puppet/util/windows/security.rb +5 -4
  240. data/lib/puppet/util/windows/service.rb +43 -26
  241. data/lib/puppet/util/windows/sid.rb +3 -3
  242. data/lib/puppet/util/windows/user.rb +242 -8
  243. data/lib/puppet/version.rb +1 -1
  244. data/locales/puppet.pot +627 -507
  245. data/man/man5/puppet.conf.5 +93 -20
  246. data/man/man8/puppet-agent.8 +7 -4
  247. data/man/man8/puppet-apply.8 +1 -1
  248. data/man/man8/puppet-catalog.8 +1 -1
  249. data/man/man8/puppet-config.8 +6 -6
  250. data/man/man8/puppet-describe.8 +1 -1
  251. data/man/man8/puppet-device.8 +1 -1
  252. data/man/man8/puppet-doc.8 +1 -1
  253. data/man/man8/puppet-epp.8 +1 -1
  254. data/man/man8/puppet-facts.8 +1 -1
  255. data/man/man8/puppet-filebucket.8 +1 -1
  256. data/man/man8/puppet-generate.8 +1 -1
  257. data/man/man8/puppet-help.8 +6 -3
  258. data/man/man8/puppet-key.8 +1 -1
  259. data/man/man8/puppet-lookup.8 +2 -2
  260. data/man/man8/puppet-man.8 +1 -1
  261. data/man/man8/puppet-module.8 +4 -1
  262. data/man/man8/puppet-node.8 +4 -4
  263. data/man/man8/puppet-parser.8 +1 -1
  264. data/man/man8/puppet-plugin.8 +1 -1
  265. data/man/man8/puppet-report.8 +1 -1
  266. data/man/man8/puppet-resource.8 +1 -1
  267. data/man/man8/puppet-script.8 +1 -1
  268. data/man/man8/puppet-ssl.8 +1 -1
  269. data/man/man8/puppet-status.8 +2 -2
  270. data/man/man8/puppet.8 +2 -2
  271. data/spec/fixtures/integration/application/apply/environments/spec/modules/amod/lib/puppet/provider/applytest/applytest.rb +2 -0
  272. data/spec/fixtures/integration/application/apply/environments/spec/modules/amod/lib/puppet/type/applytest.rb +25 -0
  273. data/spec/fixtures/ssl/unknown-127.0.0.1-key.pem +67 -0
  274. data/spec/fixtures/ssl/unknown-127.0.0.1.pem +48 -0
  275. data/spec/fixtures/ssl/unknown-ca-key.pem +67 -0
  276. data/spec/fixtures/ssl/unknown-ca.pem +59 -0
  277. data/spec/fixtures/unit/forge/bacula-releases.json +128 -0
  278. data/spec/fixtures/unit/forge/bacula.tar.gz +0 -0
  279. data/spec/fixtures/unit/provider/package/dnfmodule/{dnf-module-list-installed.txt → dnf-module-list.txt} +8 -0
  280. data/spec/fixtures/unit/provider/package/pkgng/pkg.version +2 -0
  281. data/spec/fixtures/unit/provider/package/puppetserver_gem/gem-list-local-packages +30 -0
  282. data/spec/fixtures/unit/provider/package/yum/yum-check-update-subscription-manager.txt +9 -0
  283. data/spec/fixtures/unit/provider/package/zypper/zypper-search-uninstalled.out +13 -0
  284. data/spec/fixtures/unit/provider/service/systemd/list_unit_files_services +9 -0
  285. data/spec/integration/application/agent_spec.rb +479 -0
  286. data/spec/integration/application/apply_spec.rb +279 -150
  287. data/spec/integration/application/config_spec.rb +74 -0
  288. data/spec/integration/application/doc_spec.rb +16 -6
  289. data/spec/integration/application/filebucket_spec.rb +239 -0
  290. data/spec/integration/application/help_spec.rb +42 -0
  291. data/spec/integration/application/lookup_spec.rb +13 -0
  292. data/spec/integration/application/module_spec.rb +68 -0
  293. data/spec/integration/application/plugin_spec.rb +123 -0
  294. data/spec/integration/configurer_spec.rb +14 -0
  295. data/spec/integration/data_binding_spec.rb +82 -0
  296. data/spec/integration/defaults_spec.rb +27 -3
  297. data/spec/integration/directory_environments_spec.rb +17 -17
  298. data/spec/integration/http/client_spec.rb +39 -40
  299. data/spec/integration/indirector/facts/facter_spec.rb +8 -6
  300. data/spec/integration/indirector/report/yaml.rb +83 -0
  301. data/spec/integration/network/http_pool_spec.rb +84 -19
  302. data/spec/integration/node/environment_spec.rb +15 -0
  303. data/spec/integration/parser/compiler_spec.rb +11 -0
  304. data/spec/integration/type/file_spec.rb +1 -1
  305. data/spec/integration/util/execution_spec.rb +22 -0
  306. data/spec/integration/util/windows/adsi_spec.rb +8 -3
  307. data/spec/integration/util/windows/monkey_patches/dir_spec.rb +11 -0
  308. data/spec/integration/util/windows/process_spec.rb +26 -32
  309. data/spec/integration/util/windows/registry_spec.rb +7 -7
  310. data/spec/integration/util/windows/user_spec.rb +47 -5
  311. data/spec/integration/util_spec.rb +7 -33
  312. data/spec/lib/puppet/test_ca.rb +2 -2
  313. data/spec/lib/puppet_spec/https.rb +16 -7
  314. data/spec/lib/puppet_spec/matchers.rb +0 -80
  315. data/spec/lib/puppet_spec/puppetserver.rb +127 -0
  316. data/spec/shared_contexts/https.rb +29 -0
  317. data/spec/shared_contexts/types_setup.rb +2 -0
  318. data/spec/unit/agent_spec.rb +80 -26
  319. data/spec/unit/application/agent_spec.rb +12 -9
  320. data/spec/unit/application/device_spec.rb +2 -2
  321. data/spec/unit/application/doc_spec.rb +2 -2
  322. data/spec/unit/application/face_base_spec.rb +6 -4
  323. data/spec/unit/application/facts_spec.rb +41 -10
  324. data/spec/unit/application/filebucket_spec.rb +22 -2
  325. data/spec/unit/application/man_spec.rb +52 -0
  326. data/spec/unit/application/resource_spec.rb +3 -1
  327. data/spec/unit/application/ssl_spec.rb +15 -2
  328. data/spec/unit/application_spec.rb +9 -4
  329. data/spec/unit/configurer/downloader_spec.rb +10 -0
  330. data/spec/unit/configurer/fact_handler_spec.rb +4 -4
  331. data/spec/unit/configurer_spec.rb +87 -38
  332. data/spec/unit/confine_spec.rb +2 -1
  333. data/spec/unit/context/trusted_information_spec.rb +25 -2
  334. data/spec/unit/daemon_spec.rb +5 -64
  335. data/spec/unit/defaults_spec.rb +24 -1
  336. data/spec/unit/environments_spec.rb +107 -32
  337. data/spec/unit/face/config_spec.rb +59 -1
  338. data/spec/unit/face/module/search_spec.rb +17 -0
  339. data/spec/unit/face/node_spec.rb +2 -2
  340. data/spec/unit/file_serving/http_metadata_spec.rb +37 -14
  341. data/spec/unit/file_serving/mount/locales_spec.rb +2 -2
  342. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +2 -2
  343. data/spec/unit/file_serving/mount/plugins_spec.rb +2 -2
  344. data/spec/unit/file_serving/terminus_selector_spec.rb +45 -26
  345. data/spec/unit/file_system/uniquefile_spec.rb +29 -0
  346. data/spec/unit/file_system_spec.rb +11 -2
  347. data/spec/unit/http/client_spec.rb +173 -59
  348. data/spec/unit/http/external_client_spec.rb +201 -0
  349. data/spec/unit/http/resolver_spec.rb +44 -5
  350. data/spec/unit/http/response_spec.rb +6 -0
  351. data/spec/unit/http/service/ca_spec.rb +27 -5
  352. data/spec/unit/http/service/compiler_spec.rb +186 -9
  353. data/spec/unit/http/service/file_server_spec.rb +37 -6
  354. data/spec/unit/http/service/puppetserver_spec.rb +82 -0
  355. data/spec/unit/http/service/report_spec.rb +5 -4
  356. data/spec/unit/http/service_spec.rb +3 -4
  357. data/spec/unit/http/session_spec.rb +48 -12
  358. data/spec/unit/indirector/catalog/compiler_spec.rb +1 -0
  359. data/spec/unit/indirector/catalog/json_spec.rb +1 -1
  360. data/spec/unit/indirector/catalog/rest_spec.rb +1 -1
  361. data/spec/unit/indirector/facts/rest_spec.rb +1 -1
  362. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +82 -2
  363. data/spec/unit/indirector/file_metadata/http_spec.rb +194 -0
  364. data/spec/unit/indirector/file_metadata/rest_spec.rb +15 -14
  365. data/spec/unit/indirector/json_spec.rb +8 -8
  366. data/spec/unit/indirector/msgpack_spec.rb +8 -8
  367. data/spec/unit/indirector/node/rest_spec.rb +1 -1
  368. data/spec/unit/indirector/request_spec.rb +5 -5
  369. data/spec/unit/indirector/rest_spec.rb +14 -1
  370. data/spec/unit/indirector/status/rest_spec.rb +1 -1
  371. data/spec/unit/indirector/yaml_spec.rb +7 -7
  372. data/spec/unit/interface_spec.rb +3 -3
  373. data/spec/unit/module_tool/tar/mini_spec.rb +20 -0
  374. data/spec/unit/network/format_support_spec.rb +3 -2
  375. data/spec/unit/network/http/api/indirected_routes_spec.rb +2 -1
  376. data/spec/unit/network/http/api/master/v3/environments_spec.rb +12 -23
  377. data/spec/unit/network/http/connection_spec.rb +552 -190
  378. data/spec/unit/network/http/nocache_pool_spec.rb +22 -0
  379. data/spec/unit/network/http/pool_spec.rb +3 -3
  380. data/spec/unit/network/http_pool_spec.rb +63 -57
  381. data/spec/unit/network/http_spec.rb +1 -1
  382. data/spec/unit/node/environment_spec.rb +33 -0
  383. data/spec/unit/parser/ast/block_expression_spec.rb +1 -1
  384. data/spec/unit/parser/environment_compiler_spec.rb +7 -0
  385. data/spec/unit/parser/scope_spec.rb +1 -1
  386. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +15 -1
  387. data/spec/unit/pops/loaders/loaders_spec.rb +71 -1
  388. data/spec/unit/pops/lookup/lookup_spec.rb +25 -0
  389. data/spec/unit/pops/types/type_calculator_spec.rb +1 -11
  390. data/spec/unit/provider/exec_spec.rb +4 -3
  391. data/spec/unit/provider/group/windows_adsi_spec.rb +43 -10
  392. data/spec/unit/provider/package/aix_spec.rb +29 -0
  393. data/spec/unit/provider/package/apt_spec.rb +107 -0
  394. data/spec/unit/provider/package/aptitude_spec.rb +1 -0
  395. data/spec/unit/provider/package/dnfmodule_spec.rb +54 -15
  396. data/spec/unit/provider/package/dpkg_spec.rb +22 -7
  397. data/spec/unit/provider/package/gem_spec.rb +40 -0
  398. data/spec/unit/provider/package/openbsd_spec.rb +2 -0
  399. data/spec/unit/provider/package/pacman_spec.rb +6 -21
  400. data/spec/unit/provider/package/pip2_spec.rb +36 -0
  401. data/spec/unit/provider/package/pip_spec.rb +68 -19
  402. data/spec/unit/provider/package/pkgdmg_spec.rb +1 -1
  403. data/spec/unit/provider/package/pkgng_spec.rb +38 -0
  404. data/spec/unit/provider/package/portage_spec.rb +5 -0
  405. data/spec/unit/provider/package/puppet_gem_spec.rb +12 -1
  406. data/spec/unit/provider/package/puppetserver_gem_spec.rb +137 -0
  407. data/spec/unit/provider/package/rpm_spec.rb +0 -212
  408. data/spec/unit/provider/package/yum_spec.rb +274 -1
  409. data/spec/unit/provider/package/zypper_spec.rb +98 -0
  410. data/spec/unit/provider/service/base_spec.rb +2 -4
  411. data/spec/unit/provider/service/bsd_spec.rb +5 -1
  412. data/spec/unit/provider/service/daemontools_spec.rb +1 -1
  413. data/spec/unit/provider/service/debian_spec.rb +3 -5
  414. data/spec/unit/provider/service/freebsd_spec.rb +1 -1
  415. data/spec/unit/provider/service/gentoo_spec.rb +4 -5
  416. data/spec/unit/provider/service/init_spec.rb +46 -5
  417. data/spec/unit/provider/service/launchd_spec.rb +5 -6
  418. data/spec/unit/provider/service/openbsd_spec.rb +9 -0
  419. data/spec/unit/provider/service/openrc_spec.rb +4 -5
  420. data/spec/unit/provider/service/openwrt_spec.rb +2 -1
  421. data/spec/unit/provider/service/redhat_spec.rb +10 -1
  422. data/spec/unit/provider/service/runit_spec.rb +2 -1
  423. data/spec/unit/provider/service/smf_spec.rb +1 -1
  424. data/spec/unit/provider/service/src_spec.rb +3 -5
  425. data/spec/unit/provider/service/systemd_spec.rb +95 -18
  426. data/spec/unit/provider/service/upstart_spec.rb +4 -5
  427. data/spec/unit/provider/service/windows_spec.rb +50 -14
  428. data/spec/unit/provider/user/openbsd_spec.rb +1 -0
  429. data/spec/unit/provider/user/useradd_spec.rb +30 -16
  430. data/spec/unit/provider/user/windows_adsi_spec.rb +85 -3
  431. data/spec/unit/puppet_pal_2pec.rb +11 -0
  432. data/spec/unit/puppet_pal_catalog_spec.rb +43 -0
  433. data/spec/unit/puppet_spec.rb +33 -0
  434. data/spec/unit/reports/http_spec.rb +70 -52
  435. data/spec/unit/reports/store_spec.rb +17 -13
  436. data/spec/unit/resource_spec.rb +3 -3
  437. data/spec/unit/rest/route_spec.rb +4 -4
  438. data/spec/unit/settings_spec.rb +44 -22
  439. data/spec/unit/ssl/host_spec.rb +4 -2
  440. data/spec/unit/ssl/oids_spec.rb +1 -0
  441. data/spec/unit/ssl/ssl_provider_spec.rb +69 -43
  442. data/spec/unit/ssl/state_machine_spec.rb +90 -14
  443. data/spec/unit/test/test_helper_spec.rb +17 -0
  444. data/spec/unit/transaction/persistence_spec.rb +15 -0
  445. data/spec/unit/transaction/report_spec.rb +7 -1
  446. data/spec/unit/type/file/source_spec.rb +4 -4
  447. data/spec/unit/type/file_spec.rb +122 -96
  448. data/spec/unit/type/filebucket_spec.rb +1 -1
  449. data/spec/unit/type/service_spec.rb +218 -8
  450. data/spec/unit/type/user_spec.rb +32 -3
  451. data/spec/unit/type_spec.rb +50 -0
  452. data/spec/unit/util/at_fork_spec.rb +2 -2
  453. data/spec/unit/util/autoload_spec.rb +2 -1
  454. data/spec/unit/util/character_encoding_spec.rb +4 -4
  455. data/spec/unit/util/checksums_spec.rb +16 -0
  456. data/spec/unit/util/command_line_spec.rb +11 -6
  457. data/spec/unit/util/log/destinations_spec.rb +1 -29
  458. data/spec/unit/util/package/version/debian_spec.rb +83 -0
  459. data/spec/unit/util/package/version/pip_spec.rb +464 -0
  460. data/spec/unit/util/package/version/range_spec.rb +175 -0
  461. data/spec/unit/util/package/version/rpm_spec.rb +121 -0
  462. data/spec/unit/util/pidlock_spec.rb +83 -47
  463. data/spec/unit/util/rpm_compare_spec.rb +196 -0
  464. data/spec/unit/util/run_mode_spec.rb +6 -6
  465. data/spec/unit/util/windows/adsi_spec.rb +4 -4
  466. data/spec/unit/util/windows/api_types_spec.rb +104 -40
  467. data/spec/unit/util/windows/service_spec.rb +4 -4
  468. data/spec/unit/util/windows/sid_spec.rb +2 -2
  469. data/spec/unit/util_spec.rb +3 -3
  470. data/spec/unit/x509/cert_provider_spec.rb +1 -1
  471. data/tasks/generate_cert_fixtures.rake +15 -1
  472. data/tasks/manpages.rake +5 -35
  473. metadata +90 -51
  474. data/spec/integration/faces/config_spec.rb +0 -91
  475. data/spec/integration/faces/documentation_spec.rb +0 -57
  476. data/spec/integration/faces/plugin_spec.rb +0 -63
  477. data/spec/integration/file_bucket/file_spec.rb +0 -50
  478. data/spec/integration/file_serving/content_spec.rb +0 -7
  479. data/spec/integration/file_serving/fileset_spec.rb +0 -12
  480. data/spec/integration/file_serving/metadata_spec.rb +0 -8
  481. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -20
  482. data/spec/integration/file_system/uniquefile_spec.rb +0 -26
  483. data/spec/integration/module_tool/forge_spec.rb +0 -64
  484. data/spec/integration/module_tool/tar/mini_spec.rb +0 -28
  485. data/spec/integration/provider/service/init_spec.rb +0 -48
  486. data/spec/integration/provider/service/systemd_spec.rb +0 -25
  487. data/spec/integration/provider/service/windows_spec.rb +0 -50
  488. data/spec/integration/reference/providers_spec.rb +0 -21
  489. data/spec/integration/reports_spec.rb +0 -13
  490. data/spec/integration/ssl/certificate_request_spec.rb +0 -44
  491. data/spec/integration/ssl/host_spec.rb +0 -72
  492. data/spec/integration/ssl/key_spec.rb +0 -99
  493. data/spec/integration/test/test_helper_spec.rb +0 -31
  494. data/spec/shared_behaviours/file_serving_model.rb +0 -51
  495. data/spec/unit/face/man_spec.rb +0 -25
  496. data/spec/unit/man_spec.rb +0 -31
@@ -1,10 +1,10 @@
1
- # encoding: UTF-8
1
+ # encoding: utf-8
2
2
  require 'spec_helper'
3
3
 
4
4
  describe Puppet::Type.type(:user) do
5
5
  before :each do
6
6
  @provider_class = described_class.provide(:simple) do
7
- has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_shell
7
+ has_features :manages_expiry, :manages_password_age, :manages_passwords, :manages_solaris_rbac, :manages_roles, :manages_shell
8
8
  mk_resource_methods
9
9
  def create; end
10
10
  def delete; end
@@ -35,6 +35,10 @@ describe Puppet::Type.type(:user) do
35
35
  expect(described_class.provider_feature(:manages_solaris_rbac)).not_to be_nil
36
36
  end
37
37
 
38
+ it "should have a manages_roles feature" do
39
+ expect(described_class.provider_feature(:manages_roles)).not_to be_nil
40
+ end
41
+
38
42
  it "should have a manages_expiry feature" do
39
43
  expect(described_class.provider_feature(:manages_expiry)).not_to be_nil
40
44
  end
@@ -401,7 +405,7 @@ describe Puppet::Type.type(:user) do
401
405
  end
402
406
 
403
407
  describe "when user has roles" do
404
- it "should autorequire roles" do
408
+ it "should autorequire roles on non-Windows", :unless => Puppet::Util::Platform.windows? do
405
409
  testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
406
410
  testrole = described_class.new(:name => "testrole")
407
411
 
@@ -413,6 +417,31 @@ describe Puppet::Type.type(:user) do
413
417
  expect(rel.source.ref).to eq(testrole.ref)
414
418
  expect(rel.target.ref).to eq(testuser.ref)
415
419
  end
420
+
421
+ it "should not autorequire roles on Windows", :if => Puppet::Util::Platform.windows? do
422
+ testuser = described_class.new(:name => "testuser", :roles => ['testrole'] )
423
+ testrole = described_class.new(:name => "testrole")
424
+
425
+ Puppet::Resource::Catalog.new :testing do |conf|
426
+ [testuser, testrole].each { |resource| conf.add_resource resource }
427
+ end
428
+
429
+ expect(testuser.autorequire).to be_empty
430
+ end
431
+
432
+ it "should sync the user roles when changing the state of :ensure if :roles is being managed" do
433
+ user = Puppet::Type.type(:user).new(:name => "myUser", :ensure => :present)
434
+ user[:roles] = 'testRole'
435
+
436
+ allow(user.provider.class).to receive(:supports_parameter?).and_return(true)
437
+ expect(user.property(:roles)).to receive(:retrieve).and_return("other")
438
+ expect(user.property(:roles)).to receive(:insync?).and_return(false)
439
+ expect(user.property(:roles)).to receive(:sync)
440
+
441
+ allow(user.provider).to receive(:create)
442
+
443
+ user.property(:ensure).sync
444
+ end
416
445
  end
417
446
 
418
447
  describe "when setting shell" do
@@ -1099,6 +1099,56 @@ describe Puppet::Type, :unless => Puppet::Util::Platform.windows? do
1099
1099
  expect { expect(type.instances).to eq([]) }.to_not raise_error
1100
1100
  end
1101
1101
 
1102
+ context "with a composite namevar type" do
1103
+ let :type do
1104
+ Puppet::Type.newtype(:type_spec_fake_type) do
1105
+ newparam(:name) do
1106
+ isnamevar
1107
+ end
1108
+
1109
+ newparam(:path) do
1110
+ isnamevar
1111
+ end
1112
+
1113
+ def self.title_patterns
1114
+ [[%r{^(.*)@(.*)$}, [:name, :path]], [%r{^([^@]+)$}, [:name]]]
1115
+ end
1116
+
1117
+ newproperty(:prop1) {}
1118
+ end
1119
+
1120
+ Puppet::Type.type(:type_spec_fake_type)
1121
+ end
1122
+
1123
+ before :each do
1124
+ type.provide(:default) do
1125
+ defaultfor :operatingsystem => Facter.value(:operatingsystem)
1126
+ mk_resource_methods
1127
+ class << self
1128
+ attr_accessor :params
1129
+ end
1130
+
1131
+ def title
1132
+ "#{@property_hash[:name]}@#{@property_hash[:path]}"
1133
+ end
1134
+
1135
+ def self.instance(name, path)
1136
+ new(:name => name, :path => path, :ensure => :present)
1137
+ end
1138
+
1139
+ def self.instances
1140
+ @instances ||= params.collect { |param| instance(param.first.to_s, param.last.to_s) }
1141
+ end
1142
+
1143
+ @params = [[:name_one, :path_one], [:name_two, :path_two]]
1144
+ end
1145
+ end
1146
+
1147
+ it "should return composite titles for the instances" do
1148
+ expect(type.instances.map(&:title)).to eq(["name_one@path_one", "name_two@path_two"])
1149
+ end
1150
+ end
1151
+
1102
1152
  context "with a default provider" do
1103
1153
  before :each do
1104
1154
  type.provide(:default) do
@@ -19,7 +19,7 @@ describe 'Puppet::Util::AtFork' do
19
19
  describe '.get_handler' do
20
20
  context 'when on Solaris' do
21
21
  before :each do
22
- expect(Facter).to receive(:value).with(:operatingsystem).and_return('Solaris')
22
+ expect(Puppet::Util::Platform).to receive(:solaris?).and_return(true)
23
23
  end
24
24
 
25
25
  after :each do
@@ -114,7 +114,7 @@ describe 'Puppet::Util::AtFork' do
114
114
 
115
115
  context 'when NOT on Solaris' do
116
116
  before :each do
117
- expect(Facter).to receive(:value).with(:operatingsystem).and_return(nil)
117
+ expect(Puppet::Util::Platform).to receive(:solaris?).and_return(false)
118
118
  end
119
119
 
120
120
  def stub_noop_handler(namespace_only = false)
@@ -23,10 +23,10 @@ describe Puppet::Util::Autoload do
23
23
 
24
24
  def with_libdir(libdir)
25
25
  begin
26
- Puppet::Util::Autoload.instance_variable_set(:@initialized, false)
27
26
  old_loadpath = $LOAD_PATH.dup
28
27
  old_libdir = Puppet[:libdir]
29
28
  Puppet[:libdir] = libdir
29
+ $LOAD_PATH.unshift(libdir)
30
30
  yield
31
31
  ensure
32
32
  Puppet[:libdir] = old_libdir
@@ -83,6 +83,7 @@ describe Puppet::Util::Autoload do
83
83
 
84
84
  libdir = File.expand_path('/libdir1')
85
85
  Puppet[:vendormoduledir] = vendor_dir
86
+ Puppet.initialize_settings
86
87
 
87
88
  with_libdir(libdir) do
88
89
  expect(@autoload.class).to receive(:gem_directories).and_return(%w{/one /two})
@@ -21,7 +21,7 @@ describe Puppet::Util::CharacterEncoding do
21
21
  let(:invalid_utf8_string) { "\xfd\xf1".force_encoding(Encoding::UTF_8) }
22
22
 
23
23
  it "should issue a debug message" do
24
- expect(Puppet).to receive(:debug).with(/encoding is invalid/)
24
+ expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/encoding is invalid/) }
25
25
  Puppet::Util::CharacterEncoding.convert_to_utf_8(invalid_utf8_string)
26
26
  end
27
27
 
@@ -80,7 +80,7 @@ describe Puppet::Util::CharacterEncoding do
80
80
  end
81
81
 
82
82
  it "should issue a debug message that the string was not transcodable" do
83
- expect(Puppet).to receive(:debug).with(/cannot be transcoded/)
83
+ expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/cannot be transcoded/) }
84
84
  PuppetSpec::CharacterEncoding.with_external_encoding(Encoding::Windows_31J) do
85
85
  Puppet::Util::CharacterEncoding.convert_to_utf_8(invalid_win_31j)
86
86
  end
@@ -124,7 +124,7 @@ describe Puppet::Util::CharacterEncoding do
124
124
  let(:euc_kr) { [253, 241].pack('C*').force_encoding(Encoding::ASCII) }
125
125
 
126
126
  it "should issue a debug message" do
127
- expect(Puppet).to receive(:debug).with(/cannot be transcoded/)
127
+ expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/cannot be transcoded/) }
128
128
  Puppet::Util::CharacterEncoding.convert_to_utf_8(euc_kr)
129
129
  end
130
130
 
@@ -168,7 +168,7 @@ describe Puppet::Util::CharacterEncoding do
168
168
  let(:foo) { 'foo' }
169
169
 
170
170
  it "should issue a debug message" do
171
- expect(Puppet).to receive(:debug).with(/not valid UTF-8/)
171
+ expect(Puppet).to receive(:debug) { |&b| expect(b.call).to match(/not valid UTF-8/) }
172
172
  Puppet::Util::CharacterEncoding.override_encoding_to_utf_8(oslash)
173
173
  end
174
174
 
@@ -65,6 +65,22 @@ describe Puppet::Util::Checksums do
65
65
  expect(@summer.sumtype("asdfasdfa")).to be_nil
66
66
  end
67
67
 
68
+ it "has a list of known checksum types" do
69
+ expect(@summer.known_checksum_types).to match_array(content_sums + file_only)
70
+ end
71
+
72
+ it "returns true if the checksum is valid" do
73
+ expect(@summer).to be_valid_checksum('sha1', 'fcc1715b22278a9dae322b0a34935f10d1608b9f')
74
+ end
75
+
76
+ it "returns false if the checksum is known but invalid" do
77
+ expect(@summer).to_not be_valid_checksum('sha1', 'wronglength')
78
+ end
79
+
80
+ it "returns false if the checksum type is unknown" do
81
+ expect(@summer).to_not be_valid_checksum('rot13', 'doesntmatter')
82
+ end
83
+
68
84
  {:md5 => Digest::MD5, :sha1 => Digest::SHA1, :sha256 => Digest::SHA256, :sha512 => Digest::SHA512, :sha384 => Digest::SHA384}.each do |sum, klass|
69
85
  describe("when using #{sum}") do
70
86
  it "should use #{klass} to calculate string checksums" do
@@ -62,7 +62,7 @@ describe Puppet::Util::CommandLine do
62
62
  it "should print the version and exit if #{arg} is given" do
63
63
  expect do
64
64
  described_class.new("puppet", [arg]).execute
65
- end.to have_printed(/^#{Regexp.escape(Puppet.version)}$/)
65
+ end.to output(/^#{Regexp.escape(Puppet.version)}$/).to_stdout
66
66
  end
67
67
  end
68
68
 
@@ -73,7 +73,8 @@ describe Puppet::Util::CommandLine do
73
73
 
74
74
  expect {
75
75
  commandline.execute
76
- }.to have_printed(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).and_exit_with(0)
76
+ }.to exit_with(0)
77
+ .and output(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).to_stdout
77
78
  end
78
79
  end
79
80
 
@@ -95,7 +96,8 @@ describe Puppet::Util::CommandLine do
95
96
 
96
97
  expect {
97
98
  commandline.execute
98
- }.to have_printed(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).and_exit_with(0)
99
+ }.to exit_with(0)
100
+ .and output(/Usage: puppet <subcommand> \[options\] <action> \[options\]/).to_stdout
99
101
  end
100
102
  end
101
103
 
@@ -124,7 +126,8 @@ describe Puppet::Util::CommandLine do
124
126
 
125
127
  expect {
126
128
  commandline.execute
127
- }.to have_printed(/Unknown Puppet subcommand 'whatever'/).and_exit_with(1)
129
+ }.to exit_with(1)
130
+ .and output(/Unknown Puppet subcommand 'whatever'/).to_stdout
128
131
  end
129
132
 
130
133
  it "should abort and show the help message" do
@@ -134,7 +137,8 @@ describe Puppet::Util::CommandLine do
134
137
 
135
138
  expect {
136
139
  commandline.execute
137
- }.to have_printed(/See 'puppet help' for help on available puppet subcommands/).and_exit_with(1)
140
+ }.to exit_with(1)
141
+ .and output(/See 'puppet help' for help on available puppet subcommands/).to_stdout
138
142
  end
139
143
 
140
144
  %w{--version -V}.each do |arg|
@@ -145,7 +149,8 @@ describe Puppet::Util::CommandLine do
145
149
 
146
150
  expect {
147
151
  commandline.execute
148
- }.to have_printed(%r[^#{Regexp.escape(Puppet.version)}$]).and_exit_with(1)
152
+ }.to exit_with(1)
153
+ .and output(%r[^#{Regexp.escape(Puppet.version)}$]).to_stdout
149
154
  end
150
155
  end
151
156
  end
@@ -44,41 +44,13 @@ describe Puppet::Util::Log.desttypes[:file] do
44
44
  end
45
45
  end
46
46
 
47
- describe "on POSIX systems", :if => Puppet.features.posix? do
47
+ describe "on POSIX systems", :unless => Puppet::Util::Platform.windows? do
48
48
  describe "with a normal file" do
49
49
  let (:parent) { Pathname.new('/tmp') }
50
50
  let (:abspath) { '/tmp/log' }
51
51
  let (:relpath) { 'log' }
52
52
 
53
53
  it_behaves_like "file destination"
54
-
55
- it "logs an error if it can't chown the file owner & group" do
56
- allow(File).to receive(:exist?).with(parent).and_return(true)
57
- expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(false)
58
- expect(FileUtils).to receive(:chown).with(Puppet[:user], Puppet[:group], abspath).and_raise(Errno::EPERM)
59
- expect(Puppet.features).to receive(:root?).and_return(true)
60
- expect(Puppet).to receive(:err).with("Unable to set ownership to #{Puppet[:user]}:#{Puppet[:group]} for log file: #{abspath}")
61
-
62
- @class.new(abspath)
63
- end
64
-
65
- it "doesn't attempt to chown when running as non-root" do
66
- allow(File).to receive(:exist?).with(parent).and_return(true)
67
- expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(false)
68
- expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
69
- expect(Puppet.features).to receive(:root?).and_return(false)
70
-
71
- @class.new(abspath)
72
- end
73
-
74
- it "doesn't attempt to chown when file already exists" do
75
- allow(File).to receive(:exist?).with(parent).and_return(true)
76
- expect(File).to receive(:exist?).with(Pathname.new(abspath)).and_return(true)
77
- expect(FileUtils).not_to receive(:chown).with(Puppet[:user], Puppet[:group], abspath)
78
- expect(Puppet.features).to receive(:root?).and_return(true)
79
-
80
- @class.new(abspath)
81
- end
82
54
  end
83
55
 
84
56
  describe "with a JSON file" do
@@ -0,0 +1,83 @@
1
+ require 'spec_helper'
2
+ require 'puppet/util/package/version/debian'
3
+
4
+ describe Puppet::Util::Package::Version::Debian do
5
+ context "when creating new version should fail" do
6
+ it "if is parsing symbols" do
7
+ expect { described_class.parse(:absent) }.to raise_error(described_class::ValidationFailure)
8
+ end
9
+ end
10
+ context "when creating new version" do
11
+ it "is parsing basic version" do
12
+ v = described_class.parse('1:20191210.1-0ubuntu0.19.04.2')
13
+ expect(v.epoch).to eql(1)
14
+ expect(v.upstream_version).to eql('20191210.1')
15
+ expect(v.debian_revision).to eql('0ubuntu0.19.04.2')
16
+ end
17
+
18
+ it "is parsing no epoch basic version" do
19
+ v = described_class.parse('20191210.1-0ubuntu0.19.04.2')
20
+ expect(v.epoch).to eql(0)
21
+ expect(v.upstream_version).to eql('20191210.1')
22
+ expect(v.debian_revision).to eql('0ubuntu0.19.04.2')
23
+ end
24
+
25
+ it "is parsing no debian revision basic version" do
26
+ v = described_class.parse('2.42.1+19.04')
27
+ expect(v.epoch).to eql(0)
28
+ expect(v.upstream_version).to eql('2.42.1+19.04')
29
+ expect(v.debian_revision).to eql(nil)
30
+ end
31
+
32
+ it "is parsing no epoch complex version" do
33
+ v = described_class.parse('3.32.2+git20190711-2ubuntu1~19.04.1')
34
+ expect(v.epoch).to eql(0)
35
+ expect(v.upstream_version).to eql('3.32.2+git20190711')
36
+ expect(v.debian_revision).to eql('2ubuntu1~19.04.1')
37
+ end
38
+
39
+ it "is parsing even more complex version" do
40
+ v = described_class.parse('5:1.0.0+git-20190109.133f4c4-0ubuntu2')
41
+ expect(v.epoch).to eql(5)
42
+ expect(v.upstream_version).to eql('1.0.0+git-20190109.133f4c4')
43
+ expect(v.debian_revision).to eql('0ubuntu2')
44
+ end
45
+ end
46
+ context "when comparing two versions" do
47
+ it "epoch has precedence" do
48
+ first = described_class.parse('9:99-99')
49
+ second = described_class.parse('10:01-01')
50
+ expect(first < second).to eql(true)
51
+ end
52
+ it "handles equals letters-only versions" do
53
+ lower = described_class.parse('abd-def')
54
+ higher = described_class.parse('abd-def')
55
+ expect(lower == higher).to eql(true)
56
+ end
57
+ it "shorter version is smaller" do
58
+ lower = described_class.parse('abd-de')
59
+ higher = described_class.parse('abd-def')
60
+ expect(lower < higher).to eql(true)
61
+ end
62
+ it "shorter version is smaller even with digits" do
63
+ lower = described_class.parse('a1b2d-d3e')
64
+ higher = described_class.parse('a1b2d-d3ef')
65
+ expect(lower < higher).to eql(true)
66
+ end
67
+ it "shorter version is smaller when number is less" do
68
+ lower = described_class.parse('a1b2d-d9')
69
+ higher = described_class.parse('a1b2d-d13')
70
+ expect(lower < higher).to eql(true)
71
+ end
72
+ it "handles ~ version" do
73
+ lower = described_class.parse('a1b2d-d10~')
74
+ higher = described_class.parse('a1b2d-d10')
75
+ expect(lower < higher).to eql(true)
76
+ end
77
+ it "handles letters versus -" do
78
+ lower = described_class.parse('a1b2d-d1a')
79
+ higher = described_class.parse('a1b2d-d1-')
80
+ expect(lower < higher).to eql(true)
81
+ end
82
+ end
83
+ end
@@ -0,0 +1,464 @@
1
+ require 'spec_helper'
2
+ require 'puppet/util/package/version/pip'
3
+
4
+ describe Puppet::Util::Package::Version::Pip do
5
+ describe "initialization" do
6
+ shared_examples_for 'a valid version' do |input_version, output = input_version|
7
+ [input_version, input_version.swapcase].each do |input|
8
+ it "transforms #{input} back to string(#{output}) succesfully" do
9
+ version = described_class.parse(input)
10
+ expect(version.to_s).to eq(output)
11
+ end
12
+ end
13
+
14
+ describe "comparison" do
15
+ version = described_class.parse(input_version)
16
+
17
+ # rubocop:disable UselessComparison
18
+ it "#{input_version} shouldn't be lesser than itself" do
19
+ expect(version < version).to eq(false)
20
+ end
21
+
22
+ it "#{input_version} shouldn't be greater than itself" do
23
+ expect(version > version).to eq(false)
24
+ end
25
+
26
+ it "#{input_version} shouldn't be equal with itself" do
27
+ expect(version != version).to eq(false)
28
+ end
29
+
30
+ it "#{input_version} should be equal to itself" do
31
+ expect(version == version).to eq(true)
32
+ end
33
+ end
34
+ end
35
+
36
+ shared_examples_for 'an invalid version' do |invalid_input|
37
+ [invalid_input, invalid_input.swapcase].each do |input|
38
+ it "should not be able to transform #{invalid_input} to string" do
39
+ expect{ described_class.parse(input) }.to raise_error(described_class::ValidationFailure)
40
+ end
41
+ end
42
+
43
+ describe "comparison" do
44
+ valid_version = described_class.parse("1.0")
45
+
46
+ it "should raise error when checking if #{invalid_input} is lesser than a valid version" do
47
+ expect{ valid_version < invalid_input }.to raise_error(described_class::ValidationFailure)
48
+ end
49
+
50
+ it "should raise error when checking if #{invalid_input} is greater than a valid version" do
51
+ expect{ valid_version > invalid_input }.to raise_error(described_class::ValidationFailure)
52
+ end
53
+
54
+ it "should raise error when checking if #{invalid_input} is greater or equal than a valid version" do
55
+ expect{ valid_version >= invalid_input }.to raise_error(described_class::ValidationFailure)
56
+ end
57
+
58
+ it "should raise error when checking if #{invalid_input} is lesser or equal than a valid version" do
59
+ expect{ valid_version <= invalid_input }.to raise_error(described_class::ValidationFailure)
60
+ end
61
+ end
62
+ end
63
+
64
+ describe "when only release segment is present in provided version" do
65
+ context "should work with any number of integer elements" do
66
+ context "when it has 1 element" do
67
+ it_should_behave_like 'a valid version', "1"
68
+ end
69
+ context "when it has 2 elements" do
70
+ it_should_behave_like 'a valid version', "1.1"
71
+ end
72
+
73
+ context "when it has 3 elements" do
74
+ it_should_behave_like 'a valid version', "1.1.1"
75
+ end
76
+
77
+ context "when it has 4 elements" do
78
+ it_should_behave_like 'a valid version', "1.1.1.1"
79
+ end
80
+
81
+ context "when it has 10 elements" do
82
+ it_should_behave_like 'a valid version', "1.1.1.1.1.1.1.1.1.1"
83
+ end
84
+ end
85
+
86
+ describe "should work with elements which are zero" do
87
+ context "when it ends with 1 zero" do
88
+ it_should_behave_like 'a valid version', "1.0"
89
+ end
90
+
91
+ context "when it ends with 2 zeros" do
92
+ it_should_behave_like 'a valid version', "1.0.0"
93
+ end
94
+
95
+ context "when it ends with 3 zeros" do
96
+ it_should_behave_like 'a valid version', "1.0.0.0"
97
+ end
98
+
99
+ context "when it starts with 1 zero" do
100
+ it_should_behave_like 'a valid version', "0.1"
101
+ end
102
+
103
+ context "when it starts with 2 zeros" do
104
+ it_should_behave_like 'a valid version', "0.0.1"
105
+ end
106
+
107
+ context "when it starts with 3 zeros" do
108
+ it_should_behave_like 'a valid version', "0.0.0.1"
109
+ end
110
+
111
+ context "when it is just a zero" do
112
+ it_should_behave_like 'a valid version', "0"
113
+ end
114
+
115
+ context "when it is full of just zeros" do
116
+ it_should_behave_like 'a valid version', "0.0.0"
117
+ end
118
+ end
119
+
120
+ describe "should work with elements containing multiple digits" do
121
+ context "when it has two digit elements" do
122
+ it_should_behave_like 'a valid version', "1.10.1"
123
+ end
124
+
125
+ context "when it has three digit elements" do
126
+ it_should_behave_like 'a valid version', "1.101.1.11"
127
+ end
128
+
129
+ context "when it has four digit elements" do
130
+ it_should_behave_like 'a valid version', "2019.0.11"
131
+ end
132
+
133
+ context "when it has a numerical element starting with zero" do
134
+ # the zero will dissapear
135
+ it_should_behave_like 'a valid version', "1.09.10", "1.9.10"
136
+ end
137
+
138
+ context "when it starts with multiple zeros" do
139
+ # the zeros will dissapear
140
+ it_should_behave_like 'a valid version', "0010.0000.0011", "10.0.11"
141
+ end
142
+ end
143
+
144
+ context "should fail because of misplaced letters" do
145
+ context "when it starts with letters" do
146
+ it_should_behave_like 'an invalid version', "d.2"
147
+ it_should_behave_like 'an invalid version', "ee.2"
148
+ end
149
+
150
+ context "when it has only letters" do
151
+ it_should_behave_like 'an invalid version', "d.c"
152
+ it_should_behave_like 'an invalid version', "dd.c"
153
+ end
154
+ end
155
+ end
156
+
157
+ describe "when the epoch segment is present in provided version" do
158
+ context "should work when epoch is an integer" do
159
+ context "when epoch has 1 digit" do
160
+ it_should_behave_like 'a valid version', "1!1.0.0"
161
+ end
162
+
163
+ context "when epoch has 2 digits" do
164
+ it_should_behave_like 'a valid version', "10!1.0.0"
165
+ end
166
+
167
+ context "when epoch is zero" do
168
+ # versions without epoch specified are considered to have epoch 0
169
+ # it is accepted as input but it should be ignored at output
170
+ it_should_behave_like 'a valid version', "0!1.0.0", "1.0.0"
171
+ end
172
+ end
173
+
174
+ context "should fail when epoch contains letters" do
175
+ context "when epoch starts with a letter" do
176
+ it_should_behave_like 'an invalid version', "a9!1.0.0"
177
+ end
178
+
179
+ context "when epoch ends with a letter" do
180
+ it_should_behave_like 'an invalid version', "9a!1.0.0"
181
+ end
182
+ end
183
+ end
184
+
185
+ describe "when the pre-release segment is present in provided version" do
186
+ context "when pre-release contains the letter a" do
187
+ it_should_behave_like 'a valid version', "1.0a", "1.0a0"
188
+ it_should_behave_like 'a valid version', "1.0a0"
189
+ end
190
+
191
+ context "when pre-release contains the letter b" do
192
+ it_should_behave_like 'a valid version', "1.0b", "1.0b0"
193
+ it_should_behave_like 'a valid version', "1.0b0"
194
+ end
195
+
196
+ context "when pre-release contains the letter c" do
197
+ it_should_behave_like 'a valid version', "1.0c", "1.0rc0"
198
+ it_should_behave_like 'a valid version', "1.0c0", "1.0rc0"
199
+ end
200
+
201
+ context "when pre-release contains the string alpha" do
202
+ it_should_behave_like 'a valid version', "1.0alpha", "1.0a0"
203
+ it_should_behave_like 'a valid version', "1.0alpha0", "1.0a0"
204
+ end
205
+
206
+ context "when pre-release contains the string beta" do
207
+ it_should_behave_like 'a valid version', "1.0beta", "1.0b0"
208
+ it_should_behave_like 'a valid version', "1.0beta0", "1.0b0"
209
+ end
210
+
211
+ context "when pre-release contains the string rc" do
212
+ it_should_behave_like 'a valid version', "1.0rc", "1.0rc0"
213
+ it_should_behave_like 'a valid version', "1.0rc0", "1.0rc0"
214
+ end
215
+
216
+ context "when pre-release contains the string pre" do
217
+ it_should_behave_like 'a valid version', "1.0pre", "1.0rc0"
218
+ it_should_behave_like 'a valid version', "1.0pre0", "1.0rc0"
219
+ end
220
+
221
+ context "when pre-release contains the string preview" do
222
+ it_should_behave_like 'a valid version', "1.0preview", "1.0rc0"
223
+ it_should_behave_like 'a valid version', "1.0preview0", "1.0rc0"
224
+ end
225
+
226
+ context "when pre-release contains multiple zeros at the beginning" do
227
+ it_should_behave_like 'a valid version', "1.0.beta.00", "1.0b0"
228
+ it_should_behave_like 'a valid version', "1.0.beta.002", "1.0b2"
229
+ end
230
+
231
+ context "when pre-release elements are separated by dots" do
232
+ it_should_behave_like 'a valid version', "1.0.alpha", "1.0a0"
233
+ it_should_behave_like 'a valid version', "1.0.alpha.0", "1.0a0"
234
+ it_should_behave_like 'a valid version', "1.0.alpha.2", "1.0a2"
235
+ end
236
+
237
+ context "when pre-release elements are separated by dashes" do
238
+ it_should_behave_like 'a valid version', "1.0-alpha", "1.0a0"
239
+ it_should_behave_like 'a valid version', "1.0-alpha-0", "1.0a0"
240
+ it_should_behave_like 'a valid version', "1.0-alpha-2", "1.0a2"
241
+ end
242
+
243
+ context "when pre-release elements are separated by underscores" do
244
+ it_should_behave_like 'a valid version', "1.0_alpha", "1.0a0"
245
+ it_should_behave_like 'a valid version', "1.0_alpha_0", "1.0a0"
246
+ it_should_behave_like 'a valid version', "1.0_alpha_2", "1.0a2"
247
+ end
248
+
249
+ context "when pre-release elements are separated by mixed symbols" do
250
+ it_should_behave_like 'a valid version', "1.0-alpha_5", "1.0a5"
251
+ it_should_behave_like 'a valid version', "1.0-alpha.5", "1.0a5"
252
+ it_should_behave_like 'a valid version', "1.0_alpha-5", "1.0a5"
253
+ it_should_behave_like 'a valid version', "1.0_alpha.5", "1.0a5"
254
+ it_should_behave_like 'a valid version', "1.0.alpha-5", "1.0a5"
255
+ it_should_behave_like 'a valid version', "1.0.alpha_5", "1.0a5"
256
+ end
257
+ end
258
+
259
+ describe "when the post-release segment is present in provided version" do
260
+ context "when post-release is just an integer" do
261
+ it_should_behave_like 'a valid version', "1.0-9", "1.0.post9"
262
+ it_should_behave_like 'a valid version', "1.0-10", "1.0.post10"
263
+ end
264
+
265
+ context "when post-release is just an integer and starts with zero" do
266
+ it_should_behave_like 'a valid version', "1.0-09", "1.0.post9"
267
+ it_should_behave_like 'a valid version', "1.0-009", "1.0.post9"
268
+ end
269
+
270
+ context "when post-release contains the string post" do
271
+ it_should_behave_like 'a valid version', "1.0post", "1.0.post0"
272
+ it_should_behave_like 'a valid version', "1.0post0", "1.0.post0"
273
+ it_should_behave_like 'a valid version', "1.0post1", "1.0.post1"
274
+ it_should_behave_like 'an invalid version', "1.0-0.post1"
275
+ end
276
+
277
+ context "when post-release contains the string rev" do
278
+ it_should_behave_like 'a valid version', "1.0rev", "1.0.post0"
279
+ it_should_behave_like 'a valid version', "1.0rev0", "1.0.post0"
280
+ it_should_behave_like 'a valid version', "1.0rev1", "1.0.post1"
281
+ it_should_behave_like 'an invalid version', "1.0-0.rev1"
282
+ end
283
+
284
+ context "when post-release contains the letter r" do
285
+ it_should_behave_like 'a valid version', "1.0r", "1.0.post0"
286
+ it_should_behave_like 'a valid version', "1.0r0", "1.0.post0"
287
+ it_should_behave_like 'a valid version', "1.0r1", "1.0.post1"
288
+ it_should_behave_like 'an invalid version', "1.0-0.r1"
289
+ end
290
+
291
+ context "when post-release elements are separated by dashes" do
292
+ it_should_behave_like 'a valid version', "1.0-post-22", "1.0.post22"
293
+ it_should_behave_like 'a valid version', "1.0-rev-22", "1.0.post22"
294
+ it_should_behave_like 'a valid version', "1.0-r-22", "1.0.post22"
295
+ end
296
+
297
+ context "when post-release elements are separated by underscores" do
298
+ it_should_behave_like 'a valid version', "1.0_post_22", "1.0.post22"
299
+ it_should_behave_like 'a valid version', "1.0_rev_22", "1.0.post22"
300
+ it_should_behave_like 'a valid version', "1.0_r_22", "1.0.post22"
301
+ end
302
+
303
+ context "when post-release elements are separated by dots" do
304
+ it_should_behave_like 'a valid version', "1.0.post.22", "1.0.post22"
305
+ it_should_behave_like 'a valid version', "1.0.rev.22", "1.0.post22"
306
+ it_should_behave_like 'a valid version', "1.0.r.22", "1.0.post22"
307
+ end
308
+
309
+ context "when post-release elements are separated by mixed symbols" do
310
+ it_should_behave_like 'a valid version', "1.0-r_5", "1.0.post5"
311
+ it_should_behave_like 'a valid version', "1.0-r.5", "1.0.post5"
312
+ it_should_behave_like 'a valid version', "1.0_r-5", "1.0.post5"
313
+ it_should_behave_like 'a valid version', "1.0_r.5", "1.0.post5"
314
+ it_should_behave_like 'a valid version', "1.0.r-5", "1.0.post5"
315
+ it_should_behave_like 'a valid version', "1.0.r_5", "1.0.post5"
316
+ end
317
+ end
318
+
319
+ describe "when the dev release segment is present in provided version" do
320
+ context "when dev release is only the keyword dev" do
321
+ it_should_behave_like 'a valid version', "1.0dev", "1.0.dev0"
322
+ it_should_behave_like 'a valid version', "1.0-dev", "1.0.dev0"
323
+ it_should_behave_like 'a valid version', "1.0_dev", "1.0.dev0"
324
+ it_should_behave_like 'a valid version', "1.0.dev", "1.0.dev0"
325
+ end
326
+
327
+ context "when dev release contains the keyword dev and a number" do
328
+ it_should_behave_like 'a valid version', "1.0dev2", "1.0.dev2"
329
+ it_should_behave_like 'a valid version', "1.0-dev33", "1.0.dev33"
330
+ it_should_behave_like 'a valid version', "1.0.dev11", "1.0.dev11"
331
+ it_should_behave_like 'a valid version', "1.0_dev101", "1.0.dev101"
332
+ end
333
+
334
+ context "when dev release's number element starts with 0" do
335
+ it_should_behave_like 'a valid version', "1.0dev02", "1.0.dev2"
336
+ it_should_behave_like 'a valid version', "1.0-dev033", "1.0.dev33"
337
+ it_should_behave_like 'a valid version', "1.0_dev0101", "1.0.dev101"
338
+ it_should_behave_like 'a valid version', "1.0.dev00011", "1.0.dev11"
339
+ end
340
+
341
+ context "when dev release elements are separated by dashes" do
342
+ it_should_behave_like 'a valid version', "1.0-dev", "1.0.dev0"
343
+ it_should_behave_like 'a valid version', "1.0-dev-2", "1.0.dev2"
344
+ it_should_behave_like 'a valid version', "1.0-dev-22", "1.0.dev22"
345
+ end
346
+
347
+ context "when dev release elements are separated by underscores" do
348
+ it_should_behave_like 'a valid version', "1.0_dev", "1.0.dev0"
349
+ it_should_behave_like 'a valid version', "1.0_dev_2", "1.0.dev2"
350
+ it_should_behave_like 'a valid version', "1.0_dev_22", "1.0.dev22"
351
+ end
352
+
353
+ context "when dev release elements are separated by dots" do
354
+ it_should_behave_like 'a valid version', "1.0.dev", "1.0.dev0"
355
+ it_should_behave_like 'a valid version', "1.0.dev.2", "1.0.dev2"
356
+ it_should_behave_like 'a valid version', "1.0.dev.22", "1.0.dev22"
357
+ end
358
+
359
+ context "when dev release elements are separated by mixed symbols" do
360
+ it_should_behave_like 'a valid version', "1.0-dev_5", "1.0.dev5"
361
+ it_should_behave_like 'a valid version', "1.0-dev.5", "1.0.dev5"
362
+ it_should_behave_like 'a valid version', "1.0_dev-5", "1.0.dev5"
363
+ it_should_behave_like 'a valid version', "1.0_dev.5", "1.0.dev5"
364
+ it_should_behave_like 'a valid version', "1.0.dev-5", "1.0.dev5"
365
+ it_should_behave_like 'a valid version', "1.0.dev_5", "1.0.dev5"
366
+ end
367
+ end
368
+
369
+ describe "when the local version segment is present in provided version" do
370
+ it_should_behave_like 'an invalid version', "1.0+"
371
+
372
+ context "when local version is just letters" do
373
+ it_should_behave_like 'a valid version', "1.0+local"
374
+ it_should_behave_like 'a valid version', "1.0+Local", "1.0+local"
375
+ end
376
+
377
+ context "when local version contains numbers" do
378
+ it_should_behave_like 'a valid version', "1.0+10"
379
+ it_should_behave_like 'a valid version', "1.0+01", "1.0+1"
380
+ it_should_behave_like 'a valid version', "1.0+01L", "1.0+01l"
381
+ it_should_behave_like 'a valid version', "1.0+L101L", "1.0+l101l"
382
+ end
383
+
384
+ context "when local version contains multiple elements" do
385
+ it_should_behave_like 'a valid version', "1.0+10.local"
386
+ it_should_behave_like 'a valid version', "1.0+abc.def.ghi"
387
+ it_should_behave_like 'a valid version', "1.0+01.abc", "1.0+1.abc"
388
+ it_should_behave_like 'a valid version', "1.0+01L.0001", "1.0+01l.1"
389
+ it_should_behave_like 'a valid version', "1.0+L101L.local", "1.0+l101l.local"
390
+ it_should_behave_like 'a valid version', "1.0+dash-undrsc_dot.5", "1.0+dash.undrsc.dot.5"
391
+ end
392
+ end
393
+ end
394
+
395
+ describe "comparison of versions" do
396
+ # This array must remain sorted (smallest to highest version).
397
+ versions = [
398
+ "0.1",
399
+ "0.10",
400
+ "0.10.1",
401
+ "0.10.1.0.1",
402
+ "1.0.dev456",
403
+ "1.0a1",
404
+ "1.0a2.dev456",
405
+ "1.0a12.dev456",
406
+ "1.0a12",
407
+ "1.0b1.dev456",
408
+ "1.0b2",
409
+ "1.0b2.post345.dev456",
410
+ "1.0b2.post345",
411
+ "1.0b2-346",
412
+ "1.0c1.dev456",
413
+ "1.0c1",
414
+ "1.0rc2",
415
+ "1.0c3",
416
+ "1.0",
417
+ "1.0.post456.dev34",
418
+ "1.0.post456",
419
+ "1.1.dev1",
420
+ "1.2",
421
+ "1.2+123abc",
422
+ "1.2+123abc456",
423
+ "1.2+abc",
424
+ "1.2+abc123",
425
+ "1.2+abc123-def2",
426
+ "1.2+abc123-def2-0",
427
+ "1.2+abc123def",
428
+ "1.2+1234.abc",
429
+ "1.2+123456",
430
+ "1.2.r32+123456",
431
+ "1.2.rev33+123456",
432
+ "1!1.0b2.post345.dev456",
433
+ "1!1.0",
434
+ "1!1.0.post456.dev34",
435
+ "1!1.0.post456",
436
+ "1!1.2.rev33+123456",
437
+ "2!2.3.4.alpha5.rev6.dev7+abc89"
438
+ ]
439
+
440
+ it "should find versions list to be already sorted" do
441
+ sorted_versions = versions.sort do |x,y|
442
+ described_class.compare(x, y)
443
+ end
444
+ expect(versions).to eq(sorted_versions)
445
+ end
446
+
447
+ versions.combination(2).to_a.each do |version_pair|
448
+ lower_version = described_class.parse(version_pair.first)
449
+ greater_version = described_class.parse(version_pair.last)
450
+
451
+ it "#{lower_version} should be equal to #{lower_version}" do
452
+ expect(lower_version == lower_version).to eq(true)
453
+ end
454
+
455
+ it "#{lower_version} should not be equal to #{greater_version}" do
456
+ expect(lower_version != greater_version).to eq(true)
457
+ end
458
+
459
+ it "#{lower_version} should be lower than #{greater_version}" do
460
+ expect(lower_version < greater_version).to eq(true)
461
+ end
462
+ end
463
+ end
464
+ end