puppet 6.11.1-universal-darwin → 6.16.0-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (395) hide show
  1. checksums.yaml +4 -4
  2. data/CODEOWNERS +3 -8
  3. data/CONTRIBUTING.md +7 -13
  4. data/Gemfile +1 -0
  5. data/Gemfile.lock +39 -36
  6. data/README.md +17 -24
  7. data/ext/build_defaults.yaml +1 -0
  8. data/ext/project_data.yaml +1 -1
  9. data/ext/windows/service/daemon.rb +25 -20
  10. data/lib/puppet.rb +52 -13
  11. data/lib/puppet/agent.rb +20 -14
  12. data/lib/puppet/application/agent.rb +12 -14
  13. data/lib/puppet/application/describe.rb +7 -5
  14. data/lib/puppet/application/device.rb +2 -2
  15. data/lib/puppet/application/filebucket.rb +19 -15
  16. data/lib/puppet/application/plugin.rb +1 -0
  17. data/lib/puppet/application/resource.rb +1 -1
  18. data/lib/puppet/application/ssl.rb +4 -4
  19. data/lib/puppet/concurrent.rb +2 -0
  20. data/lib/puppet/concurrent/lock.rb +16 -0
  21. data/lib/puppet/concurrent/synchronized.rb +15 -0
  22. data/lib/puppet/concurrent/thread_local_singleton.rb +14 -0
  23. data/lib/puppet/configurer.rb +85 -83
  24. data/lib/puppet/configurer/plugin_handler.rb +10 -1
  25. data/lib/puppet/context/trusted_information.rb +14 -8
  26. data/lib/puppet/daemon.rb +13 -27
  27. data/lib/puppet/defaults.rb +158 -40
  28. data/lib/puppet/environments.rb +30 -20
  29. data/lib/puppet/error.rb +9 -1
  30. data/lib/puppet/face/facts.rb +8 -5
  31. data/lib/puppet/face/help.rb +29 -3
  32. data/lib/puppet/face/module/search.rb +5 -0
  33. data/lib/puppet/face/plugin.rb +2 -2
  34. data/lib/puppet/file_serving/http_metadata.rb +1 -1
  35. data/lib/puppet/file_system/file_impl.rb +13 -9
  36. data/lib/puppet/file_system/memory_file.rb +6 -0
  37. data/lib/puppet/file_system/memory_impl.rb +13 -0
  38. data/lib/puppet/file_system/uniquefile.rb +4 -0
  39. data/lib/puppet/file_system/windows.rb +7 -10
  40. data/lib/puppet/forge.rb +3 -3
  41. data/lib/puppet/forge/errors.rb +2 -2
  42. data/lib/puppet/forge/repository.rb +31 -86
  43. data/lib/puppet/functions/call.rb +1 -1
  44. data/lib/puppet/functions/camelcase.rb +2 -2
  45. data/lib/puppet/functions/epp.rb +4 -4
  46. data/lib/puppet/functions/eyaml_lookup_key.rb +13 -8
  47. data/lib/puppet/functions/filter.rb +1 -0
  48. data/lib/puppet/functions/find_file.rb +9 -9
  49. data/lib/puppet/functions/find_template.rb +63 -0
  50. data/lib/puppet/functions/inline_epp.rb +5 -5
  51. data/lib/puppet/functions/reduce.rb +2 -4
  52. data/lib/puppet/http.rb +7 -0
  53. data/lib/puppet/http/client.rb +341 -54
  54. data/lib/puppet/http/errors.rb +2 -0
  55. data/lib/puppet/http/external_client.rb +90 -0
  56. data/lib/puppet/http/redirector.rb +34 -0
  57. data/lib/puppet/http/resolver.rb +57 -1
  58. data/lib/puppet/http/resolver/server_list.rb +98 -0
  59. data/lib/puppet/http/resolver/settings.rb +23 -2
  60. data/lib/puppet/http/resolver/srv.rb +36 -4
  61. data/lib/puppet/http/response.rb +68 -1
  62. data/lib/puppet/http/retry_after_handler.rb +39 -0
  63. data/lib/puppet/http/service.rb +179 -3
  64. data/lib/puppet/http/service/ca.rb +84 -21
  65. data/lib/puppet/http/service/compiler.rb +319 -0
  66. data/lib/puppet/http/service/file_server.rb +206 -0
  67. data/lib/puppet/http/service/report.rb +66 -0
  68. data/lib/puppet/http/session.rb +106 -31
  69. data/lib/puppet/indirector/catalog/compiler.rb +10 -0
  70. data/lib/puppet/indirector/catalog/rest.rb +34 -0
  71. data/lib/puppet/indirector/facts/rest.rb +42 -0
  72. data/lib/puppet/indirector/file_bucket_file/file.rb +1 -1
  73. data/lib/puppet/indirector/file_bucket_file/rest.rb +48 -0
  74. data/lib/puppet/indirector/file_content/http.rb +5 -0
  75. data/lib/puppet/indirector/file_content/rest.rb +30 -0
  76. data/lib/puppet/indirector/file_metadata/http.rb +4 -4
  77. data/lib/puppet/indirector/file_metadata/rest.rb +52 -0
  78. data/lib/puppet/indirector/json.rb +1 -1
  79. data/lib/puppet/indirector/msgpack.rb +1 -1
  80. data/lib/puppet/indirector/node/rest.rb +24 -0
  81. data/lib/puppet/indirector/report/rest.rb +19 -0
  82. data/lib/puppet/indirector/report/yaml.rb +23 -0
  83. data/lib/puppet/indirector/rest.rb +12 -0
  84. data/lib/puppet/indirector/status/rest.rb +18 -0
  85. data/lib/puppet/loaders.rb +6 -0
  86. data/lib/puppet/metatype/manager.rb +80 -80
  87. data/lib/puppet/network/http/base_pool.rb +19 -1
  88. data/lib/puppet/network/http/compression.rb +7 -0
  89. data/lib/puppet/network/http/connection.rb +6 -0
  90. data/lib/puppet/network/http/connection_adapter.rb +182 -0
  91. data/lib/puppet/network/http/nocache_pool.rb +2 -0
  92. data/lib/puppet/network/http/pool.rb +13 -6
  93. data/lib/puppet/network/http_pool.rb +2 -1
  94. data/lib/puppet/node/environment.rb +24 -8
  95. data/lib/puppet/pal/catalog_compiler.rb +5 -0
  96. data/lib/puppet/pal/pal_impl.rb +9 -29
  97. data/lib/puppet/parser/ast/pops_bridge.rb +6 -11
  98. data/lib/puppet/parser/compiler.rb +42 -32
  99. data/lib/puppet/parser/functions.rb +18 -13
  100. data/lib/puppet/parser/functions/epp.rb +3 -3
  101. data/lib/puppet/parser/functions/filter.rb +1 -0
  102. data/lib/puppet/parser/functions/inline_epp.rb +5 -5
  103. data/lib/puppet/pops/evaluator/access_operator.rb +2 -2
  104. data/lib/puppet/pops/evaluator/evaluator_impl.rb +1 -1
  105. data/lib/puppet/pops/evaluator/runtime3_support.rb +1 -1
  106. data/lib/puppet/pops/loader/puppet_plan_instantiator.rb +12 -3
  107. data/lib/puppet/pops/loaders.rb +7 -5
  108. data/lib/puppet/pops/lookup/invocation.rb +10 -3
  109. data/lib/puppet/pops/model/pn_transformer.rb +5 -9
  110. data/lib/puppet/pops/parser/evaluating_parser.rb +8 -11
  111. data/lib/puppet/pops/serialization/json_path.rb +3 -3
  112. data/lib/puppet/pops/time/timespan.rb +3 -5
  113. data/lib/puppet/pops/types/p_object_type_extension.rb +10 -0
  114. data/lib/puppet/pops/types/string_converter.rb +6 -9
  115. data/lib/puppet/pops/types/type_calculator.rb +30 -10
  116. data/lib/puppet/pops/types/type_formatter.rb +9 -11
  117. data/lib/puppet/pops/types/type_parser.rb +3 -3
  118. data/lib/puppet/pops/validation/checker4_0.rb +1 -1
  119. data/lib/puppet/pops/validation/tasks_checker.rb +5 -1
  120. data/lib/puppet/provider/aix_object.rb +4 -2
  121. data/lib/puppet/provider/group/aix.rb +1 -0
  122. data/lib/puppet/provider/group/groupadd.rb +57 -24
  123. data/lib/puppet/provider/group/windows_adsi.rb +3 -3
  124. data/lib/puppet/provider/package/aix.rb +17 -2
  125. data/lib/puppet/provider/package/apt.rb +78 -4
  126. data/lib/puppet/provider/package/dnfmodule.rb +69 -15
  127. data/lib/puppet/provider/package/dpkg.rb +14 -7
  128. data/lib/puppet/provider/package/fink.rb +20 -3
  129. data/lib/puppet/provider/package/gem.rb +41 -7
  130. data/lib/puppet/provider/package/openbsd.rb +13 -1
  131. data/lib/puppet/provider/package/pacman.rb +2 -5
  132. data/lib/puppet/provider/package/pip.rb +143 -48
  133. data/lib/puppet/provider/package/pip3.rb +0 -2
  134. data/lib/puppet/provider/package/pkg.rb +18 -5
  135. data/lib/puppet/provider/package/pkgdmg.rb +1 -1
  136. data/lib/puppet/provider/package/pkgng.rb +16 -4
  137. data/lib/puppet/provider/package/portage.rb +5 -5
  138. data/lib/puppet/provider/package/puppet_gem.rb +6 -2
  139. data/lib/puppet/provider/package/rpm.rb +6 -213
  140. data/lib/puppet/provider/package/yum.rb +108 -24
  141. data/lib/puppet/provider/package/zypper.rb +59 -1
  142. data/lib/puppet/provider/package_targetable.rb +5 -4
  143. data/lib/puppet/provider/service/systemd.rb +23 -5
  144. data/lib/puppet/provider/user/aix.rb +1 -0
  145. data/lib/puppet/provider/user/directoryservice.rb +30 -5
  146. data/lib/puppet/provider/user/hpux.rb +1 -1
  147. data/lib/puppet/provider/user/useradd.rb +11 -8
  148. data/lib/puppet/reports/http.rb +13 -9
  149. data/lib/puppet/reports/store.rb +1 -1
  150. data/lib/puppet/resource/type_collection.rb +20 -16
  151. data/lib/puppet/runtime.rb +32 -1
  152. data/lib/puppet/settings.rb +4 -0
  153. data/lib/puppet/settings/http_extra_headers_setting.rb +25 -0
  154. data/lib/puppet/ssl.rb +1 -0
  155. data/lib/puppet/ssl/certificate.rb +2 -1
  156. data/lib/puppet/ssl/host.rb +4 -4
  157. data/lib/puppet/ssl/oids.rb +1 -0
  158. data/lib/puppet/ssl/ssl_provider.rb +20 -0
  159. data/lib/puppet/ssl/state_machine.rb +81 -35
  160. data/lib/puppet/ssl/verifier_adapter.rb +9 -1
  161. data/lib/puppet/test/test_helper.rb +7 -1
  162. data/lib/puppet/transaction.rb +33 -11
  163. data/lib/puppet/transaction/report.rb +2 -2
  164. data/lib/puppet/transaction/resource_harness.rb +1 -1
  165. data/lib/puppet/type.rb +7 -2
  166. data/lib/puppet/type/file.rb +13 -0
  167. data/lib/puppet/type/file/data_sync.rb +5 -1
  168. data/lib/puppet/type/file/source.rb +49 -58
  169. data/lib/puppet/type/group.rb +5 -4
  170. data/lib/puppet/type/package.rb +102 -10
  171. data/lib/puppet/type/service.rb +6 -8
  172. data/lib/puppet/type/user.rb +6 -30
  173. data/lib/puppet/util.rb +34 -11
  174. data/lib/puppet/util/at_fork.rb +1 -1
  175. data/lib/puppet/util/autoload.rb +4 -18
  176. data/lib/puppet/util/instance_loader.rb +14 -10
  177. data/lib/puppet/util/log/destinations.rb +2 -11
  178. data/lib/puppet/util/logging.rb +30 -18
  179. data/lib/puppet/util/package/version/debian.rb +175 -0
  180. data/lib/puppet/util/package/version/gem.rb +15 -0
  181. data/lib/puppet/util/package/version/pip.rb +167 -0
  182. data/lib/puppet/util/package/version/range.rb +53 -0
  183. data/lib/puppet/util/package/version/range/eq.rb +14 -0
  184. data/lib/puppet/util/package/version/range/gt.rb +14 -0
  185. data/lib/puppet/util/package/version/range/gt_eq.rb +14 -0
  186. data/lib/puppet/util/package/version/range/lt.rb +14 -0
  187. data/lib/puppet/util/package/version/range/lt_eq.rb +14 -0
  188. data/lib/puppet/util/package/version/range/min_max.rb +21 -0
  189. data/lib/puppet/util/package/version/range/simple.rb +11 -0
  190. data/lib/puppet/util/package/version/rpm.rb +73 -0
  191. data/lib/puppet/util/pidlock.rb +36 -10
  192. data/lib/puppet/util/platform.rb +5 -0
  193. data/lib/puppet/util/plist.rb +6 -0
  194. data/lib/puppet/util/rpm_compare.rb +193 -0
  195. data/lib/puppet/util/storage.rb +0 -1
  196. data/lib/puppet/util/windows/adsi.rb +50 -20
  197. data/lib/puppet/util/windows/process.rb +15 -14
  198. data/lib/puppet/util/windows/security.rb +1 -0
  199. data/lib/puppet/util/windows/sid.rb +3 -3
  200. data/lib/puppet/util/yaml.rb +1 -1
  201. data/lib/puppet/version.rb +1 -1
  202. data/lib/puppet/x509/cert_provider.rb +9 -5
  203. data/locales/puppet.pot +640 -521
  204. data/man/man5/puppet.conf.5 +88 -9
  205. data/man/man8/puppet-agent.8 +6 -6
  206. data/man/man8/puppet-apply.8 +1 -1
  207. data/man/man8/puppet-catalog.8 +1 -1
  208. data/man/man8/puppet-config.8 +1 -1
  209. data/man/man8/puppet-describe.8 +1 -1
  210. data/man/man8/puppet-device.8 +2 -2
  211. data/man/man8/puppet-doc.8 +1 -1
  212. data/man/man8/puppet-epp.8 +1 -1
  213. data/man/man8/puppet-facts.8 +1 -1
  214. data/man/man8/puppet-filebucket.8 +17 -2
  215. data/man/man8/puppet-generate.8 +1 -1
  216. data/man/man8/puppet-help.8 +6 -3
  217. data/man/man8/puppet-key.8 +1 -1
  218. data/man/man8/puppet-lookup.8 +1 -1
  219. data/man/man8/puppet-man.8 +1 -1
  220. data/man/man8/puppet-module.8 +4 -1
  221. data/man/man8/puppet-node.8 +1 -1
  222. data/man/man8/puppet-parser.8 +1 -1
  223. data/man/man8/puppet-plugin.8 +1 -1
  224. data/man/man8/puppet-report.8 +1 -1
  225. data/man/man8/puppet-resource.8 +1 -1
  226. data/man/man8/puppet-script.8 +1 -1
  227. data/man/man8/puppet-ssl.8 +2 -2
  228. data/man/man8/puppet-status.8 +1 -1
  229. data/man/man8/puppet.8 +2 -2
  230. data/spec/fixtures/ssl/unknown-127.0.0.1-key.pem +67 -0
  231. data/spec/fixtures/ssl/unknown-127.0.0.1.pem +48 -0
  232. data/spec/fixtures/ssl/unknown-ca-key.pem +67 -0
  233. data/spec/fixtures/ssl/unknown-ca.pem +59 -0
  234. data/spec/fixtures/unit/forge/bacula.json +76 -0
  235. data/spec/fixtures/unit/provider/package/dnfmodule/{dnf-module-list-installed.txt → dnf-module-list.txt} +8 -0
  236. data/spec/fixtures/unit/provider/package/pkgng/pkg.version +2 -0
  237. data/spec/fixtures/unit/provider/package/yum/yum-check-update-subscription-manager.txt +9 -0
  238. data/spec/fixtures/unit/provider/package/zypper/zypper-search-uninstalled.out +13 -0
  239. data/spec/fixtures/unit/provider/service/systemd/list_unit_files_services +9 -0
  240. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_fetch_if_not_on_the_local_disk.yml +1 -102
  241. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_not_update_if_content_on_disk_is_up-to-date.yml +1 -106
  242. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_md5/should_update_if_content_differs_on_disk.yml +1 -106
  243. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_mtime/should_fetch_if_mtime_is_older_on_disk.yml +1 -102
  244. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_mtime/should_fetch_if_no_header_specified.yml +1 -98
  245. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_mtime/should_fetch_if_not_on_the_local_disk.yml +1 -102
  246. data/spec/fixtures/vcr/cassettes/Puppet_Type_File/when_sourcing/from_http/using_mtime/should_not_update_if_mtime_is_newer_on_disk.yml +1 -102
  247. data/spec/integration/application/agent_spec.rb +394 -0
  248. data/spec/integration/application/apply_spec.rb +132 -3
  249. data/spec/integration/application/filebucket_spec.rb +190 -0
  250. data/spec/integration/application/plugin_spec.rb +73 -0
  251. data/spec/integration/configurer_spec.rb +26 -7
  252. data/spec/integration/http/client_spec.rb +154 -0
  253. data/spec/integration/indirector/facts/facter_spec.rb +4 -0
  254. data/spec/integration/indirector/report/yaml.rb +83 -0
  255. data/spec/integration/module_tool/forge_spec.rb +51 -0
  256. data/spec/integration/network/http_pool_spec.rb +76 -20
  257. data/spec/integration/node/environment_spec.rb +15 -0
  258. data/spec/integration/util/windows/adsi_spec.rb +6 -1
  259. data/spec/lib/puppet/test_ca.rb +2 -2
  260. data/spec/lib/puppet_spec/https.rb +20 -9
  261. data/spec/lib/puppet_spec/puppetserver.rb +119 -0
  262. data/spec/shared_contexts/https.rb +29 -0
  263. data/spec/spec_helper.rb +6 -2
  264. data/spec/unit/agent_spec.rb +80 -26
  265. data/spec/unit/application/agent_spec.rb +9 -5
  266. data/spec/unit/application/apply_spec.rb +2 -12
  267. data/spec/unit/application/describe_spec.rb +88 -50
  268. data/spec/unit/application/device_spec.rb +2 -2
  269. data/spec/unit/application/filebucket_spec.rb +22 -2
  270. data/spec/unit/application/resource_spec.rb +2 -2
  271. data/spec/unit/concurrent/lock_spec.rb +29 -0
  272. data/spec/unit/configurer/fact_handler_spec.rb +0 -4
  273. data/spec/unit/configurer/plugin_handler_spec.rb +36 -19
  274. data/spec/unit/configurer_spec.rb +400 -406
  275. data/spec/unit/context/trusted_information_spec.rb +17 -0
  276. data/spec/unit/daemon_spec.rb +5 -64
  277. data/spec/unit/defaults_spec.rb +38 -4
  278. data/spec/unit/environments_spec.rb +65 -28
  279. data/spec/unit/face/facts_spec.rb +24 -20
  280. data/spec/unit/face/module/search_spec.rb +17 -0
  281. data/spec/unit/face/plugin_spec.rb +12 -10
  282. data/spec/unit/file_system/uniquefile_spec.rb +11 -0
  283. data/spec/unit/file_system_spec.rb +26 -2
  284. data/spec/unit/forge/errors_spec.rb +1 -1
  285. data/spec/unit/forge/forge_spec.rb +12 -54
  286. data/spec/unit/forge/module_release_spec.rb +19 -6
  287. data/spec/unit/forge/repository_spec.rb +63 -157
  288. data/spec/unit/forge_spec.rb +46 -116
  289. data/spec/unit/functions/find_template_spec.rb +69 -0
  290. data/spec/unit/functions/lookup_spec.rb +13 -0
  291. data/spec/unit/http/client_spec.rb +395 -27
  292. data/spec/unit/http/external_client_spec.rb +201 -0
  293. data/spec/unit/http/resolver_spec.rb +81 -12
  294. data/spec/unit/http/response_spec.rb +69 -0
  295. data/spec/unit/http/service/ca_spec.rb +100 -7
  296. data/spec/unit/http/service/compiler_spec.rb +627 -0
  297. data/spec/unit/http/service/file_server_spec.rb +308 -0
  298. data/spec/unit/http/service/report_spec.rb +118 -0
  299. data/spec/unit/http/service_spec.rb +117 -4
  300. data/spec/unit/http/session_spec.rb +237 -19
  301. data/spec/unit/indirector/catalog/compiler_spec.rb +47 -29
  302. data/spec/unit/indirector/catalog/rest_spec.rb +59 -2
  303. data/spec/unit/indirector/facts/rest_spec.rb +79 -24
  304. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +82 -2
  305. data/spec/unit/indirector/file_content/rest_spec.rb +53 -2
  306. data/spec/unit/indirector/file_metadata/http_spec.rb +167 -0
  307. data/spec/unit/indirector/file_metadata/rest_spec.rb +110 -2
  308. data/spec/unit/indirector/node/rest_spec.rb +57 -2
  309. data/spec/unit/indirector/report/rest_spec.rb +58 -51
  310. data/spec/unit/indirector/resource/ral_spec.rb +7 -8
  311. data/spec/unit/indirector/rest_spec.rb +13 -0
  312. data/spec/unit/indirector/status/rest_spec.rb +43 -2
  313. data/spec/unit/network/http/connection_spec.rb +549 -176
  314. data/spec/unit/network/http/nocache_pool_spec.rb +25 -3
  315. data/spec/unit/network/http/pool_spec.rb +89 -11
  316. data/spec/unit/network/http_pool_spec.rb +63 -57
  317. data/spec/unit/network/http_spec.rb +1 -1
  318. data/spec/unit/node/environment_spec.rb +16 -0
  319. data/spec/unit/node/facts_spec.rb +2 -1
  320. data/spec/unit/node_spec.rb +7 -4
  321. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +8 -3
  322. data/spec/unit/pops/serialization/to_from_hr_spec.rb +6 -1
  323. data/spec/unit/pops/validator/validator_spec.rb +7 -2
  324. data/spec/unit/provider/aix_object_spec.rb +16 -2
  325. data/spec/unit/provider/group/groupadd_spec.rb +181 -56
  326. data/spec/unit/provider/group/windows_adsi_spec.rb +43 -10
  327. data/spec/unit/provider/package/aix_spec.rb +29 -0
  328. data/spec/unit/provider/package/apt_spec.rb +43 -2
  329. data/spec/unit/provider/package/aptitude_spec.rb +1 -0
  330. data/spec/unit/provider/package/dnfmodule_spec.rb +76 -15
  331. data/spec/unit/provider/package/dpkg_spec.rb +28 -6
  332. data/spec/unit/provider/package/gem_spec.rb +40 -0
  333. data/spec/unit/provider/package/openbsd_spec.rb +17 -0
  334. data/spec/unit/provider/package/pacman_spec.rb +6 -21
  335. data/spec/unit/provider/package/pip_spec.rb +68 -19
  336. data/spec/unit/provider/package/pkg_spec.rb +15 -1
  337. data/spec/unit/provider/package/pkgdmg_spec.rb +1 -1
  338. data/spec/unit/provider/package/pkgng_spec.rb +38 -0
  339. data/spec/unit/provider/package/portage_spec.rb +9 -4
  340. data/spec/unit/provider/package/puppet_gem_spec.rb +8 -0
  341. data/spec/unit/provider/package/rpm_spec.rb +0 -212
  342. data/spec/unit/provider/package/yum_spec.rb +292 -0
  343. data/spec/unit/provider/package/zypper_spec.rb +84 -0
  344. data/spec/unit/provider/package_targetable_spec.rb +60 -0
  345. data/spec/unit/provider/service/init_spec.rb +1 -0
  346. data/spec/unit/provider/service/openbsd_spec.rb +9 -0
  347. data/spec/unit/provider/service/openwrt_spec.rb +1 -0
  348. data/spec/unit/provider/service/redhat_spec.rb +9 -0
  349. data/spec/unit/provider/service/systemd_spec.rb +92 -12
  350. data/spec/unit/provider/user/directoryservice_spec.rb +41 -0
  351. data/spec/unit/provider/user/hpux_spec.rb +2 -2
  352. data/spec/unit/provider/user/useradd_spec.rb +21 -8
  353. data/spec/unit/provider/user/windows_adsi_spec.rb +3 -3
  354. data/spec/unit/puppet_pal_2pec.rb +0 -26
  355. data/spec/unit/puppet_pal_catalog_spec.rb +46 -0
  356. data/spec/unit/puppet_spec.rb +47 -0
  357. data/spec/unit/reports/http_spec.rb +70 -52
  358. data/spec/unit/settings/autosign_setting_spec.rb +1 -1
  359. data/spec/unit/settings/http_extra_headers_spec.rb +64 -0
  360. data/spec/unit/ssl/certificate_spec.rb +7 -0
  361. data/spec/unit/ssl/host_spec.rb +4 -2
  362. data/spec/unit/ssl/oids_spec.rb +1 -0
  363. data/spec/unit/ssl/ssl_provider_spec.rb +71 -0
  364. data/spec/unit/ssl/state_machine_spec.rb +99 -13
  365. data/spec/unit/transaction/persistence_spec.rb +1 -10
  366. data/spec/unit/transaction/report_spec.rb +4 -0
  367. data/spec/unit/transaction_spec.rb +45 -1
  368. data/spec/unit/type/file/content_spec.rb +9 -3
  369. data/spec/unit/type/file/ensure_spec.rb +1 -2
  370. data/spec/unit/type/file/source_spec.rb +86 -35
  371. data/spec/unit/type/package_spec.rb +8 -0
  372. data/spec/unit/type/service_spec.rb +9 -8
  373. data/spec/unit/type/user_spec.rb +1 -2
  374. data/spec/unit/util/at_fork_spec.rb +3 -2
  375. data/spec/unit/util/autoload_spec.rb +2 -1
  376. data/spec/unit/util/log/destinations_spec.rb +1 -29
  377. data/spec/unit/util/log_spec.rb +0 -138
  378. data/spec/unit/util/logging_spec.rb +200 -0
  379. data/spec/unit/util/package/version/debian_spec.rb +83 -0
  380. data/spec/unit/util/package/version/pip_spec.rb +464 -0
  381. data/spec/unit/util/package/version/range_spec.rb +175 -0
  382. data/spec/unit/util/package/version/rpm_spec.rb +121 -0
  383. data/spec/unit/util/pidlock_spec.rb +112 -42
  384. data/spec/unit/util/plist_spec.rb +20 -0
  385. data/spec/unit/util/rpm_compare_spec.rb +196 -0
  386. data/spec/unit/util/storage_spec.rb +1 -8
  387. data/spec/unit/util/windows/adsi_spec.rb +55 -4
  388. data/spec/unit/util/windows/sid_spec.rb +2 -2
  389. data/spec/unit/x509/cert_provider_spec.rb +24 -4
  390. data/tasks/generate_cert_fixtures.rake +15 -1
  391. data/tasks/manpages.rake +6 -35
  392. metadata +92 -12
  393. data/COMMITTERS.md +0 -244
  394. data/spec/integration/faces/plugin_spec.rb +0 -61
  395. data/spec/lib/puppet_spec/validators.rb +0 -37
@@ -3,7 +3,64 @@ require 'spec_helper'
3
3
  require 'puppet/indirector/catalog/rest'
4
4
 
5
5
  describe Puppet::Resource::Catalog::Rest do
6
- it "should be a sublcass of Puppet::Indirector::REST" do
7
- expect(Puppet::Resource::Catalog::Rest.superclass).to equal(Puppet::Indirector::REST)
6
+ let(:certname) { 'ziggy' }
7
+ let(:uri) { %r{/puppet/v3/catalog/ziggy} }
8
+ let(:formatter) { Puppet::Network::FormatHandler.format(:json) }
9
+ let(:catalog) { Puppet::Resource::Catalog.new(certname) }
10
+
11
+ before :each do
12
+ Puppet[:server] = 'compiler.example.com'
13
+ Puppet[:masterport] = 8140
14
+
15
+ described_class.indirection.terminus_class = :rest
16
+ end
17
+
18
+ def catalog_response(catalog)
19
+ { body: formatter.render(catalog), headers: {'Content-Type' => formatter.mime } }
20
+ end
21
+
22
+ it 'finds a catalog' do
23
+ stub_request(:post, uri).to_return(**catalog_response(catalog))
24
+
25
+ expect(described_class.indirection.find(certname)).to be_a(Puppet::Resource::Catalog)
26
+ end
27
+
28
+ it "serializes the environment" do
29
+ stub_request(:post, uri)
30
+ .with(query: hash_including('environment' => 'outerspace'))
31
+ .to_return(**catalog_response(catalog))
32
+
33
+ described_class.indirection.find(certname, environment: Puppet::Node::Environment.remote('outerspace'))
34
+ end
35
+
36
+ it 'constructs a catalog environment_instance' do
37
+ env = Puppet::Node::Environment.remote('outerspace')
38
+ catalog = Puppet::Resource::Catalog.new(certname, env)
39
+
40
+ stub_request(:post, uri).to_return(**catalog_response(catalog))
41
+
42
+ expect(described_class.indirection.find(certname).environment_instance).to eq(env)
43
+ end
44
+
45
+ it 'returns nil if the node does not exist' do
46
+ stub_request(:post, uri).to_return(status: 404, headers: { 'Content-Type' => 'application/json' }, body: "{}")
47
+
48
+ expect(described_class.indirection.find(certname)).to be_nil
49
+ end
50
+
51
+ it 'raises if fail_on_404 is specified' do
52
+ stub_request(:post, uri).to_return(status: 404, headers: { 'Content-Type' => 'application/json' }, body: "{}")
53
+
54
+ expect{
55
+ described_class.indirection.find(certname, fail_on_404: true)
56
+ }.to raise_error(Puppet::Error, %r{Find /puppet/v3/catalog/ziggy resulted in 404 with the message: {}})
57
+ end
58
+
59
+ it 'raises Net::HTTPError on 500' do
60
+ stub_request(:post, uri).to_return(status: 500)
61
+
62
+ expect{
63
+ described_class.indirection.find(certname)
64
+ }.to raise_error(Net::HTTPError, %r{Error 500 on SERVER: })
8
65
  end
9
66
  end
@@ -3,42 +3,97 @@ require 'spec_helper'
3
3
  require 'puppet/indirector/facts/rest'
4
4
 
5
5
  describe Puppet::Node::Facts::Rest do
6
- it "should be a sublcass of Puppet::Indirector::REST" do
7
- expect(Puppet::Node::Facts::Rest.superclass).to equal(Puppet::Indirector::REST)
6
+ let(:certname) { 'ziggy' }
7
+ let(:uri) { %r{/puppet/v3/facts/ziggy} }
8
+ let(:facts) { Puppet::Node::Facts.new(certname, test_fact: 'test value') }
9
+
10
+ before do
11
+ Puppet[:server] = 'compiler.example.com'
12
+ Puppet[:masterport] = 8140
13
+
14
+ described_class.indirection.terminus_class = :rest
8
15
  end
9
16
 
10
- let(:model) { Puppet::Node::Facts }
11
- before(:each) { model.indirection.terminus_class = :rest }
17
+ describe '#find' do
18
+ let(:formatter) { Puppet::Network::FormatHandler.format(:json) }
19
+
20
+ def facts_response(facts)
21
+ { body: formatter.render(facts), headers: {'Content-Type' => formatter.mime } }
22
+ end
23
+
24
+ it 'finds facts' do
25
+ stub_request(:get, uri).to_return(**facts_response(facts))
26
+
27
+ expect(described_class.indirection.find(certname)).to be_a(Puppet::Node::Facts)
28
+ end
29
+
30
+ it "serializes the environment" do
31
+ stub_request(:get, uri)
32
+ .with(query: hash_including('environment' => 'outerspace'))
33
+ .to_return(**facts_response(facts))
34
+
35
+ described_class.indirection.find(certname, environment: Puppet::Node::Environment.remote('outerspace'))
36
+ end
37
+
38
+ it 'returns nil if the facts do not exist' do
39
+ stub_request(:get, uri).to_return(status: 404, headers: { 'Content-Type' => 'application/json' }, body: "{}")
40
+
41
+ expect(described_class.indirection.find(certname)).to be_nil
42
+ end
43
+
44
+ it 'raises if fail_on_404 is specified' do
45
+ stub_request(:get, uri).to_return(status: 404, headers: { 'Content-Type' => 'application/json' }, body: "{}")
46
+
47
+ expect{
48
+ described_class.indirection.find(certname, fail_on_404: true)
49
+ }.to raise_error(Puppet::Error, %r{Find /puppet/v3/facts/ziggy resulted in 404 with the message: {}})
50
+ end
51
+
52
+ it 'raises Net::HTTPError on 500' do
53
+ stub_request(:get, uri).to_return(status: 500)
12
54
 
13
- def mock_response(code, body, content_type='text/plain', encoding=nil)
14
- obj = double('http response', :code => code.to_s, :body => body)
15
- allow(obj).to receive(:[]).with('content-type').and_return(content_type)
16
- allow(obj).to receive(:[]).with('content-encoding').and_return(encoding)
17
- allow(obj).to receive(:[]).with(Puppet::Network::HTTP::HEADER_PUPPET_VERSION).and_return(Puppet.version)
18
- obj
55
+ expect{
56
+ described_class.indirection.find(certname)
57
+ }.to raise_error(Net::HTTPError, %r{Error 500 on SERVER: })
58
+ end
19
59
  end
20
60
 
21
61
  describe '#save' do
22
- subject { model.indirection.terminus(:rest) }
62
+ it 'returns nil on success' do
63
+ stub_request(:put, %r{/puppet/v3/facts})
64
+ .to_return(status: 200, headers: { 'Content-Type' => 'application/json'}, body: '')
23
65
 
24
- let(:connection) { double('mock http connection', :verify_callback= => nil) }
25
- let(:node_name) { 'puppet.node.test' }
26
- let(:data) { model.new(node_name, {test_fact: 'test value'}) }
27
- let(:request) { Puppet::Indirector::Request.new(:facts, :save, node_name, data) }
66
+ expect(described_class.indirection.save(facts)).to be_nil
67
+ end
68
+
69
+ it "serializes the environment" do
70
+ stub_request(:put, uri)
71
+ .with(query: hash_including('environment' => 'outerspace'))
72
+ .to_return(status: 200, headers: { 'Content-Type' => 'application/json'}, body: '')
73
+
74
+ described_class.indirection.save(facts, nil, environment: Puppet::Node::Environment.remote('outerspace'))
75
+ end
28
76
 
29
- before :each do
30
- allow(subject).to receive(:network).and_return(connection)
77
+ it 'raises if options are specified' do
78
+ expect {
79
+ described_class.indirection.save(facts, nil, foo: :bar)
80
+ }.to raise_error(ArgumentError, /PUT does not accept options/)
31
81
  end
32
82
 
33
- context 'when a 404 response is received' do
34
- let(:response) { mock_response(404, '{}', 'test/json') }
83
+ it 'raises with HTTP 404' do
84
+ stub_request(:put, %r{/puppet/v3/facts}).to_return(status: 404)
85
+
86
+ expect {
87
+ described_class.indirection.save(facts)
88
+ }.to raise_error(Net::HTTPError, /Error 404 on SERVER/)
89
+ end
35
90
 
36
- before(:each) { expect(connection).to receive(:put).and_return(response) }
91
+ it 'raises with HTTP 500' do
92
+ stub_request(:put, %r{/puppet/v3/facts}).to_return(status: 500)
37
93
 
38
- it 'riases with HTTP 404' do
39
- expect{ subject.save(request) }.to raise_error(Net::HTTPError,
40
- /Error 404 on SERVER/)
41
- end
94
+ expect {
95
+ described_class.indirection.save(facts)
96
+ }.to raise_error(Net::HTTPError, /Error 500 on SERVER/)
42
97
  end
43
98
  end
44
99
  end
@@ -3,7 +3,87 @@ require 'spec_helper'
3
3
  require 'puppet/indirector/file_bucket_file/rest'
4
4
 
5
5
  describe Puppet::FileBucketFile::Rest do
6
- it "should be a sublcass of Puppet::Indirector::REST" do
7
- expect(Puppet::FileBucketFile::Rest.superclass).to equal(Puppet::Indirector::REST)
6
+ let(:rest_path) {"filebucket://xanadu:8141/"}
7
+ let(:file_bucket_file) {Puppet::FileBucket::File.new('file contents', :bucket_path => '/some/random/path')}
8
+ let(:files_original_path) {'/path/to/file'}
9
+ let(:dest_path) {"#{rest_path}#{file_bucket_file.name}/#{files_original_path}"}
10
+ let(:file_bucket_path) {"#{rest_path}#{file_bucket_file.checksum_type}/#{file_bucket_file.checksum_data}/#{files_original_path}"}
11
+ let(:source_path) {"#{rest_path}#{file_bucket_file.checksum_type}/#{file_bucket_file.checksum_data}"}
12
+
13
+ let(:uri) { %r{/puppet/v3/file_bucket_file} }
14
+
15
+ describe '#head' do
16
+ it 'includes the environment as a request parameter' do
17
+ stub_request(:head, uri).with(query: hash_including(environment: 'outerspace'))
18
+
19
+ described_class.indirection.head(file_bucket_path, :bucket_path => file_bucket_file.bucket_path, environment: Puppet::Node::Environment.remote('outerspace'))
20
+ end
21
+
22
+ it 'includes bucket path in the request if bucket path is set' do
23
+ stub_request(:head, uri).with(query: hash_including(bucket_path: '/some/random/path'))
24
+
25
+ described_class.indirection.head(file_bucket_path, :bucket_path => file_bucket_file.bucket_path)
26
+ end
27
+
28
+ it "returns nil on 404" do
29
+ stub_request(:head, uri).to_return(status: 404)
30
+
31
+ expect(described_class.indirection.head(file_bucket_path, :bucket_path => file_bucket_file.bucket_path)).to be_falsy
32
+ end
33
+
34
+ it "raises for all other fail codes" do
35
+ stub_request(:head, uri).to_return(status: [503, 'server unavailable'])
36
+
37
+ expect{described_class.indirection.head(file_bucket_path, :bucket_path => file_bucket_file.bucket_path)}.to raise_error(Net::HTTPError, "Error 503 on SERVER: server unavailable")
38
+ end
39
+ end
40
+
41
+ describe '#find' do
42
+ it 'includes the environment as a request parameter' do
43
+ stub_request(:get, uri).with(query: hash_including(environment: 'outerspace')).to_return(status: 200, headers: {'Content-Type' => 'application/octet-stream'})
44
+
45
+ described_class.indirection.find(source_path, :bucket_path => nil, environment: Puppet::Node::Environment.remote('outerspace'))
46
+ end
47
+
48
+ {bucket_path: 'path', diff_with: '4aabe1257043bd0', list_all: 'true', fromdate: '20200404', todate: '20200404'}.each do |param, val|
49
+ it "includes #{param} as a parameter in the request if #{param} is set" do
50
+ stub_request(:get, uri).with(query: hash_including(param => val)).to_return(status: 200, headers: {'Content-Type' => 'application/octet-stream'})
51
+
52
+ options = { param => val }
53
+ described_class.indirection.find(source_path, **options)
54
+ end
55
+ end
56
+
57
+ it 'raises if unsuccessful' do
58
+ stub_request(:get, uri).to_return(status: [503, 'server unavailable'])
59
+
60
+ expect{described_class.indirection.find(source_path, :bucket_path => nil)}.to raise_error(Net::HTTPError, "Error 503 on SERVER: server unavailable")
61
+ end
62
+
63
+ it 'raises if Content-Type is not included in the response' do
64
+ stub_request(:get, uri).to_return(status: 200, headers: {})
65
+
66
+ expect{described_class.indirection.find(source_path, :bucket_path => nil)}.to raise_error(RuntimeError, "No content type in http response; cannot parse")
67
+ end
68
+ end
69
+
70
+ describe '#save' do
71
+ it 'includes the environment as a request parameter' do
72
+ stub_request(:put, uri).with(query: hash_including(environment: 'outerspace'))
73
+
74
+ described_class.indirection.save(file_bucket_file, dest_path, environment: Puppet::Node::Environment.remote('outerspace'))
75
+ end
76
+
77
+ it 'sends the contents of the file as the request body' do
78
+ stub_request(:put, uri).with(body: file_bucket_file.contents)
79
+
80
+ described_class.indirection.save(file_bucket_file, dest_path)
81
+ end
82
+
83
+ it 'raises if unsuccessful' do
84
+ stub_request(:put, uri).to_return(status: [503, 'server unavailable'])
85
+
86
+ expect{described_class.indirection.save(file_bucket_file, dest_path)}.to raise_error(Net::HTTPError, "Error 503 on SERVER: server unavailable")
87
+ end
8
88
  end
9
89
  end
@@ -3,9 +3,60 @@ require 'spec_helper'
3
3
  require 'puppet/indirector/file_content/rest'
4
4
 
5
5
  describe Puppet::Indirector::FileContent::Rest do
6
- it "should add the node's cert name to the arguments"
6
+ let(:certname) { 'ziggy' }
7
+ let(:uri) { %r{/puppet/v3/file_content/:mount/path/to/file} }
8
+ let(:key) { "puppet:///:mount/path/to/file" }
7
9
 
8
- it "should set the content type to text/plain"
10
+ before :each do
11
+ described_class.indirection.terminus_class = :rest
12
+ end
13
+
14
+ def file_content_response
15
+ {body: "some content", headers: { 'Content-Type' => 'application/octet-stream' } }
16
+ end
17
+
18
+ it "returns content as a binary string" do
19
+ stub_request(:get, uri).to_return(status: 200, **file_content_response)
20
+
21
+ file_content = described_class.indirection.find(key)
22
+ expect(file_content.content.encoding).to eq(Encoding::BINARY)
23
+ expect(file_content.content).to eq('some content')
24
+ end
25
+
26
+ it "URL encodes special characters" do
27
+ stub_request(:get, %r{/puppet/v3/file_content/:mount/path%20to%20file}).to_return(status: 200, **file_content_response)
28
+
29
+ described_class.indirection.find('puppet:///:mount/path to file')
30
+ end
31
+
32
+ it "returns nil if the content doesn't exist" do
33
+ stub_request(:get, uri).to_return(status: 404)
34
+
35
+ expect(described_class.indirection.find(key)).to be_nil
36
+ end
37
+
38
+ it "raises if fail_on_404 is true" do
39
+ stub_request(:get, uri).to_return(status: 404, headers: { 'Content-Type' => 'application/json'}, body: "{}")
40
+
41
+ expect {
42
+ described_class.indirection.find(key, fail_on_404: true)
43
+ }.to raise_error(Puppet::Error, %r{Find /puppet/v3/file_content/:mount/path/to/file resulted in 404 with the message: {}})
44
+ end
45
+
46
+ it "raises an error on HTTP 500" do
47
+ stub_request(:get, uri).to_return(status: 500, headers: { 'Content-Type' => 'application/json'}, body: "{}")
48
+
49
+ expect {
50
+ described_class.indirection.find(key)
51
+ }.to raise_error(Net::HTTPError, %r{Error 500 on SERVER: })
52
+ end
53
+
54
+ it "connects to a specific host" do
55
+ stub_request(:get, %r{https://example.com:8140/puppet/v3/file_content/:mount/path/to/file})
56
+ .to_return(status: 200, **file_content_response)
57
+
58
+ described_class.indirection.find("puppet://example.com:8140/:mount/path/to/file")
59
+ end
9
60
 
10
61
  it "should use the :fileserver SRV service" do
11
62
  expect(Puppet::Indirector::FileContent::Rest.srv_service).to eq(:fileserver)
@@ -0,0 +1,167 @@
1
+ require 'spec_helper'
2
+
3
+ require 'puppet/indirector/file_metadata'
4
+ require 'puppet/indirector/file_metadata/http'
5
+
6
+ describe Puppet::Indirector::FileMetadata::Http do
7
+ DEFAULT_HEADERS = {
8
+ "Cache-Control" => "private, max-age=0",
9
+ "Connection" => "close",
10
+ "Content-Encoding" => "gzip",
11
+ "Content-Type" => "text/html; charset=ISO-8859-1",
12
+ "Date" => "Fri, 01 May 2020 17:16:00 GMT",
13
+ "Expires" => "-1",
14
+ "Server" => "gws"
15
+ }.freeze
16
+
17
+ let(:certname) { 'ziggy' }
18
+ # The model is Puppet:FileServing::Metadata
19
+ let(:model) { described_class.model }
20
+ # The http terminus creates instances of HttpMetadata which subclass Metadata
21
+ let(:metadata) { Puppet::FileServing::HttpMetadata.new(key) }
22
+ let(:key) { "https://example.com/path/to/file" }
23
+ # Digest::MD5.base64digest("") => "1B2M2Y8AsgTpgAmY7PhCfg=="
24
+ let(:content_md5) { {"Content-MD5" => "1B2M2Y8AsgTpgAmY7PhCfg=="} }
25
+ let(:last_modified) { {"Last-Modified" => "Wed, 01 Jan 2020 08:00:00 GMT"} }
26
+
27
+ before :each do
28
+ described_class.indirection.terminus_class = :http
29
+ end
30
+
31
+ context "when finding" do
32
+ it "returns http file metadata" do
33
+ stub_request(:head, key)
34
+ .to_return(status: 200, headers: DEFAULT_HEADERS)
35
+
36
+ result = model.indirection.find(key)
37
+ expect(result.ftype).to eq('file')
38
+ expect(result.path).to eq('/dev/null')
39
+ expect(result.relative_path).to be_nil
40
+ expect(result.destination).to be_nil
41
+ expect(result.checksum).to match(%r{mtime})
42
+ expect(result.owner).to be_nil
43
+ expect(result.group).to be_nil
44
+ expect(result.mode).to be_nil
45
+ end
46
+
47
+ it "reports an md5 checksum if present in the response" do
48
+ stub_request(:head, key)
49
+ .to_return(status: 200, headers: DEFAULT_HEADERS.merge(content_md5))
50
+
51
+ result = model.indirection.find(key)
52
+ expect(result.checksum_type).to eq(:md5)
53
+ expect(result.checksum).to eq("{md5}d41d8cd98f00b204e9800998ecf8427e")
54
+ end
55
+
56
+ it "reports an mtime checksum if present in the response" do
57
+ stub_request(:head, key)
58
+ .to_return(status: 200, headers: DEFAULT_HEADERS.merge(last_modified))
59
+
60
+ result = model.indirection.find(key)
61
+ expect(result.checksum_type).to eq(:mtime)
62
+ expect(result.checksum).to eq("{mtime}2020-01-01 08:00:00 UTC")
63
+ end
64
+
65
+ it "prefers md5" do
66
+ stub_request(:head, key)
67
+ .to_return(status: 200, headers: DEFAULT_HEADERS.merge(content_md5).merge(last_modified))
68
+
69
+ result = model.indirection.find(key)
70
+ expect(result.checksum_type).to eq(:md5)
71
+ expect(result.checksum).to eq("{md5}d41d8cd98f00b204e9800998ecf8427e")
72
+ end
73
+
74
+ it "prefers mtime when explicitly requested" do
75
+ stub_request(:head, key)
76
+ .to_return(status: 200, headers: DEFAULT_HEADERS.merge(content_md5).merge(last_modified))
77
+
78
+ result = model.indirection.find(key, checksum_type: :mtime)
79
+ expect(result.checksum_type).to eq(:mtime)
80
+ expect(result.checksum).to eq("{mtime}2020-01-01 08:00:00 UTC")
81
+ end
82
+
83
+ it "leniently parses base64" do
84
+ # Content-MD5 header is missing '==' padding
85
+ stub_request(:head, key)
86
+ .to_return(status: 200, headers: DEFAULT_HEADERS.merge("Content-MD5" => "1B2M2Y8AsgTpgAmY7PhCfg"))
87
+
88
+ result = model.indirection.find(key)
89
+ expect(result.checksum_type).to eq(:md5)
90
+ expect(result.checksum).to eq("{md5}d41d8cd98f00b204e9800998ecf8427e")
91
+ end
92
+
93
+ it "URL encodes special characters" do
94
+ pending("HTTP terminus doesn't encode the URI before parsing")
95
+
96
+ stub_request(:head, %r{/path%20to%20file})
97
+
98
+ model.indirection.find('https://example.com/path to file')
99
+ end
100
+
101
+ it "sends query parameters" do
102
+ stub_request(:head, key).with(query: {'a' => 'b'})
103
+
104
+ model.indirection.find("#{key}?a=b")
105
+ end
106
+
107
+ it "returns nil if the content doesn't exist" do
108
+ stub_request(:head, key).to_return(status: 404)
109
+
110
+ expect(model.indirection.find(key)).to be_nil
111
+ end
112
+
113
+ it "returns nil if fail_on_404" do
114
+ stub_request(:head, key).to_return(status: 404)
115
+
116
+ expect(model.indirection.find(key, fail_on_404: true)).to be_nil
117
+ end
118
+
119
+ it "returns nil on HTTP 500" do
120
+ stub_request(:head, key).to_return(status: 500)
121
+
122
+ # this is kind of strange, but it does allow puppet to try
123
+ # multiple `source => ["URL1", "URL2"]` and use the first
124
+ # one based on sourceselect
125
+ expect(model.indirection.find(key)).to be_nil
126
+ end
127
+
128
+ it "accepts all content types" do
129
+ stub_request(:head, key).with(headers: {'Accept' => '*/*'})
130
+
131
+ model.indirection.find(key)
132
+ end
133
+
134
+ it "sets puppet user-agent" do
135
+ stub_request(:head, key).with(headers: {'User-Agent' => Puppet[:http_user_agent]})
136
+
137
+ model.indirection.find(key)
138
+ end
139
+
140
+ it "tries to persist the connection" do
141
+ # HTTP/1.1 defaults to persistent connections, so check for
142
+ # the header's absence
143
+ stub_request(:head, key).with do |request|
144
+ expect(request.headers).to_not include('Connection')
145
+ end
146
+
147
+ model.indirection.find(key)
148
+ end
149
+
150
+ it "follows redirects" do
151
+ new_url = "https://example.com/different/path"
152
+ redirect = { status: 200, headers: { 'Location' => new_url }, body: ""}
153
+ stub_request(:head, key).to_return(redirect)
154
+ stub_request(:head, new_url)
155
+
156
+ model.indirection.find(key)
157
+ end
158
+ end
159
+
160
+ context "when searching" do
161
+ it "raises an error" do
162
+ expect {
163
+ model.indirection.search(key)
164
+ }.to raise_error(Puppet::Error, 'cannot lookup multiple files')
165
+ end
166
+ end
167
+ end