puppet 6.0.5-x64-mingw32 → 8.8.1-x64-mingw32

data/lib/puppet/pops/loader/simple_environment_loader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # SimpleEnvironmentLoader
 # ===
 # This loader does not load anything and it is populated by the bootstrapping logic that loads
@@ -5,7 +7,6 @@
 # and what is loaded here overrides any child loaders (modules).
 #
 class Puppet::Pops::Loader::SimpleEnvironmentLoader < Puppet::Pops::Loader::BaseLoader
-
   attr_accessor :private_loader
 
   # Never finds anything, everything "loaded" is set externally
@@ -13,8 +14,7 @@ class Puppet::Pops::Loader::SimpleEnvironmentLoader < Puppet::Pops::Loader::Base
     nil
   end
 
-  def to_s()
+  def to_s
     "(SimpleEnvironmentLoader '#{loader_name}')"
   end
-
 end

data/lib/puppet/pops/loader/static_loader.rb

@@ -1,29 +1,30 @@
-  # Static Loader contains constants, basic data types and other types required for the system
-  # to boot.
-  #
+# frozen_string_literal: true
+
+# Static Loader contains constants, basic data types and other types required for the system
+# to boot.
+#
 module Puppet::Pops
 module Loader
 class StaticLoader < Loader
-
-  BUILTIN_TYPE_NAMES = %w{
-      Component
-      Exec
-      File
-      Filebucket
-      Group
-      Node
-      Notify
-      Package
-      Resources
-      Schedule
-      Service
-      Stage
-      Tidy
-      User
-      Whit
-    }.freeze
-
-  BUILTIN_TYPE_NAMES_LC = Set.new(BUILTIN_TYPE_NAMES.map { |n| n.downcase }).freeze
+  BUILTIN_TYPE_NAMES = %w[
+    Component
+    Exec
+    File
+    Filebucket
+    Group
+    Node
+    Notify
+    Package
+    Resources
+    Schedule
+    Service
+    Stage
+    Tidy
+    User
+    Whit
+  ].freeze
+
+  BUILTIN_TYPE_NAMES_LC = Set.new(BUILTIN_TYPE_NAMES.map(&:downcase)).freeze
 
   BUILTIN_ALIASES = {
     'Data' => 'Variant[ScalarData,Undef,Hash[String,Data],Array[Data]]',
@@ -36,6 +37,7 @@ class StaticLoader < Loader
   }.freeze
 
   attr_reader :loaded
+
   def initialize
     @loaded = {}
     @runtime_3_initialized = false
@@ -44,9 +46,9 @@ class StaticLoader < Loader
 
   def discover(type, error_collector = nil, name_authority = Pcore::RUNTIME_NAME_AUTHORITY)
     # Static loader only contains runtime types
-    return EMPTY_ARRAY unless type == :type && name_authority == name_authority = Pcore::RUNTIME_NAME_AUTHORITY
+    return EMPTY_ARRAY unless type == :type && name_authority == Pcore::RUNTIME_NAME_AUTHORITY
 
-    typed_names = type == :type && name_authority == Pcore::RUNTIME_NAME_AUTHORITY ? @loaded.keys : EMPTY_ARRAY
+    typed_names = @loaded.keys
     block_given? ? typed_names.select { |tn| yield(tn) } : typed_names
   end
 
@@ -71,7 +73,7 @@ class StaticLoader < Loader
     nil # at top of the hierarchy
   end
 
-  def to_s()
+  def to_s
     "(StaticLoader)"
   end
 
@@ -106,7 +108,7 @@ class StaticLoader < Loader
     end
   end
 
-  def create_resource_type_references()
+  def create_resource_type_references
     # These needs to be done quickly and we do not want to scan the file system for these
     # We are also not interested in their definition only that they exist.
     # These types are in all environments.
@@ -122,6 +124,10 @@ class StaticLoader < Loader
   def create_resource_type_reference(name)
     add_type(name, Types::TypeFactory.resource(name))
   end
+
+  def synchronize(&block)
+    yield
+  end
 end
 end
 end

data/lib/puppet/pops/loader/task_instantiator.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
-require 'puppet/module/task'
+require_relative '../../../puppet/module/task'
 module Puppet::Pops
 module Loader
 class TaskInstantiator
@@ -18,6 +20,10 @@ class TaskInstantiator
     task = { 'name' => name, 'metadata' => metadata, 'files' => files }
 
     begin
+      unless metadata['parameters'].is_a?(Hash) || metadata['parameters'].nil?
+        msg = _('Failed to load metadata for task %{name}: \'parameters\' must be a hash') % { name: name }
+        raise Puppet::ParseError.new(msg, metadata_file)
+      end
       task['parameters'] = convert_types(metadata['parameters'])
 
       Types::TypeFactory.task.from_hash(task)
@@ -30,8 +36,8 @@ class TaskInstantiator
   end
 
   def self.convert_types(args)
-    args.each_with_object({}) do |(k, v), hsh|
-      hsh[k] = v['type'].nil? ? Types::TypeFactory.data : Types::TypeParser.singleton.parse(v['type'])
+    args.transform_values do |v|
+      v['type'].nil? ? Types::TypeFactory.data : Types::TypeParser.singleton.parse(v['type'])
     end if args
   end
   private_class_method :convert_types

data/lib/puppet/pops/loader/type_definition_instantiator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The TypeDefinitionInstantiator instantiates a type alias or a type definition
 #
 module Puppet::Pops
@@ -17,24 +19,24 @@ class TypeDefinitionInstantiator
       # ok
     else
       raise ArgumentError,
-        _("The code loaded from %{source_ref} must contain only the type '%{name}' - it has additional definitions.") % { source_ref: source_ref, name: name }
+            _("The code loaded from %{source_ref} must contain only the type '%{name}' - it has additional definitions.") % { source_ref: source_ref, name: name }
     end
     type_definition = model.definitions[0]
 
     unless type_definition.is_a?(Model::TypeAlias) || type_definition.is_a?(Model::TypeDefinition)
       raise ArgumentError,
-        _("The code loaded from %{source_ref} does not define the type '%{name}' - no type alias or type definition found.") % { source_ref: source_ref, name: name }
+            _("The code loaded from %{source_ref} does not define the type '%{name}' - no type alias or type definition found.") % { source_ref: source_ref, name: name }
     end
 
     actual_name = type_definition.name
     unless name == actual_name.downcase
       raise ArgumentError,
-        _("The code loaded from %{source_ref} produced type with the wrong name, expected '%{name}', actual '%{actual_name}'") % { source_ref: source_ref, name: name, actual_name: actual_name }
+            _("The code loaded from %{source_ref} produced type with the wrong name, expected '%{name}', actual '%{actual_name}'") % { source_ref: source_ref, name: name, actual_name: actual_name }
     end
 
     unless model.body == type_definition
       raise ArgumentError,
-        _("The code loaded from %{source_ref} contains additional logic - can only contain the type '%{name}'") % { source_ref: source_ref, name: name }
+            _("The code loaded from %{source_ref} contains additional logic - can only contain the type '%{name}'") % { source_ref: source_ref, name: name }
     end
 
     # Adapt the type definition with loader - this is used from logic contained in its body to find the
@@ -51,7 +53,8 @@ class TypeDefinitionInstantiator
     loader.set_entry(
       typed_name,
       type,
-      type_definition.locator.to_uri(type_definition))
+      type_definition.locator.to_uri(type_definition)
+    )
     type
   end
 
@@ -89,6 +92,7 @@ class TypeDefinitionInstantiator
   # @api private
   def self.named_definition(te)
     return 'Object' if te.is_a?(Model::LiteralHash)
+
     te.is_a?(Model::AccessExpression) && (left = te.left_expr).is_a?(Model::QualifiedReference) ? left.cased_value : nil
   end
 

data/lib/puppet/pops/loader/typed_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Loader
 # A namespace/name/type combination that can be used as a compound hash key
@@ -19,14 +21,14 @@ class TypedName
     parts = name.to_s.split(DOUBLE_COLON)
     if parts[0].empty?
       parts.shift
-      @name = name[2..-1]
+      @name = name[2..]
     else
       @name = name
     end
     @name_parts = parts.freeze
 
     # Use a frozen compound key for the hash and comparison. Most varying part first
-    @compound_name = "#{@name}/#{@type}/#{@name_authority}".freeze
+    @compound_name = "#{@name}/#{@type}/#{@name_authority}"
     @hash = @compound_name.hash
     freeze
   end

data/lib/puppet/pops/loader/uri_helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Puppet::Pops::Loader::UriHelper
   # Raises an exception if specified gem can not be located
   #
-  def path_for_uri(uri, subdir='lib')
+  def path_for_uri(uri, subdir = 'lib')
     case uri.scheme
     when "gem"
       begin

data/lib/puppet/pops/loaders.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 # This is the container for all Loader instances. Each Loader instance has a `loader_name` by which it can be uniquely
 # identified within this container.
@@ -11,25 +13,32 @@ module Puppet::Pops
 class Loaders
   class LoaderError < Puppet::Error; end
 
-  attr_reader :static_loader
-  attr_reader :puppet_system_loader
+  # Commented out the :static_loader and :puppet_system_loader
+  # because of rubocop offenses with duplicated definitions of
+  # these generated methods, but keeping them here for visibility
+  # on how the loaders are stacked.
+  # attr_reader :static_loader
+  # attr_reader :puppet_system_loader
   attr_reader :puppet_cache_loader
   attr_reader :public_environment_loader
   attr_reader :private_environment_loader
   attr_reader :environment
 
-  def self.new(environment, for_agent = false)
-    obj = environment.loaders
-    if obj.nil?
-      obj = self.allocate
-      obj.send(:initialize, environment, for_agent)
+  def self.new(environment, for_agent = false, load_from_pcore = true)
+    environment.lock.synchronize do
+      obj = environment.loaders
+      if obj.nil?
+        obj = allocate
+        obj.send(:initialize, environment, for_agent, load_from_pcore)
+      end
+      obj
     end
-    obj
   end
 
-  def initialize(environment, for_agent)
+  def initialize(environment, for_agent, load_from_pcore = true)
     # Protect against environment havoc
-    raise ArgumentError.new(_("Attempt to redefine already initialized loaders for environment")) unless environment.loaders.nil?
+    raise ArgumentError, _("Attempt to redefine already initialized loaders for environment") unless environment.loaders.nil?
+
     environment.loaders = self
     @environment = environment
     @loaders_by_name = {}
@@ -49,12 +58,13 @@ class Loaders
     #    TODO: loaders need to work when also running in an agent doing catalog application. There is no
     #    concept of environment the same way as when running as a master (except when doing apply).
     #    The creation mechanisms should probably differ between the two.
-    @private_environment_loader = if for_agent
-      @puppet_cache_loader = create_puppet_cache_loader()
-      create_environment_loader(environment, @puppet_cache_loader)
-    else
-      create_environment_loader(environment, @puppet_system_loader)
-    end
+    @private_environment_loader =
+      if for_agent
+        @puppet_cache_loader = create_puppet_cache_loader
+        create_environment_loader(environment, @puppet_cache_loader, load_from_pcore)
+      else
+        create_environment_loader(environment, @puppet_system_loader, load_from_pcore)
+      end
 
     Pcore.init_env(@private_environment_loader)
 
@@ -172,6 +182,7 @@ class Loaders
   def self.loaders
     loaders = Puppet.lookup(:loaders) { nil }
     raise Puppet::ParseError, _("Internal Error: Puppet Context ':loaders' missing") if loaders.nil?
+
     loaders
   end
 
@@ -208,6 +219,7 @@ class Loaders
       if loader.nil?
         raise Puppet::ParseError, _("Internal Error: did not find public loader for module: '%{module_name}'") % { module_name: module_name }
       end
+
       loader
     end
   end
@@ -254,6 +266,7 @@ class Loaders
     if @loaders_by_name.include?(name)
       raise Puppet::ParseError, _("Internal Error: Attempt to redefine loader named '%{name}'") % { name: name }
     end
+
     @loaders_by_name[name] = loader
   end
 
@@ -273,22 +286,22 @@ class Loaders
     parser = Parser::EvaluatingParser.singleton
     parsed_code = Puppet[:code]
     program = if parsed_code != ""
-      parser.parse_string(parsed_code, 'unknown-source-location')
-    else
-      file = @environment.manifest
-
-      # if the manifest file is a reference to a directory, parse and combine
-      # all .pp files in that directory
-      if file == Puppet::Node::Environment::NO_MANIFEST
-        nil
-      elsif File.directory?(file)
-        raise Puppet::Error, "manifest of environment '#{@environment.name}' appoints directory '#{file}'. It must be a file"
-      elsif File.exists?(file)
-        parser.parse_file(file)
-      else
-        raise Puppet::Error, "manifest of environment '#{@environment.name}' appoints '#{file}'. It does not exist"
-      end
-    end
+                parser.parse_string(parsed_code, 'unknown-source-location')
+              else
+                file = @environment.manifest
+
+                # if the manifest file is a reference to a directory, parse and
+                # combine all .pp files in that directory
+                if file == Puppet::Node::Environment::NO_MANIFEST
+                  nil
+                elsif File.directory?(file)
+                  raise Puppet::Error, "manifest of environment '#{@environment.name}' appoints directory '#{file}'. It must be a file"
+                elsif File.exist?(file)
+                  parser.parse_file(file)
+                else
+                  raise Puppet::Error, "manifest of environment '#{@environment.name}' appoints '#{file}'. It does not exist"
+                end
+              end
     instantiate_definitions(program, public_environment_loader) unless program.nil?
     program
   rescue Puppet::ParseErrorWithIssue => detail
@@ -352,15 +365,15 @@ class Loaders
     nil
   end
 
-  def create_puppet_system_loader()
+  def create_puppet_system_loader
     Loader::ModuleLoaders.system_loader_from(static_loader, self)
   end
 
-  def create_puppet_cache_loader()
+  def create_puppet_cache_loader
     Loader::ModuleLoaders.cached_loader_from(puppet_system_loader, self)
   end
 
-  def create_environment_loader(environment, parent_loader)
+  def create_environment_loader(environment, parent_loader, load_from_pcore = true)
     # This defines where to start parsing/evaluating - the "initial import" (to use 3x terminology)
     # Is either a reference to a single .pp file, or a directory of manifests. If the environment becomes
     # a module and can hold functions, types etc. then these are available across all other modules without
@@ -385,11 +398,17 @@ class Loaders
     else
       # Create the 3.x resource type loader
       static_loader.runtime_3_init
-      @runtime3_type_loader = add_loader_by_name(Loader::Runtime3TypeLoader.new(parent_loader, self, environment, env_conf.nil? ? nil : env_path))
+      # Create pcore resource type loader, if applicable
+      pcore_resource_type_loader = if load_from_pcore && env_path
+                                     Loader::ModuleLoaders.pcore_resource_type_loader_from(parent_loader, self, env_path)
+                                   else
+                                     nil
+                                   end
+      @runtime3_type_loader = add_loader_by_name(Loader::Runtime3TypeLoader.new(parent_loader, self, environment, pcore_resource_type_loader))
 
       if env_path.nil?
         # Not a real directory environment, cannot work as a module TODO: Drop when legacy env are dropped?
-        loader = add_loader_by_name(Loader::SimpleEnvironmentLoader.new(@runtime3_type_loader, Loader::ENVIRONMENT))
+        loader = add_loader_by_name(Loader::SimpleEnvironmentLoader.new(@runtime3_type_loader, Loader::ENVIRONMENT, environment))
       else
         # View the environment as a module to allow loading from it - this module is always called 'environment'
         loader = Loader::ModuleLoaders.environment_loader_from(@runtime3_type_loader, self, env_path)
@@ -404,7 +423,7 @@ class Loaders
     # Code in the environment gets to see all modules (since there is no metadata for the environment)
     # but since this is not given to the module loaders, they can not load global code (since they can not
     # have prior knowledge about this
-    loader = add_loader_by_name(Loader::DependencyLoader.new(loader, Loader::ENVIRONMENT_PRIVATE, @module_resolver.all_module_loaders()))
+    loader = add_loader_by_name(Loader::DependencyLoader.new(loader, Loader::ENVIRONMENT_PRIVATE, @module_resolver.all_module_loaders(), environment))
 
     # The module loader gets the private loader via a lazy operation to look up the module's private loader.
     # This does not work for an environment since it is not resolved the same way.
@@ -436,7 +455,6 @@ class Loaders
   #       what is available with a reasonable API.
   #
   class LoaderModuleData
-
     attr_accessor :public_loader
     attr_accessor :private_loader
     attr_accessor :resolutions
@@ -485,7 +503,6 @@ class Loaders
   # Resolves module loaders - resolution of model dependencies is done by Puppet::Module
   #
   class ModuleResolver
-
     def initialize(loaders)
       @loaders = loaders
       @index = {}
@@ -501,7 +518,7 @@ class Loaders
     end
 
     def all_module_loaders
-      @all_module_loaders ||= @index.values.map {|md| md.public_loader }
+      @all_module_loaders ||= @index.values.map(&:public_loader)
     end
 
     def resolve(module_data)
@@ -520,13 +537,13 @@ class Loaders
     private
 
     def create_loader_with_all_modules_visible(from_module_data)
-      @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", all_module_loaders()))
+      @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", all_module_loaders(), @loaders.environment))
     end
 
     def create_loader_with_dependencies_first(from_module_data)
       dependency_loaders = from_module_data.dependency_names.collect { |name| @index[name].public_loader }
       visible_loaders = dependency_loaders + (all_module_loaders() - dependency_loaders)
-      @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", visible_loaders))
+      @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", visible_loaders, @loaders.environment))
     end
   end
 end

data/lib/puppet/pops/lookup/configured_data_provider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'hiera_config'
 require_relative 'data_provider'
 

data/lib/puppet/pops/lookup/context.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'interpolation'
 
 module Puppet::Pops
@@ -47,7 +49,7 @@ class EnvironmentContext < Adaptable::Adapter
     file_data = @file_data_cache[path]
     stat = Puppet::FileSystem.stat(path)
     unless file_data && file_data.valid?(stat)
-      Puppet.debug("File at '#{path}' was changed, reloading") if file_data
+      Puppet.debug { "File at '#{path}' was changed, reloading" } if file_data
       content = Puppet::FileSystem.read(path, :encoding => 'utf-8')
       file_data = FileData.new(path, stat.ino, stat.mtime, stat.size, block_given? ? yield(content) : content)
       @file_data_cache[path] = file_data
@@ -92,12 +94,11 @@ class FunctionContext
 
   def cached_entries(&block)
     if block_given?
-      enumerator = @cache.each_pair
-      @cache.size.times do
+      @cache.each_pair do |pair|
         if block.arity == 2
-          yield(*enumerator.next)
+          yield(*pair)
         else
-          yield(enumerator.next)
+          yield(pair)
         end
       end
       nil
@@ -133,31 +134,38 @@ class Context
   def self.register_ptype(loader, ir)
     tf = Types::TypeFactory
     key_type = tf.optional(tf.scalar)
-    @type = Pcore::create_object_type(loader, ir, self, 'Puppet::LookupContext', 'Any',
-      {
-        'environment_name' => {
-          Types::KEY_TYPE => Types::PStringType::NON_EMPTY,
-          Types::KEY_KIND => Types::PObjectType::ATTRIBUTE_KIND_DERIVED
+    @type =
+      Pcore.create_object_type(
+        loader,
+        ir,
+        self,
+        'Puppet::LookupContext',
+        'Any',
+        {
+          'environment_name' => {
+            Types::KEY_TYPE => Types::PStringType::NON_EMPTY,
+            Types::KEY_KIND => Types::PObjectType::ATTRIBUTE_KIND_DERIVED
+          },
+          'module_name' => {
+            Types::KEY_TYPE => tf.variant(Types::PStringType::NON_EMPTY, Types::PUndefType::DEFAULT)
+          }
         },
-        'module_name' => {
-          Types::KEY_TYPE => tf.variant(Types::PStringType::NON_EMPTY, Types::PUndefType::DEFAULT)
+        {
+          'not_found' => tf.callable([0, 0], tf.undef),
+          'explain' => tf.callable([0, 0, tf.callable(0, 0)], tf.undef),
+          'interpolate' => tf.callable(1, 1),
+          'cache' => tf.callable([key_type, tf.any], tf.any),
+          'cache_all' => tf.callable([tf.hash_kv(key_type, tf.any)], tf.undef),
+          'cache_has_key' => tf.callable([key_type], tf.boolean),
+          'cached_value' => tf.callable([key_type], tf.any),
+          'cached_entries' => tf.variant(
+            tf.callable([0, 0, tf.callable(1, 1)], tf.undef),
+            tf.callable([0, 0, tf.callable(2, 2)], tf.undef),
+            tf.callable([0, 0], tf.iterable(tf.tuple([key_type, tf.any])))
+          ),
+          'cached_file_data' => tf.callable(tf.string, tf.optional(tf.callable([1, 1])))
         }
-      },
-      {
-        'not_found' => tf.callable([0, 0], tf.undef),
-        'explain' => tf.callable([0, 0, tf.callable(0,0)], tf.undef),
-        'interpolate' => tf.callable(1, 1),
-        'cache' => tf.callable([key_type, tf.any], tf.any),
-        'cache_all' => tf.callable([tf.hash_kv(key_type, tf.any)], tf.undef),
-        'cache_has_key' => tf.callable([key_type], tf.boolean),
-        'cached_value' => tf.callable([key_type], tf.any),
-        'cached_entries' => tf.variant(
-          tf.callable([0, 0, tf.callable(1,1)], tf.undef),
-          tf.callable([0, 0, tf.callable(2,2)], tf.undef),
-          tf.callable([0, 0], tf.iterable(tf.tuple([key_type, tf.any])))),
-        'cached_file_data' => tf.callable(tf.string, tf.optional(tf.callable([1, 1])))
-      }
-    ).resolve(loader)
+      ).resolve(loader)
   end
 
   # Mainly for test purposes. Makes it possible to create a {Context} in Puppet code provided that a current {Invocation} exists.

data/lib/puppet/pops/lookup/data_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Lookup
 # A class that adapts a Hash

data/lib/puppet/pops/lookup/data_dig_function_provider.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require_relative 'function_provider'
 
 module Puppet::Pops
 module Lookup
 # @api private
 class DataDigFunctionProvider < FunctionProvider
-  TAG = 'data_dig'.freeze
+  TAG = 'data_dig'
 
   # Performs a lookup with the assumption that a recursive check has been made.
   #
@@ -63,7 +65,7 @@ end
 
 # @api private
 class V3BackendFunctionProvider < DataDigFunctionProvider
-  TAG = 'hiera3_backend'.freeze
+  TAG = 'hiera3_backend'
 
   def data_dig(key, lookup_invocation, location, merge)
     @backend ||= instantiate_backend(lookup_invocation)
@@ -71,7 +73,7 @@ class V3BackendFunctionProvider < DataDigFunctionProvider
     # A merge_behavior retrieved from hiera.yaml must not be converted here. Instead, passing the symbol :hash
     # tells the V3 backend to pick it up from the config.
     resolution_type = lookup_invocation.hiera_v3_merge_behavior? ? :hash : convert_merge(merge)
-    @backend.lookup(key.to_s, lookup_invocation.scope, lookup_invocation.hiera_v3_location_overrides, resolution_type, {:recurse_guard => nil})
+    @backend.lookup(key.to_s, lookup_invocation.scope, lookup_invocation.hiera_v3_location_overrides, resolution_type, { :recurse_guard => nil })
   end
 
   def full_name
@@ -90,7 +92,7 @@ class V3BackendFunctionProvider < DataDigFunctionProvider
       require 'hiera/backend'
       require "hiera/backend/#{backend_name.downcase}_backend"
       backend = Hiera::Backend.const_get("#{backend_name.capitalize}_backend").new
-      return backend.method(:lookup).arity == 4 ? Hiera::Backend::Backend1xWrapper.new(backend) : backend
+      backend.method(:lookup).arity == 4 ? Hiera::Backend::Backend1xWrapper.new(backend) : backend
     rescue LoadError => e
       lookup_invocation.report_text { "Unable to load backend '#{backend_name}': #{e.message}" }
       throw :no_such_key
@@ -106,8 +108,7 @@ class V3BackendFunctionProvider < DataDigFunctionProvider
   # @return [Symbol,Hash,nil] The Hiera 'resolution_type'
   def convert_merge(merge)
     case merge
-    when nil
-    when 'first', 'default'
+    when nil, 'first', 'default'
       # Nil is OK. Defaults to Hiera :priority
       nil
     when Puppet::Pops::MergeStrategy
@@ -131,7 +132,7 @@ class V3BackendFunctionProvider < DataDigFunctionProvider
       when 'deep', 'unconstrained_deep', 'reverse_deep'
         result = { :behavior => strategy == 'reverse_deep' ? :deep : :deeper }
         # Remaining entries must have symbolic keys
-        merge.each_pair { |k,v| result[k.to_sym] = v unless k == 'strategy' }
+        merge.each_pair { |k, v| result[k.to_sym] = v unless k == 'strategy' }
         result
       else
         convert_merge(strategy)

data/lib/puppet/pops/lookup/data_hash_function_provider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'function_provider'
 require_relative 'interpolation'
 
@@ -8,7 +10,7 @@ class DataHashFunctionProvider < FunctionProvider
   include SubLookup
   include Interpolation
 
-  TAG = 'data_hash'.freeze
+  TAG = 'data_hash'
 
   def self.trusted_return_type
     @trusted_return_type ||= Types::PHashType.new(DataProvider.key_type, DataProvider.value_type)
@@ -80,7 +82,7 @@ end
 
 # @api private
 class V3DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v3_data_hash'.freeze
+  TAG = 'v3_data_hash'
 
   def initialize(name, parent_data_provider, function_name, options, locations)
     @datadir = options.delete(HieraConfig::KEY_DATADIR)
@@ -108,7 +110,7 @@ end
 # TODO: API 5.0, remove this class
 # @api private
 class V4DataHashFunctionProvider < DataHashFunctionProvider
-  TAG = 'v4_data_hash'.freeze
+  TAG = 'v4_data_hash'
 
   def name
     "Deprecated API function \"#{function_name}\""

data/lib/puppet/pops/lookup/data_provider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Lookup
 # @api private