puppet 6.0.10-x64-mingw32 → 6.1.0-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (748) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +1 -0
  3. data/Gemfile.lock +31 -27
  4. data/Guardfile.example +76 -0
  5. data/LICENSE +189 -4
  6. data/MAINTAINERS +47 -0
  7. data/README.md +3 -3
  8. data/lib/hiera/scope.rb +0 -7
  9. data/lib/puppet.rb +6 -5
  10. data/lib/puppet/application.rb +3 -3
  11. data/lib/puppet/application/cert.rb +2 -2
  12. data/lib/puppet/application/device.rb +83 -109
  13. data/lib/puppet/application/filebucket.rb +1 -10
  14. data/lib/puppet/application/ssl.rb +0 -2
  15. data/lib/puppet/configurer.rb +9 -10
  16. data/lib/puppet/confine/false.rb +1 -7
  17. data/lib/puppet/confine/true.rb +1 -7
  18. data/lib/puppet/defaults.rb +39 -51
  19. data/lib/puppet/forge.rb +1 -4
  20. data/lib/puppet/functions/abs.rb +1 -1
  21. data/lib/puppet/functions/call.rb +1 -2
  22. data/lib/puppet/functions/new.rb +1 -1
  23. data/lib/puppet/indirector/request.rb +15 -26
  24. data/lib/puppet/network/http/connection.rb +12 -32
  25. data/lib/puppet/network/http/factory.rb +0 -5
  26. data/lib/puppet/pal/catalog_compiler.rb +96 -0
  27. data/lib/puppet/pal/compiler.rb +221 -0
  28. data/lib/puppet/pal/function_signature.rb +52 -0
  29. data/lib/puppet/pal/json_catalog_encoder.rb +67 -0
  30. data/lib/puppet/pal/pal_api.rb +15 -0
  31. data/lib/puppet/pal/pal_impl.rb +523 -0
  32. data/lib/puppet/pal/plan_signature.rb +71 -0
  33. data/lib/puppet/pal/script_compiler.rb +71 -0
  34. data/lib/puppet/pal/task_signature.rb +58 -0
  35. data/lib/puppet/parser/functions/generate.rb +7 -6
  36. data/lib/puppet/plugins/configuration.rb +5 -1
  37. data/lib/puppet/pops/evaluator/evaluator_impl.rb +5 -1
  38. data/lib/puppet/pops/evaluator/external_syntax_support.rb +3 -3
  39. data/lib/puppet/pops/issues.rb +0 -4
  40. data/lib/puppet/pops/loader/ruby_legacy_function_instantiator.rb +4 -60
  41. data/lib/puppet/pops/model/factory.rb +4 -38
  42. data/lib/puppet/pops/model/pn_transformer.rb +0 -5
  43. data/lib/puppet/pops/parser/egrammar.ra +2 -2
  44. data/lib/puppet/pops/parser/heredoc_support.rb +7 -17
  45. data/lib/puppet/pops/parser/lexer2.rb +1 -6
  46. data/lib/puppet/pops/parser/locator.rb +86 -106
  47. data/lib/puppet/pops/parser/parser_support.rb +2 -11
  48. data/lib/puppet/pops/types/string_converter.rb +7 -2
  49. data/lib/puppet/pops/types/type_mismatch_describer.rb +1 -1
  50. data/lib/puppet/pops/types/types.rb +3 -5
  51. data/lib/puppet/pops/validation/checker4_0.rb +13 -0
  52. data/lib/puppet/provider.rb +2 -1
  53. data/lib/puppet/provider/exec.rb +6 -1
  54. data/lib/puppet/provider/file/windows.rb +1 -49
  55. data/lib/puppet/provider/group/windows_adsi.rb +1 -4
  56. data/lib/puppet/provider/package.rb +0 -2
  57. data/lib/puppet/provider/package/dpkg.rb +2 -15
  58. data/lib/puppet/provider/package/gem.rb +42 -102
  59. data/lib/puppet/provider/package/pip.rb +111 -135
  60. data/lib/puppet/provider/package/pip3.rb +1 -1
  61. data/lib/puppet/provider/package/pkgng.rb +37 -21
  62. data/lib/puppet/provider/package/puppet_gem.rb +1 -1
  63. data/lib/puppet/provider/package/rpm.rb +16 -27
  64. data/lib/puppet/provider/package/windows.rb +1 -5
  65. data/lib/puppet/provider/package/yum.rb +1 -2
  66. data/lib/puppet/provider/service/systemd.rb +17 -0
  67. data/lib/puppet/provider/service/upstart.rb +5 -17
  68. data/lib/puppet/provider/service/windows.rb +8 -3
  69. data/lib/puppet/provider/user/directoryservice.rb +4 -16
  70. data/lib/puppet/provider/user/useradd.rb +13 -16
  71. data/lib/puppet/resource.rb +3 -1
  72. data/lib/puppet/rest/client.rb +83 -0
  73. data/lib/puppet/rest/route.rb +1 -1
  74. data/lib/puppet/settings.rb +5 -10
  75. data/lib/puppet/settings/server_list_setting.rb +0 -9
  76. data/lib/puppet/ssl/host.rb +11 -0
  77. data/lib/puppet/ssl/validator/default_validator.rb +0 -31
  78. data/lib/puppet/syntax_checkers/epp.rb +34 -0
  79. data/lib/puppet/syntax_checkers/pp.rb +34 -0
  80. data/lib/puppet/transaction.rb +7 -12
  81. data/lib/puppet/transaction/event_manager.rb +5 -1
  82. data/lib/puppet/transaction/resource_harness.rb +0 -1
  83. data/lib/puppet/type.rb +6 -0
  84. data/lib/puppet/type/exec.rb +5 -27
  85. data/lib/puppet/type/file/mode.rb +1 -6
  86. data/lib/puppet/type/file/source.rb +1 -0
  87. data/lib/puppet/type/filebucket.rb +8 -12
  88. data/lib/puppet/type/package.rb +11 -44
  89. data/lib/puppet/type/schedule.rb +0 -4
  90. data/lib/puppet/type/service.rb +12 -0
  91. data/lib/puppet/type/user.rb +1 -1
  92. data/lib/puppet/util/command_line.rb +1 -5
  93. data/lib/puppet/util/connection.rb +6 -15
  94. data/lib/puppet/util/http_proxy.rb +2 -3
  95. data/lib/puppet/util/log.rb +2 -7
  96. data/lib/puppet/util/pidlock.rb +1 -15
  97. data/lib/puppet/util/windows/process.rb +5 -73
  98. data/lib/puppet/util/windows/registry.rb +1 -7
  99. data/lib/puppet/util/windows/security.rb +8 -29
  100. data/lib/puppet/util/windows/service.rb +33 -27
  101. data/lib/puppet/util/windows/user.rb +4 -14
  102. data/lib/puppet/version.rb +1 -1
  103. data/lib/puppet_pal.rb +5 -1132
  104. data/locales/ja/puppet.po +297 -363
  105. data/locales/puppet.pot +445 -517
  106. data/man/man5/puppet.conf.5 +12 -20
  107. data/man/man8/puppet-agent.8 +1 -1
  108. data/man/man8/puppet-apply.8 +1 -1
  109. data/man/man8/puppet-catalog.8 +1 -1
  110. data/man/man8/puppet-config.8 +1 -1
  111. data/man/man8/puppet-describe.8 +1 -1
  112. data/man/man8/puppet-device.8 +1 -1
  113. data/man/man8/puppet-doc.8 +1 -1
  114. data/man/man8/puppet-epp.8 +1 -1
  115. data/man/man8/puppet-facts.8 +1 -1
  116. data/man/man8/puppet-filebucket.8 +2 -6
  117. data/man/man8/puppet-generate.8 +1 -1
  118. data/man/man8/puppet-help.8 +1 -1
  119. data/man/man8/puppet-key.8 +1 -1
  120. data/man/man8/puppet-lookup.8 +1 -1
  121. data/man/man8/puppet-man.8 +1 -1
  122. data/man/man8/puppet-module.8 +1 -1
  123. data/man/man8/puppet-node.8 +1 -1
  124. data/man/man8/puppet-parser.8 +1 -1
  125. data/man/man8/puppet-plugin.8 +1 -1
  126. data/man/man8/puppet-report.8 +1 -1
  127. data/man/man8/puppet-resource.8 +1 -1
  128. data/man/man8/puppet-script.8 +1 -1
  129. data/man/man8/puppet-ssl.8 +1 -1
  130. data/man/man8/puppet-status.8 +1 -1
  131. data/man/man8/puppet.8 +2 -2
  132. data/spec/fixtures/unit/provider/package/pkgng/pkg.query +7 -1
  133. data/spec/fixtures/unit/provider/package/pkgng/pkg.query.zsh +1 -0
  134. data/spec/integration/agent/logging_spec.rb +7 -5
  135. data/spec/integration/application/apply_spec.rb +16 -18
  136. data/spec/integration/application/doc_spec.rb +2 -1
  137. data/spec/integration/application/lookup_spec.rb +5 -5
  138. data/spec/integration/configurer_spec.rb +6 -5
  139. data/spec/integration/defaults_spec.rb +6 -5
  140. data/spec/integration/directory_environments_spec.rb +1 -1
  141. data/spec/integration/faces/config_spec.rb +4 -3
  142. data/spec/integration/faces/documentation_spec.rb +1 -0
  143. data/spec/integration/faces/plugin_spec.rb +1 -1
  144. data/spec/integration/file_bucket/file_spec.rb +4 -2
  145. data/spec/integration/file_serving/content_spec.rb +1 -0
  146. data/spec/integration/file_serving/fileset_spec.rb +1 -0
  147. data/spec/integration/file_serving/metadata_spec.rb +1 -0
  148. data/spec/integration/file_serving/terminus_helper_spec.rb +1 -0
  149. data/spec/integration/indirector/catalog/compiler_spec.rb +11 -10
  150. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  151. data/spec/integration/indirector/facts/facter_spec.rb +5 -4
  152. data/spec/integration/indirector/file_content/file_server_spec.rb +8 -7
  153. data/spec/integration/indirector/file_metadata/file_server_spec.rb +8 -7
  154. data/spec/integration/network/authconfig_spec.rb +24 -23
  155. data/spec/integration/network/formats_spec.rb +1 -0
  156. data/spec/integration/node/environment_spec.rb +1 -0
  157. data/spec/integration/node/facts_spec.rb +10 -9
  158. data/spec/integration/node_spec.rb +7 -6
  159. data/spec/integration/parser/catalog_spec.rb +5 -1
  160. data/spec/integration/parser/collection_spec.rb +2 -1
  161. data/spec/integration/parser/compiler_spec.rb +6 -6
  162. data/spec/integration/parser/scope_spec.rb +1 -1
  163. data/spec/integration/parser/undef_param_spec.rb +1 -1
  164. data/spec/integration/provider/service/init_spec.rb +5 -4
  165. data/spec/integration/provider/service/systemd_spec.rb +2 -0
  166. data/spec/integration/provider/service/windows_spec.rb +2 -1
  167. data/spec/integration/reference/providers_spec.rb +2 -1
  168. data/spec/integration/reports_spec.rb +2 -1
  169. data/spec/integration/resource/catalog_spec.rb +17 -14
  170. data/spec/integration/resource/type_collection_spec.rb +5 -4
  171. data/spec/integration/ssl/certificate_request_spec.rb +1 -0
  172. data/spec/integration/ssl/host_spec.rb +2 -1
  173. data/spec/integration/ssl/key_spec.rb +1 -0
  174. data/spec/integration/test/test_helper_spec.rb +1 -0
  175. data/spec/integration/transaction/report_spec.rb +11 -6
  176. data/spec/integration/transaction_spec.rb +19 -18
  177. data/spec/integration/type/exec_spec.rb +1 -0
  178. data/spec/integration/type/file_spec.rb +33 -13
  179. data/spec/integration/type/package_spec.rb +24 -20
  180. data/spec/integration/type/tidy_spec.rb +2 -1
  181. data/spec/integration/type_spec.rb +1 -0
  182. data/spec/integration/util/autoload_spec.rb +2 -1
  183. data/spec/integration/util/rdoc/parser_spec.rb +1 -0
  184. data/spec/integration/util/settings_spec.rb +1 -0
  185. data/spec/integration/util/windows/adsi_spec.rb +5 -3
  186. data/spec/integration/util/windows/principal_spec.rb +1 -0
  187. data/spec/integration/util/windows/process_spec.rb +6 -4
  188. data/spec/integration/util/windows/registry_spec.rb +51 -93
  189. data/spec/integration/util/windows/security_spec.rb +4 -2
  190. data/spec/integration/util/windows/user_spec.rb +20 -37
  191. data/spec/integration/util_spec.rb +7 -4
  192. data/spec/lib/puppet_spec/compiler.rb +1 -1
  193. data/spec/lib/puppet_spec/files.rb +1 -0
  194. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  195. data/spec/lib/puppet_spec/scope.rb +2 -1
  196. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  197. data/spec/shared_behaviours/file_server_terminus.rb +9 -8
  198. data/spec/shared_behaviours/file_serving.rb +8 -6
  199. data/spec/shared_behaviours/file_serving_model.rb +5 -3
  200. data/spec/shared_behaviours/hiera_indirections.rb +4 -3
  201. data/spec/shared_behaviours/iterative_functions.rb +1 -0
  202. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  203. data/spec/shared_examples/rhel_package_provider.rb +70 -112
  204. data/spec/spec_helper.rb +2 -11
  205. data/spec/unit/agent/disabler_spec.rb +5 -4
  206. data/spec/unit/agent/locker_spec.rb +13 -12
  207. data/spec/unit/agent_spec.rb +85 -80
  208. data/spec/unit/application/agent_spec.rb +93 -88
  209. data/spec/unit/application/apply_spec.rb +83 -82
  210. data/spec/unit/application/config_spec.rb +1 -0
  211. data/spec/unit/application/describe_spec.rb +7 -6
  212. data/spec/unit/application/device_spec.rb +419 -395
  213. data/spec/unit/application/doc_spec.rb +46 -44
  214. data/spec/unit/application/face_base_spec.rb +62 -61
  215. data/spec/unit/application/facts_spec.rb +4 -3
  216. data/spec/unit/application/filebucket_spec.rb +74 -66
  217. data/spec/unit/application/indirection_base_spec.rb +6 -8
  218. data/spec/unit/application/lookup_spec.rb +26 -26
  219. data/spec/unit/application/resource_spec.rb +48 -42
  220. data/spec/unit/application/ssl_spec.rb +3 -8
  221. data/spec/unit/application_spec.rb +98 -86
  222. data/spec/unit/capability_spec.rb +6 -6
  223. data/spec/unit/certificate_factory_spec.rb +5 -3
  224. data/spec/unit/configurer/downloader_spec.rb +21 -20
  225. data/spec/unit/configurer/fact_handler_spec.rb +3 -2
  226. data/spec/unit/configurer/plugin_handler_spec.rb +8 -41
  227. data/spec/unit/configurer_spec.rb +198 -194
  228. data/spec/unit/confine/exists_spec.rb +15 -17
  229. data/spec/unit/confine/false_spec.rb +6 -32
  230. data/spec/unit/confine/feature_spec.rb +5 -7
  231. data/spec/unit/confine/true_spec.rb +6 -32
  232. data/spec/unit/confine/variable_spec.rb +15 -14
  233. data/spec/unit/confine_collection_spec.rb +29 -28
  234. data/spec/unit/confine_spec.rb +14 -13
  235. data/spec/unit/confiner_spec.rb +11 -10
  236. data/spec/unit/context/trusted_information_spec.rb +1 -1
  237. data/spec/unit/daemon_spec.rb +36 -35
  238. data/spec/unit/data_providers/function_data_provider_spec.rb +1 -0
  239. data/spec/unit/data_providers/hiera_data_provider_spec.rb +1 -0
  240. data/spec/unit/datatypes_spec.rb +4 -3
  241. data/spec/unit/defaults_spec.rb +27 -18
  242. data/spec/unit/environments_spec.rb +7 -7
  243. data/spec/unit/etc_spec.rb +32 -30
  244. data/spec/unit/external/pson_spec.rb +1 -0
  245. data/spec/unit/face/catalog_spec.rb +1 -0
  246. data/spec/unit/face/config_spec.rb +35 -31
  247. data/spec/unit/face/epp_face_spec.rb +4 -3
  248. data/spec/unit/face/facts_spec.rb +6 -5
  249. data/spec/unit/face/generate_spec.rb +5 -4
  250. data/spec/unit/face/help_spec.rb +8 -7
  251. data/spec/unit/face/key_spec.rb +1 -0
  252. data/spec/unit/face/man_spec.rb +2 -1
  253. data/spec/unit/face/module/install_spec.rb +5 -3
  254. data/spec/unit/face/module/list_spec.rb +12 -2
  255. data/spec/unit/face/module/search_spec.rb +9 -11
  256. data/spec/unit/face/module/uninstall_spec.rb +8 -4
  257. data/spec/unit/face/node_spec.rb +24 -23
  258. data/spec/unit/face/parser_spec.rb +18 -3
  259. data/spec/unit/face/plugin_spec.rb +9 -36
  260. data/spec/unit/face/status_spec.rb +1 -0
  261. data/spec/unit/file_bucket/dipper_spec.rb +20 -24
  262. data/spec/unit/file_bucket/file_spec.rb +2 -0
  263. data/spec/unit/file_serving/base_spec.rb +15 -14
  264. data/spec/unit/file_serving/configuration/parser_spec.rb +28 -27
  265. data/spec/unit/file_serving/configuration_spec.rb +66 -63
  266. data/spec/unit/file_serving/content_spec.rb +11 -10
  267. data/spec/unit/file_serving/fileset_spec.rb +58 -63
  268. data/spec/unit/file_serving/http_metadata_spec.rb +7 -8
  269. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  270. data/spec/unit/file_serving/mount/file_spec.rb +32 -31
  271. data/spec/unit/file_serving/mount/locales_spec.rb +24 -23
  272. data/spec/unit/file_serving/mount/modules_spec.rb +15 -14
  273. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +24 -23
  274. data/spec/unit/file_serving/mount/plugins_spec.rb +24 -23
  275. data/spec/unit/file_serving/mount/tasks_spec.rb +15 -14
  276. data/spec/unit/file_serving/mount_spec.rb +1 -0
  277. data/spec/unit/file_serving/terminus_helper_spec.rb +42 -37
  278. data/spec/unit/file_serving/terminus_selector_spec.rb +13 -12
  279. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  280. data/spec/unit/file_system_spec.rb +2 -2
  281. data/spec/unit/forge/errors_spec.rb +1 -1
  282. data/spec/unit/forge/forge_spec.rb +16 -17
  283. data/spec/unit/forge/module_release_spec.rb +18 -18
  284. data/spec/unit/forge/repository_spec.rb +30 -29
  285. data/spec/unit/forge_spec.rb +11 -15
  286. data/spec/unit/functions/binary_file_spec.rb +3 -3
  287. data/spec/unit/functions/contain_spec.rb +2 -0
  288. data/spec/unit/functions/defined_spec.rb +1 -0
  289. data/spec/unit/functions/epp_spec.rb +2 -2
  290. data/spec/unit/functions/find_file_spec.rb +7 -7
  291. data/spec/unit/functions/include_spec.rb +4 -0
  292. data/spec/unit/functions/lookup_fixture_spec.rb +1 -0
  293. data/spec/unit/functions/lookup_spec.rb +2 -1
  294. data/spec/unit/functions/module_directory_spec.rb +12 -12
  295. data/spec/unit/functions/new_spec.rb +0 -15
  296. data/spec/unit/functions/require_spec.rb +3 -0
  297. data/spec/unit/functions/shared.rb +8 -5
  298. data/spec/unit/functions/versioncmp_spec.rb +2 -1
  299. data/spec/unit/functions4_spec.rb +10 -9
  300. data/spec/unit/gettext/config_spec.rb +4 -4
  301. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  302. data/spec/unit/graph/rb_tree_map_spec.rb +2 -0
  303. data/spec/unit/graph/relationship_graph_spec.rb +2 -1
  304. data/spec/unit/graph/simple_graph_spec.rb +10 -9
  305. data/spec/unit/hiera/scope_spec.rb +0 -7
  306. data/spec/unit/hiera_puppet_spec.rb +20 -20
  307. data/spec/unit/indirector/catalog/compiler_spec.rb +149 -147
  308. data/spec/unit/indirector/catalog/json_spec.rb +2 -1
  309. data/spec/unit/indirector/catalog/msgpack_spec.rb +1 -0
  310. data/spec/unit/indirector/catalog/rest_spec.rb +1 -0
  311. data/spec/unit/indirector/catalog/store_configs_spec.rb +1 -0
  312. data/spec/unit/indirector/catalog/yaml_spec.rb +1 -0
  313. data/spec/unit/indirector/certificate/file_spec.rb +1 -0
  314. data/spec/unit/indirector/certificate/rest_spec.rb +10 -8
  315. data/spec/unit/indirector/certificate_request/file_spec.rb +1 -0
  316. data/spec/unit/indirector/certificate_request/rest_spec.rb +1 -0
  317. data/spec/unit/indirector/direct_file_server_spec.rb +18 -17
  318. data/spec/unit/indirector/envelope_spec.rb +2 -1
  319. data/spec/unit/indirector/exec_spec.rb +5 -4
  320. data/spec/unit/indirector/face_spec.rb +9 -9
  321. data/spec/unit/indirector/facts/facter_spec.rb +43 -37
  322. data/spec/unit/indirector/facts/network_device_spec.rb +9 -8
  323. data/spec/unit/indirector/facts/rest_spec.rb +8 -7
  324. data/spec/unit/indirector/facts/store_configs_spec.rb +1 -0
  325. data/spec/unit/indirector/facts/yaml_spec.rb +1 -0
  326. data/spec/unit/indirector/file_bucket_file/file_spec.rb +4 -3
  327. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +1 -0
  328. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +5 -4
  329. data/spec/unit/indirector/file_content/file_server_spec.rb +1 -0
  330. data/spec/unit/indirector/file_content/file_spec.rb +1 -0
  331. data/spec/unit/indirector/file_content/rest_spec.rb +1 -0
  332. data/spec/unit/indirector/file_content/selector_spec.rb +1 -0
  333. data/spec/unit/indirector/file_metadata/file_server_spec.rb +1 -0
  334. data/spec/unit/indirector/file_metadata/file_spec.rb +13 -12
  335. data/spec/unit/indirector/file_metadata/rest_spec.rb +1 -0
  336. data/spec/unit/indirector/file_metadata/selector_spec.rb +1 -0
  337. data/spec/unit/indirector/file_server_spec.rb +87 -87
  338. data/spec/unit/indirector/indirection_spec.rb +226 -242
  339. data/spec/unit/indirector/json_spec.rb +9 -7
  340. data/spec/unit/indirector/key/file_spec.rb +22 -21
  341. data/spec/unit/indirector/memory_spec.rb +7 -6
  342. data/spec/unit/indirector/msgpack_spec.rb +9 -7
  343. data/spec/unit/indirector/node/exec_spec.rb +3 -2
  344. data/spec/unit/indirector/node/memory_spec.rb +4 -2
  345. data/spec/unit/indirector/node/msgpack_spec.rb +1 -0
  346. data/spec/unit/indirector/node/plain_spec.rb +4 -2
  347. data/spec/unit/indirector/node/rest_spec.rb +1 -0
  348. data/spec/unit/indirector/node/store_configs_spec.rb +1 -0
  349. data/spec/unit/indirector/node/yaml_spec.rb +1 -0
  350. data/spec/unit/indirector/none_spec.rb +5 -5
  351. data/spec/unit/indirector/plain_spec.rb +8 -7
  352. data/spec/unit/indirector/report/msgpack_spec.rb +1 -0
  353. data/spec/unit/indirector/report/processor_spec.rb +22 -21
  354. data/spec/unit/indirector/report/rest_spec.rb +12 -11
  355. data/spec/unit/indirector/report/yaml_spec.rb +1 -0
  356. data/spec/unit/indirector/request_spec.rb +12 -11
  357. data/spec/unit/indirector/resource/ral_spec.rb +54 -47
  358. data/spec/unit/indirector/resource/store_configs_spec.rb +1 -0
  359. data/spec/unit/indirector/rest_spec.rb +110 -113
  360. data/spec/unit/indirector/ssl_file_spec.rb +65 -64
  361. data/spec/unit/indirector/status/local_spec.rb +1 -0
  362. data/spec/unit/indirector/status/rest_spec.rb +1 -0
  363. data/spec/unit/indirector/store_configs_spec.rb +1 -0
  364. data/spec/unit/indirector/terminus_spec.rb +27 -27
  365. data/spec/unit/indirector/yaml_spec.rb +6 -5
  366. data/spec/unit/indirector_spec.rb +2 -1
  367. data/spec/unit/info_service_spec.rb +1 -1
  368. data/spec/unit/interface/action_builder_spec.rb +1 -0
  369. data/spec/unit/interface/action_manager_spec.rb +1 -0
  370. data/spec/unit/interface/action_spec.rb +3 -2
  371. data/spec/unit/interface/documentation_spec.rb +1 -0
  372. data/spec/unit/interface/face_collection_spec.rb +12 -19
  373. data/spec/unit/interface_spec.rb +3 -3
  374. data/spec/unit/man_spec.rb +4 -3
  375. data/spec/unit/module_spec.rb +51 -46
  376. data/spec/unit/module_tool/applications/installer_spec.rb +11 -10
  377. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  378. data/spec/unit/module_tool/applications/uninstaller_spec.rb +2 -1
  379. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  380. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  381. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  382. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  383. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  384. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  385. data/spec/unit/module_tool/tar_spec.rb +13 -12
  386. data/spec/unit/module_tool_spec.rb +12 -7
  387. data/spec/unit/network/auth_config_parser_spec.rb +13 -11
  388. data/spec/unit/network/authconfig_spec.rb +18 -17
  389. data/spec/unit/network/authorization_spec.rb +5 -4
  390. data/spec/unit/network/authstore_spec.rb +1 -0
  391. data/spec/unit/network/format_handler_spec.rb +1 -0
  392. data/spec/unit/network/format_spec.rb +10 -9
  393. data/spec/unit/network/format_support_spec.rb +29 -28
  394. data/spec/unit/network/formats_spec.rb +5 -4
  395. data/spec/unit/network/http/api/indirected_routes_spec.rb +29 -24
  396. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  397. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  398. data/spec/unit/network/http/api/master/v3/environments_spec.rb +7 -6
  399. data/spec/unit/network/http/api_spec.rb +2 -0
  400. data/spec/unit/network/http/compression_spec.rb +22 -21
  401. data/spec/unit/network/http/connection_spec.rb +121 -30
  402. data/spec/unit/network/http/factory_spec.rb +6 -11
  403. data/spec/unit/network/http/handler_spec.rb +18 -9
  404. data/spec/unit/network/http/nocache_pool_spec.rb +7 -6
  405. data/spec/unit/network/http/pool_spec.rb +29 -28
  406. data/spec/unit/network/http/request_spec.rb +2 -0
  407. data/spec/unit/network/http/response_spec.rb +13 -11
  408. data/spec/unit/network/http/route_spec.rb +1 -0
  409. data/spec/unit/network/http/session_spec.rb +2 -1
  410. data/spec/unit/network/http/site_spec.rb +1 -0
  411. data/spec/unit/network/http_pool_spec.rb +9 -18
  412. data/spec/unit/network/http_spec.rb +1 -0
  413. data/spec/unit/network/resolver_spec.rb +26 -25
  414. data/spec/unit/network/rights_spec.rb +53 -52
  415. data/spec/unit/node/environment_spec.rb +15 -14
  416. data/spec/unit/node/facts_spec.rb +7 -5
  417. data/spec/unit/node_spec.rb +10 -4
  418. data/spec/unit/other/selinux_spec.rb +1 -0
  419. data/spec/unit/parameter/boolean_spec.rb +2 -1
  420. data/spec/unit/parameter/package_options_spec.rb +2 -1
  421. data/spec/unit/parameter/path_spec.rb +1 -0
  422. data/spec/unit/parameter/value_collection_spec.rb +1 -0
  423. data/spec/unit/parameter/value_spec.rb +1 -0
  424. data/spec/unit/parameter_spec.rb +9 -9
  425. data/spec/unit/parser/ast/block_expression_spec.rb +8 -6
  426. data/spec/unit/parser/ast/leaf_spec.rb +21 -20
  427. data/spec/unit/parser/compiler_spec.rb +96 -84
  428. data/spec/unit/parser/environment_compiler_spec.rb +8 -7
  429. data/spec/unit/parser/files_spec.rb +1 -0
  430. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  431. data/spec/unit/parser/functions/digest_spec.rb +1 -0
  432. data/spec/unit/parser/functions/fail_spec.rb +2 -1
  433. data/spec/unit/parser/functions/file_spec.rb +14 -13
  434. data/spec/unit/parser/functions/fqdn_rand_spec.rb +6 -5
  435. data/spec/unit/parser/functions/generate_spec.rb +8 -7
  436. data/spec/unit/parser/functions/inline_template_spec.rb +1 -0
  437. data/spec/unit/parser/functions/regsubst_spec.rb +1 -0
  438. data/spec/unit/parser/functions/scanf_spec.rb +1 -0
  439. data/spec/unit/parser/functions/shellquote_spec.rb +1 -0
  440. data/spec/unit/parser/functions/split_spec.rb +1 -0
  441. data/spec/unit/parser/functions/sprintf_spec.rb +1 -0
  442. data/spec/unit/parser/functions/tag_spec.rb +2 -1
  443. data/spec/unit/parser/functions/tagged_spec.rb +3 -2
  444. data/spec/unit/parser/functions/template_spec.rb +13 -13
  445. data/spec/unit/parser/functions/versioncmp_spec.rb +2 -1
  446. data/spec/unit/parser/functions_spec.rb +7 -6
  447. data/spec/unit/parser/relationship_spec.rb +1 -0
  448. data/spec/unit/parser/resource_spec.rb +42 -42
  449. data/spec/unit/parser/scope_spec.rb +35 -39
  450. data/spec/unit/parser/templatewrapper_spec.rb +12 -11
  451. data/spec/unit/parser/type_loader_spec.rb +19 -17
  452. data/spec/unit/pops/adaptable_spec.rb +1 -0
  453. data/spec/unit/pops/benchmark_spec.rb +1 -0
  454. data/spec/unit/pops/evaluator/access_ops_spec.rb +1 -0
  455. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +1 -0
  456. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +1 -0
  457. data/spec/unit/pops/evaluator/collections_ops_spec.rb +1 -0
  458. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +1 -0
  459. data/spec/unit/pops/evaluator/conditionals_spec.rb +1 -0
  460. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +47 -10
  461. data/spec/unit/pops/evaluator/logical_ops_spec.rb +1 -0
  462. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +1 -0
  463. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +1 -0
  464. data/spec/unit/pops/evaluator/variables_spec.rb +1 -0
  465. data/spec/unit/pops/factory_spec.rb +4 -3
  466. data/spec/unit/pops/issues_spec.rb +20 -19
  467. data/spec/unit/pops/loaders/loader_spec.rb +4 -8
  468. data/spec/unit/pops/loaders/loaders_spec.rb +31 -101
  469. data/spec/unit/pops/lookup/context_spec.rb +1 -0
  470. data/spec/unit/pops/lookup/interpolation_spec.rb +3 -2
  471. data/spec/unit/pops/merge_strategy_spec.rb +1 -0
  472. data/spec/unit/pops/migration_spec.rb +5 -3
  473. data/spec/unit/pops/model/model_spec.rb +1 -0
  474. data/spec/unit/pops/model/pn_transformer_spec.rb +1 -4
  475. data/spec/unit/pops/parser/locator_spec.rb +6 -48
  476. data/spec/unit/pops/parser/parse_application_spec.rb +1 -0
  477. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +1 -0
  478. data/spec/unit/pops/parser/parse_calls_spec.rb +1 -0
  479. data/spec/unit/pops/parser/parse_capabilities_spec.rb +1 -0
  480. data/spec/unit/pops/parser/parse_conditionals_spec.rb +1 -0
  481. data/spec/unit/pops/parser/parse_containers_spec.rb +1 -0
  482. data/spec/unit/pops/parser/parse_heredoc_spec.rb +15 -111
  483. data/spec/unit/pops/parser/parse_plan_spec.rb +1 -0
  484. data/spec/unit/pops/parser/parse_resource_spec.rb +1 -0
  485. data/spec/unit/pops/parser/parse_site_spec.rb +1 -0
  486. data/spec/unit/pops/parser/pn_parser_spec.rb +1 -0
  487. data/spec/unit/pops/pn_spec.rb +1 -0
  488. data/spec/unit/pops/resource/resource_type_impl_spec.rb +1 -0
  489. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  490. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  491. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  492. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  493. data/spec/unit/pops/types/string_converter_spec.rb +5 -1
  494. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  495. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  496. data/spec/unit/pops/types/type_mismatch_describer_spec.rb +0 -9
  497. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  498. data/spec/unit/pops/validator/validator_spec.rb +2 -1
  499. data/spec/unit/pops/visitor_spec.rb +1 -0
  500. data/spec/unit/property/boolean_spec.rb +1 -1
  501. data/spec/unit/property/ensure_spec.rb +1 -0
  502. data/spec/unit/property/keyvalue_spec.rb +34 -32
  503. data/spec/unit/property/list_spec.rb +27 -26
  504. data/spec/unit/property/ordered_list_spec.rb +14 -10
  505. data/spec/unit/property_spec.rb +43 -42
  506. data/spec/unit/provider/aix_object_spec.rb +45 -47
  507. data/spec/unit/provider/command_spec.rb +9 -9
  508. data/spec/unit/provider/exec/posix_spec.rb +31 -6
  509. data/spec/unit/provider/exec/shell_spec.rb +1 -0
  510. data/spec/unit/provider/exec/windows_spec.rb +4 -2
  511. data/spec/unit/provider/exec_spec.rb +1 -0
  512. data/spec/unit/provider/file/posix_spec.rb +24 -22
  513. data/spec/unit/provider/file/windows_spec.rb +17 -15
  514. data/spec/unit/provider/group/aix_spec.rb +2 -3
  515. data/spec/unit/provider/group/groupadd_spec.rb +26 -30
  516. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  517. data/spec/unit/provider/group/pw_spec.rb +11 -11
  518. data/spec/unit/provider/group/windows_adsi_spec.rb +53 -59
  519. data/spec/unit/provider/ldap_spec.rb +62 -61
  520. data/spec/unit/provider/nameservice/directoryservice_spec.rb +36 -35
  521. data/spec/unit/provider/nameservice_spec.rb +40 -38
  522. data/spec/unit/provider/package/aix_spec.rb +15 -15
  523. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  524. data/spec/unit/provider/package/apt_spec.rb +27 -44
  525. data/spec/unit/provider/package/aptitude_spec.rb +7 -6
  526. data/spec/unit/provider/package/aptrpm_spec.rb +12 -7
  527. data/spec/unit/provider/package/base_spec.rb +4 -4
  528. data/spec/unit/provider/package/dnf_spec.rb +20 -18
  529. data/spec/unit/provider/package/dpkg_spec.rb +53 -70
  530. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  531. data/spec/unit/provider/package/gem_spec.rb +55 -132
  532. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  533. data/spec/unit/provider/package/macports_spec.rb +42 -46
  534. data/spec/unit/provider/package/nim_spec.rb +39 -30
  535. data/spec/unit/provider/package/openbsd_spec.rb +39 -36
  536. data/spec/unit/provider/package/opkg_spec.rb +26 -23
  537. data/spec/unit/provider/package/pacman_spec.rb +118 -97
  538. data/spec/unit/provider/package/pip3_spec.rb +0 -17
  539. data/spec/unit/provider/package/pip_spec.rb +106 -95
  540. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  541. data/spec/unit/provider/package/pkgdmg_spec.rb +63 -65
  542. data/spec/unit/provider/package/pkgin_spec.rb +8 -10
  543. data/spec/unit/provider/package/pkgng_spec.rb +31 -22
  544. data/spec/unit/provider/package/pkgutil_spec.rb +49 -45
  545. data/spec/unit/provider/package/portage_spec.rb +74 -70
  546. data/spec/unit/provider/package/puppet_gem_spec.rb +13 -37
  547. data/spec/unit/provider/package/rpm_spec.rb +76 -154
  548. data/spec/unit/provider/package/sun_spec.rb +18 -16
  549. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  550. data/spec/unit/provider/package/up2date_spec.rb +4 -2
  551. data/spec/unit/provider/package/urpmi_spec.rb +17 -15
  552. data/spec/unit/provider/package/windows/exe_package_spec.rb +15 -12
  553. data/spec/unit/provider/package/windows/msi_package_spec.rb +22 -19
  554. data/spec/unit/provider/package/windows/package_spec.rb +42 -37
  555. data/spec/unit/provider/package/windows_spec.rb +32 -47
  556. data/spec/unit/provider/package/yum_spec.rb +7 -7
  557. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  558. data/spec/unit/provider/parsedfile_spec.rb +45 -44
  559. data/spec/unit/provider/service/base_spec.rb +5 -4
  560. data/spec/unit/provider/service/bsd_spec.rb +29 -27
  561. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  562. data/spec/unit/provider/service/debian_spec.rb +38 -38
  563. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  564. data/spec/unit/provider/service/gentoo_spec.rb +55 -50
  565. data/spec/unit/provider/service/init_spec.rb +52 -53
  566. data/spec/unit/provider/service/launchd_spec.rb +116 -138
  567. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  568. data/spec/unit/provider/service/openrc_spec.rb +45 -43
  569. data/spec/unit/provider/service/openwrt_spec.rb +31 -26
  570. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  571. data/spec/unit/provider/service/redhat_spec.rb +43 -45
  572. data/spec/unit/provider/service/runit_spec.rb +27 -29
  573. data/spec/unit/provider/service/smf_spec.rb +66 -74
  574. data/spec/unit/provider/service/src_spec.rb +47 -46
  575. data/spec/unit/provider/service/systemd_spec.rb +136 -109
  576. data/spec/unit/provider/service/upstart_spec.rb +93 -77
  577. data/spec/unit/provider/service/windows_spec.rb +41 -33
  578. data/spec/unit/provider/user/aix_spec.rb +31 -31
  579. data/spec/unit/provider/user/directoryservice_spec.rb +114 -146
  580. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  581. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  582. data/spec/unit/provider/user/openbsd_spec.rb +12 -10
  583. data/spec/unit/provider/user/pw_spec.rb +35 -37
  584. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  585. data/spec/unit/provider/user/useradd_spec.rb +92 -93
  586. data/spec/unit/provider/user/windows_adsi_spec.rb +60 -59
  587. data/spec/unit/provider_spec.rb +35 -35
  588. data/spec/unit/puppet_pal_2pec.rb +5 -4
  589. data/spec/unit/puppet_pal_spec.rb +1 -0
  590. data/spec/unit/puppet_spec.rb +7 -6
  591. data/spec/unit/relationship_spec.rb +1 -0
  592. data/spec/unit/reports/http_spec.rb +23 -21
  593. data/spec/unit/reports/store_spec.rb +4 -3
  594. data/spec/unit/reports_spec.rb +14 -12
  595. data/spec/unit/resource/capability_finder_spec.rb +17 -15
  596. data/spec/unit/resource/catalog_spec.rb +68 -72
  597. data/spec/unit/resource/status_spec.rb +8 -6
  598. data/spec/unit/resource/type_collection_spec.rb +18 -17
  599. data/spec/unit/resource/type_spec.rb +35 -34
  600. data/spec/unit/resource_spec.rb +63 -36
  601. data/spec/unit/rest/client_spec.rb +135 -0
  602. data/spec/unit/rest/route_spec.rb +6 -6
  603. data/spec/unit/scheduler/job_spec.rb +1 -0
  604. data/spec/unit/scheduler/scheduler_spec.rb +1 -0
  605. data/spec/unit/scheduler/splay_job_spec.rb +2 -1
  606. data/spec/unit/settings/array_setting_spec.rb +1 -1
  607. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  608. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  609. data/spec/unit/settings/config_file_spec.rb +1 -0
  610. data/spec/unit/settings/directory_setting_spec.rb +7 -2
  611. data/spec/unit/settings/duration_setting_spec.rb +2 -1
  612. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  613. data/spec/unit/settings/environment_conf_spec.rb +6 -4
  614. data/spec/unit/settings/file_setting_spec.rb +46 -44
  615. data/spec/unit/settings/path_setting_spec.rb +2 -1
  616. data/spec/unit/settings/priority_setting_spec.rb +2 -1
  617. data/spec/unit/settings/string_setting_spec.rb +15 -14
  618. data/spec/unit/settings/terminus_setting_spec.rb +2 -1
  619. data/spec/unit/settings/value_translator_spec.rb +1 -0
  620. data/spec/unit/settings_spec.rb +224 -253
  621. data/spec/unit/ssl/base_spec.rb +15 -14
  622. data/spec/unit/ssl/certificate_request_spec.rb +58 -62
  623. data/spec/unit/ssl/certificate_spec.rb +25 -23
  624. data/spec/unit/ssl/digest_spec.rb +1 -0
  625. data/spec/unit/ssl/host_spec.rb +149 -166
  626. data/spec/unit/ssl/key_spec.rb +31 -30
  627. data/spec/unit/ssl/validator_spec.rb +39 -40
  628. data/spec/unit/task_spec.rb +45 -44
  629. data/spec/unit/transaction/additional_resource_generator_spec.rb +5 -3
  630. data/spec/unit/transaction/event_manager_spec.rb +88 -87
  631. data/spec/unit/transaction/event_spec.rb +15 -16
  632. data/spec/unit/transaction/persistence_spec.rb +17 -16
  633. data/spec/unit/transaction/report_spec.rb +12 -11
  634. data/spec/unit/transaction/resource_harness_spec.rb +31 -52
  635. data/spec/unit/transaction_spec.rb +87 -140
  636. data/spec/unit/type/component_spec.rb +1 -0
  637. data/spec/unit/type/exec_spec.rb +50 -101
  638. data/spec/unit/type/file/checksum_spec.rb +10 -9
  639. data/spec/unit/type/file/checksum_value_spec.rb +32 -31
  640. data/spec/unit/type/file/content_spec.rb +61 -58
  641. data/spec/unit/type/file/ctime_spec.rb +1 -0
  642. data/spec/unit/type/file/ensure_spec.rb +13 -12
  643. data/spec/unit/type/file/group_spec.rb +7 -5
  644. data/spec/unit/type/file/mode_spec.rb +6 -4
  645. data/spec/unit/type/file/mtime_spec.rb +1 -0
  646. data/spec/unit/type/file/owner_spec.rb +8 -6
  647. data/spec/unit/type/file/selinux_spec.rb +19 -17
  648. data/spec/unit/type/file/source_spec.rb +101 -104
  649. data/spec/unit/type/file/type_spec.rb +1 -0
  650. data/spec/unit/type/file_spec.rb +185 -195
  651. data/spec/unit/type/filebucket_spec.rb +10 -11
  652. data/spec/unit/type/group_spec.rb +8 -6
  653. data/spec/unit/type/noop_metaparam_spec.rb +2 -1
  654. data/spec/unit/type/package/package_settings_spec.rb +23 -44
  655. data/spec/unit/type/package_spec.rb +57 -56
  656. data/spec/unit/type/resources_spec.rb +74 -72
  657. data/spec/unit/type/schedule_spec.rb +26 -24
  658. data/spec/unit/type/service_spec.rb +75 -49
  659. data/spec/unit/type/stage_spec.rb +1 -0
  660. data/spec/unit/type/tidy_spec.rb +62 -61
  661. data/spec/unit/type/user_spec.rb +25 -24
  662. data/spec/unit/type/whit_spec.rb +1 -0
  663. data/spec/unit/type_spec.rb +54 -55
  664. data/spec/unit/util/at_fork_spec.rb +19 -18
  665. data/spec/unit/util/autoload_spec.rb +56 -55
  666. data/spec/unit/util/backups_spec.rb +35 -34
  667. data/spec/unit/util/character_encoding_spec.rb +5 -5
  668. data/spec/unit/util/checksums_spec.rb +39 -38
  669. data/spec/unit/util/colors_spec.rb +2 -1
  670. data/spec/unit/util/command_line_spec.rb +20 -40
  671. data/spec/unit/util/constant_inflector_spec.rb +1 -0
  672. data/spec/unit/util/diff_spec.rb +8 -7
  673. data/spec/unit/util/errors_spec.rb +1 -0
  674. data/spec/unit/util/execution_spec.rb +163 -187
  675. data/spec/unit/util/execution_stub_spec.rb +1 -0
  676. data/spec/unit/util/feature_spec.rb +14 -21
  677. data/spec/unit/util/filetype_spec.rb +49 -49
  678. data/spec/unit/util/http_proxy_spec.rb +12 -12
  679. data/spec/unit/util/inifile_spec.rb +31 -26
  680. data/spec/unit/util/json_lockfile_spec.rb +5 -3
  681. data/spec/unit/util/ldap/connection_spec.rb +25 -26
  682. data/spec/unit/util/ldap/generator_spec.rb +1 -0
  683. data/spec/unit/util/ldap/manager_spec.rb +101 -102
  684. data/spec/unit/util/lockfile_spec.rb +1 -0
  685. data/spec/unit/util/log/destinations_spec.rb +33 -30
  686. data/spec/unit/util/log_spec.rb +34 -48
  687. data/spec/unit/util/logging_spec.rb +72 -58
  688. data/spec/unit/util/metric_spec.rb +1 -0
  689. data/spec/unit/util/monkey_patches_spec.rb +9 -7
  690. data/spec/unit/util/multi_match_spec.rb +1 -0
  691. data/spec/unit/util/network_device/config_spec.rb +1 -0
  692. data/spec/unit/util/network_device/transport/base_spec.rb +6 -5
  693. data/spec/unit/util/network_device_spec.rb +9 -7
  694. data/spec/unit/util/package_spec.rb +1 -0
  695. data/spec/unit/util/pidlock_spec.rb +15 -60
  696. data/spec/unit/util/plist_spec.rb +33 -40
  697. data/spec/unit/util/posix_spec.rb +51 -54
  698. data/spec/unit/util/rdoc_spec.rb +10 -9
  699. data/spec/unit/util/reference_spec.rb +1 -0
  700. data/spec/unit/util/resource_template_spec.rb +20 -20
  701. data/spec/unit/util/retry_action_spec.rb +8 -7
  702. data/spec/unit/util/rubygems_spec.rb +8 -7
  703. data/spec/unit/util/run_mode_spec.rb +4 -3
  704. data/spec/unit/util/selinux_spec.rb +72 -79
  705. data/spec/unit/util/splayer_spec.rb +9 -8
  706. data/spec/unit/util/ssl_spec.rb +1 -0
  707. data/spec/unit/util/storage_spec.rb +23 -22
  708. data/spec/unit/util/suidmanager_spec.rb +54 -45
  709. data/spec/unit/util/symbolic_file_mode_spec.rb +1 -0
  710. data/spec/unit/util/tag_set_spec.rb +1 -0
  711. data/spec/unit/util/tagging_spec.rb +1 -0
  712. data/spec/unit/util/terminal_spec.rb +10 -9
  713. data/spec/unit/util/user_attr_spec.rb +2 -1
  714. data/spec/unit/util/warnings_spec.rb +4 -3
  715. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  716. data/spec/unit/util/watcher_spec.rb +21 -51
  717. data/spec/unit/util/windows/access_control_entry_spec.rb +1 -0
  718. data/spec/unit/util/windows/access_control_list_spec.rb +1 -0
  719. data/spec/unit/util/windows/adsi_spec.rb +138 -136
  720. data/spec/unit/util/windows/api_types_spec.rb +1 -0
  721. data/spec/unit/util/windows/eventlog_spec.rb +12 -9
  722. data/spec/unit/util/windows/file_spec.rb +1 -0
  723. data/spec/unit/util/windows/root_certs_spec.rb +1 -0
  724. data/spec/unit/util/windows/security_descriptor_spec.rb +2 -0
  725. data/spec/unit/util/windows/service_spec.rb +103 -100
  726. data/spec/unit/util/windows/sid_spec.rb +13 -11
  727. data/spec/unit/util/windows/string_spec.rb +1 -0
  728. data/spec/unit/util_spec.rb +57 -55
  729. data/spec/unit/version_spec.rb +6 -6
  730. metadata +20 -32
  731. data/CODEOWNERS +0 -30
  732. data/ext/autotest/Rakefile +0 -8
  733. data/ext/autotest/config +0 -43
  734. data/ext/autotest/readme.rst +0 -16
  735. data/lib/puppet/confine/boolean.rb +0 -45
  736. data/lib/puppet/provider/package_targetable.rb +0 -68
  737. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load2.rb +0 -11
  738. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load3.rb +0 -11
  739. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load4.rb +0 -11
  740. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/bad_func_load5.rb +0 -12
  741. data/spec/fixtures/unit/pops/loaders/loaders/mix_4x_and_3x_functions/usee/lib/puppet/parser/functions/good_func_load.rb +0 -9
  742. data/spec/fixtures/unit/provider/package/pkgng/pkg.info +0 -7
  743. data/spec/fixtures/unit/provider/package/pkgng/pkg.query_absent +0 -1
  744. data/spec/integration/network/http_pool_spec.rb +0 -120
  745. data/spec/integration/provider/file/windows_spec.rb +0 -162
  746. data/spec/lib/puppet_spec/https.rb +0 -166
  747. data/spec/unit/settings/server_list_setting_spec.rb +0 -21
  748. data/spec/watchr.rb +0 -137
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  describe Puppet::Type.type(:filebucket) do
@@ -20,14 +21,14 @@ describe Puppet::Type.type(:filebucket) do
20
21
  expect(Puppet::Type.type(:filebucket).new(:name => "main")[:path]).to eq(Puppet[:clientbucketdir])
21
22
  end
22
23
 
23
- it "should not have a default port" do
24
+ it "should use the masterport as the path by default port" do
24
25
  Puppet.settings[:masterport] = 50
25
- expect(Puppet::Type.type(:filebucket).new(:name => "main")[:port]).to eq(nil)
26
+ expect(Puppet::Type.type(:filebucket).new(:name => "main")[:port]).to eq(Puppet[:masterport])
26
27
  end
27
28
 
28
- it "should not have a default server" do
29
+ it "should use the server as the path by default server" do
29
30
  Puppet.settings[:server] = "myserver"
30
- expect(Puppet::Type.type(:filebucket).new(:name => "main")[:server]).to eq(nil)
31
+ expect(Puppet::Type.type(:filebucket).new(:name => "main")[:server]).to eq(Puppet[:server])
31
32
  end
32
33
 
33
34
  it "be local by default" do
@@ -76,28 +77,26 @@ describe Puppet::Type.type(:filebucket) do
76
77
 
77
78
  describe "when creating the filebucket" do
78
79
  before do
79
- @bucket = double('bucket', :name= => nil)
80
+ @bucket = stub 'bucket', :name= => nil
80
81
  end
81
82
 
82
83
  it "should use any provided path" do
83
84
  path = make_absolute("/foo/bar")
84
85
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => path
85
- expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Path => path).and_return(@bucket)
86
+ Puppet::FileBucket::Dipper.expects(:new).with(:Path => path).returns @bucket
86
87
  bucket.bucket
87
88
  end
88
89
 
89
90
  it "should use any provided server and port" do
90
91
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :server => "myserv", :port => "myport", :path => false
91
- expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => "myserv", :Port => "myport").and_return(@bucket)
92
+ Puppet::FileBucket::Dipper.expects(:new).with(:Server => "myserv", :Port => "myport").returns @bucket
92
93
  bucket.bucket
93
94
  end
94
95
 
95
- it "should not try to guess server or port if the path is unset and no server is provided" do
96
+ it "should use the default server if the path is unset and no server is provided" do
96
97
  Puppet.settings[:server] = "myserv"
97
- Puppet.settings[:server_list] = ['server_list_0', 'server_list_1']
98
- expect(Puppet::FileBucket::Dipper).to receive(:new).with(:Server => nil, :Port => nil).and_return(@bucket)
99
-
100
98
  bucket = Puppet::Type.type(:filebucket).new :name => "main", :path => false
99
+ Puppet::FileBucket::Dipper.expects(:new).with { |args| args[:Server] == "myserv" }.returns @bucket
101
100
  bucket.bucket
102
101
  end
103
102
  end
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  describe Puppet::Type.type(:group) do
@@ -49,20 +50,20 @@ describe Puppet::Type.type(:group) do
49
50
 
50
51
  it "should call 'create' to create the group" do
51
52
  group = @class.new(:name => "foo", :ensure => :present)
52
- expect(group.provider).to receive(:create)
53
+ group.provider.expects(:create)
53
54
  group.parameter(:ensure).sync
54
55
  end
55
56
 
56
57
  it "should call 'delete' to remove the group" do
57
58
  group = @class.new(:name => "foo", :ensure => :absent)
58
- expect(group.provider).to receive(:delete)
59
+ group.provider.expects(:delete)
59
60
  group.parameter(:ensure).sync
60
61
  end
61
62
 
62
63
  it "delegates the existence check to its provider" do
63
64
  provider = @class.provide(:testing) {}
64
65
  provider_instance = provider.new
65
- expect(provider_instance).to receive(:exists?).and_return(true)
66
+ provider_instance.expects(:exists?).returns true
66
67
 
67
68
  type = @class.new(:name => "group", :provider => provider_instance)
68
69
 
@@ -70,6 +71,7 @@ describe Puppet::Type.type(:group) do
70
71
  end
71
72
 
72
73
  describe "should delegate :members implementation to the provider:" do
74
+
73
75
  let (:provider) do
74
76
  @class.provide(:testing) do
75
77
  has_features :manages_members
@@ -83,13 +85,13 @@ describe Puppet::Type.type(:group) do
83
85
  let (:type) { @class.new(:name => "group", :provider => provider_instance, :members => ['user1']) }
84
86
 
85
87
  it "insync? calls members_insync?" do
86
- expect(provider_instance).to receive(:members_insync?).with(['user1'], ['user1']).and_return(true)
88
+ provider_instance.expects(:members_insync?).with(['user1'], ['user1']).returns true
87
89
  expect(type.property(:members).insync?(['user1'])).to be_truthy
88
90
  end
89
91
 
90
92
  it "is_to_s and should_to_s call members_to_s" do
91
- expect(provider_instance).to receive(:members_to_s).with(['user1', 'user2']).and_return("user1 (), user2 ()")
92
- expect(provider_instance).to receive(:members_to_s).with(['user1']).and_return("user1 ()")
93
+ provider_instance.expects(:members_to_s).with(['user1', 'user2']).returns "user1 (), user2 ()"
94
+ provider_instance.expects(:members_to_s).with(['user1']).returns "user1 ()"
93
95
 
94
96
  expect(type.property(:members).is_to_s('user1')).to eq('user1 ()')
95
97
  expect(type.property(:members).should_to_s('user1,user2')).to eq('user1 (), user2 ()')
@@ -1,3 +1,4 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  require 'puppet/type'
@@ -6,7 +7,7 @@ describe Puppet::Type.type(:file).attrclass(:noop) do
6
7
  include PuppetSpec::Files
7
8
 
8
9
  before do
9
- allow(Puppet.settings).to receive(:use)
10
+ Puppet.settings.stubs(:use)
10
11
  @file = Puppet::Type.newfile :path => make_absolute("/what/ever")
11
12
  end
12
13
 
@@ -1,8 +1,10 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  describe Puppet::Type.type(:package) do
5
+
4
6
  before do
5
- allow(Puppet::Util::Storage).to receive(:store)
7
+ Puppet::Util::Storage.stubs(:store)
6
8
  end
7
9
 
8
10
  it "should have a :package_settings feature that requires :package_settings_insync?, :package_settings and :package_settings=" do
@@ -17,81 +19,66 @@ describe Puppet::Type.type(:package) do
17
19
 
18
20
  context "when validating attribute values" do
19
21
  let(:provider) do
20
- double('provider',
21
- :class => described_class.defaultprovider,
22
- :clear => nil,
23
- :validate_source => false)
22
+ stub( 'provider',
23
+ :class => described_class.defaultprovider,
24
+ :clear => nil,
25
+ :validate_source => false )
24
26
  end
25
-
26
27
  before do
27
- allow(provider.class).to receive(:supports_parameter?).and_return(true)
28
- allow(described_class.defaultprovider).to receive(:new).and_return(provider)
28
+ provider.class.stubs(:supports_parameter?).returns(true)
29
+ described_class.defaultprovider.stubs(:new).returns(provider)
29
30
  end
30
-
31
31
  describe 'package_settings' do
32
32
  context "with a minimalistic provider supporting package_settings" do
33
33
  context "and {:package_settings => :settings}" do
34
34
  let(:resource) do
35
35
  described_class.new :name => 'foo', :package_settings => :settings
36
36
  end
37
-
38
37
  it { expect { resource }.to_not raise_error }
39
-
40
38
  it "should set package_settings to :settings" do
41
39
  expect(resource.value(:package_settings)).to be :settings
42
40
  end
43
41
  end
44
42
  end
45
-
46
43
  context "with a provider that supports validation of the package_settings" do
47
44
  context "and {:package_settings => :valid_value}" do
48
45
  before do
49
- expect(provider).to receive(:package_settings_validate).once.with(:valid_value).and_return(true)
46
+ provider.expects(:package_settings_validate).once.with(:valid_value).returns(true)
50
47
  end
51
-
52
48
  let(:resource) do
53
49
  described_class.new :name => 'foo', :package_settings => :valid_value
54
50
  end
55
-
56
51
  it { expect { resource }.to_not raise_error }
57
-
58
52
  it "should set package_settings to :valid_value" do
59
53
  expect(resource.value(:package_settings)).to eq(:valid_value)
60
54
  end
61
55
  end
62
-
63
56
  context "and {:package_settings => :invalid_value}" do
64
57
  before do
65
58
  msg = "package_settings must be a Hash, not Symbol"
66
- expect(provider).to receive(:package_settings_validate).once.
67
- with(:invalid_value).and_raise(ArgumentError, msg)
59
+ provider.expects(:package_settings_validate).once.
60
+ with(:invalid_value).raises(ArgumentError, msg)
68
61
  end
69
-
70
62
  let(:resource) do
71
63
  described_class.new :name => 'foo', :package_settings => :invalid_value
72
64
  end
73
-
74
65
  it do
75
66
  expect { resource }.to raise_error Puppet::Error,
76
67
  /package_settings must be a Hash, not Symbol/
77
68
  end
78
69
  end
79
70
  end
80
-
81
71
  context "with a provider that supports munging of the package_settings" do
82
72
  context "and {:package_settings => 'A'}" do
83
73
  before do
84
- expect(provider).to receive(:package_settings_munge).once.with('A').and_return(:a)
74
+ provider.expects(:package_settings_munge).once.with('A').returns(:a)
85
75
  end
86
-
87
76
  let(:resource) do
88
77
  described_class.new :name => 'foo', :package_settings => 'A'
89
78
  end
90
-
91
79
  it do
92
80
  expect { resource }.to_not raise_error
93
81
  end
94
-
95
82
  it "should set package_settings to :a" do
96
83
  expect(resource.value(:package_settings)).to be :a
97
84
  end
@@ -99,55 +86,47 @@ describe Puppet::Type.type(:package) do
99
86
  end
100
87
  end
101
88
  end
102
-
103
89
  describe "package_settings property" do
104
90
  let(:provider) do
105
- double('provider',
106
- :class => described_class.defaultprovider,
107
- :clear => nil,
108
- :validate_source => false)
91
+ stub( 'provider',
92
+ :class => described_class.defaultprovider,
93
+ :clear => nil,
94
+ :validate_source => false )
109
95
  end
110
-
111
96
  before do
112
- allow(provider.class).to receive(:supports_parameter?).and_return(true)
113
- allow(described_class.defaultprovider).to receive(:new).and_return(provider)
97
+ provider.class.stubs(:supports_parameter?).returns(true)
98
+ described_class.defaultprovider.stubs(:new).returns(provider)
114
99
  end
115
-
116
100
  context "with {package_settings => :should}" do
117
101
  let(:resource) do
118
102
  described_class.new :name => 'foo', :package_settings => :should
119
103
  end
120
-
121
104
  describe "#insync?(:is)" do
122
105
  it "returns the result of provider.package_settings_insync?(:should,:is)" do
123
- expect(resource.provider).to receive(:package_settings_insync?).once.with(:should,:is).and_return(:ok1)
106
+ resource.provider.expects(:package_settings_insync?).once.with(:should,:is).returns :ok1
124
107
  expect(resource.property(:package_settings).insync?(:is)).to be :ok1
125
108
  end
126
109
  end
127
-
128
110
  describe "#should_to_s(:newvalue)" do
129
111
  it "returns the result of provider.package_settings_should_to_s(:should,:newvalue)" do
130
- expect(resource.provider).to receive(:package_settings_should_to_s).once.with(:should,:newvalue).and_return(:ok2)
112
+ resource.provider.expects(:package_settings_should_to_s).once.with(:should,:newvalue).returns :ok2
131
113
  expect(resource.property(:package_settings).should_to_s(:newvalue)).to be :ok2
132
114
  end
133
115
  end
134
-
135
116
  describe "#is_to_s(:currentvalue)" do
136
117
  it "returns the result of provider.package_settings_is_to_s(:should,:currentvalue)" do
137
- expect(resource.provider).to receive(:package_settings_is_to_s).once.with(:should,:currentvalue).and_return(:ok3)
118
+ resource.provider.expects(:package_settings_is_to_s).once.with(:should,:currentvalue).returns :ok3
138
119
  expect(resource.property(:package_settings).is_to_s(:currentvalue)).to be :ok3
139
120
  end
140
121
  end
141
122
  end
142
-
143
123
  context "with any non-nil package_settings" do
144
124
  describe "#change_to_s(:currentvalue,:newvalue)" do
145
125
  let(:resource) do
146
126
  described_class.new :name => 'foo', :package_settings => {}
147
127
  end
148
-
149
128
  it "returns the result of provider.package_settings_change_to_s(:currentvalue,:newvalue)" do
150
- expect(resource.provider).to receive(:package_settings_change_to_s).once.with(:currentvalue,:newvalue).and_return(:ok4)
129
+ resource.provider.expects(:package_settings_change_to_s).once.with(:currentvalue,:newvalue).returns :ok4
151
130
  expect(resource.property(:package_settings).change_to_s(:currentvalue,:newvalue)).to be :ok4
152
131
  end
153
132
  end
@@ -1,9 +1,10 @@
1
+ #! /usr/bin/env ruby
1
2
  require 'spec_helper'
2
3
 
3
4
  describe Puppet::Type.type(:package) do
4
5
  before do
5
- allow(Process).to receive(:euid).and_return(0)
6
- allow(Puppet::Util::Storage).to receive(:store)
6
+ Process.stubs(:euid).returns 0
7
+ Puppet::Util::Storage.stubs(:store)
7
8
  end
8
9
 
9
10
  it "should have a :reinstallable feature that requires the :reinstall method" do
@@ -57,13 +58,13 @@ describe Puppet::Type.type(:package) do
57
58
 
58
59
  describe "when validating attribute values" do
59
60
  before :each do
60
- @provider = double(
61
+ @provider = stub(
61
62
  'provider',
62
63
  :class => Puppet::Type.type(:package).defaultprovider,
63
64
  :clear => nil,
64
65
  :validate_source => nil
65
66
  )
66
- allow(Puppet::Type.type(:package).defaultprovider).to receive(:new).and_return(@provider)
67
+ Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
67
68
  end
68
69
 
69
70
  after :each do
@@ -84,32 +85,32 @@ describe Puppet::Type.type(:package) do
84
85
  end
85
86
 
86
87
  it "should support :purged as a value to :ensure if the provider has the :purgeable feature" do
87
- expect(@provider).to receive(:satisfies?).with([:purgeable]).and_return(true)
88
+ @provider.expects(:satisfies?).with([:purgeable]).returns(true)
88
89
  Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged)
89
90
  end
90
91
 
91
92
  it "should not support :purged as a value to :ensure if the provider does not have the :purgeable feature" do
92
- expect(@provider).to receive(:satisfies?).with([:purgeable]).and_return(false)
93
+ @provider.expects(:satisfies?).with([:purgeable]).returns(false)
93
94
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged) }.to raise_error(Puppet::Error)
94
95
  end
95
96
 
96
97
  it "should support :latest as a value to :ensure if the provider has the :upgradeable feature" do
97
- expect(@provider).to receive(:satisfies?).with([:upgradeable]).and_return(true)
98
+ @provider.expects(:satisfies?).with([:upgradeable]).returns(true)
98
99
  Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest)
99
100
  end
100
101
 
101
102
  it "should not support :latest as a value to :ensure if the provider does not have the :upgradeable feature" do
102
- expect(@provider).to receive(:satisfies?).with([:upgradeable]).and_return(false)
103
+ @provider.expects(:satisfies?).with([:upgradeable]).returns(false)
103
104
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest) }.to raise_error(Puppet::Error)
104
105
  end
105
106
 
106
107
  it "should support version numbers as a value to :ensure if the provider has the :versionable feature" do
107
- expect(@provider).to receive(:satisfies?).with([:versionable]).and_return(true)
108
+ @provider.expects(:satisfies?).with([:versionable]).returns(true)
108
109
  Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0")
109
110
  end
110
111
 
111
112
  it "should not support version numbers as a value to :ensure if the provider does not have the :versionable feature" do
112
- expect(@provider).to receive(:satisfies?).with([:versionable]).and_return(false)
113
+ @provider.expects(:satisfies?).with([:versionable]).returns(false)
113
114
  expect { Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0") }.to raise_error(Puppet::Error)
114
115
  end
115
116
 
@@ -126,13 +127,13 @@ describe Puppet::Type.type(:package) do
126
127
 
127
128
  module PackageEvaluationTesting
128
129
  def setprops(properties)
129
- allow(@provider).to receive(:properties).and_return(properties)
130
+ @provider.stubs(:properties).returns(properties)
130
131
  end
131
132
  end
132
133
 
133
134
  describe Puppet::Type.type(:package) do
134
135
  before :each do
135
- @provider = double(
136
+ @provider = stub(
136
137
  'provider',
137
138
  :class => Puppet::Type.type(:package).defaultprovider,
138
139
  :clear => nil,
@@ -140,8 +141,8 @@ describe Puppet::Type.type(:package) do
140
141
  :name => :mock,
141
142
  :validate_source => nil
142
143
  )
143
- allow(Puppet::Type.type(:package).defaultprovider).to receive(:new).and_return(@provider)
144
- allow(Puppet::Type.type(:package).defaultprovider).to receive(:instances).and_return([])
144
+ Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
145
+ Puppet::Type.type(:package).defaultprovider.stubs(:instances).returns([])
145
146
  @package = Puppet::Type.type(:package).new(:name => "yay")
146
147
 
147
148
  @catalog = Puppet::Resource::Catalog.new
@@ -154,14 +155,14 @@ describe Puppet::Type.type(:package) do
154
155
  before { @package[:ensure] = :purged }
155
156
 
156
157
  it "should do nothing if it is :purged" do
157
- expect(@provider).to receive(:properties).and_return(:ensure => :purged).at_least(:once)
158
+ @provider.expects(:properties).returns(:ensure => :purged).at_least_once
158
159
  @catalog.apply
159
160
  end
160
161
 
161
162
  [:absent, :installed, :present, :latest].each do |state|
162
163
  it "should purge if it is #{state.to_s}" do
163
- allow(@provider).to receive(:properties).and_return(:ensure => state)
164
- expect(@provider).to receive(:purge)
164
+ @provider.stubs(:properties).returns(:ensure => state)
165
+ @provider.expects(:purge)
165
166
  @catalog.apply
166
167
  end
167
168
  end
@@ -174,15 +175,15 @@ describe Puppet::Type.type(:package) do
174
175
 
175
176
  [:purged, :absent].each do |state|
176
177
  it "should do nothing if it is #{state.to_s}" do
177
- expect(@provider).to receive(:properties).and_return(:ensure => state).at_least(:once)
178
+ @provider.expects(:properties).returns(:ensure => state).at_least_once
178
179
  @catalog.apply
179
180
  end
180
181
  end
181
182
 
182
183
  [:installed, :present, :latest].each do |state|
183
184
  it "should uninstall if it is #{state.to_s}" do
184
- allow(@provider).to receive(:properties).and_return(:ensure => state)
185
- expect(@provider).to receive(:uninstall)
185
+ @provider.stubs(:properties).returns(:ensure => state)
186
+ @provider.expects(:uninstall)
186
187
  @catalog.apply
187
188
  end
188
189
  end
@@ -195,15 +196,15 @@ describe Puppet::Type.type(:package) do
195
196
 
196
197
  [:present, :latest, "1.0"].each do |state|
197
198
  it "should do nothing if it is #{state.to_s}" do
198
- expect(@provider).to receive(:properties).and_return(:ensure => state).at_least(:once)
199
+ @provider.expects(:properties).returns(:ensure => state).at_least_once
199
200
  @catalog.apply
200
201
  end
201
202
  end
202
203
 
203
204
  [:purged, :absent].each do |state|
204
205
  it "should install if it is #{state.to_s}" do
205
- allow(@provider).to receive(:properties).and_return(:ensure => state)
206
- expect(@provider).to receive(:install)
206
+ @provider.stubs(:properties).returns(:ensure => state)
207
+ @provider.expects(:install)
207
208
  @catalog.apply
208
209
  end
209
210
  end
@@ -216,30 +217,30 @@ describe Puppet::Type.type(:package) do
216
217
 
217
218
  [:purged, :absent].each do |state|
218
219
  it "should upgrade if it is #{state.to_s}" do
219
- allow(@provider).to receive(:properties).and_return(:ensure => state)
220
- expect(@provider).to receive(:update)
220
+ @provider.stubs(:properties).returns(:ensure => state)
221
+ @provider.expects(:update)
221
222
  @catalog.apply
222
223
  end
223
224
  end
224
225
 
225
226
  it "should upgrade if the current version is not equal to the latest version" do
226
- allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
227
- allow(@provider).to receive(:latest).and_return("2.0")
228
- expect(@provider).to receive(:update)
227
+ @provider.stubs(:properties).returns(:ensure => "1.0")
228
+ @provider.stubs(:latest).returns("2.0")
229
+ @provider.expects(:update)
229
230
  @catalog.apply
230
231
  end
231
232
 
232
233
  it "should do nothing if it is equal to the latest version" do
233
- allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
234
- allow(@provider).to receive(:latest).and_return("1.0")
235
- expect(@provider).not_to receive(:update)
234
+ @provider.stubs(:properties).returns(:ensure => "1.0")
235
+ @provider.stubs(:latest).returns("1.0")
236
+ @provider.expects(:update).never
236
237
  @catalog.apply
237
238
  end
238
239
 
239
240
  it "should do nothing if the provider returns :present as the latest version" do
240
- allow(@provider).to receive(:properties).and_return(:ensure => :present)
241
- allow(@provider).to receive(:latest).and_return("1.0")
242
- expect(@provider).not_to receive(:update)
241
+ @provider.stubs(:properties).returns(:ensure => :present)
242
+ @provider.stubs(:latest).returns("1.0")
243
+ @provider.expects(:update).never
243
244
  @catalog.apply
244
245
  end
245
246
  end
@@ -251,24 +252,24 @@ describe Puppet::Type.type(:package) do
251
252
 
252
253
  [:purged, :absent].each do |state|
253
254
  it "should install if it is #{state.to_s}" do
254
- allow(@provider).to receive(:properties).and_return(:ensure => state)
255
+ @provider.stubs(:properties).returns(:ensure => state)
255
256
  expect(@package.property(:ensure).insync?(state)).to be_falsey
256
- expect(@provider).to receive(:install)
257
+ @provider.expects(:install)
257
258
  @catalog.apply
258
259
  end
259
260
  end
260
261
 
261
262
  it "should do nothing if the current version is equal to the desired version" do
262
- allow(@provider).to receive(:properties).and_return(:ensure => "1.0")
263
+ @provider.stubs(:properties).returns(:ensure => "1.0")
263
264
  expect(@package.property(:ensure).insync?('1.0')).to be_truthy
264
- expect(@provider).not_to receive(:install)
265
+ @provider.expects(:install).never
265
266
  @catalog.apply
266
267
  end
267
268
 
268
269
  it "should install if the current version is not equal to the specified version" do
269
- allow(@provider).to receive(:properties).and_return(:ensure => "2.0")
270
+ @provider.stubs(:properties).returns(:ensure => "2.0")
270
271
  expect(@package.property(:ensure).insync?('2.0')).to be_falsey
271
- expect(@provider).to receive(:install)
272
+ @provider.expects(:install)
272
273
  @catalog.apply
273
274
  end
274
275
 
@@ -276,29 +277,29 @@ describe Puppet::Type.type(:package) do
276
277
  let(:installed_versions) { ["1.0", "2.0", "3.0"] }
277
278
 
278
279
  before (:each) do
279
- allow(@provider).to receive(:properties).and_return(:ensure => installed_versions)
280
+ @provider.stubs(:properties).returns(:ensure => installed_versions)
280
281
  end
281
282
 
282
283
  it "should install if value not in the array" do
283
284
  @package[:ensure] = "1.5"
284
285
  expect(@package.property(:ensure).insync?(installed_versions)).to be_falsey
285
- expect(@provider).to receive(:install)
286
+ @provider.expects(:install)
286
287
  @catalog.apply
287
288
  end
288
289
 
289
290
  it "should not install if value is in the array" do
290
291
  @package[:ensure] = "2.0"
291
292
  expect(@package.property(:ensure).insync?(installed_versions)).to be_truthy
292
- expect(@provider).not_to receive(:install)
293
+ @provider.expects(:install).never
293
294
  @catalog.apply
294
295
  end
295
296
 
296
297
  describe "when ensure is set to 'latest'" do
297
298
  it "should not install if the value is in the array" do
298
- expect(@provider).to receive(:latest).and_return("3.0")
299
+ @provider.expects(:latest).returns("3.0")
299
300
  @package[:ensure] = "latest"
300
301
  expect(@package.property(:ensure).insync?(installed_versions)).to be_truthy
301
- expect(@provider).not_to receive(:install)
302
+ @provider.expects(:install).never
302
303
  @catalog.apply
303
304
  end
304
305
  end
@@ -327,16 +328,16 @@ describe Puppet::Type.type(:package) do
327
328
  it "should reinstall if it should be #{state.to_s} and reinstall_on_refresh is true" do
328
329
  @package[:ensure] = state
329
330
  @package[:reinstall_on_refresh] = :true
330
- allow(@provider).to receive(:reinstallable?).and_return(true)
331
- expect(@provider).to receive(:reinstall).once
331
+ @provider.stubs(:reinstallable?).returns(true)
332
+ @provider.expects(:reinstall).once
332
333
  @package.refresh
333
334
  end
334
335
 
335
336
  it "should reinstall if it should be #{state.to_s} and reinstall_on_refresh is false" do
336
337
  @package[:ensure] = state
337
338
  @package[:reinstall_on_refresh] = :false
338
- allow(@provider).to receive(:reinstallable?).and_return(true)
339
- expect(@provider).not_to receive(:reinstall)
339
+ @provider.stubs(:reinstallable?).returns(true)
340
+ @provider.expects(:reinstall).never
340
341
  @package.refresh
341
342
  end
342
343
  end
@@ -344,15 +345,15 @@ describe Puppet::Type.type(:package) do
344
345
  [:purged, :absent, :held].each do |state|
345
346
  it "should not reinstall if it should be #{state.to_s} and reinstall_on_refresh is true" do
346
347
  @package[:ensure] = state
347
- allow(@provider).to receive(:reinstallable?).and_return(true)
348
- expect(@provider).not_to receive(:reinstall)
348
+ @provider.stubs(:reinstallable?).returns(true)
349
+ @provider.expects(:reinstall).never
349
350
  @package.refresh
350
351
  end
351
352
 
352
353
  it "should not reinstall if it should be #{state.to_s} and reinstall_on_refresh is false" do
353
354
  @package[:ensure] = state
354
- allow(@provider).to receive(:reinstallable?).and_return(true)
355
- expect(@provider).not_to receive(:reinstall)
355
+ @provider.stubs(:reinstallable?).returns(true)
356
+ @provider.expects(:reinstall).never
356
357
  @package.refresh
357
358
  end
358
359
  end
@@ -362,9 +363,9 @@ describe Puppet::Type.type(:package) do
362
363
  it "should select dnf over yum for dnf supported fedora versions" do
363
364
  dnf = Puppet::Type.type(:package).provider(:dnf)
364
365
  yum = Puppet::Type.type(:package).provider(:yum)
365
- allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
366
- allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
367
- allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("22")
366
+ Facter.stubs(:value).with(:osfamily).returns(:redhat)
367
+ Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
368
+ Facter.stubs(:value).with(:operatingsystemmajrelease).returns("22")
368
369
 
369
370
  expect(dnf.specificity).to be > yum.specificity
370
371
  end