puppet 6.0.0 → 6.1.0

data/spec/unit/provider/service/redhat_spec.rb

@@ -1,11 +1,7 @@
-#! /usr/bin/env ruby
-#
-# Unit testing for the RedHat service Provider
-#
 require 'spec_helper'
 
 describe 'Puppet::Type::Service::Provider::Redhat',
-    :if => Puppet.features.posix? && !Puppet::Util::Platform.jruby? do
+         if: Puppet.features.posix? && !Puppet::Util::Platform.jruby?do
   let(:provider_class) { Puppet::Type.type(:service).provider(:redhat) }
 
   before :each do
@@ -40,7 +36,7 @@ describe 'Puppet::Type::Service::Provider::Redhat',
   end
 
   # test self.instances
-  describe "when getting all service instances" do
+  context "when getting all service instances" do
     before :each do
       @services = ['one', 'two', 'three', 'four', 'kudzu', 'functions', 'halt', 'killall', 'single', 'linuxconf', 'boot', 'reboot']
       @not_services = ['functions', 'halt', 'killall', 'single', 'linuxconf', 'reboot', 'boot']
@@ -78,7 +74,7 @@ describe 'Puppet::Type::Service::Provider::Redhat',
     expect(@provider).to respond_to(:enabled?)
   end
 
-  describe "when checking enabled? on Suse" do
+  context "when checking enabled? on Suse" do
     before :each do
       Facter.expects(:value).with(:osfamily).returns 'Suse'
     end
@@ -132,20 +128,23 @@ describe 'Puppet::Type::Service::Provider::Redhat',
     end
   end
 
-  describe "when checking status" do
-    describe "when hasstatus is :true" do
+  context "when checking status" do
+    context "when hasstatus is :true" do
       before :each do
         @resource.stubs(:[]).with(:hasstatus).returns :true
       end
+
       it "should execute the service script with fail_on_failure false" do
         @provider.expects(:texecute).with(:status, ['/sbin/service', 'myservice', 'status'], false)
         @provider.status
       end
+
       it "should consider the process running if the command returns 0" do
         @provider.expects(:texecute).with(:status, ['/sbin/service', 'myservice', 'status'], false)
         $CHILD_STATUS.stubs(:exitstatus).returns(0)
         expect(@provider.status).to eq(:running)
       end
+
       [-10,-1,1,10].each { |ec|
         it "should consider the process stopped if the command returns something non-0" do
           @provider.expects(:texecute).with(:status, ['/sbin/service', 'myservice', 'status'], false)
@@ -154,11 +153,13 @@ describe 'Puppet::Type::Service::Provider::Redhat',
         end
       }
     end
-    describe "when hasstatus is not :true" do
+
+    context "when hasstatus is not :true" do
       it "should consider the service :running if it has a pid" do
         @provider.expects(:getpid).returns "1234"
         expect(@provider.status).to eq(:running)
       end
+
       it "should consider the service :stopped if it doesn't have a pid" do
         @provider.expects(:getpid).returns nil
         expect(@provider.status).to eq(:stopped)
@@ -166,7 +167,7 @@ describe 'Puppet::Type::Service::Provider::Redhat',
     end
   end
 
-  describe "when restarting and hasrestart is not :true" do
+  context "when restarting and hasrestart is not :true" do
     it "should stop and restart the process with the server script" do
       @provider.expects(:texecute).with(:stop,  ['/sbin/service', 'myservice', 'stop'],  true)
       @provider.expects(:texecute).with(:start, ['/sbin/service', 'myservice', 'start'], true)

data/spec/unit/provider/service/runit_spec.rb

@@ -1,9 +1,3 @@
-#! /usr/bin/env ruby
-#
-# Unit testing for the Runit service Provider
-#
-# author Brice Figureau
-#
 require 'spec_helper'
 
 describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platform.jruby? do
@@ -62,7 +56,7 @@ describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platfor
     expect(@provider).to respond_to(:disable)
   end
 
-  describe "when starting" do
+  context "when starting" do
     it "should enable the service if it is not enabled" do
       @provider.stubs(:sv)
 
@@ -80,21 +74,21 @@ describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platfor
     end
   end
 
-  describe "when stopping" do
+  context "when stopping" do
     it "should execute external command 'sv stop /etc/service/myservice'" do
       @provider.expects(:sv).with("stop", "/etc/service/myservice")
       @provider.stop
     end
   end
 
-  describe "when restarting" do
+  context "when restarting" do
     it "should call 'sv restart /etc/service/myservice'" do
       @provider.expects(:sv).with("restart","/etc/service/myservice")
       @provider.restart
     end
   end
 
-  describe "when enabling" do
+  context "when enabling" do
     it "should create a symlink between daemon dir and service dir", :if => Puppet.features.manages_symlinks? do
       daemon_path = File.join(@daemondir,"myservice")
       service_path = File.join(@servicedir,"myservice")
@@ -104,7 +98,7 @@ describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platfor
     end
   end
 
-  describe "when disabling" do
+  context "when disabling" do
     it "should remove the '/etc/service/myservice' symlink" do
       path = File.join(@servicedir,"myservice")
 #      mocked_file = mock(path, :symlink? => true)
@@ -115,14 +109,14 @@ describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platfor
     end
   end
 
-  describe "when checking status" do
+  context "when checking status" do
     it "should call the external command 'sv status /etc/sv/myservice'" do
       @provider.expects(:sv).with('status',File.join(@daemondir,"myservice"))
       @provider.status
     end
   end
 
-  describe "when checking status" do
+  context "when checking status" do
     it "and sv status fails, properly raise a Puppet::Error" do
       @provider.expects(:sv).with('status',File.join(@daemondir,"myservice")).raises(Puppet::ExecutionFailure, "fail: /etc/sv/myservice: file not found")
       expect { @provider.status }.to raise_error(Puppet::Error, 'Could not get status for service Service[myservice]: fail: /etc/sv/myservice: file not found')
@@ -140,5 +134,4 @@ describe 'Puppet::Type::Service::Provider::Runit', unless: Puppet::Util::Platfor
       expect(@provider.status).to eq(:stopped)
     end
   end
-
 end

data/spec/unit/provider/service/smf_spec.rb

@@ -1,13 +1,7 @@
-#! /usr/bin/env ruby
-#
-# Unit testing for the SMF service Provider
-#
-# author Dominic Cleal
-#
 require 'spec_helper'
 
 describe 'Puppet::Type::Service::Provider::Smf',
-    if: Puppet.features.posix? && !Puppet::Util::Platform.jruby? do
+         if: Puppet.features.posix? && !Puppet::Util::Platform.jruby? do
   let(:provider_class) { Puppet::Type.type(:service).provider(:smf) }
 
   before(:each) do
@@ -25,7 +19,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     Facter.stubs(:value).with(:operatingsystemrelease).returns '11.2'
   end
 
-  describe ".instances" do
+  context ".instances" do
     it "should have an instances method" do
       expect(provider_class).to respond_to :instances
     end
@@ -70,6 +64,10 @@ describe 'Puppet::Type::Service::Provider::Smf',
   end
 
   describe "when checking status" do
+    before(:each) do
+      @provider.stubs(:complete_service?).returns(true)
+    end
+
     it "should call the external command 'svcs /system/myservice' once" do
       @provider.expects(:svcs).with('-H', '-o', 'state,nstate', "/system/myservice").returns("online\t-")
       @provider.status
@@ -78,6 +76,11 @@ describe 'Puppet::Type::Service::Provider::Smf',
       @provider.stubs(:svcs).raises(Puppet::ExecutionFailure.new("no svc found"))
       expect(@provider.status).to eq(:stopped)
     end
+    it "should return stopped for an incomplete service on Solaris 11" do
+      Facter.stubs(:value).with(:operatingsystemrelease).returns('11.3')
+      @provider.stubs(:complete_service?).returns(false)
+      expect(@provider.status).to eq(:stopped)
+    end
     it "should return running if online in svcs output" do
       @provider.stubs(:svcs).returns("online\t-")
       expect(@provider.status).to eq(:running)
@@ -104,7 +107,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     end
   end
 
-  describe "when starting" do
+  context "when starting" do
     it "should enable the service if it is not enabled" do
       @provider.expects(:status).returns :stopped
       @provider.expects(:texecute).with(:start, ['/usr/sbin/svcadm', :enable, '-rs', '/system/myservice'], true)
@@ -141,7 +144,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     end
   end
 
-  describe "when starting a service with a manifest" do
+  context "when starting a service with a manifest" do
     before(:each) do
       @resource = Puppet::Type.type(:service).new(:name => "/system/myservice", :ensure => :running, :enable => :true, :manifest => "/tmp/myservice.xml")
       @provider = provider_class.new(@resource)
@@ -149,6 +152,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     end
 
     it "should import the manifest if service is missing" do
+      @provider.stubs(:complete_service?).returns(true)
       @provider.expects(:svcs).with('-l', '/system/myservice').raises(Puppet::ExecutionFailure, "Exited 1")
       @provider.expects(:svccfg).with(:import, "/tmp/myservice.xml")
       @provider.expects(:texecute).with(:start, ["/usr/sbin/svcadm", :enable, '-rs', "/system/myservice"], true)
@@ -164,7 +168,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     end
   end
 
-  describe "when stopping" do
+  context "when stopping" do
     it "should execute external command 'svcadm disable /system/myservice'" do
       @provider.expects(:texecute).with(:stop, ["/usr/sbin/svcadm", :disable, '-s', "/system/myservice"], true)
       @provider.expects(:wait).with('offline', 'disabled', 'uninitialized')
@@ -178,8 +182,7 @@ describe 'Puppet::Type::Service::Provider::Smf',
     end
   end
 
-  describe "when restarting" do
-
+  context "when restarting" do
     it "should error if timeout occurs while restarting the service" do
       @provider.expects(:texecute).with(:restart, ["/usr/sbin/svcadm", :restart, '-s', "/system/myservice"], true)
       Timeout.expects(:timeout).with(60).raises(Timeout::Error)
@@ -212,6 +215,67 @@ describe 'Puppet::Type::Service::Provider::Smf',
         @provider.restart
       end
     end
+  end
+
+  describe '#service_fmri' do
+    it 'raises a Puppet::Error if the service resource matches multiple FMRIs' do
+      @provider.stubs(:svcs).with('-l', @provider.resource[:name]).returns(File.read(my_fixture('svcs_multiple_fmris.out')))
+
+      expect { @provider.service_fmri }.to raise_error do |error|
+        expect(error).to be_a(Puppet::Error)
+        expect(error.message).to match(@provider.resource[:name])
+        expect(error.message).to match('multiple')
+
+        matched_fmris = ["svc:/application/tstapp:one", "svc:/application/tstapp:two"]
+        expect(error.message).to match(matched_fmris.join(', '))
+      end
+    end
+
+    it 'raises a Puppet:ExecutionFailure if svcs fails' do
+      @provider.stubs(:svcs).with('-l', @provider.resource[:name]).raises(
+        Puppet::ExecutionFailure, 'svcs failed!'
+      )
+
+      expect { @provider.service_fmri }.to raise_error do |error|
+        expect(error).to be_a(Puppet::ExecutionFailure)
+        expect(error.message).to match('svcs failed!')
+      end
+    end
 
+    it "returns the service resource's fmri and memoizes it" do
+      @provider.stubs(:svcs).with('-l', @provider.resource[:name]).returns(File.read(my_fixture('svcs_fmri.out')))
+
+      expected_fmri = 'svc:/application/tstapp:default'
+
+      expect(@provider.service_fmri).to eql(expected_fmri)
+      expect(@provider.instance_variable_get(:@fmri)).to eql(expected_fmri)
+    end
+  end
+
+  describe '#complete_service?' do
+    let(:fmri) { 'service_fmri' }
+
+    before(:each) do
+      @provider.stubs(:service_fmri).returns(fmri)
+    end
+
+    it 'should raise a Puppet::Error if it is called on an older Solaris machine' do
+      Facter.stubs(:value).with(:operatingsystemrelease).returns('10.0')
+
+      expect { @provider.complete_service? }.to raise_error(Puppet::Error)
+    end
+
+    it 'should return false for an incomplete service' do
+      @provider.stubs(:svccfg).with('-s', fmri, 'listprop', 'general/complete').returns("")
+      expect(@provider.complete_service?).to be false
+    end
+
+    it 'should return true for a complete service' do
+      @provider.stubs(:svccfg)
+        .with('-s', fmri, 'listprop', 'general/complete')
+        .returns("general/complete astring")
+
+      expect(@provider.complete_service?).to be true
+    end
   end
 end

data/spec/unit/provider/service/src_spec.rb

@@ -1,11 +1,7 @@
-#! /usr/bin/env ruby
-#
-# Unit testing for the AIX System Resource Controller (src) provider
-#
-
 require 'spec_helper'
 
-describe 'Puppet::Type::Service::Provider::Src', unless: Puppet::Util::Platform.jruby? do
+describe 'Puppet::Type::Service::Provider::Src',
+         unless: Puppet::Util::Platform.jruby? do
   let(:provider_class) { Puppet::Type.type(:service).provider(:src) }
 
   if Puppet::Util::Platform.windows?
@@ -41,7 +37,7 @@ describe 'Puppet::Type::Service::Provider::Src', unless: Puppet::Util::Platform.
     @provider.stubs(:chitab)
   end
 
-  describe ".instances" do
+  context ".instances" do
     it "should have a .instances method" do
       expect(provider_class).to respond_to :instances
     end
@@ -65,7 +61,7 @@ _EOF_
 
   end
 
-  describe "when starting a service" do
+  context "when starting a service" do
     it "should execute the startsrc command" do
       @provider.expects(:execute).with(['/usr/bin/startsrc', '-s', "myservice"], {:override_locale => false, :squelch => false, :combine => true, :failonfail => true})
       @provider.expects(:status).returns :running
@@ -79,7 +75,7 @@ _EOF_
     end
   end
 
-  describe "when stopping a service" do
+  context "when stopping a service" do
     it "should execute the stopsrc command" do
       @provider.expects(:execute).with(['/usr/bin/stopsrc', '-s', "myservice"], {:override_locale => false, :squelch => false, :combine => true, :failonfail => true})
       @provider.expects(:status).returns :stopped
@@ -93,7 +89,7 @@ _EOF_
     end
   end
 
-  describe "should have a set of methods" do
+  context "should have a set of methods" do
     [:enabled?, :enable, :disable, :start, :stop, :status, :restart].each do |method|
       it "should have a #{method} method" do
         expect(@provider).to respond_to(method)
@@ -101,21 +97,21 @@ _EOF_
     end
   end
 
-  describe "when enabling" do
+  context "when enabling" do
     it "should execute the mkitab command" do
       @provider.expects(:mkitab).with("myservice:2:once:/usr/bin/startsrc -s myservice").once
       @provider.enable
     end
   end
 
-  describe "when disabling" do
+  context "when disabling" do
     it "should execute the rmitab command" do
       @provider.expects(:rmitab).with("myservice")
       @provider.disable
     end
   end
 
-  describe "when checking if it is enabled" do
+  context "when checking if it is enabled" do
     it "should execute the lsitab command" do
       @provider.expects(:execute).with(['/usr/sbin/lsitab', 'myservice'], {:combine => true, :failonfail => false})
       $CHILD_STATUS.stubs(:exitstatus).returns(0)
@@ -135,8 +131,7 @@ _EOF_
     end
   end
 
-
-  describe "when checking a subsystem's status" do
+  context "when checking a subsystem's status" do
     it "should execute status and return running if the subsystem is active" do
       sample_output = <<_EOF_
   Subsystem         Group            PID          Status
@@ -173,7 +168,7 @@ _EOF_
     end
   end
 
-  describe "when restarting a service" do
+  context "when restarting a service" do
     it "should execute restart which runs refresh" do
       sample_output = <<_EOF_
 #subsysname:synonym:cmdargs:path:uid:auditid:standin:standout:standerr:action:multi:contact:svrkey:svrmtype:priority:signorm:sigforce:display:waittime:grpname:

data/spec/unit/provider/service/systemd_spec.rb

@@ -143,7 +143,25 @@ describe 'Puppet::Type::Service::Provider::Systemd', unless: Puppet::Util::Platf
     end
   end
 
-  [:enabled?, :enable, :disable, :start, :stop, :status, :restart].each do |method|
+  [ '10', '11', '12', '13', '14', '15', '16', '17' ].each do |ver|
+    it "should not be the default provider on LinuxMint#{ver}" do
+      Facter.stubs(:value).with(:osfamily).returns(:debian)
+      Facter.stubs(:value).with(:operatingsystem).returns(:LinuxMint)
+      Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
+      expect(provider_class).not_to be_default
+    end
+  end
+
+  [ '18', '19' ].each do |ver|
+    it "should be the default provider on LinuxMint#{ver}" do
+      Facter.stubs(:value).with(:osfamily).returns(:debian)
+      Facter.stubs(:value).with(:operatingsystem).returns(:LinuxMint)
+      Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
+      expect(provider_class).to be_default
+    end
+  end
+
+  [:enabled?, :daemon_reload?, :enable, :disable, :start, :stop, :status, :restart].each do |method|
     it "should have a #{method} method" do
       expect(provider).to respond_to(method)
     end
@@ -169,6 +187,7 @@ describe 'Puppet::Type::Service::Provider::Systemd', unless: Puppet::Util::Platf
   describe "#start" do
     it "should use the supplied start command if specified" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service', :start => '/bin/foo'))
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.start
     end
@@ -176,6 +195,7 @@ describe 'Puppet::Type::Service::Provider::Systemd', unless: Puppet::Util::Platf
     it "should start the service with systemctl start otherwise" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
       provider.expects(:systemctl).with(:unmask, 'sshd.service')
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/systemctl','start','sshd.service'], {:failonfail => true, :override_locale => false, :squelch => false, :combine => true})
       provider.start
     end
@@ -183,6 +203,7 @@ describe 'Puppet::Type::Service::Provider::Systemd', unless: Puppet::Util::Platf
     it "should show journald logs on failure" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
       provider.expects(:systemctl).with(:unmask, 'sshd.service')
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/systemctl','start','sshd.service'],{:failonfail => true, :override_locale => false, :squelch => false, :combine => true})
         .raises(Puppet::ExecutionFailure, "Failed to start sshd.service: Unit sshd.service failed to load: Invalid argument. See system logs and 'systemctl status sshd.service' for details.")
       journalctl_logs = <<-EOS
@@ -224,6 +245,20 @@ Jun 14 21:43:23 foo.example.com systemd[1]: sshd.service lacks both ExecStart= a
     end
   end
 
+  describe "#daemon_reload?" do
+    it "should skip the systemctl daemon_reload if not required by the service" do
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
+      provider.expects(:execute).with(['/bin/systemctl','show','sshd.service','--property=NeedDaemonReload'], :failonfail => false).returns "no"
+      provider.daemon_reload?
+    end
+    it "should run a systemctl daemon_reload if the service has been modified" do
+      provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
+      provider.expects(:execute).with(['/bin/systemctl','show','sshd.service','--property=NeedDaemonReload'], :failonfail => false).returns "yes"
+      provider.expects(:execute).with(['/bin/systemctl','daemon-reload'], :failonfail => false)
+      provider.daemon_reload?
+    end
+  end
+
   describe "#enabled?" do
     it "should return :true if the service is enabled" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
@@ -328,6 +363,7 @@ Jun 14 21:43:23 foo.example.com systemd[1]: sshd.service lacks both ExecStart= a
   describe "#restart" do
     it "should use the supplied restart command if specified" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd', :restart => '/bin/foo'))
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/systemctl','restart','sshd.service'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true).never
       provider.expects(:execute).with(['/bin/foo'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.restart
@@ -335,12 +371,14 @@ Jun 14 21:43:23 foo.example.com systemd[1]: sshd.service lacks both ExecStart= a
 
     it "should restart the service with systemctl restart" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/systemctl','restart','sshd.service'], :failonfail => true, :override_locale => false, :squelch => false, :combine => true)
       provider.restart
     end
 
     it "should show journald logs on failure" do
       provider = provider_class.new(Puppet::Type.type(:service).new(:name => 'sshd.service'))
+      provider.expects(:daemon_reload?).returns('no')
       provider.expects(:execute).with(['/bin/systemctl','restart','sshd.service'],{:failonfail => true, :override_locale => false, :squelch => false, :combine => true})
         .raises(Puppet::ExecutionFailure, "Failed to restart sshd.service: Unit sshd.service failed to load: Invalid argument. See system logs and 'systemctl status sshd.service' for details.")
       journalctl_logs = <<-EOS

data/spec/unit/provider/service/windows_spec.rb

@@ -22,6 +22,8 @@ describe 'Puppet::Type::Service::Provider::Windows',
     # make sure we never actually execute anything (there are two execute methods)
     provider.class.expects(:execute).never
     provider.expects(:execute).never
+
+    service_util.stubs(:exists?).with(resource[:name]).returns(true)
   end
 
   describe ".instances" do
@@ -34,9 +36,19 @@ describe 'Puppet::Type::Service::Provider::Windows',
   end
 
   describe "#start" do
+    before(:each) do
+      provider.stubs(:status).returns(:stopped)
+    end
+
+    it "should resume a paused service" do
+      provider.stubs(:status).returns(:paused)
+      service_util.expects(:resume)
+      provider.start
+    end
+
     it "should start the service" do
       service_util.expects(:service_start_type).with(name).returns(:SERVICE_AUTO_START)
-      service_util.expects(:start).with(name)
+      service_util.expects(:start)
       provider.start
     end
 
@@ -51,7 +63,7 @@ describe 'Puppet::Type::Service::Provider::Windows',
 
       it "should enable if managing enable and enable is true" do
         resource[:enable] = :true
-        service_util.expects(:start).with(name)
+        service_util.expects(:start)
         service_util.expects(:set_startup_mode).with(name, :SERVICE_AUTO_START)
 
         provider.start
@@ -59,7 +71,7 @@ describe 'Puppet::Type::Service::Provider::Windows',
 
       it "should manual start if managing enable and enable is false" do
         resource[:enable] = :false
-        service_util.expects(:start).with(name)
+        service_util.expects(:start)
         service_util.expects(:set_startup_mode).with(name, :SERVICE_DEMAND_START)
 
         provider.start
@@ -69,18 +81,32 @@ describe 'Puppet::Type::Service::Provider::Windows',
 
   describe "#stop" do
     it "should stop a running service" do
-      service_util.expects(:stop).with(name)
+      service_util.expects(:stop)
 
       provider.stop
     end
   end
 
   describe "#status" do
+    it "should report a nonexistent service as stopped" do
+      service_util.stubs(:exists?).with(resource[:name]).returns(false)
+
+      expect(provider.status).to eql(:stopped)
+    end
+
     [
-      :SERVICE_STOPPED,
       :SERVICE_PAUSED,
-      :SERVICE_STOP_PENDING,
-      :SERVICE_PAUSE_PENDING,
+      :SERVICE_PAUSE_PENDING
+    ].each do |state|
+      it "should report a #{state} service as paused" do
+        service_util.expects(:service_state).with(name).returns(state)
+        expect(provider.status).to eq(:paused)
+      end
+    end
+
+    [
+      :SERVICE_STOPPED,
+      :SERVICE_STOP_PENDING
     ].each do |state|
       it "should report a #{state} service as stopped" do
         service_util.expects(:service_state).with(name).returns(state)
@@ -121,6 +147,12 @@ describe 'Puppet::Type::Service::Provider::Windows',
   end
 
   describe "#enabled?" do
+    it "should report a nonexistent service as false" do
+      service_util.stubs(:exists?).with(resource[:name]).returns(false)
+
+      expect(provider.enabled?).to eql(:false)
+    end
+
     it "should report a service with a startup type of manual as manual" do
       service_util.expects(:service_start_type).with(name).returns(:SERVICE_DEMAND_START)
       expect(provider.enabled?).to eq(:manual)

data/spec/unit/provider/user/aix_spec.rb

@@ -70,11 +70,23 @@ describe 'Puppet::Type::User::Provider::Aix' do
     end
   end
 
-  describe '.groups_to_groups' do
+  describe '.groups_attribute_to_property' do
+    it "reads the user's groups from the etc/groups file" do
+      groups = ['system', 'adm']
+      Puppet::Util::POSIX.stubs(:groups_of).with(resource[:name]).returns(groups)
+
+      actual_groups = provider_class.groups_attribute_to_property(provider, 'unused_value')
+      expected_groups = groups.join(',')
+
+      expect(actual_groups).to eql(expected_groups)
+    end
+  end
+
+  describe '.groups_property_to_attribute' do
     it 'raises an ArgumentError if the groups are space-separated' do
       groups = "foo bar baz"
       expect do
-        provider_class.groups_to_groups(groups)
+        provider_class.groups_property_to_attribute(groups)
       end.to raise_error do |error|
         expect(error).to be_a(ArgumentError)
 
@@ -84,6 +96,33 @@ describe 'Puppet::Type::User::Provider::Aix' do
     end
   end
 
+  describe '#gid=' do
+    let(:value) { 'new_pgrp' }
+
+    let(:old_pgrp) { 'old_pgrp' }
+    let(:cur_groups) { 'system,adm' }
+    before(:each) do
+      provider.stubs(:gid).returns(old_pgrp)
+      provider.stubs(:groups).returns(cur_groups)
+      provider.stubs(:set)
+    end
+
+    it 'raises a Puppet::Error if it fails to set the groups property' do
+      provider.stubs(:set)
+        .with(:groups, cur_groups)
+        .raises(Puppet::ExecutionFailure, 'failed to reset the groups!')
+
+      expect { provider.gid = value }.to raise_error do |error|
+        expect(error).to be_a(Puppet::Error)
+
+        expect(error.message).to match('groups')
+        expect(error.message).to match(cur_groups)
+        expect(error.message).to match(old_pgrp)
+        expect(error.message).to match(value)
+      end
+    end
+  end
+
   describe '#parse_password' do
     def call_parse_password
       File.open(my_fixture('aix_passwd_file.out')) do |f|
@@ -163,9 +202,11 @@ describe 'Puppet::Type::User::Provider::Aix' do
   describe '#create' do
     it 'should create the user' do
       provider.resource.stubs(:should).with(anything).returns(nil)
+      provider.resource.stubs(:should).with(:groups).returns('g1,g2')
       provider.resource.stubs(:should).with(:password).returns('password')
 
       provider.expects(:execute)
+      provider.expects(:groups=).with('g1,g2')
       provider.expects(:password=).with('password')
 
       provider.create