puppet 5.4.0-x64-mingw32 → 5.5.0-x64-mingw32

data/man/man8/puppet-node.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-NODE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-NODE" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-node\fR \- View and manage node definitions\.

data/man/man8/puppet-parser.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-PARSER" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-PARSER" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-parser\fR \- Interact directly with the parser\.
@@ -29,12 +29,11 @@ Whether to log debug information\.
 .
 .SH "ACTIONS"
 .
-.TP
-\fBdump\fR \- Outputs a dump of the internal parse tree for debugging
-\fBSYNOPSIS\fR
+.IP "\(bu" 4
+\fBdump\fR \- Outputs a dump of the internal parse tree for debugging: \fBSYNOPSIS\fR
 .
 .IP
-puppet parser dump [\-\-e \fIsource\fR] [\-\-[no\-]validate] \-e \fIsource\fR| [\fImanifest\fR \.\.\.]
+puppet parser dump [\-\-e \fIsource\fR] [\-\-[no\-]validate] [\-\-format \fIold, pn, or json\fR] [\-\-pretty] [\-\-format \fIold|pn|json\fR] [\-\-pretty] { \-e \fIsource\fR | [\fItemplates\fR \.\.\.] }
 .
 .IP
 \fBDESCRIPTION\fR
@@ -43,6 +42,23 @@ puppet parser dump [\-\-e \fIsource\fR] [\-\-[no\-]validate] \-e \fIsource\fR| [
 This action parses and validates the Puppet DSL syntax without compiling a catalog or syncing any resources\.
 .
 .IP
+The output format can be controlled using the \-\-format \fIold|pn|json\fR where:
+.
+.IP "\(bu" 4
+\'old\' is the default, but now deprecated format which is not API\.
+.
+.IP "\(bu" 4
+\'pn\' is the Puppet Extended S\-Expression Notation\.
+.
+.IP "\(bu" 4
+\'json\' outputs the same graph as \'pn\' but with JSON syntax\.
+.
+.IP "" 0
+.
+.IP
+The output will be "pretty printed" when the option \-\-pretty is given together with \-\-format \'pn\' or \'json\'\. This option has no effect on the \'old\' format\.
+.
+.IP
 The command accepts one or more manifests (\.pp) files, or an \-e followed by the puppet source text\. If no arguments are given, the stdin is read (unless it is attached to a terminal)
 .
 .IP
@@ -52,6 +68,12 @@ The output format of the dumped tree is intended for debugging purposes and is n
 \fBOPTIONS\fR \fI\-\-e <source\fR> \- dump one source expression given on the command line\.
 .
 .IP
+\fI\-\-format <old, pn, or json\fR> \- Get result in \'old\' (deprecated format), \'pn\' (new format), or \'json\' (new format in JSON)\.
+.
+.IP
+\fI\-\-pretty\fR \- Pretty print output\. Only applicable together with \-\-format pn or json
+.
+.IP
 \fI\-\-[no\-]validate\fR \- Whether or not to validate the parsed result, if no\-validate only syntax errors are reported
 .
 .IP
@@ -60,9 +82,8 @@ The output format of the dumped tree is intended for debugging purposes and is n
 .IP
 A dump of the resulting AST model unless there are syntax or validation errors\.
 .
-.TP
-\fBvalidate\fR \- Validate the syntax of one or more Puppet manifests\.
-\fBSYNOPSIS\fR
+.IP "\(bu" 4
+\fBvalidate\fR \- Validate the syntax of one or more Puppet manifests\.: \fBSYNOPSIS\fR
 .
 .IP
 puppet parser validate [\fImanifest\fR] [\fImanifest\fR \.\.\.]
@@ -82,6 +103,8 @@ When validating multiple issues per file are reported up to the settings of max_
 .IP
 Nothing, or the first syntax error encountered\.
 .
+.IP "" 0
+.
 .SH "EXAMPLES"
 \fBvalidate\fR
 .

data/man/man8/puppet-plugin.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-PLUGIN" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-PLUGIN" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-plugin\fR \- Interact with the Puppet plugin system\.

data/man/man8/puppet-report.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-REPORT" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-REPORT" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-report\fR \- Create, display, and submit reports\.

data/man/man8/puppet-resource.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-RESOURCE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-RESOURCE" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-resource\fR \- The resource abstraction layer shell

data/man/man8/puppet-script.8

@@ -0,0 +1,67 @@
+.\" generated with Ronn/v0.7.3
+.\" http://github.com/rtomayko/ronn/tree/0.7.3
+.
+.TH "PUPPET\-SCRIPT" "8" "March 2018" "Puppet, Inc." "Puppet manual"
+.
+.SH "NAME"
+\fBpuppet\-script\fR \- Run a puppet manifests as a script without compiling a catalog
+.
+.SH "SYNOPSIS"
+Runs a puppet language script without compiling a catalog\.
+.
+.SH "USAGE"
+puppet script [\-h|\-\-help] [\-V|\-\-version] [\-d|\-\-debug] [\-v|\-\-verbose] [\-e|\-\-execute] [\-l|\-\-logdest syslog|eventlog|\fIFILE\fR|console] [\-\-noop] \fIfile\fR
+.
+.SH "DESCRIPTION"
+This is a standalone puppet script runner tool; use it to run puppet code without compiling a catalog\.
+.
+.P
+When provided with a modulepath, via command line or config file, puppet script can load functions, types, tasks and plans from modules\.
+.
+.SH "OPTIONS"
+Note that any setting that\'s valid in the configuration file is also a valid long argument\. For example, \'environment\' is a valid setting, so you can specify \'\-\-environment mytest\' as an argument\.
+.
+.P
+See the configuration file documentation at https://docs\.puppetlabs\.com/puppet/latest/reference/configuration\.html for the full list of acceptable parameters\. A commented list of all configuration options can also be generated by running puppet with \'\-\-genconfig\'\.
+.
+.TP
+\-\-debug
+Enable full debugging\.
+.
+.TP
+\-\-help
+Print this help message
+.
+.TP
+\-\-logdest
+Where to send log messages\. Choose between \'syslog\' (the POSIX syslog service), \'eventlog\' (the Windows Event Log), \'console\', or the path to a log file\. Defaults to \'console\'\.
+.
+.IP
+A path ending with \'\.json\' will receive structured output in JSON format\. The log file will not have an ending \']\' automatically written to it due to the appending nature of logging\. It must be appended manually to make the content valid JSON\.
+.
+.TP
+\-\-noop
+Use \'noop\' mode where Puppet runs in a no\-op or dry\-run mode\. This is useful for seeing what changes Puppet will make without actually executing the changes\. Applies to tasks only\.
+.
+.TP
+\-\-execute
+Execute a specific piece of Puppet code
+.
+.TP
+\-\-verbose
+Print extra information\.
+.
+.SH "EXAMPLE"
+.
+.nf
+
+$ puppet script \-l /tmp/manifest\.log manifest\.pp
+$ puppet script \-\-modulepath=/root/dev/modules \-e \'notice("hello world")\'
+.
+.fi
+.
+.SH "AUTHOR"
+Henrik Lindberg
+.
+.SH "COPYRIGHT"
+Copyright (c) 2017 Puppet Inc\., LLC Licensed under the Apache 2\.0 License

data/man/man8/puppet-status.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-STATUS" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET\-STATUS" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-status\fR \- View puppet server status\.

data/man/man8/puppet.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
+.TH "PUPPET" "8" "March 2018" "Puppet, Inc." "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\fR
@@ -13,7 +13,7 @@ Usage: puppet \fIsubcommand\fR [options] \fIaction\fR [options]
 Available subcommands:
 .
 .P
-agent The puppet agent daemon apply Apply Puppet manifests locally ca Local Puppet Certificate Authority management\. (Deprecated) catalog Compile, save, view, and convert catalogs\. cert Manage certificates and requests certificate Provide access to the CA for certificate management\. certificate_request Manage certificate requests\. (Deprecated) certificate_revocation_list Manage the list of revoked certificates\. (Deprecated) config Interact with Puppet\'s settings\. describe Display help about resource types device Manage remote network devices doc Generate Puppet references epp Interact directly with the EPP template parser/renderer\. facts Retrieve and store facts\. filebucket Store and retrieve files in a filebucket generate Generates Puppet code from Ruby definitions\. help Display Puppet help\. key Create, save, and remove certificate keys\. (Deprecated) lookup Interactive Hiera lookup man Display Puppet manual pages\. master The puppet master daemon module Creates, installs and searches for modules on the Puppet Forge\. node View and manage node definitions\. parser Interact directly with the parser\. plugin Interact with the Puppet plugin system\. report Create, display, and submit reports\. resource The resource abstraction layer shell status View puppet server status\. (Deprecated)
+agent The puppet agent daemon apply Apply Puppet manifests locally ca Local Puppet Certificate Authority management\. (Deprecated) catalog Compile, save, view, and convert catalogs\. cert Manage certificates and requests certificate Provide access to the CA for certificate management\. certificate_request Manage certificate requests\. (Deprecated) certificate_revocation_list Manage the list of revoked certificates\. (Deprecated) config Interact with Puppet\'s settings\. describe Display help about resource types device Manage remote network devices doc Generate Puppet references epp Interact directly with the EPP template parser/renderer\. facts Retrieve and store facts\. filebucket Store and retrieve files in a filebucket generate Generates Puppet code from Ruby definitions\. help Display Puppet help\. key Create, save, and remove certificate keys\. (Deprecated) lookup Interactive Hiera lookup man Display Puppet manual pages\. (Deprecated) master The puppet master daemon module Creates, installs and searches for modules on the Puppet Forge\. node View and manage node definitions\. parser Interact directly with the parser\. plugin Interact with the Puppet plugin system\. report Create, display, and submit reports\. resource The resource abstraction layer shell script Run a puppet manifests as a script without compiling a catalog status View puppet server status\. (Deprecated)
 .
 .P
-See \'puppet help \fIsubcommand\fR \fIaction\fR\' for help on a specific subcommand action\. See \'puppet help \fIsubcommand\fR\' for help on a specific subcommand\. Puppet v5\.0\.0
+See \'puppet help \fIsubcommand\fR \fIaction\fR\' for help on a specific subcommand action\. See \'puppet help \fIsubcommand\fR\' for help on a specific subcommand\. Puppet v5\.5\.0

data/spec/fixtures/unit/pops/binder/bindings_composer/ok/modules/awesome2/lib/puppet_x/awesome2/echo_scheme_handler.rb

@@ -11,7 +11,7 @@ module PuppetX
         factory = ::Puppet::Pops::Binder::BindingsFactory
         bindings = factory.named_bindings("echo")
         bindings.bind.name(uri.path.gsub(/\//, '::')).to("echo: #{uri.path.gsub(/\//, ' ').strip!}")
-        result = factory.contributed_bindings("echo", bindings.model) ### , nil)
+        factory.contributed_bindings("echo", bindings.model) ### , nil)
       end
     end
   end

data/spec/integration/application/apply_spec.rb

@@ -470,13 +470,13 @@ class amod::bad_type {
         catalog = compile_to_catalog(execute, node)
         apply = Puppet::Application[:apply]
         apply.options[:catalog] = file_containing('manifest', catalog.to_json)
-        apply.expects(:apply_catalog).with do |catalog|
-          catalog.resource(:notify, 'rx')['message'].is_a?(String)
-          catalog.resource(:notify, 'bin')['message'].is_a?(String)
-          catalog.resource(:notify, 'ver')['message'].is_a?(String)
-          catalog.resource(:notify, 'vrange')['message'].is_a?(String)
-          catalog.resource(:notify, 'tspan')['message'].is_a?(String)
-          catalog.resource(:notify, 'tstamp')['message'].is_a?(String)
+        apply.expects(:apply_catalog).with do |cat|
+          cat.resource(:notify, 'rx')['message'].is_a?(String)
+          cat.resource(:notify, 'bin')['message'].is_a?(String)
+          cat.resource(:notify, 'ver')['message'].is_a?(String)
+          cat.resource(:notify, 'vrange')['message'].is_a?(String)
+          cat.resource(:notify, 'tspan')['message'].is_a?(String)
+          cat.resource(:notify, 'tstamp')['message'].is_a?(String)
         end
         apply.run
       end
@@ -493,7 +493,7 @@ class amod::bad_type {
 
       it 'will log a warning that a value of unknown type is converted into a string' do
         logs = []
-        json = Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
+        Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
           compile_to_catalog('include amod::bad_type', node).to_json
         end
         logs = logs.select { |log| log.level == :warning }.map { |log| log.message }
@@ -509,13 +509,13 @@ class amod::bad_type {
         catalog = compile_to_catalog(execute, node)
         apply = Puppet::Application[:apply]
         apply.options[:catalog] = file_containing('manifest', catalog.to_json)
-        apply.expects(:apply_catalog).with do |catalog|
-          catalog.resource(:notify, 'rx')['message'].is_a?(Regexp)
-          catalog.resource(:notify, 'bin')['message'].is_a?(Puppet::Pops::Types::PBinaryType::Binary)
-          catalog.resource(:notify, 'ver')['message'].is_a?(SemanticPuppet::Version)
-          catalog.resource(:notify, 'vrange')['message'].is_a?(SemanticPuppet::VersionRange)
-          catalog.resource(:notify, 'tspan')['message'].is_a?(Puppet::Pops::Time::Timespan)
-          catalog.resource(:notify, 'tstamp')['message'].is_a?(Puppet::Pops::Time::Timestamp)
+        apply.expects(:apply_catalog).with do |cat|
+          cat.resource(:notify, 'rx')['message'].is_a?(Regexp)
+          cat.resource(:notify, 'bin')['message'].is_a?(Puppet::Pops::Types::PBinaryType::Binary)
+          cat.resource(:notify, 'ver')['message'].is_a?(SemanticPuppet::Version)
+          cat.resource(:notify, 'vrange')['message'].is_a?(SemanticPuppet::VersionRange)
+          cat.resource(:notify, 'tspan')['message'].is_a?(Puppet::Pops::Time::Timespan)
+          cat.resource(:notify, 'tstamp')['message'].is_a?(Puppet::Pops::Time::Timestamp)
         end
         apply.run
       end

data/spec/integration/application/lookup_spec.rb

@@ -90,6 +90,27 @@ describe 'lookup' do
       expect(lookup('a')).to eql('value a')
     end
 
+    context 'uses node_terminus' do
+      require 'puppet/indirector/node/exec'
+      require 'puppet/indirector/node/plain'
+
+      let(:node) { Puppet::Node.new('testnode', :environment => env) }
+
+      it ':plain without --compile' do
+        Puppet.settings[:node_terminus] = 'exec'
+        Puppet::Node::Plain.any_instance.expects(:find).returns(node)
+        Puppet::Node::Exec.any_instance.expects(:find).never
+        expect(lookup('a')).to eql('value a')
+      end
+
+      it 'configured in Puppet settings with --compile' do
+        Puppet.settings[:node_terminus] = 'exec'
+        Puppet::Node::Plain.any_instance.expects(:find).never
+        Puppet::Node::Exec.any_instance.expects(:find).returns(node)
+        expect(lookup('a', :compile => true)).to eql('value a')
+      end
+    end
+
     context 'configured with the wrong environment' do
       let(:env) { Puppet::Node::Environment.create(env_name.to_sym, [File.join(populated_env_dir, env_name, 'modules')]) }
       it 'does not find data in non-existing environment' do

data/spec/integration/faces/config_spec.rb

@@ -57,11 +57,21 @@ rando_key=foobar
   end
 
   context 'when getting / setting UTF8 values' do
+
+    let(:config) { described_class }
+
+    def render(action, result)
+      config.get_action(action).when_rendering(:console).call(result)
+    end
+
+    before :each do
+      subject.stubs(:report_section_and_environment)
+    end
+
     # key must be a defined setting
     ['rando_key', MIXED_UTF8].each do |key|
       it "can change '#{key}' keyed ASCII value to a UTF-8 value and read it back" do
-        key = "rando_key"
-        value = "value#{MIXED_UTF8.reverse}value"
+        value = "value#{key.reverse}value"
 
         # needed for the subject.set to write to correct file
         Puppet.settings.stubs(:which_configuration_file).returns(tmp_config)
@@ -72,8 +82,10 @@ rando_key=foobar
         # instead of the default Puppet.settings (implementation detail)
         Puppet.stubs(:settings).returns(test_settings)
 
-        expect { subject.print() }.to have_printed("#{key} = #{value}")
-        expect { subject.print(key, :section => 'main') }.to have_printed("#{value}")
+        result = subject.print()
+        expect(render(:print, result)).to match(/^#{key} = #{value}$/)
+        result = subject.print(key, :section => 'main')
+        expect(render(:print, result)).to eq("#{value}\n")
       end
     end
   end

data/spec/integration/network/http/api/indirected_routes_spec.rb

@@ -7,7 +7,7 @@ require 'puppet/network/http/rack/rest'
 require 'puppet/indirector_proxy'
 require 'puppet_spec/files'
 require 'puppet_spec/network'
-require 'json'
+require 'puppet/util/json'
 
 describe Puppet::Network::HTTP::API::IndirectedRoutes do
   include PuppetSpec::Files
@@ -33,7 +33,7 @@ describe Puppet::Network::HTTP::API::IndirectedRoutes do
                                          {:accept_header => 'unknown, text/pson'},
                                          {:environment => 'production', :checksum_type => checksum_type})
           handler.call(request, response)
-          resp = JSON.parse(response.body)
+          resp = Puppet::Util::Json.load(response.body)
 
           expect(resp['checksum']['type']).to eq(checksum_type)
           expect(checksum_valid(checksum_type, checksum, resp['checksum']['value'])).to be_truthy
@@ -44,7 +44,7 @@ describe Puppet::Network::HTTP::API::IndirectedRoutes do
                                             {:accept_header => 'unknown, text/pson'},
                                             {:environment => 'production', :checksum_type => checksum_type, :recurse => 'yes'})
           handler.call(request, response)
-          resp = JSON.parse(response.body)
+          resp = Puppet::Util::Json.load(response.body)
 
           expect(resp.length).to eq(2)
           file = resp.find {|x| x['relative_path'] == 'file.rb'}
@@ -67,7 +67,7 @@ describe Puppet::Network::HTTP::API::IndirectedRoutes do
           handler.process(request, response)
 
           expect(response.header["Content-Type"]).to match(/json/)
-          resp = JSON.parse(response.body.first)
+          resp = Puppet::Util::Json.load(response.body.first)
           expect(resp["message"]).to match(/The indirection name must be purely alphanumeric/)
           expect(resp["issue_kind"]).to be_a_kind_of(String)
         end
@@ -79,7 +79,7 @@ describe Puppet::Network::HTTP::API::IndirectedRoutes do
           handler.process(request, response)
 
           expect(response.header["Content-Type"]).to match(/json/)
-          resp = JSON.parse(response.body.first)
+          resp = Puppet::Util::Json.load(response.body.first)
           expect(resp["message"]).to match(/Could not find indirection/)
           expect(resp["issue_kind"]).to be_a_kind_of(String)
         end

data/spec/integration/parser/catalog_spec.rb

@@ -90,7 +90,7 @@ describe "A catalog" do
   end
 
   def master_catalog_for(manifest)
-    master_catalog = Puppet::Resource::Catalog::Compiler.new.filter(compile_to_catalog(manifest, node))
+    Puppet::Resource::Catalog::Compiler.new.filter(compile_to_catalog(manifest, node))
   end
 
   def master_and_agent_catalogs_for(manifest)

data/spec/integration/parser/collection_spec.rb

@@ -180,7 +180,7 @@ describe 'collectors' do
     it "does not collect classes" do
       node = Puppet::Node.new('the node')
       expect do
-        catalog = compile_to_catalog(<<-MANIFEST, node)
+        compile_to_catalog(<<-MANIFEST, node)
           class theclass {
             @notify { "testing": message => "good message" }
           }
@@ -192,7 +192,7 @@ describe 'collectors' do
     it "does not collect resources that don't exist" do
       node = Puppet::Node.new('the node')
       expect do
-        catalog = compile_to_catalog(<<-MANIFEST, node)
+        compile_to_catalog(<<-MANIFEST, node)
           class theclass {
             @notify { "testing": message => "good message" }
           }

data/spec/integration/parser/compiler_spec.rb

@@ -259,7 +259,7 @@ describe Puppet::Parser::Compiler do
     it "should not create duplicate resources when a class is referenced both directly and indirectly by the node classifier (4792)" do
       node = Puppet::Node.new("testnodex")
       node.classes = ['foo', 'bar']
-      catalog = compile_to_catalog(<<-PP, node)
+      compile_to_catalog(<<-PP, node)
         class foo
         {
           notify { foo_notify: }
@@ -401,7 +401,7 @@ describe Puppet::Parser::Compiler do
 
       it "should not favor local name scope" do
         expect {
-          catalog = compile_to_catalog(<<-PP)
+          compile_to_catalog(<<-PP)
             class experiment {
               class baz {
               }
@@ -683,7 +683,7 @@ describe Puppet::Parser::Compiler do
 
       it 'an initial underscore in not ok if elsewhere than last segment' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class a { $_a = 10}
             include a
             notify { 'test': message => $_a::_a }
@@ -769,7 +769,7 @@ describe Puppet::Parser::Compiler do
 
       it 'accepts anything when parameters are untyped' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
           define foo($a, $b, $c) { }
           foo { 'test': a => String, b=>10, c=>undef }
           MANIFEST
@@ -778,7 +778,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies non type compliant arguments' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(Integer $x) { }
             foo { 'test': x =>'say friend' }
           MANIFEST
@@ -787,7 +787,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies undef for a non-optional type' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(Integer $x) { }
             foo { 'test': x => undef }
           MANIFEST
@@ -796,7 +796,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies non type compliant default argument' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(Integer $x = 'pow') { }
             foo { 'test':  }
           MANIFEST
@@ -805,7 +805,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies undef as the default for a non-optional type' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(Integer $x = undef) { }
             foo { 'test':  }
           MANIFEST
@@ -826,7 +826,7 @@ describe Puppet::Parser::Compiler do
 
       it 'uses infer_set when reporting type mismatch' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(Struct[{b => Integer, d=>String}] $a) { }
             foo{ bar: a => {b => 5, c => 'stuff'}}
           MANIFEST
@@ -855,7 +855,7 @@ describe Puppet::Parser::Compiler do
 
       it 'accepts anything when parameters are untyped' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo($a, $b, $c) { }
             class { 'foo': a => String, b=>10, c=>undef }
           MANIFEST
@@ -864,7 +864,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies non type compliant arguments' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo(Integer $x) { }
             class { 'foo': x =>'say friend' }
           MANIFEST
@@ -873,7 +873,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies undef for a non-optional type' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo(Integer $x) { }
             class { 'foo': x => undef }
           MANIFEST
@@ -882,7 +882,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies non type compliant default argument' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo(Integer $x = 'pow') { }
             class { 'foo':  }
           MANIFEST
@@ -891,7 +891,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies undef as the default for a non-optional type' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo(Integer $x = undef) { }
             class { 'foo':  }
           MANIFEST
@@ -900,7 +900,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies a regexp (rich data) argument given to class String parameter (even if later encoding of it is a string)' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             class foo(String $x) { }
             class { 'foo':  x => /I am a regexp and I don't want to be a String/}
           MANIFEST
@@ -909,7 +909,7 @@ describe Puppet::Parser::Compiler do
 
       it 'denies a regexp (rich data) argument given to define String parameter (even if later encoding of it is a string)' do
         expect do
-          catalog = compile_to_catalog(<<-MANIFEST)
+          compile_to_catalog(<<-MANIFEST)
             define foo(String $x) { }
             foo { 'foo':  x => /I am a regexp and I don't want to be a String/}
           MANIFEST
@@ -1162,7 +1162,7 @@ describe Puppet::Parser::Compiler do
     it 'errors when an alias cannot be found when relationship is formed with -> operator' do
       node = Puppet::Node.new("testnodex")
       expect {
-        catalog = compile_to_catalog(<<-PP, node)
+        compile_to_catalog(<<-PP, node)
           notify { 'actual_2':  }
           notify { 'actual_1': alias => 'alias_1' }
           Notify[actual_2] -> Notify[alias_2]
@@ -1190,7 +1190,6 @@ describe Puppet::Parser::Compiler do
         include foo
         include bar
       MANIFEST
-      package = catalog.resource('Package', 'pip')
       expect(catalog.resource('Package', 'pip')[:require].to_s).to eql('Package[python]')
     end