puppet 5.3.7 → 5.4.0

data/man/man8/puppet-filebucket.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-FILEBUCKET" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-FILEBUCKET" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-filebucket\fR \- Store and retrieve files in a filebucket
@@ -78,56 +78,38 @@ Print extra information\.
 \-\-version
 Print version information\.
 .
-.SH "EXAMPLES"
+.SH "EXAMPLE"
 .
 .nf
 
-## Backup a file to the filebucket, then restore it to a temporary directory
 $ puppet filebucket backup /etc/passwd
 /etc/passwd: 429b225650b912a2ee067b0a4cf1e949
 $ puppet filebucket restore /tmp/passwd 429b225650b912a2ee067b0a4cf1e949
-
 ## Diff between two files in the filebucket
 $ puppet filebucket \-l diff d43a6ecaa892a1962398ac9170ea9bf2 7ae322f5791217e031dc60188f4521ef
 1a2
 > again
-
-## Diff between the file in the filebucket and a local file
+## Diff between the file in the filebucket and the current one
 $ puppet filebucket \-l diff d43a6ecaa892a1962398ac9170ea9bf2 /tmp/testFile
 1a2
 > again
-
-## Backup a file to the filebucket and observe that it keeps each backup separate
 $ puppet filebucket \-l list
 d43a6ecaa892a1962398ac9170ea9bf2 2015\-05\-11 09:27:56 /tmp/TestFile
-
 $ echo again >> /tmp/TestFile
-
 $ puppet filebucket \-l backup /tmp/TestFile
 /tmp/TestFile: 7ae322f5791217e031dc60188f4521ef
-
-$ puppet filebucket \-l list
+$ puppet filebucket \-l  list
 d43a6ecaa892a1962398ac9170ea9bf2 2015\-05\-11 09:27:56 /tmp/TestFile
 7ae322f5791217e031dc60188f4521ef 2015\-05\-11 09:52:15 /tmp/TestFile
-
-## List files in a filebucket within date ranges
 $ puppet filebucket \-l \-f 2015\-01\-01 \-t 2015\-01\-11 list
 <Empty Output>
-
 $ puppet filebucket \-l \-f 2015\-05\-10 list
 d43a6ecaa892a1962398ac9170ea9bf2 2015\-05\-11 09:27:56 /tmp/TestFile
 7ae322f5791217e031dc60188f4521ef 2015\-05\-11 09:52:15 /tmp/TestFile
-
 $ puppet filebucket \-l \-f "2015\-05\-11 09:30:00" list
 7ae322f5791217e031dc60188f4521ef 2015\-05\-11 09:52:15 /tmp/TestFile
-
 $ puppet filebucket \-l \-t "2015\-05\-11 09:30:00" list
 d43a6ecaa892a1962398ac9170ea9bf2 2015\-05\-11 09:27:56 /tmp/TestFile
-
-## From a Puppet master, list files in the master bucketdir
-$ puppet filebucket \-b $(puppet config print bucketdir \-\-section master) list
-d43a6ecaa892a1962398ac9170ea9bf2 2015\-05\-11 09:27:56 /tmp/TestFile
-7ae322f5791217e031dc60188f4521ef 2015\-05\-11 09:52:15 /tmp/TestFile
 .
 .fi
 .

data/man/man8/puppet-generate.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-GENERATE" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-GENERATE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-generate\fR \- Generates Puppet code from Ruby definitions\.

data/man/man8/puppet-help.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-HELP" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-HELP" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-help\fR \- Display Puppet help\.

data/man/man8/puppet-key.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-KEY" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-KEY" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-key\fR \- Create, save, and remove certificate keys\.

data/man/man8/puppet-lookup.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-LOOKUP" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-LOOKUP" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-lookup\fR \- Interactive Hiera lookup

data/man/man8/puppet-man.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-MAN" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-MAN" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-man\fR \- Display Puppet manual pages\.

data/man/man8/puppet-master.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-MASTER" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-MASTER" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-master\fR \- The puppet master daemon

data/man/man8/puppet-module.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-MODULE" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-MODULE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-module\fR \- Creates, installs and searches for modules on the Puppet Forge\.
@@ -32,16 +32,7 @@ Whether to log debug information\.
 .
 .TP
 \-\-environment production
-The environment in which Puppet is running\. For clients, such as \fBpuppet agent\fR, this determines the environment itself, which Puppet uses to find modules and much more\. For servers, such as \fBpuppet master\fR, this provides the default environment for nodes that Puppet knows nothing about\.
-.
-.IP
-When defining an environment in the \fB[agent]\fR section, this refers to the environment that the agent requests from the master\. The environment doesn\'t have to exist on the local filesystem because the agent fetches it from the master\. This definition is used when running \fBpuppet agent\fR\.
-.
-.IP
-When defined in the \fB[user]\fR section, the environment refers to the path that Puppet uses to search for code and modules related to its execution\. This requires the environment to exist locally on the filesystem where puppet is being executed\. Puppet subcommands, including \fBpuppet module\fR and \fBpuppet apply\fR, use this definition\.
-.
-.IP
-Given that the context and effects vary depending on the config section \fIhttps://puppet\.com/docs/puppet/latest/config_file_main\.html#config\-sections\fR in which the \fBenvironment\fR setting is defined, do not set it globally\.
+The environment Puppet is running in\. For clients (e\.g\., \fBpuppet agent\fR) this determines the environment itself, which is used to find modules and much more\. For servers (i\.e\., \fBpuppet master\fR) this provides the default environment for nodes we know nothing about\.
 .
 .TP
 \-\-modulepath

data/man/man8/puppet-node.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-NODE" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-NODE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-node\fR \- View and manage node definitions\.

data/man/man8/puppet-parser.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-PARSER" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-PARSER" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-parser\fR \- Interact directly with the parser\.

data/man/man8/puppet-plugin.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-PLUGIN" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-PLUGIN" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-plugin\fR \- Interact with the Puppet plugin system\.

data/man/man8/puppet-report.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-REPORT" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-REPORT" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-report\fR \- Create, display, and submit reports\.

data/man/man8/puppet-resource.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-RESOURCE" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-RESOURCE" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-resource\fR \- The resource abstraction layer shell

data/man/man8/puppet-status.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET\-STATUS" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET\-STATUS" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\-status\fR \- View puppet server status\.

data/man/man8/puppet.8

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "PUPPET" "8" "May 2018" "Puppet, Inc." "Puppet manual"
+.TH "PUPPET" "8" "June 2017" "Puppet Labs, LLC" "Puppet manual"
 .
 .SH "NAME"
 \fBpuppet\fR
@@ -16,4 +16,4 @@ Available subcommands:
 agent The puppet agent daemon apply Apply Puppet manifests locally ca Local Puppet Certificate Authority management\. (Deprecated) catalog Compile, save, view, and convert catalogs\. cert Manage certificates and requests certificate Provide access to the CA for certificate management\. certificate_request Manage certificate requests\. (Deprecated) certificate_revocation_list Manage the list of revoked certificates\. (Deprecated) config Interact with Puppet\'s settings\. describe Display help about resource types device Manage remote network devices doc Generate Puppet references epp Interact directly with the EPP template parser/renderer\. facts Retrieve and store facts\. filebucket Store and retrieve files in a filebucket generate Generates Puppet code from Ruby definitions\. help Display Puppet help\. key Create, save, and remove certificate keys\. (Deprecated) lookup Interactive Hiera lookup man Display Puppet manual pages\. master The puppet master daemon module Creates, installs and searches for modules on the Puppet Forge\. node View and manage node definitions\. parser Interact directly with the parser\. plugin Interact with the Puppet plugin system\. report Create, display, and submit reports\. resource The resource abstraction layer shell status View puppet server status\. (Deprecated)
 .
 .P
-See \'puppet help \fIsubcommand\fR \fIaction\fR\' for help on a specific subcommand action\. See \'puppet help \fIsubcommand\fR\' for help on a specific subcommand\. Puppet v5\.3\.7
+See \'puppet help \fIsubcommand\fR \fIaction\fR\' for help on a specific subcommand action\. See \'puppet help \fIsubcommand\fR\' for help on a specific subcommand\. Puppet v5\.0\.0

data/spec/integration/application/lookup_spec.rb

@@ -90,27 +90,6 @@ describe 'lookup' do
       expect(lookup('a')).to eql('value a')
     end
 
-    context 'uses node_terminus' do
-      require 'puppet/indirector/node/exec'
-      require 'puppet/indirector/node/plain'
-
-      let(:node) { Puppet::Node.new('testnode', :environment => env) }
-
-      it ':plain without --compile' do
-        Puppet.settings[:node_terminus] = 'exec'
-        Puppet::Node::Plain.any_instance.expects(:find).returns(node)
-        Puppet::Node::Exec.any_instance.expects(:find).never
-        expect(lookup('a')).to eql('value a')
-      end
-
-      it 'configured in Puppet settings with --compile' do
-        Puppet.settings[:node_terminus] = 'exec'
-        Puppet::Node::Plain.any_instance.expects(:find).never
-        Puppet::Node::Exec.any_instance.expects(:find).returns(node)
-        expect(lookup('a', :compile => true)).to eql('value a')
-      end
-    end
-
     context 'configured with the wrong environment' do
       let(:env) { Puppet::Node::Environment.create(env_name.to_sym, [File.join(populated_env_dir, env_name, 'modules')]) }
       it 'does not find data in non-existing environment' do

data/spec/integration/parser/compiler_spec.rb

@@ -898,6 +898,24 @@ describe Puppet::Parser::Compiler do
         end.to raise_error(/Class\[Foo\]: parameter 'x' expects an Integer value, got Undef/)
       end
 
+      it 'denies a regexp (rich data) argument given to class String parameter (even if later encoding of it is a string)' do
+        expect do
+          catalog = compile_to_catalog(<<-MANIFEST)
+            class foo(String $x) { }
+            class { 'foo':  x => /I am a regexp and I don't want to be a String/}
+          MANIFEST
+        end.to raise_error(/Class\[Foo\]: parameter 'x' expects a String value, got Regexp/)
+      end
+
+      it 'denies a regexp (rich data) argument given to define String parameter (even if later encoding of it is a string)' do
+        expect do
+          catalog = compile_to_catalog(<<-MANIFEST)
+            define foo(String $x) { }
+            foo { 'foo':  x => /I am a regexp and I don't want to be a String/}
+          MANIFEST
+        end.to raise_error(/Foo\[foo\]: parameter 'x' expects a String value, got Regexp/)
+      end
+
       it 'accepts a Resource as a Type' do
         catalog = compile_to_catalog(<<-MANIFEST)
           define bar($text) { }

data/spec/integration/parser/script_compiler_spec.rb

@@ -0,0 +1,113 @@
+require 'puppet'
+require 'spec_helper'
+require 'puppet_spec/compiler'
+require 'matchers/resource'
+require 'puppet/parser/script_compiler'
+
+describe 'the script compiler' do
+  include PuppetSpec::Compiler
+  include PuppetSpec::Files
+  include Matchers::Resource
+  before(:each) do
+    Puppet[:tasks] = true
+  end
+
+  context "when used" do
+    let(:env_name) { 'testenv' }
+    let(:environments_dir) { Puppet[:environmentpath] }
+    let(:env_dir) { File.join(environments_dir, env_name) }
+    let(:manifest) { Puppet::Node::Environment::NO_MANIFEST }
+    let(:env) { Puppet::Node::Environment.create(env_name.to_sym, [File.join(populated_env_dir, 'modules')], manifest) }
+    let(:node) { Puppet::Node.new("test", :environment => env) }
+
+    let(:env_dir_files) {
+      {
+        'manifests' => {
+          'good.pp' => "'good'\n"
+        },
+        'modules' => {
+          'test' => {
+            'plans' => {
+               'run_me.pp' => 'plan test::run_me() { "worked2" }'
+            }
+          }
+        }
+      }
+    }
+
+    let(:populated_env_dir) do
+      dir_contained_in(environments_dir, env_name => env_dir_files)
+      PuppetSpec::Files.record_tmp(env_dir)
+      env_dir
+    end
+
+    let(:script_compiler) do
+      Puppet::Parser::ScriptCompiler.new(env, node.name)
+    end
+
+    context 'is configured such that' do
+      it 'returns what the script_compiler returns' do
+        Puppet[:code] = <<-CODE
+            42
+          CODE
+        expect(script_compiler.compile).to eql(42)
+      end
+
+      it 'referencing undefined variables raises an error' do
+        expect do
+          Puppet[:code] = <<-CODE
+              notice $rubyversion
+            CODE
+            Puppet::Parser::ScriptCompiler.new(env, 'test_node_name').compile
+
+        end.to raise_error(/Unknown variable: 'rubyversion'/)
+      end
+
+      it 'has strict=error behavior' do
+        expect do
+          Puppet[:code] = <<-CODE
+              notice({a => 10, a => 20})
+            CODE
+            Puppet::Parser::ScriptCompiler.new(env, 'test_node_name').compile
+
+        end.to raise_error(/The key 'a' is declared more than once/)
+      end
+
+      it 'performing a multi assign from a class reference raises an error' do
+        expect do
+          Puppet[:code] = <<-CODE
+              [$a] = Class[the_dalit]
+            CODE
+            Puppet::Parser::ScriptCompiler.new(env, 'test_node_name').compile
+
+        end.to raise_error(/The catalog operation 'multi var assignment from class' is only available when compiling a catalog/)
+      end
+    end
+
+    context 'when using environment manifest' do
+      context 'set to single file' do
+        let (:manifest) { "#{env_dir}/manifests/good.pp" }
+
+        it 'loads and evaluates' do
+          expect(script_compiler.compile).to eql('good')
+        end
+      end
+
+      context 'set to directory' do
+        let (:manifest) { "#{env_dir}/manifests" }
+
+        it 'fails with an error' do
+          expect{script_compiler.compile}.to raise_error(/manifest of environment 'testenv' appoints directory '.*\/manifests'. It must be a file/)
+        end
+      end
+
+      context 'set to non existing path' do
+        let (:manifest) { "#{env_dir}/manyfiests/good.pp" }
+
+        it 'fails with an error' do
+          expect{script_compiler.compile}.to raise_error(/manifest of environment 'testenv' appoints '.*\/good.pp'. It does not exist/)
+        end
+      end
+    end
+  end
+end

data/spec/integration/provider/mount_spec.rb

@@ -19,12 +19,14 @@ describe "mount provider (integration)", :unless => Puppet.features.microsoft_wi
     @fake_fstab = tmpfile('fstab')
     @current_options = "local"
     @current_device = "/dev/disk1s1"
+    Puppet[:digest_algorithm] = 'md5' 
     Puppet::Type.type(:mount).defaultprovider.stubs(:default_target).returns(@fake_fstab)
     Facter.stubs(:value).with(:hostname).returns('some_host')
     Facter.stubs(:value).with(:domain).returns('some_domain')
     Facter.stubs(:value).with(:kernel).returns('Linux')
     Facter.stubs(:value).with(:operatingsystem).returns('RedHat')
     Facter.stubs(:value).with(:osfamily).returns('RedHat')
+    Facter.stubs(:value).with(:fips_enabled).returns(false)
     Puppet::Util::ExecutionStub.set do |command, options|
       case command[0]
       when %r{/s?bin/mount}

data/spec/integration/type/file_spec.rb

@@ -479,7 +479,11 @@ describe Puppet::Type.type(:file), :uses_checksums => true do
 
   describe "when writing files" do
     shared_examples "files are backed up" do |resource_options|
-      it "should backup files to a filebucket when one is configured" do
+      it "should backup files to a filebucket when one is configured" do |example|
+        if Puppet::Util::Platform.windows? && ['sha512', 'sha384'].include?(example.metadata[:digest_algorithm])
+          skip "PUP-8257: Skip file bucket test on windows for #{example.metadata[:digest_algorithm]} due to long path names"
+        end
+
         filebucket = Puppet::Type.type(:filebucket).new :path => tmpfile("filebucket"), :name => "mybucket"
         file = described_class.new({:path => path, :backup => "mybucket", :content => "foo"}.merge(resource_options))
         catalog.add_resource file
@@ -562,7 +566,11 @@ describe Puppet::Type.type(:file), :uses_checksums => true do
         expect(File.read(File.join(backup, "foo"))).to eq("yay")
       end
 
-      it "should backup directories to filebuckets by backing up each file separately" do
+      it "should backup directories to filebuckets by backing up each file separately" do |example|
+        if Puppet::Util::Platform.windows? && ['sha512', 'sha384'].include?(example.metadata[:digest_algorithm])
+          skip "PUP-8257: Skip file bucket test on windows for #{example.metadata[:digest_algorithm]} due to long path names"
+        end
+        
         bucket = Puppet::Type.type(:filebucket).new :path => tmpfile("filebucket"), :name => "mybucket"
         file = described_class.new({:path => tmpfile("bucket_backs"), :backup => "mybucket", :content => "foo", :force => true}.merge(resource_options))
         catalog.add_resource file
@@ -1816,7 +1824,7 @@ describe Puppet::Type.type(:file), :uses_checksums => true do
     end
   end
 
-  [:md5, :sha256, :md5lite, :sha256lite].each do |checksum|
+  [:md5, :sha256, :md5lite, :sha256lite, :sha384, :sha512, :sha224].each do |checksum|
     describe "setting checksum_value explicitly with checksum #{checksum}" do
       let(:path) { tmpfile('target') }
       let(:contents) { 'yay' }