puppet 5.2.0 → 5.3.1

data/spec/unit/pops/validator/validator_spec.rb

@@ -574,6 +574,16 @@ describe "validating 4x" do
     end
   end
 
+  context 'uses a var pattern that is performant' do
+    it 'such that illegal VAR_NAME is not too slow' do
+      t = Time.now.nsec
+      result = '$hg_oais::archivematica::requirements::automation_tools::USER' =~ Puppet::Pops::Patterns::VAR_NAME
+      t2 = Time.now.nsec
+      expect(result).to be(nil)
+      expect(t2-t).to be < 1000000 # one ms as a check for very slow operation, is in fact at ~< 10 microsecond 
+    end
+  end
+
   def parse(source)
     Puppet::Pops::Parser::Parser.new.parse_string(source)
   end

data/spec/unit/settings/certificate_revocation_setting_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+require 'puppet/settings'
+require 'puppet/settings/certificate_revocation_setting'
+
+describe Puppet::Settings::CertificateRevocationSetting do
+  subject { described_class.new(:settings => stub('settings'), :desc => "test") }
+
+  it "is of type :certificate_revocation" do
+    expect(subject.type).to eq :certificate_revocation
+  end
+
+  describe "munging the value" do
+    ['true', true, 'chain'].each do |setting|
+      it "munges #{setting.inspect} to :chain" do
+        expect(subject.munge(setting)).to eq :chain
+      end
+    end
+
+    it "munges 'leaf' to :leaf" do
+      expect(subject.munge("leaf")).to eq :leaf
+    end
+
+    ['false', false, nil].each do |setting|
+      it "munges #{setting.inspect} to false" do
+        expect(subject.munge(setting)).to eq false
+      end
+    end
+
+    it "raises an error when given an unexpected object type" do
+        expect {
+          subject.munge(1)
+        }.to raise_error(Puppet::Settings::ValidationError, "Invalid certificate revocation value 1: must be one of 'true', 'chain', 'leaf', or 'false'")
+    end
+  end
+end
+

data/spec/unit/ssl/host_spec.rb

@@ -714,9 +714,27 @@ describe Puppet::SSL::Host do
         Puppet::SSL::CertificateRevocationList.indirection.stubs(:find).returns @crl
       end
 
-      describe "and 'certificate_revocation' is true" do
+      [true, 'chain'].each do |crl_setting|
+        describe "and 'certificate_revocation' is #{crl_setting}" do
+          before do
+            Puppet[:certificate_revocation] = crl_setting
+          end
+
+          it "should add the CRL" do
+            @store.expects(:add_crl).with "real_crl"
+            @host.ssl_store
+          end
+
+          it "should set the flags to OpenSSL::X509::V_FLAG_CRL_CHECK_ALL|OpenSSL::X509::V_FLAG_CRL_CHECK" do
+            @store.expects(:flags=).with(OpenSSL::X509::V_FLAG_CRL_CHECK_ALL|OpenSSL::X509::V_FLAG_CRL_CHECK)
+            @host.ssl_store
+          end
+        end
+      end
+
+      describe "and 'certificate_revocation' is leaf" do
         before do
-          Puppet[:certificate_revocation] = true
+          Puppet[:certificate_revocation] = 'leaf'
         end
 
         it "should add the CRL" do
@@ -724,8 +742,8 @@ describe Puppet::SSL::Host do
           @host.ssl_store
         end
 
-        it "should set the flags to OpenSSL::X509::V_FLAG_CRL_CHECK_ALL|OpenSSL::X509::V_FLAG_CRL_CHECK" do
-          @store.expects(:flags=).with OpenSSL::X509::V_FLAG_CRL_CHECK_ALL|OpenSSL::X509::V_FLAG_CRL_CHECK
+        it "should set the flags to OpenSSL::X509::V_FLAG_CRL_CHECK" do
+          @store.expects(:flags=).with(OpenSSL::X509::V_FLAG_CRL_CHECK)
           @host.ssl_store
         end
       end

data/spec/unit/transaction/report_spec.rb

@@ -199,6 +199,11 @@ describe Puppet::Transaction::Report do
   end
 
   describe "when computing exit status" do
+    it "should produce -1 if no metrics are present" do
+      report = Puppet::Transaction::Report.new("apply")
+      expect(report.exit_status).to eq(-1)
+    end
+
     it "should produce 2 if changes are present" do
       report = Puppet::Transaction::Report.new
       report.add_metric("changes", {"total" => 1})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-12 00:00:00.000000000 Z
+date: 2017-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: facter
@@ -701,6 +701,7 @@ files:
 - lib/puppet/settings/file_or_directory_setting.rb
 - lib/puppet/settings/duration_setting.rb
 - lib/puppet/settings/symbolic_enum_setting.rb
+- lib/puppet/settings/certificate_revocation_setting.rb
 - lib/puppet/settings/environment_conf.rb
 - lib/puppet/settings/server_list_setting.rb
 - lib/puppet/settings/ttl_setting.rb
@@ -2260,6 +2261,7 @@ files:
 - spec/unit/settings/environment_conf_spec.rb
 - spec/unit/settings/ini_file_spec.rb
 - spec/unit/settings/priority_setting_spec.rb
+- spec/unit/settings/certificate_revocation_setting_spec.rb
 - spec/unit/settings/file_setting_spec.rb
 - spec/unit/settings/array_setting_spec.rb
 - spec/unit/settings/duration_setting_spec.rb
@@ -3533,6 +3535,7 @@ test_files:
 - spec/unit/settings/environment_conf_spec.rb
 - spec/unit/settings/ini_file_spec.rb
 - spec/unit/settings/priority_setting_spec.rb
+- spec/unit/settings/certificate_revocation_setting_spec.rb
 - spec/unit/settings/file_setting_spec.rb
 - spec/unit/settings/array_setting_spec.rb
 - spec/unit/settings/duration_setting_spec.rb