puppet 4.5.3-x86-mingw32 → 4.6.1-x86-mingw32

data/lib/puppet/pops/parser/evaluating_parser.rb

@@ -55,7 +55,7 @@ class EvaluatingParser
 
   # Create a closure that can be called in the given scope
   def closure(model, scope)
-    Evaluator::Closure.new(evaluator, model, scope)
+    Evaluator::Closure::Dynamic.new(evaluator, model, scope)
   end
 
   def evaluate(scope, model)

data/lib/puppet/pops/parser/interpolation_support.rb

@@ -185,11 +185,18 @@ module Puppet::Pops::Parser::InterpolationSupport
     scn = @scanner
     ctx = @lexing_context
     queue = @token_queue
+    queue_base = @token_queue[0]
 
     scn.skip(self.class::PATTERN_WS)
     queue_size = queue.size
     until scn.eos? do
       if token = lex_token
+        if token.equal?(queue_base)
+          # A nested #interpolate_dq call shifted the queue_base token from the @token_queue. It must
+          # be put back since it is intended for the top level #interpolate_dq call only.
+          queue.insert(0, token)
+          next # all relevant tokens are already on the queue
+        end
         token_name = token[0]
         ctx[:after] = token_name
         if token_name == :RBRACE && ctx[:brace_count] == brace_count

data/lib/puppet/pops/parser/lexer2.rb

@@ -37,6 +37,7 @@ class Lexer2
   TOKEN_RBRACE       = [:RBRACE,       '}'.freeze,   1].freeze
   TOKEN_SELBRACE     = [:SELBRACE,     '{'.freeze,   1].freeze
   TOKEN_LPAREN       = [:LPAREN,       '('.freeze,   1].freeze
+  TOKEN_WSLPAREN     = [:WSLPAREN,     '('.freeze,   1].freeze
   TOKEN_RPAREN       = [:RPAREN,       ')'.freeze,   1].freeze
 
   TOKEN_EQUALS       = [:EQUALS,       '='.freeze,   1].freeze
@@ -219,7 +220,17 @@ class Lexer2
         end
       end,
       ']' => lambda { emit(TOKEN_RBRACK, @scanner.pos) },
-      '(' => lambda { emit(TOKEN_LPAREN, @scanner.pos) },
+      '(' => lambda do
+        before = @scanner.pos
+        # If first on a line, or only whitespace between start of line and '('
+        # then the token is special to avoid being taken as start of a call.
+        line_start = @lexing_context[:line_lexical_start]
+        if before == line_start || @scanner.string.byteslice(line_start, before - line_start) =~ /\A[[:blank:]\r]+\Z/
+          emit(TOKEN_WSLPAREN, before)
+        else
+          emit(TOKEN_LPAREN, before)
+        end
+      end,
       ')' => lambda { emit(TOKEN_RPAREN, @scanner.pos) },
       ';' => lambda { emit(TOKEN_SEMIC, @scanner.pos) },
       '?' => lambda { emit(TOKEN_QMARK, @scanner.pos) },
@@ -489,6 +500,7 @@ class Lexer2
         else
           @scanner.pos += 1
         end
+        ctx[:line_lexical_start] = @scanner.pos
         nil
       end,
       '' => lambda { nil } # when the peek(1) returns empty
@@ -656,6 +668,7 @@ class Lexer2
     @lexing_context = {
       :brace_count => 0,
       :after => nil,
+      :line_lexical_start => 0
     }
     appm_mode = Puppet[:app_management] ? :with_appm : :without_appm
     @appm_keywords = APP_MANAGEMENT_TOKENS[appm_mode]

data/lib/puppet/pops/parser/locator.rb

@@ -8,7 +8,7 @@ class Locator
   #
   def self.locator(string, file, index = nil, char_offsets = false)
     if char_offsets
-      LocatorForChars.new(string, file, index);
+      LocatorForChars.new(string, file, index)
     else
       Locator19.new(string, file, index)
     end
@@ -205,6 +205,15 @@ class Locator
       return low
     end
 
+    def hash
+      [string, file, line_index].hash
+    end
+
+    # Equal method needed by serializer to perform tabulation
+    def eql?(o)
+      self.class == o.class && string == o.string && file == o.file && line_index == o.line_index
+    end
+
     # Common impl for 18 and 19 since scanner is byte based
     def compute_line_index
       scanner = StringScanner.new(string)
@@ -262,6 +271,26 @@ class Locator
   # strings are frozen).
   #
   class Locator19 < AbstractLocator
+    include Types::PuppetObject
+
+    def self._ptype
+      @type
+    end
+
+    # The Locator is not part of the Ecore model so no ObjectType is automatically inferred. Instead the
+    # type is explicitly added here.
+    # TODO: LocatorForChars is never added. It looks like it could be removed (remnant from Ruby 1.8 compatibility?)
+    # @api private
+    def self.register_ptype(loader, ir)
+      @type = Pcore::create_object_type(loader, ir, self, 'Puppet::AST::Locator', 'Any',
+        'string' => Types::PStringType::DEFAULT,
+        'file' => Types::PStringType::DEFAULT,
+        'line_index' => {
+          Types::KEY_TYPE => Types::POptionalType.new(Types::PArrayType.new(Types::PIntegerType::DEFAULT)),
+          Types::KEY_VALUE => nil
+        }
+      ).resolve(Types::TypeParser.singleton, loader)
+    end
 
     # Returns the offset on line (first offset on a line is 0).
     # Ruby 19 is multibyte but has no character position methods, must use byteslice

data/lib/puppet/pops/parser/parser_support.rb

@@ -1,7 +1,6 @@
 require 'puppet/parser/functions'
 require 'puppet/parser/files'
 require 'puppet/resource/type_collection'
-require 'puppet/resource/type_collection_helper'
 require 'puppet/resource/type'
 require 'monitor'
 
@@ -22,8 +21,6 @@ class Parser
   #
   Factory = Model::Factory
 
-  include Puppet::Resource::TypeCollectionHelper
-
   attr_accessor :lexer
   attr_reader :definitions
 

data/lib/puppet/pops/parser/slurp_support.rb

@@ -11,9 +11,9 @@ module Parser
 module SlurpSupport
   include LexerSupport
 
-  SLURP_SQ_PATTERN  = /(?:[^\\]|^|[^\\])(?:[\\]{2})*[']/
-  SLURP_DQ_PATTERN  = /(?:[^\\]|^|[^\\])(?:[\\]{2})*(["]|[$]\{?)/
-  SLURP_UQ_PATTERN  = /(?:[^\\]|^|[^\\])(?:[\\]{2})*([$]\{?|\z)/
+  SLURP_SQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*[']/
+  SLURP_DQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*(["]|[$]\{?)/
+  SLURP_UQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*([$]\{?|\z)/
   # unquoted, no escapes
   SLURP_UQNE_PATTERN  = /(\$\{?|\z)/m
   SLURP_ALL_PATTERN = /.*(\z)/m

data/lib/puppet/pops/patterns.rb

@@ -30,17 +30,25 @@ module Puppet::Pops::Patterns
   #
   CLASSREF_EXT = %r{\A((::){0,1}[A-Z][\w]*)+\z}
 
+  # Same as CLASSREF_EXT but cannot start with '::'
+  #
+  CLASSREF_EXT_DECL = %r{\A[A-Z][\w]*(?:::[A-Z][\w]*)*\z}
+
   # CLASSREF matches a class reference the way it is represented internally in the
   # model (i.e. in lower case).
   #
   CLASSREF = %r{\A((::){0,1}[a-z][\w]*)+\z}
 
+  # Same as CLASSREF but cannot start with '::'
+  #
+  CLASSREF_DECL = %r{\A[a-z][\w]*(?:::[a-z][\w]*)*\z}
+
   # DOLLAR_VAR matches a variable name including the initial $ character
   DOLLAR_VAR     = %r{\$(::)?(\w+::)*\w+}
 
   # VAR_NAME matches the name part of a variable (The $ character is not included)
   # Note, that only the final segment may start with an underscore.
-  VAR_NAME = %r{\A(:?(::)?[a-z]\w*)*(:?(::)?[a-z_]\w*)\z}
+  VAR_NAME = %r{\A(?:(::)?[a-z]\w*)*(?:(::)?[a-z_]\w*)\z}
 
   # PARAM_NAME matches the name part of a parameter (The $ character is not included)
   PARAM_NAME = %r{\A[a-z_]\w*\z}

data/lib/puppet/pops/pcore.rb

@@ -2,29 +2,85 @@ require 'uri'
 
 module Puppet::Pops
 module Pcore
-  TYPE_QUALIFIED_REFERENCE = Types::TypeFactory.pattern(Types::TypeFactory.regexp(Patterns::CLASSREF_EXT))
+  TYPE_URI_RX = Types::TypeFactory.regexp(URI.regexp)
+  TYPE_URI = Types::TypeFactory.pattern(TYPE_URI_RX)
+  TYPE_SIMPLE_TYPE_NAME = Types::TypeFactory.pattern(/\A[A-Z]\w*\z/)
+  TYPE_QUALIFIED_REFERENCE = Types::TypeFactory.pattern(/\A[A-Z][\w]*(?:::[A-Z][\w]*)*\z/)
+
+  KEY_PCORE_URI = 'pcore_uri'.freeze
+  KEY_PCORE_VERSION = 'pcore_version'.freeze
+
+  PCORE_URI = 'http://puppet.com/2016.1/pcore'
+  PCORE_VERSION = Semantic::Version.new(1,0,0)
+  PARSABLE_PCORE_VERSIONS = Semantic::VersionRange.parse('1.x')
+
+  RUNTIME_NAME_AUTHORITY = 'http://puppet.com/2016.1/runtime'
 
   def self.init(loader, ir)
-    add_alias('Puppet::Pcore::QualifiedReference', TYPE_QUALIFIED_REFERENCE, loader)
+    add_alias('Pcore::URI_RX', TYPE_URI_RX, loader)
+    add_alias('Pcore::URI', TYPE_URI, loader)
+    add_alias('Pcore::SimpleTypeName', TYPE_SIMPLE_TYPE_NAME, loader)
+    add_alias('Pcore::TypeName', TYPE_QUALIFIED_REFERENCE, loader)
+    add_alias('Pcore::QRef', TYPE_QUALIFIED_REFERENCE, loader)
+    Types::TypedModelObject.register_ptypes(loader, ir)
+
+    ir.register_implementation_namespace('Pcore', 'Puppet::Pops::Pcore', loader)
+    ir.register_implementation_namespace('Puppet::AST', 'Puppet::Pops::Model', loader)
+    ast_type_set = Serialization::RGen::TypeGenerator.new.generate_type_set('Puppet::AST', Puppet::Pops::Model, loader)
+
+    # Extend the Puppet::AST type set with the Locator (it's not an RGen class, but nevertheless, used in the model)
+    ast_ts_i12n = ast_type_set.i12n_hash
+    ast_ts_i12n['types'] = ast_ts_i12n['types'].merge('Locator' => Parser::Locator::Locator19.register_ptype(loader, ir))
+    add_type(Types::PTypeSetType.new(ast_ts_i12n), loader)
+
+    Resource.register_ptypes(loader, ir)
+  end
+
+  # Create and register a new `Object` type in the Puppet Type System and map it to an implementation class
+  #
+  # @param loader [Loader::Loader] The loader where the new type will be registered
+  # @param ir [ImplementationRegistry] The implementation registry that maps this class to the new type
+  # @param impl_class [Class] The class that is the implementation of the type
+  # @param type_name [String] The fully qualified name of the new type
+  # @param parent_name [String,nil] The fully qualified name of the parent type
+  # @param attributes_hash [Hash{String => Object}] A hash of attribute definitions for the new type
+  # @param functions_hash [Hash{String => Object}] A hash of function definitions for the new type
+  # @param equality [Array<String>] An array with names of attributes that participate in equality comparison
+  # @return [PObjectType] the created type. Not yet resolved
+  #
+  # @api private
+  def self.create_object_type(loader, ir, impl_class, type_name, parent_name, attributes_hash = EMPTY_HASH, functions_hash = EMPTY_HASH, equality = nil)
+    i12n_hash = {}
+    i12n_hash[Types::KEY_PARENT] = Types::PTypeReferenceType.new(parent_name) unless parent_name.nil?
+    i12n_hash[Types::KEY_ATTRIBUTES] = attributes_hash unless attributes_hash.empty?
+    i12n_hash[Types::KEY_FUNCTIONS] = functions_hash unless functions_hash.empty?
+    i12n_hash[Types::KEY_EQUALITY] = equality unless equality.nil?
+    ir.register_implementation(type_name, impl_class, loader)
+    add_type(Types::PObjectType.new(type_name, i12n_hash), loader)
+  end
 
-    ir.register_implementation_namespace('Puppet::Pcore', 'Puppet::Pops::Pcore', loader)
+  def self.add_object_type(name, body, loader)
+    add_type(Types::PObjectType.new(name, Parser::EvaluatingParser.new.parse_string(body).current.body), loader)
   end
 
-  def self.add_alias(name, type, loader)
-    add_type(Types::PTypeAliasType.new(name, nil, type), loader)
+  def self.add_alias(name, type, loader, name_authority = RUNTIME_NAME_AUTHORITY)
+    add_type(Types::PTypeAliasType.new(name, nil, type), loader, name_authority)
   end
 
-  def self.add_type(type, loader)
-    loader.set_entry(Loader::Loader::TypedName.new(:type, type.name.downcase), type)
+  def self.add_type(type, loader, name_authority = RUNTIME_NAME_AUTHORITY)
+    loader.set_entry(Loader::TypedName.new(:type, type.name.downcase, name_authority), type)
+    type
   end
 
-  def self.register_implementations(*impls)
-    Loaders.loaders.register_implementations(*impls)
+  def self.register_implementations(impls, name_authority = RUNTIME_NAME_AUTHORITY)
+    Loaders.loaders.register_implementations(impls, name_authority = RUNTIME_NAME_AUTHORITY)
   end
 
-  def self.register_aliases(aliases)
+  def self.register_aliases(aliases, name_authority = RUNTIME_NAME_AUTHORITY)
     loader = Loaders.loaders.private_environment_loader
-    aliases.each { |name, type_string| add_type(Types::PTypeAliasType.new(name, Types::TypeFactory.type_reference(type_string), nil), loader) }
+    aliases.each do |name, type_string|
+      add_type(Types::PTypeAliasType.new(name, Types::TypeFactory.type_reference(type_string), nil), loader, name_authority)
+    end
   end
 end
 end

data/lib/puppet/pops/puppet_stack.rb

@@ -0,0 +1,43 @@
+module Puppet::Pops
+# Module for making a call such that there is an identifiable entry on
+# the ruby call stack enabling getting a puppet call stack
+# To use this make a call with:
+# ```
+# Puppet::Pops::PuppetStack.stack(file, line, receiver, message, args)
+# ```
+# To get the stack call:
+# ```
+# Puppet::Pops::PuppetStack.stacktrace
+#
+# When getting a backtrace in Ruby, the puppet stack frames are
+# identified as coming from "in 'stack'" and having a ".pp" file
+# name.
+# To support testing, a given file that is an empty string, or nil
+# as well as a nil line number are supported. Such stack frames
+# will be represented with the text `unknown` and `0´ respectively.
+#
+module PuppetStack
+  # Sends a message to an obj such that it appears to come from
+  # file, line when calling stacktrace.
+  #
+  def self.stack(file, line, obj, message, args, &block)
+    file = '' if file.nil?
+    line = 0 if line.nil?
+
+    if block_given?
+      Kernel.eval("obj.send(message, *args, &block)", Kernel.binding(), file, line)
+    else
+      Kernel.eval("obj.send(message, *args)", Kernel.binding(), file, line)
+    end
+  end
+
+  def self.stacktrace
+    result = caller().reduce([]) do |memo, loc|
+      if loc =~ /^(.*\.pp)?:([0-9]+):in `stack'/
+        memo << [$1.nil? ? 'unknown' : $1, $2.to_i]
+      end
+      memo
+    end.reverse
+  end
+end
+end

data/lib/puppet/pops/resource/param.rb

@@ -0,0 +1,51 @@
+# An implementation of the interface Puppet::Resource
+# that adapts the 3.x compiler and catalog expectations on
+# a resource instance. This instance is backed by a
+# pcore representation of the resource type an instance of this
+# ruby class.
+#
+# This class must inherit from Puppet::Resource because of the
+# class expectations in existing logic.
+#
+# This implementation does not support
+# * setting 'strict' - strictness (must refer to an existing type) is always true
+# * does not support the indirector
+# 
+#
+module Puppet::Pops
+module Resource
+class Param
+  # This make this class instantiateable from Puppet
+  include Puppet::Pops::Types::PuppetObject
+
+  def self.register_ptype(loader, ir)
+    @ptype = Pcore::create_object_type(loader, ir, self, 'Puppet::Resource::Param', nil,
+      {
+        Types::KEY_TYPE => Types::PType::DEFAULT,
+        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
+        'name_var' => {
+          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
+          Types::KEY_VALUE => false
+        }
+      },
+      EMPTY_HASH,
+      [Types::KEY_NAME]
+    )
+  end
+
+  attr_reader :name
+  attr_reader :type
+  attr_reader :name_var
+
+  def initialize(type, name, name_var = false)
+    @type = type
+    @name = name
+    @name_var = name_var
+  end
+
+  def self._ptype
+    @ptype
+  end
+end
+end
+end

data/lib/puppet/pops/resource/resource_type_impl.rb

@@ -0,0 +1,301 @@
+require_relative 'param'
+
+module Puppet::Pops
+module Resource
+
+def self.register_ptypes(loader, ir)
+  types = [Param, ResourceTypeImpl].map do |c|
+    c.register_ptype(loader, ir)
+  end
+  types.each {|t| t.resolve(Types::TypeParser.singleton, loader) }
+end
+
+class ResourceTypeImpl
+  # Make instances of this class directly createable from the Puppet Language
+  # as object.
+  #
+  include Puppet::Pops::Types::PuppetObject
+
+  # Instances of ResourceTypeImpl can be used as the type of a Puppet::Parser::Resource/Puppet::Resource when compiling
+  #
+  include Puppet::CompilableResourceType
+
+  # Returns the Puppet Type for this instance.
+  def self._ptype
+    @ptype
+  end
+
+  def self.register_ptype(loader, ir)
+    param_ref = Types::PTypeReferenceType.new('Puppet::Resource::Param')
+    @ptype = Pcore::create_object_type(loader, ir, self, 'Puppet::Resource::ResourceType3', nil,
+      {
+        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
+        'properties' => {
+          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
+          Types::KEY_VALUE => EMPTY_ARRAY
+        },
+        'parameters' => {
+          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
+          Types::KEY_VALUE => EMPTY_ARRAY
+        },
+        'title_patterns_hash' => {
+          Types::KEY_TYPE => Types::POptionalType.new(
+            Types::PHashType.new(Types::PRegexpType::DEFAULT, Types::PArrayType.new(Types::PStringType::NON_EMPTY))),
+          Types::KEY_VALUE => nil
+        },
+        'isomorphic' => {
+          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
+          Types::KEY_VALUE => true
+        },
+      },
+      EMPTY_HASH,
+      [Types::KEY_NAME]
+    )
+  end
+
+  # Compares this type against the given _other_ (type) and returns -1, 0, or +1 depending on the order.
+  # @param other [Object] the object to compare against (produces nil, if not kind of Type}
+  # @return [-1, 0, +1, nil] produces -1 if this type is before the given _other_ type, 0 if equals, and 1 if after.
+  #   Returns nil, if the given _other_ is not a kind of Type.
+  # @see Comparable
+  #
+  def <=>(other)
+    # Order is only maintained against other types, not arbitrary objects.
+    # The natural order is based on the reference name used when comparing
+    return nil unless other.is_a?(Puppet::CompilableResourceType)
+    # against other type instances.
+    self.ref <=> other.ref
+  end
+
+  METAPARAMS = [
+    :noop,
+    :schedule,
+    :audit,
+    :loglevel,
+    :alias,
+    :tag,
+    :require,
+    :subscribe,
+    :before,
+    :notify,
+    :stage,
+    :export,
+    :consume
+    ].freeze
+
+  # Speed up lookup
+  METAPARAMSET = Set.new(METAPARAMS).freeze
+
+  attr_reader :name
+  attr_reader :properties
+  attr_reader :parameters
+  attr_reader :title_patterns_hash
+  attr_reader :title_patterns
+  attr_reader :isomorphic
+
+  def initialize(name, properties = EMPTY_ARRAY, parameters = EMPTY_ARRAY, title_patterns_hash = nil, isomorphic = true)
+    @name = name
+    @properties = properties
+    @parameters = parameters
+    @title_patterns_hash = title_patterns_hash
+    @isomorphic = isomorphic
+
+    # Compute attributes hash
+    # Compute key_names (possibly compound key if there are multiple name vars).
+    @attributes = {}
+    @key_attributes = []
+
+    # Name to kind of attribute
+    @attr_types = {}
+
+    # Add all meta params
+    METAPARAMS.each {|p| @attr_types[p] = :meta }
+
+    @property_set = Set.new(properties.map do |p|
+      symname = p.name.to_sym
+      @attributes[symname] = p
+      @key_attributes << symname if p.name_var
+      @attr_types[symname] = :property
+      symname
+    end).freeze
+
+    @param_set = Set.new(parameters.map do |p|
+      symname = p.name.to_sym
+      @attributes[symname] = p
+      @key_attributes << symname if p.name_var
+      @attr_types[symname] = :param
+      symname
+    end).freeze
+
+    # API for title patterns is [ [regexp, [ [ [sym, <lambda>], [sym, <lambda>] ] ] ] ]
+    # Where lambdas are optional. This resource type impl does not support lambdas
+    # Note that the pcore file has a simpler hashmap that is post processed here
+    # since the structure must have Symbol instances for names which the .pp representation
+    # does not deliver.
+    #
+    @title_patterns =
+      case @key_attributes.length
+      when 0
+        # TechDebt: The case of specifying title patterns when having no name vars is unspecified behavior in puppet
+        # Here it is silently ignored.
+        []
+      when 1
+        if @title_pattners_hash.nil?
+          [ [ /(.*)/m, [ [@key_attributes.first] ] ] ]
+        else
+          # TechDebt: The case of having one namevar and an empty title patterns is unspecified behavior in puppet.
+          # Here, it may lead to an empty map which may or may not trigger the wanted/expected behavior.
+          #
+          @title_patterns_hash.map {|k,v| [ k, [ v.map {|n| n.to_sym } ] ] }
+        end
+      else
+        if @title_patterns_hash.nil? || @title_patterns_hash.empty?
+          # TechDebt: While title patterns must be specified when more than one is used, they do not have
+          # to match/set them all since some namevars can be omitted (to support the use case in
+          # the 'package' type where 'provider' attribute is handled as part of the key without being
+          # set from the title.
+          #
+          raise Puppet::DevError,"you must specify title patterns when there are two or more key attributes"
+        end
+        @title_patterns_hash.nil? ? [] : @title_patterns_hash.map {|k,v| [ k, [ v.map {|n| n.to_sym } ] ] }
+      end
+  end
+
+  # Override CompilableResource inclusion
+  def is_3x_ruby_plugin?
+    false
+  end
+
+  # Answers if the parameter name is a parameter/attribute of this type
+  # This is part of the Puppet::Type API
+  # Check if used when compiling (it is triggered in an apply)
+  #
+  def valid_parameter?(name)
+    @attributes.include?(name) || METAPARAMSET.include?(name)
+  end
+
+  # The type implementation of finish does a lot of things
+  # * iterates over all parameters and calls post_compile on them if the parameter impl responds to post_compile
+  # * validates the relationship parameters
+  #
+  # This implementation does nothing - it is assumed that the catalog is already validated
+  # via the relationship validator (done late in the game).
+  def finish()
+    # Do nothing.
+  end
+
+  # This is called on a resource type
+  # it performs tagging if it is a Class or Node.
+  # It also ensure the parent type is in the catalog, but that is weird since
+  # resource types cannot really inherit
+  def instantiate_resource(scope, resource)
+    # Do nothing because nothing is needed when compiling.
+
+    # This is what the Puppet::Type implementation does
+    # None of this should be needed
+
+      #    # Make sure our parent class has been evaluated, if we have one.
+      #    if parent && !scope.catalog.resource(resource.type, parent)
+      #      parent_type(scope).ensure_in_catalog(scope)
+      #    end
+
+    # This will never happen
+
+      #    if ['Class', 'Node'].include? resource.type
+      #      scope.catalog.tag(*resource.tags)
+      #    end
+  end
+
+  # Being isomorphic in puppet means that the resource is managing a state
+  # (as opposed to a resource like Exec that is a function, possibly with side effect.
+  # In a Ruby implementation of a resource type, @isomorphic = false is used to turn
+  # off isomorphism, it is true by default.
+  # This is part of the Puppet::Type API.
+  #
+  def isomorphic?
+    @isomorphic
+  end
+
+  # Produces the names of the attributes that make out the unique id of a resource
+  #
+  def key_attributes
+    @key_attributes
+  end
+
+  # Gives a type a chance to issue deprecations for parameters.
+  # @param title [String] the title of the resource of this type
+  # @param attributes [Array<Param>] the set parameters in the resource instance
+  def deprecate_params(title, attributes)
+    # TODO: Current API somewhat unclear, if done at type level, or per
+    #       Param.
+  end
+
+  #######################
+  # UNSUPPORTED STUFF
+  #######################
+
+  # Applications are not supported
+  def application?
+    false
+  end
+
+  ############################
+  # DON'T KNOW YET
+  ############################
+
+
+  ##################################################
+  # NEVER CALLED COMPILE SIDE FOR A COMPILATION
+  ##################################################
+
+  # Answers :property, :param or :meta depending on the type of the attribute
+  # According to original version, this is called millions of times
+  # and a cache is required. 
+  # @param name [Symbol]
+  def attrtype(name)
+    raise NotImplementedError, "attrtype() - returns the kind (:meta, :param, or :property) of the parameter"
+    # @attr_types[name]
+  end
+
+  # Returns the implementation of a param/property/attribute - i.e. a Param class
+  def attrclass(name)
+    raise NotImplementedError, "attrclass() - returns the (param) class of the parameter"
+  end
+
+  # PROBABLY NOT USED WHEN COMPILING
+  # Returns the names of all attributes in a defined order:
+  # * all key attributes (the composite id)
+  # * :provider if it is specified
+  # * all properties
+  # * all parameters
+  # * meta parameters
+  #
+  def allattrs
+    raise NotImplementedError, "allattrs() - return all attribute names in order - probably not used master side"
+    # key_attributes | (parameters & [:provider]) | properties.collect { |property| property.name } | parameters | metaparams
+  end
+
+  # Sets "applies to host"
+  def apply_to
+    raise NotImplementedError, "apply_to() - probably used when selecting a provider (device/host support)"
+  end
+
+  def apply_to_host
+    raise NotImplementedError, "apply_to_host() - probably used when selecting a provider (device/host support)"
+  end
+
+  def apply_to_device
+    raise NotImplementedError, "apply_to_device() - probably used when selecting a provider (device/host support)"
+  end
+
+  def apply_to_all
+    raise NotImplementedError, "apply_to_all() - probably used when selecting a provider (device/host support)"
+  end
+
+  def can_apply_to_target(target)
+    raise NotImplementedError, "can_apply_to_target() - probably used when selecting a provider (device/host support)"
+  end
+
+end
+end
+end