puppet 4.4.0-universal-darwin

data/spec/unit/provider/package/sun_spec.rb

@@ -0,0 +1,114 @@
+#! /usr/bin/env ruby
+require 'spec_helper'
+
+describe Puppet::Type.type(:package).provider(:sun) do
+  let(:resource) { Puppet::Type.type(:package).new(:name => 'dummy', :ensure => :installed, :provider => :sun) }
+  let(:provider) { resource.provider }
+
+  describe 'provider features' do
+    it { is_expected.to be_installable }
+    it { is_expected.to be_uninstallable }
+    it { is_expected.to be_upgradeable }
+    it { is_expected.not_to be_versionable }
+  end
+
+  [:install, :uninstall, :latest, :query, :update].each do |method|
+    it "should have a #{method} method" do
+      expect(provider).to respond_to(method)
+    end
+  end
+
+  context '#install' do
+    it "should install a package" do
+      resource[:ensure] = :installed
+      resource[:source] = '/cdrom'
+      provider.expects(:pkgadd).with(['-d', '/cdrom', '-n', 'dummy'])
+      provider.install
+    end
+
+    it "should install a package if it is not present on update" do
+      provider.expects(:pkginfo).with('-l', 'dummy').returns File.read(my_fixture('dummy.server'))
+      provider.expects(:pkgrm).with(['-n', 'dummy'])
+      provider.expects(:install)
+      provider.update
+    end
+
+     it "should install a package on global zone if -G specified" do
+      resource[:ensure] = :installed
+      resource[:source] = '/cdrom'
+      resource[:install_options] = '-G'
+      provider.expects(:pkgadd).with(['-d', '/cdrom', '-G', '-n', 'dummy'])
+      provider.install
+    end
+  end
+
+  context '#uninstall' do
+    it "should uninstall a package" do
+      provider.expects(:pkgrm).with(['-n','dummy'])
+      provider.uninstall
+    end
+  end
+
+  context '#update' do
+    it "should call uninstall if not :absent on info2hash" do
+      provider.stubs(:info2hash).returns({:name => 'SUNWdummy', :ensure => "11.11.0,REV=2010.10.12.04.23"})
+      provider.expects(:uninstall)
+      provider.expects(:install)
+      provider.update
+    end
+
+    it "should not call uninstall if :absent on info2hash" do
+      provider.stubs(:info2hash).returns({:name => 'SUNWdummy', :ensure => :absent})
+      provider.expects(:install)
+      provider.update
+    end
+  end
+
+  context '#query' do
+    it "should find the package on query" do
+      provider.expects(:pkginfo).with('-l', 'dummy').returns File.read(my_fixture('dummy.server'))
+      expect(provider.query).to eq({
+        :name     => 'SUNWdummy',
+        :category=>"system",
+        :platform=>"i386",
+        :ensure   => "11.11.0,REV=2010.10.12.04.23",
+        :root=>"/",
+        :description=>"Dummy server (9.6.1-P3)",
+        :vendor => "Oracle Corporation",
+      })
+    end
+
+    it "shouldn't find the package on query if it is not present" do
+      provider.expects(:pkginfo).with('-l', 'dummy').raises Puppet::ExecutionFailure, "Execution of 'pkginfo -l dummy' returned 3: ERROR: information for \"dummy\" not found."
+      expect(provider.query).to eq({:ensure => :absent})
+    end
+
+    it "unknown message should raise error." do
+      provider.expects(:pkginfo).with('-l', 'dummy').returns 'RANDOM'
+      expect { provider.query }.to raise_error Puppet::Error
+    end
+  end
+
+  context '#instance' do
+    it "should list instances when there are packages in the system" do
+      described_class.expects(:pkginfo).with('-l').returns File.read(my_fixture('simple'))
+      instances = provider.class.instances.map { |p| {:name => p.get(:name), :ensure => p.get(:ensure)} }
+      expect(instances.size).to eq(2)
+      expect(instances[0]).to eq({
+        :name     => 'SUNWdummy',
+        :ensure   => "11.11.0,REV=2010.10.12.04.23",
+      })
+      expect(instances[1]).to eq({
+        :name     => 'SUNWdummyc',
+        :ensure   => "11.11.0,REV=2010.10.12.04.24",
+      })
+    end
+
+    it "should return empty if there were no packages" do
+      described_class.expects(:pkginfo).with('-l').returns ''
+      instances = provider.class.instances
+      expect(instances.size).to eq(0)
+    end
+
+  end
+end

data/spec/unit/provider/package/up2date_spec.rb

@@ -0,0 +1,24 @@
+# spec/unit/provider/package/up2date_spec.rb
+require 'spec_helper'
+
+describe 'up2date package provider' do
+
+  # This sets the class itself as the subject rather than
+  # an instance of the class.
+  subject do
+    Puppet::Type.type(:package).provider(:up2date)
+  end
+
+  osfamilies = [ 'redhat' ]
+  releases = [ '2.1', '3', '4' ]
+
+  osfamilies.each do |osfamily|
+    releases.each do |release|
+      it "should be the default provider on #{osfamily} #{release}" do
+        Facter.expects(:value).with(:osfamily).returns(osfamily)
+        Facter.expects(:value).with(:lsbdistrelease).returns(release)
+        expect(subject.default?).to be_truthy
+      end
+    end
+  end
+end

data/spec/unit/provider/package/urpmi_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+describe Puppet::Type.type(:package).provider(:urpmi) do
+
+  before do
+    Puppet::Util::Execution.expects(:execute).never
+    %w[rpm urpmi urpme urpmq].each do |executable|
+      Puppet::Util.stubs(:which).with(executable).returns(executable)
+    end
+    Puppet::Util::Execution.stubs(:execute).with(['rpm', '--version'], anything).returns 'RPM version 4.9.1.3'
+  end
+
+  let(:resource) do
+    Puppet::Type.type(:package).new(:name => 'foopkg', :provider => :urpmi)
+  end
+
+  before do
+    subject.resource = resource
+    Puppet::Type.type(:package).stubs(:defaultprovider).returns described_class
+  end
+
+  describe '#install' do
+    before do
+      subject.stubs(:rpm).with('-q', 'foopkg', any_parameters).returns "foopkg 0 1.2.3.4 5 noarch :DESC:\n"
+    end
+
+    describe 'without a version' do
+      it 'installs the unversioned package' do
+        resource[:ensure] = :present
+        Puppet::Util::Execution.expects(:execute).with(['urpmi', '--auto', 'foopkg'], anything)
+        subject.install
+      end
+    end
+
+    describe 'with a version' do
+      it 'installs the versioned package' do
+        resource[:ensure] = '4.5.6'
+        Puppet::Util::Execution.expects(:execute).with(['urpmi', '--auto', 'foopkg-4.5.6'], anything)
+        subject.install
+      end
+    end
+
+    describe "and the package install fails" do
+      it "raises an error" do
+        Puppet::Util::Execution.stubs(:execute).with(['urpmi', '--auto', 'foopkg'], anything)
+        subject.stubs(:query)
+        expect { subject.install }.to raise_error Puppet::Error, /Package \S+ was not present after trying to install it/
+      end
+    end
+  end
+
+  describe '#latest' do
+    let(:urpmq_output) { 'foopkg : Lorem ipsum dolor sit amet, consectetur adipisicing elit ( 7.8.9-1.mga2 )' }
+
+    it "uses urpmq to determine the latest package" do
+      Puppet::Util::Execution.expects(:execute).with(['urpmq', '-S', 'foopkg'], anything).returns urpmq_output
+      expect(subject.latest).to eq('7.8.9-1.mga2')
+    end
+
+    it "falls back to the current version" do
+      resource[:ensure] = '5.4.3'
+      Puppet::Util::Execution.expects(:execute).with(['urpmq', '-S', 'foopkg'], anything).returns ''
+      expect(subject.latest).to eq('5.4.3')
+    end
+  end
+
+  describe '#update' do
+    it 'delegates to #install' do
+      subject.expects(:install)
+      subject.update
+    end
+  end
+
+  describe '#purge' do
+    it 'uses urpme to purge packages' do
+      Puppet::Util::Execution.expects(:execute).with(['urpme', '--auto', 'foopkg'], anything)
+      subject.purge
+    end
+  end
+end

data/spec/unit/provider/package/windows/exe_package_spec.rb

@@ -0,0 +1,100 @@
+#! /usr/bin/env ruby
+require 'spec_helper'
+require 'puppet/provider/package/windows/exe_package'
+
+describe Puppet::Provider::Package::Windows::ExePackage do
+  subject { described_class }
+
+  let (:name)        { 'Git version 1.7.11' }
+  let (:version)     { '1.7.11' }
+  let (:source)      { 'E:\Git-1.7.11.exe' }
+  let (:uninstall)   { '"C:\Program Files (x86)\Git\unins000.exe" /SP-' }
+
+  context '::from_registry' do
+    it 'should return an instance of ExePackage' do
+      subject.expects(:valid?).returns(true)
+
+      pkg = subject.from_registry('', {'DisplayName' => name, 'DisplayVersion' => version, 'UninstallString' => uninstall})
+      expect(pkg.name).to eq(name)
+      expect(pkg.version).to eq(version)
+      expect(pkg.uninstall_string).to eq(uninstall)
+    end
+
+    it 'should return nil if it is not a valid executable' do
+      subject.expects(:valid?).returns(false)
+
+      expect(subject.from_registry('', {})).to be_nil
+    end
+  end
+
+  context '::valid?' do
+    let(:name)   { 'myproduct' }
+    let(:values) do { 'DisplayName' => name, 'UninstallString' => uninstall } end
+
+    {
+      'DisplayName'      => ['My App', ''],
+      'UninstallString'  => ['E:\uninstall.exe', ''],
+      'WindowsInstaller' => [nil, 1],
+      'ParentKeyName'    => [nil, 'Uber Product'],
+      'Security Update'  => [nil, 'KB890830'],
+      'Update Rollup'    => [nil, 'Service Pack 42'],
+      'Hotfix'           => [nil, 'QFE 42']
+    }.each_pair do |k, arr|
+      it "should accept '#{k}' with value '#{arr[0]}'" do
+        values[k] = arr[0]
+        expect(subject.valid?(name, values)).to be_truthy
+      end
+
+      it "should reject '#{k}' with value '#{arr[1]}'" do
+        values[k] = arr[1]
+        expect(subject.valid?(name, values)).to be_falsey
+      end
+    end
+
+    it 'should reject packages whose name starts with "KBXXXXXX"' do
+      expect(subject.valid?('KB890830', values)).to be_falsey
+    end
+
+    it 'should accept packages whose name does not start with "KBXXXXXX"' do
+      expect(subject.valid?('My Update (KB890830)', values)).to be_truthy
+    end
+  end
+
+  context '#match?' do
+    let(:pkg) { subject.new(name, version, uninstall) }
+
+    it 'should match product name' do
+      expect(pkg.match?({:name => name})).to be_truthy
+    end
+
+    it 'should return false otherwise' do
+      expect(pkg.match?({:name => 'not going to find it'})).to be_falsey
+    end
+  end
+
+  context '#install_command' do
+    it 'should install using the source' do
+      cmd = subject.install_command({:source => source})
+
+      expect(cmd).to eq(['cmd.exe', '/c', 'start', '"puppet-install"', '/w', source])
+    end
+  end
+
+  context '#uninstall_command' do
+    ['C:\uninstall.exe', 'C:\Program Files\uninstall.exe'].each do |exe|
+      it "should quote #{exe}" do
+        expect(subject.new(name, version, exe).uninstall_command).to eq(
+          ['cmd.exe', '/c', 'start', '"puppet-uninstall"', '/w', "\"#{exe}\""]
+        )
+      end
+    end
+
+    ['"C:\Program Files\uninstall.exe"', '"C:\Program Files (x86)\Git\unins000.exe" /SILENT"'].each do |exe|
+      it "should not quote #{exe}" do
+        expect(subject.new(name, version, exe).uninstall_command).to eq(
+          ['cmd.exe', '/c', 'start', '"puppet-uninstall"', '/w', exe]
+        )
+      end
+    end
+  end
+end

data/spec/unit/provider/package/windows/msi_package_spec.rb

@@ -0,0 +1,114 @@
+#! /usr/bin/env ruby
+require 'spec_helper'
+require 'puppet/provider/package/windows/msi_package'
+
+describe Puppet::Provider::Package::Windows::MsiPackage do
+  subject { described_class }
+
+  let (:name)        { 'mysql-5.1.58-win-x64' }
+  let (:version)     { '5.1.58' }
+  let (:source)      { 'E:\mysql-5.1.58-win-x64.msi' }
+  let (:productcode) { '{E437FFB6-5C49-4DAC-ABAE-33FF065FE7CC}' }
+  let (:packagecode) { '{5A6FD560-763A-4BC1-9E03-B18DFFB7C72C}' }
+
+  def expect_installer
+    inst = mock
+    inst.expects(:ProductState).returns(5)
+    inst.expects(:ProductInfo).with(productcode, 'PackageCode').returns(packagecode)
+    subject.expects(:installer).returns(inst)
+  end
+
+  context '::installer', :if => Puppet.features.microsoft_windows? do
+    it 'should return an instance of the COM interface' do
+      expect(subject.installer).not_to be_nil
+    end
+  end
+
+  context '::from_registry' do
+    it 'should return an instance of MsiPackage' do
+      subject.expects(:valid?).returns(true)
+      expect_installer
+
+      pkg = subject.from_registry(productcode, {'DisplayName' => name, 'DisplayVersion' => version})
+      expect(pkg.name).to eq(name)
+      expect(pkg.version).to eq(version)
+      expect(pkg.productcode).to eq(productcode)
+      expect(pkg.packagecode).to eq(packagecode)
+    end
+
+    it 'should return nil if it is not a valid MSI' do
+      subject.expects(:valid?).returns(false)
+
+      expect(subject.from_registry(productcode, {})).to be_nil
+    end
+  end
+
+  context '::valid?' do
+    let(:values) do { 'DisplayName' => name, 'DisplayVersion' => version, 'WindowsInstaller' => 1 } end
+
+    {
+      'DisplayName'      => ['My App', ''],
+      'WindowsInstaller' => [1, nil],
+    }.each_pair do |k, arr|
+      it "should accept '#{k}' with value '#{arr[0]}'" do
+        values[k] = arr[0]
+        expect(subject.valid?(productcode, values)).to be_truthy
+      end
+
+      it "should reject '#{k}' with value '#{arr[1]}'" do
+        values[k] = arr[1]
+        expect(subject.valid?(productcode, values)).to be_falsey
+      end
+    end
+
+    it 'should reject packages whose name is not a productcode' do
+     expect(subject.valid?('AddressBook', values)).to be_falsey
+   end
+
+   it 'should accept packages whose name is a productcode' do
+     expect(subject.valid?(productcode, values)).to be_truthy
+   end
+  end
+
+  context '#match?' do
+    it 'should match package codes case-insensitively' do
+      pkg = subject.new(name, version, productcode, packagecode.upcase)
+
+      expect(pkg.match?({:name => packagecode.downcase})).to be_truthy
+    end
+
+    it 'should match product codes case-insensitively' do
+      pkg = subject.new(name, version, productcode.upcase, packagecode)
+
+      expect(pkg.match?({:name => productcode.downcase})).to be_truthy
+    end
+
+    it 'should match product name' do
+      pkg = subject.new(name, version, productcode, packagecode)
+
+      expect(pkg.match?({:name => name})).to be_truthy
+    end
+
+    it 'should return false otherwise' do
+      pkg = subject.new(name, version, productcode, packagecode)
+
+      expect(pkg.match?({:name => 'not going to find it'})).to be_falsey
+    end
+  end
+
+  context '#install_command' do
+    it 'should install using the source' do
+      cmd = subject.install_command({:source => source})
+
+      expect(cmd).to eq(['msiexec.exe', '/qn', '/norestart', '/i', source])
+    end
+  end
+
+  context '#uninstall_command' do
+    it 'should uninstall using the productcode' do
+      pkg = subject.new(name, version, productcode, packagecode)
+
+      expect(pkg.uninstall_command).to eq(['msiexec.exe', '/qn', '/norestart', '/x', productcode])
+    end
+  end
+end

data/spec/unit/provider/package/windows/package_spec.rb

@@ -0,0 +1,182 @@
+#! /usr/bin/env ruby
+require 'spec_helper'
+require 'puppet/provider/package/windows/package'
+
+describe Puppet::Provider::Package::Windows::Package do
+  subject { described_class }
+
+  let(:hklm) { 'HKEY_LOCAL_MACHINE' }
+  let(:hkcu) { 'HKEY_CURRENT_USER' }
+  let(:path) { 'Software\Microsoft\Windows\CurrentVersion\Uninstall' }
+  let(:key)  { mock('key', :name => "#{hklm}\\#{path}\\Google") }
+  let(:package)  { mock('package') }
+
+  context '::each' do
+    it 'should generate an empty enumeration' do
+      subject.expects(:with_key)
+
+      expect(subject.to_a).to be_empty
+    end
+
+    it 'should yield each package it finds' do
+      subject.expects(:with_key).yields(key, {})
+
+      Puppet::Provider::Package::Windows::MsiPackage.expects(:from_registry).with('Google', {}).returns(package)
+
+      yielded = nil
+      subject.each do |pkg|
+        yielded = pkg
+      end
+
+      expect(yielded).to eq(package)
+    end
+  end
+
+  context '::with_key', :if => Puppet.features.microsoft_windows? do
+    it 'should search HKLM (64 & 32) and HKCU (64 & 32)' do
+      seq = sequence('reg')
+
+      subject.expects(:open).with(hklm, path, subject::KEY64 | subject::KEY_READ).in_sequence(seq)
+      subject.expects(:open).with(hklm, path, subject::KEY32 | subject::KEY_READ).in_sequence(seq)
+      subject.expects(:open).with(hkcu, path, subject::KEY64 | subject::KEY_READ).in_sequence(seq)
+      subject.expects(:open).with(hkcu, path, subject::KEY32 | subject::KEY_READ).in_sequence(seq)
+
+      subject.with_key { |key, values| }
+    end
+
+    it 'should ignore file not found exceptions' do
+      ex = Puppet::Util::Windows::Error.new('Failed to open registry key', Puppet::Util::Windows::Error::ERROR_FILE_NOT_FOUND)
+
+      # make sure we don't stop after the first exception
+      subject.expects(:open).times(4).raises(ex)
+
+      keys = []
+      subject.with_key { |key, values| keys << key }
+      expect(keys).to be_empty
+    end
+
+    it 'should raise other types of exceptions' do
+      ex = Puppet::Util::Windows::Error.new('Failed to open registry key', Puppet::Util::Windows::Error::ERROR_ACCESS_DENIED)
+      subject.expects(:open).raises(ex)
+
+      expect {
+        subject.with_key{ |key, values| }
+      }.to raise_error(Puppet::Util::Windows::Error, /Access is denied/)
+    end
+  end
+
+  context '::installer_class' do
+    it 'should require the source parameter' do
+      expect {
+        subject.installer_class({})
+      }.to raise_error(Puppet::Error, /The source parameter is required when using the Windows provider./)
+    end
+
+    context 'MSI' do
+      let (:klass) { Puppet::Provider::Package::Windows::MsiPackage }
+
+      it 'should accept source ending in .msi' do
+        expect(subject.installer_class({:source => 'foo.msi'})).to eq(klass)
+      end
+
+      it 'should accept quoted source ending in .msi' do
+        expect(subject.installer_class({:source => '"foo.msi"'})).to eq(klass)
+      end
+
+      it 'should accept source case insensitively' do
+        expect(subject.installer_class({:source => '"foo.MSI"'})).to eq(klass)
+      end
+
+      it 'should reject source containing msi in the name' do
+        expect {
+          subject.installer_class({:source => 'mymsi.txt'})
+        }.to raise_error(Puppet::Error, /Don't know how to install 'mymsi.txt'/)
+      end
+    end
+
+    context 'Unknown' do
+      it 'should reject packages it does not know about' do
+        expect {
+          subject.installer_class({:source => 'basram'})
+        }.to raise_error(Puppet::Error, /Don't know how to install 'basram'/)
+      end
+    end
+  end
+
+  context '::munge' do
+    it 'should shell quote strings with spaces and fix forward slashes' do
+      expect(subject.munge('c:/windows/the thing')).to eq('"c:\windows\the thing"')
+    end
+    it 'should leave properly formatted paths alone' do
+      expect(subject.munge('c:\windows\thething')).to eq('c:\windows\thething')
+    end
+  end
+
+  context '::replace_forward_slashes' do
+    it 'should replace forward with back slashes' do
+      expect(subject.replace_forward_slashes('c:/windows/thing/stuff')).to eq('c:\windows\thing\stuff')
+    end
+  end
+
+  context '::quote' do
+    it 'should shell quote strings with spaces' do
+      expect(subject.quote('foo bar')).to eq('"foo bar"')
+    end
+
+    it 'should shell quote strings with spaces and quotes' do
+      expect(subject.quote('"foo bar" baz')).to eq('"\"foo bar\" baz"')
+    end
+
+    it 'should not shell quote strings without spaces' do
+      expect(subject.quote('"foobar"')).to eq('"foobar"')
+    end
+  end
+
+  context '::get_display_name' do
+    it 'should return nil if values is nil' do
+      expect(subject.get_display_name(nil)).to be_nil
+    end
+
+    it 'should return empty if values is empty' do
+      reg_values =  {}
+      expect(subject.get_display_name(reg_values)).to eq('')
+    end
+
+    it 'should return DisplayName when available' do
+      reg_values =  { 'DisplayName' => 'Google' }
+      expect(subject.get_display_name(reg_values)).to eq('Google')
+    end
+
+    it 'should return DisplayName when available, even when QuietDisplayName is also available' do
+      reg_values =  { 'DisplayName' => 'Google', 'QuietDisplayName' => 'Google Quiet' }
+      expect(subject.get_display_name(reg_values)).to eq('Google')
+    end
+
+    it 'should return QuietDisplayName when available if DisplayName is empty' do
+      reg_values =  { 'DisplayName' => '', 'QuietDisplayName' =>'Google Quiet' }
+      expect(subject.get_display_name(reg_values)).to eq('Google Quiet')
+    end
+
+    it 'should return QuietDisplayName when DisplayName is not available' do
+      reg_values =  { 'QuietDisplayName' =>'Google Quiet' }
+      expect(subject.get_display_name(reg_values)).to eq('Google Quiet')
+    end
+
+    it 'should return empty when DisplayName is empty and QuietDisplay name is not available' do
+      reg_values =  { 'DisplayName' => '' }
+      expect(subject.get_display_name(reg_values)).to eq('')
+    end
+
+    it 'should return empty when DisplayName is empty and QuietDisplay name is empty' do
+      reg_values =  { 'DisplayName' => '', 'QuietDisplayName' =>'' }
+      expect(subject.get_display_name(reg_values)).to eq('')
+    end
+  end
+
+  it 'should implement instance methods' do
+    pkg = subject.new('orca', '5.0')
+
+    expect(pkg.name).to eq('orca')
+    expect(pkg.version).to eq('5.0')
+  end
+end