puppet 4.3.2 → 4.4.0

data/spec/unit/indirector/catalog/compiler_spec.rb

@@ -1,5 +1,7 @@
 #! /usr/bin/env ruby
 require 'spec_helper'
+require 'puppet_spec/compiler'
+require 'matchers/resource'
 
 require 'puppet/indirector/catalog/compiler'
 
@@ -46,7 +48,7 @@ describe Puppet::Resource::Catalog::Compiler do
 
     it "should directly use provided nodes for a local request" do
       Puppet::Node.indirection.expects(:find).never
-      @compiler.expects(:compile).with(@node, nil)
+      @compiler.expects(:compile).with(@node, anything)
       @request.stubs(:options).returns(:use_node => @node)
       @request.stubs(:remote?).returns(false)
       @compiler.find(@request)
@@ -63,7 +65,7 @@ describe Puppet::Resource::Catalog::Compiler do
     it "should use the authenticated node name if no request key is provided" do
       @request.stubs(:key).returns(nil)
       Puppet::Node.indirection.expects(:find).with(@name, anything).returns(@node)
-      @compiler.expects(:compile).with(@node, nil)
+      @compiler.expects(:compile).with(@node, anything)
       @compiler.find(@request)
     end
 
@@ -71,7 +73,7 @@ describe Puppet::Resource::Catalog::Compiler do
       @request.expects(:key).returns "my_node"
 
       Puppet::Node.indirection.expects(:find).with("my_node", anything).returns @node
-      @compiler.expects(:compile).with(@node, nil)
+      @compiler.expects(:compile).with(@node, anything)
       @compiler.find(@request)
     end
 
@@ -88,7 +90,7 @@ describe Puppet::Resource::Catalog::Compiler do
     it "should pass the found node to the compiler for compiling" do
       Puppet::Node.indirection.expects(:find).with(@name, anything).returns(@node)
       config = mock 'config'
-      Puppet::Parser::Compiler.expects(:compile).with(@node, nil)
+      Puppet::Parser::Compiler.expects(:compile).with(@node, anything)
       @compiler.find(@request)
     end
 
@@ -145,6 +147,96 @@ describe Puppet::Resource::Catalog::Compiler do
 
       expect(@compiler.find(@request).code_id).to eq(code_id)
     end
+
+    it "does not inline metadata when the static_catalog option is false" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = false
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      catalog = Puppet::Resource::Catalog.new(@node.name, @node.environment)
+      Puppet::Parser::Compiler.stubs(:compile).returns catalog
+
+      @compiler.expects(:inline_metadata).never
+      @compiler.find(@request)
+    end
+
+    it "does not inline metadata when static_catalogs are disabled" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = 'md5'
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns false
+
+      catalog = Puppet::Resource::Catalog.new(@node.name, @node.environment)
+      Puppet::Parser::Compiler.stubs(:compile).returns catalog
+
+      @compiler.expects(:inline_metadata).never
+      @compiler.find(@request)
+    end
+
+    it "does not inline metadata when code_id is not specified" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = 'md5'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      catalog = Puppet::Resource::Catalog.new(@node.name, @node.environment)
+      Puppet::Parser::Compiler.stubs(:compile).returns catalog
+
+      @compiler.expects(:inline_metadata).never
+      expect(@compiler.find(@request)).to eq(catalog)
+    end
+
+    it "inlines metadata when the static_catalog option is true, static_catalogs are enabled, and a code_id is provided" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = 'sha256'
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      catalog = Puppet::Resource::Catalog.new(@node.name, @node.environment)
+      Puppet::Parser::Compiler.stubs(:compile).returns catalog
+
+      @compiler.expects(:inline_metadata).with(catalog, :sha256).returns catalog
+      @compiler.find(@request)
+    end
+
+    it "inlines metadata with the first common checksum type" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = 'atime.md5.sha256.mtime'
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      catalog = Puppet::Resource::Catalog.new(@node.name, @node.environment)
+      Puppet::Parser::Compiler.stubs(:compile).returns catalog
+
+      @compiler.expects(:inline_metadata).with(catalog, :md5).returns catalog
+      @compiler.find(@request)
+    end
+
+    it "errors if checksum_type contains no shared checksum types" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = 'atime.sha512'
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      expect { @compiler.find(@request) }.to raise_error Puppet::Error,
+        "Unable to find a common checksum type between agent 'atime.sha512' and master '[:sha256, :sha256lite, :md5, :md5lite, :sha1, :sha1lite, :mtime, :ctime, :none]'."
+    end
+
+    it "errors if checksum_type contains no shared checksum types" do
+      Puppet::Node.indirection.stubs(:find).returns(@node)
+      @request.options[:static_catalog] = true
+      @request.options[:checksum_type] = nil
+      @request.options[:code_id] = 'some_code_id'
+      @node.environment.stubs(:static_catalogs?).returns true
+
+      expect { @compiler.find(@request) }.to raise_error Puppet::Error,
+        "Unable to find a common checksum type between agent '' and master '[:sha256, :sha256lite, :md5, :md5lite, :sha1, :sha1lite, :mtime, :ctime, :none]'."
+    end
   end
 
   describe "when extracting facts from the request" do
@@ -300,4 +392,613 @@ describe Puppet::Resource::Catalog::Compiler do
     end
 
   end
+
+  describe "when inlining metadata" do
+    include PuppetSpec::Compiler
+
+    let(:node) { Puppet::Node.new 'me' }
+    let(:checksum_type) { 'md5' }
+    let(:checksum_value) { 'b1946ac92492d2347c6235b4d2611184' }
+    let(:path) { File.expand_path('/foo') }
+    let(:source) { 'puppet:///modules/mymodule/config_file.txt' }
+
+    before :each do
+      @compiler = Puppet::Resource::Catalog::Compiler.new
+    end
+
+    def stubs_resource_metadata(ftype, relative_path, full_path = nil)
+      full_path ||=  File.join(Puppet[:environmentpath], 'production', relative_path)
+
+      metadata = stub 'metadata'
+      metadata.stubs(:ftype).returns(ftype)
+      metadata.stubs(:full_path).returns(full_path)
+      metadata.stubs(:relative_path).returns(relative_path)
+      metadata.stubs(:source).returns("puppet:///#{relative_path}")
+      metadata.stubs(:source=)
+      metadata.stubs(:content_uri=)
+
+      metadata
+    end
+
+    def stubs_file_metadata(checksum_type, sha, relative_path, full_path = nil)
+      metadata = stubs_resource_metadata('file', relative_path, full_path)
+      metadata.stubs(:checksum).returns("{#{checksum_type}}#{sha}")
+      metadata.stubs(:checksum_type).returns(checksum_type)
+      metadata
+    end
+
+    def stubs_link_metadata(relative_path, destination)
+      metadata = stubs_resource_metadata('link', relative_path)
+      metadata.stubs(:destination).returns(destination)
+      metadata
+    end
+
+    def stubs_directory_metadata(relative_path)
+      metadata = stubs_resource_metadata('directory', relative_path)
+      metadata.stubs(:relative_path).returns('.')
+      metadata
+    end
+
+    it "inlines metadata for a file" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt')
+      metadata.expects(:source=).with(source)
+      metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/config_file.txt')
+
+      options = {
+        :environment => catalog.environment_instance,
+        :links => :manage,
+        :checksum_type => checksum_type.to_sym,
+        :source_permissions => :ignore
+      }
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, options).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+
+      expect(catalog.metadata[path]).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "uses resource parameters when inlining metadata" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => link,
+          source => '#{source}',
+          links  => follow,
+          source_permissions => use,
+        }
+      MANIFEST
+
+      metadata = stubs_link_metadata('modules/mymodule/files/config_file.txt', '/tmp/some/absolute/path')
+      metadata.expects(:source=).with(source)
+      metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/config_file.txt')
+
+      options = {
+        :environment        => catalog.environment_instance,
+        :links              => :follow,
+        :checksum_type      => checksum_type.to_sym,
+        :source_permissions => :use
+      }
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, options).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+
+      expect(catalog.metadata[path]).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "uses file parameters which match the true file type defaults" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      if Puppet::Util::Platform.windows?
+        default_file = Puppet::Type.type(:file).new(:name => 'C:\defaults')
+      else
+        default_file = Puppet::Type.type(:file).new(:name => '/defaults')
+      end
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt')
+
+      options = {
+        :environment => catalog.environment_instance,
+        :links => default_file[:links],
+        :checksum_type => checksum_type.to_sym,
+        :source_permissions => default_file[:source_permissions]
+      }
+
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, options).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+    end
+
+    it "inlines metadata for the first source found" do
+      alt_source = 'puppet:///modules/files/other.txt'
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => ['#{alt_source}', '#{source}'],
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt')
+      metadata.expects(:source=).with(source)
+      metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/config_file.txt')
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(alt_source, anything).returns(nil)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+
+      expect(catalog.metadata[path]).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    [['md5', 'b1946ac92492d2347c6235b4d2611184'],
+     ['sha256', '5891b5b522d5df086d0ff0b110fbd9d21bb4fc7163af34d08286a2e846f6be03']].each do |checksum_type, sha|
+      describe "with agent requesting checksum_type #{checksum_type}" do
+        it "sets checksum and checksum_value for resources with puppet:// source URIs" do
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure => file,
+              source => '#{source}'
+            }
+          MANIFEST
+
+          metadata = stubs_file_metadata(checksum_type, sha, 'modules/mymodule/files/config_file.txt')
+
+          options = {
+            :environment        => catalog.environment_instance,
+            :links              => :manage,
+            :checksum_type      => checksum_type.to_sym,
+            :source_permissions => :ignore
+          }
+          Puppet::FileServing::Metadata.indirection.expects(:find).with(source, options).returns(metadata)
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to eq(metadata)
+          expect(catalog.recursive_metadata).to be_empty
+        end
+      end
+    end
+
+    it "preserves source host and port in the content_uri" do
+      source = 'puppet://myhost:8888/modules/mymodule/config_file.txt'
+
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt')
+      metadata.stubs(:source).returns(source)
+
+      metadata.expects(:content_uri=).with('puppet://myhost:8888/modules/mymodule/files/config_file.txt')
+
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+    end
+
+    it "skips absent resources" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => absent,
+        }
+      MANIFEST
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources without a source" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+        }
+      MANIFEST
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources with a local source" do
+      local_source = File.expand_path('/tmp/source')
+
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{local_source}',
+        }
+      MANIFEST
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources with a http source" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => ['http://foo.source.io', 'https://foo.source.io']
+        }
+      MANIFEST
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources with a source outside the environment path" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      full_path = File.join(Puppet[:codedir], "modules/mymodule/files/config_file.txt")
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt', full_path)
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources whose mount point is not 'modules'" do
+      source = 'puppet:///secure/data'
+
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}',
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'secure/files/data.txt')
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources with 'modules' mount point resolving to a path not in 'modules/*/files'" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}',
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/not_in_files/config_file.txt')
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "skips resources with 'modules' mount point resolving to a path with an empty module name" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}',
+        }
+      MANIFEST
+
+      # note empty module name "modules//files"
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules//files/config_file.txt')
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "inlines resources in 'modules' mount point resolving to a 'site' directory within the per-environment codedir" do
+      # example taken from https://github.com/puppetlabs/control-repo/blob/508b9cc/site/profile/manifests/puppetmaster.pp#L45-L49
+      source = 'puppet:///modules/profile/puppetmaster/update-classes.sh'
+
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      # See https://github.com/puppetlabs/control-repo/blob/508b9cc/site/profile/files/puppetmaster/update-classes.sh
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'site/profile/files/puppetmaster/update-classes.sh')
+      metadata.stubs(:source).returns(source)
+
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata[path]).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    # It's bizarre to strip trailing slashes for a file, but it's how
+    # puppet currently behaves, so match that.
+    it "inlines resources with a trailing slash" do
+      source = 'puppet:///modules/mymodule/myfile'
+
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { '#{path}':
+          ensure => file,
+          source => '#{source}/'
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/myfile')
+      metadata.stubs(:source).returns(source)
+
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata[path]).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    describe "when inlining directories" do
+      let(:source_dir) { 'puppet:///modules/mymodule/directory' }
+      let(:metadata) { stubs_directory_metadata('modules/mymodule/files/directory') }
+
+      describe "when recurse is false" do
+        it "skips children" do
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              source  => '#{source_dir}'
+            }
+          MANIFEST
+
+          metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/directory')
+          Puppet::FileServing::Metadata.indirection.expects(:find).with(source_dir, anything).returns(metadata)
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to eq(metadata)
+          expect(catalog.recursive_metadata).to be_empty
+        end
+      end
+
+      describe "when recurse is true" do
+        let(:child_metadata) { stubs_file_metadata(checksum_type, checksum_value, 'myfile.txt') }
+
+        it "inlines child metadata" do
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => '#{source_dir}'
+            }
+          MANIFEST
+
+          metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/directory')
+          child_metadata.expects(:content_uri=).with('puppet:///modules/mymodule/files/directory/myfile.txt')
+
+          options = {
+            :environment        => catalog.environment_instance,
+            :links              => :manage,
+            :checksum_type      => checksum_type.to_sym,
+            :source_permissions => :ignore,
+            :recurse            => true,
+            :recurselimit       => nil,
+            :ignore             => nil,
+          }
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source_dir, options).returns([metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to be_nil
+          expect(catalog.recursive_metadata[path][source_dir]).to eq([metadata, child_metadata])
+        end
+
+        it "uses resource parameters when inlining metadata" do
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => '#{source_dir}',
+              checksum => sha256,
+              source_permissions => use_when_creating,
+              recurselimit => 2,
+              ignore => 'foo.+',
+              links => follow,
+            }
+          MANIFEST
+
+          options = {
+            :environment        => catalog.environment_instance,
+            :links              => :follow,
+            :checksum_type      => :sha256,
+            :source_permissions => :use_when_creating,
+            :recurse            => true,
+            :recurselimit       => 2,
+            :ignore             => 'foo.+',
+          }
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source_dir, options).returns([metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to be_nil
+          expect(catalog.recursive_metadata[path][source_dir]).to eq([metadata, child_metadata])
+        end
+
+        it "inlines metadata for all sources if source_select is all" do
+          alt_source_dir = 'puppet:///modules/mymodule/other_directory'
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => ['#{source_dir}', '#{alt_source_dir}'],
+              sourceselect => all,
+            }
+          MANIFEST
+
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source_dir, anything).returns([metadata, child_metadata])
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(alt_source_dir, anything).returns([metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to be_nil
+          expect(catalog.recursive_metadata[path][source_dir]).to eq([metadata, child_metadata])
+          expect(catalog.recursive_metadata[path][alt_source_dir]).to eq([metadata, child_metadata])
+        end
+
+        it "inlines metadata for the first valid source if source_select is first" do
+          alt_source_dir = 'puppet:///modules/mymodule/other_directory'
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => ['#{source_dir}', '#{alt_source_dir}'],
+            }
+          MANIFEST
+
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source_dir, anything).returns(nil)
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(alt_source_dir, anything).returns([metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata[path]).to be_nil
+          expect(catalog.recursive_metadata[path][source_dir]).to be_nil
+          expect(catalog.recursive_metadata[path][alt_source_dir]).to eq([metadata, child_metadata])
+        end
+
+        it "skips resources whose mount point is not 'modules'" do
+          source = 'puppet:///secure/data'
+
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => '#{source}',
+            }
+          MANIFEST
+
+          metadata = stubs_directory_metadata('secure/files/data')
+          metadata.stubs(:source).returns(source)
+
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source, anything).returns([metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+          expect(catalog.metadata).to be_empty
+          expect(catalog.recursive_metadata).to be_empty
+        end
+
+        it "skips resources with 'modules' mount point resolving to a path not in 'modules/*/files'" do
+          source = 'puppet:///modules/mymodule/directory'
+
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => '#{source}',
+            }
+          MANIFEST
+
+          metadata = stubs_directory_metadata('modules/mymodule/not_in_files/directory')
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source, anything).returns([metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+          expect(catalog.metadata).to be_empty
+          expect(catalog.recursive_metadata).to be_empty
+        end
+
+        it "inlines resources in 'modules' mount point resolving to a 'site' directory within the per-environment codedir" do
+          # example adopted from https://github.com/puppetlabs/control-repo/blob/508b9cc/site/profile/manifests/puppetmaster.pp#L45-L49
+          source = 'puppet:///modules/profile/puppetmaster'
+
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => file,
+              recurse => true,
+              source  => '#{source}'
+            }
+          MANIFEST
+
+          # See https://github.com/puppetlabs/control-repo/blob/508b9cc/site/profile/files/puppetmaster/update-classes.sh
+          dir_metadata = stubs_directory_metadata('site/profile/files/puppetmaster')
+          dir_metadata.stubs(:source).returns(source)
+
+          child_metadata = stubs_file_metadata(checksum_type, checksum_value, './update-classes.sh')
+          child_metadata.stubs(:source).returns("#{source}/update-classes.sh")
+
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source, anything).returns([dir_metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+          expect(catalog.metadata).to be_empty
+          expect(catalog.recursive_metadata[path][source]).to eq([dir_metadata, child_metadata])
+        end
+
+        it "inlines resources with a trailing slash" do
+          source = 'puppet:///modules/mymodule/directory'
+
+          catalog = compile_to_catalog(<<-MANIFEST, node)
+            file { '#{path}':
+              ensure  => directory,
+              recurse => true,
+              source  => '#{source}/'
+            }
+          MANIFEST
+
+          dir_metadata = stubs_directory_metadata('modules/mymodule/files/directory')
+          dir_metadata.stubs(:source).returns(source)
+
+          child_metadata = stubs_file_metadata(checksum_type, checksum_value, './file')
+          child_metadata.stubs(:source).returns("#{source}/file")
+
+          Puppet::FileServing::Metadata.indirection.expects(:search).with(source, anything).returns([dir_metadata, child_metadata])
+
+          @compiler.send(:inline_metadata, catalog, checksum_type)
+
+          expect(catalog.metadata).to be_empty
+          expect(catalog.recursive_metadata[path][source]).to eq([dir_metadata, child_metadata])
+        end
+      end
+    end
+
+    it "skips non-file resources" do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        notify { 'hi': }
+      MANIFEST
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata).to be_empty
+      expect(catalog.recursive_metadata).to be_empty
+    end
+
+    it "inlines windows file paths", :if => Puppet.features.posix? do
+      catalog = compile_to_catalog(<<-MANIFEST, node)
+        file { 'c:/foo':
+          ensure => file,
+          source => '#{source}'
+        }
+      MANIFEST
+
+      metadata = stubs_file_metadata(checksum_type, checksum_value, 'modules/mymodule/files/config_file.txt')
+      Puppet::FileServing::Metadata.indirection.expects(:find).with(source, anything).returns(metadata)
+
+      @compiler.send(:inline_metadata, catalog, checksum_type)
+      expect(catalog.metadata['c:/foo']).to eq(metadata)
+      expect(catalog.recursive_metadata).to be_empty
+    end
+  end
 end