puppet 4.10.0 → 5.0.0

data/lib/puppet/indirector/node/plain.rb

@@ -14,7 +14,8 @@ class Puppet::Node::Plain < Puppet::Indirector::Plain
   def find(request)
     node = super
     node.environment = request.environment
-    node.fact_merge
+    facts = request.options[:facts].is_a?(Puppet::Node::Facts) ? request.options[:facts] : nil
+    node.fact_merge(facts)
     node
   end
 end

data/lib/puppet/indirector/node/write_only_yaml.rb

@@ -11,7 +11,12 @@ require 'puppet/indirector/yaml'
 # @api private
 #
 class Puppet::Node::WriteOnlyYaml < Puppet::Indirector::Yaml
-  desc "Store node information as flat files, serialized using YAML,
+  def initialize
+    Puppet.warn_once('deprecations', 'Puppet::Node::WriteOnlyYaml', _('Puppet::Node::WriteOnlyYaml is deprecated and will be removed in a future release of Puppet.'))
+    super
+  end
+
+  desc "(Deprecated) Store node information as flat files, serialized using YAML,
     does not deserialize (write only)."
 
   # Overridden to always return nil. This is a write only terminus.

data/lib/puppet/indirector/node/yaml.rb

@@ -8,15 +8,6 @@ class Puppet::Node::Yaml < Puppet::Indirector::Yaml
   protected
 
   def fix(object)
-    # This looks very strange because when the object is read from disk the
-    # environment is a string and by assigning it back onto the object it gets
-    # converted to a Puppet::Node::Environment.
-    #
-    # The Puppet::Node class can't handle this itself because we are loading
-    # with just straight YAML, which doesn't give the object a chance to modify
-    # things as it is loaded. Instead YAML simply sets the instance variable
-    # and leaves it at that.
-    object.environment = object.environment
     object
   end
 end

data/lib/puppet/indirector/report/processor.rb

@@ -36,7 +36,7 @@ class Puppet::Transaction::Report::Processor < Puppet::Indirector::Code
         newrep.extend(mod)
         newrep.process
       rescue => detail
-        Puppet.log_exception(detail, "Report #{name} failed: #{detail}")
+        Puppet.log_exception(detail, _("Report %{report} failed: %{detail}") % { report: name, detail: detail })
       end
     end
   end
@@ -52,7 +52,7 @@ class Puppet::Transaction::Report::Processor < Puppet::Indirector::Code
       if mod = Puppet::Reports.report(name)
         yield(mod)
       else
-        Puppet.warning "No report named '#{name}'"
+        Puppet.warning _("No report named '%{name}'") % { name: name }
       end
     end
   end

data/lib/puppet/indirector/report/rest.rb

@@ -1,4 +1,5 @@
 require 'puppet/indirector/rest'
+require 'semantic_puppet'
 
 class Puppet::Transaction::Report::Rest < Puppet::Indirector::REST
   desc "Get server report over HTTP via REST."
@@ -6,6 +7,18 @@ class Puppet::Transaction::Report::Rest < Puppet::Indirector::REST
   use_port_setting(:report_port)
   use_srv_service(:report)
 
+  def handle_response(request, response)
+    if !response.is_a?(Net::HTTPSuccess)
+      server_version = response[Puppet::Network::HTTP::HEADER_PUPPET_VERSION]
+      if server_version &&
+         SemanticPuppet::Version.parse(server_version).major < Puppet::Indirector::REST::MAJOR_VERSION_JSON_DEFAULT &&
+         Puppet[:preferred_serialization_format] != 'pson'
+        format = Puppet[:preferred_serialization_format]
+        raise Puppet::Error.new(_("Server version %{version} does not accept reports in '%{format}', use `preferred_serialization_format=pson`") % {version: server_version, format: format})
+      end
+    end
+  end
+
   private
 
   def deserialize_save(content_type, body)

data/lib/puppet/indirector/request.rb

@@ -41,10 +41,6 @@ class Puppet::Indirector::Request
     end
   end
 
-  def escaped_key
-    URI.escape(key)
-  end
-
   # LAK:NOTE This is a messy interface to the cache, and it's only
   # used by the Configurer class.  I decided it was better to implement
   # it now and refactor later, when we have a better design, than
@@ -97,7 +93,7 @@ class Puppet::Indirector::Request
   end
 
   def model
-    raise ArgumentError, "Could not find indirection '#{indirection_name}'" unless i = indirection
+    raise ArgumentError, _("Could not find indirection '%{indirection}'") % { indirection: indirection_name } unless i = indirection
     i.model
   end
 
@@ -133,17 +129,17 @@ class Puppet::Indirector::Request
       case value
       when nil
         params
-      when true, false, String, Symbol, Fixnum, Bignum, Float
+      when true, false, String, Symbol, Integer, Float
         params << [key, value]
       else
-        raise ArgumentError, "HTTP REST queries cannot handle values of type '#{value.class}'"
+        raise ArgumentError, _("HTTP REST queries cannot handle values of type '%{klass}'") % { klass: value.class }
       end
     end
   end
 
   def encode_params(params)
     params.collect do |key, value|
-      "#{key}=#{CGI.escape(value.to_s)}"
+      "#{key}=#{Puppet::Util.uri_query_encode(value.to_s)}"
     end.join("&")
   end
 
@@ -191,7 +187,7 @@ class Puppet::Indirector::Request
           self.port   = srv_port
           return yield(self)
         rescue SystemCallError => e
-          Puppet.warning "Error connecting to #{srv_server}:#{srv_port}: #{e.message}"
+          Puppet.warning _("Error connecting to %{srv_server}:%{srv_port}: %{message}") % { srv_server: srv_server, srv_port: srv_port, message: e.message }
         end
       end
     end
@@ -243,11 +239,10 @@ class Puppet::Indirector::Request
   def set_uri_key(key)
     @uri = key
     begin
-      # calling URI.escape for UTF-8 characters will % escape them
-      # and the resulting string components of the URI are now ASCII
-      uri = URI.parse(URI.escape(key))
+      # calling uri_encode for UTF-8 characters will % escape them and keep them UTF-8
+      uri = URI.parse(Puppet::Util.uri_encode(key))
     rescue => detail
-      raise ArgumentError, "Could not understand URL #{key}: #{detail}", detail.backtrace
+      raise ArgumentError, _("Could not understand URL %{key}: %{detail}") % { key: key, detail: detail }, detail.backtrace
     end
 
     # Just short-circuit these to full paths
@@ -274,8 +269,6 @@ class Puppet::Indirector::Request
       @protocol = uri.scheme
     end
 
-    # The unescaped bytes are correct but in ASCII and must be treated
-    # as UTF-8 for the sake of performing string comparisons later
-    @key = URI.unescape(uri.path.sub(/^\//, '')).force_encoding(Encoding::UTF_8)
+    @key = URI.unescape(uri.path.sub(/^\//, ''))
   end
 end

data/lib/puppet/indirector/resource/ral.rb

@@ -58,6 +58,6 @@ class Puppet::Resource::Ral < Puppet::Indirector::Code
   end
 
   def type( request )
-    Puppet::Type.type(type_name(request)) or raise Puppet::Error, "Could not find type #{type_name(request)}"
+    Puppet::Type.type(type_name(request)) or raise Puppet::Error, _("Could not find type %{request_type}") % { request_type: type_name(request) }
   end
 end

data/lib/puppet/indirector/resource/validator.rb

@@ -2,7 +2,7 @@ module Puppet::Resource::Validator
   def validate_key(request)
     type, title = request.key.split('/', 2)
     unless type.downcase == request.instance.type.downcase and title == request.instance.title
-      raise Puppet::Indirector::ValidationError, "Resource instance does not match request key"
+      raise Puppet::Indirector::ValidationError, _("Resource instance does not match request key")
     end
   end
 end

data/lib/puppet/indirector/rest.rb

@@ -1,6 +1,7 @@
 require 'net/http'
 require 'uri'
 require 'json'
+require 'semantic_puppet'
 
 require 'puppet/network/http'
 require 'puppet/network/http_pool'
@@ -10,6 +11,10 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
   include Puppet::Network::HTTP::Compression.module
 
   IndirectedRoutes = Puppet::Network::HTTP::API::IndirectedRoutes
+  EXCLUDED_FORMATS = [:yaml, :b64_zlib_yaml, :dot]
+
+  # puppet major version where JSON is enabled by default
+  MAJOR_VERSION_JSON_DEFAULT = 5
 
   class << self
     attr_reader :server_setting, :port_setting
@@ -101,11 +106,10 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
   # Provide appropriate headers.
   def headers
     # yaml is not allowed on the network
-    network_formats = model.supported_formats.reject do |format|
-      [:yaml, :b64_zlib_yaml].include?(format)
-    end
+    network_formats = model.supported_formats - EXCLUDED_FORMATS
+    mime_types = network_formats.map { |f| model.get_format(f).mime }
     common_headers = {
-      "Accept"                                     => network_formats.join(", "),
+      "Accept"                                     => mime_types.join(', '),
       Puppet::Network::HTTP::HEADER_PUPPET_VERSION => Puppet.version
     }
 
@@ -180,7 +184,7 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
       # that makes a user aware of the reason for the failure.
       #
       content_type, body = parse_response(response)
-      msg = "Find #{elide(uri_with_query_string, 100)} resulted in 404 with the message: #{body}"
+      msg = _("Find %{uri} resulted in 404 with the message: %{body}") % { uri: elide(uri_with_query_string, 100), body: body }
       raise Puppet::Error, msg
     else
       nil
@@ -213,7 +217,7 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
   end
 
   def destroy(request)
-    raise ArgumentError, "DELETE does not accept options" unless request.options.empty?
+    raise ArgumentError, _("DELETE does not accept options") unless request.options.empty?
 
     response = do_request(request) do |req|
       http_delete(req, IndirectedRoutes.request_to_uri(req), headers)
@@ -228,7 +232,7 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
   end
 
   def save(request)
-    raise ArgumentError, "PUT does not accept options" unless request.options.empty?
+    raise ArgumentError, _("PUT does not accept options") unless request.options.empty?
 
     response = do_request(request) do |req|
       http_put(req, IndirectedRoutes.request_to_uri(req), req.instance.render, headers.merge({ "Content-Type" => req.instance.mime }))
@@ -249,7 +253,21 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
   # to request.do_request from here, thus if we change what we pass or how we
   # get it, we only need to change it here.
   def do_request(request)
-    request.do_request(self.class.srv_service, self.class.server, self.class.port) { |req| yield(req) }
+    response = request.do_request(self.class.srv_service, self.class.server, self.class.port) { |req| yield(req) }
+
+    handle_response(request, response) if response
+
+    response
+  end
+
+  def handle_response(request, response)
+    server_version = response[Puppet::Network::HTTP::HEADER_PUPPET_VERSION]
+    if server_version &&
+       SemanticPuppet::Version.parse(server_version).major < MAJOR_VERSION_JSON_DEFAULT &&
+       Puppet[:preferred_serialization_format] != 'pson'
+      Puppet.warning("Downgrading to PSON for future requests")
+      Puppet[:preferred_serialization_format] = 'pson'
+    end
   end
 
   def validate_key(request)
@@ -288,7 +306,7 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
       returned_message = uncompress_body(response)
     end
 
-    message = "Error #{response.code} on SERVER: #{returned_message}"
+    message = _("Error %{code} on SERVER: %{returned_message}") % { code: response.code, returned_message: returned_message }
     Net::HTTPError.new(message, response)
   end
 
@@ -300,7 +318,7 @@ class Puppet::Indirector::REST < Puppet::Indirector::Terminus
       [ response['content-type'].gsub(/\s*;.*$/,''),
         body = uncompress_body(response) ]
     else
-      raise "No content type in http response; cannot parse"
+      raise _("No content type in http response; cannot parse")
     end
   end
 

data/lib/puppet/indirector/ssl_file.rb

@@ -54,8 +54,8 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
 
   def path(name)
     if name =~ Puppet::Indirector::BadNameRegexp then
-      Puppet.crit("directory traversal detected in #{self.class}: #{name.inspect}")
-      raise ArgumentError, "invalid key"
+      Puppet.crit(_("directory traversal detected in %{indirection}: %{name}") % { indirection: self.class, name: name.inspect })
+      raise ArgumentError, _("invalid key")
     end
 
     if ca?(name) and ca_location
@@ -72,11 +72,11 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
     path = Puppet::FileSystem.pathname(path(request.key))
     return false unless Puppet::FileSystem.exist?(path)
 
-    Puppet.notice "Removing file #{model} #{request.key} at '#{path}'"
+    Puppet.notice _("Removing file %{model} %{request} at '%{path}'") % { model: model, request: request.key, path: path }
     begin
       Puppet::FileSystem.unlink(path)
     rescue => detail
-      raise Puppet::Error, "Could not remove #{request.key}: #{detail}", detail.backtrace
+      raise Puppet::Error, _("Could not remove %{request}: %{detail}") % { request: request.key, detail: detail }, detail.backtrace
     end
   end
 
@@ -92,8 +92,8 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
     path = path(request.key)
     dir = File.dirname(path)
 
-    raise Puppet::Error.new("Cannot save #{request.key}; parent directory #{dir} does not exist") unless FileTest.directory?(dir)
-    raise Puppet::Error.new("Cannot save #{request.key}; parent directory #{dir} is not writable") unless FileTest.writable?(dir)
+    raise Puppet::Error.new(_("Cannot save %{request}; parent directory %{dir} does not exist") % { request: request.key, dir: dir }) unless FileTest.directory?(dir)
+    raise Puppet::Error.new(_("Cannot save %{request}; parent directory %{dir} is not writable") % { request: request.key, dir: dir }) unless FileTest.writable?(dir)
 
     write(request.key, path) { |f| f.print request.instance.to_s }
   end
@@ -142,7 +142,7 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
     dir, short = File.split(file)
     return nil unless Puppet::FileSystem.exist?(dir)
 
-    raise ArgumentError, "Tried to fix SSL files to a file containing uppercase" unless short.downcase == short
+    raise ArgumentError, _("Tried to fix SSL files to a file containing uppercase") unless short.downcase == short
     real_file = Dir.entries(dir).reject { |f| f =~ /^\./ }.find do |other|
       other.downcase == short
     end
@@ -151,7 +151,7 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
 
     full_file = File.join(dir, real_file)
 
-    Puppet.deprecation_warning "Automatic downcasing and renaming of ssl files is deprecated; please request the file using its correct case: #{full_file}"
+    Puppet.deprecation_warning _("Automatic downcasing and renaming of ssl files is deprecated; please request the file using its correct case: %{full_file}") % { full_file: full_file }
     File.rename(full_file, file)
 
     file
@@ -187,7 +187,7 @@ class Puppet::Indirector::SslFile < Puppet::Indirector::Terminus
       begin
         Puppet.settings.setting(setting).open_file(path, 'w:ASCII') { |f| yield f }
       rescue => detail
-        raise Puppet::Error, "Could not write #{path} to #{setting}: #{detail}", detail.backtrace
+        raise Puppet::Error, _("Could not write %{path} to %{setting}: %{detail}") % { path: path, setting: setting, detail: detail }, detail.backtrace
       end
     else
       raise Puppet::DevError, "You must provide a setting to determine where the files are stored"

data/lib/puppet/indirector/terminus.rb

@@ -32,7 +32,7 @@ class Puppet::Indirector::Terminus
       elsif ind = Puppet::Indirector::Indirection.instance(name)
         @indirection = ind
       else
-        raise ArgumentError, "Could not find indirection instance #{name} for #{self.name}"
+        raise ArgumentError, _("Could not find indirection instance %{name} for %{terminus}") % { name: name, terminus: self.name }
       end
     end
 
@@ -157,13 +157,13 @@ class Puppet::Indirector::Terminus
 
   def validate_key(request)
     unless request.key == request.instance.name
-      raise Puppet::Indirector::ValidationError, "Instance name #{request.instance.name.inspect} does not match requested key #{request.key.inspect}"
+      raise Puppet::Indirector::ValidationError, _("Instance name %{name} does not match requested key %{key}") % { name: request.instance.name.inspect, key: request.key.inspect }
     end
   end
 
   def validate_model(request)
     unless model === request.instance
-      raise Puppet::Indirector::ValidationError, "Invalid instance type #{request.instance.class.inspect}, expected #{model.inspect}"
+      raise Puppet::Indirector::ValidationError, _("Invalid instance type %{klass}, expected %{model_type}") % { klass: request.instance.class.inspect, model_type: model.inspect }
     end
   end
 end

data/lib/puppet/indirector/yaml.rb

@@ -11,13 +11,13 @@ class Puppet::Indirector::Yaml < Puppet::Indirector::Terminus
     begin
       return fix(Puppet::Util::Yaml.load_file(file))
     rescue Puppet::Util::Yaml::YamlLoadError => detail
-      raise Puppet::Error, "Could not parse YAML data for #{indirection.name} #{request.key}: #{detail}", detail.backtrace
+      raise Puppet::Error, _("Could not parse YAML data for %{indirection} %{request}: %{detail}") % { indirection: indirection.name, request: request.key, detail: detail }, detail.backtrace
     end
   end
 
   # Convert our object to YAML and store it to the disk.
   def save(request)
-    raise ArgumentError.new("You can only save objects that respond to :name") unless request.instance.respond_to?(:name)
+    raise ArgumentError.new(_("You can only save objects that respond to :name")) unless request.instance.respond_to?(:name)
 
     file = path(request.key)
 
@@ -29,15 +29,15 @@ class Puppet::Indirector::Yaml < Puppet::Indirector::Terminus
     begin
       Puppet::Util::Yaml.dump(request.instance, file)
     rescue TypeError => detail
-      Puppet.err "Could not save #{self.name} #{request.key}: #{detail}"
+      Puppet.err _("Could not save %{indirection} %{request}: %{detail}") % { indirection: self.name, request: request.key, detail: detail }
     end
   end
 
   # Return the path to a given node's file.
   def path(name,ext='.yaml')
     if name =~ Puppet::Indirector::BadNameRegexp then
-      Puppet.crit("directory traversal detected in #{self.class}: #{name.inspect}")
-      raise ArgumentError, "invalid key"
+      Puppet.crit(_("directory traversal detected in %{indirection}: %{name}") % { indirection: self.class, name: name.inspect })
+      raise ArgumentError, _("invalid key")
     end
 
     base = Puppet.run_mode.master? ? Puppet[:yamldir] : Puppet[:clientyamldir]

data/lib/puppet/indirector.rb

@@ -22,7 +22,7 @@ module Puppet::Indirector
       Puppet::Indirector::Terminus.terminus_class(indirection_name, terminus_name || cache_name)
 
       indirection = Puppet::Indirector::Indirection.instance(indirection_name)
-      raise "Indirection #{indirection_name} does not exist" unless indirection
+      raise _("Indirection %{indirection_name} does not exist") % { indirection_name: indirection_name } unless indirection
 
       indirection.terminus_class = terminus_name if terminus_name
       indirection.cache_class = cache_name if cache_name
@@ -35,7 +35,7 @@ module Puppet::Indirector
   # evaluated at parse time, which is before the user has had a chance
   # to override it.
   def indirects(indirection, options = {})
-    raise(ArgumentError, "Already handling indirection for #{@indirection.name}; cannot also handle #{indirection}") if @indirection
+    raise(ArgumentError, _("Already handling indirection for %{current}; cannot also handle %{next}") % { current: @indirection.name, next: indirection }) if @indirection
     # populate this class with the various new methods
     extend ClassMethods
     include Puppet::Indirector::Envelope

data/lib/puppet/info_service/class_information_service.rb

@@ -15,7 +15,7 @@ class Puppet::InfoService::ClassInformationService
     # feature flags in effect.
 
     unless env_file_hash.is_a?(Hash)
-      raise ArgumentError, 'Given argument must be a Hash'
+      raise ArgumentError, _('Given argument must be a Hash')
     end
 
     result = {}
@@ -52,7 +52,7 @@ class Puppet::InfoService::ClassInformationService
   end
 
   def parse_file(f)
-    return {:error => "The file #{f} does not exist"} unless Puppet::FileSystem.exist?(f)
+    return {:error => _("The file %{f} does not exist") % { f: f }} unless Puppet::FileSystem.exist?(f)
 
     begin
       parse_result = @parser.parse_file(f)
@@ -105,7 +105,6 @@ class Puppet::InfoService::ClassInformationService
 
   # Extracts the source for the expression
   def extract_value_source(value_expr)
-    position = Puppet::Pops::Adapters::SourcePosAdapter.adapt(value_expr)
-    position.extract_tree_text
+    value_expr.locator.extract_tree_text(value_expr)
   end
-end
+end

data/lib/puppet/interface/face_collection.rb

@@ -41,10 +41,15 @@ module Puppet::Interface::FaceCollection
     return @faces[name][:current] if pattern == :current
 
     versions = @faces[name].keys - [ :current ]
-    found    = SemVer.find_matching(pattern, versions)
+    range = pattern.is_a?(SemanticPuppet::Version) ? SemanticPuppet::VersionRange.new(pattern, pattern) : SemanticPuppet::VersionRange.parse(pattern)
+    found = find_matching(range, versions)
     return @faces[name][found]
   end
 
+  def self.find_matching(range, versions)
+    versions.select { |v| range === v }.sort.last
+  end
+
   # try to load the face, and return it.
   def self.load_face(name, version)
     # We always load the current version file; the common case is that we have

data/lib/puppet/interface.rb

@@ -1,7 +1,6 @@
 require 'puppet'
 require 'puppet/util/autoload'
 require 'prettyprint'
-require 'semver'
 
 # @api public
 class Puppet::Interface
@@ -138,7 +137,7 @@ class Puppet::Interface
   attr_reader :name
 
   # The version of the face
-  # @return [SemVer]
+  # @return [SemanticPuppet::Version]
   attr_reader :version
 
   # The autoloader instance for the face
@@ -154,10 +153,7 @@ class Puppet::Interface
     end
 
     @name    = Puppet::Interface::FaceCollection.underscorize(name)
-
-    # SemVer is deprecated but in 4.x we must use it here (the attr_reader is public api). The
-    # extra boolean argument suppresses the deprecation warning.
-    @version = SemVer.new(version, true)
+    @version = SemanticPuppet::Version.parse(version)
 
     # The few bits of documentation we actually demand.  The default license
     # is a favour to our end users; if you happen to get that in a core face

data/lib/puppet/module.rb

@@ -1,5 +1,4 @@
 require 'puppet/util/logging'
-require 'semver'
 require 'json'
 
 # Support for modules
@@ -59,9 +58,10 @@ class Puppet::Module
   attr_accessor :dependencies, :forge_name
   attr_accessor :source, :author, :version, :license, :summary, :description, :project_page
 
-  def initialize(name, path, environment)
+  def initialize(name, path, environment, strict_semver = true)
     @name = name
     @path = path
+    @strict_semver = strict_semver
     @environment = environment
 
     assert_validity
@@ -96,7 +96,7 @@ class Puppet::Module
   FILETYPES.each do |type, location|
     # A boolean method to let external callers determine if
     # we have files of a given type.
-    define_method(type +'?') do
+    define_method(type + '?') do
       type_subpath = subpath(location)
       unless Puppet::FileSystem.exist?(type_subpath)
         Puppet.debug("No #{type} found in subpath '#{type_subpath}' " +
@@ -146,7 +146,9 @@ class Puppet::Module
   rescue JSON::JSONError => e
     msg = "#{name} has an invalid and unparsable metadata.json file. The parse error: #{e.message}"
     case Puppet[:strict]
-    when :off, :warning
+    when :off
+      Puppet.debug(msg)
+    when :warning
       Puppet.warning(msg)
     when :error
       raise FaultyMetadata, msg
@@ -326,9 +328,8 @@ class Puppet::Module
 
       if version_string
         begin
-          # Suppress deprecation warnings from SemVer in 4.9. In 5.0, this will be SemanticPuppet instead
-          required_version_semver_range = SemVer[version_string, true]
-          actual_version_semver = SemVer.new(dep_mod.version, true)
+          required_version_semver_range = SemanticPuppet::VersionRange.parse(version_string, @strict_semver)
+          actual_version_semver = SemanticPuppet::Version.parse(dep_mod.version)
         rescue ArgumentError
           error_details[:reason] = :non_semantic_version
           unmet_dependencies << error_details
@@ -353,6 +354,10 @@ class Puppet::Module
     self.environment == other.environment
   end
 
+  def strict_semver?
+    @strict_semver
+  end
+
   private
 
   def wanted_manifests_from(pattern)

data/lib/puppet/module_tool/applications/application.rb

@@ -1,5 +1,4 @@
 require 'net/http'
-require 'semver'
 require 'json'
 require 'puppet/util/colors'
 
@@ -37,11 +36,11 @@ module Puppet::ModuleTool
         @metadata = Puppet::ModuleTool::Metadata.new
 
         unless @path
-          raise ArgumentError, "Could not determine module path"
+          raise ArgumentError, _("Could not determine module path")
         end
 
         if require_metadata && !Puppet::ModuleTool.is_module_root?(@path)
-          raise ArgumentError, "Unable to find metadata.json in module root at #{@path} See https://docs.puppet.com/puppet/latest/reference/modules_publishing.html for required file format."
+          raise ArgumentError, _("Unable to find metadata.json in module root at %{path} See https://docs.puppet.com/puppet/latest/reference/modules_publishing.html for required file format.") % { path: @path }
         end
 
         metadata_path   = File.join(@path, 'metadata.json')
@@ -51,13 +50,13 @@ module Puppet::ModuleTool
             begin
               @metadata.update(JSON.load(f))
             rescue JSON::ParserError => ex
-              raise ArgumentError, "Could not parse JSON #{metadata_path}", ex.backtrace
+              raise ArgumentError, _("Could not parse JSON %{metadata_path}") % { metadata_path: metadata_path }, ex.backtrace
             end
           end
         end
 
         if File.file?(File.join(@path, 'Modulefile'))
-          Puppet.warning "A Modulefile was found in the root directory of the module. This file will be ignored and can safely be removed."
+          Puppet.warning _("A Modulefile was found in the root directory of the module. This file will be ignored and can safely be removed.")
         end
 
         return @metadata
@@ -69,14 +68,14 @@ module Puppet::ModuleTool
       end
 
       def parse_filename(filename)
-        if match = /^((.*?)-(.*?))-(\d+\.\d+\.\d+.*?)$/.match(File.basename(filename,'.tar.gz'))
+        if match = /^((.*?)-(.*?))-(\d+\.\d+\.\d+.*?)$/.match(File.basename(filename, '.tar.gz'))
           module_name, author, shortname, version = match.captures
         else
-          raise ArgumentError, "Could not parse filename to obtain the username, module name and version.  (#{@release_name})"
+          raise ArgumentError, _("Could not parse filename to obtain the username, module name and version.  (%{release_name})") % { release_name: @release_name }
         end
 
-        unless SemVer.valid?(version)
-          raise ArgumentError, "Invalid version format: #{version} (Semantic Versions are acceptable: http://semver.org)"
+        unless SemanticPuppet::Version.valid?(version)
+          raise ArgumentError, _("Invalid version format: %{version} (Semantic Versions are acceptable: http://semver.org)") % { version: version }
         end
 
         return {

data/lib/puppet/module_tool/applications/builder.rb

@@ -18,7 +18,7 @@ module Puppet::ModuleTool
         create_directory
         copy_contents
         write_json
-        Puppet.notice "Building #{@path} for release"
+        Puppet.notice _("Building %{path} for release") % { path: @path }
         pack
         relative = Pathname.new(archive_file).relative_path_from(Pathname.new(File.expand_path(Dir.pwd)))
 
@@ -114,10 +114,10 @@ module Puppet::ModuleTool
           symlinks.each do |s|
             s = Pathname.new s
             mpath = Pathname.new @path
-            Puppet.warning "Symlinks in modules are unsupported. Please investigate symlink #{s.relative_path_from mpath} -> #{s.realpath.relative_path_from mpath}."
+            Puppet.warning _("Symlinks in modules are unsupported. Please investigate symlink %{from} -> %{to}.") % { from: s.relative_path_from(mpath), to: s.realpath.relative_path_from(mpath) }
           end
 
-          raise Puppet::ModuleTool::Errors::ModuleToolError, "Found symlinks. Symlinks in modules are not allowed, please remove them."
+          raise Puppet::ModuleTool::Errors::ModuleToolError, _("Found symlinks. Symlinks in modules are not allowed, please remove them.")
         end
       end
 
@@ -125,7 +125,7 @@ module Puppet::ModuleTool
         metadata_path = File.join(build_path, 'metadata.json')
 
         if metadata.to_hash.include? 'checksums'
-          Puppet.warning "A 'checksums' field was found in metadata.json. This field will be ignored and can safely be removed."
+          Puppet.warning _("A 'checksums' field was found in metadata.json. This field will be ignored and can safely be removed.")
         end
 
         # TODO: This may necessarily change the order in which the metadata.json
@@ -135,9 +135,8 @@ module Puppet::ModuleTool
           f.write(metadata.to_json)
         end
 
-        # PSON.pretty_generate is a BINARY string
         Puppet::FileSystem.open(File.join(build_path, 'checksums.json'), nil, 'wb') do |f|
-          f.write(PSON.pretty_generate(Checksums.new(build_path)))
+          f.write(JSON.pretty_generate(Checksums.new(build_path)))
         end
       end