puppet 3.5.0.rc3 → 3.5.1.rc1

data/spec/unit/parser/compiler_spec.rb

@@ -66,7 +66,7 @@ describe Puppet::Parser::Compiler do
     now = Time.now
     Time.stubs(:now).returns(now)
 
-    environment = Puppet::Node::Environment.create(:testing, [], '')
+    environment = Puppet::Node::Environment.create(:testing, [])
     @node = Puppet::Node.new("testnode",
                              :facts => Puppet::Node::Facts.new("facts", {}),
                              :environment => environment)

data/spec/unit/parser/files_spec.rb

@@ -6,7 +6,7 @@ require 'puppet/parser/files'
 describe Puppet::Parser::Files do
   include PuppetSpec::Files
 
-  let(:environment) { Puppet::Node::Environment.create(:testing, [], '') }
+  let(:environment) { Puppet::Node::Environment.create(:testing, []) }
 
   before do
     @basepath = make_absolute("/somepath")
@@ -140,7 +140,7 @@ describe Puppet::Parser::Files do
     end
 
     it "does not find the module when it is a different environment" do
-      different_env = Puppet::Node::Environment.create(:different, [], '')
+      different_env = Puppet::Node::Environment.create(:different, [])
       a_module_in_environment(environment, "mymod")
 
       Puppet::Parser::Files.find_manifests_in_modules("mymod/init.pp", different_env).should_not include("mymod")

data/spec/unit/parser/functions_spec.rb

@@ -8,7 +8,7 @@ describe Puppet::Parser::Functions do
 
   let(:function_module) { Puppet::Parser::Functions.environment_module(Puppet.lookup(:current_environment)) }
 
-  let(:environment) { Puppet::Node::Environment.create(:myenv, [], '') }
+  let(:environment) { Puppet::Node::Environment.create(:myenv, []) }
 
   before do
     Puppet::Parser::Functions.reset
@@ -72,7 +72,7 @@ describe Puppet::Parser::Functions do
         end
       end
 
-      Puppet.override(:current_environment => Puppet::Node::Environment.create(:other, [], '')) do
+      Puppet.override(:current_environment => Puppet::Node::Environment.create(:other, [])) do
         Puppet::Parser::Functions.newfunction("other_env", :type => :rvalue) do |args|
         end
 

data/spec/unit/parser/parser_spec.rb

@@ -19,12 +19,12 @@ describe Puppet::Parser do
   end
 
   it "should set the environment" do
-    env = Puppet::Node::Environment.create(:testing, [], '')
+    env = Puppet::Node::Environment.create(:testing, [])
     Puppet::Parser::Parser.new(env).environment.should == env
   end
 
   it "should be able to look up the environment-specific resource type collection" do
-    env = Puppet::Node::Environment.create(:development, [], '')
+    env = Puppet::Node::Environment.create(:development, [])
     rtc = env.known_resource_types
     parser = Puppet::Parser::Parser.new env
     parser.known_resource_types.should equal(rtc)

data/spec/unit/parser/resource_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Puppet::Parser::Resource do
   before do
-    environment = Puppet::Node::Environment.create(:testing, [], '')
+    environment = Puppet::Node::Environment.create(:testing, [])
     @node = Puppet::Node.new("yaynode", :environment => environment)
     @known_resource_types = environment.known_resource_types
     @compiler = Puppet::Parser::Compiler.new(@node)

data/spec/unit/parser/scope_spec.rb

@@ -64,7 +64,7 @@ describe Puppet::Parser::Scope do
   end
 
   it "should get its environment from its compiler" do
-    env = Puppet::Node::Environment.create(:testing, [], '')
+    env = Puppet::Node::Environment.create(:testing, [])
     compiler = stub 'compiler', :environment => env, :is_a? => true
     scope = Puppet::Parser::Scope.new(compiler)
     scope.environment.should equal(env)
@@ -87,7 +87,7 @@ describe Puppet::Parser::Scope do
   end
 
   describe "when custom functions are called" do
-    let(:env) { Puppet::Node::Environment.create(:testing, [], '') }
+    let(:env) { Puppet::Node::Environment.create(:testing, []) }
     let(:compiler) { Puppet::Parser::Compiler.new(Puppet::Node.new('foo', :environment => env)) }
     let(:scope) { Puppet::Parser::Scope.new(compiler) }
 
@@ -120,7 +120,7 @@ describe Puppet::Parser::Scope do
 
   describe "when initializing" do
     it "should extend itself with its environment's Functions module as well as the default" do
-      env = Puppet::Node::Environment.create(:myenv, [], '')
+      env = Puppet::Node::Environment.create(:myenv, [])
       root = Puppet.lookup(:root_environment)
       compiler = stub 'compiler', :environment => env, :is_a? => true
 

data/spec/unit/pops/parser/lexer2_spec.rb

@@ -208,6 +208,17 @@ describe 'Lexer2' do
     end
   end
 
+  { '"$"'      => '$',
+    '"a$"'     => 'a$',
+    '"a$%b"'  => "a$%b",
+    '"a$$"'  => "a$$",
+    '"a$$%"'  => "a$$%",
+  }.each do |source, expected|
+    it "should lex interpolation including false starts #{source}" do
+      tokens_scanned_from(source).should match_tokens2([:STRING, expected])
+    end
+  end
+
   it "differentiates between foo[x] and foo [x] (whitespace)" do
     tokens_scanned_from("$a[1]").should match_tokens2(:VARIABLE, :LBRACK, :NUMBER, :RBRACK)
     tokens_scanned_from("$a [1]").should match_tokens2(:VARIABLE, :LBRACK, :NUMBER, :RBRACK)

data/spec/unit/pops/parser/parse_heredoc_spec.rb

@@ -58,7 +58,7 @@ describe "egrammar parsing heredoc" do
     ].join("\n")
   end
 
-  it "parses interpolated heredoc epression" do
+  it "parses interpolated heredoc expression" do
     src = <<-CODE
     @("END")
     Hello $name
@@ -70,4 +70,18 @@ describe "egrammar parsing heredoc" do
       ")"
     ].join("\n")
   end
+
+  it "parses interpolated heredoc expression with false start on $" do
+    src = <<-CODE
+    @("END")
+    Hello $name$%a
+    |- END
+    CODE
+    dump(parse(src)).should == [
+      "(@()",
+      "  (sublocated (cat 'Hello ' (str $name) '$%a'))",
+      ")"
+    ].join("\n")
+  end
+
 end

data/spec/unit/provider/yumrepo/inifile_spec.rb

@@ -10,24 +10,28 @@ describe Puppet::Type.type(:yumrepo).provider(:inifile) do
 
   describe 'self.instances' do
     let(:updates_section) do
-      stub('inifile updates section',
-           :name => 'updates',
-           :entries => {'name' => 'updates', 'enabled' => '1', 'descr' => 'test updates'})
+      sect = Puppet::Util::IniConfig::Section.new('updates', '/some/imaginary/file')
+      sect.entries << ['name', 'Some long description of the repo']
+      sect.entries << ['enabled', '1']
+
+      sect
     end
 
     it 'finds any existing sections' do
       virtual_inifile.expects(:each_section).yields(updates_section)
+      virtual_inifile.stubs(:[]).with('updates').returns(updates_section)
 
       providers = described_class.instances
       providers.should have(1).items
       providers[0].name.should == 'updates'
+      providers[0].descr.should == 'Some long description of the repo'
       providers[0].enabled.should == '1'
     end
   end
 
-  describe "methods used by ensurable" do
+  describe "setting and getting properties" do
 
-    let(:type) do
+    let(:type_instance) do
       Puppet::Type.type(:yumrepo).new(
         :name     => 'puppetlabs-products',
         :ensure   => :present,
@@ -39,31 +43,75 @@ describe Puppet::Type.type(:yumrepo).provider(:inifile) do
       )
     end
 
-    let(:provider) { type.provider }
+    let(:provider) do
+      described_class.new(type_instance)
+    end
 
-    let(:puppetlabs_section) { stub('inifile puppetlabs section', :name => 'puppetlabs-products') }
+    let(:section) do
+      stub('inifile puppetlabs section', :name => 'puppetlabs-products')
+    end
 
-    it "#create sets the yumrepo properties on the according section" do
-      described_class.expects(:section).returns(puppetlabs_section)
-      puppetlabs_section.expects(:[]=).with('baseurl', 'http://yum.puppetlabs.com/el/6/products/$basearch')
-      puppetlabs_section.expects(:[]=).with('descr', 'Puppet Labs Products El 6 - $basearch')
-      puppetlabs_section.expects(:[]=).with('enabled', '1')
-      puppetlabs_section.expects(:[]=).with('gpgcheck', '1')
-      puppetlabs_section.expects(:[]=).with('gpgkey', 'file:///etc/pki/rpm-gpg/RPM-GPG-KEY-puppetlabs')
+    before do
+      type_instance.provider = provider
+      described_class.stubs(:section).with('puppetlabs-products').returns(section)
+    end
 
-      provider.create
+    describe "methods used by ensurable" do
+      it "#create sets the yumrepo properties on the according section" do
+        section.expects(:[]=).with('baseurl', 'http://yum.puppetlabs.com/el/6/products/$basearch')
+        section.expects(:[]=).with('name', 'Puppet Labs Products El 6 - $basearch')
+        section.expects(:[]=).with('enabled', '1')
+        section.expects(:[]=).with('gpgcheck', '1')
+        section.expects(:[]=).with('gpgkey', 'file:///etc/pki/rpm-gpg/RPM-GPG-KEY-puppetlabs')
+
+        provider.create
+      end
+
+      it "#exists? checks if the repo has been marked as present" do
+        described_class.stubs(:section).returns(stub(:[]= => nil))
+        provider.create
+        expect(provider).to be_exist
+      end
+
+      it "#destroy deletes the associated ini file section" do
+        described_class.expects(:section).returns(section)
+        section.expects(:destroy=).with(true)
+        provider.destroy
+      end
     end
 
-    it "#exists? checks if the repo has been marked as present" do
-      described_class.stubs(:section).returns(stub(:[]= => nil))
-      provider.create
-      expect(provider).to be_exist
+    describe "getting properties" do
+      it "maps the 'descr' property to the 'name' INI property" do
+        section.expects(:[]).with('name').returns 'Some rather long description of the repository'
+        expect(provider.descr).to eq 'Some rather long description of the repository'
+      end
+
+      it "gets the property from the INI section" do
+        section.expects(:[]).with('enabled').returns '1'
+        expect(provider.enabled).to eq '1'
+      end
+
+      it "sets the property as :absent if the INI property is nil" do
+        section.expects(:[]).with('exclude').returns nil
+        expect(provider.exclude).to eq :absent
+      end
     end
 
-    it "#destroy deletes the associated ini file section" do
-      described_class.expects(:section).returns(puppetlabs_section)
-      puppetlabs_section.expects(:destroy=).with(true)
-      provider.destroy
+    describe "setting properties" do
+      it "maps the 'descr' property to the 'name' INI property" do
+        section.expects(:[]=).with('name', 'Some rather long description of the repository')
+        provider.descr = 'Some rather long description of the repository'
+      end
+
+      it "sets the property on the INI section" do
+        section.expects(:[]=).with('enabled', '0')
+        provider.enabled = '0'
+      end
+
+      it "sets the section field to nil when the specified value is absent" do
+        section.expects(:[]=).with('exclude', nil)
+        provider.exclude = :absent
+      end
     end
   end
 

data/spec/unit/rails/host_spec.rb

@@ -40,7 +40,7 @@ describe "Puppet::Rails::Host", :if => can_use_scratch_database? do
 
     it "should stringify the environment" do
       host = Puppet::Rails::Host.new
-      host.environment = Puppet::Node::Environment.create(:production, [], '')
+      host.environment = Puppet::Node::Environment.create(:production, [])
       host.environment.class.should == String
     end
 

data/spec/unit/resource/type_collection_spec.rb

@@ -7,7 +7,7 @@ require 'puppet/resource/type'
 describe Puppet::Resource::TypeCollection do
   include PuppetSpec::Files
 
-  let(:environment) { Puppet::Node::Environment.create(:testing, [], '') }
+  let(:environment) { Puppet::Node::Environment.create(:testing, []) }
 
   before do
     @instance = Puppet::Resource::Type.new(:hostclass, "foo")

data/spec/unit/resource/type_spec.rb

@@ -347,7 +347,7 @@ describe Puppet::Resource::Type do
 
   describe "when describing and managing parent classes" do
     before do
-      environment = Puppet::Node::Environment.create(:testing, [], '')
+      environment = Puppet::Node::Environment.create(:testing, [])
       @krt = environment.known_resource_types
       @parent = Puppet::Resource::Type.new(:hostclass, "bar")
       @krt.add @parent

data/spec/unit/resource_spec.rb

@@ -6,7 +6,7 @@ describe Puppet::Resource do
   include PuppetSpec::Files
 
   let(:basepath) { make_absolute("/somepath") }
-  let(:environment) { Puppet::Node::Environment.create(:testing, [], '') }
+  let(:environment) { Puppet::Node::Environment.create(:testing, []) }
 
   [:catalog, :file, :line].each do |attr|
     it "should have an #{attr} attribute" do

data/spec/unit/type/yumrepo_spec.rb

@@ -1,78 +1,243 @@
 require 'spec_helper'
 require 'puppet'
 
-describe Puppet::Type.type(:yumrepo) do
-  let(:yumrepo) {
-    Puppet::Type.type(:yumrepo).new(
-      :name => "puppetlabs"
-    )
-  }
+shared_examples_for "a yumrepo parameter that can be absent" do |param|
+  it "can be set as :absent" do
+    described_class.new(:name => 'puppetlabs', param => :absent)
+  end
+end
 
-  describe "When validating attributes" do
-    it "should have a 'name' parameter'" do
-      yumrepo[:name].should == "puppetlabs"
-    end
+shared_examples_for "a yumrepo parameter that expects a boolean parameter" do |param|
+  valid_values = %w[True False 0 1 No Yes]
 
-    [:baseurl, :cost, :descr, :enabled, :enablegroups, :exclude, :failovermethod,
-     :gpgcheck, :repo_gpgcheck, :gpgkey, :http_caching, :include, :includepkgs, :keepalive,
-     :metadata_expire, :mirrorlist, :priority, :protect, :proxy, :proxy_username,
-     :proxy_password, :timeout, :sslcacert, :sslverify, :sslclientcert,
-     :sslclientkey, :s3_enabled, :metalink].each do |param|
-      it "should have a '#{param}' parameter" do
-        Puppet::Type.type(:yumrepo).attrtype(param).should == :property
-      end
+  valid_values.each do |value|
+    it "accepts a valid value of #{value}" do
+      instance = described_class.new(:name => 'puppetlabs', param => value)
+      expect(instance[param]).to eq value
+    end
+    it "accepts #{value} downcased to #{value.downcase}" do
+      instance = described_class.new(:name => 'puppetlabs', param => value.downcase)
+      expect(instance[param]).to eq value.downcase
     end
   end
 
-  describe "When validating attribute values" do
-    [:cost, :enabled, :enablegroups, :failovermethod, :gpgcheck, :repo_gpgcheck, :http_caching,
-     :keepalive, :metadata_expire, :priority, :protect, :timeout].each do |param|
-      it "should support :absent as a value to '#{param}' parameter" do
-        Puppet::Type.type(:yumrepo).new(:name => 'puppetlabs', param => :absent)
+  it "rejects invalid boolean values" do
+    expect {
+      described_class.new(:name => 'puppetlabs', param => 'flase')
+    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
+  end
+end
+
+shared_examples_for "a yumrepo parameter that accepts a single URL" do |param|
+  it "can accept a single URL" do
+    described_class.new(
+      :name => 'puppetlabs',
+      param => 'http://localhost/yumrepos'
+    )
+  end
+
+  it "fails if an invalid URL is provided" do
+    expect {
+      described_class.new(
+        :name => 'puppetlabs',
+        param => "that's no URL!"
+      )
+    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
+  end
+
+  it "fails if a valid URL uses an invalid URI scheme" do
+    expect {
+      described_class.new(
+        :name => 'puppetlabs',
+        param => 'ldap://localhost/yumrepos'
+      )
+    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
+  end
+end
+
+shared_examples_for "a yumrepo parameter that accepts multiple URLs" do |param|
+  it "can accept multiple URLs" do
+    described_class.new(
+      :name => 'puppetlabs',
+      param => 'http://localhost/yumrepos http://localhost/more-yumrepos'
+    )
+  end
+
+  it "fails if multiple URLs are given and one is invalid" do
+    expect {
+      described_class.new(
+        :name => 'puppetlabs',
+        param => "http://localhost/yumrepos That's no URL!"
+      )
+    }.to raise_error(Puppet::ResourceError, /Parameter #{param} failed/)
+  end
+end
+
+describe Puppet::Type.type(:yumrepo) do
+  it "has :name as its namevar" do
+    expect(described_class.key_attributes).to eq [:name]
+  end
+
+  describe "validating" do
+
+    describe "name" do
+      it "is a valid parameter" do
+        instance = described_class.new(:name => 'puppetlabs')
+        expect(instance.name).to eq 'puppetlabs'
       end
     end
 
-    [:cost, :enabled, :enablegroups, :gpgcheck, :repo_gpgcheck, :keepalive, :metadata_expire,
-     :priority, :protect, :timeout].each do |param|
-      it "should fail if '#{param}' is not true/false, 0/1, or yes/no" do
-        expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "notanumber") }.to raise_error
-      end
+    describe "target" do
+      it_behaves_like "a yumrepo parameter that can be absent", :target
     end
 
-    [:enabled, :enabledgroups, :gpgcheck, :repo_gpgcheck, :keepalive, :protect, :s3_enabled].each do |param|
-      it "should fail if '#{param}' does not have one of the following values (0|1)" do
-        expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "2") }.to raise_error
-      end
+    describe "descr" do
+      it_behaves_like "a yumrepo parameter that can be absent", :descr
+    end
+
+    describe "mirrorlist" do
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :mirrorlist
+      it_behaves_like "a yumrepo parameter that can be absent", :mirrorlist
+    end
+
+    describe "baseurl" do
+      it_behaves_like "a yumrepo parameter that can be absent", :baseurl
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :baseurl
+      it_behaves_like "a yumrepo parameter that accepts multiple URLs", :baseurl
+    end
+
+    describe "enabled" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :enabled
+      it_behaves_like "a yumrepo parameter that can be absent", :enabled
+    end
+
+    describe "gpgcheck" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :gpgcheck
+      it_behaves_like "a yumrepo parameter that can be absent", :gpgcheck
+    end
+
+    describe "repo_gpgcheck" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :repo_gpgcheck
+      it_behaves_like "a yumrepo parameter that can be absent", :repo_gpgcheck
+    end
+
+    describe "gpgkey" do
+      it_behaves_like "a yumrepo parameter that can be absent", :gpgkey
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :gpgkey
+      it_behaves_like "a yumrepo parameter that accepts multiple URLs", :gpgkey
+    end
+
+    describe "include" do
+      it_behaves_like "a yumrepo parameter that can be absent", :include
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :include
     end
 
-    it "should fail if 'failovermethod' does not have one of the following values (roundrobin|priority)" do
-      expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", :failovermethod => "notavalidvalue") }.to raise_error
+    describe "exclude" do
+      it_behaves_like "a yumrepo parameter that can be absent", :exclude
     end
 
-    it "should fail if 'http_caching' does not have one of the following values (packages|all|none)" do
-      expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", :http_caching => "notavalidvalue") }.to raise_error
+    describe "includepkgs" do
+      it_behaves_like "a yumrepo parameter that can be absent", :includepkgs
     end
 
-    it "should fail if 'sslverify' does not have one of the following values (True|False)" do
-      expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", :sslverify => "notavalidvalue") }.to raise_error
+    describe "enablegroups" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :enablegroups
+      it_behaves_like "a yumrepo parameter that can be absent", :enablegroups
+    end
+
+    describe "failovermethod" do
+
+      %w[roundrobin priority].each do |value|
+        it "accepts a value of #{value}" do
+          described_class.new(:name => "puppetlabs", :failovermethod => value)
+        end
+      end
+
+      it "raises an error if an invalid value is given" do
+        expect {
+          described_class.new(:name => "puppetlabs", :failovermethod => "notavalidvalue")
+        }.to raise_error(Puppet::ResourceError, /Parameter failovermethod failed/)
+      end
+
+      it_behaves_like "a yumrepo parameter that can be absent", :failovermethod
     end
 
-    it "should succeed if 'sslverify' has one of the following values (True|False)" do
-      Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", :sslverify => "True")[:sslverify].should == "True"
-      Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", :sslverify => "False")[:sslverify].should == "False"
+    describe "keepalive" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :keepalive
+      it_behaves_like "a yumrepo parameter that can be absent", :keepalive
     end
 
-    [:mirrorlist, :baseurl, :gpgkey, :include, :proxy, :metalink].each do |param|
-      it "should succeed if '#{param}' uses one of the following protocols (file|http|https|ftp)" do
-        Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "file:///srv/example/")[param].should =~ %r{\Afile://}
-        Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "http://example.com/")[param].should =~ %r{\Ahttp://}
-        Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "https://example.com/")[param].should =~ %r{\Ahttps://}
-        Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "ftp://example.com/")[param].should =~ %r{\Aftp://}
+    describe "http_caching" do
+      %w[packages all none].each do |value|
+        it "accepts a valid value of #{value}" do
+          described_class.new(:name => 'puppetlabs', :http_caching => value)
+        end
       end
 
-      it "should fail if '#{param}' does not use one of the following protocols (file|http|https|ftp)" do
-        expect { Puppet::Type.type(:yumrepo).new(:name => "puppetlabs", param => "gopher://example.com/") }.to raise_error
+      it "rejects invalid values" do
+        expect {
+          described_class.new(:name => 'puppetlabs', :http_caching => 'yes')
+        }.to raise_error(Puppet::ResourceError, /Parameter http_caching failed/)
       end
+
+      it_behaves_like "a yumrepo parameter that can be absent", :http_caching
+    end
+
+    describe "timeout" do
+      it_behaves_like "a yumrepo parameter that can be absent", :timeout
+    end
+
+    describe "metadata_expire" do
+      it_behaves_like "a yumrepo parameter that can be absent", :metadata_expire
+    end
+
+    describe "protect" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :protect
+      it_behaves_like "a yumrepo parameter that can be absent", :protect
+    end
+
+    describe "priority" do
+      it_behaves_like "a yumrepo parameter that can be absent", :priority
+    end
+
+    describe "proxy" do
+      it_behaves_like "a yumrepo parameter that can be absent", :proxy
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :proxy
+    end
+
+    describe "proxy_username" do
+      it_behaves_like "a yumrepo parameter that can be absent", :proxy_username
+    end
+
+    describe "proxy_password" do
+      it_behaves_like "a yumrepo parameter that can be absent", :proxy_password
+    end
+
+    describe "s3_enabled" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :s3_enabled
+      it_behaves_like "a yumrepo parameter that can be absent", :s3_enabled
+    end
+
+    describe "sslcacert" do
+      it_behaves_like "a yumrepo parameter that can be absent", :sslcacert
+    end
+
+    describe "sslverify" do
+      it_behaves_like "a yumrepo parameter that expects a boolean parameter", :sslverify
+      it_behaves_like "a yumrepo parameter that can be absent", :sslverify
+    end
+
+    describe "sslclientcert" do
+      it_behaves_like "a yumrepo parameter that can be absent", :sslclientcert
+    end
+
+    describe "sslclientkey" do
+      it_behaves_like "a yumrepo parameter that can be absent", :sslclientkey
+    end
+
+    describe "metalink" do
+      it_behaves_like "a yumrepo parameter that can be absent", :metalink
+      it_behaves_like "a yumrepo parameter that accepts a single URL", :metalink
     end
   end
 end