puppet 3.4.3 → 3.5.0.rc1

data/lib/puppet/pops/evaluator/external_syntax_support.rb

@@ -0,0 +1,49 @@
+# This module is an integral part of the evaluator. It deals with the concern of validating
+# external syntax in text produced by heredoc and templates.
+#
+module Puppet::Pops::Evaluator::ExternalSyntaxSupport
+  # TODO: This can be simplified if the Factory directly supporteded hash_of/type_of
+  TYPES = Puppet::Pops::Types::TypeFactory
+
+  def assert_external_syntax(scope, result, syntax, reference_expr)
+    @@HASH_OF_SYNTAX_CHECKERS ||= TYPES.hash_of(TYPES.type_of(::Puppetx::SYNTAX_CHECKERS_TYPE))
+    # ignore 'unspecified syntax'
+    return if syntax.nil? || syntax == ''
+
+    checker = checker_for_syntax(scope, syntax)
+    # ignore syntax with no matching checker
+    return unless checker
+
+    # Call checker and give it the location information from the expression
+    # (as opposed to where the heredoc tag is (somewhere on the line above)).
+    acceptor = Puppet::Pops::Validation::Acceptor.new()
+    source_pos = find_closest_positioned(reference_expr)
+    checker.check(result, syntax, acceptor, source_pos)
+
+    if acceptor.error_count > 0
+      checker_message = "Invalid produced text having syntax: '#{syntax}'."
+      Puppet::Pops::IssueReporter.assert_and_report(acceptor, :message => checker_message)
+      raise ArgumentError, "Internal Error: Configuration of runtime error handling wrong: should have raised exception"
+    end
+  end
+
+  # Finds the most significant checker for the given syntax (most significant is to the right).
+  # Returns nil if there is no registered checker.
+  #
+  def checker_for_syntax(scope, syntax)
+    checkers_hash = scope.compiler.injector.lookup(scope, @@HASH_OF_SYNTAX_CHECKERS, ::Puppetx::SYNTAX_CHECKERS) || {}
+    checkers_hash[lookup_keys_for_syntax(syntax).find {|x| checkers_hash[x] }]
+  end
+
+  # Returns an array of possible syntax names
+  def lookup_keys_for_syntax(syntax)
+    segments = syntax.split(/\+/)
+    result = []
+    begin
+      result << segments.join("+")
+      segments.shift
+    end until segments.empty?
+    result
+  end
+
+end

data/lib/puppet/pops/evaluator/relationship_operator.rb

@@ -0,0 +1,156 @@
+# The RelationshipOperator implements the semantics of the -> <- ~> <~ operators creating relationships or notification
+# relationships between the left and right hand side's references to resources.
+#
+# This is separate class since a second level of evaluation is required that transforms string in left or right hand
+# to type references. The task of "making a relationship" is delegated to the "runtime support" class that is included.
+# This is done to separate the concerns of the new evaluator from the 3x runtime; messy logic goes into the runtime support
+# module. Later when more is cleaned up this can be simplified further.
+#
+class Puppet::Pops::Evaluator::RelationshipOperator
+
+  # Provides access to the Puppet 3.x runtime (scope, etc.)
+  # This separation has been made to make it easier to later migrate the evaluator to an improved runtime.
+  #
+  include Puppet::Pops::Evaluator::Runtime3Support
+
+  Issues = Puppet::Pops::Issues
+
+  class IllegalRelationshipOperandError < RuntimeError
+    attr_reader :operand
+    def initialize operand
+      @operand = operand
+    end
+  end
+
+  class NotCatalogTypeError < RuntimeError
+    attr_reader :type
+    def initialize type
+      @type = type
+    end
+  end
+
+  def initialize
+    @type_transformer_visitor = Puppet::Pops::Visitor.new(self, "transform", 1, 1)
+    @type_calculator = Puppet::Pops::Types::TypeCalculator.new()
+    @type_parser = Puppet::Pops::Types::TypeParser.new()
+
+    @catalog_type = Puppet::Pops::Types::TypeFactory.catalog_entry()
+  end
+
+  def transform(o, scope)
+    @type_transformer_visitor.visit_this_1(self, o, scope)
+  end
+
+  # Catch all non transformable objects
+  # @api private
+  def transform_Object(o, scope)
+    raise IllegalRelationshipOperandError.new(o)
+  end
+
+  # A string must be a type reference in string format
+  # @api private
+  def transform_String(o, scope)
+    assert_catalog_type(@type_parser.parse(o), scope)
+  end
+
+  # A qualified name is short hand for a class with this name
+  # @api private
+  def transform_QualifiedName(o, scope)
+    Puppet::Pops::Types::TypeFactory.host_class(o.value)
+  end
+
+  # Types are what they are, just check the type
+  # @api private
+  def transform_PAbstractType(o, scope)
+    assert_catalog_type(o, scope)
+  end
+
+  # This transforms a 3x Collector (the result of evaluating a 3x AST::Collection).
+  # It is passed through verbatim since it is evaluated late by the compiler. At the point
+  # where the relationship is evaluated, it is simply recorded with the compiler for later evaluation.
+  # If one of the sides of the relationship is a Collector it is evaluated before the actual
+  # relationship is formed. (All of this happens at a later point in time.
+  #
+  def transform_Collector(o, scope)
+    o
+  end
+
+  # Array content needs to be transformed
+  def transform_Array(o, scope)
+    o.map{|x| transform(x, scope) }
+  end
+
+  # Asserts (and returns) the type if it is a PCatalogEntryType
+  # (A PCatalogEntryType is the base class of PHostClassType, and PResourceType).
+  #
+  def assert_catalog_type(o, scope)
+    unless @type_calculator.assignable?(@catalog_type, o)
+      raise NotCatalogTypeError.new(o)
+    end
+    # TODO must check if this is an abstract PResourceType (i.e. without a type_name) - which should fail ?
+    # e.g. File -> File (and other similar constructs) - maybe the catalog protects against this since references
+    # may be to future objects...
+    o
+  end
+
+  RELATIONSHIP_OPERATORS = [:'->', :'~>', :'<-', :'<~']
+  REVERSE_OPERATORS      = [:'<-', :'<~']
+  RELATION_TYPE = {
+    :'->' => :relationship,
+    :'<-' => :relationship,
+    :'~>' => :subscription,
+    :'<~' => :subscription
+  }
+
+  # Evaluate a relationship.
+  # TODO: The error reporting is not fine grained since evaluation has already taken place
+  # There is no references to the original source expressions at this point, only the overall
+  # relationship expression. (e.g.. the expression may be ['string', func_call(), etc.] -> func_call())
+  # To implement this, the general evaluator needs to be able to track each evaluation result and associate
+  # it with a corresponding expression. This structure should then be passed to the relationship operator.
+  #
+  def evaluate (left_right_evaluated, relationship_expression, scope)
+    # assert operator (should have been validated, but this logic makes assumptions which would
+    # screw things up royally). Better safe than sorry.
+    unless RELATIONSHIP_OPERATORS.include?(relationship_expression.operator)
+      fail(Issues::UNSUPPORTED_OPERATOR, relationship_expression, {:operator => relationship_expression.operator})
+    end
+
+    begin
+      # Turn each side into an array of types (this also asserts their type)
+      # (note wrap in array first if value is not already an array)
+      #
+      # TODO: Later when objects are Puppet Runtime Objects and know their type, it will be more efficient to check/infer
+      # the type first since a chained operation then does not have to visit each element again. This is not meaningful now
+      # since inference needs to visit each object each time, and this is what the transformation does anyway).
+      #
+      # real is [left, right], and both the left and right may be a single value or an array. In each case all content
+      # should be flattened, and then transformed to a type. left or right may also be a value that is transformed
+      # into an array, and thus the resulting left and right must be flattened individually
+      # Once flattened, the operands should be sets (to remove duplicate entries)
+      #
+      real = left_right_evaluated.collect {|x| [x].flatten.collect {|x| transform(x, scope) }}
+      real[0].flatten!
+      real[1].flatten!
+      real[0].uniq!
+      real[1].uniq!
+
+      # reverse order if operator is Right to Left
+      source, target = reverse_operator?(relationship_expression) ? real.reverse : real
+
+      # Add the relationships to the catalog
+      source.each {|s| target.each {|t| add_relationship(s, t, RELATION_TYPE[relationship_expression.operator], scope) }}
+
+      # Produce the transformed source RHS (if this is a chain, this does not need to be done again)
+      real.slice(1)
+    rescue NotCatalogTypeError => e
+      fail(Issues::ILLEGAL_RELATIONSHIP_OPERAND_TYPE, relationship_expression, {:type => @type_calculator.string(e.type)})
+    rescue IllegalRelationshipOperandError => e
+      fail(Issues::ILLEGAL_RELATIONSHIP_OPERAND_TYPE, relationship_expression, {:operand => e.operand})
+    end
+  end
+
+  def reverse_operator?(o)
+    REVERSE_OPERATORS.include?(o.operator)
+  end
+end

data/lib/puppet/pops/evaluator/runtime3_support.rb

@@ -0,0 +1,489 @@
+# A module with bindings between the new evaluator and the 3x runtime.
+# The intention is to separate all calls into scope, compiler, resource, etc. in this module
+# to make it easier to later refactor the evaluator for better implementations of the 3x classes.
+#
+# @api private
+module Puppet::Pops::Evaluator::Runtime3Support
+  # Fails the evaluation of _semantic_ with a given issue.
+  #
+  # @param issue [Puppet::Pops::Issue] the issue to report
+  # @param semantic [Puppet::Pops::ModelPopsObject] the object for which evaluation failed in some way. Used to determine origin.
+  # @param options [Hash] hash of optional named data elements for the given issue
+  # @return [!] this method does not return
+  # @raise [Puppet::ParseError] an evaluation error initialized from the arguments (TODO: Change to EvaluationError?)
+  #
+  def fail(issue, semantic, options={}, except=nil)
+    if except.nil?
+      # Want a stacktrace, and it must be passed as an exception
+      begin
+       raise EvaluationError.new()
+      rescue EvaluationError => e
+        except = e
+      end
+    end
+    diagnostic_producer.accept(issue, semantic, options, except)
+  end
+
+  # Binds the given variable name to the given value in the given scope.
+  # The reference object `o` is intended to be used for origin information - the 3x scope implementation
+  # only makes use of location when there is an error. This is now handled by other mechanisms; first a check
+  # is made if a variable exists and an error is raised if attempting to change an immutable value. Errors
+  # in name, numeric variable assignment etc. have also been validated prior to this call. In the event the
+  # scope.setvar still raises an error, the general exception handling for evaluation of the assignment
+  # expression knows about its location. Because of this, there is no need to extract the location for each
+  # setting (extraction is somewhat expensive since 3x requires line instead of offset).
+  #
+  def set_variable(name, value, o, scope)
+    # Scope also checks this but requires that location information are passed as options.
+    # Those are expensive to calculate and a test is instead made here to enable failing with better information.
+    # The error is not specific enough to allow catching it - need to check the actual message text.
+    # TODO: Improve the messy implementation in Scope.
+    #
+    if scope.bound?(name)
+      if Puppet::Parser::Scope::RESERVED_VARIABLE_NAMES.include?(name)
+        fail(Puppet::Pops::Issues::ILLEGAL_RESERVED_ASSIGNMENT, o, {:name => name} )
+      else
+        fail(Puppet::Pops::Issues::ILLEGAL_REASSIGNMENT, o, {:name => name} )
+      end
+    end
+    scope.setvar(name, value)
+  end
+
+  # Returns the value of the variable (nil is returned if variable has no value, or if variable does not exist)
+  #
+  def get_variable_value(name, o, scope)
+    # Puppet 3x stores all variables as strings (then converts them back to numeric with a regexp... to see if it is a match variable)
+    # Not ideal, scope should support numeric lookup directly instead.
+    # TODO: consider fixing scope
+    catch(:undefined_variable) {
+      return scope.lookupvar(name.to_s)
+    }
+    # It is always ok to reference numeric variables even if they are not assigned. They are always undef
+    # if not set by a match expression.
+    #
+    unless name =~ Puppet::Pops::Patterns::NUMERIC_VAR_NAME
+      fail(Puppet::Pops::Issues::UNKNOWN_VARIABLE, o, {:name => name})
+    end
+  end
+
+  # Returns true if the variable of the given name is set in the given most nested scope. True is returned even if
+  # variable is bound to nil.
+  #
+  def variable_bound?(name, scope)
+    scope.bound?(name.to_s)
+  end
+
+  # Returns true if the variable is bound to a value or nil, in the scope or it's parent scopes.
+  #
+  def variable_exists?(name, scope)
+    scope.exist?(name.to_s)
+  end
+
+  def set_match_data(match_data, o, scope)
+    # See set_variable for rationale for not passing file and line to ephemeral_from.
+    # NOTE: The 3x scope adds one ephemeral(match) to its internal stack per match that succeeds ! It never
+    # clears anything. Thus a context that performs many matches will get very deep (there simply is no way to
+    # clear the match variables without rolling back the ephemeral stack.)
+    # This implementation does not attempt to fix this, it behaves the same bad way.
+    unless match_data.nil?
+      scope.ephemeral_from(match_data)
+    end
+  end
+
+  # Creates a local scope with vairalbes set from a hash of variable name to value
+  #
+  def create_local_scope_from(hash, scope)
+    # two dummy values are needed since the scope tries to give an error message (can not happen in this
+    # case - it is just wrong, the error should be reported by the caller who knows in more detail where it
+    # is in the source.
+    #
+    raise ArgumentError, "Internal error - attempt to create a local scope without a hash" unless hash.is_a?(Hash)
+    scope.ephemeral_from(hash)
+  end
+
+  # Creates a nested match scope
+  def create_match_scope_from(scope)
+    # Create a transparent match scope (for future matches)
+    scope.new_match_scope(nil)
+  end
+
+  def get_scope_nesting_level(scope)
+    scope.ephemeral_level
+  end
+
+  def set_scope_nesting_level(scope, level)
+    # Yup, 3x uses this method to reset the level, it also supports passing :all to destroy all 
+    # ephemeral/local scopes - which is a sure way to create havoc.
+    #
+    scope.unset_ephemeral_var(level)
+  end
+
+  # Adds a relationship between the given `source` and `target` of the given `relationship_type`
+  # @param source [Puppet:Pops::Types::PCatalogEntryType] the source end of the relationship (from)
+  # @param target [Puppet:Pops::Types::PCatalogEntryType] the target end of the relationship (to)
+  # @param relationship_type [:relationship, :subscription] the type of the relationship
+  #
+  def add_relationship(source, target, relationship_type, scope)
+    # The 3x way is to record a Puppet::Parser::Relationship that is evaluated at the end of the compilation.
+    # This means it is not possible to detect any duplicates at this point (and signal where an attempt is made to
+    # add a duplicate. There is also no location information to signal the original place in the logic. The user will have
+    # to go fish.
+    # The 3.x implementation is based on Strings :-o, so the source and target must be transformed. The resolution is
+    # done by Catalog#resource(type, title). To do that, it creates a Puppet::Resource since it is responsible for
+    # translating the name/type/title and create index-keys used by the catalog. The Puppet::Resource has bizarre parsing of
+    # the type and title (scan for [] that is interpreted as type/title (but it gets it wrong).
+    # Moreover if the type is "" or "component", the type is Class, and if the type is :main, it is :main, all other cases
+    # undergo capitalization of name-segments (foo::bar becomes Foo::Bar). (This was earlier done in the reverse by the parser).
+    # Further, the title undergoes the same munging !!!
+    #
+    # That bug infested nest of messy logic needs serious Exorcism!
+    #
+    # Unfortunately it is not easy to simply call more intelligent methods at a lower level as the compiler evaluates the recorded
+    # Relationship object at a much later point, and it is responsible for invoking all the messy logic.
+    #
+    # TODO: Revisit the below logic when there is a sane implementation of the catalog, compiler and resource. For now
+    # concentrate on transforming the type references to what is expected by the wacky logic.
+    #
+    # HOWEVER, the Compiler only records the Relationships, and the only method it calls is @relationships.each{|x| x.evaluate(catalog) }
+    # Which means a smarter Relationship class could do this right. Instead of obtaining the resource from the catalog using
+    # the borked resource(type, title) which creates a resource for the purpose of looking it up, it needs to instead
+    # scan the catalog's resources
+    #
+    # GAAAH, it is even worse!
+    # It starts in the parser, which parses "File['foo']" into an AST::ResourceReference with type = File, and title = foo
+    # This AST is evaluated by looking up the type/title in the scope - causing it to be loaded if it exists, and if not, the given
+    # type name/title is used. It does not search for resource instances, only classes and types. It returns symbolic information
+    # [type, [title, title]]. From this, instances of Puppet::Resource are created and returned. These only have type/title information
+    # filled out. One or an array of resources are returned.
+    # This set of evaluated (empty reference) Resource instances are then passed to the relationship operator. It creates a
+    # Puppet::Parser::Relationship giving it a source and a target that are (empty reference) Resource instances. These are then remembered
+    # until the relationship is evaluated by the compiler (at the end). When evaluation takes place, the (empty reference) Resource instances
+    # are converted to String (!?! WTF) on the simple format "#{type}[#{title}]", and the catalog is told to find a resource, by giving
+    # it this string. If it cannot find the resource it fails, else the before/notify parameter is appended with the target.
+    # The search for the resource begin with (you guessed it) again creating an (empty reference) resource from type and title (WTF?!?!).
+    # The catalog now uses the reference resource to compute a key [r.type, r.title.to_s] and also gets a uniqueness key from the
+    # resource (This is only a reference type created from title and type). If it cannot find it with the first key, it uses the
+    # uniqueness key to lookup.
+    #
+    # This is probably done to allow a resource type to munge/translate the title in some way (but it is quite unclear from the long
+    # and convoluted path of evaluation.
+    # In order to do this in a way that is similar to 3.x two resources are created to be used as keys.
+    #
+    #
+    # TODO: logic that creates a PCatalogEntryType should resolve it to ensure it is loaded (to the best of known_resource_types knowledge).
+    # If this is not done, the order in which things are done may be different? OTOH, it probably works anyway :-)
+    # TODO: Not sure if references needs to be resolved via the scope?
+    #
+    # And if that is not enough, a source/target may be a Collector (a baked query that will be evaluated by the
+    # compiler - it is simply passed through here for processing by the compiler at the right time).
+    #
+    if source.is_a?(Puppet::Parser::Collector)
+      # use verbatim - behavior defined by 3x
+      source_resource = source
+    else
+      # transform into the wonderful String representation in 3x
+      type, title = catalog_type_to_split_type_title(source)
+      source_resource = Puppet::Resource.new(type, title)
+    end
+    if target.is_a?(Puppet::Parser::Collector)
+      # use verbatim - behavior defined by 3x
+      target_resource = target
+    else
+      # transform into the wonderful String representation in 3x
+      type, title = catalog_type_to_split_type_title(target)
+      target_resource = Puppet::Resource.new(type, title)
+    end
+    # Add the relationship to the compiler for later evaluation.
+    scope.compiler.add_relationship(Puppet::Parser::Relationship.new(source_resource, target_resource, relationship_type))
+  end
+
+  # Coerce value `v` to numeric or fails.
+  # The given value `v` is coerced to Numeric, and if that fails the operation
+  # calls {#fail}.
+  # @param v [Object] the value to convert
+  # @param o [Object] originating instruction
+  # @param scope [Object] the (runtime specific) scope where evaluation of o takes place
+  # @return [Numeric] value `v` converted to Numeric.
+  #
+  def coerce_numeric(v, o, scope)
+    unless n = Puppet::Pops::Utils.to_n(v)
+      fail(Puppet::Pops::Issues::NOT_NUMERIC, o, {:value => v})
+    end
+    n
+  end
+
+  # Asserts that the given function name resolves to an available function. The function is loaded
+  # as a side effect. Fails if the function does not exist.
+  #
+  def assert_function_available(name, o, scope)
+    fail(Puppet::Pops::Issues::UNKNOWN_FUNCTION, o, {:name => name}) unless Puppet::Parser::Functions.function(name)
+  end
+
+  def call_function(name, args, o, scope)
+    # Arguments must be mapped since functions are unaware of the new and magical creatures in 4x.
+    # NOTE: Passing an empty string last converts :undef to empty string
+    mapped_args = args.map {|a| convert(a, scope, '') }
+    scope.send("function_#{name}", mapped_args)
+  end
+
+  # Returns true if the function produces a value
+  def rvalue_function?(name, o, scope)
+    Puppet::Parser::Functions.rvalue?(name)
+  end
+
+  # The o is used for source reference
+  def create_resource_parameter(o, scope, name, value, operator)
+    file, line = extract_file_line(o)
+    Puppet::Parser::Resource::Param.new(
+      :name   => name,
+      :value  => convert(value, scope, :undef), # converted to 3x since 4x supports additional objects / types
+      :source => scope.source, :line => line, :file => file,
+      :add    => operator == :'+>'
+    )
+  end
+
+  def create_resources(o, scope, virtual, exported, type_name, resource_titles, evaluated_parameters)
+
+    # TODO: Unknown resource causes creation of Resource to fail with ArgumentError, should give
+    # a proper Issue. Now the result is "Error while evaluating a Resource Statement" with the message
+    # from the raised exception. (It may be good enough).
+
+    # resolve in scope.
+    fully_qualified_type, resource_titles = scope.resolve_type_and_titles(type_name, resource_titles)
+
+    # Not 100% accurate as this is the resource expression location and each title is processed separately
+    # The titles are however the result of evaluation and they have no location at this point (an array
+    # of positions for the source expressions are required for this to work).
+    # TODO: Revisit and possible improve the accuracy.
+    #
+    file, line = extract_file_line(o)
+
+    # Build a resource for each title
+    resource_titles.map do |resource_title|
+        resource = Puppet::Parser::Resource.new(
+          fully_qualified_type, resource_title,
+          :parameters => evaluated_parameters,
+          :file => file,
+          :line => line,
+          :exported => exported,
+          :virtual => virtual,
+          # WTF is this? Which source is this? The file? The name of the context ?
+          :source => scope.source,
+          :scope => scope,
+          :strict => true
+        )
+
+        if resource.resource_type.is_a? Puppet::Resource::Type
+          resource.resource_type.instantiate_resource(scope, resource)
+        end
+        scope.compiler.add_resource(scope, resource)
+        scope.compiler.evaluate_classes([resource_title], scope, false, true) if fully_qualified_type == 'class'
+        # Turn the resource into a PType (a reference to a resource type)
+        # weed out nil's
+        resource_to_ptype(resource)
+    end
+  end
+
+  # Defines default parameters for a type with the given name.
+  #
+  def create_resource_defaults(o, scope, type_name, evaluated_parameters)
+    # Note that name must be capitalized in this 3x call
+    # The 3x impl creates a Resource instance with a bogus title and then asks the created resource
+    # for the type of the name.
+    # Note, locations are available per parameter.
+    #
+    scope.define_settings(type_name.capitalize, evaluated_parameters)
+  end
+
+  # Creates resource overrides for all resource type objects in evaluated_resources. The same set of
+  # evaluated parameters are applied to all.
+  #
+  def create_resource_overrides(o, scope, evaluated_resources, evaluated_parameters)
+    # Not 100% accurate as this is the resource expression location and each title is processed separately
+    # The titles are however the result of evaluation and they have no location at this point (an array
+    # of positions for the source expressions are required for this to work.
+    # TODO: Revisit and possible improve the accuracy.
+    #
+    file, line = extract_file_line(o)
+
+    evaluated_resources.each do |r|
+      resource = Puppet::Parser::Resource.new(
+      r.type_name, r.title,
+        :parameters => evaluated_parameters,
+        :file => file,
+        :line => line,
+        # WTF is this? Which source is this? The file? The name of the context ?
+        :source => scope.source,
+        :scope => scope
+      )
+
+      scope.compiler.add_override(resource)
+    end
+  end
+
+  # Finds a resource given a type and a title.
+  #
+  def find_resource(scope, type_name, title)
+    scope.compiler.findresource(type_name, title)
+  end
+
+  # Returns the value of a resource's parameter by first looking up the parameter in the resource
+  # and then in the defaults for the resource. Since the resource exists (it must in order to look up its
+  # parameters, any overrides have already been applied). Defaults are not applied to a resource until it
+  # has been finished (which typically has not taked place when this is evaluated; hence the dual lookup).
+  #
+  def get_resource_parameter_value(scope, resource, parameter_name)
+    val = resource[parameter_name]
+    if val.nil? && defaults = scope.lookupdefaults(resource.type)
+      # NOTE: 3x resource keeps defaults as hash using symbol for name as key to Parameter which (again) holds
+      # name and value.
+      param = defaults[parameter_name.to_sym]
+      val = param.value
+    end
+    val
+  end
+
+  # Returns true, if the given name is the name of a resource parameter.
+  #
+  def is_parameter_of_resource?(scope, resource, name)
+    resource.valid_parameter?(name)
+  end
+
+  def resource_to_ptype(resource)
+    nil if resource.nil?
+    type_calculator.infer(resource)
+  end
+
+  # This is the same type of "truth" as used in the current Puppet DSL.
+  #
+  def is_true? o
+    # Is the value true?  This allows us to control the definition of truth
+    # in one place.
+    case o
+    when ''
+      false
+    when :undef
+      false
+    else
+      !!o
+    end
+  end
+
+  # Utility method for TrueClass || FalseClass
+  # @param x [Object] the object to test if it is instance of TrueClass or FalseClass
+  def is_boolean? x
+    x.is_a?(TrueClass) || x.is_a?(FalseClass)
+  end
+
+  def initialize
+    @@convert_visitor   ||= Puppet::Pops::Visitor.new(self, "convert", 2, 2)
+  end
+
+  # Converts 4x supported values to 3x values. This is required because
+  # resources and other objects do not know about the new type system, and does not support
+  # regular expressions. Unfortunately this has to be done for array and hash as well.
+  # A complication is that catalog types needs to be resolved against the scope.
+  #
+  def convert(o, scope, undef_value)
+    @@convert_visitor.visit_this_2(self, o, scope, undef_value)
+  end
+
+
+  def convert_NilClass(o, scope, undef_value)
+    undef_value
+  end
+
+  def convert_Object(o, scope, undef_value)
+    o
+  end
+
+  def convert_Array(o, scope, undef_value)
+    o.map {|x| convert(x, scope, undef_value) }
+  end
+
+  def convert_Hash(o, scope, undef_value)
+    result = {}
+    o.each {|k,v| result[convert(k, scope, undef_value)] = convert(v, scope, undef_value) }
+    result
+  end
+
+  def convert_Regexp(o, scope, undef_value)
+    # Puppet 3x cannot handle parameter values that are reqular expressions. Turn into regexp string in
+    # source form
+    o.inspect
+  end
+
+  def convert_Symbol(o, scope, undef_value)
+    case o
+    when :undef
+      undef_value  # 3x wants :undef as empty string in function
+    else
+      o   # :default, and all others are verbatim since they are new in future evaluator
+    end
+  end
+
+  def convert_PAbstractType(o, scope, undef_value)
+    o
+  end
+
+  def convert_PResourceType(o,scope, undef_value)
+    # Needs conversion by calling scope to resolve the name and possibly return a different name
+    # Resolution can only be called with an array, and returns an array. Here there is only one name
+    type, titles = scope.resolve_type_and_titles(o.type_name, [o.title])
+    Puppet::Resource.new(type, titles[0])
+  end
+
+  def convert_PHostClassType(o, scope, undef_value)
+    # Needs conversion by calling scope to resolve the name and possibly return a different name
+    # Resolution can only be called with an array, and returns an array. Here there is only one name
+    type, titles = scope.resolve_type_and_titles('class', [o.class_name])
+    Puppet::Resource.new(type, titles[0])
+  end
+
+  private
+
+  # Produces an array with [type, title] from a PCatalogEntryType
+  # Used to produce reference resource instances (used when 3x is operating on a resource).
+  #
+  def catalog_type_to_split_type_title(catalog_type)
+    case catalog_type
+    when Puppet::Pops::Types::PHostClassType
+      return ['Class', catalog_type.class_name]
+    when Puppet::Pops::Types::PResourceType
+      return [catalog_type.type_name, catalog_type.title]
+    else
+      raise ArgumentError, "Cannot split the type #{catalog_type.class}, it is neither a PHostClassType, nor a PResourceClass."
+    end
+  end
+
+  def extract_file_line(o)
+    source_pos = Puppet::Pops::Utils.find_closest_positioned(o)
+    return [nil, -1] unless source_pos
+    [source_pos.locator.file, source_pos.line]
+  end
+
+  def find_closest_positioned(o)
+    return nil if o.nil? || o.is_a?(Puppet::Pops::Model::Program)
+    o.offset.nil? ? find_closest_positioned(o.eContainer) : Puppet::Pops::Adapters::SourcePosAdapter.adapt(o)
+  end
+
+  # Creates a diagnostic producer
+  def diagnostic_producer
+    Puppet::Pops::Validation::DiagnosticProducer.new(
+      ExceptionRaisingAcceptor.new(),                   # Raises exception on all issues
+      Puppet::Pops::Validation::SeverityProducer.new(), # All issues are errors
+      Puppet::Pops::Model::ModelLabelProvider.new())
+  end
+
+  # An acceptor of diagnostics that immediately raises an exception.
+  class ExceptionRaisingAcceptor < Puppet::Pops::Validation::Acceptor
+    def accept(diagnostic)
+      super
+      Puppet::Pops::IssueReporter.assert_and_report(self, {:message => "Evaluation Error:" })
+      raise ArgumentError, "Internal Error: Configuration of runtime error handling wrong: should have raised exception"
+    end
+  end
+
+  class EvaluationError < StandardError
+  end
+end