puppet 3.2.4 → 3.3.0.rc2

data/spec/unit/provider/package/urpmi.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+describe Puppet::Type.type(:package).provider(:urpmi) do
+
+  before do
+    Puppet::Util::Execution.expects(:execute).never
+    %w[rpm urpmi urpme urpmq].each do |executable|
+      Puppet::Util.stubs(:which).with(executable).returns(executable)
+    end
+    Puppet::Util::Execution.stubs(:execute).with(['rpm', '--version'], anything).returns 'RPM version 4.9.1.3'
+  end
+
+  let(:resource) do
+    Puppet::Type.type(:package).new(:name => 'foopkg')
+  end
+
+  before do
+    subject.resource = resource
+    Puppet::Type.type(:package).stubs(:defaultprovider).returns described_class
+  end
+
+  describe '#install' do
+    before do
+      subject.stubs(:rpm).with('-q', 'foopkg', any_parameters).returns "foopkg 0 1.2.3.4 5 noarch :DESC:\n"
+    end
+
+    describe 'without a version' do
+      it 'installs the unversioned package' do
+        resource[:ensure] = :present
+        Puppet::Util::Execution.expects(:execute).with(['urpmi', '--auto', 'foopkg'], anything)
+        subject.install
+      end
+    end
+
+    describe 'with a version' do
+      it 'installs the versioned package' do
+        resource[:ensure] = '4.5.6'
+        Puppet::Util::Execution.expects(:execute).with(['urpmi', '--auto', 'foopkg-4.5.6'], anything)
+        subject.install
+      end
+    end
+
+    describe "and the package install fails" do
+      it "raises an error" do
+        Puppet::Util::Execution.stubs(:execute).with(['urpmi', '--auto', 'foopkg'], anything)
+        subject.stubs(:query)
+        expect { subject.install }.to raise_error Puppet::Error, /Package \S+ was not present after trying to install it/
+      end
+    end
+  end
+
+  describe '#latest' do
+    let(:urpmq_output) { 'foopkg : Lorem ipsum dolor sit amet, consectetur adipisicing elit ( 7.8.9-1.mga2 )' }
+
+    it "uses urpmq to determine the latest package" do
+      Puppet::Util::Execution.expects(:execute).with(['urpmq', '-S', 'foopkg'], anything).returns urpmq_output
+      subject.latest.should == '7.8.9-1.mga2'
+    end
+
+    it "falls back to the current version" do
+      resource[:ensure] = '5.4.3'
+      Puppet::Util::Execution.expects(:execute).with(['urpmq', '-S', 'foopkg'], anything).returns ''
+      subject.latest.should == '5.4.3'
+    end
+  end
+
+  describe '#update' do
+    it 'delegates to #install' do
+      subject.expects(:install)
+      subject.update
+    end
+  end
+
+  describe '#purge' do
+    it 'uses urpme to purge packages' do
+      Puppet::Util::Execution.expects(:execute).with(['urpme', '--auto', 'foopkg'], anything)
+      subject.purge
+    end
+  end
+end

data/spec/unit/provider/package/windows/exe_package_spec.rb

@@ -77,7 +77,7 @@ describe Puppet::Provider::Package::Windows::ExePackage do
     it 'should install using the source' do
       cmd = subject.install_command({:source => source})
 
-      cmd.should == ['cmd.exe', '/c', 'start', '/w', source]
+      cmd.should == ['cmd.exe', '/c', 'start', '"puppet-install"', '/w', source]
     end
   end
 

data/spec/unit/provider/package/yum_spec.rb

@@ -108,4 +108,89 @@ describe provider do
       end
     end
   end
+
+  describe 'prefetching' do
+    let(:nevra_format) { Puppet::Type::Package::ProviderRpm::NEVRA_FORMAT }
+
+    let(:packages) do
+      <<-RPM_OUTPUT
+      cracklib-dicts 0 2.8.9 3.3 x86_64 :DESC: The standard CrackLib dictionaries
+      basesystem 0 8.0 5.1.1.el5.centos noarch :DESC: The skeleton package which defines a simple Red Hat Enterprise Linux system
+      chkconfig 0 1.3.30.2 2.el5 x86_64 :DESC: A system tool for maintaining the /etc/rc*.d hierarchy
+      myresource 0 1.2.3.4 5.el4 noarch :DESC: Now with summary
+      mysummaryless 0 1.2.3.4 5.el4 noarch :DESC:
+      RPM_OUTPUT
+    end
+
+    let(:yumhelper_output) do
+      <<-YUMHELPER_OUTPUT
+ * base: centos.tcpdiag.net
+ * extras: centos.mirrors.hoobly.com
+ * updates: mirrors.arsc.edu
+_pkg nss-tools 0 3.14.3 4.el6_4 x86_64
+_pkg pixman 0 0.26.2 5.el6_4 x86_64
+_pkg myresource 0 1.2.3.4 5.el4 noarch
+_pkg mysummaryless 0 1.2.3.4 5.el4 noarch
+     YUMHELPER_OUTPUT
+    end
+
+    let(:execute_options) do
+      {:failonfail => true, :combine => true, :custom_environment => {}}
+    end
+
+    let(:rpm_version) { "RPM version 4.8.0\n" }
+
+    let(:package_type) { Puppet::Type.type(:package) }
+    let(:yum_provider) { provider }
+
+    def pretend_we_are_root_for_yum_provider
+      Process.stubs(:euid).returns(0)
+    end
+
+    def expect_yum_provider_to_provide_rpm
+      Puppet::Type::Package::ProviderYum.stubs(:rpm).with('--version').returns(rpm_version)
+      Puppet::Type::Package::ProviderYum.expects(:command).with(:rpm).returns("/bin/rpm")
+    end
+
+    def expect_execpipe_to_provide_package_info_for_an_rpm_query
+      Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa --nosignature --nodigest --qf #{nevra_format}").yields(packages)
+    end
+
+    def expect_python_yumhelper_call_to_return_latest_info
+      Puppet::Type::Package::ProviderYum.expects(:python).with(regexp_matches(/yumhelper.py$/)).returns(yumhelper_output)
+    end
+
+    def a_package_type_instance_with_yum_provider_and_ensure_latest(name)
+      type_instance = package_type.new(:name => name)
+      type_instance.provider = yum_provider.new
+      type_instance[:ensure] = :latest
+      return type_instance
+    end
+
+    before do
+      pretend_we_are_root_for_yum_provider
+      expect_yum_provider_to_provide_rpm
+      expect_execpipe_to_provide_package_info_for_an_rpm_query
+      expect_python_yumhelper_call_to_return_latest_info
+    end
+
+    it "injects latest provider info into passed resources when prefetching" do
+      myresource = a_package_type_instance_with_yum_provider_and_ensure_latest('myresource')
+      mysummaryless = a_package_type_instance_with_yum_provider_and_ensure_latest('mysummaryless')
+
+      yum_provider.prefetch({ "myresource" => myresource, "mysummaryless" => mysummaryless })
+
+      expect(@logs.map(&:message).grep(/^Failed to match rpm line/)).to be_empty
+      expect(myresource.provider.latest_info).to eq({
+        :name=>"myresource",
+        :epoch=>"0",
+        :version=>"1.2.3.4",
+        :release=>"5.el4",
+        :arch=>"noarch",
+        :description=>nil,
+        :provider=>:yum,
+        :ensure=>"1.2.3.4-5.el4"
+      })
+    end
+  end
 end

data/spec/unit/provider/package/zypper_spec.rb

@@ -39,13 +39,18 @@ describe provider_class do
     @provider.should respond_to(:latest)
   end
 
+  it "should have a install_options method" do
+    @provider = provider_class.new
+    @provider.should respond_to(:install_options)
+  end
+
   describe "when installing with zypper version >= 1.0" do
     it "should use a command-line with versioned package'" do
       @resource.stubs(:should).with(:ensure).returns "1.2.3-4.5.6"
       @provider.stubs(:zypper_version).returns "1.2.8"
 
       @provider.expects(:zypper).with('--quiet', :install,
-        '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
+        '--auto-agree-with-licenses', '--no-confirm', nil, 'mypackage-1.2.3-4.5.6')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -54,7 +59,7 @@ describe provider_class do
       @resource.stubs(:should).with(:ensure).returns :latest
       @provider.stubs(:zypper_version).returns "1.2.8"
       @provider.expects(:zypper).with('--quiet', :install,
-        '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
+        '--auto-agree-with-licenses', '--no-confirm', nil, 'mypackage')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -66,7 +71,7 @@ describe provider_class do
       @provider.stubs(:zypper_version).returns "0.6.104"
 
       @provider.expects(:zypper).with('--terse', :install,
-        '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
+        '--auto-agree-with-licenses', '--no-confirm', nil, 'mypackage-1.2.3-4.5.6')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -75,7 +80,7 @@ describe provider_class do
       @resource.stubs(:should).with(:ensure).returns :latest
       @provider.stubs(:zypper_version).returns "0.6.104"
       @provider.expects(:zypper).with('--terse', :install,
-        '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
+        '--auto-agree-with-licenses', '--no-confirm', nil, 'mypackage')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -87,7 +92,7 @@ describe provider_class do
       @provider.stubs(:zypper_version).returns "0.6.13"
 
       @provider.expects(:zypper).with('--terse', :install,
-        '--no-confirm', 'mypackage-1.2.3-4.5.6')
+        '--no-confirm', nil, 'mypackage-1.2.3-4.5.6')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -96,7 +101,7 @@ describe provider_class do
       @resource.stubs(:should).with(:ensure).returns :latest
       @provider.stubs(:zypper_version).returns "0.6.13"
       @provider.expects(:zypper).with('--terse', :install,
-        '--no-confirm', 'mypackage')
+        '--no-confirm', nil, 'mypackage')
       @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
       @provider.install
     end
@@ -119,4 +124,18 @@ describe provider_class do
     end
   end
 
+  describe "when installing with zypper install options" do
+    it "should install the package without checking keys" do
+      @resource.stubs(:[]).with(:name).returns "php5"
+      @resource.stubs(:should).with(:install_options).returns ['--no-gpg-check', {'-p' => '/vagrant/files/localrepo/'}]
+      @resource.stubs(:should).with(:ensure).returns "5.4.10-4.5.6"
+      @provider.stubs(:zypper_version).returns "1.2.8"
+
+      @provider.expects(:install_options).returns "--no-gpg-check -p \"/vagrant/files/localrepo/\""
+      @provider.expects(:zypper).with('--quiet', :install,
+        '--auto-agree-with-licenses', '--no-confirm', '--no-gpg-check -p "/vagrant/files/localrepo/"', 'php5-5.4.10-4.5.6')
+      @provider.expects(:query).returns "php5 0 5.4.10 4.5.6 x86_64"
+      @provider.install
+    end
+  end
 end

data/spec/unit/provider/parsedfile_spec.rb

@@ -1,11 +1,11 @@
 #! /usr/bin/env ruby
 require 'spec_helper'
+require 'puppet_spec/files'
 
 require 'puppet/provider/parsedfile'
 
 # Most of the tests for this are still in test/ral/provider/parsedfile.rb.
 describe Puppet::Provider::ParsedFile do
-
   # The ParsedFile provider class is meant to be used as an abstract base class
   # but also stores a lot of state within the singleton class. To avoid
   # sharing data between classes we construct an anonymous class that inherits
@@ -136,9 +136,10 @@ describe Puppet::Provider::ParsedFile do
 end
 
 describe "A very basic provider based on ParsedFile" do
+  include PuppetSpec::Files
 
   let(:input_text) { File.read(my_fixture('simple.txt')) }
-  let(:target) { File.expand_path("/tmp/test") }
+  let(:target) { tmpfile('parsedfile_spec') }
 
   subject do
     example_provider_class = Class.new(Puppet::Provider::ParsedFile)

data/spec/unit/provider/service/init_spec.rb

@@ -103,28 +103,28 @@ describe Puppet::Type.type(:service).provider(:init) do
     end
 
     it "should be able to find the init script in the service path" do
-      File.expects(:stat).with("#{paths[0]}/myservice").returns true
-      File.expects(:stat).with("#{paths[1]}/myservice").never # first one wins
+      File.expects(:exist?).with("#{paths[0]}/myservice").returns true
+      File.expects(:exist?).with("#{paths[1]}/myservice").never # first one wins
       provider.initscript.should == "/service/path/myservice"
     end
 
     it "should be able to find the init script in an alternate service path" do
-      File.expects(:stat).with("#{paths[0]}/myservice").raises Errno::ENOENT, "No such file or directory - #{paths[0]}/myservice"
-      File.expects(:stat).with("#{paths[1]}/myservice").returns true
+      File.expects(:exist?).with("#{paths[0]}/myservice").returns false
+      File.expects(:exist?).with("#{paths[1]}/myservice").returns true
       provider.initscript.should == "/alt/service/path/myservice"
     end
 
     it "should be able to find the init script if it ends with .sh" do
-      File.expects(:stat).with("#{paths[0]}/myservice").raises Errno::ENOENT, "No such file or directory - #{paths[0]}/myservice"
-      File.expects(:stat).with("#{paths[1]}/myservice").raises Errno::ENOENT, "No such file or directory - #{paths[1]}/myservice"
-      File.expects(:stat).with("#{paths[0]}/myservice.sh").returns true
+      File.expects(:exist?).with("#{paths[0]}/myservice").returns false
+      File.expects(:exist?).with("#{paths[1]}/myservice").returns false
+      File.expects(:exist?).with("#{paths[0]}/myservice.sh").returns true
       provider.initscript.should == "/service/path/myservice.sh"
     end
 
     it "should fail if the service isn't there" do
       paths.each do |path|
-        File.expects(:stat).with("#{path}/myservice").raises Errno::ENOENT, "No such file or directory - #{path}/myservice"
-        File.expects(:stat).with("#{path}/myservice.sh").raises Errno::ENOENT, "No such file or directory - #{path}/myservice.sh"
+        File.expects(:exist?).with("#{path}/myservice").returns false
+        File.expects(:exist?).with("#{path}/myservice.sh").returns false
       end
       expect { provider.initscript }.to raise_error(Puppet::Error, "Could not find init script for 'myservice'")
     end
@@ -134,7 +134,7 @@ describe Puppet::Type.type(:service).provider(:init) do
     before :each do
       File.stubs(:directory?).with("/service/path").returns true
       File.stubs(:directory?).with("/alt/service/path").returns true
-      File.stubs(:stat).with("/service/path/myservice").returns true
+      File.stubs(:exist?).with("/service/path/myservice").returns true
     end
 
     [:start, :stop, :status, :restart].each do |method|

data/spec/unit/provider/service/openrc_spec.rb

@@ -7,7 +7,10 @@ describe Puppet::Type.type(:service).provider(:openrc) do
   before :each do
     Puppet::Type.type(:service).stubs(:defaultprovider).returns described_class
     ['/sbin/rc-service', '/bin/rc-status', '/sbin/rc-update'].each do |command|
+      # Puppet::Util is both mixed in to providers and is also invoked directly
+      # by Puppet::Provider::CommandDefiner, so we have to stub both out.
       described_class.stubs(:which).with(command).returns(command)
+      Puppet::Util.stubs(:which).with(command).returns(command)
     end
   end
 
@@ -58,6 +61,19 @@ describe Puppet::Type.type(:service).provider(:openrc) do
     end
   end
 
+  describe 'when invoking `rc-status`' do
+    subject { described_class.new(Puppet::Type.type(:service).new(:name => 'urandom')) }
+    it "clears the RC_SVCNAME environment variable" do
+      Puppet::Util.withenv(:RC_SVCNAME => 'puppet') do
+        Puppet::Util::Execution.expects(:execute).with(
+          includes('/bin/rc-status'),
+          has_entry(:custom_environment, {:RC_SVCNAME => nil})
+        ).returns ''
+        subject.enabled?
+      end
+    end
+  end
+
   describe "#enabled?" do
 
     before :each do

data/spec/unit/provider/service/openwrt_spec.rb

@@ -33,7 +33,7 @@ describe Puppet::Type.type(:service).provider(:openwrt), :as_platform => :posix
     # All OpenWrt tests operate on the init script directly. It must exist.
     File.stubs(:directory?).with('/etc/init.d').returns true
 
-    File.stubs(:stat).with('/etc/init.d/myservice')
+    File.stubs(:exist?).with('/etc/init.d/myservice').returns true
     FileTest.stubs(:file?).with('/etc/init.d/myservice').returns true
     FileTest.stubs(:executable?).with('/etc/init.d/myservice').returns true
   end

data/spec/unit/provider/service/redhat_spec.rb

@@ -69,6 +69,13 @@ describe provider_class, :as_platform => :posix do
     @provider.should respond_to(:enabled?)
   end
 
+  it "should use --check on SuSE" do
+    Facter.expects(:value).with(:osfamily).returns 'Suse'
+    provider_class.expects(:chkconfig).with(@resource[:name], '--check')
+
+    @provider.enabled?
+  end
+
   it "should have an enable method" do
     @provider.should respond_to(:enable)
   end

data/spec/unit/provider/ssh_authorized_key/parsed_spec.rb

@@ -51,7 +51,7 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
     genkey(key).should == "ssh-dss AAAAfsfddsjldjgksdflgkjsfdlgkj Just_Testing\n"
   end
 
-  it "should be able to generate a authorized_keys file with options" do
+  it "should be able to generate an authorized_keys file with options" do
 
     key = mkkey(:name    => "root@localhost",
                 :key     => "AAAAfsfddsjldjgksdflgkjsfdlgkj",
@@ -246,7 +246,7 @@ describe provider_class, :unless => Puppet.features.microsoft_windows? do
       end
     end
 
-    describe "and a invalid user has been specified with no target" do
+    describe "and an invalid user has been specified with no target" do
       it "should catch an exception and raise a Puppet error" do
         @resource[:user] = "thisusershouldnotexist"
 

data/spec/unit/provider/user/aix_spec.rb

@@ -39,4 +39,93 @@ guest id=100 pgrp=usr groups=usr home=/home/guest
     provider_class.list_all.should == ['root', 'guest']
   end
 
+  describe "#managed_attribute_keys" do
+    let(:existing_attributes) do
+      { :account_locked => 'false',
+        :admin => 'false',
+        :login => 'true',
+        'su' => 'true'
+      }
+    end
+
+    before(:each) do
+      original_parameters = { :attributes => attribute_array }
+      @resource.stubs(:original_parameters).returns(original_parameters)
+    end
+
+    describe "invoked via manifest" do
+      let(:attribute_array) { ["rlogin=false", "login =true"] }
+
+      it "should return only the keys of the attribute key=value pair from manifest" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        keys.should be_include(:rlogin)
+        keys.should be_include(:login)
+        keys.should_not be_include(:su)
+      end
+
+      it "should strip spaces from symbols" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        keys.should be_include(:login)
+        keys.should_not be_include(:"login ")
+      end
+
+      it "should have the same count as that from the manifest" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        keys.size.should == attribute_array.size
+      end
+
+      it "should convert the keys to symbols" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        all_symbols = keys.all? {|k| k.is_a? Symbol}
+        all_symbols.should be_true
+      end
+    end
+
+    describe "invoked via RAL" do
+      let(:attribute_array) { nil }
+
+      it "should return the keys in supplied hash" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        keys.should_not be_include(:rlogin)
+        keys.should be_include(:login)
+        keys.should be_include(:su)
+      end
+
+      it "should convert the keys to symbols" do
+        keys = @provider.managed_attribute_keys(existing_attributes)
+        all_symbols = keys.all? {|k| k.is_a? Symbol}
+        all_symbols.should be_true
+      end
+    end
+  end
+
+  describe "#should_include?" do
+    it "should exclude keys translated into something else" do
+      managed_keys = [:rlogin]
+      @provider.class.attribute_mapping_from.stubs(:include?).with(:rlogin).returns(true)
+      @provider.class.stubs(:attribute_ignore).returns([])
+      @provider.should_include?(:rlogin, managed_keys).should be_false
+    end
+
+    it "should exclude keys explicitly ignored" do
+      managed_keys = [:rlogin]
+      @provider.class.attribute_mapping_from.stubs(:include?).with(:rlogin).returns(false)
+      @provider.class.stubs(:attribute_ignore).returns([:rlogin])
+      @provider.should_include?(:rlogin, managed_keys).should be_false
+    end
+
+    it "should exclude keys not specified in manifest" do
+      managed_keys = [:su]
+      @provider.class.attribute_mapping_from.stubs(:include?).with(:rlogin).returns(false)
+      @provider.class.stubs(:attribute_ignore).returns([])
+      @provider.should_include?(:rlogin, managed_keys).should be_false
+    end
+
+    it "should include keys specified in manifest if not translated or ignored" do
+      managed_keys = [:rlogin]
+      @provider.class.attribute_mapping_from.stubs(:include?).with(:rlogin).returns(false)
+      @provider.class.stubs(:attribute_ignore).returns([])
+      @provider.should_include?(:rlogin, managed_keys).should be_true
+    end
+  end
 end