puppet 3.1.1 → 3.2.0.rc1

data/spec/unit/provider/package/aptrpm_spec.rb

@@ -10,6 +10,12 @@ describe Puppet::Type.type(:package).provider(:aptrpm) do
   it { should be_versionable }
 
   context "when retrieving ensure" do
+    before(:each) do
+      Puppet::Util.stubs(:which).with("rpm").returns("/bin/rpm")
+      pkg.provider.stubs(:which).with("rpm").returns("/bin/rpm")
+      Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "--version"], {:combine => true, :custom_environment => {}, :failonfail => true}).returns("4.10.1\n").at_most_once
+    end
+
     def rpm
       pkg.provider.expects(:rpm).
         with('-q', 'faff', '--nosignature', '--nodigest', '--qf',

data/spec/unit/provider/package/gem_spec.rb

@@ -29,23 +29,18 @@ describe provider_class do
       provider.install
     end
 
-    it "should specify that dependencies should be included" do
-      provider.expects(:execute).with { |args| args[2] == "--include-dependencies" }.returns ""
-      provider.install
-    end
-
     it "should specify that documentation should not be included" do
-      provider.expects(:execute).with { |args| args[3] == "--no-rdoc" }.returns ""
+      provider.expects(:execute).with { |args| args[2] == "--no-rdoc" }.returns ""
       provider.install
     end
 
     it "should specify that RI should not be included" do
-      provider.expects(:execute).with { |args| args[4] == "--no-ri" }.returns ""
+      provider.expects(:execute).with { |args| args[3] == "--no-ri" }.returns ""
       provider.install
     end
 
     it "should specify the package name" do
-      provider.expects(:execute).with { |args| args[5] == "myresource" }.returns ""
+      provider.expects(:execute).with { |args| args[4] == "myresource" }.returns ""
       provider.install
     end
 
@@ -53,14 +48,14 @@ describe provider_class do
       describe "as a normal file" do
         it "should use the file name instead of the gem name" do
           resource[:source] = "/my/file"
-          provider.expects(:execute).with { |args| args[3] == "/my/file" }.returns ""
+          provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
           provider.install
         end
       end
       describe "as a file url" do
         it "should use the file name instead of the gem name" do
           resource[:source] = "file:///my/file"
-          provider.expects(:execute).with { |args| args[3] == "/my/file" }.returns ""
+          provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
           provider.install
         end
       end
@@ -73,7 +68,7 @@ describe provider_class do
       describe "as a non-file and non-puppet url" do
         it "should treat the source as a gem repository" do
           resource[:source] = "http://host/my/file"
-          provider.expects(:execute).with { |args| args[3..5] == ["--source", "http://host/my/file", "myresource"] }.returns ""
+          provider.expects(:execute).with { |args| args[2..4] == ["--source", "http://host/my/file", "myresource"] }.returns ""
           provider.install
         end
       end

data/spec/unit/provider/package/nim_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 provider_class = Puppet::Type.type(:package).provider(:nim)
 
 describe provider_class do
+
   before(:each) do
     # Create a mock resource
     @resource = stub 'resource'
@@ -12,7 +13,7 @@ describe provider_class do
     @resource.stubs(:[]).returns(nil)
 
     # But set name and source
-    @resource.stubs(:[]).with(:name).returns "mypackage"
+    @resource.stubs(:[]).with(:name).returns "mypackage.foo"
     @resource.stubs(:[]).with(:source).returns "mysource"
     @resource.stubs(:[]).with(:ensure).returns :installed
 
@@ -25,17 +26,225 @@ describe provider_class do
     @provider.should respond_to(:install)
   end
 
-  describe "when installing" do
+  let(:bff_showres_output) {
+    <<END
+mypackage.foo                                                           ALL  @@I:mypackage.foo _all_filesets
+ @ 1.2.3.1  MyPackage Runtime Environment                       @@I:mypackage.foo 1.2.3.1
+ + 1.2.3.4  MyPackage Runtime Environment                       @@I:mypackage.foo 1.2.3.4
+ + 1.2.3.8  MyPackage Runtime Environment                       @@I:mypackage.foo 1.2.3.8
+
+END
+  }
+
+  let(:rpm_showres_output) {
+    <<END
+mypackage.foo                                                                ALL  @@R:mypackage.foo _all_filesets
+ @@R:mypackage.foo-1.2.3-1 1.2.3-1
+ @@R:mypackage.foo-1.2.3-4 1.2.3-4
+ @@R:mypackage.foo-1.2.3-8 1.2.3-8
+
+END
+  }
+
+  context "when installing" do
     it "should install a package" do
+
       @resource.stubs(:should).with(:ensure).returns(:installed)
-      @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets='mypackage'")
+      Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo'").returns(bff_showres_output)
+      @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets=mypackage.foo 1.2.3.8")
       @provider.install
     end
 
-    it "should install a versioned package" do
-      @resource.stubs(:should).with(:ensure).returns("1.2.3.4")
-      @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets='mypackage 1.2.3.4'")
-      @provider.install
+    context "when installing versioned packages" do
+
+      it "should fail if the package is not available on the lpp source" do
+        nimclient_showres_output = ""
+
+        @resource.stubs(:should).with(:ensure).returns("1.2.3.4")
+        Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo( |-)1\\.2\\.3\\.4'").returns(nimclient_showres_output)
+        expect {
+          @provider.install
+        }.to raise_error(Puppet::Error, "Unable to find package 'mypackage.foo' with version '1.2.3.4' on lpp_source 'mysource'")
+      end
+
+      it "should succeed if a BFF/installp package is available on the lpp source" do
+        nimclient_sequence = sequence('nimclient')
+
+        @resource.stubs(:should).with(:ensure).returns("1.2.3.4")
+        Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo( |-)1\\.2\\.3\\.4'").returns(bff_showres_output).in_sequence(nimclient_sequence)
+        @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets=mypackage.foo 1.2.3.4").in_sequence(nimclient_sequence)
+        @provider.install
+      end
+
+      it "should fail if the specified version of a BFF package is superseded" do
+        nimclient_sequence = sequence('nimclient')
+
+        install_output = <<OUTPUT
++-----------------------------------------------------------------------------+
+                    Pre-installation Verification...
++-----------------------------------------------------------------------------+
+Verifying selections...done
+Verifying requisites...done
+Results...
+
+WARNINGS
+--------
+  Problems described in this section are not likely to be the source of any
+  immediate or serious failures, but further actions may be necessary or
+  desired.
+
+  Already Installed
+  -----------------
+  The number of selected filesets that are either already installed
+  or effectively installed through superseding filesets is 1.  See
+  the summaries at the end of this installation for details.
+
+  NOTE:  Base level filesets may be reinstalled using the "Force"
+  option (-F flag), or they may be removed, using the deinstall or
+  "Remove Software Products" facility (-u flag), and then reinstalled.
+
+  << End of Warning Section >>
+
++-----------------------------------------------------------------------------+
+                   BUILDDATE Verification ...
++-----------------------------------------------------------------------------+
+Verifying build dates...done
+FILESET STATISTICS
+------------------
+    1  Selected to be installed, of which:
+        1  Already installed (directly or via superseding filesets)
+  ----
+    0  Total to be installed
+
+
+Pre-installation Failure/Warning Summary
+----------------------------------------
+Name                      Level           Pre-installation Failure/Warning
+-------------------------------------------------------------------------------
+mypackage.foo              1.2.3.1         Already superseded by 1.2.3.4
+OUTPUT
+
+        @resource.stubs(:should).with(:ensure).returns("1.2.3.1")
+        Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo( |-)1\\.2\\.3\\.1'").returns(bff_showres_output).in_sequence(nimclient_sequence)
+        @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets=mypackage.foo 1.2.3.1").in_sequence(nimclient_sequence).returns(install_output)
+
+        expect { @provider.install }.to raise_error(Puppet::Error, "NIM package provider is unable to downgrade packages")
+    end
+
+
+    it "should succeed if an RPM package is available on the lpp source" do
+        nimclient_sequence = sequence('nimclient')
+
+        @resource.stubs(:should).with(:ensure).returns("1.2.3-4")
+        Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo( |-)1\\.2\\.3\\-4'").returns(rpm_showres_output).in_sequence(nimclient_sequence)
+        @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets=mypackage.foo-1.2.3-4").in_sequence(nimclient_sequence)
+        @provider.install
+      end
+    end
+
+    it "should fail if the specified version of a RPM package is superseded" do
+      nimclient_sequence = sequence('nimclient')
+
+      install_output = <<OUTPUT
+
+
+Validating RPM package selections ...
+
+Please wait...
++-----------------------------------------------------------------------------+
+                          RPM  Error Summary:
++-----------------------------------------------------------------------------+
+The following RPM packages were requested for installation
+but they are already installed or superseded by a package installed
+at a higher level:
+mypackage.foo-1.2.3-1 is superseded by mypackage.foo-1.2.3-4
+
+
+OUTPUT
+
+      @resource.stubs(:should).with(:ensure).returns("1.2.3-1")
+      Puppet::Util.expects(:execute).with("/usr/sbin/nimclient -o showres -a resource=mysource |/usr/bin/grep -p -E 'mypackage\\.foo( |-)1\\.2\\.3\\-1'").returns(rpm_showres_output).in_sequence(nimclient_sequence)
+      @provider.expects(:nimclient).with("-o", "cust", "-a", "installp_flags=acgwXY", "-a", "lpp_source=mysource", "-a", "filesets=mypackage.foo-1.2.3-1").in_sequence(nimclient_sequence).returns(install_output)
+
+      expect { @provider.install }.to raise_error(Puppet::Error, "NIM package provider is unable to downgrade packages")
+    end
+
+
+
+  end
+
+  context "when uninstalling" do
+    it "should call installp to uninstall a bff package" do
+      @provider.expects(:lslpp).with("-qLc", "mypackage.foo").returns("#bos.atm:bos.atm.atmle:7.1.2.0: : :C: :ATM LAN Emulation Client Support : : : : : : :0:0:/:1241")
+      @provider.expects(:installp).with("-gu", "mypackage.foo")
+      @provider.class.expects(:pkglist).with(:pkgname => 'mypackage.foo').returns(nil)
+      @provider.uninstall
+    end
+
+    it "should call rpm to uninstall an rpm package" do
+      @provider.expects(:lslpp).with("-qLc", "mypackage.foo").returns("cdrecord:cdrecord-1.9-6:1.9-6: : :C:R:A command line CD/DVD recording program.: :/bin/rpm -e cdrecord: : : : :0: :/opt/freeware:Wed Jun 29 09:41:32 PDT 2005")
+      @provider.expects(:rpm).with("-e", "mypackage.foo")
+      @provider.class.expects(:pkglist).with(:pkgname => 'mypackage.foo').returns(nil)
+      @provider.uninstall
+    end
+
+  end
+
+
+  context "when parsing nimclient showres output" do
+    describe "#parse_showres_output" do
+      it "should be able to parse installp/BFF package listings" do
+        packages = subject.send(:parse_showres_output, bff_showres_output)
+        Set.new(packages.keys).should == Set.new(['mypackage.foo'])
+        versions = packages['mypackage.foo']
+        ['1.2.3.1', '1.2.3.4', '1.2.3.8'].each do |version|
+          versions.has_key?(version).should == true
+          versions[version].should == :installp
+        end
+      end
+
+      it "should be able to parse RPM package listings" do
+        packages = subject.send(:parse_showres_output, rpm_showres_output)
+        Set.new(packages.keys).should == Set.new(['mypackage.foo'])
+        versions = packages['mypackage.foo']
+        ['1.2.3-1', '1.2.3-4', '1.2.3-8'].each do |version|
+          versions.has_key?(version).should == true
+          versions[version].should == :rpm
+        end
+      end
+    end
+
+    describe "#determine_latest_version" do
+      context "when there are multiple versions" do
+        it "should return the latest version" do
+          subject.send(:determine_latest_version, rpm_showres_output, 'mypackage.foo').should == [:rpm, '1.2.3-8']
+        end
+      end
+
+      context "when there is only one version" do
+        it "should return the type specifier and `nil` for the version number" do
+          nimclient_showres_output = <<END
+mypackage.foo                                                                ALL  @@R:mypackage.foo _all_filesets
+ @@R:mypackage.foo-1.2.3-4 1.2.3-4
+
+END
+          subject.send(:determine_latest_version, nimclient_showres_output, 'mypackage.foo').should == [:rpm, nil]
+        end
+      end
+
+    end
+
+    describe "#determine_package_type" do
+      it "should return :rpm for rpm packages" do
+        subject.send(:determine_package_type, rpm_showres_output, 'mypackage.foo', '1.2.3-4').should == :rpm
+      end
+
+      it "should return :installp for installp/bff packages" do
+        subject.send(:determine_package_type, bff_showres_output, 'mypackage.foo', '1.2.3.4').should == :installp
+      end
     end
   end
+
+
+
 end

data/spec/unit/provider/package/opkg_spec.rb

@@ -0,0 +1,180 @@
+#! /usr/bin/env ruby
+require 'spec_helper'
+
+describe Puppet::Type.type(:package).provider(:opkg) do
+
+  let(:resource) do
+    Puppet::Type.type(:package).new(:name => 'package')
+  end
+
+  let(:provider) { described_class.new(resource) }
+
+  before do
+    Puppet::Util::Execution.stubs(:execute).never
+    Puppet::Util.stubs(:which).with("opkg").returns("/bin/opkg")
+    Dir.stubs(:entries).with('/var/opkg-lists/').returns ['.', '..', 'packages']
+  end
+
+  describe "when installing" do
+    before do
+      provider.stubs(:query).returns({ :ensure => '1.0' })
+    end
+
+    context "when the package list is absent" do
+      before do
+        Dir.stubs(:entries).with('/var/opkg-lists/').returns ['.', '..']  #empty, no package list
+      end
+
+      it "fetches the package list when installing" do
+        provider.expects(:opkg).with('update')
+        provider.expects(:opkg).with("--force-overwrite", "install", resource[:name])
+
+        provider.install
+      end
+    end
+
+    context "when the package list is present" do
+      before do
+        Dir.stubs(:entries).with('/var/opkg-lists/').returns ['.', '..', 'lists']  # With a pre-downloaded package list
+      end
+
+      it "fetches the package list when installing" do
+        provider.expects(:opkg).with('update').never
+        provider.expects(:opkg).with("--force-overwrite", "install", resource[:name])
+
+        provider.install
+      end
+    end
+
+    it "should call opkg install" do
+      Puppet::Util::Execution.expects(:execute).with(["/bin/opkg", "--force-overwrite", "install", resource[:name]], {:failonfail => true, :combine => true, :custom_environment => {}})
+      provider.install
+    end
+
+    context "when :source is specified" do
+      context "works on valid urls" do
+        %w{
+          /some/package/file
+          http://some.package.in/the/air
+          ftp://some.package.in/the/air
+        }.each do |source|
+          it "should install #{source} directly" do
+            resource[:source] = source
+            Puppet::Util::Execution.expects(:execute).with(["/bin/opkg", "--force-overwrite", "install", resource[:source]], {:failonfail => true, :combine => true, :custom_environment => {}})
+            provider.install
+          end
+        end
+      end
+
+      context "as a file:// URL" do
+        before do
+          @package_file = "file:///some/package/file"
+          @actual_file_path = "/some/package/file"
+          resource[:source] = @package_file
+        end
+
+        it "should install from the path segment of the URL" do
+          Puppet::Util::Execution.expects(:execute).returns("")
+          provider.install
+        end
+      end
+
+      context "with invalid URL for opkg" do
+        before do
+          # Emulate the `opkg` command returning a non-zero exit value
+          Puppet::Util::Execution.stubs(:execute).raises Puppet::ExecutionFailure
+        end
+
+        context "puppet://server/whatever" do
+          before do
+            resource[:source] = "puppet://server/whatever"
+          end
+
+          it "should fail" do
+            expect { provider.install }.to raise_error, Puppet::ExecutionFailure
+          end
+        end
+
+        context "as a malformed URL" do
+          before do
+            resource[:source] = "blah://"
+          end
+
+          it "should fail" do
+            expect { provider.install }.to raise_error, Puppet::ExecutionFailure
+          end
+        end
+      end
+    end # end when source is specified
+  end # end when installing
+
+  describe "when updating" do
+    it "should call install" do
+      provider.expects(:install).returns("install return value")
+      provider.update.should == "install return value"
+    end
+  end
+
+  describe "when uninstalling" do
+    it "should run opkg remove bla" do
+      Puppet::Util::Execution.expects(:execute).with(["/bin/opkg", "remove", resource[:name]], {:failonfail => true, :combine => true, :custom_environment => {}})
+      provider.uninstall
+    end
+  end
+
+  describe "when querying" do
+
+    describe "self.instances" do
+      let (:packages) do
+        <<-OPKG_OUTPUT
+dropbear - 2011.54-2
+kernel - 3.3.8-1-ba5cdb2523b4fc7722698b4a7ece6702
+uhttpd - 2012-10-30-e57bf6d8bfa465a50eea2c30269acdfe751a46fd
+OPKG_OUTPUT
+      end
+      it "returns an array of packages" do
+        Puppet::Util.stubs(:which).with("opkg").returns("/bin/opkg")
+        described_class.stubs(:which).with("opkg").returns("/bin/opkg")
+        described_class.expects(:execpipe).with("/bin/opkg list-installed").yields(packages)
+
+        installed_packages = described_class.instances
+        installed_packages.length.should == 3
+
+        installed_packages[0].properties.should ==
+          {
+            :provider => :opkg,
+            :name => "dropbear",
+            :ensure => "2011.54-2"
+          }
+        installed_packages[1].properties.should ==
+          {
+            :provider => :opkg,
+            :name => "kernel",
+            :ensure => "3.3.8-1-ba5cdb2523b4fc7722698b4a7ece6702"
+          }
+        installed_packages[2].properties.should ==
+          {
+            :provider => :opkg,
+            :name => "uhttpd",
+            :ensure => "2012-10-30-e57bf6d8bfa465a50eea2c30269acdfe751a46fd"
+          }
+      end
+    end
+
+    it "should return a nil if the package isn't found" do
+      Puppet::Util::Execution.expects(:execute).returns("")
+      provider.query.should be_nil
+    end
+
+    it "should return a hash indicating that the package is missing on error" do
+      Puppet::Util::Execution.expects(:execute).raises(Puppet::ExecutionFailure.new("ERROR!"))
+      provider.query.should == {
+        :ensure => :purged,
+        :status => 'missing',
+        :name => resource[:name],
+        :error => 'ok',
+      }
+    end
+  end #end when querying
+
+end # end describe provider