puppet 2.7.26 → 3.0.0.rc4

data/spec/unit/provider/package/pkgutil_spec.rb

@@ -1,4 +1,4 @@
-#!/usr/bin/env rspec
+#! /usr/bin/env ruby -S rspec
 require 'spec_helper'
 
 provider = Puppet::Type.type(:package).provider(:pkgutil)
@@ -38,6 +38,20 @@ describe provider do
       @provider.expects(:pkguti).with('-y', '-i', 'TESTpkg')
       @provider.install
     end
+
+    it "should support a single temp repo URL" do
+      @resource[:ensure] = :latest
+      @resource[:source] = "http://example.net/repo"
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-y', '-i', 'TESTpkg')
+      @provider.install
+    end
+
+    it "should support multiple temp repo URLs as array" do
+      @resource[:ensure] = :latest
+      @resource[:source] = [ 'http://example.net/repo', 'http://example.net/foo' ]
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-t', 'http://example.net/foo', '-y', '-i', 'TESTpkg')
+      @provider.install
+    end
   end
 
   describe "when updating" do
@@ -45,6 +59,18 @@ describe provider do
       @provider.expects(:pkguti).with('-y', '-u', 'TESTpkg')
       @provider.update
     end
+
+    it "should support a single temp repo URL" do
+      @resource[:source] = "http://example.net/repo"
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-y', '-u', 'TESTpkg')
+      @provider.update
+    end
+
+    it "should support multiple temp repo URLs as array" do
+      @resource[:source] = [ 'http://example.net/repo', 'http://example.net/foo' ]
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-t', 'http://example.net/foo', '-y', '-u', 'TESTpkg')
+      @provider.update
+    end
   end
 
   describe "when uninstalling" do
@@ -52,6 +78,18 @@ describe provider do
       @provider.expects(:pkguti).with('-y', '-r', 'TESTpkg')
       @provider.uninstall
     end
+
+    it "should support a single temp repo URL" do
+      @resource[:source] = "http://example.net/repo"
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-y', '-r', 'TESTpkg')
+      @provider.uninstall
+    end
+
+    it "should support multiple temp repo URLs as array" do
+      @resource[:source] = [ 'http://example.net/repo', 'http://example.net/foo' ]
+      @provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-t', 'http://example.net/foo', '-y', '-r', 'TESTpkg')
+      @provider.uninstall
+    end
   end
 
   describe "when getting latest version" do
@@ -59,7 +97,16 @@ describe provider do
       fake_data = "
 noisy output here
 TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
+      @provider.latest.should == "1.4.5,REV=2007.11.20"
+    end
+
+    it "should support a temp repo URL" do
+      @resource[:source] = "http://example.net/repo"
+      fake_data = "
+noisy output here
+TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-c', '--single', 'TESTpkg').returns fake_data
       @provider.latest.should == "1.4.5,REV=2007.11.20"
     end
 
@@ -67,19 +114,19 @@ TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
       fake_data = "
 noisy output here
 TESTpkg                   1.4.5,REV=2007.11.18      SAME"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.latest.should == "1.4.5,REV=2007.11.18"
     end
 
     it "should handle a non-existent package" do
       fake_data = "noisy output here
 Not in catalog"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.latest.should == nil
     end
 
     it "should warn on unknown pkgutil noise" do
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns("testingnoise")
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns("testingnoise")
       @provider.latest.should == nil
     end
 
@@ -93,7 +140,7 @@ gpg: Good signature from \"Distribution Manager <dm@blastwave.org>\"
 ==> 2770 packages loaded from /var/opt/csw/pkgutil/catalog.mirror.opencsw.org_opencsw_unstable_i386_5.11
 package                   installed                 catalog
 TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.latest.should == "1.4.5,REV=2007.11.20"
     end
 
@@ -101,7 +148,7 @@ TESTpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
       fake_data = "
 noisy output here
 REALpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.query[:name].should == "TESTpkg"
     end
   end
@@ -109,22 +156,29 @@ REALpkg                   1.4.5,REV=2007.11.18      1.4.5,REV=2007.11.20"
   describe "when querying current version" do
     it "should return TESTpkg's version string" do
       fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.query[:ensure].should == "1.4.5,REV=2007.11.18"
     end
 
     it "should handle a package that isn't installed" do
       fake_data = "TESTpkg  notinst  1.4.5,REV=2007.11.20"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.query[:ensure].should == :absent
     end
 
     it "should handle a non-existent package" do
       fake_data = "noisy output here
 Not in catalog"
-      provider.expects(:pkguti).with(['-c', '--single', 'TESTpkg']).returns fake_data
+      provider.expects(:pkguti).with('-c', '--single', 'TESTpkg').returns fake_data
       @provider.query[:ensure].should == :absent
     end
+
+    it "should support a temp repo URL" do
+      @resource[:source] = "http://example.net/repo"
+      fake_data = "TESTpkg  1.4.5,REV=2007.11.18  1.4.5,REV=2007.11.20"
+      provider.expects(:pkguti).with('-t', 'http://example.net/repo', '-c', '--single', 'TESTpkg').returns fake_data
+      @provider.query[:ensure].should == "1.4.5,REV=2007.11.18"
+    end
   end
 
   describe "when querying current instances" do

data/spec/unit/provider/package/rpm_spec.rb

@@ -0,0 +1,58 @@
+#! /usr/bin/env ruby -S rspec
+require 'spec_helper'
+
+provider_class = Puppet::Type.type(:package).provider(:rpm)
+
+describe provider_class do
+  subject { provider_class }
+
+  let (:packages) do
+    <<-RPM_OUTPUT
+    cracklib-dicts 0 2.8.9 3.3 x86_64
+    basesystem 0 8.0 5.1.1.el5.centos noarch
+    chkconfig 0 1.3.30.2 2.el5 x86_64
+    RPM_OUTPUT
+  end
+
+  describe "self.instances" do
+    it "returns an array of packages" do
+      Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "--version"], {:custom_environment => {}}).returns("RPM version 5.x")
+      Puppet::Util.stubs(:which).with("rpm").returns("/bin/rpm")
+      subject.stubs(:which).with("rpm").returns("/bin/rpm")
+      Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa --nosignature --nodigest --qf '%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\n'").yields(packages)
+
+      installed_packages = subject.instances
+
+      installed_packages[0].properties.should ==
+        {
+          :provider => :rpm,
+          :name => "cracklib-dicts",
+          :epoch => "0",
+          :version => "2.8.9",
+          :release => "3.3",
+          :arch => "x86_64",
+          :ensure => "2.8.9-3.3"
+        }
+      installed_packages[1].properties.should ==
+        {
+          :provider => :rpm,
+          :name => "basesystem",
+          :epoch => "0",
+          :version => "8.0",
+          :release => "5.1.1.el5.centos",
+          :arch => "noarch",
+          :ensure => "8.0-5.1.1.el5.centos"
+        }
+      installed_packages[2].properties.should ==
+        {
+          :provider => :rpm,
+          :name => "chkconfig",
+          :epoch => "0",
+          :version => "1.3.30.2",
+          :release => "2.el5",
+          :arch => "x86_64",
+          :ensure => "1.3.30.2-2.el5"
+        }
+    end
+  end
+end

data/spec/unit/provider/package/sun_spec.rb

@@ -0,0 +1,122 @@
+#! /usr/bin/env ruby -S rspec
+require 'spec_helper'
+
+describe Puppet::Type.type(:package).provider(:sun) do
+  let(:resource) { Puppet::Type.type(:package).new(:name => 'dummy', :ensure => :installed, :provider => :sun) }
+  let(:provider) { resource.provider }
+
+  before(:each) do
+    # Stub some provider methods to avoid needing the actual software
+    # installed, so we can test on whatever platform we want.
+    provider.class.stubs(:command).with(:pkginfo).returns('/usr/bin/pkginfo')
+    provider.class.stubs(:command).with(:pkgadd).returns('/usr/sbin/pkgadd')
+    provider.class.stubs(:command).with(:pkgrm).returns('/usr/sbin/pkgrm')
+  end
+
+  describe 'provider features' do
+    it { should be_installable }
+    it { should be_uninstallable }
+    it { should be_upgradeable }
+    it { should_not be_versionable }
+  end
+
+  [:install, :uninstall, :latest, :query, :update].each do |method|
+    it "should have a #{method} method" do
+      provider.should respond_to(method)
+    end
+  end
+
+  context '#install' do
+    it "should install a package" do
+      resource[:ensure] = :installed
+      resource[:source] = '/cdrom'
+      provider.expects(:pkgadd).with(['-d', '/cdrom', '-n', 'dummy'])
+      provider.install
+    end
+
+    it "should install a package if it is not present on update" do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l', 'dummy'], {:failonfail => false}).returns File.read(my_fixture('dummy.server'))
+      provider.expects(:pkgrm).with(['-n', 'dummy'])
+      provider.expects(:install)
+      provider.update
+    end
+
+     it "should install a package on global zone if -G specified" do
+      resource[:ensure] = :installed
+      resource[:source] = '/cdrom'
+      resource[:install_options] = '-G'
+      provider.expects(:pkgadd).with(['-d', '/cdrom', '-G', '-n', 'dummy'])
+      provider.install
+    end
+  end
+
+  context '#uninstall' do
+    it "should uninstall a package" do
+      provider.expects(:pkgrm).with(['-n','dummy'])
+      provider.uninstall
+    end
+  end
+
+  context '#update' do
+    it "should call uninstall if not :absent on info2hash" do
+      provider.stubs(:info2hash).returns({:name => 'SUNWdummy', :ensure => "11.11.0,REV=2010.10.12.04.23"})
+      provider.expects(:uninstall)
+      provider.expects(:install)
+      provider.update
+    end
+
+    it "should not call uninstall if :absent on info2hash" do
+      provider.stubs(:info2hash).returns({:name => 'SUNWdummy', :ensure => :absent})
+      provider.expects(:install)
+      provider.update
+    end
+  end
+
+  context '#query' do
+    it "should find the package on query" do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l', 'dummy'], {:failonfail => false}).returns File.read(my_fixture('dummy.server'))
+      provider.query.should == {
+        :name     => 'SUNWdummy',
+        :category=>"system",
+        :platform=>"i386",
+        :ensure   => "11.11.0,REV=2010.10.12.04.23",
+        :root=>"/",
+        :description=>"Dummy server (9.6.1-P3)",
+        :vendor => "Oracle Corporation",
+      }
+    end
+
+    it "shouldn't find the package on query if it is not present" do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l', 'dummy'], {:failonfail => false}).returns 'ERROR: information for "dummy" not found.'
+      provider.query.should == {:ensure => :absent}
+    end
+
+    it "unknown message should raise error." do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l', 'dummy'], {:failonfail => false}).returns 'RANDOM'
+      lambda { provider.query }.should raise_error(Puppet::Error)
+    end
+  end
+
+  context '#instance' do
+    it "should list instances when there are packages in the system" do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l']).returns File.read(my_fixture('simple'))
+      instances = provider.class.instances.map { |p| {:name => p.get(:name), :ensure => p.get(:ensure)} }
+      instances.size.should == 2
+      instances[0].should == {
+        :name     => 'SUNWdummy',
+        :ensure   => "11.11.0,REV=2010.10.12.04.23",
+      }
+      instances[1].should == {
+        :name     => 'SUNWdummyc',
+        :ensure   => "11.11.0,REV=2010.10.12.04.24",
+      }
+    end
+
+    it "should return empty if there were no packages" do
+      Puppet::Util::Execution.expects(:execute).with(['/usr/bin/pkginfo', '-l']).returns ''
+      instances = provider.class.instances
+      instances.size.should == 0
+    end
+
+  end
+end

data/spec/unit/provider/package/up2date_spec.rb

@@ -0,0 +1,24 @@
+# spec/unit/provider/package/up2date_spec.rb
+require 'spec_helper'
+
+describe 'up2date package provider' do
+
+  # This sets the class itself as the subject rather than
+  # an instance of the class.
+  subject do
+    Puppet::Type.type(:package).provider(:up2date)
+  end
+
+  osfamilies = [ 'redhat' ]
+  releases = [ '2.1', '3', '4' ]
+
+  osfamilies.each do |osfamily|
+    releases.each do |release|
+      it "should be the default provider on #{osfamily} #{release}" do
+        Facter.expects(:value).with(:osfamily).returns(osfamily)
+        Facter.expects(:value).with(:lsbdistrelease).returns(release)
+        subject.default?.should be_true
+      end
+    end
+  end
+end

data/spec/unit/provider/package/windows/exe_package_spec.rb

@@ -0,0 +1,99 @@
+#! /usr/bin/env ruby -S rspec
+require 'spec_helper'
+require 'puppet/provider/package/windows/exe_package'
+
+describe Puppet::Provider::Package::Windows::ExePackage do
+  subject { described_class }
+
+  let (:name)        { 'Git version 1.7.11' }
+  let (:version)     { '1.7.11' }
+  let (:source)      { 'E:\Git-1.7.11.exe' }
+  let (:uninstall)   { '"C:\Program Files (x86)\Git\unins000.exe" /SP-' }
+
+  context '::from_registry' do
+    it 'should return an instance of ExePackage' do
+      subject.expects(:valid?).returns(true)
+
+      pkg = subject.from_registry('', {'DisplayName' => name, 'DisplayVersion' => version, 'UninstallString' => uninstall})
+      pkg.name.should == name
+      pkg.version.should == version
+      pkg.uninstall_string.should == uninstall
+    end
+
+    it 'should return nil if it is not a valid executable' do
+      subject.expects(:valid?).returns(false)
+
+      subject.from_registry('', {}).should be_nil
+    end
+  end
+
+  context '::valid?' do
+    let(:name)   { 'myproduct' }
+    let(:values) do { 'DisplayName' => name, 'UninstallString' => uninstall } end
+
+    {
+      'DisplayName'      => ['My App', ''],
+      'UninstallString'  => ['E:\uninstall.exe', ''],
+      'SystemComponent'  => [nil, 1],
+      'WindowsInstaller' => [nil, 1],
+      'ParentKeyName'    => [nil, 'Uber Product'],
+      'Security Update'  => [nil, 'KB890830'],
+      'Update Rollup'    => [nil, 'Service Pack 42'],
+      'Hotfix'           => [nil, 'QFE 42']
+    }.each_pair do |k, arr|
+      it "should accept '#{k}' with value '#{arr[0]}'" do
+        values[k] = arr[0]
+        subject.valid?(name, values).should be_true
+      end
+
+      it "should reject '#{k}' with value '#{arr[1]}'" do
+        values[k] = arr[1]
+        subject.valid?(name, values).should be_false
+      end
+    end
+
+    it 'should reject packages whose name starts with "KBXXXXXX"' do
+      subject.valid?('KB890830', values).should be_false
+    end
+
+    it 'should accept packages whose name does not start with "KBXXXXXX"' do
+      subject.valid?('My Update (KB890830)', values).should be_true
+    end
+  end
+
+  context '#match?' do
+    let(:pkg) { subject.new(name, version, uninstall) }
+
+    it 'should match product name' do
+      pkg.match?({:name => name}).should be_true
+    end
+
+    it 'should return false otherwise' do
+      pkg.match?({:name => 'not going to find it'}).should be_false
+    end
+  end
+
+  context '#install_command' do
+    it 'should install using the source' do
+      cmd = subject.install_command({:source => source})
+
+      cmd.should == ['cmd.exe', '/c', 'start', '/w', source]
+    end
+  end
+
+  context '#uninstall_command' do
+    ['C:\uninstall.exe', 'C:\Program Files\uninstall.exe'].each do |exe|
+      it "should quote #{exe}" do
+        subject.new(name, version, exe).uninstall_command.should ==
+          ['cmd.exe', '/c', 'start', '"puppet-uninstall"', '/w', "\"#{exe}\""]
+      end
+    end
+
+    ['"C:\Program Files\uninstall.exe"', '"C:\Program Files (x86)\Git\unins000.exe" /SILENT"'].each do |exe|
+      it "should not quote #{exe}" do
+        subject.new(name, version, exe).uninstall_command.should ==
+          ['cmd.exe', '/c', 'start', '"puppet-uninstall"', '/w', exe]
+      end
+    end
+  end
+end