puppet 0.24.9 → 0.25.0

data/spec/unit/configurer/downloader.rb

@@ -0,0 +1,188 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+require 'puppet/configurer/downloader'
+
+describe Puppet::Configurer::Downloader do
+    it "should require a name" do
+        lambda { Puppet::Configurer::Downloader.new }.should raise_error(ArgumentError)
+    end
+
+    it "should require a path and a source at initialization" do
+        lambda { Puppet::Configurer::Downloader.new("name") }.should raise_error(ArgumentError)
+    end
+
+    it "should set the name, path and source appropriately" do
+        dler = Puppet::Configurer::Downloader.new("facts", "path", "source")
+        dler.name.should == "facts"
+        dler.path.should == "path"
+        dler.source.should == "source"
+    end
+
+    it "should be able to provide a timeout value" do
+        Puppet::Configurer::Downloader.should respond_to(:timeout)
+    end
+
+    it "should use the configtimeout, converted to an integer, as its timeout" do
+        Puppet.settings.expects(:value).with(:configtimeout).returns "50"
+        Puppet::Configurer::Downloader.timeout.should == 50
+    end
+
+    describe "when creating the file that does the downloading" do
+        before do
+            @dler = Puppet::Configurer::Downloader.new("foo", "path", "source")
+        end
+
+        it "should create a file instance with the right path and source" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:path] == "path" and opts[:source] == "source" }
+            @dler.file
+        end
+
+        it "should tag the file with the downloader name" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:tag] == "foo" }
+            @dler.file
+        end
+
+        it "should always recurse" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:recurse] == true }
+            @dler.file
+        end
+
+        it "should always purge" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:purge] == true }
+            @dler.file
+        end
+
+        it "should never be in noop" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:noop] == false }
+            @dler.file
+        end
+
+        it "should always set the owner to the current UID" do
+            Process.expects(:uid).returns 51
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:owner] == 51 }
+            @dler.file
+        end
+
+        it "should always set the group to the current GID" do
+            Process.expects(:gid).returns 61
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:group] == 61 }
+            @dler.file
+        end
+
+        it "should always force the download" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:force] == true }
+            @dler.file
+        end
+
+        it "should never back up when downloading" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:backup] == false }
+            @dler.file
+        end
+
+        it "should support providing an 'ignore' parameter" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:ignore] == [".svn"] }
+            @dler = Puppet::Configurer::Downloader.new("foo", "path", "source", ".svn")
+            @dler.file
+        end
+
+        it "should split the 'ignore' parameter on whitespace" do
+            Puppet::Type.type(:file).expects(:new).with { |opts| opts[:ignore] == %w{.svn CVS} }
+            @dler = Puppet::Configurer::Downloader.new("foo", "path", "source", ".svn CVS")
+            @dler.file
+        end
+    end
+
+    describe "when creating the catalog to do the downloading" do
+        before do
+            @dler = Puppet::Configurer::Downloader.new("foo", "path", "source")
+        end
+
+        it "should create a catalog and add the file to it" do
+            file = mock 'file'
+            catalog = mock 'catalog'
+
+            @dler.expects(:file).returns file
+
+            Puppet::Resource::Catalog.expects(:new).returns catalog
+            catalog.expects(:add_resource).with(file)
+
+            @dler.catalog.should equal(catalog)
+        end
+    end
+
+    describe "when downloading" do
+        before do
+            @dler = Puppet::Configurer::Downloader.new("foo", "path", "source")
+        end
+
+        it "should log that it is downloading" do
+            Puppet.expects(:info)
+            Timeout.stubs(:timeout)
+
+            @dler.evaluate
+        end
+
+        it "should set a timeout for the download" do
+            Puppet::Configurer::Downloader.expects(:timeout).returns 50
+            Timeout.expects(:timeout).with(50)
+
+            @dler.evaluate
+        end
+
+        it "should apply the catalog within the timeout block" do
+            catalog = mock 'catalog'
+            @dler.expects(:catalog).returns(catalog)
+
+            Timeout.expects(:timeout).yields
+
+            catalog.expects(:apply)
+
+            @dler.evaluate
+        end
+
+        it "should return all changed file paths" do
+            trans = mock 'transaction'
+
+            catalog = mock 'catalog'
+            @dler.expects(:catalog).returns(catalog)
+            catalog.expects(:apply).yields(trans)
+
+            Timeout.expects(:timeout).yields
+
+            resource = mock 'resource'
+            resource.expects(:[]).with(:path).returns "/changed/file"
+
+            trans.expects(:changed?).returns([resource])
+
+            @dler.evaluate.should == %w{/changed/file}
+        end
+
+        it "should yield the resources if a block is given" do
+            trans = mock 'transaction'
+
+            catalog = mock 'catalog'
+            @dler.expects(:catalog).returns(catalog)
+            catalog.expects(:apply).yields(trans)
+
+            Timeout.expects(:timeout).yields
+
+            resource = mock 'resource'
+            resource.expects(:[]).with(:path).returns "/changed/file"
+
+            trans.expects(:changed?).returns([resource])
+
+            yielded = nil
+            @dler.evaluate { |r| yielded = r }
+            yielded.should == resource
+        end
+
+        it "should catch and log exceptions" do
+            Puppet.expects(:err)
+            Timeout.stubs(:timeout).raises(Puppet::Error, "testing")
+
+            lambda { @dler.evaluate }.should_not raise_error
+        end
+    end
+end

data/spec/unit/configurer/fact_handler.rb

@@ -0,0 +1,150 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+require 'puppet/configurer'
+require 'puppet/configurer/fact_handler'
+
+class FactHandlerTester
+    include Puppet::Configurer::FactHandler
+end
+
+describe Puppet::Configurer::FactHandler do
+    before do
+        @facthandler = FactHandlerTester.new
+    end
+
+    it "should have a method for downloading fact plugins" do
+        @facthandler.should respond_to(:download_fact_plugins)
+    end
+
+    it "should have a boolean method for determining whether fact plugins should be downloaded" do
+        @facthandler.should respond_to(:download_fact_plugins?)
+    end
+
+    it "should download fact plugins when :factsync is true" do
+        Puppet.settings.expects(:value).with(:factsync).returns true
+        @facthandler.should be_download_fact_plugins
+    end
+
+    it "should not download fact plugins when :factsync is false" do
+        Puppet.settings.expects(:value).with(:factsync).returns false
+        @facthandler.should_not be_download_fact_plugins
+    end
+
+    it "should not download fact plugins when downloading is disabled" do
+        Puppet::Configurer::Downloader.expects(:new).never
+        @facthandler.expects(:download_fact_plugins?).returns false
+        @facthandler.download_fact_plugins
+    end
+
+    it "should use an Agent Downloader, with the name, source, destination, and ignore set correctly, to download fact plugins when downloading is enabled" do
+        downloader = mock 'downloader'
+
+        Puppet.settings.expects(:value).with(:factsource).returns "fsource"
+        Puppet.settings.expects(:value).with(:factdest).returns "fdest"
+        Puppet.settings.expects(:value).with(:factsignore).returns "fignore"
+
+        Puppet::Configurer::Downloader.expects(:new).with("fact", "fdest", "fsource", "fignore").returns downloader
+
+        downloader.expects(:evaluate)
+
+        @facthandler.expects(:download_fact_plugins?).returns true
+        @facthandler.download_fact_plugins
+    end
+
+    it "should warn about factsync deprecation when factsync is enabled" do
+        Puppet::Configurer::Downloader.stubs(:new).returns mock("downloader", :evaluate => nil)
+
+        @facthandler.expects(:download_fact_plugins?).returns true
+        Puppet.expects(:warning)
+        @facthandler.download_fact_plugins
+    end
+
+    it "should have a method for retrieving facts" do
+        @facthandler.should respond_to(:find_facts)
+    end
+
+    it "should use the Facts class with the :certname to find the facts" do
+        Puppet.settings.expects(:value).with(:certname).returns "foo"
+        Puppet::Node::Facts.expects(:find).with("foo").returns "myfacts"
+        @facthandler.stubs(:reload_facter)
+        @facthandler.find_facts.should == "myfacts"
+    end
+
+    it "should reload Facter and find local facts when asked to find facts" do
+        @facthandler.expects(:reload_facter)
+
+        Puppet.settings.expects(:value).with(:certname).returns "myhost"
+        Puppet::Node::Facts.expects(:find).with("myhost")
+
+        @facthandler.find_facts
+    end
+
+    it "should fail if finding facts fails" do
+        @facthandler.stubs(:reload_facter)
+
+        Puppet.settings.stubs(:value).with(:trace).returns false
+        Puppet.settings.stubs(:value).with(:certname).returns "myhost"
+        Puppet::Node::Facts.expects(:find).raises RuntimeError
+
+        lambda { @facthandler.find_facts }.should raise_error(Puppet::Error)
+    end
+
+    it "should have a method to prepare the facts for uploading" do
+        @facthandler.should respond_to(:facts_for_uploading)
+    end
+
+    # I couldn't get marshal to work for this, only yaml, so we hard-code yaml.
+    it "should serialize and CGI escape the fact values for uploading" do
+        facts = stub 'facts'
+        facts.expects(:render).returns "my text"
+        text = CGI.escape("my text")
+
+        @facthandler.expects(:find_facts).returns facts
+
+        @facthandler.facts_for_uploading.should == {:facts_format => :yaml, :facts => text}
+    end
+
+    it "should properly accept facts containing a '+'" do
+        facts = stub 'facts'
+        facts.expects(:render).returns "my+text"
+        text = "my%2Btext"
+
+        @facthandler.expects(:find_facts).returns facts
+
+        @facthandler.facts_for_uploading.should == {:facts_format => :yaml, :facts => text}
+    end
+
+    it "should hard-code yaml as the serialization" do
+        facts = stub 'facts'
+        facts.expects(:render).with(:yaml).returns "my text"
+        text = CGI.escape("my text")
+
+        @facthandler.expects(:find_facts).returns facts
+
+        @facthandler.facts_for_uploading
+    end
+
+    describe "when reloading Facter" do
+        before do
+            Facter.stubs(:clear)
+            Facter.stubs(:load)
+            Facter.stubs(:loadfacts)
+        end
+
+        it "should clear Facter" do
+            Facter.expects(:clear)
+            @facthandler.reload_facter
+        end
+
+        it "should load all Facter facts" do
+            Facter.expects(:loadfacts)
+            @facthandler.reload_facter
+        end
+
+        it "should use the Facter terminus load all Puppet Fact plugins" do
+            Puppet::Node::Facts::Facter.expects(:load_fact_plugins)
+            @facthandler.reload_facter
+        end
+    end
+end

data/spec/unit/configurer/plugin_handler.rb

@@ -0,0 +1,112 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+require 'puppet/configurer'
+require 'puppet/configurer/plugin_handler'
+
+class PluginHandlerTester
+    include Puppet::Configurer::PluginHandler
+end
+
+describe Puppet::Configurer::PluginHandler do
+    before do
+        @pluginhandler = PluginHandlerTester.new
+    end
+
+    it "should have a method for downloading plugins" do
+        @pluginhandler.should respond_to(:download_plugins)
+    end
+
+    it "should have a boolean method for determining whether plugins should be downloaded" do
+        @pluginhandler.should respond_to(:download_plugins?)
+    end
+
+    it "should download plugins when :pluginsync is true" do
+        Puppet.settings.expects(:value).with(:pluginsync).returns true
+        @pluginhandler.should be_download_plugins
+    end
+
+    it "should not download plugins when :pluginsync is false" do
+        Puppet.settings.expects(:value).with(:pluginsync).returns false
+        @pluginhandler.should_not be_download_plugins
+    end
+
+    it "should not download plugins when downloading is disabled" do
+        Puppet::Configurer::Downloader.expects(:new).never
+        @pluginhandler.expects(:download_plugins?).returns false
+        @pluginhandler.download_plugins
+    end
+
+    it "should use an Agent Downloader, with the name, source, destination, and ignore set correctly, to download plugins when downloading is enabled" do
+        downloader = mock 'downloader'
+
+        Puppet.settings.expects(:value).with(:pluginsource).returns "psource"
+        Puppet.settings.expects(:value).with(:plugindest).returns "pdest"
+        Puppet.settings.expects(:value).with(:pluginsignore).returns "pignore"
+
+        Puppet::Configurer::Downloader.expects(:new).with("plugin", "pdest", "psource", "pignore").returns downloader
+
+        downloader.expects(:evaluate).returns []
+
+        @pluginhandler.expects(:download_plugins?).returns true
+        @pluginhandler.download_plugins
+    end
+
+    it "should be able to load plugins" do
+        @pluginhandler.should respond_to(:load_plugin)
+    end
+
+    it "should load each downloaded file" do
+        FileTest.stubs(:exist?).returns true
+        downloader = mock 'downloader'
+
+        Puppet::Configurer::Downloader.expects(:new).returns downloader
+
+        downloader.expects(:evaluate).returns %w{one two}
+
+        @pluginhandler.expects(:download_plugins?).returns true
+
+        @pluginhandler.expects(:load_plugin).with("one")
+        @pluginhandler.expects(:load_plugin).with("two")
+
+        @pluginhandler.download_plugins
+    end
+
+    it "should load plugins when asked to do so" do
+        FileTest.stubs(:exist?).returns true
+        @pluginhandler.expects(:load).with("foo")
+
+        @pluginhandler.load_plugin("foo")
+    end
+
+    it "should not try to load files that don't exist" do
+        FileTest.expects(:exist?).with("foo").returns true
+        @pluginhandler.expects(:load).never
+
+        @pluginhandler.load_plugin("foo")
+    end
+
+    it "should not try to load directories" do
+        FileTest.stubs(:exist?).returns true
+        FileTest.expects(:directory?).with("foo").returns true
+        @pluginhandler.expects(:load).never
+
+        @pluginhandler.load_plugin("foo")
+    end
+
+    it "should warn but not fail if loading a file raises an exception" do
+        FileTest.stubs(:exist?).returns true
+        @pluginhandler.expects(:load).with("foo").raises "eh"
+
+        Puppet.expects(:err)
+        @pluginhandler.load_plugin("foo")
+    end
+
+    it "should warn but not fail if loading a file raises a LoadError" do
+        FileTest.stubs(:exist?).returns true
+        @pluginhandler.expects(:load).with("foo").raises LoadError.new("eh")
+
+        Puppet.expects(:err)
+        @pluginhandler.load_plugin("foo")
+    end
+end