puppet-sec-lint 0.5.9 → 0.5.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66d4c1a23074509e42349a4a98389d2d7cd6128b11e179a351bd06af41e3b8f2
-  data.tar.gz: fc5bae0f4770b51b331d71b467ef2cb63d7967e8d86c7cf215305f1c63a70f15
+  metadata.gz: 269b5c5edfe9c78bf77bdee1dfd1d1a2cb3b20716c6aeec158d7b66c08d6e4a3
+  data.tar.gz: ab9c34d67d6320b4c235a394e7a5863d67a8eddc026978b30d14edd48de909cc
 SHA512:
-  metadata.gz: e2fde00b171f537752af40db32884ae62a44adaf2ff707974d0a60a85beb835f680898504340a6ce6d00171ffffbf1e895c33f25ecaa040d480e7668eff9b09c
-  data.tar.gz: 96eb37c5aa53750a5fba82011345b0187dead264a1d6c97522560a4181a770db30f59717bfee02cc37f1e443752037e657b761311d974895124d4dd0b4972bee
+  metadata.gz: 314f68b9f6bccd464511513006941fbcb2395a9cc5038ea30fad11f5c20debff9a92bb4343139159d15b0ffd66180514ff04383d7077c9628521b4bdf520b8ce
+  data.tar.gz: 44e430d28e8777da01a8277b3e5b3d1a59717e6a174c8e61ea26526d2c96cd916c0c0f7762f70bc29aee4147a405d2af75f7435b5a5e56f3488dbb85c2f38b4a

data/.idea/modules.xml

@@ -2,6 +2,7 @@
 <project version="4">
   <component name="ProjectModuleManager">
     <modules>
+      <module fileurl="file://$PROJECT_DIR$/.idea/modules/docs.iml" filepath="$PROJECT_DIR$/.idea/modules/docs.iml" />
       <module fileurl="file://$PROJECT_DIR$/.idea/puppet-sec-lint.iml" filepath="$PROJECT_DIR$/.idea/puppet-sec-lint.iml" />
     </modules>
   </component>

data/.idea/puppet-sec-lint.iml

@@ -15,6 +15,7 @@
     <orderEntry type="library" scope="PROVIDED" name="bundler (v2.2.3, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="inifile (v3.0.0, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="launchy (v2.5.0, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
+    <orderEntry type="library" scope="PROVIDED" name="logger (v1.4.3, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="minitest (v5.14.4, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="public_suffix (v4.0.6, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
     <orderEntry type="library" scope="PROVIDED" name="puppet-lint (v2.4.2, RVM: ruby-3.0.0 [global]) [gem]" level="application" />
@@ -24,30 +25,7 @@
   </component>
   <component name="RakeTasksCache">
     <option name="myRootTask">
-      <RakeTaskImpl id="rake">
-        <subtasks>
-          <RakeTaskImpl description="Build puppet-sec-lint-0.5.7.gem into the pkg directory" fullCommand="build" id="build" />
-          <RakeTaskImpl description="Remove any temporary products" fullCommand="clean" id="clean" />
-          <RakeTaskImpl description="Remove any generated files" fullCommand="clobber" id="clobber" />
-          <RakeTaskImpl description="Build and install puppet-sec-lint-0.5.7.gem into system gems" fullCommand="install" id="install" />
-          <RakeTaskImpl id="install">
-            <subtasks>
-              <RakeTaskImpl description="Build and install puppet-sec-lint-0.5.7.gem into system gems without network access" fullCommand="install:local" id="local" />
-            </subtasks>
-          </RakeTaskImpl>
-          <RakeTaskImpl description="Create tag v0.5.7 and build and push puppet-sec-lint-0.5.7.gem to https://rubygems.org" fullCommand="release[remote]" id="release[remote]" />
-          <RakeTaskImpl description="Run tests" fullCommand="test" id="test" />
-          <RakeTaskImpl description="" fullCommand="default" id="default" />
-          <RakeTaskImpl description="" fullCommand="release" id="release" />
-          <RakeTaskImpl id="release">
-            <subtasks>
-              <RakeTaskImpl description="" fullCommand="release:guard_clean" id="guard_clean" />
-              <RakeTaskImpl description="" fullCommand="release:rubygem_push" id="rubygem_push" />
-              <RakeTaskImpl description="" fullCommand="release:source_control_push" id="source_control_push" />
-            </subtasks>
-          </RakeTaskImpl>
-        </subtasks>
-      </RakeTaskImpl>
+      <RakeTaskImpl id="rake" />
     </option>
   </component>
 </module>

data/Gemfile

@@ -17,4 +17,6 @@ gem 'webrick'
 
 gem 'inifile'
 
-gem 'launchy'
+gem 'launchy'
+
+gem 'logger'

data/Gemfile.lock

@@ -1,13 +1,15 @@
 PATH
   remote: .
   specs:
-    puppet-sec-lint (0.5.7)
+    puppet-sec-lint (0.5.14)
       inifile (~> 3.0.0)
       launchy (~> 2.5.0)
+      logger (~> 1.4.3)
       minitest (~> 5.0)
       puppet-lint (~> 2.4, >= 2.4.2)
       rack (~> 2.2.3)
       rake (~> 13.0)
+      webrick (~> 1.7.0)
 
 GEM
   remote: https://rubygems.org/
@@ -17,6 +19,7 @@ GEM
     inifile (3.0.0)
     launchy (2.5.0)
       addressable (~> 2.7)
+    logger (1.4.3)
     minitest (5.14.4)
     public_suffix (4.0.6)
     puppet-lint (2.4.2)
@@ -30,6 +33,7 @@ PLATFORMS
 DEPENDENCIES
   inifile
   launchy
+  logger
   minitest (~> 5.0)
   puppet-lint
   puppet-sec-lint!

data/README.md

@@ -25,14 +25,6 @@ If the linter is called with a folder, all puppet files inside are recursively a
 puppet-sec-lint /folder
 ```
 
-To open the configurations page to better tune the different rules applied, use the appropriate flag:
-
-```bash
-puppet-sec-lint -c
-```
-(this will open the configurations page on the computer default web browser)
-
-
 ### Integration with Visual Studio Code
 
 The linter can also work inside Visual Studio code. For it, please ensure that the 'puppet-sec-lint' gem was installed on your system.
@@ -43,12 +35,36 @@ Now, after that the extension is activate, it should be activated automatically
 
 ![puppet-sec-lint console execution](docs/images/puppet-sec-lint_vscode.png)
 
+###Customization of Linter Rules
+
+All rules applied by the linter to detect vulnerabilities can be configured to better adapt the tool to any project conventions and requirements.
+
+To open the configurations page, use the appropriate flag:
+
+```bash
+puppet-sec-lint -c
+```
+(this will open the configurations page on the computer default web browser)
+
+![puppet-sec-lint configurations page](docs/images/puppet-sec-lint_configurations.png)
+
 ## Development
 
+### Development of new rules
+
+The linter was built on top of a modular architecture, which means that new customizable rules can be added fairly easy facing the discovery of new scenarios and vulnerabilities.
+
+<!--
+(add instructions on how to clone, build and run tool)
+
+(add instructions on where and how to add new rule and configurations)
+-->
+
 <!--After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).-->
 
+
 ## Contributing
 
 <!-- Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/puppet-sec-lint. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/puppet-sec-lint/blob/master/CODE_OF_CONDUCT.md). -->

data/docs/admin-by-default.md

@@ -24,4 +24,8 @@ Any account with the power to do everything in the system is a very dangerous si
 
 ## How to avoid it?
 
-Accounts should always be setup up with the [Principle of least privilege](https://us-cert.cisa.gov/bsi/articles/knowledge/principles/least-privilege) in mind, meaning that all accounts should only get the permissions strictly necessary to perform their required tasks during the minimum amount of time possible. This severely limits the exposure to accidental errors and also to malicious attackers.
+Accounts should always be setup up with the [Principle of least privilege](https://us-cert.cisa.gov/bsi/articles/knowledge/principles/least-privilege) in mind, meaning that all accounts should only get the permissions strictly necessary to perform their required tasks during the minimum amount of time possible. This severely limits the exposure to accidental errors and also to malicious attackers.
+
+## More related information
+
+* [CWE-250: Execution with Unnecessary Privileges](https://cwe.mitre.org/data/definitions/250.html)

data/docs/cyrillic-homograph-attack.md

@@ -37,4 +37,8 @@ This malicious domain on a Puppet manifest can point to a fake package repositor
 After the tool detects the presence of Cyrillic characters on a URL, the best course of action is to replace all Cyrillic characters with their Latin counterparts, as these characters are very rarely used in legitimate domains.
 Then, check if the domain is well written (subtle misspellings with similar letters are very common in these kinds of attacks).
 
-To better ensure that the domain is actually the correct one, the URL can also be copied from a trusted source.
+To better ensure that the domain is actually the correct one, the URL can also be copied from a trusted source.
+
+## More related information
+
+* [CWE-1007: Insufficient Visual Distinction of Homoglyphs Presented to User](https://cwe.mitre.org/data/definitions/1007.html)

data/docs/empty-password.md

@@ -24,4 +24,8 @@ An attacker looking to gain access to an account my try a couple of different ge
 
 ## How to avoid it?
 
-Secure software systems should have a decent password policy that prevents, among other types, empty passwords. This means that it's very likely for the Puppet manifest to fail as the password would be rejected. But even if the target software accepts empty passwords, a long and hard to guess password is always a much safer option against malicious attacks.
+Secure software systems should have a decent password policy that prevents, among other types, empty passwords. This means that it's very likely for the Puppet manifest to fail as the password would be rejected. But even if the target software accepts empty passwords, a long and hard to guess password is always a much safer option against malicious attacks.
+
+## More related information
+
+* [CWE-258: Empty Password in Configuration File](https://cwe.mitre.org/data/definitions/258.html)

data/docs/hard-coded-credentials.md

@@ -77,4 +77,9 @@ file { '/etc/mysql/server-key.pem':
   ensure  => file,
   content => hiera("privatekey"),
 }
-```
+```
+
+## More related information
+
+* [CWE-259: Use of Hard-coded Password](https://cwe.mitre.org/data/definitions/259.html)
+* [CWE-798: Use of Hard-coded Credentials](https://cwe.mitre.org/data/definitions/798.html)

data/docs/http-without-tls.md

@@ -0,0 +1,46 @@
+---
+title: Use HTTP without TLS
+permalink: /http-without-tls/
+layout: default
+---
+
+# Use HTTP without TLS
+
+## What is it?
+
+Connecting to a server using the regular HTTP protocol instead of the secure HTTPS, which uses TLS, doesn't allow for an encrypted connection. This means that all the data is sent in plaintext and easily viewed and modified by anyone, including malicious attackers.
+
+### Example
+Providing a server to run the PHPMyAdmin application:
+```puppet
+define phpmyadmin::server (
+  $blowfish_key      = md5("${::fqdn}${::ipaddress}"),
+  $absolute_uri      = "http://${::fqdn}/phpmyadmin/",
+  $config_file       = $::phpmyadmin::params::config_file
+)
+```
+This newly created service will be available to clients through a non secure HTTP address.
+
+A more secure way of hosting the server would be by using an HTTPS url:
+```puppet
+define phpmyadmin::server (
+  $blowfish_key      = md5("${::fqdn}${::ipaddress}"),
+  $absolute_uri      = "https://${::fqdn}/phpmyadmin/",
+  $config_file       = $::phpmyadmin::params::config_file
+)
+```
+
+
+## How can it be exploited?
+
+When a connection is made to a website using a non-secure HTTP address, all communications are sent unencrypted. An attacker can capture the traffic sent and received by a victim, for example, in the same Wifi network. After analyzing his traffic, the attacker can extract sensitive information exchanged by the victim with the websites visited, like passwords and tokens. 
+
+The attacker can then use this information to attack his victim, by logging in and impersonating him in several different websites that don't use the TLS protocol.
+
+## How to avoid it?
+
+All connections to internet addresses or made available to the public by a service configured with a Puppet manifest must use some kind of secure protocol, to ensure the confidentiality, authenticity and integrity of all data exchanged. Making an HTTPS connection is the easiest way to do this and it's also the recommended way of addressing this security vulnerability. In some cases, if the transferred information is verified afterwards by an hashing algorithm, like packages transferred from a repository, then this solution can be considered optional.
+
+## More related information
+
+* [CWE-319: Cleartext Transmission of Sensitive Information](https://cwe.mitre.org/data/definitions/319.html)

data/docs/invalid-ip-addr-binding.md

@@ -6,7 +6,7 @@ layout: default
 
 # Invalid IP Address binding
 
-## What it it?
+## What is it?
 
 Binding an IP address to a server or service means authorizing connections incoming from those networks. This allows to limit what kind of incoming connections a server may or may not accept. Binding the 0.0.0.0 IP address to a service means that any connection from any network is accepted.
 
@@ -28,4 +28,8 @@ A server or service that's open to all kinds of connections it's more exposed to
 
 ## How to avoid it?
 
-Properly configuring binding addresses means that the server should only accept connections from trusted networks known to use the service. This ensures a greater level of control and also protection, as an attacker would know have an extra obstacle in trying to gain access first to one of those networks.
+Properly configuring binding addresses means that the server should only accept connections from trusted networks known to use the service. This ensures a greater level of control and also protection, as an attacker would know have an extra obstacle in trying to gain access first to one of those networks.
+
+## More related information
+
+* [CWE-284: Improper Access Control](https://cwe.mitre.org/data/definitions/284.html)

data/docs/suspicious-comments.md

@@ -0,0 +1,31 @@
+---
+title: Suspicious Comments
+permalink: /suspicious-comments/
+layout: default
+---
+
+# Suspicious Comments
+
+## What are they?
+
+Suspicious comments are all comments left in a release of a Puppet Manifest that might suggest the existence of bugs, missing security functionalities or other weaknesses.
+
+
+### Example
+```puppet
+# TODO: switch password from weak hash to sha256
+$key = md5("${client_name} ${client_ip} ${client_seed}")
+```
+This comment immediately tells that developers are aware of the weakness of using a compromised hashing algorithm, but still hadn't made the necessary fix.
+
+## How can it be exploited?
+
+In the previous example, the presence of the comment immediately draws the attention of a malicious hacker who might have gained access to the code repository. By stating the portion of code that is considered insecure, it tells to an attacker exactly where to look for unpatched vulnerabilities. In this case, he could start working on ways to break the weak hashing algorithm.
+
+## How to avoid it?
+
+All comments indicating to be implemented features or non-resolved security issues should be erased, as they pose a very serious threat by gaining the attackers attention. Instead, proper and secure defect management solutions should be used. As a plus, the code stays clean and easy to read.
+
+## More related information
+
+* [CWE-546: Suspicious Comment](https://cwe.mitre.org/data/definitions/546.html)

data/docs/weak-crypto-algorithm.md

@@ -28,4 +28,9 @@ An attacker who was able to gain access to a server and steal the hashes from al
 
 ## How to avoid it?
 
-If the Puppet manifest is being used to generate hashes for passwords or important data, using a more secure algorithm like SHA256 is very advisable as it avoids exposure to the risks mentioned above, ensuring that the algorithm actually performs what's intended to.
+If the Puppet manifest is being used to generate hashes for passwords or important data, using a more secure algorithm like SHA256 is very advisable as it avoids exposure to the risks mentioned above, ensuring that the algorithm actually performs what's intended to.
+
+## More related information
+
+* [CWE-326: Inadequate Encryption Strength](https://cwe.mitre.org/data/definitions/326.html)
+* [CWE-327: Use of a Broken or Risky Cryptographic Algorithm](https://cwe.mitre.org/data/definitions/327.html)

data/exe/puppet-sec-lint

@@ -5,6 +5,7 @@ require 'json'
 require 'launchy'
 require 'optparse'
 require 'optparse/uri'
+require 'logger'
 require_relative '../lib/puppet-sec-lint/version'
 require_relative '../lib/visitors/configuration_visitor'
 require_relative '../lib/facades/configuration_file_facade'
@@ -12,6 +13,9 @@ require_relative '../lib/facades/configuration_file_facade'
 ConfigurationVisitor.GenerateIDs
 ConfigurationFileFacade.LoadConfigurations
 
+$logger = Logger.new(STDOUT)
+$logger.level = Logger::ERROR
+
 #get free port
 loop do
   $port = rand(3000..9999)
@@ -49,6 +53,11 @@ OptionParser.new do |opts|
   opts.on("-p", "--port=PORT", "TCP Port open for socket communication with the language server (Default:5007)") do |port|
     options[:port] = port
   end
+
+  opts.on("-v", "--verbose", "Verbose mode (shows all communications and other debug info)") do |v|
+    options[:verbose] = v
+    $logger.level = Logger::DEBUG
+  end
 end.parse!
 
 puts '___  _  _ ___  ___  ____ ___    ____ ____ ____ _  _ ____ _ ___ _   _    _    _ _  _ ___ ____ ____ '

data/lib/lol2.pp

@@ -0,0 +1,11 @@
+# addresses bug: https://bugs.launchpad.net/keystone/+bug/1472285
+class example (
+  $power_username= 'admin',
+  $power_password= ‘’,
+  $pwd = ‘EHDJSKD’
+){
+  $bind_host = ‘0.0.0.0’
+  $quantum_auth_url = ‘http://127.0.0.1:35357/v2.0’
+“  $”tr = "hey"
+  $message = sha1($str)
+}

data/lib/manifest.pp

@@ -0,0 +1,83 @@
+#class path_attribute {
+#  file { 'ssh_config_file':
+#    path    => '/etc/ssh/sshd_config',
+#    content => 'Bad path attribute, bad.',
+#  }
+#}
+
+# the following code addresses the bug: https://bugs.launchpad.net/keystone/+bug/1472285 .
+
+class consul_template::service (
+    $rpc_password                   = '{6ad470ec62b0511b63340dca2950d750181598efnHKvN1ge',
+    $admin_username = 'admin',
+    $password       = 'ceilometer',
+    $admin_password = 'admin',
+  ) {
+  exec { 'network-restart':
+    command        => 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDM release-runner key',
+    path           => '/usr/bin:/usr/sbin:/bin:/sbin',
+    refreshonly    => true,
+    vmware_md5     => 'LOL',
+    autho          => 'MD5',
+    cmd            => 'virsh secret-define --file ${secret_xml} && virsh secret-set-value --secret ${rbd_secret_uuid} --base64 $(ceph auth get-key client.${user})',
+    $auth_uri      => 'http://127.0.0.1:5000',
+    'bind_address' => '0.0.0.0',
+    password       => '',
+  }
+  case $::osfamily {
+    'RedHat': {
+    exec { 'upload-img':
+      command => "/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} add name=${img_name} is_public=${public} container_format=${container_format} disk_format=${disk_format} distro=${os_name} < /opt/vm/cirros-x86_64-disk.img",
+      unless => "/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} index && (/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} index | grep ${img_name})",
+
+      }
+    }
+    'Debian': {
+    exec { 'upload-img':
+      command => "/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} add name=${img_name} is_public=${public} container_format=${container_format} disk_format=${disk_format} distro=${os_name} < /usr/share/cirros-testvm/cirros-x86_64-disk.img",
+      unless => "/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} index && (/usr/bin/glance -N ${os_auth_url} -T ${os_tenant_name} -I ${os_username} -K ${os_password} index | grep ${img_name})",
+      key => "E8CC67053ED3B199",
+      key_content => '-----BEGIN PGP PUBLIC KEY BLOCK-----
+Version: GnuPG v1.4.11 (GNU/Linux)
+
+mQENBE/oXVkBCACcjAcV7lRGskECEHovgZ6a2robpBroQBW+tJds7B+qn/DslOAN
+1hm0UuGQsi8pNzHDE29FMO3yOhmkenDd1V/T6tHNXqhHvf55nL6anlzwMmq3syIS
+uqVjeMMXbZ4d+Rh0K/rI4TyRbUiI2DDLP+6wYeh1pTPwrleHm5FXBMDbU/OZ5vKZ
+67j99GaARYxHp8W/be8KRSoV9wU1WXr4+GA6K7ENe2A8PT+jH79Sr4kF4uKC3VxD
+BF5Z0yaLqr+1V2pHU3AfmybOCmoPYviOqpwj3FQ2PhtObLs+hq7zCviDTX2IxHBb
+Q3mGsD8wS9uyZcHN77maAzZlL5G794DEr1NLABEBAAG0NU9wZW5TdGFja0BDaXNj
+byBBUFQgcmVwbyA8b3BlbnN0YWNrLWJ1aWxkZEBjaXNjby5jb20+iQE4BBMBAgAi
+BQJP6F1ZAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDozGcFPtOxmXcK
+B/9WvQrBwxmIMV2M+VMBhQqtipvJeDX2Uv34Ytpsg2jldl0TS8XheGlUNZ5djxDy
+u3X0hKwRLeOppV09GVO3wGizNCV1EJjqQbCMkq6VSJjD1B/6Tg+3M/XmNaKHK3Op
+zSi+35OQ6xXc38DUOrigaCZUU40nGQeYUMRYzI+d3pPlNd0+nLndrE4rNNFB91dM
+BTeoyQMWd6tpTwz5MAi+I11tCIQAPCSG1qR52R3bog/0PlJzilxjkdShl1Cj0RmX
+7bHIMD66uC1FKCpbRaiPR8XmTPLv29ZTk1ABBzoynZyFDfliRwQi6TS20TuEj+ZH
+xq/T6MM6+rpdBVz62ek6/KBcuQENBE/oXVkBCACgzyyGvvHLx7g/Rpys1WdevYMH
+THBS24RMaDHqg7H7xe0fFzmiblWjV8V4Yy+heLLV5nTYBQLS43MFvFbnFvB3ygDI
+IdVjLVDXcPfcp+Np2PE8cJuDEE4seGU26UoJ2pPK/IHbnmGWYwXJBbik9YepD61c
+NJ5XMzMYI5z9/YNupeJoy8/8uxdxI/B66PL9QN8wKBk5js2OX8TtEjmEZSrZrIuM
+rVVXRU/1m732lhIyVVws4StRkpG+D15Dp98yDGjbCRREzZPeKHpvO/Uhn23hVyHe
+PIc+bu1mXMQ+N/3UjXtfUg27hmmgBDAjxUeSb1moFpeqLys2AAY+yXiHDv57ABEB
+AAGJAR8EGAECAAkFAk/oXVkCGwwACgkQ6MxnBT7TsZng+AgAnFogD90f3ByTVlNp
+Sb+HHd/cPqZ83RB9XUxRRnkIQmOozUjw8nq8I8eTT4t0Sa8G9q1fl14tXIJ9szzz
+BUIYyda/RYZszL9rHhucSfFIkpnp7ddfE9NDlnZUvavnnyRsWpIZa6hJq8hQEp92
+IQBF6R7wOws0A0oUmME25Rzam9qVbywOh9ZQvzYPpFaEmmjpCRDxJLB1DYu8lnC4
+h1jP1GXFUIQDbcznrR2MQDy5fNt678HcIqMwVp2CJz/2jrZlbSKfMckdpbiWNns/
+xKyLYs5m34d4a0it6wsMem3YCefSYBjyLGSd/kCI/CgOdGN1ZY1HSdLmmjiDkQPQ
+UcXHbA==
+=v6jg
+-----END PGP PUBLIC KEY BLOCK-----',
+
+      }
+    }
+  }
+  file { '/var/lib/gerrit/.ssh/id_rsa' :
+    owner   => 'gerrit',
+    group   => 'gerrit',
+    mode    => '0600',
+    content => $ssh_replication_rsa_key_contents,
+    replace => true,
+    require => File['/var/lib/gerrit/.ssh']
+  }
+}

data/lib/puppet-sec-lint/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PuppetSecLint
-  VERSION = "0.5.9"
+  VERSION = "0.5.15"
   YEAR = "2021"
-  AUTHOR = "Tiago Ribeiro"
+  AUTHOR = "TQRG"
 end

data/lib/rule_engine.rb

@@ -21,8 +21,9 @@ class RuleEngine
     begin
       lexer = PuppetLint::Lexer.new
       tokens = lexer.tokenise(code)
-    rescue
-      puts "Error in getting tokens from Puppet-Lint"
+    rescue => error
+      $logger.error("Error in getting tokens from Puppet-Lint")
+      $logger.error(error.backtrace)
       tokens = []
     end
 
@@ -34,8 +35,12 @@ class RuleEngine
     tokens = self.getTokens(code)
 
     @rules.each do |rule|
-      if rule.configurations[0].value
-        (result << rule.AnalyzeTokens(tokens)).flatten!
+      begin
+        if rule.configurations[0].value
+          (result << rule.AnalyzeTokens(tokens)).flatten!
+        end
+      rescue
+        $logger.error("Error in running rule #{rule.name}")
       end
     end
 

data/lib/rules/no_http_rule.rb

@@ -8,21 +8,22 @@ class NoHTTPRule < Rule
   @resources = %w[apt::source ::apt::source wget::fetch yumrepo yum:: aptly::mirror util::system_package yum::managed_yumrepo]
   @keywords = %w[backport key download uri mirror]
   @http = /^http:\/\/.+/
-  @whitelist = [] # Todo:Need to check how is this set up
+  @whitelist = ""
 
   @resources_conf = ListConfiguration.new("List of resources that can use HTTP", @resources, "List of resources that are known to not use HTTPS but that validate the transferred content with other secure methods.")
   @keywords_conf = ListConfiguration.new("List of keywords for URLs", @keywords, "List of keywords that identify hyperlinks that should be analyzed.")
+  @whitelist_conf = RegexConfiguration.new("HTTP Address whitelist", @whitelist, "List of addresses that are allowed to have non-secure http connections to them.")
   @http_conf = RegexConfiguration.new("Regular expression of a normal HTTP address", @http, "Regular expression that identifies the URL of a website using the regular non-secure HTTP protocol.")
 
-  @configurations+=[@resources_conf, @keywords_conf, @http_conf]
+  @configurations+=[@resources_conf, @keywords_conf, @http_conf, @whitelist_conf]
 
   def self.AnalyzeTokens(tokens)
     result = []
 
     ptokens = self.filter_resources(tokens, @resources_conf.value)
-    ctokens = self.filter_variables(ptokens, @keywords_conf.value)
-    if @whitelist
-      wtokens = self.filter_whitelist(ctokens)
+    ctokens = self.filter_variables(ptokens, @keywords_conf.value) #TODO: It's working upside down
+    if not @whitelist_conf.value.empty?
+      wtokens = self.filter_whitelist(ctokens, @whitelist_conf.value)
     else
       wtokens = ptokens
     end

data/lib/rules/rule.rb

@@ -67,10 +67,9 @@ class Rule
     return ftokens
   end
 
-  def self.filter_whitelist(tokens)
+  def self.filter_whitelist(tokens, whitelist)
     ftokens=tokens.find_all do |hash|
-      #!(@whitelist =~ hash.value.downcase)
-      true # TODO: Understand the whitelist
+      !(whitelist =~ hash.value.downcase)
     end
     return ftokens
   end

data/lib/servers/language_server.rb

@@ -18,7 +18,7 @@ class LanguageServer
           length=Integer(line.scan(/\d/).join(''))
           line=client.read(length+2)
           request = JSON.parse(line)
-          puts line
+          $logger.debug(line)
 
           method_name = request['method'].sub('/', '_')
           response = if self.respond_to? "client_"+method_name then self.send("client_"+method_name,request['id'],request['params']) end
@@ -27,7 +27,7 @@ class LanguageServer
             client.flush
             client.print("Content-Length: "+response.length.to_s+"\r\n\r\n")
             client.print(response)
-            puts response
+            $logger.debug(response)
           end
         end
         client.close

data/lib/servers/linter_server.rb

@@ -1,4 +1,5 @@
 require "rack"
+require 'webrick'
 require 'json'
 require 'uri'
 require_relative '../rule_engine'
@@ -43,7 +44,8 @@ class LinterServer
   end
 
   def self.start(port)
-    Rack::Handler::WEBrick.run(LinterServer.new, :Port => port)
+    log = WEBrick::Log.new $stdout,1
+    Rack::Handler::WEBrick.run(LinterServer.new, :Port => port,Logger: log )
   end
 
 end

data/puppet-sec-lint.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Tiago Ribeiro"]
   spec.email         = ["tiago7b27@gmail.com"]
 
-  spec.summary       = "This is a security linter for the puppet language"
-  spec.description   = "This is a more complete security linter for the puppet language"
+  spec.summary       = "Security vulnerabilities linter for Puppet Manifests"
+  spec.description   = "Linter built to detect potential security vulnerabilities in Puppet manifests code. It also offers integration with Visual Studio Code https://marketplace.visualstudio.com/items?itemName=tiago1998.puppet-sec-lint-vscode"
   spec.homepage      = "https://github.com/TiagoR98/puppet-sec-lint"
   spec.license       = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
@@ -37,6 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'webrick', '~> 1.7.0'
   spec.add_runtime_dependency 'inifile', '~> 3.0.0'
   spec.add_runtime_dependency 'launchy', '~> 2.5.0'
+  spec.add_runtime_dependency 'logger', '~> 1.4.3'
 
   # For more information and examples about making a new gem, checkout our
   # guide at: https://bundler.io/guides/creating_gem.html

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-sec-lint
 version: !ruby/object:Gem::Version
-  version: 0.5.9
+  version: 0.5.15
 platform: ruby
 authors:
 - Tiago Ribeiro
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-05-14 00:00:00.000000000 Z
+date: 2021-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -114,7 +114,22 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.5.0
-description: This is a more complete security linter for the puppet language
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.4.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.4.3
+description: Linter built to detect potential security vulnerabilities in Puppet manifests
+  code. It also offers integration with Visual Studio Code https://marketplace.visualstudio.com/items?itemName=tiago1998.puppet-sec-lint-vscode
 email:
 - tiago7b27@gmail.com
 executables:
@@ -157,10 +172,13 @@ files:
 - docs/cyrillic-homograph-attack.md
 - docs/empty-password.md
 - docs/hard-coded-credentials.md
+- docs/http-without-tls.md
+- docs/images/puppet-sec-lint_configurations.png
 - docs/images/puppet-sec-lint_console.png
 - docs/images/puppet-sec-lint_vscode.png
 - docs/index.md
 - docs/invalid-ip-addr-binding.md
+- docs/suspicious-comments.md
 - docs/weak-crypto-algorithm.md
 - exe/puppet-sec-lint
 - lib/configurations/boolean_configuration.rb
@@ -170,6 +188,8 @@ files:
 - lib/facades/configuration_file_facade.rb
 - lib/facades/configuration_page_facade.rb
 - lib/lol.pp
+- lib/lol2.pp
+- lib/manifest.pp
 - lib/puppet-sec-lint/version.rb
 - lib/rule_engine.rb
 - lib/rules/admin_by_default_rule.rb
@@ -183,11 +203,9 @@ files:
 - lib/rules/use_weak_crypto_algorithms_rule.rb
 - lib/servers/language_server.rb
 - lib/servers/linter_server.rb
-- lib/settings.ini
 - lib/sin/sin.rb
 - lib/sin/sin_type.rb
 - lib/visitors/configuration_visitor.rb
-- puppet-sec-lint-0.5.8.gem
 - puppet-sec-lint.gemspec
 homepage: https://github.com/TiagoR98/puppet-sec-lint
 licenses:
@@ -215,5 +233,5 @@ requirements: []
 rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
-summary: This is a security linter for the puppet language
+summary: Security vulnerabilities linter for Puppet Manifests
 test_files: []

data/lib/settings.ini

@@ -1,39 +0,0 @@
-[HardCodedCredentialsRule]
-HardCodedCredentialsRule-enable_configuration = false
-HardCodedCredentialsRule-list_of_known_words_not_considered_in_credentials = pe-puppet,pe-webserver,pe-puppetdb,pe-postgres,pe-console-services,pe-orchestration-services,pe-ace-server,pe-bolt-server
-HardCodedCredentialsRule-list_of_invalid_values_in_credentials = undefined,unset,www-data,wwwrun,www,no,yes,[],root
-HardCodedCredentialsRule-regular_expression_of_words_present_in_credentials = (?-mix:user|usr|pass(word|_|$)|pwd|key|secret)
-HardCodedCredentialsRule-regular_expression_of_words_not_present_in_credentials = (?-mix:gpg|path|type|buff|zone|mode|tag|header|scheme|length|guid)
-
-[NoHTTPRule]
-NoHTTPRule-enable_configuration = false
-NoHTTPRule-list_of_resources_that_can_use_http = apt::source,::apt::source,wget::fetch,yumrepo,yum::,aptly::mirror,util::system_package,yum::managed_yumrepo
-NoHTTPRule-list_of_keywords_for_urls = backport,key,download,uri,mirror
-NoHTTPRule-regular_expression_of_a_normal_http_address = (?-mix:^http:\/\/.+)
-
-[AdminByDefaultRule]
-AdminByDefaultRule-enable_configuration = true
-AdminByDefaultRule-regular_expression_of_words_present_in_credentials = (?-mix:user|usr|pass(word|_|$)|pwd)
-
-[EmptyPasswordRule]
-EmptyPasswordRule-enable_configuration = true
-EmptyPasswordRule-list_of_trigger_words = pwd,password,pass
-EmptyPasswordRule-regular_expression_of_password_name = (?-mix:pass(word|_|$)|pwd)
-
-[InvalidIPAddrBindingRule]
-InvalidIPAddrBindingRule-enable_configuration = true
-InvalidIPAddrBindingRule-regular_expression_of_an_invalid_ip_address = (?-mix:^((http(s)?:\/\/)?0.0.0.0(:\d{1,5})?)$)
-
-[UseWeakCryptoAlgorithmsRule]
-UseWeakCryptoAlgorithmsRule-enable_configuration = true
-UseWeakCryptoAlgorithmsRule-regular_expression_of_weak_crypto_algorithms = (?-mix:^(sha1|md5))
-
-[SuspiciousCommentRule]
-SuspiciousCommentRule-enable_configuration = true
-SuspiciousCommentRule-list_of_trigger_words = hack,fixme,later,later2,todo,ticket,launchpad,bug,to-do
-SuspiciousCommentRule-regular_expression_of_keywords_present_in_suspicious_comments = (?-mix:hack|fixme|ticket|bug|secur|debug|defect|weak)
-
-[CyrillicHomographAttack]
-CyrillicHomographAttack-enable_configuration = true
-CyrillicHomographAttack-regular_expression_of_links_with_cyrillic_characters = (?-mix:^(http(s)?:\/\/)?.*\p{Cyrillic}+)
-