puppet-sec-lint 0.5.14 → 0.5.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4f5d30d4bf9e32338bf3c81fa619d6cb6560870343d01a62905282ac5724d6e
-  data.tar.gz: d6d63ef87f2df9654f2edac1a1b75f3525b2bc514e46608f2990923b830a5134
+  metadata.gz: 269b5c5edfe9c78bf77bdee1dfd1d1a2cb3b20716c6aeec158d7b66c08d6e4a3
+  data.tar.gz: ab9c34d67d6320b4c235a394e7a5863d67a8eddc026978b30d14edd48de909cc
 SHA512:
-  metadata.gz: 90e1f2fddbc2d97ad919d54e98870650f4d56b944676ff8f115a29b84395ae9413770d4985f45510fd77a5de46b5a4377b404974eb8265aca8a18087a9392d83
-  data.tar.gz: 88312bf0a323156a1eb265700079cacf07c19e92c190d6b497acf28e2b08a92b7cb56ec7e656649ffff5865dfb7b08f546b0dc90f72fcba13fbf8e6fe2e8cd43
+  metadata.gz: 314f68b9f6bccd464511513006941fbcb2395a9cc5038ea30fad11f5c20debff9a92bb4343139159d15b0ffd66180514ff04383d7077c9628521b4bdf520b8ce
+  data.tar.gz: 44e430d28e8777da01a8277b3e5b3d1a59717e6a174c8e61ea26526d2c96cd916c0c0f7762f70bc29aee4147a405d2af75f7435b5a5e56f3488dbb85c2f38b4a

data/docs/admin-by-default.md

@@ -24,4 +24,8 @@ Any account with the power to do everything in the system is a very dangerous si
 
 ## How to avoid it?
 
-Accounts should always be setup up with the [Principle of least privilege](https://us-cert.cisa.gov/bsi/articles/knowledge/principles/least-privilege) in mind, meaning that all accounts should only get the permissions strictly necessary to perform their required tasks during the minimum amount of time possible. This severely limits the exposure to accidental errors and also to malicious attackers.
+Accounts should always be setup up with the [Principle of least privilege](https://us-cert.cisa.gov/bsi/articles/knowledge/principles/least-privilege) in mind, meaning that all accounts should only get the permissions strictly necessary to perform their required tasks during the minimum amount of time possible. This severely limits the exposure to accidental errors and also to malicious attackers.
+
+## More related information
+
+* [CWE-250: Execution with Unnecessary Privileges](https://cwe.mitre.org/data/definitions/250.html)

data/docs/cyrillic-homograph-attack.md

@@ -37,4 +37,8 @@ This malicious domain on a Puppet manifest can point to a fake package repositor
 After the tool detects the presence of Cyrillic characters on a URL, the best course of action is to replace all Cyrillic characters with their Latin counterparts, as these characters are very rarely used in legitimate domains.
 Then, check if the domain is well written (subtle misspellings with similar letters are very common in these kinds of attacks).
 
-To better ensure that the domain is actually the correct one, the URL can also be copied from a trusted source.
+To better ensure that the domain is actually the correct one, the URL can also be copied from a trusted source.
+
+## More related information
+
+* [CWE-1007: Insufficient Visual Distinction of Homoglyphs Presented to User](https://cwe.mitre.org/data/definitions/1007.html)

data/docs/empty-password.md

@@ -24,4 +24,8 @@ An attacker looking to gain access to an account my try a couple of different ge
 
 ## How to avoid it?
 
-Secure software systems should have a decent password policy that prevents, among other types, empty passwords. This means that it's very likely for the Puppet manifest to fail as the password would be rejected. But even if the target software accepts empty passwords, a long and hard to guess password is always a much safer option against malicious attacks.
+Secure software systems should have a decent password policy that prevents, among other types, empty passwords. This means that it's very likely for the Puppet manifest to fail as the password would be rejected. But even if the target software accepts empty passwords, a long and hard to guess password is always a much safer option against malicious attacks.
+
+## More related information
+
+* [CWE-258: Empty Password in Configuration File](https://cwe.mitre.org/data/definitions/258.html)

data/docs/hard-coded-credentials.md

@@ -77,4 +77,9 @@ file { '/etc/mysql/server-key.pem':
   ensure  => file,
   content => hiera("privatekey"),
 }
-```
+```
+
+## More related information
+
+* [CWE-259: Use of Hard-coded Password](https://cwe.mitre.org/data/definitions/259.html)
+* [CWE-798: Use of Hard-coded Credentials](https://cwe.mitre.org/data/definitions/798.html)

data/docs/http-without-tls.md

@@ -39,4 +39,8 @@ The attacker can then use this information to attack his victim, by logging in a
 
 ## How to avoid it?
 
-All connections to internet addresses or made available to the public by a service configured with a Puppet manifest must use some kind of secure protocol, to ensure the confidentiality, authenticity and integrity of all data exchanged. Making an HTTPS connection is the easiest way to do this and it's also the recommended way of addressing this security vulnerability. In some cases, if the transferred information is verified afterwards by an hashing algorithm, like packages transferred from a repository, then this solution can be considered optional.
+All connections to internet addresses or made available to the public by a service configured with a Puppet manifest must use some kind of secure protocol, to ensure the confidentiality, authenticity and integrity of all data exchanged. Making an HTTPS connection is the easiest way to do this and it's also the recommended way of addressing this security vulnerability. In some cases, if the transferred information is verified afterwards by an hashing algorithm, like packages transferred from a repository, then this solution can be considered optional.
+
+## More related information
+
+* [CWE-319: Cleartext Transmission of Sensitive Information](https://cwe.mitre.org/data/definitions/319.html)

data/docs/invalid-ip-addr-binding.md

@@ -28,4 +28,8 @@ A server or service that's open to all kinds of connections it's more exposed to
 
 ## How to avoid it?
 
-Properly configuring binding addresses means that the server should only accept connections from trusted networks known to use the service. This ensures a greater level of control and also protection, as an attacker would know have an extra obstacle in trying to gain access first to one of those networks.
+Properly configuring binding addresses means that the server should only accept connections from trusted networks known to use the service. This ensures a greater level of control and also protection, as an attacker would know have an extra obstacle in trying to gain access first to one of those networks.
+
+## More related information
+
+* [CWE-284: Improper Access Control](https://cwe.mitre.org/data/definitions/284.html)

data/docs/suspicious-comments.md

@@ -0,0 +1,31 @@
+---
+title: Suspicious Comments
+permalink: /suspicious-comments/
+layout: default
+---
+
+# Suspicious Comments
+
+## What are they?
+
+Suspicious comments are all comments left in a release of a Puppet Manifest that might suggest the existence of bugs, missing security functionalities or other weaknesses.
+
+
+### Example
+```puppet
+# TODO: switch password from weak hash to sha256
+$key = md5("${client_name} ${client_ip} ${client_seed}")
+```
+This comment immediately tells that developers are aware of the weakness of using a compromised hashing algorithm, but still hadn't made the necessary fix.
+
+## How can it be exploited?
+
+In the previous example, the presence of the comment immediately draws the attention of a malicious hacker who might have gained access to the code repository. By stating the portion of code that is considered insecure, it tells to an attacker exactly where to look for unpatched vulnerabilities. In this case, he could start working on ways to break the weak hashing algorithm.
+
+## How to avoid it?
+
+All comments indicating to be implemented features or non-resolved security issues should be erased, as they pose a very serious threat by gaining the attackers attention. Instead, proper and secure defect management solutions should be used. As a plus, the code stays clean and easy to read.
+
+## More related information
+
+* [CWE-546: Suspicious Comment](https://cwe.mitre.org/data/definitions/546.html)

data/docs/weak-crypto-algorithm.md

@@ -28,4 +28,9 @@ An attacker who was able to gain access to a server and steal the hashes from al
 
 ## How to avoid it?
 
-If the Puppet manifest is being used to generate hashes for passwords or important data, using a more secure algorithm like SHA256 is very advisable as it avoids exposure to the risks mentioned above, ensuring that the algorithm actually performs what's intended to.
+If the Puppet manifest is being used to generate hashes for passwords or important data, using a more secure algorithm like SHA256 is very advisable as it avoids exposure to the risks mentioned above, ensuring that the algorithm actually performs what's intended to.
+
+## More related information
+
+* [CWE-326: Inadequate Encryption Strength](https://cwe.mitre.org/data/definitions/326.html)
+* [CWE-327: Use of a Broken or Risky Cryptographic Algorithm](https://cwe.mitre.org/data/definitions/327.html)

data/lib/puppet-sec-lint/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PuppetSecLint
-  VERSION = "0.5.14"
+  VERSION = "0.5.15"
   YEAR = "2021"
   AUTHOR = "TQRG"
 end

data/lib/rules/no_http_rule.rb

@@ -22,7 +22,7 @@ class NoHTTPRule < Rule
 
     ptokens = self.filter_resources(tokens, @resources_conf.value)
     ctokens = self.filter_variables(ptokens, @keywords_conf.value) #TODO: It's working upside down
-    if @whitelist_conf.value
+    if not @whitelist_conf.value.empty?
       wtokens = self.filter_whitelist(ctokens, @whitelist_conf.value)
     else
       wtokens = ptokens

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-sec-lint
 version: !ruby/object:Gem::Version
-  version: 0.5.14
+  version: 0.5.15
 platform: ruby
 authors:
 - Tiago Ribeiro
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-05-17 00:00:00.000000000 Z
+date: 2021-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: puppet-lint
@@ -178,6 +178,7 @@ files:
 - docs/images/puppet-sec-lint_vscode.png
 - docs/index.md
 - docs/invalid-ip-addr-binding.md
+- docs/suspicious-comments.md
 - docs/weak-crypto-algorithm.md
 - exe/puppet-sec-lint
 - lib/configurations/boolean_configuration.rb
@@ -202,7 +203,6 @@ files:
 - lib/rules/use_weak_crypto_algorithms_rule.rb
 - lib/servers/language_server.rb
 - lib/servers/linter_server.rb
-- lib/settings.ini
 - lib/sin/sin.rb
 - lib/sin/sin_type.rb
 - lib/visitors/configuration_visitor.rb

data/lib/settings.ini

@@ -1,40 +0,0 @@
-[HardCodedCredentialsRule]
-HardCodedCredentialsRule-enable_configuration = true
-HardCodedCredentialsRule-list_of_known_words_not_considered_in_credentials = pe-puppet,pe-webserver,pe-puppetdb,pe-postgres,pe-console-services,pe-orchestration-services,pe-ace-server,pe-bolt-server
-HardCodedCredentialsRule-list_of_invalid_values_in_credentials = undefined,unset,www-data,wwwrun,www,no,yes,[],root
-HardCodedCredentialsRule-regular_expression_of_words_present_in_credentials = (?-mix:user|usr|pass(word|_|$)|pwd|key|secret)
-HardCodedCredentialsRule-regular_expression_of_words_not_present_in_credentials = (?-mix:gpg|path|type|buff|zone|mode|tag|header|scheme|length|guid)
-
-[NoHTTPRule]
-NoHTTPRule-enable_configuration = true
-NoHTTPRule-list_of_resources_that_can_use_http = apt::source,::apt::source,wget::fetch,yumrepo,yum::,aptly::mirror,util::system_package,yum::managed_yumrepo
-NoHTTPRule-list_of_keywords_for_urls = backport,key,download,uri,mirror
-NoHTTPRule-regular_expression_of_a_normal_http_address = (?-mix:^http:\/\/.+)
-NoHTTPRule-http_address_whitelist = (?-mix:^(127.0.0.1))
-
-[AdminByDefaultRule]
-AdminByDefaultRule-enable_configuration = true
-AdminByDefaultRule-regular_expression_of_words_present_in_credentials = (?-mix:user|usr|pass(word|_|$)|pwd)
-
-[EmptyPasswordRule]
-EmptyPasswordRule-enable_configuration = true
-EmptyPasswordRule-list_of_trigger_words = pwd,password,pass
-EmptyPasswordRule-regular_expression_of_password_name = (?-mix:pass(word|_|$)|pwd)
-
-[InvalidIPAddrBindingRule]
-InvalidIPAddrBindingRule-enable_configuration = true
-InvalidIPAddrBindingRule-regular_expression_of_an_invalid_ip_address = (?-mix:^((http(s)?:\/\/)?0.0.0.0(:\d{1,5})?)$)
-
-[UseWeakCryptoAlgorithmsRule]
-UseWeakCryptoAlgorithmsRule-enable_configuration = true
-UseWeakCryptoAlgorithmsRule-regular_expression_of_weak_crypto_algorithms = (?-mix:^(sha1|md5))
-
-[SuspiciousCommentRule]
-SuspiciousCommentRule-enable_configuration = true
-SuspiciousCommentRule-list_of_trigger_words = hack,fixme,later,later2,todo,ticket,launchpad,bug,to-do
-SuspiciousCommentRule-regular_expression_of_keywords_present_in_suspicious_comments = (?-mix:hack|fixme|ticket|bug|secur|debug|defect|weak)
-
-[CyrillicHomographAttack]
-CyrillicHomographAttack-enable_configuration = true
-CyrillicHomographAttack-regular_expression_of_links_with_cyrillic_characters = (?-mix:^(http(s)?:\/\/)?.*\p{Cyrillic}+)
-