puppet-retrospec 1.0.0 → 1.1.0

data/spec/unit/generators/node_generator_spec.rb

@@ -1,17 +1,16 @@
 require 'spec_helper'
 
 describe Retrospec::Puppet::Generators::NodeGenerator do
-
   after(:each) do
-    FileUtils.rm(spec_file) if File.exists?(spec_file)
+    FileUtils.rm(spec_file) if File.exist?(spec_file)
   end
 
   let(:generator_opts) do
-    {:manifest_file => sample_file, :template_dir => retrospec_templates_path}
+    { :manifest_file => sample_file, :template_dir => retrospec_templates_path }
   end
 
   let(:sample_file) do
-    File.join(module_path, 'manifests','node_file.pp')
+    File.join(module_path, 'manifests', 'node_file.pp')
   end
 
   let(:spec_files_path) do
@@ -36,7 +35,7 @@ describe Retrospec::Puppet::Generators::NodeGenerator do
 
   xit 'should create spec file' do
     expect(generator.run).to eq(spec_file)
-    expect(File.exists?(spec_file)).to eq(true)
+    expect(File.exist?(spec_file)).to eq(true)
   end
 
   xit 'should produce correct file name' do
@@ -48,7 +47,6 @@ describe Retrospec::Puppet::Generators::NodeGenerator do
     expect(spec_file_contents).to eq(data)
   end
 
-
   describe 'spec files' do
     let(:generated_files) do
       [File.join(spec_files_path, 'site_spec.rb')]
@@ -58,5 +56,4 @@ describe Retrospec::Puppet::Generators::NodeGenerator do
       expect(files).to eq(generated_files)
     end
   end
-
 end

data/spec/unit/generators/parsers/fact_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
-describe "facter" do
+describe 'facter' do
   let(:model) do
     Retrospec::Puppet::Generators::Facter.load_fact(file)
   end
 
   describe 'node_role' do
     let(:file) do
-      File.join(fixtures_facts_path , 'node_role.rb')
+      File.join(fixtures_facts_path, 'node_role.rb')
     end
     it 'can eval code' do
       fact_name = model.facts.keys.first
@@ -16,16 +16,15 @@ describe "facter" do
       confines = fact_data.confines
       model_facts = model.facts[fact_name].used_facts
       global_used_facts = model.global_used_facts
-      expect(confines).to eq({:kernel=>"Windows", :is_virtual=>true})
+      expect(confines).to eq(:kernel => 'Windows', :is_virtual => true)
       expect(model_facts).to eq({})
       expect(global_used_facts).to eq({})
     end
   end
 
-
   describe 'multiple facts' do
     let(:file) do
-      File.join(fixtures_facts_path , 'datacenter_facts.rb')
+      File.join(fixtures_facts_path, 'datacenter_facts.rb')
     end
 
     it 'can eval code with multiple facts' do
@@ -35,7 +34,7 @@ describe "facter" do
       confines = fact_data.confines
       model_facts = fact_data.used_facts
       expect(fact_name).to eq(:fact1)
-      expect(confines).to eq({:kernel=>"Linux"})
+      expect(confines).to eq(:kernel => 'Linux')
       expect(model_facts).to eq({})
       expect(global_used_facts).to eq({})
       fact_name = model.facts.keys.last
@@ -43,7 +42,7 @@ describe "facter" do
       confines = fact_data.confines
       model_facts = fact_data.used_facts
       expect(fact_name).to eq(:fact2)
-      expect(confines).to eq({:kernel=>"Windows"})
+      expect(confines).to eq(:kernel => 'Windows')
       expect(model_facts).to eq({})
       expect(global_used_facts).to eq({})
     end
@@ -51,12 +50,10 @@ describe "facter" do
 
   describe 'fact value' do
     let(:file) do
-      File.join(fixtures_facts_path , 'facts_with_methods.rb')
+      File.join(fixtures_facts_path, 'facts_with_methods.rb')
     end
     it 'can be processed' do
       expect(model).to_not eq(nil)
     end
-
   end
-
 end

data/spec/unit/generators/parsers/provider_spec.rb

@@ -19,7 +19,7 @@ describe 'provider' do
 
   it 'contains class methods' do
     expect(models.class_methods).to match_array([:ipmitoolcmd, :instances, :prefetch, :laninfo,
-                                        :convert_vlanid, :convert_ip_source])
+                                                 :convert_vlanid, :convert_ip_source])
   end
 
   it 'contains a file' do
@@ -28,10 +28,10 @@ describe 'provider' do
 
   it 'contains instance methods' do
     expect(models.instance_methods).to match_array([:ipmitoolcmd, :ensure, :ensure=, :ipsource,
-                                           :ipsource=, :ip, :ip=, :netmask, :netmask=,
-                                           :gateway, :gateway=, :vlanid, :vlanid=,
-                                           :provider, :provider=, :flush, :install,
-                                           :remove, :exists?])
+                                                    :ipsource=, :ip, :ip=, :netmask, :netmask=,
+                                                    :gateway, :gateway=, :vlanid, :vlanid=,
+                                                    :provider, :provider=, :flush, :install,
+                                                    :remove, :exists?])
   end
 
   it 'contains properties' do

data/spec/unit/generators/parsers/type_spec.rb

@@ -75,19 +75,18 @@ describe 'type' do
 
     it 'has correct amount of parameters' do
       expect(models.parameters).to eq([:name,
-                                        :patch_id,
-                                        :os_user,
-                                        :oracle_product_home_dir,
-                                        :orainst_dir,
-                                        :extracted_patch_dir,
-                                        :ocmrf_file,
-                                        :opatch_auto,
-                                        :bundle_sub_patch_id])
+                                       :patch_id,
+                                       :os_user,
+                                       :oracle_product_home_dir,
+                                       :orainst_dir,
+                                       :extracted_patch_dir,
+                                       :ocmrf_file,
+                                       :opatch_auto,
+                                       :bundle_sub_patch_id])
     end
 
     it 'has the correct number of instance methods' do
       expect(models.instance_methods).to eq([])
     end
-
   end
 end

data/spec/unit/generators/provider_generator_spec.rb

@@ -90,7 +90,6 @@ describe 'provider_generator' do
     it 'return path of core type' do
       expect(generator.type_file('package')).to eq('puppet/type/package.rb')
     end
-
   end
   describe 'cli' do
     it 'can run the cli options' do
@@ -111,7 +110,7 @@ describe 'provider_generator' do
 
       it 'can generate a spec file' do
         generator.generate_provider_files
-        files = [File.join(provider_spec_dir, "#{type_name}", "#{provider_name}_spec.rb")]
+        files = [File.join(provider_spec_dir, type_name.to_s, "#{provider_name}_spec.rb")]
         expect(generator.generate_provider_spec_files).to eq(files)
       end
 

data/spec/unit/generators/report_generator_spec.rb

@@ -1,14 +1,13 @@
 require 'spec_helper'
 
 describe 'report_generator' do
-
   after(:each) do
-    FileUtils.rm(report_file) if File.exists?(report_file)
-    FileUtils.rm(report_spec_file) if File.exists?(report_spec_file)
+    FileUtils.rm(report_file) if File.exist?(report_file)
+    FileUtils.rm(report_spec_file) if File.exist?(report_spec_file)
   end
 
   let(:generator_opts) do
-    {:name => 'test',  :template_dir => retrospec_templates_path}
+    { :name => 'test', :template_dir => retrospec_templates_path }
   end
 
   let(:module_path) do
@@ -30,9 +29,9 @@ describe 'report_generator' do
   it 'should create files without error' do
     files = generator.run
     expect(files.include?(report_file)).to eq(true)
-    expect(File.exists?(report_file)).to eq(true)
+    expect(File.exist?(report_file)).to eq(true)
     expect(files.include?(report_spec_file)).to eq(true)
-    expect(File.exists?(report_spec_file)).to eq(true)
+    expect(File.exist?(report_spec_file)).to eq(true)
   end
 
   it 'should produce correct file name' do
@@ -42,5 +41,4 @@ describe 'report_generator' do
   it 'should produce correct spec file path' do
     expect(generator.item_spec_path).to eq(report_spec_file)
   end
-
 end

data/spec/unit/generators/resource_base_generator_spec.rb

@@ -1,17 +1,16 @@
 require 'spec_helper'
 
 describe Retrospec::Puppet::Generators::ResourceBaseGenerator do
-
   after(:each) do
-    FileUtils.rm_rf(spec_files_path) if File.exists?(spec_files_path)
+    FileUtils.rm_rf(spec_files_path) if File.exist?(spec_files_path)
   end
 
   let(:generator_opts) do
-    {:manifest_file => sample_file, :template_dir => retrospec_templates_path}
+    { :manifest_file => sample_file, :template_dir => retrospec_templates_path }
   end
 
   let(:sample_file) do
-    File.join(module_path, 'manifests','one_define.pp')
+    File.join(module_path, 'manifests', 'one_define.pp')
   end
 
   let(:spec_files_path) do
@@ -38,5 +37,4 @@ describe Retrospec::Puppet::Generators::ResourceBaseGenerator do
     files = Retrospec::Puppet::Generators::ResourceBaseGenerator.generate_spec_files(module_path, generator_opts)
     expect(files).to match_array(generated_files)
   end
-
 end

data/spec/unit/generators/schema_generator_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe 'schema_generator' do
-
   before(:each) do
-    FileUtils.rm(schema_file) if File.exists?(schema_file)
+    FileUtils.rm(schema_file) if File.exist?(schema_file)
   end
 
   let(:generator_opts) do
-    {:name => 'test', :puppet_context => puppet_context,  :template_dir => template_dir}
+    { :name => 'test', :puppet_context => puppet_context, :template_dir => template_dir }
   end
 
   let(:module_path) do
@@ -25,7 +24,7 @@ describe 'schema_generator' do
   let(:puppet_context) do
     path = File.join(fixture_modules_path, 'tomcat')
     opts = { :module_path => path, :enable_beaker_tests => false, :name => 'name-test123',
-      :enable_user_templates => false,  :template_dir => template_dir }
+             :enable_user_templates => false, :template_dir => template_dir }
     mod = Retrospec::Plugins::V1::Puppet.new(opts[:module_path], opts)
     mod.post_init
     mod.context
@@ -37,48 +36,46 @@ describe 'schema_generator' do
 
   let(:hostclass_items) do
     {
-      "tomcat::catalina_home"=>{"type"=>"any", "required"=>false},
-      "tomcat::user"=>{"type"=>"any", "required"=>false},
-      "tomcat::group"=>{"type"=>"any", "required"=>false},
-      "tomcat::install_from_source"=>{"type"=>"bool", "required"=>false},
-      "tomcat::purge_connectors"=>{"type"=>"bool", "required"=>false},
-      "tomcat::purge_realms"=>{"type"=>"bool", "required"=>false},
-      "tomcat::manage_user"=>{"type"=>"bool", "required"=>false},
-      "tomcat::manage_group"=>{"type"=>"bool", "required"=>false}
+      'tomcat::catalina_home' => { 'type' => 'any', 'required' => false },
+      'tomcat::user' => { 'type' => 'any', 'required' => false },
+      'tomcat::group' => { 'type' => 'any', 'required' => false },
+      'tomcat::install_from_source' => { 'type' => 'bool', 'required' => false },
+      'tomcat::purge_connectors' => { 'type' => 'bool', 'required' => false },
+      'tomcat::purge_realms' => { 'type' => 'bool', 'required' => false },
+      'tomcat::manage_user' => { 'type' => 'bool', 'required' => false },
+      'tomcat::manage_group' => { 'type' => 'bool', 'required' => false }
     }
   end
   let(:schema_map) do
-    {"type"=>"map",
-     "mapping"=>
+    { 'type' => 'map',
+      'mapping' =>
        {
-        "definition" => {
-          "tomcat::war::catalina_base"=>{"type"=>"any", "required"=>false},
-          "tomcat::war::app_base"=>{"type"=>"any", "required"=>false},
-          "tomcat::war::deployment_path"=>{"type"=>"any", "required"=>false},
-          "tomcat::war::war_ensure"=>{"type"=>"str", "required"=>false},
-          "tomcat::war::war_name"=>{"type"=>"any", "required"=>false},
-          "tomcat::war::war_purge"=>{"type"=>"bool", "required"=>false},
-          "tomcat::war::war_source"=>{"type"=>"any", "required"=>false}
-        }
-       }
-    }
+         'definition' => {
+           'tomcat::war::catalina_base' => { 'type' => 'any', 'required' => false },
+           'tomcat::war::app_base' => { 'type' => 'any', 'required' => false },
+           'tomcat::war::deployment_path' => { 'type' => 'any', 'required' => false },
+           'tomcat::war::war_ensure' => { 'type' => 'str', 'required' => false },
+           'tomcat::war::war_name' => { 'type' => 'any', 'required' => false },
+           'tomcat::war::war_purge' => { 'type' => 'bool', 'required' => false },
+           'tomcat::war::war_source' => { 'type' => 'any', 'required' => false }
+         }
+       } }
   end
 
   it 'should create files without error' do
     expect(generator.generate_schema_file).to eq(schema_file)
-    expect(File.exists?(schema_file)).to eq(true)
+    expect(File.exist?(schema_file)).to eq(true)
   end
 
   it 'should contain proper mapping' do
     schema_file = generator.generate_schema_file
     sch = YAML.load_file(schema_file)
-    expect(sch.keys).to eq(["type", "mapping"])
-    expect(sch['mapping'].keys).to eq(["hostclass", "definition"])
-    expect(sch['mapping']['hostclass'].keys).to eq(["type", "mapping"])
-    expect(sch['mapping']['definition'].keys).to eq(["type", "mapping"])
+    expect(sch.keys).to eq(%w(type mapping))
+    expect(sch['mapping'].keys).to eq(%w(hostclass definition))
+    expect(sch['mapping']['hostclass'].keys).to eq(%w(type mapping))
+    expect(sch['mapping']['definition'].keys).to eq(%w(type mapping))
     expect(sch['mapping']['hostclass']['mapping']).to eq(hostclass_items)
     expect(sch['mapping']['definition']['mapping'].keys.count).to eq(125)
-
   end
 
   it 'should produce correct file name' do
@@ -118,5 +115,4 @@ describe 'schema_generator' do
   # it 'should detect when a parameter is required' do
   #   expect(generator.create_map_content).to eq(schema_map)
   # end
-
 end

data/spec/unit/generators/serializers/rspec_dumper_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 require 'retrospec/plugins/v1/plugin/generators/serializers/rspec_dumper'
 
 describe 'rspec_serializer' do
-
   let(:sample_file) do
     File.join(fixtures_path, 'manifests', 'sql.pp')
   end
@@ -30,25 +29,25 @@ describe 'rspec_serializer' do
 
   let(:store) do
     {
-      "$backup_root_dir" => {:value=>"c:\\backup", :type=>:parameter},
-       "$features_location" => {:value=>:undef, :type=>:parameter},
-       "$install_account_passwords" => {:value=>{}, :type=>:parameter},
-       "$install_accounts" => {:value=>{}, :type=>:parameter},
-       "$install_options" => {:value=>{}, :type=>:parameter},
-       "$install_type" => {:value=>"default", :type=>:parameter},
-       "$instance_name" => {:value=>"MSSQLSERVER", :type=>:parameter},
-       "$source" => {:value=>:undef, :type=>:parameter},
-       "$sql::backup_root_dir" => {:value=>"c:\\backup", :type=>:parameter},
-       "$sql::features_location" => {:value=>:undef, :type=>:parameter},
-       "$sql::install_account_passwords" => {:value=>{}, :type=>:parameter},
-       "$sql::install_accounts" => {:value=>{}, :type=>:parameter},
-       "$sql::install_options" => {:value=>{}, :type=>:parameter},
-       "$sql::install_type" => {:value=>"default", :type=>:parameter},
-       "$sql::instance_name" => {:value=>"MSSQLSERVER", :type=>:parameter},
-       "$sql::source" => {:value=>:undef, :type=>:parameter},
-       "$sql::ssdt_install_options" => {:value=>{}, :type=>:parameter},
-       "$ssdt_install_options" => {:value=>{}, :type=>:parameter},
-       "$value" => {:value=>"$value", :type=>:class_scope}
+      '$backup_root_dir' => { :value => 'c:\\backup', :type => :parameter },
+      '$features_location' => { :value => :undef, :type => :parameter },
+      '$install_account_passwords' => { :value => {}, :type => :parameter },
+      '$install_accounts' => { :value => {}, :type => :parameter },
+      '$install_options' => { :value => {}, :type => :parameter },
+      '$install_type' => { :value => 'default', :type => :parameter },
+      '$instance_name' => { :value => 'MSSQLSERVER', :type => :parameter },
+      '$source' => { :value => :undef, :type => :parameter },
+      '$sql::backup_root_dir' => { :value => 'c:\\backup', :type => :parameter },
+      '$sql::features_location' => { :value => :undef, :type => :parameter },
+      '$sql::install_account_passwords' => { :value => {}, :type => :parameter },
+      '$sql::install_accounts' => { :value => {}, :type => :parameter },
+      '$sql::install_options' => { :value => {}, :type => :parameter },
+      '$sql::install_type' => { :value => 'default', :type => :parameter },
+      '$sql::instance_name' => { :value => 'MSSQLSERVER', :type => :parameter },
+      '$sql::source' => { :value => :undef, :type => :parameter },
+      '$sql::ssdt_install_options' => { :value => {}, :type => :parameter },
+      '$ssdt_install_options' => { :value => {}, :type => :parameter },
+      '$value' => { :value => '$value', :type => :class_scope }
     }
   end
   let(:hostclass_body) do
@@ -68,7 +67,7 @@ describe 'rspec_serializer' do
   end
 
   let(:case_exp) do
-    hostclass_body.statements.find {|s| s.class == Puppet::Pops::Model::CaseExpression}
+    hostclass_body.statements.find { |s| s.class == Puppet::Pops::Model::CaseExpression }
   end
 
   let(:case_opt) do
@@ -76,7 +75,7 @@ describe 'rspec_serializer' do
   end
 
   let(:resource_exp) do
-     relationship_exp.eContents.last
+    relationship_exp.eContents.last
   end
 
   let(:relationship_exp) do
@@ -151,18 +150,18 @@ describe 'rspec_serializer' do
 
     #
     # not supported
-#     it 'case option' do
-#       # test = serializer.dump(case_exp.test)
-#       # ls, exp = case_exp.options.first.eContents
-#       # case_exp.options.first.eContents
-#       # options = case_exp.options
-# #      data = "context 'custom' do\n  context blah do\n    it { is_expected.to call(fail).with('Install type: default specified but no install options given')} \n  end\nend"
-#       require 'pry'
-#       binding.pry
-#       data = ''
-#       expect(serializer.dump(case_opt)).to match(/context\ 'custom'\ do\n/)
-#       expect(serializer.dump(case_opt)).to eq(data)
-#     end
+    #     it 'case option' do
+    #       # test = serializer.dump(case_exp.test)
+    #       # ls, exp = case_exp.options.first.eContents
+    #       # case_exp.options.first.eContents
+    #       # options = case_exp.options
+    # #      data = "context 'custom' do\n  context blah do\n    it { is_expected.to call(fail).with('Install type: default specified but no install options given')} \n  end\nend"
+    #       require 'pry'
+    #       binding.pry
+    #       data = ''
+    #       expect(serializer.dump(case_opt)).to match(/context\ 'custom'\ do\n/)
+    #       expect(serializer.dump(case_opt)).to eq(data)
+    #     end
 
     # it 'if_expr' do
     #   if_expr = case_opt.then_expr.statements.first
@@ -239,7 +238,7 @@ describe 'rspec_serializer' do
 
     it 'values should not contain a $' do
       expect(serializer.add_var_to_store('class_a::master_type', 'value1')).to eq('value1')
-      serializer.var_store.each do |key, value|
+      serializer.var_store.each do |_key, value|
         expect(value).to_not match(/^\$'.*/)
       end
     end
@@ -260,7 +259,7 @@ describe 'rspec_serializer' do
 
       it 'values should not contain a $' do
         expect(serializer.add_var_to_store('$master_type', 'value1')).to eq('value1')
-        serializer.var_store.each do |key, value|
+        serializer.var_store.each do |_key, value|
           expect(value).to_not match(/^\$'.*/)
         end
       end
@@ -274,7 +273,6 @@ describe 'rspec_serializer' do
         expect(serializer.add_var_to_store('$class_a::master_type', 'value1')).to eq('value1')
         expect(serializer.lookup_var('$class_a::master_type')).to eq('value1')
         expect(serializer.lookup_var('$master_type')).to eq('value1')
-
       end
 
       it 'should not add a variable when it already exists' do
@@ -292,7 +290,6 @@ describe 'rspec_serializer' do
       expect(serializer.add_var_to_store('$class_a::master_type', 'value1')).to eq('value1')
       expect(serializer.lookup_var('$class_a::master_type')).to eq('value1')
       expect(serializer.lookup_var('$master_type')).to eq('value1')
-
     end
 
     it 'should not add a variable when it already exists' do