puppet-retrospec 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3461b3345064309ba4d62c62b0393ed4f4223ba6
-  data.tar.gz: 57deba94c2c1d0e62c85263bbedf9771f4b5f213
+  metadata.gz: cbc49b480678daffff061e656b863bd070e751aa
+  data.tar.gz: 664b47744df42f5fa4df4121ac631a443c578818
 SHA512:
-  metadata.gz: 81efc82dbb22d30e873dbb1e9a1ddf4fc10b065f31174cfce7a4959876019a0e6e183ce2eed64e2e54264e82834bea2e85c695075195ce1f83326ed3cc73694d
-  data.tar.gz: c1e46dea03222cfd8a7ee237bbde5e54937dc6223cfcacaeeb3b2b863b4fa4e9e023634de458ad91125ae55dbd43b6d07aaf615dd3b62c9e660b036f4f96c068
+  metadata.gz: 3c933d5fb7ee82ea64ab460dfe40f4b6e8a79d690785ece5422109323aedf9998112f27f0d0b949a89e2dfae0edf7b28314ef5c0f6b43442a2c1dfb112575b31
+  data.tar.gz: 8df5426ac543a838444891ca1a4cbca589d9dc228344e589975da6fab5d16eaee44674f8489e02d1325cf9b9f66938a79fdebad7013c2725b6028681bc1f06a1

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.10.0
+ * refactor cli options to use retrospec 0.4.0 specifications
+ * gh-32 - add ability to create new module
+ * fix pinning of module to use 0.x.0 instead of 0.x
+ * pin to version 0.4.x
 ## 0.9.0
  * convert to retrospec plugin
  This is a big change in how you run puppet-retrospec please see the readme for changes.

data/Gemfile

@@ -1,25 +1,15 @@
 source "http://rubygems.org"
 
-# while retrospec does not use facter or hiera,
-# we vendor the puppet gem 3.7.3 which also requires facter and hiera
-#gem 'facter', '< 3', '> 1.6'
-#gem 'hiera', '~> 1.0'
-
 gem 'trollop'
-gem 'retrospec', "~> 0.3"
+gem 'retrospec', "~> 0.4.0"
 # Include everything needed to run rake, tests, features, etc.
 group :development do
   gem "rspec", "~> 3.2"
   gem 'puppet', '3.7.3',  :path => 'vendor/gems/puppet-3.7.3'
-  #gem 'facter', '< 3', '> 1.6'
-  #gem 'hiera', '~> 1.0'
   gem "yard", "~> 0.7"
   gem "rdoc", "~> 3.12"
   gem "bundler", "~> 1.0"
   gem "jeweler"
   gem 'pry'
   gem "fakefs", :require => "fakefs/safe"
-  gem 'pry-rescue'
-  gem 'pry-stack_explorer'
-  gem 'pry-coolline'
 end

data/Gemfile.lock

@@ -11,13 +11,8 @@ GEM
   specs:
     CFPropertyList (2.2.8)
     addressable (2.3.8)
-    binding_of_caller (0.7.2)
-      debug_inspector (>= 0.0.1)
     builder (3.2.2)
     coderay (1.1.0)
-    coolline (0.5.0)
-      unicode_utils (~> 1.4)
-    debug_inspector (0.0.2)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
@@ -39,7 +34,6 @@ GEM
     hiera (1.3.4)
       json_pure
     highline (1.7.7)
-    interception (0.5)
     jeweler (2.0.1)
       builder
       bundler (>= 1.0)
@@ -69,19 +63,11 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    pry-coolline (0.2.5)
-      coolline (~> 0.5)
-    pry-rescue (1.4.2)
-      interception (>= 0.5)
-      pry
-    pry-stack_explorer (0.4.9.2)
-      binding_of_caller (>= 0.7)
-      pry (>= 0.9.11)
     rack (1.6.4)
     rake (10.4.2)
     rdoc (3.12.2)
       json (~> 1.4)
-    retrospec (0.3.0)
+    retrospec (0.4.0)
       trollop
     rspec (3.3.0)
       rspec-core (~> 3.3.0)
@@ -99,7 +85,6 @@ GEM
     slop (3.6.0)
     thread_safe (0.3.5)
     trollop (2.1.2)
-    unicode_utils (1.4.0)
     yard (0.8.7.6)
 
 PLATFORMS
@@ -110,12 +95,9 @@ DEPENDENCIES
   fakefs
   jeweler
   pry
-  pry-coolline
-  pry-rescue
-  pry-stack_explorer
   puppet (= 3.7.3)!
   rdoc (~> 3.12)
-  retrospec (~> 0.3)
+  retrospec (~> 0.4.0)
   rspec (~> 3.2)
   trollop
   yard (~> 0.7)

data/README.md

@@ -68,34 +68,80 @@ Installing ri documentation for puppet-retrospec-0.9.0
 
 ```
 
-Dependency
-============
+## Dependency
 Retrospec relies heavily on the puppet 3.7.x codebase.  Because of this hard dependency the puppet gem is vendored into
 the library so there should not be conflicts with your existing puppet gem.
   
-Install
-=============
+## Install
 `gem install puppet-retrospec`  
 
 This will also install the retrospec framework that is required to use the plugin.
 
-How to use
-=============
-Run from the command line
+## How to use
+
+Run from the command line: `retrospec puppet`
+
+If you need to point to a directory outside the current directory you can use the `--module_path` option.
 ```
-retrospec puppet -h
+[puppet@puppetdev ~]$ retrospec -m /tmp/test3323 puppet -h
 Generates puppet rspec test code based on the classes and defines inside the manifests directory.
-  -t, --template-dir=<s>        Path to templates directory (only for overriding Retrospec templates) (default: /home/puppet/.retrospec/repos/retrospec-puppet-templates)
-  -s, --scm-url=<s>             SCM url for retrospec templates (default: https://github.com/nwops/retrospec-templates)
+
+Subcommands:
+new_module
+  -t, --template-dir=<s>        Path to templates directory (only for overriding Retrospec templates)
+                                (default: /Users/cosman/.retrospec/repos/retrospec-puppet-templates)
+  -s, --scm-url=<s>             SCM url for retrospec templates (default:
+                                https://github.com/nwops/retrospec-templates)
+  -n, --name=<s>                The name of the module you wish to create (default: test3323)
   -b, --branch=<s>              Branch you want to use for the retrospec template repo (default: master)
+  -a, --namespace=<s>           The namespace to use only when creating a new module (default: namespace)
   -e, --enable-beaker-tests     Enable the creation of beaker tests
-  -n, --enable-future-parser    Enables the future parser only during validation
+  -l, --enable-future-parser    Enables the future parser only during validation
   -v, --version                 Print version and exit
-  -h, --help                    Show this message
+  -h, --help                    Show this message  -h, --help                    Show this message
+```
 
 
+### Enabling the future parser
                      
-retrospec -m ~/projects/puppet_modules/apache puppet --enable-future-parser
+`retrospec -m ~/projects/puppet_modules/apache puppet --enable-future-parser`
+
+### Creating a new module
+
+Creating a new module can now be done with retrospec as of 0.10.0. To do so you just need to use the sub command
+`new_module`.  See `retrospec puppet -h` for more options and overridable configurations.
+
+
+```
+retrospec -m /tmp/new_module puppet new_module --namespace lmc --name apache2
+Successfully ran hook: /Users/cosman/.retrospec/repos/retrospec-puppet-templates/clone-hook
+Already up-to-date.
+
+The module located at: /tmp/new_module does not exist, do you wish to create it? (y/n): y
+ + /tmp/new_module/manifests/
+ + /tmp/new_module/manifests/init.pp
+Successfully ran hook: /Users/cosman/.retrospec/repos/retrospec-puppet-templates/pre-hook
+
+ + /tmp/new_module/.bundle/
+ + /tmp/new_module/.bundle/config
+ + /tmp/new_module/.fixtures.yml
+ + /tmp/new_module/.git/
+ + /tmp/new_module/.git/hooks/
+ + /tmp/new_module/.git/hooks/pre-commit
+ + /tmp/new_module/.gitignore
+ + /tmp/new_module/.puppet-lint.rc
+ + /tmp/new_module/.travis.yml
+ + /tmp/new_module/Gemfile
+ + /tmp/new_module/README.markdown
+ + /tmp/new_module/Rakefile
+ + /tmp/new_module/Vagrantfile
+ + /tmp/new_module/spec/
+ + /tmp/new_module/spec/acceptance/
+ + /tmp/new_module/spec/shared_contexts.rb
+ + /tmp/new_module/spec/spec_helper.rb
+ + /tmp/new_module/metadata.json
+ + /tmp/new_module/spec/classes/
+ + /tmp/new_module/spec/classes/apache2_spec.rb
 
 ```
 
@@ -111,15 +157,16 @@ plugins::puppet::templates::ref: master
 plugins::puppet::enable_beaker_tests: true
 plugins::puppet::enable_future_parser: true
 plugins::puppet::template_dir: /Users/username/.retrospec/repos/retrospec-puppet-templates
+plugins::puppet::namespace: organization
+plugins::puppet::author: your_name
 ```
-
-Note: your not require to set any of these as they can be specified on the cli and also default to 
+Note: your not required to set any of these as they can be specified on the cli and also default to 
 sane values.
 
 Example
 ======================
 
-Below you can see that it creates files for every resource in the tomcat module in addition to other files
+Below you can see that it creates files for every resource in the apache module in addition to other files
 that you need for unit testing puppet code. Rspec-puppet best practices says to put definitions in a defines folder
 and classes in a classes folder since it infers what kind of resource it is based on this convention.  Retrospec sets up
 this scaffolding for you.  Don't like the files that came with your module?  Simply delete the files and re-generate them
@@ -413,9 +460,9 @@ Lets say I have three clients that each need site specific files in the module a
 don't give me everything I want.  Thus I will need to override the templates for each client.
 
 ```shell
-    retrospec --template-dir ~/retrspec_client1
-    retrospec --template-dir ~/retrspec_client2
-    retrospec --template-dir ~/retrspec_client3
+    retrospec puppet --template-dir ~/retrspec_client1
+    retrospec puppet --template-dir ~/retrspec_client2
+    retrospec puppet --template-dir ~/retrspec_client3
     touch ~/retrspec_client1/module_files/special_file_for_client1.yml
     touch ~/retrspec_client2/module_files/special_file_for_client2.yml
     touch ~/retrspec_client3/module_files/special_file_for_client3.yml
@@ -568,7 +615,7 @@ parser cannot read future code syntax.  If your puppet 4 codebase is compatible
 In order to allow future parser validation please run retrospec with the following option.
 
  ```shell
-    retrospec --enable-future-parser
+    retrospec puppet --enable-future-parser
 
  ```
 

data/VERSION

@@ -1 +1 @@
-0.9.1
+0.10.0

data/lib/retrospec/plugins/v1/plugin/puppet.rb

@@ -1,5 +1,6 @@
 require 'retrospec/plugins/v1/module_helpers'
 require 'retrospec/plugins/v1'
+require 'retrospec/config'
 require_relative 'spec_object'
 require 'erb'
 require_relative 'template_helpers'
@@ -26,36 +27,98 @@ module Retrospec
           Utilities::PuppetModule.instance.future_parser = config_data[:enable_future_parser]
           # user supplied a template path or user wants to use local templates
           @template_dir = setup_user_template_dir(config_data[:template_dir], config_data[:scm_url], config_data[:ref])
+        end
+
+        def post_init
+          # before we validate the module directory we should ensure the module exists by creating it
           # validation also occurs when setting the module path
           Utilities::PuppetModule.instance.module_path = module_path
           Utilities::PuppetModule.create_tmp_module_path # this is required to finish initialization
+          # setting the context is require to make other methods below work.  #TODO lazy create the context
           @context = ::Puppet::SpecObject.new(module_path, Utilities::PuppetModule.instance, config_data)
         end
 
-        # used to display subcommand options to the cli
+        # if the module does not exist lets create it
+        # this will create the module directory, manifests directory and basic init.pp file
+        # if the manifest directory already exist but an init.pp file does not we do not creating
+        # anything since it is not mandatory
+        # I thought about using the the module face to perform this generation but it seems like its not
+        # supported at this time, and you can't specify the path to generate the module in
+        def new_module
+          unless File.exist?(manifest_dir)
+            init_class = File.join(manifest_dir, 'init.pp')
+            content = File.read(File.join(template_dir, 'manifest_file.pp'))
+            print "The module located at: #{module_path} does not exist, do you wish to create it? (y/n): "
+            answer = gets.chomp
+            unless answer =~ /y/i
+              exit 1
+            end
+            create_manifest_file(init_class, content)
+          end
+        end
+
+        # used to display subcommand options to tglobal_confighe cli
         # the global options are passed in for your usage
         # http://trollop.rubyforge.org
         # all options here are available in the config passed into the initialize code
-        def self.cli_options(global_opts)
-          template_dir = global_opts['plugins::puppet::template_dir'] || File.expand_path('~/.retrospec/repos/retrospec-puppet-templates')
-          scm_url = ENV['RETROSPEC_PUPPET_SCM_URL'] || global_opts['plugins::puppet::templates::url']
-          scm_branch = ENV['RETROSPEC_PUPPET_SCM_BRANCH'] || global_opts['plugins::puppet::templates::ref'] || 'master'
-          future_parser = global_opts['plugins::puppet::enable_future_parser']
-          beaker_tests  = global_opts['plugins::puppet::enable_beaker_tests']
-          Trollop::options do
+        # this is the only entry point into the plugin
+        def self.run_cli(global_opts, global_config, plugin_config, args=ARGV)
+          template_dir = plugin_config['plugins::puppet::template_dir'] || File.expand_path('~/.retrospec/repos/retrospec-puppet-templates')
+          scm_url = ENV['RETROSPEC_PUPPET_SCM_URL'] || plugin_config['plugins::puppet::templates::url']
+          scm_branch = ENV['RETROSPEC_PUPPET_SCM_BRANCH'] || plugin_config['plugins::puppet::templates::ref'] || 'master'
+          future_parser = plugin_config['plugins::puppet::enable_future_parser'] || false
+          beaker_tests  = plugin_config['plugins::puppet::enable_beaker_tests'] || false
+          namespace     = plugin_config['plugins::puppet::namespace'] || 'namespace'
+          # a list of subcommands for this plugin
+          sub_commands  = [:new_module]
+          if sub_commands.count > 0
+            sub_command_help = "Subcommands:\n#{sub_commands.join("\n")}\n"
+          else
+            sub_command_help = ""
+          end
+          plugin_opts = Trollop::options do
             version "#{Retrospec::Puppet::VERSION} (c) Corey Osman"
             banner <<-EOS
-Generates puppet rspec test code based on the classes and defines inside the manifests directory.
+Generates puppet rspec test code based on the classes and defines inside the manifests directory.\n
+#{sub_command_help}
 
             EOS
             opt :template_dir, "Path to templates directory (only for overriding Retrospec templates)", :type => :string,
                 :required => false, :default => template_dir
             opt :scm_url, "SCM url for retrospec templates", :type => :string, :required => false,
                 :default => scm_url
+            opt :name, "The name of the module you wish to create", :type => :string, :require => :false, :short => '-n',
+                :default => File.basename(global_opts[:module_path])
             opt :branch, "Branch you want to use for the retrospec template repo", :type => :string, :required => false,
                 :default => scm_branch
+            opt :namespace, "The namespace to use only when creating a new module", :default => namespace, :required => false,
+                :type => :string
             opt :enable_beaker_tests, "Enable the creation of beaker tests", :require => false, :type => :boolean, :default => beaker_tests
             opt :enable_future_parser, "Enables the future parser only during validation", :default => future_parser, :require => false, :type => :boolean
+            stop_on sub_commands
+          end
+          # the passed in options will always override the config file
+          plugin_data = plugin_opts.merge(global_config).merge(global_opts).merge(plugin_opts)
+          # define the default action to use the plugin here, the default is run
+          sub_command = (args.shift || :run).to_sym
+          # create an instance of this plugin
+          plugin = self.new(plugin_data[:module_path],plugin_data)
+          # check if the plugin supports the sub command
+          if plugin.respond_to?(sub_command)
+            case sub_command
+              when :new_module
+                plugin.send(sub_command)
+                plugin.post_init   # finish initialization
+              when :run
+                plugin.post_init   # finish initialization
+              else
+                plugin.post_init   # finish initialization
+                plugin.send(sub_command)
+            end
+            plugin.send(:run)
+          else
+            puts "The subcommand #{sub_command} is not supported or valid"
+            exit 1
           end
         end
 
@@ -105,6 +168,7 @@ Generates puppet rspec test code based on the classes and defines inside the man
         def create_files
           types = context.types
           safe_create_module_files
+          generate_metadata_file
           # a Type is nothing more than a defined type or puppet class
           # we could have named this manifest but there could be multiple types
           # in a manifest.
@@ -239,17 +303,41 @@ Generates puppet rspec test code based on the classes and defines inside the man
           '.pp'
         end
 
-        # # validates module directory fits the description of this plugin
-        # def self.validate_type(dir)
-        #   if ! File.exist?(manifest_dir)
-        #     message = "No manifest directory in #{manifest_dir}, cannot validate this is a module".fatal
-        #     raise TypeValidationException message
-        #   else
-        #     manifest_files ||= Dir.glob("#{manifest_dir}/**/*.pp")
-        #     warn "No puppet manifest files found at #{manifest_dir}".warning if manifest_files.length < 1
-        #   end
-        #   true
-        # end
+        def create_manifest_file(dest, content)
+          # replace the name in the target file with the module_name from this class
+          # I would have just used a template but the context does not exist yet
+          new_content = content.gsub('CLASS_NAME', config_data[:name])
+          safe_create_file(dest, new_content)
+        end
+
+        # generates the metadata file in the module directory
+        def generate_metadata_file
+          require 'puppet/module_tool/metadata'
+          # make sure the metadata file exists
+          metadata_file = File.join(module_path, 'metadata.json')
+          unless File.exists?(metadata_file)
+            # by default the module tool metadata checks for a namespece
+            if ! config_data[:name].include?('-')
+              name = "#{config_data[:namespace]}-#{config_data[:name]}"
+            else
+              name = config_data[:name]
+            end
+            begin
+              metadata = ::Puppet::ModuleTool::Metadata.new.update(
+                  'name' => name,
+                  'version' => '0.1.0',
+                  'author'  => (config_data['plugins::puppet::author'] || nil ),
+                  'dependencies' => [
+                      { 'name' => 'puppetlabs-stdlib', 'version_requirement' => '>= 1.0.0' }
+                  ]
+              )
+            rescue ArgumentError => e
+              puts e.message
+              exit -1
+            end
+            safe_create_file(metadata_file, metadata.to_json)
+          end
+        end
       end
     end
   end

data/lib/retrospec/plugins/v1/plugin/version.rb

@@ -1,5 +1,5 @@
 module Retrospec
   module Puppet
-    VERSION = '0.9.1'
+    VERSION = '0.10.0'
   end
 end

data/puppet-retrospec.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "puppet-retrospec"
-  s.version = "0.9.1"
+  s.version = "0.10.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Corey Osman"]
-  s.date = "2015-09-28"
+  s.date = "2015-10-12"
   s.description = "Retrofits and generates valid puppet rspec test code to existing modules"
   s.email = "corey@logicminds.biz"
   s.extra_rdoc_files = [
@@ -46,6 +46,7 @@ Gem::Specification.new do |s|
     "spec/fixtures/fixture_modules/one_resource_module/manifests/params.pp",
     "spec/fixtures/fixture_modules/zero_resource_module/manifests/empty_class.pp",
     "spec/fixtures/fixture_modules/zero_resource_module/manifests/not_a_resource_defination.pp",
+    "spec/fixtures/fixture_modules/zero_resource_module/metadata.json",
     "spec/fixtures/manifests/includes-class.pp",
     "spec/fixtures/manifests/includes-defines.pp",
     "spec/fixtures/modules/concat/CHANGELOG.md",
@@ -1821,7 +1822,7 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<trollop>, [">= 0"])
-      s.add_runtime_dependency(%q<retrospec>, ["~> 0.3"])
+      s.add_runtime_dependency(%q<retrospec>, ["~> 0.4.0"])
       s.add_development_dependency(%q<rspec>, ["~> 3.2"])
       s.add_development_dependency(%q<puppet>, ["= 3.7.3"])
       s.add_development_dependency(%q<yard>, ["~> 0.7"])
@@ -1830,12 +1831,9 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<jeweler>, [">= 0"])
       s.add_development_dependency(%q<pry>, [">= 0"])
       s.add_development_dependency(%q<fakefs>, [">= 0"])
-      s.add_development_dependency(%q<pry-rescue>, [">= 0"])
-      s.add_development_dependency(%q<pry-stack_explorer>, [">= 0"])
-      s.add_development_dependency(%q<pry-coolline>, [">= 0"])
     else
       s.add_dependency(%q<trollop>, [">= 0"])
-      s.add_dependency(%q<retrospec>, ["~> 0.3"])
+      s.add_dependency(%q<retrospec>, ["~> 0.4.0"])
       s.add_dependency(%q<rspec>, ["~> 3.2"])
       s.add_dependency(%q<puppet>, ["= 3.7.3"])
       s.add_dependency(%q<yard>, ["~> 0.7"])
@@ -1844,13 +1842,10 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<jeweler>, [">= 0"])
       s.add_dependency(%q<pry>, [">= 0"])
       s.add_dependency(%q<fakefs>, [">= 0"])
-      s.add_dependency(%q<pry-rescue>, [">= 0"])
-      s.add_dependency(%q<pry-stack_explorer>, [">= 0"])
-      s.add_dependency(%q<pry-coolline>, [">= 0"])
     end
   else
     s.add_dependency(%q<trollop>, [">= 0"])
-    s.add_dependency(%q<retrospec>, ["~> 0.3"])
+    s.add_dependency(%q<retrospec>, ["~> 0.4.0"])
     s.add_dependency(%q<rspec>, ["~> 3.2"])
     s.add_dependency(%q<puppet>, ["= 3.7.3"])
     s.add_dependency(%q<yard>, ["~> 0.7"])
@@ -1859,9 +1854,6 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<jeweler>, [">= 0"])
     s.add_dependency(%q<pry>, [">= 0"])
     s.add_dependency(%q<fakefs>, [">= 0"])
-    s.add_dependency(%q<pry-rescue>, [">= 0"])
-    s.add_dependency(%q<pry-stack_explorer>, [">= 0"])
-    s.add_dependency(%q<pry-coolline>, [">= 0"])
   end
 end
 

data/spec/fixtures/fixture_modules/zero_resource_module/metadata.json

@@ -0,0 +1,13 @@
+{
+  "name": "name-test123",
+  "version": "0.1.0",
+  "author": "name",
+  "summary": null,
+  "license": "Apache 2.0",
+  "source": "",
+  "project_page": null,
+  "issues_url": null,
+  "dependencies": [
+    {"name":"puppetlabs-stdlib","version_requirement":">= 1.0.0"}
+  ]
+}

data/spec/unit/plugin_spec.rb

@@ -6,16 +6,25 @@ describe "puppet" do
     Retrospec::Plugins::V1::Puppet.new('/tmp/testplugin_dir', {:name => 'testplugin', :config1 => 'test'})
   end
 
-  it 'can show the version' do
-    expect(Retrospec::Puppet::VERSION).to eq('0.9.0')
+  let(:global_opts) do
+    {:module_path => '/tmp/testplugin_dir'}
   end
 
-  it 'can get cli options' do
-    expect(Retrospec::Plugins::V1::Puppet.cli_options({})[:enable_future_parser]).to be false
+  before :each do
+    FileUtils.rm_rf('/tmp/testplugin_dir')
   end
 
+  it 'can show the version' do
+    expect(Retrospec::Puppet::VERSION).to eq('0.10.0')
+  end
+
+  # disabling for now until we can stub gets
+  xit 'can run cli and create new module' do
+    expect(Retrospec::Plugins::V1::Puppet.run_cli(global_opts, {},{}, ['new_module'])).to eq(nil)
+  end
 
-  it 'can get cli options' do
-    expect(Retrospec::Plugins::V1::Puppet.cli_options({'plugins::puppet::enable_future_parser' => true})[:enable_future_parser]).to be true
+  xit 'can run cli' do
+    Retrospec::Plugins::V1::Puppet.run_cli(global_opts, {},{}, ['new_module'])
+    expect(Retrospec::Plugins::V1::Puppet.run_cli(global_opts, {},{}, [])).to eq(nil)
   end
 end

data/spec/unit/puppet-retrospec_spec.rb

@@ -7,6 +7,30 @@ describe "puppet-retrospec" do
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
   end
 
+  let(:global_config) do
+     {'author' => 'Corey Osman'}
+  end
+
+  let(:plugin_config) do
+    {
+    # 'plugins::puppet::template_dir' => '/Users',
+    # 'plugins::puppet::templates::url' => '',
+    # 'plugins::puppet::templates::ref'  => '',
+    # 'plugins::puppet::enable_future_parser' => '',
+    # 'plugins::puppet::enable_beaker_tests' => '',
+    # 'plugins::puppet::namespace' => '',
+    # 'plugins::puppet::auto_create' => '',
+    }
+  end
+
+  let(:global_opts) do
+    {:module_path => File.join(fixture_modules_path, 'tomcat')}
+  end
+
+  let(:plugin_opts) do
+     {}
+  end
+
   before :all do
     #enabling the removal of real modules slows down tests, but from time to time we may need to
     FileUtils.rm_rf(fixture_modules_path) if ENV['RETROSPEC_CLEAN_UP_TEST_MODULES'] =~ /true/
@@ -16,7 +40,7 @@ describe "puppet-retrospec" do
 
   before :each do
     clean_up_spec_dir(@path)
-    @opts = {:module_path => @path, :enable_beaker_tests => false,
+    @opts = {:module_path => @path, :enable_beaker_tests => false, :name => 'name-test123',
              :enable_user_templates => false, :template_dir => '/tmp/.retrospec_templates' }
   end
 
@@ -29,11 +53,31 @@ describe "puppet-retrospec" do
     opts = {:module_path => @path, :enable_beaker_tests => false,
             :enable_user_templates => false, :template_dir => nil, :enable_future_parser => true }
     tomcat = Retrospec::Plugins::V1::Puppet.new(opts[:module_path], opts)
+    tomcat.post_init
     expect(tomcat.context.instance.future_parser).to eq(true)
   end
+  describe 'new module' do
+    after :each do
+      FileUtils.rm_rf('/tmp/new_module')
+    end
+    it 'should create a module when it does not exist' do
+      opts = {'plugins::puppet::author' => 'test_name', :module_path => '/tmp/new_module', :create => true,
+              :namespace => 'retrospec', :enable_beaker_tests => false,
+              :enable_user_templates => false, :name => 'moduletest', :template_dir => nil, :enable_future_parser => true }
+      new_module = Retrospec::Plugins::V1::Puppet.new(opts[:module_path], opts)
+      allow(new_module).to receive(:gets).and_return("y\n")
+      new_module.new_module
+      new_module.post_init
+      new_module.run
+      expect(File.exists?(File.join(new_module.manifest_dir, 'init.pp'))).to eq(true)
+      expect(File.exists?(File.join(new_module.module_path, 'metadata.json'))).to eq(true)
+      expect(JSON.parse(File.read(File.join(new_module.module_path, 'metadata.json')))['author']).to eq('test_name')
+    end
+  end
 
   it 'should create files without error' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     tomcat.create_files
     expect(File.exists?(File.join(@path, 'Gemfile'))).to eq(true)
     expect(File.exists?(File.join(@path, 'Rakefile'))).to eq(true)
@@ -47,6 +91,7 @@ describe "puppet-retrospec" do
   it 'should create acceptance test files' do
     @opts[:enable_beaker_tests] = true
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     spec_path = File.expand_path(File.join(@path, 'spec'))
     tomcat.create_files
     expect(File.exists?(File.join(spec_path, 'spec_helper_acceptance.rb'))).to eq(true)
@@ -61,6 +106,7 @@ describe "puppet-retrospec" do
     clean_up_spec_dir(@path)
     @opts[:enable_beaker_tests] = false
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     spec_path = File.expand_path(File.join(@path, 'spec'))
     tomcat.create_files
     expect(File.exists?(File.join(spec_path, 'spec_helper_acceptance.rb'))).to eq(false)
@@ -72,6 +118,7 @@ describe "puppet-retrospec" do
 
   it 'should create proper spec helper file' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'spec', 'spec_helper.rb'))
     tomcat.safe_create_module_files
     path = tomcat.module_path
@@ -80,6 +127,7 @@ describe "puppet-retrospec" do
 
   it 'should create proper shared context file' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'spec', 'shared_contexts.rb'))
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
@@ -87,6 +135,7 @@ describe "puppet-retrospec" do
 
   it 'should produce hiera data' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'spec', 'shared_contexts.rb'))
     tomcat.safe_create_module_files
     path = tomcat.module_path
@@ -107,6 +156,7 @@ describe "puppet-retrospec" do
     opts = {:module_path => @path, :enable_beaker_tests => true,
              :template_dir => '/tmp/my_templates' }
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'spec', 'spec_helper_acceptance.rb'))
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
@@ -117,6 +167,7 @@ describe "puppet-retrospec" do
              :template_dir => '/tmp/my_templates' }
     filepath = File.expand_path(File.join(@path, 'spec', 'spec_helper_acceptance.rb'))
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], opts)
+    tomcat.post_init
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(false)
   end
@@ -125,6 +176,7 @@ describe "puppet-retrospec" do
     opts = {:module_path => @path, :enable_beaker_tests => true,
             :template_dir =>  '/tmp/my_templates' }
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'spec', 'acceptance', 'nodesets', 'default.yml'))
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
@@ -133,6 +185,7 @@ describe "puppet-retrospec" do
 
   it 'should create Gemfile file' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'Gemfile'))
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
@@ -140,6 +193,7 @@ describe "puppet-retrospec" do
 
   it 'should create Rakefile file' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     filepath = File.expand_path(File.join(@path, 'Rakefile'))
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
@@ -149,18 +203,20 @@ describe "puppet-retrospec" do
     filepath = File.expand_path(File.join(@path,'.fixtures.yml'))
     FileUtils.rm_f(filepath)  # ensure we have a clean state
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     tomcat.safe_create_module_files
     expect(File.exists?(filepath)).to eq(true)
   end
 
   it 'should not create any files when 0 resources exists' do
     my_path = File.expand_path(File.join('spec', 'fixtures', 'fixture_modules', 'zero_resource_module'))
-    my_retro = Retrospec::Plugins::V1::Puppet.new(my_path)
+    my_retro = Retrospec::Plugins::V1::Puppet.new(my_path, @opts)
     my_retro.should_not_receive(:safe_create_file).with(anything,'resource_spec_file.erb')
   end
 
   it 'should create a file from a template' do
     tomcat = Retrospec::Plugins::V1::Puppet.new(@opts[:module_path], @opts)
+    tomcat.post_init
     file_path = File.join(@path,'.fixtures.yml')
     template_file = File.join(tomcat.template_dir,'module_files','.fixtures.yml.retrospec.erb')
     tomcat.safe_create_template_file(file_path, template_file, tomcat.context)
@@ -220,4 +276,5 @@ describe "puppet-retrospec" do
      expect(tomcat.generate_file_name('tomcat')).to eq('tomcat_spec.rb')
      expect(tomcat.generate_file_name('tomcat::config')).to eq('config_spec.rb')
   end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-retrospec
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Corey Osman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-28 00:00:00.000000000 Z
+date: 2015-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trollop
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,48 +150,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-rescue
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-stack_explorer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-coolline
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Retrofits and generates valid puppet rspec test code to existing modules
 email: corey@logicminds.biz
 executables: []
@@ -229,6 +187,7 @@ files:
 - spec/fixtures/fixture_modules/one_resource_module/manifests/params.pp
 - spec/fixtures/fixture_modules/zero_resource_module/manifests/empty_class.pp
 - spec/fixtures/fixture_modules/zero_resource_module/manifests/not_a_resource_defination.pp
+- spec/fixtures/fixture_modules/zero_resource_module/metadata.json
 - spec/fixtures/manifests/includes-class.pp
 - spec/fixtures/manifests/includes-defines.pp
 - spec/fixtures/modules/concat/CHANGELOG.md