puppet-retrospec 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fda1c3cbfe5d3d9b92d5eab9303f80bc4465aa4f
-  data.tar.gz: 786d7801e1105e8c988a8a4d9721ec04b2a66a15
+  metadata.gz: eaace655a4e5f360e93ef3ee07ed003dfeecdf61
+  data.tar.gz: 20f0b75846a20d22b35db36bfee6b8768503ca30
 SHA512:
-  metadata.gz: 4b38dc27fe54704e900fd3f361f7a31807cd1b38a68af1aa8ab5c6f1994529e16e2ee94202abe97891f380a38f2c423f83f1bb411dfe0930bafc1adfe7ce6a1e
-  data.tar.gz: 91ca0086878911e8f021eb17fad1a37a6b53d67eb8d3117ed53e5c9bd01eb704241c1c80cf1ddddbb297ccb9958d4b13e7acb5010e4a1f1e671a2d8a9f550d24
+  metadata.gz: 46c667b57c0d670e2ccde78f388b4d3a881b423679a6e438905e2f7bbf1667b760a8a973652a73ed6803068e6a5ba7e73a73c6f7892077b9da0bfc7a7a65685f
+  data.tar.gz: 667274f680050e06ef26e63d6804a46cc09a2ce9c5bf4831337070f8a16c2250978fa8e9573c6da634e4b28310e4036a68824561289327ac642f5fb96417468b

data/README.md

@@ -369,13 +369,14 @@ To override these templates just set **one** of the following cli options.
 
 ```
 
-Once one of the options is set, retrospec will copy over all the templates from the gem location to the default
-or specified override templates path.
+Once one of the options is set, retrospec will copy over all the templates from the default gem location to the default
+or specified templates path.  
 If you have already created the erb file in the templates location, then puppet-retrospec will not overwrite the file.
 You can set multiple template paths if you use them for different projects so just be sure the set the correct
 template option when running retrospec.
 
-Setting the `--enable-user-templates` option will tell retrospec to use the default user template location.
+Setting the `--enable-user-templates` option will tell retrospec to use the default user template location and will
+copy over all the default templates that came with the gem.
 
 The default user location for the templates when using this variable is ~/.puppet_retrospec_templates
 
@@ -387,35 +388,74 @@ If you set the `--template-dir` option you are not required to set the set `--en
 Example:
 `--template-dir=~/my_templates`
 
+As I said above some of us need different templates for different projects and so I have outlined a simple scenario below:
+Lets say I have three clients that each need site specific files in the module and the default templates just 
+don't give me everything I want.  Thus I will need to override the templates for each client.
+
+```shell
+    retrospec --template-dir ~/retrspec_client1
+    retrospec --template-dir ~/retrspec_client2
+    retrospec --template-dir ~/retrspec_client3
+    touch ~/retrspec_client1/module_files/special_file_for_client1.yml
+    touch ~/retrspec_client2/module_files/special_file_for_client2.yml
+    touch ~/retrspec_client3/module_files/special_file_for_client3.yml
+
+    mkdir -p ~/{client1,client2, client3}
+    cd ~/client1 && puppet module generate lmc-module1
+    cd ~/client2 && puppet module generate lmc-module1
+    cd ~/client3 && puppet module generate lmc-module1
+
+    cd ~/client1/module1 && retrospec --template-dir ~/retrspec_client1
+    cd ~/client2/module1 && retrospec --template-dir ~/retrspec_client2
+    cd ~/client3/module1 && retrospec --template-dir ~/retrspec_client3
+```
+Now when you run retrospec just pass in the template path for the specified client and the files will be created as you 
+specified in each clients template directory.
+
 Adding New Templates
 ======================
 Should you ever need to add new templates or normal files of any kind retrospec will automatically render and copy the template file
-to the module path if you place a file inside the templates/module_files directory.  The cool thing about this feature
-is that retrospec will recursively create the same directory structure you make inside the module_files directory inside your
+to the module path if you place a file inside the `template_path/module_files` directory.  The cool thing about this feature
+is that retrospec will recursively create the same directory structure you make inside the `module_files` directory inside your
 module.  Files do not need to end in .erb will still be rendered as a erb template.
 
-This follows the convention over configuration pattern so no directory name or filename is required when running retrospec.
+This follow the convention over configuration pattern so no directory name or filename is required when running retrospec.
 Just put the template file in the directory where you want it (under module_files) and name it exactly how you want it to appear in the module and retrospec
 will take care of the rest.  Please note that any file ending in .erb will have this extension automatically removed.
 
 Example:
+So lets say you want to add a .gitlab-ci.yaml file to all of your modules in your modules directory.  
 
 ```shell
-templates/
-├── acceptance_spec_test.erb
-├── module_files
-│   ├── Gemfile
-│   ├── Rakefile
-│   └── spec
-│       ├── acceptance
-│       │   └── nodesets
-│       │       ├── centos-59-x64.yml
-│       │       ├── centos-64-x64-pe.yml
-│       │       └── ubuntu-server-1404-x64.yml
-│       ├── shared_contexts.rb
-│       ├── spec_helper.rb
-│       └── spec_helper_acceptance.rb
-└── resource_spec_file.erb
+   touch ~/.puppet_retrospec_templates/module_files/.gitlab-ci.yaml
+   
+   tree ~/.puppet_retrospec_templates -a
+   ./.puppet_retrospec_templates
+   ├── acceptance_spec_test.erb
+   ├── module_files
+   │   ├── .fixtures.yml
+   │   ├── .gitignore.erb
+   │   ├── .gitlab-ci.yaml
+   │   ├── .travis.yml
+   │   ├── Gemfile
+   │   ├── README.markdown
+   │   ├── Rakefile
+   │   ├── Vagrantfile
+   │   └── spec
+   │       ├── acceptance
+   │       │   └── nodesets
+   │       │       └── ubuntu-server-1404-x64.yml
+   │       ├── shared_contexts.rb
+   │       ├── spec_helper.rb
+   │       └── spec_helper_acceptance.rb
+   └── resource_spec_file.erb
+
+    for dir in ../modules/*; do
+       name=`basename $dir`
+       retrospec -m $dir -e
+       + /Users/user1/modules/module1/.gitlab-ci.yaml
+    done
+
 ```
 
 Beaker Testing

data/VERSION

@@ -1 +1 @@
-0.7.2
+0.7.3

data/bin/retrospec

@@ -4,7 +4,7 @@ require 'trollop'
 require 'retrospec'
 
 opts = Trollop::options do
-  version "0.7.2 (c) Corey Osman"
+  version "0.7.3 (c) Corey Osman"
   banner <<-EOS
 Generates puppet rspec test code based on the classes and defines inside the manifests directory.
 

data/lib/retrospec.rb

@@ -41,11 +41,12 @@ class Retrospec
   end
 
   def create_files
+    types = spec_object.types
     safe_create_module_files
     # a Type is nothing more than a defined type or puppet class
     # we could have named this manifest but there could be multiple types
     # in a manifest.
-    spec_object.types.each do |type|
+    types.each do |type|
        safe_create_resource_spec_files(type)
        if spec_object.enable_beaker_tests?
          safe_create_acceptance_tests(type)

data/lib/retrospec/spec_object.rb

@@ -1,17 +1,46 @@
 
 module Utilities
   class SpecObject
-    attr_reader :instance
+    attr_reader :instance, :all_hiera_data
     attr_accessor :enable_beaker_tests, :parameters, :types, :resources, :type
 
     def initialize(mod_instance)
       @instance = mod_instance
+      all_hiera_data
     end
 
     def types
       instance.types
     end
 
+    def class_hiera_data(classname)
+      data = {}
+      types.each do |t|
+        next unless t.type == :hostclass   #defines don't have hiera lookup values
+        next unless t.name == classname
+        t.arguments.each do |k, v|
+          key = "#{t.name}::#{k}"
+          data[key] = nil
+        end
+      end
+      data
+    end
+
+    # gathers all the class parameters that could be used in hiera data mocking
+    def all_hiera_data
+      if @all_hiera_data.nil?
+        @all_hiera_data = {}
+        types.each do |t|
+          next unless t.type == :hostclass   #defines don't have hiera lookup values
+          t.arguments.each do |k, v|
+            key = "#{t.name}::#{k}"
+            @all_hiera_data[key] = nil
+          end
+        end
+      end
+      @all_hiera_data
+    end
+
     def module_name
       instance.module_name
     end

data/lib/retrospec/templates/acceptance_spec_test.erb

@@ -4,21 +4,21 @@ describe '<%= @type.name -%> <%= @type.type %>' do
   describe 'running puppet code' do
     it 'should work with no errors' do
       pp = <<-EOS
-class { '<%= @type.name %>':
-<%- @parameters.each do |k,v| -%>
-  <%- if v.nil? -%>
-  <%= "#{k} => 'place_value_here'," %>
-  <%- else -%>
-  <%= "##{k} => #{variable_value(v)}," %>
-  <%- end -%>
-<%- end -%>
-}
+      class { '<%= @type.name %>':
+      <%- @parameters.each do |k,v| -%>
+        <%- if v.nil? -%>
+        <%= "#{k}  => 'place_value_here'," %>
+        <%- else -%>
+        <%= "##{k} => #{variable_value(v)}," %>
+        <%- end -%>
+      <%- end -%>
+      }
       EOS
 
-   # Run it twice and test for idempotency
+    # Run it twice and test for idempotency
       apply_manifest(pp, :catch_failures => true)
-      expect(apply_manifest(pp, :catch_failures => true).exit_code).to be_zero
+      apply_manifest(pp, :catch_changes => true)
     end
 
   end
-end
+end

data/lib/retrospec/templates/module_files/Gemfile

@@ -1,29 +1,27 @@
 source "https://rubygems.org"
 
 group :test do
-gem "rake"
-gem "puppet", ENV['PUPPET_VERSION'] || '~> 3.7.3'
-gem "rspec-puppet", :git => 'https://github.com/rodjek/rspec-puppet.git'
-gem "puppetlabs_spec_helper"
-gem 'rspec-puppet-utils', :git => 'https://github.com/Accuity/rspec-puppet-utils.git'
-gem 'hiera-puppet-helper', :git => 'https://github.com/bobtfish/hiera-puppet-helper.git'
-<%- if enable_beaker_tests? -%>
+    gem "rake"
+    gem "puppet", ENV['PUPPET_VERSION'] || '~> 3.7.3'
+    gem "rspec-puppet", :git => 'https://github.com/rodjek/rspec-puppet.git'
+    gem "puppetlabs_spec_helper"
+    gem 'rspec-puppet-utils', :git => 'https://github.com/Accuity/rspec-puppet-utils.git'
+    gem 'hiera-puppet-helper', :git => 'https://github.com/bobtfish/hiera-puppet-helper.git'
+    gem "metadata-json-lint"
+    gem 'puppet-syntax'
+    gem 'puppet-lint'
+end
+
+group :integration do
     gem "beaker", :git => 'https://github.com/puppetlabs/beaker.git'
     gem "beaker-rspec", :git => 'https://github.com/puppetlabs/beaker-rspec.git'
     gem "vagrant-wrapper"
     gem 'serverspec'
-<%- end -%>
-# there seems to be a bug with puppet-blacksmith and metadata-json-lint
-# removing metadata for now
-gem "metadata-json-lint"
-gem 'puppet-syntax'
-gem 'puppet-lint'
 end
 
 group :development do
-gem "travis"
-gem "travis-lint"
-gem "puppet-blacksmith"
-gem "guard-rake"
+    gem "travis"
+    gem "travis-lint"
+    gem "puppet-blacksmith"
+    gem "guard-rake"
 end
-

data/lib/retrospec/templates/module_files/README.markdown

@@ -0,0 +1,75 @@
+# profiles 
+
+## Module development setup
+
+Install all the require gems to run test code
+```shell
+bundle install  (only need to do once)
+
+```
+## Running Tests
+
+### Unit tests
+This type of testing is fast and should be the first thing you do before comming your code.  Mistakes can be found
+in a matter of seconds vs minutes/hours.  You can test your logic in a unit test.  The downside is you need to learn
+how to write unit tests which can take some initial time getting used to.
+
+```shell
+bundle exec rake spec
+
+```
+
+### Integration Testing
+This type of testing is somewhat manual and requires the use of vagrant and a test vm that is controlled by vagrant.
+You can find the list of available test vms by running `vagrant status` in the root of the module directory.  There is 
+at lot of magic happening in the vagrantfile that makes this easy.  Windows support with this module has not been added yet.
+
+```shell
+
+$ vagrant status
+Current machine states:
+
+win2012r2                 not created (vmware_fusion)
+win2008r2                 not created (vmware_fusion)
+centos6                   running (vmware_fusion)
+```
+
+To run a test first you need to define the test code located in module_root/tests directory.  This code is nothing more
+than a bunch of puppet code that uses your manifest code.  You will be using puppet apply to run this code on the vm. 
+Have a look inside the tests directory for examples.
+
+Example test file
+```
+include profiles::default_linux
+file{'/tmp/test.txt':
+    ensure => file,
+    content => 'Hello World'
+}
+```
+
+There are a few ways to run the test code against a test vm, both of which have the same outcome.
+
+```shell
+bundle exec rake spec_prep
+VAGRANT_MANIFEST=linux.pp vagrant provision centos6
+```
+
+or use the rake command which bundles the two commands together
+
+```shell
+bundle exec rake "vagrant_up[linux.pp,centos6]"
+```
+
+### Acceptance Tests 
+Acceptance testing is sorta like combining unit testing and integration testing where it tests the code on real systems
+automatically across a wide range of operating systems.  This is an advanced topic, so yu will want to master unit and
+integration testing first before writing acceptance tests.
+
+```shell
+bundle exec rake beaker
+
+```
+
+
+## CI config doc
+https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/docs/configuration/advanced-configuration.md

data/lib/retrospec/templates/module_files/Rakefile

@@ -24,9 +24,9 @@ PuppetLint.configuration.send('disable_class_parameter_defaults')
 PuppetLint.configuration.send('disable_class_inherits_from_params_class')
 
 exclude_paths = [
-  "pkg/**/*",
-  "vendor/**/*",
-  "spec/**/*",
+    "pkg/**/*",
+    "vendor/**/*",
+    "spec/**/*",
 ]
 PuppetLint.configuration.ignore_paths = exclude_paths
 PuppetSyntax.exclude_paths = exclude_paths
@@ -37,8 +37,36 @@ end
 
 desc "Run syntax, lint, and spec tests."
 task :test => [
-       :syntax,
-       :lint,
-       :spec,
-       :metadata,
+         :syntax,
+         :lint,
+         :spec,
+         :metadata,
      ]
+def io_popen(command)
+  IO.popen(command) do |io|
+    io.each do |line|
+      print line
+      yield line if block_given?
+    end
+  end
+end
+
+desc 'Vagrant VM power up and provision'
+task :vagrant_up, [:manifest, :hostname] do |t, args|
+  args.with_defaults(:manifest => 'init.pp', :hostname => '')
+  Rake::Task['spec_prep'].execute
+  ENV['VAGRANT_MANIFEST'] = args[:manifest]
+  provision = false
+  io_popen("vagrant up #{args[:hostname]}") do |line|
+    provision = true if line =~ /is already running./
+  end
+  io_popen("vagrant provision #{args[:hostname]}") if provision
+end
+
+# Cleanup vagrant environment
+desc 'Vagrant VM shutdown and fixtures cleanup'
+task :vagrant_destroy do
+  Rake::Task['spec_prep'].execute
+  `vagrant destroy -f`
+  Rake::Task['spec_clean'].execute
+end

data/lib/retrospec/templates/module_files/Vagrantfile

@@ -0,0 +1,95 @@
+def vm(opt)
+  module_name = opt.fetch(:module).to_s || raise(ArgumentError, 'Must provide puppet module name')
+  hostname = opt.fetch(:hostname, module_name).to_s
+  memory = opt.fetch(:memory, 512)
+  cpu = opt.fetch(:cpu, 1)
+  box = opt.fetch(:box).to_s || raise(ArgumentError, 'Must provide box type.')
+  url = opt.fetch(:url, '').to_s
+  os_type = opt[:os_type] || opt[:type] || :linux
+  gui = opt.fetch(:gui, false)
+  ports = Array(opt.fetch(:port, []))
+  iso = opt.fetch(:iso, nil)
+  proj_root = File.expand_path(File.join(File.dirname(__FILE__)))
+  fixture_modules = File.join(proj_root, 'spec', 'fixtures', 'modules')
+
+  Vagrant.configure('2') do |conf|
+
+    # forward all the ports
+    ports.each do |p|
+      conf.vm.network(:forwarded_port, guest: p, host: p, auto_correct: true)
+    end
+
+    if os_type == :windows
+      conf.ssh.username = 'vagrant'
+      conf.winrm.username = 'vagrant'
+      conf.winrm.password = 'vagrant'
+    end
+
+    conf.vm.define hostname.to_sym do |mod|
+      mod.vm.box = box
+      mod.vm.box_url = url
+
+      if os_type == :windows
+        mod.vm.guest = :windows
+        mod.vm.communicator = 'winrm'
+        mod.vm.synced_folder './' , "/ProgramData/PuppetLabs/puppet/etc/modules/#{module_name}"
+        mod.vm.synced_folder 'spec/fixtures/modules' , '/temp/modules'
+      else
+        mod.vm.synced_folder './', "/etc/puppet/modules/#{module_name}"
+        mod.vm.synced_folder 'spec/fixtures/modules', '/tmp/puppet/modules'
+      end
+
+      mod.vm.hostname = hostname
+
+      mod.vm.provider :vmware_fusion do |f|
+        f.gui = gui
+        f.vmx['displayName'] = hostname
+        f.vmx['memsize'] = memory
+        f.vmx['numvcpus'] = cpu
+        if iso
+          f.vmx['ide1:0.devicetype'] = "cdrom-image"
+          f.vmx['ide1:0.filename'] = iso
+        end
+      end
+
+      mod.vm.provider :vmware_workstation do |f|
+        f.gui = gui
+        f.vmx['displayName'] = hostname
+        f.vmx['memsize'] = memory
+        f.vmx['numvcpus'] = cpu
+        if iso
+          f.vmx['ide1:0.devicetype'] = "cdrom-image"
+          f.vmx['ide1:0.filename'] = iso
+        end
+      end
+
+      mod.vm.provider :virtualbox do |v|
+        v.gui = gui
+        v.name = hostname
+        v.memory = memory
+        v.cpus = cpu
+      end
+
+      if os_type == :windows
+        manifest = ENV['VAGRANT_MANIFEST'] || 'init.pp'
+        mod.vm.provision :shell, :inline => "@powershell -NoProfile -ExecutionPolicy Bypass -Command \"iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1'))\" && SET PATH=%PATH%;%ALLUSERSPROFILE%\chocolatey\bin"
+        mod.vm.provision :shell, :inline => "choco install puppet"
+        mod.vm.provision :shell, :inline => "puppet apply --modulepath 'C:/ProgramData/PuppetLabs/puppet/etc/modules;C:/temp/modules' --verbose C:/ProgramData/PuppetLabs/puppet/etc/modules/#{module_name}/tests/#{manifest}"
+      else
+        mod.vm.provision :puppet do |p|
+          p.manifests_path = 'tests'
+          p.hiera_config_path = File.join(fixture_modules, 'hieradata', 'hiera.yaml')
+          p.manifest_file = ENV['VAGRANT_MANIFEST'] || 'init.pp'
+          #p.module_path = fixture_modules
+          # because of how symlinks are handled via the spec_helper we are forced to mount the modules is different locations
+          # otherwise we could just use the above option
+          p.options = '--modulepath="/etc/puppet/modules:/tmp/puppet/modules"'
+        end
+      end
+    end
+  end
+end
+module_name = File.basename(File.expand_path(File.join(File.dirname(__FILE__))))
+vm :hostname => 'win2012r2', :module => module_name, :box => 'opentable/win-2012r2-standard-amd64-nocm', :url => 'opentable/win-2012r2-standard-amd64-nocm', :cpu => 1, :memory => 4096, :gui => true
+vm :hostname => 'win2008r2', :module => module_name, :box => 'opentable/win-2008r2-standard-amd64-nocm', :url => 'opentable/win-2008r2-standard-amd64-nocm', :cpu => 1, :memory => 4096, :gui => true
+vm :hostname => 'centos6', :module => module_name, :box => 'puppetlabs/centos-6.6-64-puppet', :url => 'puppetlabs/centos-6.6-64-puppet', :cpu => 1, :memory => 2048, :gui => false

data/lib/retrospec/templates/module_files/spec/acceptance/nodesets/default.yml

@@ -1,11 +1,11 @@
 HOSTS:
-  centos-64-x64:
+  centos-66-x64:
     roles:
       - master
     platform: el-6-x86_64
-    box : centos-64-x64-vbox4210-nocm
-    box_url : http://puppet-vagrant-boxes.puppetlabs.com/centos-64-x64-vbox4210-nocm.box
-    hypervisor : vagrant
+    box: puppetlabs/centos-6.6-64-nocm
+    box_url: https://vagrantcloud.com/puppetlabs/boxes/centos-6.6-64-nocm
+    hypervisor: vagrant
 CONFIG:
-  log_level: debug
-  type: git
+  log_level: verbose
+  type: foss

data/lib/retrospec/templates/module_files/spec/shared_contexts.rb

@@ -1,12 +1,20 @@
-require 'hiera-puppet-helper'
-
 # optional, this should be the path to where the hiera data config file is in this repo
 # You must update this if your actual hiera data lives inside your module.
-# I only assume its data, but it could be anything
-hiera_config_file = File.expand_path(File.join(File.dirname(__FILE__), '..','data', 'hiera.yaml'))
+# I only assume you have a separate repository for hieradata and its include in your .fixtures
+hiera_config_file = File.expand_path(File.join(File.dirname(__FILE__), 'fixtures','modules','hieradata', 'hiera.yaml'))
 
 # hiera_config and hiera_data are mutually exclusive contexts.
 
+shared_content :global_hiera_data do
+  let(:hiera_data) do
+     {
+     <% @all_hiera_data.sort.each do |key, value| -%>
+  #"<%= key %>" => '',
+     <% end %>
+     }
+  end
+end
+
 shared_context :hiera do
     # example only,
     let(:hiera_data) do
@@ -32,6 +40,6 @@ end
 # you cannot use this in addition to any of the hiera_data contexts above
 shared_context :real_hiera_data do
     let(:hiera_config) do
-       hirea_config_file
+       hiera_config_file
     end
-end
+end

data/lib/retrospec/templates/module_files/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
 require 'rspec-puppet-utils'
+require 'hiera-puppet-helper'
 
 # Uncomment this to show coverage report, also useful for debugging
 #at_exit { RSpec::Puppet::Coverage.report! }

data/lib/retrospec/version.rb

@@ -1,3 +1,3 @@
 module Puppet_Retrospec
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/puppet-retrospec.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "puppet-retrospec"
-  s.version = "0.7.2"
+  s.version = "0.7.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Corey Osman"]
-  s.date = "2015-06-03"
+  s.date = "2015-07-28"
   s.description = "Retrofits and generates valid puppet rspec test code to existing modules"
   s.email = "corey@logicminds.biz"
   s.executables = ["retrospec"]
@@ -40,7 +40,9 @@ Gem::Specification.new do |s|
     "lib/retrospec/templates/module_files/.gitignore.erb",
     "lib/retrospec/templates/module_files/.travis.yml",
     "lib/retrospec/templates/module_files/Gemfile",
+    "lib/retrospec/templates/module_files/README.markdown",
     "lib/retrospec/templates/module_files/Rakefile",
+    "lib/retrospec/templates/module_files/Vagrantfile",
     "lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-59-x64.yml",
     "lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-64-x64-pe.yml",
     "lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-64-x64.yml",

data/spec/unit/module_spec.rb

@@ -49,7 +49,7 @@ describe 'Utilities::Module' do
 
   it 'should find types' do
     expect(@module.types).to be_instance_of(Array)
-    expect(@module.types.map {|t| t.name}.length).to eq(14)
+    expect(@module.types.map {|t| t.name}.length).to eq(18)
   end
 
 end

data/spec/unit/puppet-retrospec_spec.rb

@@ -145,10 +145,28 @@ describe "puppet-retrospec" do
     tomcat = Retrospec.new(@opts[:module_path], @opts)
     filepath = File.expand_path(File.join(@path, 'spec', 'shared_contexts.rb'))
     tomcat.safe_create_module_files
-    path = tomcat.module_path
     expect(File.exists?(filepath)).to eq(true)
   end
 
+  it 'should produce hiera data' do
+    tomcat = Retrospec.new(@opts[:module_path], @opts)
+    filepath = File.expand_path(File.join(@path, 'spec', 'shared_contexts.rb'))
+    tomcat.safe_create_module_files
+    path = tomcat.module_path
+    require 'pry'
+    expect(tomcat.spec_object.all_hiera_data).to eq({"tomcat::catalina_home"=>nil,
+                                                 "tomcat::user"=>nil,
+                                                 "tomcat::group"=>nil,
+                                                 "tomcat::install_from_source"=>nil,
+                                                 "tomcat::purge_connectors"=>nil,
+                                                 "tomcat::purge_realms"=>nil,
+                                                 "tomcat::manage_user"=>nil,
+                                                 "tomcat::manage_group"=>nil}
+                                             )
+
+    expect(File.read(filepath)).to include('#"tomcat::catalina_home" => \'\',')
+  end
+
   it 'should create acceptance spec helper file' do
     opts = {:module_path => @path, :enable_beaker_tests => true,
              :enable_user_templates => false, :template_dir => nil }

data/spec/unit/resource_spec.rb

@@ -47,8 +47,6 @@ describe "resource" do
       expect(r[1].type).to eq("file")
     end
 
-
-
     it 'should return resources' do
       test_type = @m.types.find {|x| x.name == 'one_resource::another_resource'}
       expect(Resource.all(test_type.code).length).to eq(2)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-retrospec
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Corey Osman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-03 00:00:00.000000000 Z
+date: 2015-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: facter
@@ -277,7 +277,9 @@ files:
 - lib/retrospec/templates/module_files/.gitignore.erb
 - lib/retrospec/templates/module_files/.travis.yml
 - lib/retrospec/templates/module_files/Gemfile
+- lib/retrospec/templates/module_files/README.markdown
 - lib/retrospec/templates/module_files/Rakefile
+- lib/retrospec/templates/module_files/Vagrantfile
 - lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-59-x64.yml
 - lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-64-x64-pe.yml
 - lib/retrospec/templates/module_files/spec/acceptance/nodesets/centos-64-x64.yml