puppet-resource_api 1.8.14 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 535559ec94778cea613ca61f7fd96309506730c7a79b7b081e198cea19739db0
-  data.tar.gz: afc626bed3349a334d7a25df3950f56ce997f6a607e8bdbe156c38b631c98d4a
+  metadata.gz: 1e25dec4ab50e8a0f4bb3bb3979c13df63857a092b5c9a7a1ef9f71f85c7f518
+  data.tar.gz: 01b32be4792de2f82eb78b91066a6f2bb740b49a620a92f50653fe9031e10026
 SHA512:
-  metadata.gz: c587b8c92ed10ec5329cb80c00968003b8f0a95f51e62002b26c4b446f48f517754ebf2344542806411e81a239f3f1bc56d56574652ad34624076726ed9880b8
-  data.tar.gz: b2fd76ef2a2cf6ae5e1f9f18022a318012ec29dbfbc4af6232b7bdb6481e5affeeb9f77c471fd0195e6401427656f854ac4c4083202b742c3be5772bbe9ba1fb
+  metadata.gz: e9845b10a4d1997ebfda6094c3a61012a4b55659b4870e966ca516b03c52e47a20b061bd47581ca0e67bb4976f797d6b271634ff761743c5b842f718fa26f630
+  data.tar.gz: 8387c57e4a46044c6fe301275b41856d1ce87ab0219b62bdfb5c6622593f5bfdc582ebf35cda2dfb0c2f4bb36f1b9b0075604a2baae5d53a33e14aac89c16d7d

data/CHANGELOG.md

@@ -3,9 +3,50 @@
 All significant changes to this repo will be summarized in this file.
 
 
-## [v1.8.14](https://github.com/puppetlabs/puppet-resource_api/tree/v1.8.14) (2021-06-09)
+## [1.9.0](https://github.com/puppetlabs/puppet-resource_api/tree/1.9.0) (2023-08-08)
 
-[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/1.8.13...v1.8.14)
+[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/1.8.18...1.9.0)
+
+**Implemented enhancements:**
+
+- \(CAT-761\) Add custom\_generate as a feature [\#316](https://github.com/puppetlabs/puppet-resource_api/pull/316) ([david22swan](https://github.com/david22swan))
+
+## [1.8.18](https://github.com/puppetlabs/puppet-resource_api/tree/1.8.18) (2023-07-21)
+
+[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/1.8.16...1.8.18)
+
+**Merged pull requests:**
+
+- \(PA-5641\) Release only to rubygems, do not bump and release [\#326](https://github.com/puppetlabs/puppet-resource_api/pull/326) ([tvpartytonight](https://github.com/tvpartytonight))
+- \(PA-5641\) Prep for 1.8.18 release [\#324](https://github.com/puppetlabs/puppet-resource_api/pull/324) ([tvpartytonight](https://github.com/tvpartytonight))
+- \(PA-5641\) Use new organizational token for rubygem pushing [\#323](https://github.com/puppetlabs/puppet-resource_api/pull/323) ([tvpartytonight](https://github.com/tvpartytonight))
+- \(PA-5641\) prefer auto-generated GITHUB\_TOKEN [\#322](https://github.com/puppetlabs/puppet-resource_api/pull/322) ([tvpartytonight](https://github.com/tvpartytonight))
+- \(PA-5641\) Add release job via PR [\#321](https://github.com/puppetlabs/puppet-resource_api/pull/321) ([tvpartytonight](https://github.com/tvpartytonight))
+- \(maint\) Remove old Ruby logic from Gemfile [\#320](https://github.com/puppetlabs/puppet-resource_api/pull/320) ([mhashizume](https://github.com/mhashizume))
+- \(PA-4639\) Migrate away from AppVeyor [\#319](https://github.com/puppetlabs/puppet-resource_api/pull/319) ([mhashizume](https://github.com/mhashizume))
+- \(maint\) Don't require git [\#318](https://github.com/puppetlabs/puppet-resource_api/pull/318) ([joshcooper](https://github.com/joshcooper))
+- \(PA-5641\) Update rspec tests with modern Ruby [\#317](https://github.com/puppetlabs/puppet-resource_api/pull/317) ([mhashizume](https://github.com/mhashizume))
+- \(maint\) Update to Mend [\#311](https://github.com/puppetlabs/puppet-resource_api/pull/311) ([cthorn42](https://github.com/cthorn42))
+- \(packaging\) Bump to version '1.8.17' \[no-promote\] [\#301](https://github.com/puppetlabs/puppet-resource_api/pull/301) ([tvpartytonight](https://github.com/tvpartytonight))
+
+## [1.8.16](https://github.com/puppetlabs/puppet-resource_api/tree/1.8.16) (2022-10-03)
+
+[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/1.8.14...1.8.16)
+
+**Merged pull requests:**
+
+- \(PA-4558\) Replaces Travis CI with GitHub Actions [\#298](https://github.com/puppetlabs/puppet-resource_api/pull/298) ([mhashizume](https://github.com/mhashizume))
+- Add snyk monitoring [\#297](https://github.com/puppetlabs/puppet-resource_api/pull/297) ([joshcooper](https://github.com/joshcooper))
+- \(packaging\) Sets version to 1.8.15 for release [\#296](https://github.com/puppetlabs/puppet-resource_api/pull/296) ([mhashizume](https://github.com/mhashizume))
+- Update CODEOWNERS [\#295](https://github.com/puppetlabs/puppet-resource_api/pull/295) ([binford2k](https://github.com/binford2k))
+- Add array support to autorequire variable expansion [\#294](https://github.com/puppetlabs/puppet-resource_api/pull/294) ([seanmil](https://github.com/seanmil))
+- \(GH-231\) Add default to transport attributes [\#293](https://github.com/puppetlabs/puppet-resource_api/pull/293) ([seanmil](https://github.com/seanmil))
+- Support ensure parameter with Optional data type [\#292](https://github.com/puppetlabs/puppet-resource_api/pull/292) ([seanmil](https://github.com/seanmil))
+- Only ship needed files [\#289](https://github.com/puppetlabs/puppet-resource_api/pull/289) ([ekohl](https://github.com/ekohl))
+
+## [1.8.14](https://github.com/puppetlabs/puppet-resource_api/tree/1.8.14) (2021-06-09)
+
+[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/1.8.13...1.8.14)
 
 **Implemented enhancements:**
 
@@ -32,7 +73,7 @@ All significant changes to this repo will be summarized in this file.
 - Language correction [\#270](https://github.com/puppetlabs/puppet-resource_api/pull/270) ([epackorigan](https://github.com/epackorigan))
 - \(maint\) Update CHANGELOG [\#268](https://github.com/puppetlabs/puppet-resource_api/pull/268) ([DavidS](https://github.com/DavidS))
 - \(maint\) update test matrix for current supported versions; remove older versions to cut down on resource usage [\#265](https://github.com/puppetlabs/puppet-resource_api/pull/265) ([DavidS](https://github.com/DavidS))
-- \(maint\) Mock Hocon.load\(...\) [\#263](https://github.com/puppetlabs/puppet-resource_api/pull/263) ([IrimieBogdan](https://github.com/IrimieBogdan))
+- \(maint\) Mock Hocon.load\(...\) [\#263](https://github.com/puppetlabs/puppet-resource_api/pull/263) ([BogdanIrimie](https://github.com/BogdanIrimie))
 - Update rake requirement from ~\> 10.0 to ~\> 13.0 [\#262](https://github.com/puppetlabs/puppet-resource_api/pull/262) ([dependabot-preview[bot]](https://github.com/apps/dependabot-preview))
 - \(maint\) update Gemfile to allow use of non-vulnerable rake version 12.3.3 [\#260](https://github.com/puppetlabs/puppet-resource_api/pull/260) ([DavidS](https://github.com/DavidS))
 

data/README.md

@@ -1,6 +1,6 @@
-# Puppet::ResourceApi [![TravisCI Build Status](https://travis-ci.org/puppetlabs/puppet-resource_api.svg?branch=main)](https://travis-ci.org/puppetlabs/puppet-resource_api) [![Appveyor Build status](https://ci.appveyor.com/api/projects/status/8o9s1ax0hs8lm5fd/branch/main?svg=true)](https://ci.appveyor.com/project/puppetlabs/puppet-resource-api/branch/main) [![codecov](https://codecov.io/gh/puppetlabs/puppet-resource_api/branch/main/graph/badge.svg)](https://codecov.io/gh/puppetlabs/puppet-resource_api)
+# Puppet::ResourceApi [![codecov](https://codecov.io/gh/puppetlabs/puppet-resource_api/branch/main/graph/badge.svg)](https://codecov.io/gh/puppetlabs/puppet-resource_api)
 
-This is an implementation of the [Resource API specification](https://github.com/puppetlabs/puppet-specifications/blob/main/language/resource-api/README.md).
+This is an implementation of the [Resource API specification](https://github.com/puppetlabs/puppet-specifications/blob/master/language/resource-api/README.md).
 
 Find a working example of a new-style providers in the [Palo Alto Firewall module](https://github.com/puppetlabs/puppetlabs-panos/):
 * [Type](https://github.com/puppetlabs/puppetlabs-panos/blob/main/lib/puppet/type/panos_address.rb)
@@ -15,18 +15,18 @@ Find a working example of a new-style providers in the [Palo Alto Firewall modul
 * The [Resource API specs](https://github.com/puppetlabs/puppet-specifications/blob/master/language/resource-api/README.md) describes details of all the capabilities of this gem.
 * The [puppetlabs-hue module](https://github.com/puppetlabs/puppetlabs-hue) is a very simple example for using the Resource API for remote resources.
 * The [meraki module](https://github.com/meraki/puppet-module) is a full example for using the Resource API for remote resources.
-* This [Introduction to Testing Puppet Modules](https://www.netways.de/index.php?id=3445#c44135) talk describes rspec usage in more detail.
-* The [RSpec docs](https://relishapp.com/rspec) provide an overview of the capabilities of rspec.
+* This [Introduction to Testing Puppet Modules](https://www.youtube.com/watch?v=GgNrxLfoDF8) talk describes rspec usage in more detail.
+* The [RSpec docs](https://rspec.info/documentation/) provide an overview of the capabilities of rspec.
 * Read [betterspecs](http://www.betterspecs.org/) for general guidelines on what is considered good specs.
 
 
 ## Deployment
 
-The `puppet-resource_api` gem is part of the [Puppet 6 Platform](https://puppet.com/blog/introducing-puppet-6). With older versions of Puppet, you can use the [puppetlabs-resource_api module](https://forge.puppet.com/puppetlabs/resource_api) to install the gem on your servers and agents.
+The `puppet-resource_api` gem is part of Puppet from version 6 onward.
 
 
 ## Contributing
-We are always welcoming bug reports and pull requests on the Resource API, so that we can continue to improve it to the best of our ability. If you would like to contribute, [have a look at our GitHub](https://github.com/puppetlabs/puppet-resource_api) and the [Resource API Backlog](https://github.com/puppetlabs/puppet-resource_api/projects/1).
+We welcome bug reports and pull requests on the Resource API so that we can continue to improve it to the best of our ability. If you would like to contribute, [have a look at our GitHub](https://github.com/puppetlabs/puppet-resource_api) and the [Resource API Backlog](https://github.com/puppetlabs/puppet-resource_api/projects/1).
 
 
 ## Known Issues

data/lib/puppet/resource_api/base_context.rb

@@ -90,7 +90,7 @@ class Puppet::ResourceApi::BaseContext
     end
   end
 
-  def processing(title, is, should, message: 'Processing')
+  def processing(title, is, should, message = 'Processing')
     raise "#{__method__} only accepts a single resource title" if title.respond_to?(:each)
     start_time = Time.now
     setup_context(title, message)

data/lib/puppet/resource_api/data_type_handling.rb

@@ -86,7 +86,7 @@ module Puppet::ResourceApi::DataTypeHandling
     when Puppet::Pops::Types::PIntegerType,
          Puppet::Pops::Types::PFloatType,
          Puppet::Pops::Types::PNumericType
-      if value =~ %r{^-?\d+$} || value =~ Puppet::Pops::Patterns::NUMERIC
+      if value.is_a?(String) && (value.match?(%r{^-?\d+$}) || value.match?(Puppet::Pops::Patterns::NUMERIC))
         value = Puppet::Pops::Utils.to_n(value)
       end
     when Puppet::Pops::Types::PEnumType,
@@ -184,8 +184,15 @@ module Puppet::ResourceApi::DataTypeHandling
     options = definition[:attributes][:ensure]
     type = parse_puppet_type(:ensure, options[:type])
 
+    # If the type is wrapped in optional, then check it unwrapped:
+    type = type.type if type.is_a?(Puppet::Pops::Types::POptionalType)
     return if type.is_a?(Puppet::Pops::Types::PEnumType) && type.values.sort == %w[absent present].sort
-    raise Puppet::DevError, '`:ensure` attribute must have a type of: `Enum[present, absent]`'
+
+    # If Variant was used instead, then construct one and use the built-in type comparison:
+    variant_type = Puppet::Pops::Types::TypeParser.singleton.parse('Variant[Undef, Enum[present, absent]]')
+    return if variant_type == type
+
+    raise Puppet::DevError, '`:ensure` attribute must have a type of: `Enum[present, absent]` or `Optional[Enum[present, absent]]`'
   end
 
   def self.parse_puppet_type(attr_name, type)

data/lib/puppet/resource_api/simple_provider.rb

@@ -40,14 +40,14 @@ module Puppet::ResourceApi
           context.creating(name) do
             create(context, name_hash, should)
           end
-        elsif is[:ensure].to_s == 'present' && should[:ensure].to_s == 'present'
-          context.updating(name) do
-            update(context, name_hash, should)
-          end
         elsif is[:ensure].to_s == 'present' && should[:ensure].to_s == 'absent'
           context.deleting(name) do
             delete(context, name_hash)
           end
+        elsif is[:ensure].to_s == 'present'
+          context.updating(name) do
+            update(context, name_hash, should)
+          end
         end
       end
     end

data/lib/puppet/resource_api/transport.rb

@@ -103,6 +103,7 @@ module Puppet::ResourceApi::Transport
       clean_bolt_attributes(transport_schema, connection_info)
     end
 
+    apply_defaults(transport_schema, connection_info)
     message_prefix = 'The connection info provided does not match the Transport Schema'
     transport_schema.check_schema(connection_info, message_prefix)
     transport_schema.validate(connection_info)
@@ -128,6 +129,18 @@ module Puppet::ResourceApi::Transport
   end
   private_class_method :wrap_sensitive
 
+  def self.apply_defaults(transport_schema, connection_info)
+    context = get_context(transport_schema.name)
+    transport_schema.attributes.each do |attr_name, options|
+      if options.key?(:default) && connection_info.key?(attr_name) == false
+        context.debug('Using default value for attribute: %{attribute_name}, value: %{default_value}' % { attribute_name: attr_name, default_value: options[:default].inspect })
+        connection_info[attr_name] = options[:default]
+      end
+    end
+    connection_info
+  end
+  private_class_method :apply_defaults
+
   def self.transports
     @transports ||= {}
   end

data/lib/puppet/resource_api/type_definition.rb

@@ -36,7 +36,7 @@ module Puppet::ResourceApi
       Puppet::ResourceApi::DataTypeHandling.validate_ensure(definition)
 
       definition[:features] ||= []
-      supported_features = %w[supports_noop canonicalize custom_insync remote_resource simple_get_filter].freeze
+      supported_features = %w[supports_noop canonicalize custom_insync remote_resource simple_get_filter custom_generate].freeze
       unknown_features = definition[:features] - supported_features
       Puppet.warning("Unknown feature detected: #{unknown_features.inspect}") unless unknown_features.empty?
     end

data/lib/puppet/resource_api/version.rb

@@ -2,6 +2,6 @@
 
 module Puppet
   module ResourceApi
-    VERSION = '1.8.14'
+    VERSION = '1.9.0'
   end
 end

data/lib/puppet/resource_api.rb

@@ -136,6 +136,23 @@ module Puppet::ResourceApi
         @rsapi_canonicalized_target_state
       end
 
+      # Method is used to custom generate resources which are then applied by Puppet
+      def generate
+        # If feature `custom_generate` has been set then call the generate function within the provider and return the given results
+        return unless type_definition&.feature?('custom_generate')
+        should_hash = rsapi_canonicalized_target_state
+        is_hash     = rsapi_current_state
+        title       = rsapi_title
+
+        # Ensure that a custom `generate` method has been created within the provider
+        raise(Puppet::DevError, 'No generate method found within the types provider') unless my_provider.respond_to?(:generate)
+        # Call the providers custom `generate` method
+        rules_resources = my_provider.generate(context, title, is_hash, should_hash)
+
+        # Return array of resources
+        rules_resources
+      end
+
       def rsapi_current_state
         refresh_current_state unless @rsapi_current_state
         @rsapi_current_state
@@ -456,7 +473,7 @@ MESSAGE
         definition[auto].each do |type, values|
           Puppet.debug("Registering #{auto} for #{type}: #{values.inspect}")
           send(auto, type.downcase.to_sym) do
-            [values].flatten.map do |v|
+            resolved = [values].flatten.map do |v|
               match = %r{\A\$(.*)\Z}.match(v) if v.is_a? String
               if match.nil?
                 v
@@ -464,6 +481,9 @@ MESSAGE
                 self[match[1].to_sym]
               end
             end
+            # Flatten to handle any resolved array properties and filter any nil
+            # values resulting from unspecified optional parameters:
+            resolved.flatten.reject { |v| v.nil? }
           end
         end
       end

data/puppet-resource_api.gemspec

@@ -12,14 +12,13 @@ Gem::Specification.new do |spec|
   spec.summary       = 'This library provides a simple way to write new native resources for puppet.'
   spec.homepage      = 'https://github.com/puppetlabs/puppet-resource_api'
 
-  # on out internal jenkins, there is no git, but since it is a clean machine, we don't need to worry about anything else
-  spec.files         = if system('git --help > /dev/null')
-                         `git ls-files -z`.split("\x0")
-                       else
-                         Dir.glob('**/*')
-                       end.reject do |f|
-                         f.match(%r{^(test|spec|features)/})
-                       end
+  base = "#{__dir__}#{File::SEPARATOR}"
+  dirs =
+    Dir[File.join(__dir__, 'lib/**/*')] +
+    Dir[File.join(__dir__, 'docs/**/*')]
+  spec.files =
+    dirs.select { |path| File.file?(path) }.map { |path| path.sub(base, '') } +
+    %w[CHANGELOG.md CONTRIBUTING.md README.md LICENSE NOTICE puppet-resource_api.gemspec]
 
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-resource_api
 version: !ruby/object:Gem::Version
-  version: 1.8.14
+  version: 1.9.0
 platform: ruby
 authors:
 - David Schmitt
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-06-09 00:00:00.000000000 Z
+date: 2023-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hocon
@@ -31,28 +31,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".dependency_decisions.yml"
-- ".fixtures.yml"
-- ".github/dependabot.yml"
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
-- CODEOWNERS
 - CONTRIBUTING.md
-- Gemfile
-- HISTORY.md
 - LICENSE
 - NOTICE
 - README.md
-- Rakefile
-- appveyor.yml
-- bin/console
-- bin/setup
-- codecov.yml
-- contrib/README.md
-- contrib/pre-commit
 - docs/README.md
 - docs/hands-on-lab/01-installing-prereqs.md
 - docs/hands-on-lab/02-connecting-to-the-lightbulbs-emulator.png
@@ -100,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.5
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: This library provides a simple way to write new native resources for puppet.

data/.dependency_decisions.yml

@@ -1,98 +0,0 @@
----
-- - :permit
-  - MIT
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:11:09.971500380 Z
-- - :permit
-  - Apache 2.0
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:12:21.086779416 Z
-- - :permit
-  - ruby
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:12:28.578927478 Z
-- - :permit
-  - Simplified BSD
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:12:36.924605442 Z
-- - :permit
-  - New BSD
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:14:00.252514982 Z
-- - :permit
-  - Apache License, v2
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:14:07.999759997 Z
-- - :permit
-  - Ruby or LGPLv3+
-  - :who: DavidS
-    :why: standard license
-    :versions: []
-    :when: 2017-07-28 11:18:47.915684798 Z
-- - :license
-  - bundler
-  - MIT
-  - :who: DavidS
-    :why: See https://rubygems.org/gems/bundler
-    :versions: []
-    :when: 2017-07-28 11:22:12.975947786 Z
-- - :license
-  - minitar
-  - ruby
-  - :who: DavidS
-    :why: https://rubygems.org/gems/minitar
-    :versions: []
-    :when: 2017-07-28 11:22:50.609762862 Z
-- - :license
-  - colored
-  - MIT
-  - :who: DavidS
-    :why: https://github.com/defunkt/colored/blob/829bde0f8832406be1cacc5c99c49d976e05ccfc/LICENSE
-    :versions: []
-    :when: 2017-07-28 11:23:25.554994001 Z
-- - :permit
-  - ISC
-  - :who: scotje
-    :why: MIT equivalent
-    :versions: []
-    :when: 2017-08-11 01:30:32.594531000 Z
-- - :license
-  - facter
-  - Apache 2.0
-  - :who: DavidS
-    :why: https://github.com/puppetlabs/facter/blob/d6e1d4bcb087683239ff5ee6bd72978d262b9c39/LICENSE
-    :versions: []
-    :when: 2017-08-31 13:26:57.197893553 Z
-- - :license
-  - codecov
-  - MIT
-  - :who: DavidS
-    :why: https://github.com/codecov/codecov-ruby/blob/d5f85a0ece83845a577e26f8ce735ae10de767c0/LICENSE.txt
-    :versions: []
-    :when: 2017-10-11 12:15:00.000000000 Z
-- - :license
-  - blankslate
-  - MIT
-  - :who: DavidS
-    :why: https://github.com/masover/blankslate/blob/f0a73b80c34bc3ad94dc3195d12a227a8fe30019/MIT-LICENSE
-    :versions: []
-    :when: 2017-11-17 14:05:09.534340925 Z
-- - :license
-  - puppetlabs_spec_helper
-  - Apache 2.0
-  - :who: DavidS
-    :why:
-    :versions: []
-    :when: 2018-03-09 18:04:29.175843919 Z

data/.fixtures.yml

@@ -1,8 +0,0 @@
-# This file can be used to install module depdencies for unit testing
-# See https://github.com/puppetlabs/puppetlabs_spec_helper#using-fixtures for details
----
-fixtures:
-  forge_modules:
-#     stdlib: "puppetlabs/stdlib"
-  symlinks:
-    test_module: "#{source_dir}/spec/fixtures/test_module"

data/.github/dependabot.yml

@@ -1,12 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: bundler
-  directory: "/"
-  schedule:
-    interval: daily
-    time: "13:00"
-  open-pull-requests-limit: 10
-  ignore:
-  - dependency-name: rubocop
-    versions:
-    - "> 0.57.0"

data/.gitignore

@@ -1,15 +0,0 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-
-# rspec failure tracking
-.rspec_status
-
-# puppetlabs_spec_helper automatic fixtures
-spec/fixtures/modules/test_module

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---color
---order rand

data/.rubocop.yml

@@ -1,159 +0,0 @@
----
-require: rubocop-rspec
-AllCops:
-  TargetRubyVersion: '2.5'
-  Include:
-  - "**/*.rb"
-  Exclude:
-  - bin/*
-  - ".vendor/**/*"
-  - Gemfile
-  - Rakefile
-  - pkg/**/*
-  - spec/fixtures/**/*
-  - vendor/**/*
-Metrics/LineLength:
-  Description: People have wide screens, use them.
-  Max: 200
-RSpec/BeforeAfterAll:
-  Description: Beware of using after(:all) as it may cause state to leak between tests.
-    A necessary evil in acceptance testing.
-  Exclude:
-  - spec/acceptance/**/*.rb
-RSpec/HookArgument:
-  Description: Prefer explicit :each argument, matching existing module's style
-  EnforcedStyle: each
-RSpec/SubjectStub:
-  Exclude:
-    - 'spec/puppet/resource_api/base_context_spec.rb'
-Style/BlockDelimiters:
-  Description: Prefer braces for chaining. Mostly an aesthetical choice. Better to
-    be consistent then.
-  EnforcedStyle: braces_for_chaining
-Style/ClassAndModuleChildren:
-  Description: Compact style reduces the required amount of indentation.
-  EnforcedStyle: compact
-# this needs to be easily usable in the gemspec
-  Exclude:
-    - 'lib/puppet/resource_api/version.rb'
-Style/EmptyElse:
-  Description: Enforce against empty else clauses, but allow `nil` for clarity.
-  EnforcedStyle: empty
-Style/FormatString:
-  Description: Following the main puppet project's style, prefer the % format format.
-  EnforcedStyle: percent
-Style/FormatStringToken:
-  Description: Following the main puppet project's style, prefer the simpler template
-    tokens over annotated ones.
-  EnforcedStyle: template
-Style/Lambda:
-  Description: Prefer the keyword for easier discoverability.
-  EnforcedStyle: literal
-Style/RegexpLiteral:
-  Description: Community preference. See https://github.com/voxpupuli/modulesync_config/issues/168
-  EnforcedStyle: percent_r
-Style/TernaryParentheses:
-  Description: Checks for use of parentheses around ternary conditions. Enforce parentheses
-    on complex expressions for better readability, but seriously consider breaking
-    it up.
-  EnforcedStyle: require_parentheses_when_complex
-Style/TrailingCommaInArguments:
-  Description: Prefer always trailing comma on multiline argument lists. This makes
-    diffs, and re-ordering nicer.
-  EnforcedStyleForMultiline: comma
-Style/SymbolArray:
-  Description: Using percent style obscures symbolic intent of array's contents.
-  EnforcedStyle: brackets
-Layout/EndOfLine:
-  Enabled: false
-Style/CollectionMethods:
-  Enabled: true
-Style/MethodCalledOnDoEndBlock:
-  Enabled: true
-Style/StringMethods:
-  Enabled: true
-Metrics/AbcSize:
-  Enabled: false
-Metrics/BlockLength:
-  Enabled: false
-Metrics/ClassLength:
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Enabled: false
-Metrics/MethodLength:
-  Enabled: false
-Metrics/ModuleLength:
-  Enabled: false
-Metrics/ParameterLists:
-  Enabled: false
-Metrics/PerceivedComplexity:
-  Enabled: false
-RSpec/DescribeClass:
-  Enabled: false
-RSpec/ExampleLength:
-  Enabled: false
-RSpec/MessageExpectation:
-  Enabled: false
-RSpec/MultipleExpectations:
-  Enabled: false
-RSpec/NestedGroups:
-  Enabled: false
-Style/AsciiComments:
-  Enabled: false
-Style/IfUnlessModifier:
-  Enabled: false
-Style/SymbolProc:
-  Enabled: false
-
-# local overrides
-
-# overridden for local conventions
-Naming/FileName:
-  Exclude:
-    - 'puppet-resource_api.gemspec'
-
-# metaprogramming makes everything "fun"
-Lint/NestedMethodDefinition:
-  Exclude:
-    - 'lib/puppet/resource_api.rb'
-
-# Interacting with external API makes message spies pretty useless
-RSpec/MessageSpies:
-  Enabled: false
-
-# If neighbouring parameters are both hashes, it helps to have braces round both.
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'spec/puppet/resource_api/base_context_spec.rb'
-
-# requires 2.3's squiggly HEREDOC support, which we can't use, yet
-# see http://www.virtuouscode.com/2016/01/06/about-the-ruby-squiggly-heredoc-syntax/
-Layout/IndentHeredoc:
-  Enabled: false
-
-# Updated in 0.53 (or thereabouts)
-Style/TrailingCommaInArrayLiteral:
-  Description: Prefer always trailing comma on multiline literals. This makes diffs,
-    and re-ordering nicer.
-  EnforcedStyleForMultiline: comma
-Style/TrailingCommaInHashLiteral:
-  Description: Prefer always trailing comma on multiline literals. This makes diffs,
-    and re-ordering nicer.
-  EnforcedStyleForMultiline: comma
-
-# Add allowing "is", as it is a technical term in puppet
-Naming/UncommunicativeMethodParamName:
-  Description: Checks for method parameter names that contain capital letters, end in
-    numbers, or do not meet a minimal length.
-  Enabled: true
-  MinNameLength: 3
-  AllowNamesEndingInNumbers: true
-  AllowedNames:
-  - io
-  - id
-  - is
-  ForbiddenNames: []
-
-# This cop breaks syntax highlighting in VSCode
-Layout/ClosingHeredocIndentation:
-  Enabled: false