puppet-resource_api 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d29f5e5eebf841dba323c731c6a6a423fc904b7cc52a000a708307ff5bbe51cc
-  data.tar.gz: 01e210072f6c0154c3964a93e45ebd8388469c25a0e47b5d4ab547e9f9321733
+  metadata.gz: 105c2d9cb6636fc3d70e1250bf84e4a56392199aadbfcb3be58471282f9f9c36
+  data.tar.gz: 1ce5d86677e93beb2375fd83c7e1eb95b4b3132cf001b6cf2534135244c53e84
 SHA512:
-  metadata.gz: c91d23aa2991cbadf1714930bb5a02e5366f1d8308350f9be96d4c76eef12a5b462776f6d068dd80762b5f11b667a734d7dc04593d5fd38b294c36bae6e0f8f3
-  data.tar.gz: c9ba9579b7057a34c5056db7d4bf89ecceafb7e4eab8c3fe62dfdafe190eb353d72e28e680a7d91b472351b14bccf563b744aff5c2f6a0ed9773abee7e24f42c
+  metadata.gz: 057617a9cdde0351dcee064dfaba1cd439c60dd6112feea96b5045febb80248ce9bcc96fb9d0ba893021efafc275f5ded07e29ed6ff61f9d4df7965f4586e378
+  data.tar.gz: 4640b315d89e61001df0e41f304547c686e1317e4428dd102a9232bf46c930f2eb5b3f3508880372d70474e8235f014e363d0a9928bdaf28af01a343927081dc

data/CHANGELOG.md

@@ -3,6 +3,18 @@
 All significant changes to this repo will be summarized in this file.
 
 
+## [v1.4.2](https://github.com/puppetlabs/puppet-resource_api/tree/v1.4.2) (2018-08-09)
+[Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/v1.4.1...v1.4.2)
+
+**Fixed bugs:**
+
+- Allow an attribute with default boolean value to be set correctly [\#110](https://github.com/puppetlabs/puppet-resource_api/pull/110) ([da-ar](https://github.com/da-ar))
+
+**Merged pull requests:**
+
+- \(maint\) fix brace alignment; document reference [\#111](https://github.com/puppetlabs/puppet-resource_api/pull/111) ([DavidS](https://github.com/DavidS))
+- Release prep for v1.4.1 [\#109](https://github.com/puppetlabs/puppet-resource_api/pull/109) ([DavidS](https://github.com/DavidS))
+
 ## [v1.4.1](https://github.com/puppetlabs/puppet-resource_api/tree/v1.4.1) (2018-07-20)
 [Full Changelog](https://github.com/puppetlabs/puppet-resource_api/compare/v1.4.0...v1.4.1)
 

data/README.md

@@ -2,7 +2,7 @@
 
 This is an implementation of the [Resource API](https://github.com/puppetlabs/puppet-specifications/blob/master/language/resource-api/README.md) proposal. Find a working example of a new-style provider in the [experimental puppetlabs-apt branch](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb). There is also the corresponding [type](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/type/apt_key2.rb), [provider](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb), and [new unit tests](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/spec/unit/puppet/provider/apt_key2/apt_key2_spec.rb) for 100% coverage.
 
-## Install the Resource API
+## Getting Started
 
 1. Download the [Puppet Development Kit](https://puppet.com/download-puppet-development-kit) (PDK) appropriate to your operating system and architecture.
 
@@ -47,7 +47,7 @@ $
 ```
 
 5. Create the required files for a new type and provider in the module by running `pdk new provider <provider_name>`
- 
+
 You will get the following response:
 
 ```
@@ -82,13 +82,13 @@ Puppet::ResourceApi.register_type(
   docs: <<-EOS,
       This type provides Puppet with the capabilities to manage ...
     EOS
-  attributes:   {
-    ensure:      {
+  attributes: {
+    ensure: {
       type:    'Enum[present, absent]',
       desc:    'Whether this apt key should be present or absent on the target system.',
       default: 'present',
     },
-    name:        {
+    name: {
       type:      'String',
       desc:      'The name of the resource you want to manage.',
       behaviour: :namevar,

data/lib/puppet/resource_api.rb

@@ -179,9 +179,18 @@ module Puppet::ResourceApi
           end
 
           # read-only values do not need type checking, but can have default values
-          if options[:behaviour] != :read_only
+          if options[:behaviour] != :read_only && options.key?(:default)
             if options.key? :default
-              defaultto options[:default]
+              if options[:default] == false
+                # work around https://tickets.puppetlabs.com/browse/PUP-2368
+                defaultto :false # rubocop:disable Lint/BooleanSymbol
+              elsif options[:default] == true
+                # work around https://tickets.puppetlabs.com/browse/PUP-2368
+                defaultto :true # rubocop:disable Lint/BooleanSymbol
+              else
+                defaultto options[:default]
+              end
+              # defaultto options[:default]
             end
           end
 
@@ -195,11 +204,14 @@ module Puppet::ResourceApi
 
           if param_or_property == :newproperty
             define_method(:should) do
-              if type.is_a? Puppet::Pops::Types::PBooleanType
-                # work around https://tickets.puppetlabs.com/browse/PUP-2368
-                rs_value ? :true : :false # rubocop:disable Lint/BooleanSymbol
-              elsif name == :ensure && rs_value.is_a?(String)
+              if name == :ensure && rs_value.is_a?(String)
                 rs_value.to_sym
+              elsif rs_value == false
+                # work around https://tickets.puppetlabs.com/browse/PUP-2368
+                :false # rubocop:disable Lint/BooleanSymbol
+              elsif rs_value == true
+                # work around https://tickets.puppetlabs.com/browse/PUP-2368
+                :true # rubocop:disable Lint/BooleanSymbol
               else
                 rs_value
               end
@@ -521,6 +533,12 @@ MESSAGE
       # the correct types, e.g. "1" (a string) to 1 (an integer)
       cleaned_value, error_msg = try_mungify(type, value, error_msg_prefix)
       raise Puppet::ResourceError, error_msg if error_msg
+    elsif value == :false # rubocop:disable Lint/BooleanSymbol
+      # work around https://tickets.puppetlabs.com/browse/PUP-2368
+      cleaned_value = false
+    elsif value == :true # rubocop:disable Lint/BooleanSymbol
+      # work around https://tickets.puppetlabs.com/browse/PUP-2368
+      cleaned_value = true
     else
       # Every other time, we can use the values as is
       cleaned_value = value

data/lib/puppet/resource_api/version.rb

@@ -1,5 +1,5 @@
 module Puppet
   module ResourceApi
-    VERSION = '1.4.1'.freeze
+    VERSION = '1.4.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppet-resource_api
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - David Schmitt
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-20 00:00:00.000000000 Z
+date: 2018-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hocon