puppet-lint 4.3.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe9befaf41d2eaff6047b13dc030938b29002ce29382312862571133e1b75138
-  data.tar.gz: 655bc012b63ae3659262cfeea02c4e9b35c1af65a1831c5df839b30ea3307934
+  metadata.gz: 200023e7df4e5c5ad823fba0f940ee2ad73ae5d05eb04796e83dbcc118e2a47e
+  data.tar.gz: 3a14e87f1f69fdc2495068d246609af04c81e6610e4e878a669ab9b8262f1265
 SHA512:
-  metadata.gz: e6684deef64a18afb534b4004106fc946bcb67e4f8d406912b2bdf0851c495b1feaf35938268c7f1854686e2114c803f7f31b37a9d61df85d175cbf8eb8df14d
-  data.tar.gz: 92f9e92fb27df8abe9b28c116eefa9f901a64b13b6e0de98c6a39cd58451f726ceb142e85daa1958fad2d88388505634d18bee02cc242e023e1bdab51b5a9943
+  metadata.gz: 5bad4d387c8695aa0bc3fca805a819c5af1e0c410953f61093ec77a1139848c1b284a53aa238bed450ba5195d9af8736a2ba6a9dfec97ceca09bdaca08da80bf
+  data.tar.gz: 4d26e6093580630b0b838562efdc2d2e9492d8185652a469aaca3fdb48cec0f88b9d02367cacc595b46d10d08745d4b76874d304a891e1e265c35ffb01625752

data/lib/puppet-lint/checkplugin.rb

@@ -55,7 +55,9 @@ class PuppetLint::CheckPlugin
   #
   # Returns an Array of PuppetLint::Lexer::Token objects.
   def tokens
-    PuppetLint::Data.tokens
+    # When called from a plugins `check` method, the tokens array returned should be a (shallow) copy
+    called_from_check = (caller_locations(1..1).first.base_label == 'check')
+    PuppetLint::Data.tokens(duplicate: called_from_check)
   end
 
   def add_token(index, token)
@@ -180,9 +182,9 @@ class PuppetLint::CheckPlugin
   def default_info
     @default_info ||= {
       check: self.class.const_get(:NAME),
-      fullpath: fullpath,
-      path: path,
-      filename: filename
+      fullpath:,
+      path:,
+      filename:
     }
   end
 

data/lib/puppet-lint/checks.rb

@@ -36,7 +36,7 @@ class PuppetLint::Checks
       problems << {
         kind: :error,
         check: :syntax,
-        message: message,
+        message:,
         line: e.line_no,
         column: e.column,
         fullpath: PuppetLint::Data.fullpath,
@@ -54,10 +54,11 @@ class PuppetLint::Checks
   #
   # Returns an Array of problem Hashes.
   def run(fileinfo, data)
-    load_data(fileinfo, data)
-
     checks_run = []
     if File.extname(fileinfo).downcase.match?(%r{\.ya?ml$})
+      PuppetLint::Data.path = fileinfo
+      PuppetLint::Data.manifest_lines = data.split("\n", -1)
+
       enabled_checks.select { |check| YAML_COMPATIBLE_CHECKS.include?(check) }.each do |check|
         klass = PuppetLint.configuration.check_object[check].new
         # FIXME: shadowing #problems
@@ -65,6 +66,8 @@ class PuppetLint::Checks
         checks_run << [klass, problems]
       end
     else
+      load_data(fileinfo, data)
+
       enabled_checks.each do |check|
         klass = PuppetLint.configuration.check_object[check].new
         # FIXME: shadowing #problems

data/lib/puppet-lint/configuration.rb

@@ -48,7 +48,7 @@ class PuppetLint::Configuration
   # Signature
   #
   #   <option>=(value)
-  def method_missing(method, *args, &_block)
+  def method_missing(method, *args, &)
     super unless method.to_s =~ %r{^(\w+)=?$}
 
     option = Regexp.last_match(1)

data/lib/puppet-lint/data.rb

@@ -38,37 +38,14 @@ class PuppetLint::Data
       @defaults_indexes = nil
     end
 
-    # @api private
-    def ruby1?
-      @ruby1 = RbConfig::CONFIG['MAJOR'] == '1' if @ruby1.nil?
-      @ruby1
-    end
-
     # Get the tokenised manifest.
     #
+    # @param duplicate [Boolean] if true, returns a duplicate of the token array.
     # @return [Array[PuppetLint::Lexer::Token]]
     #
     # @api public
-    def tokens
-      calling_method = if ruby1?
-                         begin
-                           caller[0][%r{`.*'}][1..-2] # rubocop:disable Performance/Caller
-                         rescue NoMethodError
-                           caller[1][%r{`.*'}][1..-2] # rubocop:disable Performance/Caller
-                         end
-                       else
-                         begin
-                           caller(0..0).first[%r{`.*'}][1..-2]
-                         rescue NoMethodError
-                           caller(1..1).first[%r{`.*'}][1..-2]
-                         end
-                       end
-
-      if calling_method == 'check'
-        @tokens.dup
-      else
-        @tokens
-      end
+    def tokens(duplicate: false)
+      duplicate ? @tokens.dup : @tokens
     end
 
     # Add new token.
@@ -359,7 +336,7 @@ class PuppetLint::Data
                 end: i + j + 1,
                 tokens: tokens[i..(i + j + 1)],
                 param_tokens: param_tokens(tokens[i..(i + j + 1)]),
-                type: type,
+                type:,
                 name_token: token.next_code_token,
                 inherited_token: inherited_class
               }

data/lib/puppet-lint/lexer/string_slurper.rb

@@ -6,12 +6,12 @@ class PuppetLint::Lexer
   class StringSlurper
     attr_accessor :scanner, :results, :interp_stack
 
-    START_INTERP_PATTERN = %r{\$\{}.freeze
-    END_INTERP_PATTERN = %r{\}}.freeze
-    END_STRING_PATTERN = %r{(\A|[^\\])(\\\\)*"}.freeze
-    UNENC_VAR_PATTERN = %r{(\A|[^\\])\$(::)?(\w+(-\w+)*::)*\w+(-\w+)*}.freeze
-    ESC_DQUOTE_PATTERN = %r{\\+"}.freeze
-    LBRACE_PATTERN = %r{\{}.freeze
+    START_INTERP_PATTERN = %r{\$\{}
+    END_INTERP_PATTERN = %r{\}}
+    END_STRING_PATTERN = %r{(\A|[^\\])(\\\\)*"}
+    UNENC_VAR_PATTERN = %r{(\A|[^\\])\$(::)?(\w+(-\w+)*::)*\w+(-\w+)*}
+    ESC_DQUOTE_PATTERN = %r{\\+"}
+    LBRACE_PATTERN = %r{\{}
 
     def initialize(string)
       @scanner = StringScanner.new(string)

data/lib/puppet-lint/lexer.rb

@@ -111,9 +111,9 @@ class PuppetLint::Lexer
   # \p{Zs} == ASCII + Unicode non-linebreaking whitespace
   WHITESPACE_RE = (RUBY_VERSION == '1.8.7') ? %r{[\t\v\f ]} : %r{[\t\v\f\p{Zs}]}
 
-  LINE_END_RE = %r{(?:\r\n|\r|\n)}.freeze
+  LINE_END_RE = %r{(?:\r\n|\r|\n)}
 
-  NAME_RE = %r{\A((?:(?:::)?[_a-z0-9][-\w]*)(?:::[a-z0-9][-\w]*)*)}.freeze
+  NAME_RE = %r{\A((?:(?:::)?[_a-z0-9][-\w]*)(?:::[a-z0-9][-\w]*)*)}
 
   # Internal: An Array of Arrays containing tokens that can be described by
   # a single regular expression.  Each sub-Array contains 2 elements, the
@@ -123,7 +123,44 @@ class PuppetLint::Lexer
     [:WHITESPACE, %r{\A(#{WHITESPACE_RE}+)}],
     # FIXME: Future breaking change, the following :TYPE tokens conflict with
     #        the :TYPE keyword token.
-    [:TYPE, %r{\A(Any|Array|Binary|Boolean|Callable|CatalogEntry|Class|Collection|Data|Default|Enum|Error|Float|Hash|Integer|NotUndef|Numeric|Optional|Pattern|Regexp|Resource|Runtime|Scalar|Sensitive|String|Struct|Tuple|Type|Undef|Variant)\b}], # rubocop:disable Layout/LineLength
+    [:TYPE, %r{\A(
+      Any|
+      Array|
+      Binary|
+      Boolean|
+      Callable|
+      CatalogEntry|
+      Class|
+      Collection|
+      Data|
+      Default|
+      Enum|
+      Error|
+      Float|
+      Hash|
+      Integer|
+      Iterable|
+      Iterator|
+      NotUndef|
+      Numeric|
+      Optional|
+      Pattern|
+      Regexp|
+      Resource|
+      RichData|
+      Runtime|
+      Scalar|
+      ScalarData|
+      SemVer|
+      SemVerRange|
+      Sensitive|
+      String|
+      Struct|
+      Tuple|
+      Type|
+      Undef|
+      Variant
+    )\b}x],
     [:CLASSREF, %r{\A(((::){0,1}[A-Z][-\w]*)+)}],
     [:NUMBER, %r{\A\b((?:0[xX][0-9A-Fa-f]+|0?\d+(?:\.\d+)?(?:[eE]-?\d+)?))\b}],
     [:FUNCTION_NAME, %r{#{NAME_RE}(?=\()}],

data/lib/puppet-lint/plugins/check_classes/arrow_on_right_operand_line.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:arrow_on_right_operand_line) do
         message: "arrow should be on the right operand's line",
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Test the manifest tokens for chaining arrow that is on the line of the left operand when the right operand is on another line.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#chaining-arrow-syntax',
       )

data/lib/puppet-lint/plugins/check_comments/slash_comments.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:slash_comments) do
         message: '// comment found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any comments started with slashes (//) and record a warning for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#comments',
       )

data/lib/puppet-lint/plugins/check_comments/star_comments.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:star_comments) do
         message: '/* */ comment found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any comments encapsulated with slash-asterisks (/* */) and record a warning for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#comments',
       )

data/lib/puppet-lint/plugins/check_nodes/unquoted_node_name.rb

@@ -31,7 +31,7 @@ PuppetLint.new_check(:unquoted_node_name) do
           message: 'unquoted node name found',
           line: token.line,
           column: token.column,
-          token: token,
+          token:,
           description: 'Check the manifest for unquoted node names and record a warning for each instance found.',
           help_uri: nil,
         )

data/lib/puppet-lint/plugins/check_resources/ensure_first_param.rb

@@ -20,7 +20,7 @@ PuppetLint.new_check(:ensure_first_param) do
         message: "ensure found on line but it's not the first attribute",
         line: ensure_token.line,
         column: ensure_token.column,
-        resource: resource,
+        resource:,
         description: 'Check the tokens of each resource instance for an ensure parameter and if ' \
                      'found, check that it is the first parameter listed.  If it is not the first parameter, record a warning.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#attribute-ordering',

data/lib/puppet-lint/plugins/check_resources/ensure_not_symlink_target.rb

@@ -20,7 +20,7 @@ PuppetLint.new_check(:ensure_not_symlink_target) do
           line: value_token.line,
           column: value_token.column,
           param_token: ensure_token,
-          value_token: value_token,
+          value_token:,
           description: 'Check the tokens of each File resource instance for an ensure parameter and ' \
                        'record a warning if the value of that parameter looks like a symlink target (starts with a \'/\').',
           help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#symbolic-links',

data/lib/puppet-lint/plugins/check_resources/file_mode.rb

@@ -6,7 +6,7 @@
 MSG = 'mode should be represented as a 4 digit octal value or symbolic mode'.freeze
 SYM_RE = '([ugoa]*[-=+][-=+rstwxXugo]*)(,[ugoa]*[-=+][-=+rstwxXugo]*)*'.freeze
 IGNORE_TYPES = Set[:VARIABLE, :UNDEF, :FUNCTION_NAME]
-MODE_RE = %r{\A([0-7]{4}|#{SYM_RE})\Z}.freeze
+MODE_RE = %r{\A([0-7]{4}|#{SYM_RE})\Z}
 
 PuppetLint.new_check(:file_mode) do
   def check

data/lib/puppet-lint/plugins/check_resources/unquoted_resource_title.rb

@@ -12,7 +12,7 @@ PuppetLint.new_check(:unquoted_resource_title) do
         message: 'unquoted resource title',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any resource titles / namevars that are not quoted and record a warning for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#resource-names',
       )

data/lib/puppet-lint/plugins/check_strings/double_quoted_strings.rb

@@ -3,7 +3,7 @@
 # each instance found.
 #
 # https://puppet.com/docs/puppet/latest/style_guide.html#quoting
-ESCAPE_CHAR_RE = %r{(\\\$|\\"|\\'|'|\r|\t|\\t|\\s|\n|\\n|\\\\)}.freeze
+ESCAPE_CHAR_RE = %r{(\\\$|\\"|\\'|'|\r|\t|\\t|\\s|\n|\\n|\\\\)}
 
 PuppetLint.new_check(:double_quoted_strings) do
   def check
@@ -18,7 +18,7 @@ PuppetLint.new_check(:double_quoted_strings) do
         message: 'double quoted string containing no variables',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any double quoted strings that don\'t ' \
                      'contain any variables or common escape characters and record a warning for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#quoting',

data/lib/puppet-lint/plugins/check_strings/only_variable_string.rb

@@ -27,8 +27,8 @@ PuppetLint.new_check(:only_variable_string) do
               message: 'string containing only a variable',
               line: var_token.line,
               column: var_token.column,
-              start_token: start_token,
-              var_token: var_token,
+              start_token:,
+              var_token:,
               end_token: eos_token,
               description: 'Check the manifest tokens for double quoted strings that contain a single variable only and record a warning for each instance found.',
               help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#quoting',

data/lib/puppet-lint/plugins/check_strings/puppet_url_without_modules.rb

@@ -19,7 +19,7 @@ PuppetLint.new_check(:puppet_url_without_modules) do
         message: 'puppet:// URL without modules/ found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any puppet:// URL strings where the path section doesn\'t start with modules/ and record a warning for each instance found.',
         help_uri: nil,
       )

data/lib/puppet-lint/plugins/check_strings/quoted_booleans.rb

@@ -18,7 +18,7 @@ PuppetLint.new_check(:quoted_booleans) do
         message: 'quoted boolean value found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any double or single quoted strings containing only a boolean value and record a warning for each instance found.',
         help_uri: nil,
       )

data/lib/puppet-lint/plugins/check_strings/variables_not_enclosed.rb

@@ -25,7 +25,7 @@ PuppetLint.new_check(:variables_not_enclosed) do
         message: 'variable not enclosed in {}',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for any variables in a string that have not been enclosed by braces ({}) and record a warning for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#quoting',
       )

data/lib/puppet-lint/plugins/check_whitespace/hard_tabs.rb

@@ -16,7 +16,7 @@ PuppetLint.new_check(:hard_tabs) do
         message: 'tab character found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the raw manifest string for lines containing hard tab characters and record an error for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#spacing-indentation-and-whitespace',
       )

data/lib/puppet-lint/plugins/check_whitespace/space_before_arrow.rb

@@ -51,8 +51,8 @@ PuppetLint.new_check(:space_before_arrow) do
         notify(
           :warning,
           message: "there should be a single space before '=>' on line #{line}, column #{column}",
-          line: line,
-          column: column,
+          line:,
+          column:,
           token: prev_token,
         )
       end

data/lib/puppet-lint/plugins/check_whitespace/trailing_whitespace.rb

@@ -18,7 +18,7 @@ PuppetLint.new_check(:trailing_whitespace) do
         message: 'trailing whitespace found',
         line: token.line,
         column: token.column,
-        token: token,
+        token:,
         description: 'Check the manifest tokens for lines ending with whitespace and record an error for each instance found.',
         help_uri: 'https://puppet.com/docs/puppet/latest/style_guide.html#spacing-indentation-and-whitespace',
       )

data/lib/puppet-lint/plugins/legacy_facts/legacy_facts.rb

@@ -184,8 +184,8 @@ PuppetLint.new_check(:legacy_facts) do
         message: "legacy fact '#{fact_name}'",
         line: token.line,
         column: token.column,
-        token: token,
-        fact_name: fact_name
+        token:,
+        fact_name:
       }
     end
   end

data/lib/puppet-lint/plugins/top_scope_facts/top_scope_facts.rb

@@ -38,7 +38,7 @@ PuppetLint.new_check(:top_scope_facts) do
         message: 'top scope fact instead of facts hash',
         line: token.line,
         column: token.column,
-        token: token
+        token:
       }
     end
   end

data/lib/puppet-lint/plugins.rb

@@ -75,7 +75,7 @@ class PuppetLint::Plugins
   end
 end
 
-Dir[File.expand_path('plugins/**/*.rb', File.dirname(__FILE__))].sort.each do |file|
+Dir[File.expand_path('plugins/**/*.rb', File.dirname(__FILE__))].each do |file|
   require file
 end
 

data/lib/puppet-lint/report/codeclimate.rb

@@ -25,7 +25,7 @@ class PuppetLint::Report
             check_name: message[:check],
             description: message[:message],
             categories: [:Style],
-            severity: severity,
+            severity:,
             location: {
               path: message[:path],
               lines: {

data/lib/puppet-lint/tasks/puppet-lint.rb

@@ -27,7 +27,7 @@ class PuppetLint::RakeTask < Rake::TaskLib
   #
   #   PuppetLint::RakeTask.new
   # rubocop:disable Lint/MissingSuper
-  def initialize(*args, &task_block)
+  def initialize(*args, &)
     @name = args.shift || :lint
     @pattern = DEFAULT_PATTERN
     @with_filename = true
@@ -35,7 +35,7 @@ class PuppetLint::RakeTask < Rake::TaskLib
     @only_checks = []
     @ignore_paths = []
 
-    define(args, &task_block)
+    define(args, &)
   end
 
   def define(args, &task_block)

data/lib/puppet-lint/tasks/release_test.rb

@@ -27,7 +27,7 @@ def run_cmd(message, *cmd)
   [output.strip, status.success?]
 end
 
-def with_puppet_lint_head(&block)
+def with_puppet_lint_head(&)
   print('  Updating Gemfile to use puppet-lint HEAD... ')
 
   buffer = Parser::Source::Buffer.new('Gemfile')
@@ -49,7 +49,7 @@ def with_puppet_lint_head(&block)
 
   puts 'Done'
 
-  Bundler.with_clean_env(&block)
+  Bundler.with_clean_env(&)
 
   run_cmd('Restoring Gemfile', 'git', 'checkout', '--', 'Gemfile')
 end

data/lib/puppet-lint/version.rb

@@ -1,3 +1,3 @@
 class PuppetLint
-  VERSION = '4.3.0'.freeze
+  VERSION = '5.1.0'.freeze
 end

data/lib/puppet-lint.rb

@@ -11,7 +11,6 @@ require 'puppet-lint/data'
 require 'puppet-lint/checks'
 require 'puppet-lint/report/github'
 require 'puppet-lint/bin'
-require 'puppet-lint/monkeypatches'
 
 class PuppetLint::NoCodeError < StandardError; end
 
@@ -250,11 +249,11 @@ class PuppetLint
   #     def check
   #     end
   #   end
-  def self.new_check(name, &block)
+  def self.new_check(name, &)
     class_name = name.to_s.split('_').map(&:capitalize).join
     klass = PuppetLint.const_set(:"Check#{class_name}", Class.new(PuppetLint::CheckPlugin))
     klass.const_set(:NAME, name)
-    klass.class_exec(&block)
+    klass.class_exec(&)
     PuppetLint.configuration.add_check(name, klass)
     PuppetLint::Data.ignore_overrides[name] ||= {}
   end

data/rubocop_baseline.yml

@@ -6,7 +6,7 @@ AllCops:
   NewCops: enable
   ExtraDetails: true
   DisplayStyleGuide: true
-  TargetRubyVersion: '2.7'
+  TargetRubyVersion: '3.1'
   DisplayCopNames: true
   SuggestExtensions: false
   Exclude:

data/spec/acceptance/puppet_lint_spec.rb

@@ -43,4 +43,11 @@ describe 'When executing puppet-lint' do
       expect(result[:stdout]).to have_warnings(2)
     end
   end
+
+  context 'with a YAML file provided' do
+    it 'returns zero errors' do
+      result = puppet_lint([File.join(manifest_root, 'parseable.yaml')])
+      expect(result[:stdout]).to have_errors(0)
+    end
+  end
 end

data/spec/fixtures/test/manifests/parseable.yaml

@@ -0,0 +1,3 @@
+---
+heredoc: |
+ contains $

data/spec/spec_helper.rb

@@ -22,6 +22,7 @@ end
 
 require 'puppet-lint'
 require 'rspec/its'
+require 'pp'
 begin
   require 'rspec/json_expectations'
 rescue LoadError, SyntaxError
@@ -33,7 +34,7 @@ module RSpec::LintExampleGroup
     def initialize(method, message)
       @expected_problem = {
         kind: method.to_s.delete_prefix('contain_').to_sym,
-        message: message
+        message:
       }
       @description = ["contain a #{@expected_problem[:kind]}"]
     end
@@ -107,7 +108,7 @@ module RSpec::LintExampleGroup
     end
   end
 
-  def method_missing(method, *args, &block)
+  def method_missing(method, *args, &)
     return HaveProblem.new(method, args.first) if method.to_s.start_with?('contain_')
 
     super

data/spec/unit/puppet-lint/checkplugin_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+class DummyCheckPlugin < PuppetLint::CheckPlugin
+  def check
+    # Since we're calling `tokens` from a `check` method, we should get our own Array object.
+    # If we add an extra token to it, PuppetLint::Data.tokens should remain unchanged.
+    tokens << :extra_token
+  end
+
+  def fix
+    tokens << :fix_token
+  end
+end
+
+describe PuppetLint::CheckPlugin do
+  before(:each) do
+    PuppetLint::Data.tokens = [:token1, :token2, :token3]
+  end
+
+  it 'returns a duplicate of the token array when called from check' do
+    plugin = DummyCheckPlugin.new
+
+    plugin.check
+
+    # Verify that the global token array remains unchanged.
+    expect(PuppetLint::Data.tokens).to eq([:token1, :token2, :token3])
+  end
+
+  it 'other methods can modify the tokens array' do
+    plugin = DummyCheckPlugin.new
+
+    plugin.fix
+
+    expect(PuppetLint::Data.tokens).to eq([:token1, :token2, :token3, :fix_token])
+  end
+end

data/spec/unit/puppet-lint/checks_spec.rb

@@ -223,11 +223,6 @@ describe PuppetLint::Checks do
       allow(File).to receive(:extname).with(fileinfo).and_return('.yaml')
     end
 
-    it 'loads the yaml data' do
-      expect(instance).to receive(:load_data).with(fileinfo, data).and_call_original # rubocop: disable RSpec/SubjectStub
-      instance.run(fileinfo, data)
-    end
-
     context 'when there are checks enabled' do
       let(:enabled_checks) { [:legacy_facts] }
       let(:enabled_check_classes) { enabled_checks.map { |r| PuppetLint.configuration.check_object[r] } }

data/spec/unit/puppet-lint/lexer_spec.rb

@@ -1392,6 +1392,12 @@ END
 
     it_behaves_like 'a type matcher', 'Error'
     it_behaves_like 'a type matcher', 'Binary'
+    it_behaves_like 'a type matcher', 'Iterable'
+    it_behaves_like 'a type matcher', 'Iterator'
+    it_behaves_like 'a type matcher', 'RichData'
+    it_behaves_like 'a type matcher', 'ScalarData'
+    it_behaves_like 'a type matcher', 'SemVer'
+    it_behaves_like 'a type matcher', 'SemVerRange'
   end
 
   context ':HEREDOC without interpolation' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 5.1.0
 platform: ruby
 authors:
 - Tim Sharpe
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-06 00:00:00.000000000 Z
+date: 2025-09-25 00:00:00.000000000 Z
 dependencies: []
 description: "    Checks your Puppet manifests against the Puppetlabs style guide
   and alerts you to any discrepancies.\n"
@@ -34,7 +34,6 @@ files:
 - lib/puppet-lint/lexer.rb
 - lib/puppet-lint/lexer/string_slurper.rb
 - lib/puppet-lint/lexer/token.rb
-- lib/puppet-lint/monkeypatches.rb
 - lib/puppet-lint/optparser.rb
 - lib/puppet-lint/plugins.rb
 - lib/puppet-lint/plugins/check_classes/arrow_on_right_operand_line.rb
@@ -95,6 +94,7 @@ files:
 - spec/fixtures/test/manifests/init.pp
 - spec/fixtures/test/manifests/malformed.pp
 - spec/fixtures/test/manifests/mismatched_control_comment.pp
+- spec/fixtures/test/manifests/parseable.yaml
 - spec/fixtures/test/manifests/top_scope_variables.pp
 - spec/fixtures/test/manifests/two_warnings.pp
 - spec/fixtures/test/manifests/unterminated_control_comment.pp
@@ -105,6 +105,7 @@ files:
 - spec/spec_helper_acceptance.rb
 - spec/spec_helper_acceptance_local.rb
 - spec/unit/puppet-lint/bin_spec.rb
+- spec/unit/puppet-lint/checkplugin_spec.rb
 - spec/unit/puppet-lint/checks_spec.rb
 - spec/unit/puppet-lint/configuration_spec.rb
 - spec/unit/puppet-lint/data_spec.rb
@@ -165,14 +166,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.27
 signing_key:
 specification_version: 4
 summary: Ensure your Puppet manifests conform with the Puppetlabs style guide

data/lib/puppet-lint/monkeypatches.rb

@@ -1,51 +0,0 @@
-begin
-  '%{test}' % { test: 'replaced' } == 'replaced'
-rescue StandardError
-  # monkeypatch String#% into Ruby 1.8.7
-  class String
-    Percent = instance_method(:%) unless defined?(Percent)
-
-    def %(*a, &b)
-      a.flatten!
-
-      string = case a.last
-               when Hash
-                 expand(a.pop)
-               else
-                 self
-               end
-
-      if a.empty?
-        string
-      else
-        Percent.bind_call(string, a, &b)
-      end
-    end
-
-    def expand!(vars = {})
-      loop do
-        changed = false
-        vars.each do |var, value|
-          var = var.to_s
-          var.gsub!(%r{[^a-zA-Z0-9_]}, '')
-          changed = gsub!(%r{%\{#{var}\}}, value.to_s)
-        end
-        break unless changed
-      end
-      self
-    end
-
-    def expand(opts = {})
-      dup.expand!(opts)
-    end
-  end
-end
-
-unless String.respond_to?(:prepend)
-  # monkeypatch String#prepend into Ruby 1.8.7
-  class String
-    def prepend(lead)
-      replace("#{lead}#{self}")
-    end
-  end
-end