puppet-lint 4.2.0 → 4.2.2

data/spec/unit/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb

@@ -8,7 +8,7 @@ describe 'unquoted_resource_title' do
       let(:code) { "file { 'foo': }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -16,7 +16,7 @@ describe 'unquoted_resource_title' do
       let(:code) { 'file { foo: }' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -33,7 +33,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -46,7 +46,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -65,7 +65,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -80,7 +80,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -92,7 +92,7 @@ describe 'unquoted_resource_title' do
       let(:code) { "file { ['foo', 'bar']: }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -110,7 +110,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -125,7 +125,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -147,7 +147,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
   end
@@ -165,7 +165,7 @@ describe 'unquoted_resource_title' do
       let(:code) { 'file { foo: }' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -193,7 +193,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -225,7 +225,7 @@ describe 'unquoted_resource_title' do
       end
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do

data/spec/unit/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb

@@ -8,7 +8,7 @@ describe 'double_quoted_strings' do
       let(:code) { "exec { \"/usr/bin/wget -O - '${source}' | /usr/bin/apt-key add -\": }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -16,7 +16,7 @@ describe 'double_quoted_strings' do
       let(:code) { "\"aoeu\" '${foo}'" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -28,7 +28,7 @@ describe 'double_quoted_strings' do
       let(:code) { "'grep \"status=sent\" /var/log/mail.log'" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -36,7 +36,7 @@ describe 'double_quoted_strings' do
       let(:code) { "service { 'foo': } # \"bar\"" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -44,16 +44,16 @@ describe 'double_quoted_strings' do
       let(:code) { %("foo\n") }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
     context 'double quoted string with backslash for continuation' do
       let(:code) do
         <<-END
-          class puppet::master::maintenance (
+          class puppet::server::maintenance (
           ) {
-            cron { 'puppet_master_reports_cleanup':
+            cron { 'puppet_server_reports_cleanup':
               command     => "/usr/bin/find /var/lib/puppet/reports -type f -mtime +15 \
                              -delete && /usr/bin/find /var/lib/puppet/reports -mindepth 1 \
                              -empty -type d -delete",
@@ -65,7 +65,7 @@ describe 'double_quoted_strings' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -73,7 +73,7 @@ describe 'double_quoted_strings' do
       let(:code) { "class { 'foo': boolFlag => \"true\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -85,7 +85,7 @@ describe 'double_quoted_strings' do
       let(:code) { "class { 'foo': boolFlag => \"false\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -108,7 +108,7 @@ describe 'double_quoted_strings' do
       end
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -116,7 +116,7 @@ describe 'double_quoted_strings' do
       let(:code) { %( $ztring = "this string contains \l random escape" ) }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -128,7 +128,7 @@ describe 'double_quoted_strings' do
       let(:code) { "\"this 'string' 'has' lots of 'quotes'\"" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
 
@@ -136,7 +136,7 @@ describe 'double_quoted_strings' do
       let(:code) { %(notify { "'foo'": }) }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
     end
   end
@@ -154,7 +154,7 @@ describe 'double_quoted_strings' do
       let(:code) { "exec { \"/usr/bin/wget -O - '${source}' | /usr/bin/apt-key add -\": }" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not modify the manifest' do
@@ -166,7 +166,7 @@ describe 'double_quoted_strings' do
       let(:code) { "\"sed -i 's/^;*[[:space:]]*${name}[[:space:]]*=.*$/${name} = ${value}/g' file\"" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not modify the manifest' do
@@ -178,7 +178,7 @@ describe 'double_quoted_strings' do
       let(:code) { "\"aoeu\" '${foo}'" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -194,7 +194,7 @@ describe 'double_quoted_strings' do
       let(:code) { "\"this 'string' 'has' lots of 'quotes'\"" }
 
       it 'does not detect any problems' do
-        expect(problems).to have(0).problems
+        expect(problems).to be_empty
       end
 
       it 'does not modify the manifest' do

data/spec/unit/puppet-lint/plugins/check_strings/only_variable_string_spec.rb

@@ -8,7 +8,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo[0]}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -32,7 +32,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo[0][aoeuaoeu][bar][999]}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -69,7 +69,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -85,7 +85,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo[0]}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -101,7 +101,7 @@ describe 'only_variable_string' do
       let(:code) { '"${foo[0][aoeuaoeu][bar][999]}"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do

data/spec/unit/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb

@@ -7,7 +7,7 @@ describe 'puppet_url_without_modules' do
     let(:code) { "'puppet:///modules/foo'" }
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -16,7 +16,7 @@ describe 'puppet_url_without_modules' do
       let(:code) { "'puppet:///foo'" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -38,7 +38,7 @@ describe 'puppet_url_without_modules' do
       let(:code) { "'puppet:///foo'" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -55,7 +55,7 @@ describe 'puppet_url_without_modules' do
     let(:code) { File.read('spec/fixtures/test/manifests/url_interpolation.pp') }
 
     it 'detects several problems' do
-      expect(problems).to have(4).problem
+      expect(problems.size).to eq(4)
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb

@@ -8,7 +8,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => 'false' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => 'true' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -32,7 +32,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => \"true\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -44,7 +44,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => \"false\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -66,7 +66,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => 'false' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -82,7 +82,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => 'true' }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -98,7 +98,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => \"true\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -114,7 +114,7 @@ describe 'quoted_booleans' do
       let(:code) { "class { 'foo': boolFlag => \"false\" }" }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do

data/spec/unit/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb

@@ -7,7 +7,7 @@ describe 'single_quote_string_with_variables' do
     let(:code) { "\"aoeu\" '${foo}'" }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates an error' do
@@ -26,7 +26,7 @@ describe 'single_quote_string_with_variables' do
       END
     end
 
-    it { expect(problems).to have(0).problem }
+    it { expect(problems.size).to eq(0) }
   end
 
   context 'single quoted inline epp with dollar signs has no problems' do
@@ -40,6 +40,6 @@ describe 'single_quote_string_with_variables' do
       END
     end
 
-    it { expect(problems).to have(0).problem }
+    it { expect(problems.size).to eq(0) }
   end
 end

data/spec/unit/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -8,7 +8,7 @@ describe 'variables_not_enclosed' do
       let(:code) { '" $gronk"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -20,7 +20,7 @@ describe 'variables_not_enclosed' do
       let(:code) { ("'groovy'\n" * 20) + '" $gronk"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'creates a warning' do
@@ -42,7 +42,7 @@ describe 'variables_not_enclosed' do
       let(:code) { '" $gronk"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -58,7 +58,7 @@ describe 'variables_not_enclosed' do
       let(:code) { ("'groovy'\n" * 20) + '" $gronk"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -74,7 +74,7 @@ describe 'variables_not_enclosed' do
       let(:code) { '"$foo-$bar"' }
 
       it 'only detects two problems' do
-        expect(problems).to have(2).problems
+        expect(problems.size).to eq(2)
       end
 
       it 'fixes the manifest' do
@@ -91,7 +91,7 @@ describe 'variables_not_enclosed' do
       let(:code) { %("$foo['bar'][2]something") }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do
@@ -107,7 +107,7 @@ describe 'variables_not_enclosed' do
       let(:code) { '"$hostname-keystore"' }
 
       it 'only detects a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems.size).to eq(1)
       end
 
       it 'fixes the manifest' do

data/spec/unit/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb

@@ -7,7 +7,7 @@ describe 'variable_contains_dash' do
     let(:code) { '$foo-bar' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -19,7 +19,7 @@ describe 'variable_contains_dash' do
     let(:code) { '" $foo-bar"' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do

data/spec/unit/puppet-lint/plugins/check_variables/variable_is_lowercase_spec.rb

@@ -7,7 +7,7 @@ describe 'variable_is_lowercase' do
     let(:code) { '$fooBar' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -19,7 +19,7 @@ describe 'variable_is_lowercase' do
     let(:code) { '$foobar' }
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -27,7 +27,7 @@ describe 'variable_is_lowercase' do
     let(:code) { %("${Integer(fact('memory.system.total_bytes'))}") }
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -35,7 +35,7 @@ describe 'variable_is_lowercase' do
     let(:code) { '"${fooBar}"' }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do
@@ -47,7 +47,7 @@ describe 'variable_is_lowercase' do
     let(:code) { '"${foobar}"' }
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 end

data/spec/unit/puppet-lint/plugins/check_whitespace/140chars_spec.rb

@@ -13,7 +13,7 @@ describe '140chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -27,7 +27,7 @@ describe '140chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -41,7 +41,7 @@ describe '140chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -49,7 +49,7 @@ describe '140chars' do
     let(:code) { 'a' * 141 }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do

data/spec/unit/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb

@@ -13,7 +13,7 @@ describe '2sp_soft_tabs' do
     end
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates an error' do

data/spec/unit/puppet-lint/plugins/check_whitespace/80chars_spec.rb

@@ -17,7 +17,7 @@ describe '80chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -31,7 +31,7 @@ describe '80chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -45,7 +45,7 @@ describe '80chars' do
     end
 
     it 'does not detect any problems' do
-      expect(problems).to have(0).problems
+      expect(problems).to be_empty
     end
   end
 
@@ -53,7 +53,7 @@ describe '80chars' do
     let(:code) { 'a' * 81 }
 
     it 'only detects a single problem' do
-      expect(problems).to have(1).problem
+      expect(problems.size).to eq(1)
     end
 
     it 'creates a warning' do