puppet-lint 2.5.2 → 3.0.0

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_strings/quoted_booleans_spec.rb

@@ -7,11 +7,11 @@ describe 'quoted_booleans' do
     context 'quoted false' do
       let(:code) { "class { 'foo': boolFlag => 'false' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(28)
       end
     end
@@ -19,11 +19,11 @@ describe 'quoted_booleans' do
     context 'quoted true' do
       let(:code) { "class { 'foo': boolFlag => 'true' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(28)
       end
     end
@@ -31,11 +31,11 @@ describe 'quoted_booleans' do
     context 'double quoted true' do
       let(:code) { "class { 'foo': boolFlag => \"true\" }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(28)
       end
     end
@@ -43,37 +43,37 @@ describe 'quoted_booleans' do
     context 'double quoted false' do
       let(:code) { "class { 'foo': boolFlag => \"false\" }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(28)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context 'quoted false' do
       let(:code) { "class { 'foo': boolFlag => 'false' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(28)
       end
 
-      it 'should unquote the boolean' do
+      it 'unquotes the boolean' do
         expect(manifest).to eq("class { 'foo': boolFlag => false }")
       end
     end
@@ -81,15 +81,15 @@ describe 'quoted_booleans' do
     context 'quoted true' do
       let(:code) { "class { 'foo': boolFlag => 'true' }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(28)
       end
 
-      it 'should unquote the boolean' do
+      it 'unquotes the boolean' do
         expect(manifest).to eq("class { 'foo': boolFlag => true }")
       end
     end
@@ -97,15 +97,15 @@ describe 'quoted_booleans' do
     context 'double quoted true' do
       let(:code) { "class { 'foo': boolFlag => \"true\" }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(28)
       end
 
-      it 'should unquote the boolean' do
+      it 'unquotes the boolean' do
         expect(manifest).to eq("class { 'foo': boolFlag => true }")
       end
     end
@@ -113,15 +113,15 @@ describe 'quoted_booleans' do
     context 'double quoted false' do
       let(:code) { "class { 'foo': boolFlag => \"false\" }" }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(28)
       end
 
-      it 'should unquote the boolean' do
+      it 'unquotes the boolean' do
         expect(manifest).to eq("class { 'foo': boolFlag => false }")
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_strings/single_quote_string_with_variables_spec.rb

@@ -6,11 +6,11 @@ describe 'single_quote_string_with_variables' do
   context 'multiple strings in a line' do
     let(:code) { "\"aoeu\" '${foo}'" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1).in_column(8)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -7,11 +7,11 @@ describe 'variables_not_enclosed' do
     context 'variable not enclosed in {}' do
       let(:code) { '" $gronk"' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(3)
       end
     end
@@ -19,37 +19,37 @@ describe 'variables_not_enclosed' do
     context 'variable not enclosed in {} after many tokens' do
       let(:code) { ("'groovy'\n" * 20) + '" $gronk"' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(21).in_column(3)
       end
     end
   end
 
   context 'with fix enabled' do
-    before do
+    before(:each) do
       PuppetLint.configuration.fix = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.fix = false
     end
 
     context 'variable not enclosed in {}' do
       let(:code) { '" $gronk"' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(3)
       end
 
-      it 'should enclose the variable in braces' do
+      it 'encloses the variable in braces' do
         expect(manifest).to eq('" ${gronk}"')
       end
     end
@@ -57,15 +57,15 @@ describe 'variables_not_enclosed' do
     context 'variable not enclosed in {} after many tokens' do
       let(:code) { ("'groovy'\n" * 20) + '" $gronk"' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(21).in_column(3)
       end
 
-      it 'should enclose the variable in braces' do
+      it 'encloses the variable in braces' do
         expect(manifest).to eq(("'groovy'\n" * 20) + '" ${gronk}"')
       end
     end
@@ -73,16 +73,16 @@ describe 'variables_not_enclosed' do
     context 'variables not enclosed in {}, delimited by -' do
       let(:code) { '"$foo-$bar"' }
 
-      it 'should only detect two problems' do
+      it 'only detects two problems' do
         expect(problems).to have(2).problems
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(2)
         expect(problems).to contain_fixed(msg).on_line(1).in_column(7)
       end
 
-      it 'should enclose both variables in braces' do
+      it 'encloses both variables in braces' do
         expect(manifest).to eq('"${foo}-${bar}"')
       end
     end
@@ -90,15 +90,15 @@ describe 'variables_not_enclosed' do
     context 'variable with a hash or array reference not enclosed' do
       let(:code) { %("$foo['bar'][2]something") }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(2)
       end
 
-      it 'should enclose the variable with the references' do
+      it 'encloses the variable with the references' do
         expect(manifest).to eq(%("${foo['bar'][2]}something"))
       end
     end
@@ -106,15 +106,15 @@ describe 'variables_not_enclosed' do
     context 'unenclosed variable followed by a dash and then text' do
       let(:code) { '"$hostname-keystore"' }
 
-      it 'should only detect a single problem' do
+      it 'only detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the manifest' do
+      it 'fixes the manifest' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(2)
       end
 
-      it 'should enclose the variable but not the text' do
+      it 'encloses the variable but not the text' do
         expect(manifest).to eq('"${hostname}-keystore"')
       end
     end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_variables/variable_contains_dash_spec.rb

@@ -6,11 +6,11 @@ describe 'variable_contains_dash' do
   context 'a variable containing a dash' do
     let(:code) { '$foo-bar' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(1)
     end
   end
@@ -18,11 +18,11 @@ describe 'variable_contains_dash' do
   context 'variable containing a dash' do
     let(:code) { '" $foo-bar"' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(3)
     end
   end
@@ -30,7 +30,7 @@ describe 'variable_contains_dash' do
   context 'variable with an array reference containing a dash' do
     let(:code) { '$foo[bar-baz]' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to be_empty
     end
   end
@@ -38,7 +38,7 @@ describe 'variable_contains_dash' do
   context 'enclosed variable in a string followed by a dash' do
     let(:code) { '"${variable}-is-ok"' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to be_empty
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_variables/variable_is_lowercase_spec.rb

@@ -6,11 +6,11 @@ describe 'variable_is_lowercase' do
   context 'a variable containing an uppercase letter' do
     let(:code) { '$fooBar' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(1)
     end
   end
@@ -18,7 +18,7 @@ describe 'variable_is_lowercase' do
   context 'a variable containing only lowercase letters' do
     let(:code) { '$foobar' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -26,7 +26,7 @@ describe 'variable_is_lowercase' do
   context 'when typecasting inside an interpolation' do
     let(:code) { %("${Integer(fact('memory.system.total_bytes'))}") }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -34,11 +34,11 @@ describe 'variable_is_lowercase' do
   context 'when an interpolated variable contains an uppercase letter' do
     let(:code) { '"${fooBar}"' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(4)
     end
   end
@@ -46,7 +46,7 @@ describe 'variable_is_lowercase' do
   context 'when an interpolated variable only contains lowercase letters' do
     let(:code) { '"${foobar}"' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_whitespace/140chars_spec.rb

@@ -14,7 +14,7 @@ describe '140chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -28,7 +28,7 @@ describe '140chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -42,7 +42,7 @@ describe '140chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -50,11 +50,11 @@ describe '140chars' do
   context '141 character line' do
     let(:code) { 'a' * 141 }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(140)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_whitespace/2sp_soft_tabs_spec.rb

@@ -12,11 +12,11 @@ describe '2sp_soft_tabs' do
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(2).in_column(1)
     end
   end

data/spec/{puppet-lint → unit/puppet-lint}/plugins/check_whitespace/80chars_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe '80chars' do
-  before do
+  before(:each) do
     PuppetLint.configuration.send('enable_80chars')
   end
 
@@ -18,7 +18,7 @@ describe '80chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -32,7 +32,7 @@ describe '80chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -46,7 +46,7 @@ describe '80chars' do
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -54,11 +54,11 @@ describe '80chars' do
   context '81 character line' do
     let(:code) { 'a' * 81 }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(80)
     end
   end