puppet-lint 2.0.2 → 2.1.0

data/spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb

@@ -14,4 +14,28 @@ describe 'single_quote_string_with_variables' do
       expect(problems).to contain_error(msg).on_line(1).in_column(8)
     end
   end
+
+  context 'single quoted inline template with dollar signs has no problems' do
+    let (:code) {"
+      $list = ['one', 'two', 'three']
+      file { '/tmp/text.txt':
+        ensure  => file,
+        content => inline_template('<% $list.each |$item| { %><%= \"${item}\n\" %><% } %>'),
+      }
+    "}
+
+    it { expect(problems).to have(0).problem }
+  end
+
+  context 'single quoted inline epp with dollar signs has no problems' do
+    let (:code) {"
+      $list = ['one', 'two', 'three']
+      file { '/tmp/text.txt':
+        ensure  => file,
+        content => inline_template('<% @list.each do |item| %><%= @item %>\n<% end %>'),
+      }
+    "}
+
+    it { expect(problems).to have(0).problem }
+  end
 end

data/spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -69,5 +69,22 @@ describe 'variables_not_enclosed' do
         expect(manifest).to eq(("'groovy'\n" * 20) + '" ${gronk}"')
       end
     end
+
+    context 'variables not enclosed in {}, delimited by -' do
+      let(:code) { '"$foo-$bar"' }
+
+      it 'should only detect two problems' do
+        expect(problems).to have(2).problems
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(2)
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(7)
+      end
+
+      it 'should enclose both variables in braces' do
+        expect(manifest).to eq('"${foo}-${bar}"')
+      end
+    end
   end
 end

data/spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb

@@ -34,4 +34,12 @@ describe 'variable_contains_dash' do
       expect(problems).to be_empty
     end
   end
+
+  context 'enclosed variable in a string followed by a dash' do
+    let(:code) { '"${variable}-is-ok"' }
+
+    it 'should not detect any problems' do
+      expect(problems).to be_empty
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,11 @@
 require 'puppet-lint'
 require 'rspec/its'
 require 'rspec/collection_matchers'
+begin
+  require 'rspec/json_expectations'
+rescue SyntaxError
+  puts 'rspec/json_expectations is not available'
+end
 
 module RSpec
   module LintExampleGroup

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: puppet-lint
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Tim Sharpe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: github_changelog_generator
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2016-12-30 00:00:00.000000000 Z
+dependencies: []
 description: |-
   Checks your Puppet manifests against the Puppetlabs
     style guide and alerts you to any discrepancies.
@@ -74,6 +60,7 @@ files:
 - spec/fixtures/test/manifests/ignore_reason.pp
 - spec/fixtures/test/manifests/init.pp
 - spec/fixtures/test/manifests/malformed.pp
+- spec/fixtures/test/manifests/mismatched_control_comment.pp
 - spec/fixtures/test/manifests/url_interpolation.pp
 - spec/fixtures/test/manifests/warning.pp
 - spec/puppet-lint/bin_spec.rb
@@ -83,7 +70,9 @@ files:
 - spec/puppet-lint/lexer_spec.rb
 - spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
 - spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb
+- spec/puppet-lint/plugins/check_classes/code_on_top_scope_spec.rb
 - spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/name_contains_uppercase_spec.rb
 - spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
 - spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
 - spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
@@ -148,6 +137,7 @@ test_files:
 - spec/fixtures/test/manifests/ignore_reason.pp
 - spec/fixtures/test/manifests/init.pp
 - spec/fixtures/test/manifests/malformed.pp
+- spec/fixtures/test/manifests/mismatched_control_comment.pp
 - spec/fixtures/test/manifests/url_interpolation.pp
 - spec/fixtures/test/manifests/warning.pp
 - spec/puppet-lint/bin_spec.rb
@@ -157,7 +147,9 @@ test_files:
 - spec/puppet-lint/lexer_spec.rb
 - spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
 - spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb
+- spec/puppet-lint/plugins/check_classes/code_on_top_scope_spec.rb
 - spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/name_contains_uppercase_spec.rb
 - spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
 - spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
 - spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb