puppet-lint 2.0.0 → 2.0.1

data/spec/puppet-lint/plugins/check_comments/star_comments_spec.rb

@@ -29,6 +29,28 @@ describe 'star_comments' do
       PuppetLint.configuration.fix = false
     end
 
+    context 'multiline comment w/ no indents' do
+      let(:code) { "/* foo *
+ *     *
+ * bar */"}
+
+      let(:fixed) { "# foo *
+# *
+# bar"}
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(1)
+      end
+
+      it 'should convert the multiline comment' do
+        expect(manifest).to eq(fixed)
+      end
+    end
+ 
     context 'multiline comment w/ one line of content' do
       let(:code) { "
         /* foo

data/spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb

@@ -52,4 +52,23 @@ describe 'ensure_first_param' do
       expect(problems).to have(0).problems
     end
   end
+
+  context 'ensure as a hash key in classes does not need to be first' do
+    let(:code) { "
+      class thing {
+          class {'thang':
+              stuff => {
+                  'stuffing' => {
+                      ensure => 'present',
+                      blah   => 'bleah',
+                  }
+              },
+          }
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
 end

data/spec/puppet-lint/plugins/check_resources/file_mode_spec.rb

@@ -67,6 +67,70 @@ describe 'file_mode' do
         expect(problems).to have(0).problems
       end
     end
+
+    context '3 digit concat mode' do
+      let(:code) { "concat { 'foo': mode => '777' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(25)
+      end
+    end
+
+    context '4 digit concat mode' do
+      let(:code) { "concat { 'foo': mode => '0777' }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'concat mode as a variable' do
+      let(:code) { "concat { 'foo': mode => $concat_mode }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'symbolic concat mode' do
+      let(:code) { "concat { 'foo': mode => 'u=rw,og=r' }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'concat mode undef unquoted' do
+      let(:code) { "concat { 'foo': mode => undef }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'concat mode undef quoted' do
+      let(:code) { "concat { 'foo': mode => 'undef' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(25)
+      end
+    end
+
+    context 'mode as audit value' do
+      let(:code) { "concat { '/etc/passwd': audit => [ owner, mode ], }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
   end
 
   context 'with fix enabled' do
@@ -109,5 +173,37 @@ describe 'file_mode' do
         expect(manifest).to eq(code)
       end
     end
+
+    context '3 digit concat mode' do
+      let(:code) { "concat { 'foo': mode => '777' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(25)
+      end
+
+      it 'should zero pad the concat mode' do
+        expect(manifest).to eq("concat { 'foo': mode => '0777' }")
+      end
+    end
+
+    context 'concat mode undef quoted' do
+      let(:code) { "concat { 'foo': mode => 'undef' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(25)
+      end
+
+      it 'should not modify the original manifest' do
+        expect(manifest).to eq(code)
+      end
+    end
   end
 end

data/spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb

@@ -15,6 +15,18 @@ describe 'unquoted_file_mode' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(23)
       end
     end
+
+    context '4 digit unquoted file mode' do
+      let(:code) { "concat { 'foo': mode => 0777 }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(25)
+      end
+    end
   end
 
   context 'with fix enabled' do
@@ -41,5 +53,21 @@ describe 'unquoted_file_mode' do
         expect(manifest).to eq("file { 'foo': mode => '0777' }")
       end
     end
+
+    context '4 digit unquoted file mode w/fix' do
+      let(:code) { "concat { 'foo': mode => 0777 }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(25)
+      end
+
+      it 'should single quote the file mode' do
+        expect(manifest).to eq("concat { 'foo': mode => '0777' }")
+      end
+    end
   end
 end

data/spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -39,10 +39,10 @@ describe 'variables_not_enclosed' do
     end
 
     context 'variable not enclosed in {}' do
-      let(:code) { '" $gronk"' }
+      let(:code) { '" $gronk-$grouik"' }
 
       it 'should only detect a single problem' do
-        expect(problems).to have(1).problem
+        expect(problems).to have(2).problem
       end
 
       it 'should fix the manifest' do
@@ -50,7 +50,7 @@ describe 'variables_not_enclosed' do
       end
 
       it 'should enclose the variable in braces' do
-        expect(manifest).to eq('" ${gronk}"')
+        expect(manifest).to eq('" ${gronk}-${grouik}"')
       end
     end
 

data/spec/puppet-lint/plugins/check_variables/variable_is_lowercase_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe 'variable_is_lowercase' do
+  let(:msg) { 'variable contains an uppercase letter' }
+
+  context 'a variable containing an uppercase letter' do
+    let(:code) { '$fooBar' }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+  
+    it 'should create a warning' do
+      expect(problems).to contain_warning(msg).on_line(1).in_column(1)
+    end
+  end
+
+  context 'a variable containing only lowercase letters' do
+    let(:code) { '$foobar' }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb

@@ -0,0 +1,71 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe '80chars' do
+  before do
+    PuppetLint.configuration.send("enable_80chars")
+  end
+
+  let(:msg) { 'line has more than 80 characters' }
+
+  context 'file resource with a source line > 80c' do
+    let(:code) { "
+      file {
+        source  => 'puppet:///modules/certificates/etc/ssl/private/wildcard.example.com.crt',
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'file resource with a template line > 80c' do
+    let(:code) { "
+      file {
+        content => template('mymodule/this/is/a/truely/absurdly/long/path/that/should/make/you/feel/bad'),
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'length of lines with UTF-8 characters' do
+    let(:code) { "
+      # ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
+      # ┃          Configuration           ┃
+      # ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context '81 character line' do
+    let(:code) { 'a' * 81 }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create a warning' do
+      expect(problems).to contain_warning(msg).on_line(1).in_column(80)
+    end
+  end
+
+# TODO: figure out why rspec keeps enabling this check!
+#
+#   context '81 character line with disabled check' do
+#     let(:code) { 'a' * 81 }
+#
+#     PuppetLint.configuration.send("disable_80chars")
+#
+#     it 'should not detect any problems' do
+#       expect(problems).to have(0).problem
+#     end
+#   end
+
+end

data/spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'arrow_alignment' do
-  let(:msg) { 'indentation of => is not properly aligned' }
+  let(:msg) { 'indentation of => is not properly aligned (expected in column %d, but found it in column %d)' }
 
   context 'with fix disabled' do
     context 'selectors inside a resource' do
@@ -119,10 +119,10 @@ describe 'arrow_alignment' do
       end
 
       it 'should create four warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(15)
-        expect(problems).to contain_warning(msg).on_line(4).in_column(15)
-        expect(problems).to contain_warning(msg).on_line(6).in_column(16)
-        expect(problems).to contain_warning(msg).on_line(7).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(3).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(4).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,16)).on_line(6).in_column(16)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(7).in_column(15)
       end
     end
 
@@ -142,10 +142,10 @@ describe 'arrow_alignment' do
       end
 
       it 'should create four warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(15)
-        expect(problems).to contain_warning(msg).on_line(4).in_column(15)
-        expect(problems).to contain_warning(msg).on_line(6).in_column(16)
-        expect(problems).to contain_warning(msg).on_line(7).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(3).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(4).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,17,16)).on_line(6).in_column(16)
+        expect(problems).to contain_warning(sprintf(msg,17,15)).on_line(7).in_column(15)
       end
     end
     context 'complex resource with a misaligned =>' do
@@ -166,9 +166,9 @@ describe 'arrow_alignment' do
       end
 
       it 'should create three warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(15)
-        expect(problems).to contain_warning(msg).on_line(6).in_column(17)
-        expect(problems).to contain_warning(msg).on_line(9).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,16,15)).on_line(3).in_column(15)
+        expect(problems).to contain_warning(sprintf(msg,19,17)).on_line(6).in_column(17)
+        expect(problems).to contain_warning(sprintf(msg,16,15)).on_line(9).in_column(15)
       end
     end
 
@@ -189,7 +189,7 @@ describe 'arrow_alignment' do
       end
 
       it 'should create a warning' do
-        expect(problems).to contain_warning(msg).on_line(8).in_column(17)
+        expect(problems).to contain_warning(sprintf(msg,19,17)).on_line(8).in_column(17)
       end
     end
 
@@ -214,10 +214,10 @@ describe 'arrow_alignment' do
       end
 
       it 'should create a warning' do
-        expect(problems).to contain_warning(msg).on_line(5).in_column(19)
-        expect(problems).to contain_warning(msg).on_line(6).in_column(18)
-        expect(problems).to contain_warning(msg).on_line(11).in_column(19)
-        expect(problems).to contain_warning(msg).on_line(12).in_column(18)
+        expect(problems).to contain_warning(sprintf(msg,20,19)).on_line(5).in_column(19)
+        expect(problems).to contain_warning(sprintf(msg,20,18)).on_line(6).in_column(18)
+        expect(problems).to contain_warning(sprintf(msg,20,19)).on_line(11).in_column(19)
+        expect(problems).to contain_warning(sprintf(msg,20,18)).on_line(12).in_column(18)
       end
     end
 
@@ -282,8 +282,8 @@ describe 'arrow_alignment' do
       end
 
       it 'should create 2 warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(19)
-        expect(problems).to contain_warning(msg).on_line(4).in_column(19)
+        expect(problems).to contain_warning(sprintf(msg,18,19)).on_line(3).in_column(19)
+        expect(problems).to contain_warning(sprintf(msg,18,19)).on_line(4).in_column(19)
       end
     end
 
@@ -314,8 +314,8 @@ describe 'arrow_alignment' do
       end
 
       it 'should create 2 warnings' do
-        expect(problems).to contain_warning(msg).on_line(3).in_column(13)
-        expect(problems).to contain_warning(msg).on_line(3).in_column(26)
+        expect(problems).to contain_warning(sprintf(msg,15,13)).on_line(3).in_column(13)
+        expect(problems).to contain_warning(sprintf(msg,15,26)).on_line(3).in_column(26)
       end
     end
 
@@ -368,10 +368,10 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix the manifest' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(15)
-        expect(problems).to contain_fixed(msg).on_line(4).in_column(15)
-        expect(problems).to contain_fixed(msg).on_line(6).in_column(16)
-        expect(problems).to contain_fixed(msg).on_line(7).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,17,15)).on_line(3).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,17,15)).on_line(4).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,17,16)).on_line(6).in_column(16)
+        expect(problems).to contain_fixed(sprintf(msg,17,15)).on_line(7).in_column(15)
       end
 
       it 'should align the arrows' do
@@ -408,9 +408,9 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix the manifest' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(15)
-        expect(problems).to contain_fixed(msg).on_line(6).in_column(17)
-        expect(problems).to contain_fixed(msg).on_line(9).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,16,15)).on_line(3).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,19,17)).on_line(6).in_column(17)
+        expect(problems).to contain_fixed(sprintf(msg,16,15)).on_line(9).in_column(15)
       end
 
       it 'should align the arrows' do
@@ -445,7 +445,7 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix the manifest' do
-        expect(problems).to contain_fixed(msg).on_line(8).in_column(17)
+        expect(problems).to contain_fixed(sprintf(msg,19,17)).on_line(8).in_column(17)
       end
 
       it 'should align the arrows' do
@@ -473,8 +473,8 @@ describe 'arrow_alignment' do
       end
 
       it 'should create 2 warnings' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(19)
-        expect(problems).to contain_fixed(msg).on_line(4).in_column(19)
+        expect(problems).to contain_fixed(sprintf(msg,18,19)).on_line(3).in_column(19)
+        expect(problems).to contain_fixed(sprintf(msg,18,19)).on_line(4).in_column(19)
       end
 
       it 'should realign the arrows with the minimum whitespace' do
@@ -502,7 +502,7 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix the problem' do
-        expect(problems).to contain_fixed(msg).on_line(4).in_column(17)
+        expect(problems).to contain_fixed(sprintf(msg,18,17)).on_line(4).in_column(17)
       end
 
       it 'should add whitespace between the param and the arrow' do
@@ -531,8 +531,8 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix 2 problems' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(13)
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(26)
+        expect(problems).to contain_fixed(sprintf(msg,15,13)).on_line(3).in_column(13)
+        expect(problems).to contain_fixed(sprintf(msg,15,26)).on_line(3).in_column(26)
       end
 
       it 'should move the extra param onto its own line and realign' do
@@ -561,9 +561,9 @@ describe 'arrow_alignment' do
       end
 
       it 'should fix 2 problems' do
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(13)
-        expect(problems).to contain_fixed(msg).on_line(3).in_column(29)
-        expect(problems).to contain_fixed(msg).on_line(4).in_column(15)
+        expect(problems).to contain_fixed(sprintf(msg,17,13)).on_line(3).in_column(13)
+        expect(problems).to contain_fixed(sprintf(msg,17,29)).on_line(3).in_column(29)
+        expect(problems).to contain_fixed(sprintf(msg,17,15)).on_line(4).in_column(15)
       end
 
       it 'should move the extra param onto its own line and realign' do